Page MenuHomePhabricator
Feed Advanced Search

Mar 11 2015

Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTf1221f35582b: Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage…
Mar 11 2015, 6:16 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTd81de9e75b69: Updated mediawiki/extensions Project: mediawiki/extensions/ApiSandbox… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/ApiSandbox…
Mar 11 2015, 6:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTa16891e83434: Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage…
Mar 11 2015, 6:14 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT477c27d8b293: Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage…
Mar 11 2015, 6:08 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTfe87f2f1bf35: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Thanks…
Mar 11 2015, 6:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTebfb3bed9d8b: Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage…
Mar 11 2015, 6:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT2babfc443c9e: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Thanks…
Mar 11 2015, 6:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTd0df17392887: Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage…
Mar 11 2015, 6:06 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT885323f51d93: Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage…
Mar 11 2015, 6:06 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTd72adf1ebb27: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Thanks…
Mar 11 2015, 6:06 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT7f046f868c25: Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/MassMessage…
Mar 11 2015, 6:05 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTe835e6d90b0a: Updated mediawiki/extensions Project: mediawiki/extensions/PageImages… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/PageImages…
Mar 11 2015, 6:05 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT26a8f35b9288: Updated mediawiki/extensions Project: mediawiki/extensions/Flow… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
Mar 11 2015, 6:05 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT95cb61036ca9: Updated mediawiki/extensions Project: mediawiki/extensions/Flow… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
Mar 11 2015, 6:04 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT34e63084713b: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Thanks…
Mar 11 2015, 6:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT9307b13b4a17: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Thanks…
Mar 11 2015, 6:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT9832c4c6467a: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Thanks…
Mar 11 2015, 5:59 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTf1ab33b850d8: Updated mediawiki/extensions Project: mediawiki/extensions/Flow… (authored by wctaiwan).
Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
Mar 11 2015, 5:57 AM

Mar 5 2015

wctaiwan added a comment to T18691: RFC: Section header "share" link.

A user at ru.wp wonders whether clicking on the icon could directly copy the link to the clipboard.

Mar 5 2015, 6:09 PM · Tech Ambassadors & Translators, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-User-Interface

Mar 4 2015

wctaiwan added a comment to T89690: Longer Maniphest tasks not fully displayed (as Phabricator defines a result set limit as 100 rows).

Does this fix the issue where clicking "Show older changes" doesn't show all of them? The upstream bug doesn't seem to make this clear.

Mar 4 2015, 9:20 PM · Upstream, Phabricator (Upstream)

Mar 3 2015

wctaiwan committed rMWVAc939d9f5e43a: Use 'git pull' for non-SSH URLs in run-git-update.
Use 'git pull' for non-SSH URLs in run-git-update
Mar 3 2015, 7:46 PM

Mar 2 2015

wctaiwan updated the task description for T13555: .mw-editsection links should not be part of the <h#> element.
Mar 2 2015, 4:24 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
wctaiwan updated the task description for T13555: .mw-editsection links should not be part of the <h#> element.
Mar 2 2015, 4:12 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
wctaiwan raised the priority of T13555: .mw-editsection links should not be part of the <h#> element from Lowest to Medium.

I don't think accessibility issues should have "lowest" priority. Even if no one is willing to commit to working on this, it is something we should try to fix sooner rather than later.

Mar 2 2015, 4:01 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
wctaiwan closed T91010: Rename "Unbreak Now!" priority as Declined.

Consensus seems to be that it's fine as it is.

Mar 2 2015, 12:14 AM · Phabricator

Mar 1 2015

wctaiwan added a comment to T89719: Default article links should be language neutral.

What is the advantage here, exactly? If you're using a localised interface, wouldn't the links be pointing to non-English articles anyway?

Mar 1 2015, 10:52 PM · Patch-Needs-Improvement, I18n, WikimediaMessages
wctaiwan added a comment to rMW33cfd0bc4a5f: Slightly increase wikitable padding.

If this is so bad that it can't be fixed for individual tables (and I'm not convinced it is--Imzadi1979's link looks fine to me, and would inevitably have line breaks at smaller resolutions even without the padding change, anyway), please just add an override in common.css on wikis that don't want this change, rather than reverting this. The new value is better where the table isn't absolutely packed, and wikis without such a large body of existing tables would benefit from it.

Mar 1 2015, 7:36 PM

Feb 27 2015

wctaiwan added a comment to T91010: Rename "Unbreak Now!" priority.

Would "urgent" be sufficient to convey the sense of urgency?

Feb 27 2015, 5:21 PM · Phabricator
wctaiwan added a comment to T78617: Decide on "Needs Volunteer" Priority field value in Phabricator.

I've filed T91010 to discuss renaming "Unbreak Now!"

Feb 27 2015, 5:08 PM · Patch-For-Review, patch-welcome, Phabricator
wctaiwan added a comment to rMW33cfd0bc4a5f: Slightly increase wikitable padding.

I think it's a better idea to fix broken templates as we see them than to revert this patch, at least for the horizontal padding.

Feb 27 2015, 1:21 AM
wctaiwan created T91010: Rename "Unbreak Now!" priority.
Feb 27 2015, 1:12 AM · Phabricator

Feb 26 2015

wctaiwan added a comment to T90611: Special:UserProfile has unclosed div which destroy the page view.

This seems to happen on dewiki, but not on enwiki, meta or zhwiki.

Feb 26 2015, 6:49 AM · MobileFrontend-Feature-requests

Feb 20 2015

wctaiwan added a comment to T18691: RFC: Section header "share" link.

Please see T90091 for discussions on the design of this feature.

Feb 20 2015, 6:46 AM · Tech Ambassadors & Translators, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-User-Interface
wctaiwan added a comment to T90091: Improve the UX of section anchor links.

Currently, the anchors are revealed when the user mouses over the full-width horizontal strip occupied by the section header. This is problematic for two reasons:

Feb 20 2015, 6:40 AM · Design, MediaWiki-User-Interface
wctaiwan created T90091: Improve the UX of section anchor links.
Feb 20 2015, 6:33 AM · Design, MediaWiki-User-Interface

Feb 19 2015

wctaiwan committed rEGUP865b60d97d4b: Add top margin to notice.
Add top margin to notice
Feb 19 2015, 6:59 AM

Feb 18 2015

wctaiwan created T89791: Update migration information on Phabricator front page.
Feb 18 2015, 3:37 AM · Phabricator

Feb 17 2015

wctaiwan committed rMW1147690eb18d: Improve title text in jquery.confirmable.
Improve title text in jquery.confirmable
Feb 17 2015, 1:40 PM

Feb 16 2015

wctaiwan added a comment to T89572: In Thanks confirmation, "No" choice title text should not say "Send a thank you notification to this user".

Sorry, I just noticed I was CC'd, figured it was a quick one line patch and didn't see that it was assigned. I'll be more careful in the future.

Feb 16 2015, 6:13 AM · Patch-For-Review, MediaWiki-User-Interface, Thanks

Feb 15 2015

wctaiwan added a comment to T89572: In Thanks confirmation, "No" choice title text should not say "Send a thank you notification to this user".

I'm inclined to just make it so that jquery.confirmable doesn't include title text for the default yes / no buttons, since I can't think of a scenario in which it'd be desirable for the "no" action to inherit the title text. This shouldn't result in accessibility issues, given the button label is descriptive.

Feb 15 2015, 10:00 PM · Patch-For-Review, MediaWiki-User-Interface, Thanks

Feb 9 2015

wctaiwan committed rEMAMc57ebe2e4c9e: Add extension.json (authored by Legoktm).
Add extension.json
Feb 9 2015, 5:34 AM

Feb 6 2015

wctaiwan created T88779: Show edit notice when creating local user page.
Feb 6 2015, 7:22 AM · Patch-For-Review, GlobalUserPage

Jan 29 2015

wctaiwan created T88006: Deprecate and Remove $wgContentHandlerUseDB.
Jan 29 2015, 7:39 PM · Technical-Debt (Deprecation process), MediaWiki-ContentHandler
wctaiwan committed rEMAM7b3a586491e7: Make validation errors look consistent.
Make validation errors look consistent
Jan 29 2015, 6:48 PM

Jan 27 2015

wctaiwan committed rEMAM2e324465b154: MWException -> Exception (authored by ori).
MWException -> Exception
Jan 27 2015, 8:08 PM

Jan 23 2015

wctaiwan added a comment to M15: Error pages mocks.

I think putting a donation link on the error page is pretty inappropriate as it misleads the reader into thinking donating will directly contribute to fixing the issue, whereas in most instances insignificant down times are inevitable and quickly correctable, with very little relation to funding.

Jan 23 2015, 7:41 PM · Design

Jan 17 2015

wctaiwan closed T76654: Special:CreateMassMessageList should check for "editcontentmodel" permission to display a nicer error as Resolved.

Thanks for the patch.

Jan 17 2015, 11:32 PM · Patch-For-Review, good first task, MassMessage
wctaiwan added a comment to T87101: MassMessage use deprecated getJsonData.
Jan 17 2015, 11:06 PM · Patch-For-Review, MassMessage
wctaiwan closed T87101: MassMessage use deprecated getJsonData as Resolved.

Fixed in https://gerrit.wikimedia.org/r/#/c/184117/

Jan 17 2015, 11:05 PM · Patch-For-Review, MassMessage
wctaiwan committed rEMAM8791026a2dfc: Special:CreateMassMessageList should check for "editcontentmodel" permission (authored by 01tonythomas).
Special:CreateMassMessageList should check for "editcontentmodel" permission
Jan 17 2015, 8:02 PM
wctaiwan committed rEMAM5550f376c058: Use getData() instead of getJsonData().
Use getData() instead of getJsonData()
Jan 17 2015, 7:56 PM
wctaiwan committed rEMAM05b8584956b7: Fix sending when $wgEmailConfirmToEdit is true.
Fix sending when $wgEmailConfirmToEdit is true
Jan 17 2015, 5:42 AM
wctaiwan closed T75061: Sending a message fails when $wgEmailConfirmToEdit is true as Resolved.
Jan 17 2015, 5:42 AM · Patch-For-Review, MassMessage

Jan 10 2015

wctaiwan committed rMWa90b4c580993: Let subclasses specify content model in JsonContent.
Let subclasses specify content model in JsonContent
Jan 10 2015, 5:24 AM

Jan 2 2015

wctaiwan committed rEPDQ5b0cff8ebf95: Fix embed URL.
Fix embed URL
Jan 2 2015, 5:21 PM

Dec 31 2014

wctaiwan closed T85580: docs/contenthandler.txt should be updated to include JSON as Resolved.
Dec 31 2014, 1:49 AM · Patch-For-Review, MediaWiki-Documentation
wctaiwan committed rMW8e78387b5555: Add JSON to docs/contenthandler.txt.
Add JSON to docs/contenthandler.txt
Dec 31 2014, 1:48 AM
wctaiwan updated the task description for T85580: docs/contenthandler.txt should be updated to include JSON.
Dec 31 2014, 1:15 AM · Patch-For-Review, MediaWiki-Documentation
wctaiwan created T85580: docs/contenthandler.txt should be updated to include JSON.
Dec 31 2014, 1:14 AM · Patch-For-Review, MediaWiki-Documentation

Dec 23 2014

wctaiwan updated the task description for T85241: Login form checkbox labels wind up with too much line spacing when spanning multiple lines.
Dec 23 2014, 8:22 PM · Design, Patch-For-Review, MediaWiki-User-login-and-signup
wctaiwan updated the task description for T85241: Login form checkbox labels wind up with too much line spacing when spanning multiple lines.
Dec 23 2014, 8:19 PM · Design, Patch-For-Review, MediaWiki-User-login-and-signup

Dec 21 2014

wctaiwan committed rEGAEe25290ffaca7: Rename Hooks.php.
Rename Hooks.php
Dec 21 2014, 12:29 AM

Dec 13 2014

wctaiwan closed T67180: Only mark MassMessage edits as a bot in User talk namespace as Resolved.
Dec 13 2014, 9:32 PM · Patch-For-Review, Google-Code-in-2014, good first task, MassMessage

Dec 11 2014

wctaiwan awarded T56307: Watchlist icon does not match on desktop and mobile skin a Heartbreak token.
Dec 11 2014, 6:46 AM · Vector (legacy skin), Google-Code-in-2014, Design

Dec 10 2014

wctaiwan committed rETHAc1e4c568ccf3: Use jquery.confirmable instead of jquery.ui.dialog (authored by Legoktm).
Use jquery.confirmable instead of jquery.ui.dialog
Dec 10 2014, 6:18 PM
wctaiwan committed rETHA0e0ef33ea335: Bind Flow Thank click detection to .flow-container.
Bind Flow Thank click detection to .flow-container
Dec 10 2014, 6:18 PM
wctaiwan committed rETHA9a709e61b355: Refactor API code and fix invalid input handling.
Refactor API code and fix invalid input handling
Dec 10 2014, 6:18 PM
wctaiwan committed rEMAM96b59e047f09: Fix sending when $wgEmailConfirmToEdit is true.
Fix sending when $wgEmailConfirmToEdit is true
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM3347038cf2f2: Hide EditMassMessageList in Special:SpecialPages.
Hide EditMassMessageList in Special:SpecialPages
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM186b2d4c6230: Fix inaccurate comment and indentation.
Fix inaccurate comment and indentation
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM8d18ab818210: Strip signatures for Flow and LQT.
Strip signatures for Flow and LQT
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMacbb2d393360: Use __DIR__ directly.
Use __DIR__ directly
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMfcc5ef3070f9: Make MassMessageJob methods protected.
Make MassMessageJob methods protected
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM0ac8b21ccf06: Don't require context for MassMessage::submit() (authored by Legoktm).
Don't require context for MassMessage::submit()
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMfff792adcf48: Override TextContentHandler::getContentClass() (authored by Legoktm).
Override TextContentHandler::getContentClass()
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMad977feeac15: Output the number of recipients on preview.
Output the number of recipients on preview
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMceb914b62c8b: Clean up SpecialMassMessage.
Clean up SpecialMassMessage
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMa3098d4671ef: Fix determination of $revId.
Fix determination of $revId
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMa27d844953c0: Reject empty lists or cats as import sources.
Reject empty lists or cats as import sources
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM5fac5cea6af1: Improve title checking in extractTarget.
Improve title checking in extractTarget
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM288b5acdc39e: Refactor ApiEditMassMessageList::getEditSummary() (authored by Legoktm).
Refactor ApiEditMassMessageList::getEditSummary()
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM94ff44714022: Remove manual resets of mContentModel.
Remove manual resets of mContentModel
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM226451108f82: Fix whitespace.
Fix whitespace
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM26804cfacfe3: Add parser cache support to MassMessageListContent (authored by Legoktm).
Add parser cache support to MassMessageListContent
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM7030deb608a4: Unit tests.
Unit tests
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMb97594b09ef9: Add test cases for extractTarget.
Add test cases for extractTarget
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMb48dfc482905: Disable ContentHandler features if $wgContentHandlerUseDB = false (authored by Legoktm).
Disable ContentHandler features if $wgContentHandlerUseDB = false
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMa3ae5087cc06: Add tests to Database group.
Add tests to Database group
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMc43208288b35: Update token handling for core API change (authored by Anomie).
Update token handling for core API change
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM9036ee2524b4: Fix MassMessage::getMessengerUser() after Password API changes (authored by Legoktm).
Fix MassMessage::getMessengerUser() after Password API changes
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMf9cdd20012de: Allow valid lists to contain invalid sites.
Allow valid lists to contain invalid sites
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM693c86297b96: Subclass JSONContent.
Subclass JSONContent
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM2af7e1bb1ab3: Improve edit summaries.
Improve edit summaries
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM6940fdc94c27: Use jquery.confirmable for remove links.
Use jquery.confirmable for remove links
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM752957e090ca: Escape invalid target strings in message.
Escape invalid target strings in message
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM291e9723c2a0: More readable diff.
More readable diff
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMfd2fc0d9ad2e: Fix creation edit summary.
Fix creation edit summary
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAMd3427b5049e1: Improve Special:EditMassMessageList.
Improve Special:EditMassMessageList
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM23cf2558fd4a: Use addBacklinkSubtitle.
Use addBacklinkSubtitle
Dec 10 2014, 5:15 PM
wctaiwan committed rEMAM69407f0b639b: Move Add pages and add tracking category.
Move Add pages and add tracking category
Dec 10 2014, 5:15 PM