I would suggest following @Tchanders testing steps for QA, which means that this ticket can only be QA'd on a local wiki. I've checked the betawikis and it seems that no log was made for the GlobalBlocking extension before 2012, so betawikis cannot be used to test this.

Furthermore, some log entries pre-2010 have flags for the gblock type. For example:

+--------+----------+------------+----------------+---------------+---------------------------------+----------------+---------------------------+-------------+-----------+----------+
| log_id | log_type | log_action | log_timestamp  | log_namespace | log_title                       | log_comment_id | log_params                | log_deleted | log_actor | log_page |
+--------+----------+------------+----------------+---------------+---------------------------------+----------------+---------------------------+-------------+-----------+----------+
| 183748 | gblblock | gblock     | 20080821202044 |            -1 | Contributions/151.9.110.20      |        3593591 | 10 minutes
anon-only      |           0 |       696 |     NULL |
+--------+----------+------------+----------------+---------------+---------------------------------+----------------+---------------------------+-------------+-----------+----------+

There are also entries on enwiki and on metawiki. On metawiki there are 755 of these entries.

In T360621#9713336, @dom_walden wrote:

• However, if a non-broken entry also exists alongside the broken entries for the same globally blocked user, nothing will happen (i.e. duplicates won't be deleted, even with --delete flag). For example:

globalblocks:

gb_id	gb_address
3	Foobar

global_block_whitelist:

gbw_id	gbw_address
2	Foobar
3	Foobar

After running script (even with --delete flag):
global_block_whitelist:

gbw_id	gbw_address
2	Foobar
3	Foobar

Marking this as open again because I have an example of this.

@hashar Example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1018767

My suggestion for testing this is to suppress a variety of information for log events and then try to see if any of it is shown in Special:CheckUser, in a similar vein to T326867.

Declining in favour of T329493.

In favour of doing T362548.

In favour of doing T362548.

In favour of doing T362548.

For QA I would suggest checking that Special:Investigate and Special:InvestigateBlock still work, and that a link from Special:CheckUser to Special:Investigate still exists that says Try out Special:Investigate.

For QA please check that temporary accounts on beta wikis still works as expected. For example:

1. The format for temporary account usernames is ~YYYY-X, where X is an integer and YYYY is the current year
2. Users which start with ~2 or * are marked as temporary users.

No easy way to QA this. QA of the offset feature was done in T353545: Allow plain-numeric serial mapping to avoid conflicts when generating temp user names, so it should be okay to skip QA on this change.

Blocked on T362152

@matmarex, thanks for dealing with the renaming duplications.

I've updated:

1. https://translatewiki.net/wiki/MediaWiki:Logeventslist-review-log/fr to use the same text as https://translatewiki.net/wiki/MediaWiki:Review-logpage/fr to avoid the frwikinews issue
2. https://translatewiki.net/wiki/MediaWiki:Logeventslist-review-log/es to use the same text as https://translatewiki.net/wiki/MediaWiki:Review-logpage/es to avoid the eswikinews issue

Done for all interfaces other than Special:Investigate (support for which is being added in the short term).

Done via T330158.

Going to mark this as resolved, given that the test coverage is nearly full based on https://doc.wikimedia.org/cover-extensions/CheckUser/src/Hooks.php.html

Solved by T361296.