Fri, Sep 25
Thu, Sep 24
Fri, Sep 18
Tue, Sep 8
Thu, Sep 3
I appreciate the response @Pablo-WMDE. My questioning came from not wanting to over-complicate the solution, and making sure docker-compose was the appropriate tool for our use case. But I agree with what you said, developing locally through a UI (storybook) and doing the project build is beneficial. I will move ahead with docker-compose, thank you!
Wed, Sep 2
I had a general question around the use of docker-compose in the vuejs-components project. (From my understanding) docker-compose is useful when you need multiple docker containers running together, but in the case of your project I was wondering if the same thing could be accomplished with a single container, by just using a Dockerfile? In the docker-compose.yml for example, it looks like the node service is mounting some volumes and storybook service is actually getting the storybook service running on port 3003. How come 2 containers are needed in this case? And would it be bad practice to combine them both in a single container?
Hi @darthmon_wmde, I didn't have too many crazy questions just a couple general ones about how it is configured. We could do async or sync conversation about it if anyone on the team would be willing to help me out!
Mon, Aug 31
Aug 26 2020
thanks for clarifying @Volker_E !
Is there a particular directory anyone thinks the repo should live under in gerrit? or should this be a top-level repo just named wvui?
Aug 24 2020
but it was dismissed because we wanted to keep MWServices->getMessageFormatter to return the IMessageFormatterFactory interface, not the MW implementation.
Aug 19 2020
Will re-post this comment here as it is relevant to this ticket specifically!
Aug 18 2020
Aug 13 2020
Can use these existing schemas as a reference to codify and enforce uniformity among the endpoints
Aug 10 2020
ChangeTags::tagShortDescriptionMessage() gives us the description of the tag though, rather than the html or wikitext pointing to the tag page (https://en.wikipedia.org/wiki/MediaWiki:Tag-AWB) like I think @EvanProdromou wanted in https://phabricator.wikimedia.org/T235073#6337164?
The way that ChangeTags::formatSummaryRow() spits out the html is like: Tags: mw-revert, mobile edit. So do we want to remove Tags from the html output altogether so each tag is formatted on its own?
Additionally, just want to clarify (because im not sure the use case): Is the HTML intended to be used for showing all the tags for a given contribution? If so, just clarifying we should just have one appearance_source property (however it ends up being named), instead of each tag object having appearance_source. That way we show all the tags in one html element.
What do you think about s/appearance/display? Analogous to T259547 ?
Apologies everyone for being the one to merge that in and block CI. It was a big miss on my end. I had needed the fake timestamp (still should definitely not have been in the data provider to begin with). But around the same time another patch was merged that caused me not to need the faketimestamp (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/616120) so removing it is definitely the better solution of the two. Thank you very much for catching it and working to merge in the fix, I hadn't seen this until Petr +2ed the fix patch.
Aug 6 2020
@eprodromou To validate the fact that contributions included in the endpoints are only mediawiki revisions, I made some edits to beta as an anon user.
Aug 5 2020
Jul 30 2020
@eprodromou Do you have any objection to me renaming the 'name' path param to 'user'? It makes more sense with how the backend is refactored now, but from an end user perspective I think it also makes more sense for the case of passing in an ip address, as thats more of a 'user' than a name.
Jul 29 2020
Jul 24 2020
Jul 22 2020
wow ok your due diligence has uncovered that yes I think we just forgot to implement that one....theres no route for it and the user in UserContributionsCount defaults to "me". @daniel I can work on that one now. It shouldn't take too long.
@apaskulin Users (i think only admins) can create custom tags. I believe a fresh install of mediawiki comes with no predefined tags, but there might be some jobs or something that create standard tags (because i see a few that pop up when I run the integration tests and look at what tags are stored in the database)
Jul 21 2020
Jul 20 2020
Jul 17 2020
@daniel I think I need to go through and rename more things to 'contribution' e.g. ContributionSegment->getRevisions() to ContributionsSegment->getContributions () yea?
Jul 15 2020
Jul 14 2020
Jul 13 2020
Jul 1 2020
Jun 30 2020
Jun 24 2020
Jun 18 2020
Jun 16 2020
Just adding a quick note, that cpt has moved some mediawiki REST endpoints from /v0 namespace into /v1 (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/604441). This shouldn't be a problem but just making a note of it.
Jun 12 2020
Jun 11 2020
Jun 10 2020
Jun 8 2020
@Naike This is being worked on by Daniel and I, I have added an assignee :)
Jun 5 2020
@Pppery absolutely :)
@Naike Woops - added assignee. Daniel and I are working on this at the moment (But it only lets me add one user)