Today I met with @Peter to talk about the steps remaining for this ticket. Peter was very helpful and now we have a really cool dashboard thanks to him!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 23 2021
Feb 22 2021
@ovasileva Thank you. I agree that it should not be a blocker for deployment
Feb 19 2021
Okay, I've looked into this more and made a POC. The POC was worthwhile as it exposed several gotchas that make this ticket not so trivial:
Feb 18 2021
Sorry for the delay on this. I'm planning on looking into this more today
Feb 16 2021
Feb 11 2021
@phuedx Thank you. The rest of your posts made sense to me and were well articulated. Please consider this a "+2" from me 😀
Feb 10 2021
Thank you @phuedx for the great detailed notes!
Feb 9 2021
Sorry, I ran out of time to look at this today. Will plan on reviewing tomorrow
Feb 8 2021
Feb 5 2021
Feb 3 2021
Feb 2 2021
Feb 1 2021
moving to signoff after talking to @ovasileva in standup today (qa will be done in T259798)
thanks @Jdlrobson !
Jan 28 2021
@alexhollender You might also be interested in looking at the search with thumbnails disabled as well: https://patchdemo.wmflabs.org/wikis/9ed1c233860587aa138e8a652fbf5e63/w/index.php/Main_Page
Jan 27 2021
I will write QA steps soon
\o/
Patches for review:
Jan 26 2021
Jan 25 2021
Jan 22 2021
Patches for review:
Thank you @alexhollender and no problem 😃 I just wanted to make sure the code to support A was deliberate and preferred.
How will we create the button? mw-ui-button ? wvui styles ? other?
Jan 21 2021
Jan 20 2021
Assuming thumbnails are enabled, how important is it to you to have the input expand immediately on first focus before WVUI loads vs. having the input expand after WVUI loads? As an example, please compare these two patchdemos:
In T231168#6763424, @Jdlrobson wrote:Here's the HTML leading up to 1st paragraph for French Wikipedia
html74 KBDownloadcat html | gzip -7 -c | wc -c yields 17829
Patch for review is at https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/656504 which makes the input NOT expand (and before WVUI loads) if the search configuration has thumbnails disabled
Jan 19 2021
@alexhollender You can check it out at https://patchdemo.wmflabs.org/wikis/6d3f20204dd32341b2b79dfedfcab632/w/index.php/Main_Page
Jan 15 2021
This is a 2 line change so I've put it in code review
@alexhollender your blockers should be addressed now in https://patchdemo.wmflabs.org/wikis/55796de21ed353df22c9ce80a17539af/w/index.php/Main_Page . Please double check to see if you have any remaining blockers
Jan 13 2021
Removing the tooltip would require more than a CSS change and at that point we might as well make the magnifying glass button not be a button (but that should be done in its own ticket)
- remove tooltip over magnifying glass icon
text should say "Search for pages containing [x]", currently it says "containing [x]" -- *where are we at with this?
Jan 12 2021
@alexhollender I made a patchdemo yesterday that includes the latest WVUI work and latest Vector work except for 1 patch that will increase the search input width to 500px (as shown in the spec):
Jan 7 2021
All WVUI changes have been merged (thanks @Jdrewniak!). The remaining patches to review are small patches in Vector:
Jan 6 2021
Jan 5 2021
Dec 22 2020
The following patches are ready for review: