Page MenuHomePhabricator
Feed Advanced Search

Wed, Oct 9

MGChecker awarded T117736: Convert Special:Contributions to OOUI a Dislike token.
Wed, Oct 9, 6:42 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-notice, MediaWiki-Special-pages, User-Jdlrobson, UI-Standardization-Kanban, UI-Standardization

Tue, Oct 8

Florian added a comment to T234632: Wikimedia Technical Conference 2019 Session: Local development environment - MediaWiki core.

yes, I think it should focus on looking at the existing methods and not new ones, since there doesn't seem to be a lack of the former :)

Tue, Oct 8, 9:56 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
abian awarded T117736: Convert Special:Contributions to OOUI a Like token.
Tue, Oct 8, 3:19 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-notice, MediaWiki-Special-pages, User-Jdlrobson, UI-Standardization-Kanban, UI-Standardization

Fri, Oct 4

Florian awarded T234639: Wikimedia Technical Conference 2019 Session: WMF CI 2.0: Status and future a Love token.
Fri, Oct 4, 9:23 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
Florian added a comment to T234632: Wikimedia Technical Conference 2019 Session: Local development environment - MediaWiki core.

Actually I really like this idea for a session, it's kind of hard for a newcomer to actually being able to "see the wiki running", even if they did not even start with all the possible services we provide on top of MediaWiki core. I would, however, propose to keep the focus of this to a specific area in the beginning, probably MediaWiki core, as this is something most people will most likely run into, otherwise it could be an endless discussion?

Fri, Oct 4, 9:17 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
Florian added a comment to T234635: Wikimedia Technical Conference 2019 Session: System level testing: patterns and anti-patterns with Selenium.

What is the expected outcome of this session, is it mainly focussed on getting people, who are not familiar with our "system test level" to give an overview, so that they can provide valuable feedback, ideas and concerns in the session building on top of that?
Or is this session focussed on finding patterns and anti-patterns we're using or utilizing at the moment in order to try to have detailed focus-areas where we can invest time to imrprove and hopefully get rid of used anti-patterns?

Fri, Oct 4, 9:12 PM · Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO (201910), User-zeljkofilipin, User-greg, International-Developer-Events, Wikimedia-Technical-Conference-2019

Mon, Sep 30

Pppery awarded T117736: Convert Special:Contributions to OOUI a Dislike token.
Mon, Sep 30, 6:09 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-notice, MediaWiki-Special-pages, User-Jdlrobson, UI-Standardization-Kanban, UI-Standardization

Sat, Sep 28

Florian claimed T208829: Implement support for new Google ReCaptcha v3.
Sat, Sep 28, 7:38 PM · Patch-For-Review, ConfirmEdit (CAPTCHA extension)

Wed, Sep 25

Jayprakash12345 awarded T117736: Convert Special:Contributions to OOUI a Love token.
Wed, Sep 25, 1:06 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), User-notice, MediaWiki-Special-pages, User-Jdlrobson, UI-Standardization-Kanban, UI-Standardization

Sat, Sep 21

Florian awarded T189982: Move all apihelp translatable messages to separate files a Orange Medal token.
Sat, Sep 21, 2:32 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-extensions-General, Google-Code-in-2018, translatewiki.net, good first bug, I18n
Florian closed T229834: Undefined index: value in "ExtensionProcessor.php" on line 504 (due to specific extension.json file) as Invalid.
Sat, Sep 21, 2:30 PM · MediaWiki-Configuration
Florian added a comment to T229834: Undefined index: value in "ExtensionProcessor.php" on line 504 (due to specific extension.json file).

Ok, then this is your actual problem: Adding the requires section is perfectly fine, however, for this to work you need to bump the manifest version from 1 to 2. However, your remaining extension.json is still version 1 of the manifest (the schema verification, if you run it, will most likely fail). E.g. the config section was massively overhauled in version 2 of the manifest, see the docs:

Sat, Sep 21, 2:29 PM · MediaWiki-Configuration
Florian added a comment to T229834: Undefined index: value in "ExtensionProcessor.php" on line 504 (due to specific extension.json file).

That looks completely unrelated from what I see. Can you post the full extension.json file, so we can reproduce the error locally? Is the error still occuring?

Sat, Sep 21, 1:50 PM · MediaWiki-Configuration

Fri, Sep 20

Florian awarded Blog Post: Wikipedia's JavaScript initialisation on a budget a Manufacturing Defect? token.
Fri, Sep 20, 10:19 PM

Sep 11 2019

Thbrown awarded T116318: Images in tables are too small a Love token.
Sep 11 2019, 10:59 AM · Reading-Web-Local-Wiki-Issues, WorkType-Maintenance

Sep 8 2019

Florian closed T232129: OOUI\Exception occurs when try to insert "https://w" to page as Resolved.
Sep 8 2019, 11:45 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), ConfirmEdit (CAPTCHA extension)

Aug 24 2019

Florian claimed T231135: Module loading not working because of 'Require stack'.
Aug 24 2019, 11:48 AM · Core Platform Team Workboards (Clinic Duty Team), Services (done), HyperSwitch
Florian added a comment to T231135: Module loading not working because of 'Require stack'.

https://github.com/wikimedia/hyperswitch/pull/109

Aug 24 2019, 11:48 AM · Core Platform Team Workboards (Clinic Duty Team), Services (done), HyperSwitch
Florian created T231135: Module loading not working because of 'Require stack'.
Aug 24 2019, 11:46 AM · Core Platform Team Workboards (Clinic Duty Team), Services (done), HyperSwitch

Aug 22 2019

Florian added a comment to T193716: Support whitelisting IPs in CookieWarning extension.

That highly depends on how the electron service is working :P So, honestly, I don't know as I don't know the source of the electron service.

Aug 22 2019, 6:30 PM · MediaWiki-extensions-CookieWarning

Aug 16 2019

Florian closed T186080: GoogleLogin Auto Account Creation as Resolved.
Aug 16 2019, 9:37 PM · MediaWiki-Authentication-and-authorization, GoogleLogin

Aug 11 2019

Florian updated the task description for T199712: Archive the CustomSidebar extension.
Aug 11 2019, 12:02 PM · Patch-For-Review, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Florian committed rELOOc659d2a6d188: Convert Loops to use extension registration (authored by Zoranzoki21).
Convert Loops to use extension registration
Aug 11 2019, 11:10 AM
Florian updated the task description for T199712: Archive the CustomSidebar extension.
Aug 11 2019, 11:08 AM · Patch-For-Review, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Florian added a comment to T230265: Captcha for edit block refresh of session.

What exactly do you mean with "the page refuse to reload"?

Aug 11 2019, 10:46 AM · ConfirmEdit (CAPTCHA extension)
Florian closed T230292: SpecialPage tests failing for Loops extension as Invalid.

Is related to change 425913.

Aug 11 2019, 10:37 AM · ci-test-error, MediaWiki-extensions-Loops
Florian claimed T230292: SpecialPage tests failing for Loops extension.
Aug 11 2019, 10:21 AM · ci-test-error, MediaWiki-extensions-Loops
Florian created T230292: SpecialPage tests failing for Loops extension.
Aug 11 2019, 10:16 AM · ci-test-error, MediaWiki-extensions-Loops

Aug 6 2019

Florian closed T192113: Convert Loops to use extension registration, a subtask of T98668: Convert all extensions and skins on gerrit to use extension registration, as Resolved.
Aug 6 2019, 8:15 PM · User-Zoranzoki21, Google-Code-in-2018, MediaWiki-extensions-General, Goal, MediaWiki-Configuration
Florian closed T192113: Convert Loops to use extension registration as Resolved.
Aug 6 2019, 8:15 PM · MediaWiki-extensions-Loops, Patch-For-Review, User-Zoranzoki21

Aug 5 2019

Florian added a comment to T229834: Undefined index: value in "ExtensionProcessor.php" on line 504 (due to specific extension.json file).

Can you "unsinstall" the extensions one by one until the error disappears? Then you probably have the extension which causes the error :)

Aug 5 2019, 4:30 PM · MediaWiki-Configuration

Jul 29 2019

Florian added a comment to Blog Post: Changes and improvements to PHPUnit testing in MediaWiki.

@kostajh Thanks for your answer! :) I know found my problem, it was not related to the phpunit setup at all (as I already thought, as the unit tests worked well). It was related to the fact, that I use docker to run php, as well as my database and the webserver. And I simply missed to tell IntelliJ that it needs to start the php container for running the tests on the same network as the database in order to be able to connect to it. Now, both, the unit and integration tests run perfectly fine in my extension!

Jul 29 2019, 3:52 PM · MediaWiki-Core-Testing, Test-Coverage, Code-Health
Florian added a comment to T227998: CAPTCHA required for edits that do not add new external links.

Is there a simple way how to trigger addurl only if url was added directly by the edit?

Jul 29 2019, 3:38 PM · ConfirmEdit (CAPTCHA extension)

Jul 28 2019

Florian awarded T229122: Allow wmf-deployment to remove votes from changes in wmf branches a Orange Medal token.
Jul 28 2019, 10:29 AM · Gerrit
Florian awarded T229122: Allow wmf-deployment to remove votes from changes in wmf branches a Yellow Medal token.
Jul 28 2019, 10:29 AM · Gerrit
Florian added a comment to T229122: Allow wmf-deployment to remove votes from changes in wmf branches.

I support this, too, having wmf-deployment people able to deploy is their main reason why this group exists.

Jul 28 2019, 10:29 AM · Gerrit
Florian added a comment to T227998: CAPTCHA required for edits that do not add new external links.

They are stored in LogStash, as (almost?) all logs :-). NDA is required to access.

Jul 28 2019, 10:27 AM · ConfirmEdit (CAPTCHA extension)

Jul 26 2019

Florian closed T227401: MediaWiki should query master instead of replica if replica is too lagged as Resolved.

@Anomie You're absolutely right, I did not think about bisecting the problem *thumbsup*

Jul 26 2019, 6:02 PM · Core Platform Team, MW-1.34-release, Wikimedia-Rdbms

Jul 20 2019

Florian placed T85370: Cannot move cards to workboards on mobile devices without drag and drop functionality up for grabs.
Jul 20 2019, 11:12 AM · Upstream, Phabricator (Upstream)
Florian closed T85370: Cannot move cards to workboards on mobile devices without drag and drop functionality, a subtask of T105404: [EPIC] Gather requirements from teams for Phab project management feature requests, as Resolved.
Jul 20 2019, 11:12 AM · Upstream, Phabricator (Upstream), Phabricator, Epic
Florian closed T85370: Cannot move cards to workboards on mobile devices without drag and drop functionality as Resolved.

From my point of view, it could be closed given that moving of cards is possible on the task itself now, so it's not blocking us from using a mobile device to work :)

Jul 20 2019, 11:12 AM · Upstream, Phabricator (Upstream)
Florian updated subscribers of T227998: CAPTCHA required for edits that do not add new external links.

Basically, these edits needed to add a new (or changed) external URL, otherwise ConfirmEdit would not trigger with the addurl trigger. As far as I understand the code correctly, the link does not need to be added by the edit itself, it could've been added by a new or updated template or something like that.

Jul 20 2019, 11:08 AM · ConfirmEdit (CAPTCHA extension)
Florian removed a project from T228445: Special:SpecialPages throws error when not logged in: Patch-For-Review.
Jul 20 2019, 10:32 AM · GoogleLogin
Florian closed T228445: Special:SpecialPages throws error when not logged in as Resolved.
Jul 20 2019, 10:31 AM · GoogleLogin
Florian added a comment to Blog Post: Changes and improvements to PHPUnit testing in MediaWiki.

Thanks to everyone involved in this! I finally can execute unit tests in my ide (integration tests are still throwing an unexpected error, however, this seems to be related to IntelliJ, as they run on the cli). This is absolutely awesome, as it will make developing tests and features much more easy! Kudos to everyone who helped getting this done! :)

Jul 20 2019, 10:09 AM · MediaWiki-Core-Testing, Test-Coverage, Code-Health

Jul 18 2019

Florian created T228445: Special:SpecialPages throws error when not logged in.
Jul 18 2019, 4:03 PM · GoogleLogin

Jul 7 2019

Florian created T227401: MediaWiki should query master instead of replica if replica is too lagged.
Jul 7 2019, 10:48 AM · Core Platform Team, MW-1.34-release, Wikimedia-Rdbms

Jul 2 2019

Florian closed T223749: ReCaptcha v1 not supported anymore as Resolved.
Jul 2 2019, 4:03 PM · ConfirmEdit (CAPTCHA extension)

Jun 1 2019

Florian added a comment to T220212: Wikimedia Technical Conference 2019: Discussion .

One more thing that frustates me a lot (and directly pays in into the developer Productivity vision in my opinion) is, that MediaWiki makes it complicated to run tests for people who didn't know how it's done specifically in MediaWiki. Like phpunit tests. You can't run them out of IntelliJ at all (as far as I know, I'm not sure how this is in other IDEs) and you can't run them easily with the default phpunit commands (which you may know from other PHP projects already). So a new MediaWiki developer needs to go through a lot of documentation first in order to know how to run tests.

Jun 1 2019, 10:30 PM · Wikimedia-Technical-Conference-2019, International-Developer-Events

May 30 2019

Florian added a comment to T223898: Remove the requirement to enter a password during the login flow.

I played a bit with the first solution, however, it turns out that, even if we move the password field into a second step (which would mean, that the AbstractPasswordPrimaryAuthenticationProvider needs to return a UI AuthenticationResponse in the beginPrimaryAuthentication step), there's the problem thet AuthManager requires a response from continuePrimaryAuthentication to be non-ABSTAIN (which makes kind of sense). However, this means, that there can only be one password authentication provider listening for the second, new, UI step, however, core ships with 2 already (temporary and local passwords).

May 30 2019, 7:48 PM · PasswordlessLogin, MediaWiki-Authentication-and-authorization
Florian committed rEPLL7e48d2f11c64: Remove separate login with smartphone button (authored by Florian).
Remove separate login with smartphone button
May 30 2019, 7:41 PM
Florian committed rEPLLe747c8f1b4ab: Save confirm status when user confirmed a new device (authored by Florian).
Save confirm status when user confirmed a new device
May 30 2019, 7:41 PM
Florian committed rEPLL718128cbdeee: Remove separate login with smartphone button (authored by Florian).
Remove separate login with smartphone button
May 30 2019, 7:39 PM
Florian committed rEPLLcd67d93236c2: Save confirm status when user confirmed a new device (authored by Florian).
Save confirm status when user confirmed a new device
May 30 2019, 7:33 PM
Florian committed rEPLL21993f55be4d: Correctly abstain on non-confirmed device (authored by Florian).
Correctly abstain on non-confirmed device
May 30 2019, 7:18 PM
Florian committed rEPLL4fcd6bd43728: Use wgExtensionAssetsPath instead of scriptpath (authored by Florian).
Use wgExtensionAssetsPath instead of scriptpath
May 30 2019, 3:17 PM
Florian closed T224371: Move PasswordlessLogin extension to gerrit as Resolved.
May 30 2019, 3:16 PM · PasswordlessLogin
Florian updated the task description for T224371: Move PasswordlessLogin extension to gerrit.
May 30 2019, 3:16 PM · PasswordlessLogin
Florian committed rEPLL0c42f34ce03e: Use wgExtensionAssetsPath instead of scriptpath (authored by Florian).
Use wgExtensionAssetsPath instead of scriptpath
May 30 2019, 3:16 PM
Florian committed rEPLL62d661839277: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 3:04 PM
Florian committed rEPLL30f9768de4bc: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:58 PM
Florian committed rEPLL1ea74fbeee12: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:54 PM
Florian committed rEPLL756af56fec79: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:45 PM
Florian committed rEPLL14f017d1149a: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:16 PM
Florian committed rEPLL62eea916eaea: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:11 PM
Florian committed rEPLLfeacec8f3d75: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 2:01 PM
Florian committed rEPLLea3dd181416d: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 1:36 PM
Florian committed rEPLLea782fe0c01a: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 1:27 PM
Florian committed rEPLL17d98f5fdcaa: Use php 7.0 compatible libraries and CI fixes (authored by Florian).
Use php 7.0 compatible libraries and CI fixes
May 30 2019, 1:25 PM
Florian committed rEPLLaa042ca54ce5: Use php 7.0 compatible libraries (authored by Florian).
Use php 7.0 compatible libraries
May 30 2019, 12:42 PM
Florian changed the status of T224667: Bump endroid/qr-code to latest php 7.2 compatible version from Open to Stalled.
May 30 2019, 12:31 PM · PasswordlessLogin
Florian created T224667: Bump endroid/qr-code to latest php 7.2 compatible version.
May 30 2019, 12:31 PM · PasswordlessLogin
Florian changed the status of T224666: Bump endroid/qr-code to latest php 7.1 compatible version from Open to Stalled.
May 30 2019, 12:31 PM · PasswordlessLogin
Florian created T224666: Bump endroid/qr-code to latest php 7.1 compatible version.
May 30 2019, 12:30 PM · PasswordlessLogin
Florian committed rEPLLb52321421d57: Use php 7.0 compatible libraries (authored by Florian).
Use php 7.0 compatible libraries
May 30 2019, 12:29 PM

May 29 2019

Florian closed T224438: Link to Play Store app as Resolved.
May 29 2019, 5:16 PM · Patch-For-Review, PasswordlessLogin
Florian committed rEPLL545c59ac2d4a: Add a play store link for the Andorid app (authored by Florian).
Add a play store link for the Andorid app
May 29 2019, 5:16 PM
Florian committed rEPLL4b6ed85e358c: Render QR code in backend and remove odd client script (authored by Florian).
Render QR code in backend and remove odd client script
May 29 2019, 5:04 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEPLL1a6627d3d6f1: Merge "Render QR code in backend and remove odd client script" (authored by Florian).
Merge "Render QR code in backend and remove odd client script"
May 29 2019, 5:04 PM
Florian claimed T224438: Link to Play Store app.
May 29 2019, 4:52 PM · Patch-For-Review, PasswordlessLogin

May 27 2019

Florian committed rEPLL767be488e2a7: Render QR code in backend and remove odd client script (authored by Florian).
Render QR code in backend and remove odd client script
May 27 2019, 5:42 PM
Florian committed rEPLLb1e007e2c71f: Use correct description for i18n message (authored by Florian).
Use correct description for i18n message
May 27 2019, 5:39 PM
Florian committed rEPLL3b7b906cf7f7: Render QR code in backend and remove odd client script (authored by Florian).
Render QR code in backend and remove odd client script
May 27 2019, 5:35 PM
Florian created T224438: Link to Play Store app.
May 27 2019, 5:19 PM · Patch-For-Review, PasswordlessLogin
Florian committed rEPLLa11152f0b1a1: Add a i18n (authored by Florian).
Add a i18n
May 27 2019, 4:25 PM
Florian committed rEPLL734bf4ec67f9: Add a i18n (authored by Florian).
Add a i18n
May 27 2019, 4:20 PM
Florian committed rEPLLadd322d3930d: Add a i18n (authored by Florian).
Add a i18n
May 27 2019, 4:17 PM
Florian updated the task description for T224371: Move PasswordlessLogin extension to gerrit.
May 27 2019, 3:45 PM · PasswordlessLogin

May 26 2019

Florian updated the task description for T224371: Move PasswordlessLogin extension to gerrit.
May 26 2019, 4:00 PM · PasswordlessLogin
Florian created T224371: Move PasswordlessLogin extension to gerrit.
May 26 2019, 3:56 PM · PasswordlessLogin
Florian closed T224045: Add an app information screen as Resolved.
May 26 2019, 3:54 PM · PasswordlessLogin
Florian claimed T224045: Add an app information screen.
May 26 2019, 1:09 PM · PasswordlessLogin
Florian closed T224044: Some design work for the Android app as Resolved.

This is how the app now looks like:

May 26 2019, 1:03 PM · PasswordlessLogin
Florian claimed T224044: Some design work for the Android app.
May 26 2019, 10:33 AM · PasswordlessLogin
Florian closed T224043: Finish linking a new device as Resolved.

This is done in the extension and the Android app itself, too :)

May 26 2019, 10:33 AM · PasswordlessLogin
Florian closed T211848: SimpleCaptcha::loadText() loads section 0 when passed false, as all callers do as Resolved.
May 26 2019, 10:30 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), ConfirmEdit (CAPTCHA extension)

May 21 2019

Florian claimed T224043: Finish linking a new device.
May 21 2019, 6:01 PM · PasswordlessLogin
Florian added a comment to T223893: Create a project for mediawiki extension Passwordless Login.

TODO: Creating an extension homepage on mediawiki.org (and then updating the project description) is welcome. :)

May 21 2019, 5:26 PM · Project-Admins
Florian edited Description on PasswordlessLogin.
May 21 2019, 5:25 PM
Florian created T224049: Require https for the api URL.
May 21 2019, 5:21 PM · PasswordlessLogin