It's late, but I imported this task into GCI as https://codein.withgoogle.com/dashboard/tasks/4964700098396160/ Let's see if someone claims this in the last days of the contest :)
Fri, Jan 17
@Reedy Thanks for checking my assumption :)
@Wolfhelius It would be awesome, however, I would suggest that we move this discussion somewhere else. Either you edit the GoogleLogin documentation on mediawiki.org directly (what I would welcome), or you can point out the improvements on the discussion page.
Thu, Jan 16
So, this is resolved or did I miss something? I'm not sure, what we can do in GoogleLogin to mitigate this problem :(
Wed, Jan 15
@Ammarpad I was so free to assign myself as well, so we can co-mentor this :]
Fri, Jan 10
Imported as https://codein.withgoogle.com/dashboard/tasks/5648057396363264/ with 10 task instances for now :)
Sounds like a good task for GCI, I'll mentor this :)
Let's see if a student wants to take this, I'll mentor it :)
I'll mentor this in GCI :)
Wed, Jan 8
Sun, Jan 5
Is there anything specific you can give at hand for the student to know, how to send an e-mail from Toolforge? Is it simply by using SMTP (where do the credentials come from?) or is it by an API? Any details from here would help a lot, I think :)
I added the new set of links and the GCI tasks for them to the description.
OAuthManageConsumers -> OAuthConsumerRegistration and the reverse is probably not really useful in practice.
Sat, Jan 4
Uii, that looks nice, and it also allows us to get multiple students into the OAuth extension, one for each linking, isn't it? So, just for clarification, these are the links we want to introduce, right?
Fri, Jan 3
Forgot to click "Submit" in my phab UI :D
Thu, Jan 2
Ammarpad: I'd like to co-mentor this task, is that ok for you?
Wed, Jan 1
Sun, Dec 29
Or, even better, just update the mailgun-php library, if possible, the problem should be fixed there already :D
Hmm, the problem seems to be (also) in the Mailgun library. L067 in the Mailgun extension uses:
$message->addToRecipient( $recip );
Sat, Dec 21
That would be something that need to be proved first by seeing what the performance impact is (in an isolated setup). That's what I want to try to get done, to have data we can decide upon. However, there's the problem, that the php-fpm worker crashes when MediaWiki classes are preloaded (that's what I've reported as a PHP bug entry to see if that's really a bug or something I did wrong when setting up the preload).
Dec 16 2019
Latest master segfaults with:
Looks a bit like https://bugs.php.net/bug.php?id=78894
I'm going to compile php from source to see if the same error occurs again.
Ok, on another system, I was now able to get a core dump from the exiting php-fpm worker:
Dec 15 2019
so is this about third parties only?
You're right, even if the same name is used from another version of the same application, the preloading class "wins" and may result in incompatibilities of the application code :/
@Bawolff Hot deploying is complicated, but it really depends on what you want to pre-load and what not. If you, e.g., focus on deploying config changes only, then you can exclude the configuration paths from pre-loading and let the usual opcache handle them only.
Dec 14 2019
Based on the script published in the original php RfC, I build a preload file for my local environment to see what's going on:
Dec 8 2019
Nov 21 2019
Should be fixed, if not, we can still reopen this task :) Thanks @tstarling!
Nov 19 2019
Getting this again out of the history again :D How would such a functionality look like from the API point of view?
Nov 18 2019
I took a look into the test, however, this one is huuuugggeee, complicated and I can not really understand the intent of it, and as it is working pretty fine locally all the time, I don't feel very comfortable to work on this :( Maybe the person who can fix this, could also take a look into the test and try to make it easier to read and understand? :)
Nov 15 2019
Yep, encountered this multiple times now as well, thought it was related to some changes in master, but it's flaky :(
Nov 14 2019
Nov 13 2019
@Jdlrobson Are you available to mentor this task? :) I would probably also co-mentor it, but I'm a bit out of MobileFrontend for quite some time and having someone who can also take a look would be very nice :)
Nov 12 2019
Nov 10 2019
Nov 9 2019
Nov 3 2019
Would it make sense to reduce the scope of the GCI task to convert a single txt file to markdown, instead of expecting that one student is converting all of them? :)
Imported into GCI as https://codein.withgoogle.com/dashboard/tasks/5619920755228672/ I'll mentor this task :)
Awesome! Thanks for the clarification :)
Nov 2 2019
I added a screenshot of how the screen looks at the moment :)
Awesome, thanks @Urbanecm :) I published the task!
Imported into Google-Code-in-2019 as https://codein.withgoogle.com/dashboard/tasks/5176453134548992/
I'm mentoring this task as well :)
it might relate to my missing knowledge of the codebase, however, GCI students will not have any context as well, so: Can you give a bit more context of the problem? Why is an "is_staff" check problematic and what is the expected replacement? Checking for a specific permission? Adding a new one or re-using an existing one? Once this is clarified, I would be happy to publish this task on the GCI website :)
Oct 9 2019
Oct 8 2019
yes, I think it should focus on looking at the existing methods and not new ones, since there doesn't seem to be a lack of the former :)
Oct 4 2019
Actually I really like this idea for a session, it's kind of hard for a newcomer to actually being able to "see the wiki running", even if they did not even start with all the possible services we provide on top of MediaWiki core. I would, however, propose to keep the focus of this to a specific area in the beginning, probably MediaWiki core, as this is something most people will most likely run into, otherwise it could be an endless discussion?
What is the expected outcome of this session, is it mainly focussed on getting people, who are not familiar with our "system test level" to give an overview, so that they can provide valuable feedback, ideas and concerns in the session building on top of that?
Or is this session focussed on finding patterns and anti-patterns we're using or utilizing at the moment in order to try to have detailed focus-areas where we can invest time to imrprove and hopefully get rid of used anti-patterns?
Sep 30 2019
Sep 28 2019
Sep 25 2019
Sep 21 2019
Ok, then this is your actual problem: Adding the requires section is perfectly fine, however, for this to work you need to bump the manifest version from 1 to 2. However, your remaining extension.json is still version 1 of the manifest (the schema verification, if you run it, will most likely fail). E.g. the config section was massively overhauled in version 2 of the manifest, see the docs:
That looks completely unrelated from what I see. Can you post the full extension.json file, so we can reproduce the error locally? Is the error still occuring?