I've been in communication with @Erdinc_Ciftci_WMDE — the proposed design for mobile looks good. Removing this from our board.
Bringing what's shown in the mobile preview closer to the wikitext sounds like a good idea to me in general. I'm fine with displaying the broken-ish icons, assuming that it will lead to things getting fixed so they work better on mobile eventually.
@alexhollender Thanks for clarification. For users who reconcile or mistakenly clicked the button, the way back is preferences then, correct?
Do we have a time limitation as for how long to show this *very prominent* UI element, that pushes down possible other popular user action elements in the sidebar, for example “Recent Changes”?
Wed, Feb 19
@thiemowmde how we handle links seems to be a bit inconsistent (or difficult to define), see T190549 for context. Perhaps the best way to handle this is to follow what would happen if a link within the reference itself (not the reference preview) were clicked? In this case that would mean it would open in the same tab.
Lastly, as soon as you switch, does the button's label change “Switch to new look” or would that be a toggle button? Or does the design change and the button disappears completely?
Thu, Feb 13
From a certain perspective this is a bug, because any click outside of the filter menu is intended to close the menu (that's part of the mechanics of how our menus work).
From my perspective, 8px would be a good compromise here.
Captured the navigation proposal in patch below.
Wed, Feb 12
Hey @Peteole this is a super cool exploration. I'm curious about your thinking — specifically what challenges you are aiming to solve with this? I can make some guesses but always best to hear directly.
Tue, Feb 11
@olga small things that came up during estimation:
- is the styling of the button intentional? Sort've...it should stand out from the other links in the list but doesn't have to be a full on button (e.g. we could just add some spacing around it and make it bold)
- can we make the button text shorter / less negative? Possibly, let's try to come up with alternatives
My apologies for the long delay on reviewing this.
This looks correct to me. As somewhat of a side-note: I'm not sure if the original design is fully suited to deal with edits with multiple paragraphs moved. Perhaps someday we can create a task and try for a better design there 🙃
Fri, Feb 7
@Physikerwelt ok, is there a separate task that exists? I think we should think of the visual treatment on links and interactivity as design requirements for this feature.
Thu, Feb 6
Wed, Feb 5
@Physikerwelt following up from our email, here is some design feedback:
Tue, Feb 4
This is working. But the design looks bad on mobile. Leaving this to @alexhollender for review. Could you take a look at https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/411223...412204?diffmode=visual (with VisualDiff beta feature enabled) and check if this design is okay?
Jan 23 2020
Jan 22 2020
Jan 20 2020
@alexhollender logo is here: https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/565549/2/static/images/mobile/copyright/wikipedia-wordmark-et.svg if you have time to take a look.
Seems like I never replied here. I remember we had a similar task about this regarding Wikipedia. I am still in favor of keeping the welcome message.
4. Possible diff style issues
I am noticing some style issues. Background colors (red and green) extend to the whole line (covers up the spaces without any content). Is this intended or a bug?
Diff in https://commons.m.wikimedia.org/wiki/Special:MobileDiff/386331930
Good to think about as we go into the desktop refresh where there's a hamburger given @Nirzar's suggestion that "The hamburger menu UI pattern is not meant for desktops or tablets"
Moving this along. Known issue that the map icon still has this bug, e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain
Jan 9 2020
@Jdlrobson ok, since it's a gadget I'd be okay with moving this task along without fixing that, however if it's easy to fix at the same time that'd be great.
two things I'm seeing:
@Ammarpad thanks for the screenshots. It looks great and I think this is sufficient for testing.
Jan 8 2020
I'm unable to access la.wikipedia on the beta cluster. Based on the screenshot here (T240728#5778454) I'm fine with moving this to signoff.
@Ammarpad where should I test this?
Jan 7 2020
Re-opening this task based on T204691#5752221. I've added a revised solution in the description.
Jan 6 2020
Ok awesome, looks great
Ah right, I forgot to check desktop. I've updated my comment above to include screenshots from desktop.
I am curious whether you share this perception and consider this darkening a compromise or a universal improvement you would have considered even without this task for the reading experience.
If not, then perhaps the border suggestion that was initially used in the mockup is worth considering?
@N3rsti ok for now I think all that needs to be done is removing the border-radius.
There seems to be one issue here (only affecting iOS) — not sure if we want to re-open this task or create a new one?
Jan 2 2020
The wordmark looks good. I attempted to make a new SVG file without the extra whitespace.
where and how would we like this to be reviewed?
Dec 20 2019
I'm also not sure that login needs to be a top level action, and don't know how we would achieve
The login / create an account page can be accessed with one click
Dec 19 2019
@alexhollender should this apply to all icons? The icon margin is the same for the page actions as the menu items for example under the hamburger - do these need to change too or are we saying that we want label specific behaviour for the page actions?
I wonder if the navigation menu might be thought of the exception here. These are not standard buttons, and since they are presented in a vertical list I find the reduced spacing between the icon and the text to feel a bit tight. I'm not sure if we've explored the readability implications of lists with icon + text in any formal way, @Volker_E?
Dec 16 2019
Dec 13 2019
Dec 12 2019
Dec 11 2019
Apologies for the delay. Logo looks great. Resolving this.
I just noticed that the font-weight on the labels is a bit light. According to OOUI we should be using 700, though that looks a bit heavy. Would 500 be an acceptable alternative here @Volker_E?
@olga Jan and I reviewed the prototype. I've updated the task description with a prioritized to-do list. We think all items are achievable by Monday.
Dec 10 2019
Dec 9 2019
I recommend opening a new ticket if this is still a problem as I don't think the fix will be trivial
Talk page messages without a section header are not shown. Are you going to address that issue too?
I've re-scoped this task to logged-out users since logged-in is now taken care of via T232594.
Dec 6 2019
Dec 1 2019
@Jdlrobson where can I test this?
Nov 14 2019
If I open a discussion and then click the back button (without adding a reply), when I return to the main talk page it's scrolled all the way down.
From what I can see it scrolls to the thing that was clicked on. Going back takes me to where I was before in the document. Are you saying we want to scroll back to the top of the page in this circumstance? We can do that, we just need to make sure that's the appropriate behaviour here.
@nray two things I've just noticed:
Nov 12 2019
@Volker_E I had imagined something like this (perhaps with the list items rearranged):
Nov 8 2019
I agree that we should increase to 12pt