Thanks for working on this. I’m reviewing it from a design perspective for Android, as it’s been moved to the “Design signoff” column. Some areas haven’t been updated yet, see:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 19 2019
Dec 17 2019
Just experienced the permission error again with this image:
Dec 13 2019
Dec 11 2019
Count edits and users who edited via Suggested edits Explore feed card in total and per edit type (image captions / article descriptions)
Count edits and users who edited via Explore feed card in total and per edit type (image captions (article descriptions)@Charlotte @schoenbaechler: what's the difference between those two asks?
Dec 9 2019
Dec 5 2019
+1 to flat hierarchy and directly showcasing what we have. And since LukeW, we all know that obvious always wins. In regards to sorting the list items, how about an A-Z approach like this:
Hey 👋, just fiddled around in the console with this on design.wikimedia.org. I’m in favor of font-weight: 600;. It feels more harmonic with h1, whereas 700 is competing with it.
Dec 3 2019
As discussed last week @Charlotte, here are the data requests! 👋
Nov 28 2019
Per T235652#5698593, I wasn’t able to check the Explore feed card yet.
Ok @cooltey, moving it back to “Did not pass QA“ for now.
Thanks for checking @Pcoombe and wow, 95 tabs, respect! 👊
Nov 27 2019
hey @cooltey just wanted to check but seems like the production app now supports in-article as well (2.7.50304-r-2019-11-25):
Nov 26 2019
Thanks for fixing the stuff in the task’s description @Dbrant. I noticed some first time experience issues, all the things below are recorded in this video:
@cooltey is there a way to check the Explore feed cards for testing purposes? I played around with the settings (according to T235538#5691719) but wasn’t able to make it show up. Thx.
I'm fine unless @Charlotte or @schoenbaechler have something else.
Nov 22 2019
Also if we say "How many days without break or the last time you’ve contributed using Suggested edits" it's a bit confusing to users why we would show one rather than the other.
@Charlotte Re:
- Change the explanatory string about the streak to "How many days without a break you've contributed using Suggested edits. If you haven't edited in a while, the date of the last edit you made is displayed." (@schoenbaechler may be able to think of something shorter/nicer.)
Nov 15 2019
Hey @cooltey, the settings should be the same for all countries (border: true). Whether it’s placed in article or Explore feed depends on the clients version, see @JMinor’s comment in T235537#5624671:
Nov 14 2019
@cooltey, perfect!
I like that precision in explaining the IP address block @Dbrant, thanks for the explanation. Moving it to QA signoff.
Congrats on the smooth work --> ready for QA signoff 🚀
Looks good, two aspects to improve:
Looks good @Dbrant, impressed by the precise and beautiful implementation. Moving it to QA signoff.
@cooltey, looks good! Last thing before it’s good to go, can we use font-weight: normal; for To all our readers in the UK, as defined?
Hi @cooltey, a very good suggestion. Let’s go with that label style. Would it solve the swiping issue, described in the task’s description as well?
Nov 13 2019
Impeccable work @Sharvaniharan 👏 Hope that Android is going to introduce an automatic dark mode (based on daytime) soon.
Great catch @Dbrant! Let’s go with base10 for the black theme. Updated Zeplin & theme guidelines accordingly.
Nov 12 2019
@Dbrant as just discussed, here’s the new color group for the circle: color_group_54:
Nov 7 2019
Hey @Sharvaniharan, added a comment in regards to the illustrations here to another task: T231445#5644098
Looks good @Dbrant, one last thing – then we can move it to QA signoff. The background circle in the illustration is customized per theme in the designs:
Nov 6 2019
Perfect @cooltey 👍
Nov 5 2019
Thanks @cooltey, this is going to have a positive impact on donations. Question: what is its current behavior? It would be ideal if it always updates to the current weekday & date.
Nov 4 2019
Hey @cooltey, thanks! It seems like the red border’s gone in the latest screenshot?
And just one other question about "disabling" the feature because of too many reverts: What does the user have to do to re-enable the feature? (What is the path to redemption?)
You got a point there @Dbrant – haven’t thought about landscape too much. Let’s go with the current implementation to keep this simple and consistent then.
@Dbrant, one more thing I just realized; implementation on tablets for the tasks deviates from the designs.
Alright @Dbrant! Happy about the ✔ and agree with the ❌ because of your good rationales, then. Sounds like it’s QA signoff time soon.
Thanks @Sharvaniharan & @Dbrant. Minor things:
Listed most of the remaining issues in T231445#563096.
Hey @Dbrant, I had a detailed look at it this morning (also on tablets). Everything we discussed so far is greatly optimized, thanks for that.
Related task: T237162
I’m impressed @cooltey, makes a lot of sense to unify the two, thanks for suggesting this! I think the comments in T235652#5630326 can also be applied here then.
Thanks @cooltey, comments below.