Page MenuHomePhabricator
Feed Advanced Search

Aug 14 2018

nikitavbv closed T185286: Add "enabled [date]" for "Most active users :)" module as Resolved.

Github PR is merged, so closing this as resolved.

Aug 14 2018, 2:05 PM · Patch-For-Review, WM-Bot

Aug 2 2018

zhuyifei1999 awarded T184674: Drop "2" from names of environmental variables a Love token.
Aug 2 2018, 7:23 PM · Patch-For-Review, Pywikibot

Jun 16 2018

nikitavbv created T197513: Username change: Phantom42 -> nikitavbv (on Phabricator).
Jun 16 2018, 1:57 PM · Phabricator

Jun 15 2018

nikitavbv updated the task description for T152139: Update Maintenance scripts in extensions to use $this->requireExtension().
Jun 15 2018, 7:33 PM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), patch-welcome, Patch-For-Review, good first bug, Google-Code-In-2016, MediaWiki-extensions-General, MediaWiki-Maintenance-scripts

Jun 14 2018

nikitavbv added a project to T185286: Add "enabled [date]" for "Most active users :)" module: Patch-For-Review.

Link to related Github PR: https://github.com/benapetr/wikimedia-bot/pull/76

Jun 14 2018, 4:02 PM · Patch-For-Review, WM-Bot
nikitavbv claimed T185286: Add "enabled [date]" for "Most active users :)" module.

I will add this.

Jun 14 2018, 3:19 PM · Patch-For-Review, WM-Bot

Jun 13 2018

D3r1ck01 awarded T185906: PHPUnit tests for the Mailgun extension extension a Meh! token.
Jun 13 2018, 2:16 PM · Patch-For-Review, MediaWiki-extensions-Mailgun
nikitavbv added a comment to T185906: PHPUnit tests for the Mailgun extension extension.

I have added tests. Thank you for offering me to work on this on IRC!

Jun 13 2018, 1:48 PM · Patch-For-Review, MediaWiki-extensions-Mailgun
nikitavbv claimed T185906: PHPUnit tests for the Mailgun extension extension.

I will add tests for this extension

Jun 13 2018, 11:10 AM · Patch-For-Review, MediaWiki-extensions-Mailgun

Jun 11 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEBSD9738424ecd95: Update patch set 1 (authored by nikitavbv).
Update patch set 1
Jun 11 2018, 3:17 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rLTZB72cd18f13266: Final NoteDb migration updates (authored by nikitavbv).
Final NoteDb migration updates
Jun 11 2018, 10:59 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rLTZB0d41f6d6c10e: Create change (authored by nikitavbv).
Create change
Jun 11 2018, 10:59 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rLTZB9c298c0ff941: Final NoteDb migration updates (authored by nikitavbv).
Final NoteDb migration updates
Jun 11 2018, 10:58 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rLTZB3ed679a370f3: Create change (authored by nikitavbv).
Create change
Jun 11 2018, 10:58 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGeaba95381453: Final NoteDb migration updates (authored by nikitavbv).
Final NoteDb migration updates
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGa0c4e7b8d364: Create patch set 3 (authored by nikitavbv).
Create patch set 3
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGb18ad77ce098: Create patch set 2 (authored by nikitavbv).
Create patch set 2
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGf2ec00d30ef3: Create change (authored by nikitavbv).
Create change
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG21259e29094c: Final NoteDb migration updates (authored by nikitavbv).
Final NoteDb migration updates
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG7a2038f928c7: Create change (authored by nikitavbv).
Create change
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG17c0d5d0145d: Final NoteDb migration updates (authored by nikitavbv).
Final NoteDb migration updates
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG428b6a72b443: Update patch set 31 (authored by nikitavbv).
Update patch set 31
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG02d9ccdfda19: Update patch set 29 (authored by nikitavbv).
Update patch set 29
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG2cb230e9fc90: Update patch set 30 (authored by nikitavbv).
Update patch set 30
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG2eda1e27bb6d: Update patch set 29 (authored by nikitavbv).
Update patch set 29
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG2045f1c39a65: Create patch set 30 (authored by nikitavbv).
Create patch set 30
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG1482441da3a4: Create patch set 29 (authored by nikitavbv).
Create patch set 29
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG84dc8f4889cf: Update patch set 27 (authored by nikitavbv).
Update patch set 27
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG8ceecf3e236a: Update patch set 28 (authored by nikitavbv).
Update patch set 28
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG9b5c8e35d0d0: Create patch set 28 (authored by nikitavbv).
Create patch set 28
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG7247e763387a: Create patch set 27 (authored by nikitavbv).
Create patch set 27
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG75c22bcbe2b1: Update patch set 27 (authored by nikitavbv).
Update patch set 27
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGbd842bcf75f7: Update patch set 26 (authored by nikitavbv).
Update patch set 26
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGb115181d1c67: Create patch set 26 (authored by nikitavbv).
Create patch set 26
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG7bef28dad243: Update patch set 25 (authored by nikitavbv).
Update patch set 25
Jun 11 2018, 8:52 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG2d81c7f47a2a: Update patch set 24 (authored by nikitavbv).
Update patch set 24
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG76786e754312: Update patch set 24 (authored by nikitavbv).
Update patch set 24
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGdcc5de995a8c: Create patch set 24 (authored by nikitavbv).
Create patch set 24
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGe862eab2fe4d: Update patch set 22 (authored by nikitavbv).
Update patch set 22
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG3f76397ecf0d: Create patch set 23 (authored by nikitavbv).
Create patch set 23
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGc28325a04fea: Create patch set 22 (authored by nikitavbv).
Create patch set 22
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG4647b4abd5b3: Create patch set 21 (authored by nikitavbv).
Create patch set 21
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG47203f0d6f18: Create patch set 20 (authored by nikitavbv).
Create patch set 20
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGd0dcebaee5d1: Create patch set 19 (authored by nikitavbv).
Create patch set 19
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG555f9f8d5d56: Update patch set 19 (authored by nikitavbv).
Update patch set 19
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG381d49962337: Update patch set 18 (authored by nikitavbv).
Update patch set 18
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG3fc223869876: Create patch set 18 (authored by nikitavbv).
Create patch set 18
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGeddb135fc0fe: Update patch set 17 (authored by nikitavbv).
Update patch set 17
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG7181d164180b: Update patch set 17 (authored by nikitavbv).
Update patch set 17
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG465eac63da92: Create patch set 17 (authored by nikitavbv).
Create patch set 17
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG2d6d39fdce79: Update patch set 17 (authored by nikitavbv).
Update patch set 17
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG6732cccf608a: Update patch set 4 (authored by nikitavbv).
Update patch set 4
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG6a2d3299eee5: Create patch set 4 (authored by nikitavbv).
Create patch set 4
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNGf5b5bdcc4ba5: Create patch set 2 (authored by nikitavbv).
Create patch set 2
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG8efdc10cf7d5: Create patch set 3 (authored by nikitavbv).
Create patch set 3
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESNG3e0dae4fac31: Create change (authored by nikitavbv).
Create change
Jun 11 2018, 8:51 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWIS15335b152d65: Final NoteDb migration updates (authored by nikitavbv).
Final NoteDb migration updates
Jun 11 2018, 6:16 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWISbada19532284: Update patch set 2 (authored by nikitavbv).
Update patch set 2
Jun 11 2018, 6:16 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWISef2cf896fff7: Create patch set 2 (authored by nikitavbv).
Create patch set 2
Jun 11 2018, 6:16 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWISed814c21d49b: Create change (authored by nikitavbv).
Create change
Jun 11 2018, 6:16 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWIS8b3b15d9e48f: Final NoteDb migration updates (authored by nikitavbv).
Final NoteDb migration updates
Jun 11 2018, 6:16 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWISc9f0b53d3660: Update patch set 1 (authored by nikitavbv).
Update patch set 1
Jun 11 2018, 6:16 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWIS516034d62246: Create change (authored by nikitavbv).
Create change
Jun 11 2018, 6:16 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBTFdd55dacd9fb6: Update patch set 2 (authored by nikitavbv).
Update patch set 2
Jun 11 2018, 2:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBTFeda72f8cb73a: Update patch set 1 (authored by nikitavbv).
Update patch set 1
Jun 11 2018, 2:50 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSX8e273ca1e1a6: Update patch set 1 (authored by nikitavbv).
Update patch set 1
Jun 11 2018, 2:21 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSB68b998a1a30d: Final NoteDb migration updates (authored by nikitavbv).
Final NoteDb migration updates
Jun 11 2018, 1:03 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSBe2798694b1c7: Create change (authored by nikitavbv).
Create change
Jun 11 2018, 1:03 AM

Jun 9 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEBSESe5bf742faa5e: Update patch set 3 (authored by nikitavbv).
Update patch set 3
Jun 9 2018, 1:30 AM

Jun 8 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEBSN4e5b168fc1a1: Update patch set 1 (authored by nikitavbv).
Update patch set 1
Jun 8 2018, 11:54 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSNafbf45fdf1cb: Update patch set 1 (authored by nikitavbv).
Update patch set 1
Jun 8 2018, 11:54 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSLacf2da824bd3: Update patch set 1 (authored by nikitavbv).
Update patch set 1
Jun 8 2018, 10:41 PM

Feb 4 2018

D3r1ck01 awarded T183572: PHPUnit tests for the SendGrid extension a Love token.
Feb 4 2018, 7:38 PM · Patch-For-Review, MediaWiki-extensions-SendGrid
nikitavbv committed rESNG512c4588a0c5: Add PHPUnit tests for extension SendGrid (authored by nikitavbv).
Add PHPUnit tests for extension SendGrid
Feb 4 2018, 6:07 PM
nikitavbv committed rESNG5345b720e8ac: Add PHPUnit tests for extension SendGrid (authored by nikitavbv).
Add PHPUnit tests for extension SendGrid
Feb 4 2018, 6:02 PM
nikitavbv committed rESNGbac6776c9739: Add PHPUnit tests for extension SendGrid (authored by nikitavbv).
Add PHPUnit tests for extension SendGrid
Feb 4 2018, 5:49 PM
nikitavbv committed rEWIS1101d4b3a800: Rename Hooks.php to WikispeechHooks.php (authored by nikitavbv).
Rename Hooks.php to WikispeechHooks.php
Feb 4 2018, 5:11 PM

Jan 31 2018

nikitavbv moved T185115: PHPUnit runner does not load required dependencies from composer.json (SendGrid extension) from Doing (On-Going) to Completed (Done) on the MediaWiki-extensions-SendGrid board.

This fixed the issue! Thanks everyone for your help! Can we use extension-unittests-composer instead of extension-unittests-composer-non-voting now, if it works good?

Jan 31 2018, 9:47 AM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-extensions-SendGrid
nikitavbv committed rESNG5780e12bff5e: Remove unneeded phpcs excludes (authored by nikitavbv).
Remove unneeded phpcs excludes
Jan 31 2018, 9:38 AM
nikitavbv committed rESNG81d16cbf6623: Add PHPUnit tests for extension SendGrid (authored by nikitavbv).
Add PHPUnit tests for extension SendGrid
Jan 31 2018, 9:36 AM
nikitavbv committed rESNG8c892b3225f2: [WIP] Add PHPUnit tests for extension SendGrid (authored by nikitavbv).
[WIP] Add PHPUnit tests for extension SendGrid
Jan 31 2018, 9:33 AM

Jan 24 2018

nikitavbv added a comment to T177809: Fix multiple PHP class declarations in one file.

While working on this, I have noticed that in some extensions (for example WikiLexicalData) some classes are outside includes directory (need to take this into account while grep-ing). Additionally, some files are not loaded with autoloader, but are required from other files with require_once. I am not sure what to do with those. Do we need to replace require_once with autoloading first?

Jan 24 2018, 4:19 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MediaWiki-General-or-Unknown, MediaWiki-extensions-General, Google-Code-in-2017
nikitavbv added a comment to T185492: Add PHP_CodeSniffer for codestyle checks to WikiLexicalData extension.

After enabling phpcs I noticed that there are a lot of rule violations here. I decided that it will be better to exclude all failing rules now and then fix them part-by-part in next patches. This will make code style fixes easier to review and merge. Additionally, I faced internal CodeSniffer error which I reported in T185642.

Jan 24 2018, 3:57 PM · Patch-For-Review, MediaWiki-extensions-WikiLexicalData-or-OmegaWiki
nikitavbv created T185642: Undefined index: scope_opener in IfElseStructureSniff.php.
Jan 24 2018, 3:52 PM · MediaWiki-extensions-WikiLexicalData-or-OmegaWiki, MediaWiki-Codesniffer

Jan 23 2018

nikitavbv added a comment to T184583: Fatal error: Class undefined: WikiAdmin for multiple BlueSpice extensions.

Thank you for your work @Osnard! Can we close this as resolved once https://gerrit.wikimedia.org/r/#/c/405853/ is merged?

Jan 23 2018, 9:55 PM · BlueSpice

Jan 22 2018

nikitavbv claimed T185492: Add PHP_CodeSniffer for codestyle checks to WikiLexicalData extension.

I will add this and fix code style issues if those will be detected

Jan 22 2018, 2:37 PM · Patch-For-Review, MediaWiki-extensions-WikiLexicalData-or-OmegaWiki
nikitavbv created T185492: Add PHP_CodeSniffer for codestyle checks to WikiLexicalData extension.
Jan 22 2018, 2:33 PM · Patch-For-Review, MediaWiki-extensions-WikiLexicalData-or-OmegaWiki
nikitavbv committed rEWISc3bc53f76faa: Fix multiple PHP class declarations in one file (authored by nikitavbv).
Fix multiple PHP class declarations in one file
Jan 22 2018, 2:14 PM
nikitavbv added a comment to T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.

tests/wikibase_tests.py::TestRedirects::test_normal_item ERROR: Logged in as '192.0.2.42' instead of 'Pywikibot-test'. Forcing re-login.

Hm, taking this into account, I think that the simplest solution would be just to edit cassette and replace 192.168.0.2.42 with Pywikibot-test in request which is reponsible for logging in.
Another possible (and maybe more correct) solution would be to write a custom cassette serializer/deserializer, so needed value (name of user used to run the test) is placed in cassette automatically on load.

Jan 22 2018, 2:11 PM · Patch-For-Review, Google-Code-in-2017, Pywikibot
nikitavbv committed rEWIS472daaa2d7d9: Fix multiple PHP class declarations in one file (authored by nikitavbv).
Fix multiple PHP class declarations in one file
Jan 22 2018, 2:31 AM

Jan 21 2018

nikitavbv added a comment to T184081: Convert pywikibot wikibase tests to dry tests by using vcrpy.

Looks like cassette which was recorded does not contain one of requests:

CannotOverwriteExistingCassetteException: No match for the request (<Request (GET) https://www.wikidata.org/w/api.php?maxlag=5&format=json&rawcontinue=&meta=userinfo&action=query&uiprop=blockinfo%7Cgroups%7Chasmsg%7Crights>)
Jan 21 2018, 3:37 PM · Patch-For-Review, Google-Code-in-2017, Pywikibot

Jan 20 2018

nikitavbv added a comment to T177809: Fix multiple PHP class declarations in one file.

@Reedy Thank you! Then I will abandon my changes to core and fix extensions instead.

Jan 20 2018, 11:52 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MediaWiki-General-or-Unknown, MediaWiki-extensions-General, Google-Code-in-2017
nikitavbv added a comment to T177809: Fix multiple PHP class declarations in one file.

@Anomie Thank you for giving links to those tasks! You are right, there is no need to split files now if general reogranization will be done. So can we close this task as "Declined"?

Jan 20 2018, 11:25 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MediaWiki-General-or-Unknown, MediaWiki-extensions-General, Google-Code-in-2017
nikitavbv added a comment to T177809: Fix multiple PHP class declarations in one file.

There are quite a lot of such files in core so to make things simplier to manage, review and merge I will split it into multiple patches (by directories)

Jan 20 2018, 6:09 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MediaWiki-General-or-Unknown, MediaWiki-extensions-General, Google-Code-in-2017
nikitavbv claimed T177809: Fix multiple PHP class declarations in one file.

I will work on fixing this

Jan 20 2018, 5:25 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MediaWiki-General-or-Unknown, MediaWiki-extensions-General, Google-Code-in-2017
nikitavbv claimed T139456: Translation of Page display title in the Special:PageMigration (does not shown field for first translation unit).

Okay. Thank you for your work @Goraf! I have tested it once again (changing from 1 to 0 fixes the problem) and will push a patch now.

Jan 20 2018, 5:07 PM · Patch-For-Review, MediaWiki-extensions-Translate
D3r1ck01 awarded T185115: PHPUnit runner does not load required dependencies from composer.json (SendGrid extension) a Like token.
Jan 20 2018, 12:41 PM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-extensions-SendGrid
nikitavbv added a comment to T139456: Translation of Page display title in the Special:PageMigration (does not shown field for first translation unit).

@Goraf Your explanation of this seems to be right. Do you have any plans to continue working on this? Maybe to provide a patch?

Jan 20 2018, 9:44 AM · Patch-For-Review, MediaWiki-extensions-Translate
nikitavbv added a comment to T179182: PageMigration is stopped after importing first item (various wikis).

@Goraf thank you, I will take a look at it!

Jan 20 2018, 9:40 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MediaWiki-extensions-Translate

Jan 19 2018

nikitavbv added a comment to T179182: PageMigration is stopped after importing first item (various wikis).

Thank you for merging this! Hopefully we will get some feedback after deployment. If there are any other issues related to this - please tell and I will be happy to fix!

Jan 19 2018, 8:07 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MediaWiki-extensions-Translate