checked on Hindi wikipedia.

as per the screenshot.

This icon is non standard because it is used in context as a visual illustrative element and not in action/button context. we have 20x20 icons* as standard size.

As an editor, I greatly appreciate the color difference, and would want to retain it.

@pmiazga related: https://phabricator.wikimedia.org/T190549

@alexhollender to followup on these

should we set up a separate task for the followup changes?

Fixed on production now.

Who will do this and how?

@Jdlrobson sounds great, I leave the SWATING decisions up to @ovasileva and @atgo

@Jdlrobson should show the metadata and not the wikidata description. looks like a bug to me. the intended behaviour is to show the timestamp and user

I tested this on slow internet connection.. 3mbps. and we need a spinner while we fetch the list of articles. right now, i only see "Nearby" as a title and nothing happens for 5-7 seconds and then you see the list. let's create a followup for that @alexhollender

These colors do not follow guidelines https://wikimedia.github.io/WikimediaUI-Style-Guide/visual-style_colors.html

Tested... Looks great! a minor followup would be the top alignment of icon and the text but not a blocker.

this could actually be favourable behaviour as it might suggest an "accidental/unintentional hover"

You should't be seeing gradient on it. since the sentence or text ends where it ends. if it wraps to second line. it will start showing the gradient. that is intended.

@ovasileva Let's get rid of it.. we can bring that feature back when we work on special pages to have call to action. as of now the refresh button is not even in the right place.

Is the purpose to align it with the X (close) icon? In which case it looks like it should be 54px, no (that's it's width)?

the purpose is to align the Page Issues title to the content.

The notifications are missing

the notification count is missing in the header as you can see in the screenshot. I'm assuming that space is reserved for refresh icon when the permission is given but at the empty state, either the search icon should move to the right or we should show notification. the search icon looks like it's floating out of no where.

please assign designer for sign off for user facing changes

This did not go through design!!!

• The notifications are missing
• I could not test the main workflow here since dev wiki can't determine location. the transition from accepting location vs not accepting

• The icon types are missing on staging. I could see them before i can't now
• The modal title is issues instead of page issues
• the alignments are off
• the font size needs fixin

10.1093/acprof:oso/9780195314250.003.0001 < this link has a preview that ends in one line at the edge. it doesn't fade into the gradient.

one small style fix with the styles
hide-when-compact computed font size is 14.4 in your change. it should 13px. same for the date and the "learn more" link as well. 16px for the main title and 13px for everything else

Looks good on beta!

that's cheating!

@Jdlrobson nah this is just some inconsistent behaviour of going inside search for the first time vs the second time. seems like a bug

@atgo just to clarify the video shows 3 flashes. they are triggered by reloads which are not captured in the screen there.

I spent 30 mins with JR. we have figured out 80% of the things. the only thing remains now is the flash of unstyled content.
we are trying to target

no one here answered about the the first AC here!

^ I've put that on the beta cluster. any element with class skin-minerva-search-trigger when clicked will trigger the search now. Does that solve your problem?

Just a word of warning.. any css in mobile provided by editors is loaded via JS. Does Hindi have template styles? If not that problem goes away, otherways you'll need to inline them :/

@Jdrewniak Zeplin doesn't allow public boards unfortunately, I have added you to the board.
you can now get the asset

Thanks, that's helpful. is there a way I can see the progress of applying our style to jsdocs? i saw a link on github that was broken

Thanks Volker for separating out the content types. I will get on it :) much easier to do this now

UPDATE: after more discussion, we have decided this change should go live. we will be creating some design debt and follow ups. for now I can confirm this should get merged.

When the user has blocked permissions for providing geolocation the "show nearby articles" button will be disabled.

@alexhollender and I are working on coming up with our options. we identified some trade offs as the change intended here is getting applied to all interactive elements and not only hyperlinks.

min-height prevents the gradient to be applied to first line, it starts with second line given our line height

We use two patterns when it comes to displaying information about an action that cannot be done for various reason.

@TBolliger Here's a compact version with exact same content and comparison with current version.

tested on staging, this is getting applied to all the links and buttons including the UI. i think that's because we removed the property completely. we might need to do a {-webkit-tap-highlight-color:default; } override for article hyperlinks and keep the transparent property for body.

I think a lot of these visual changes will be simple and unintrusive, but I'm concerned about the spacing of elements. We've worked really hard on making sure the tools has high information density so our target users (administrators and power users) can see a lot of information in one go. The margins, spacing of elements, and font sizes were all decreased to have as many 'edit cards' on a 1366x768 monitor. This is the timeline now versus last November.

I applied the UI style guide to the interaction timeline
https://wikimedia.invisionapp.com/share/VRG4FI7NDJY#/282441034_Landing

The line height here is rather -- variable.

for desktop
https://zpl.io/bLNGAvJ

@Vachovec1 created a card to fix this issue
https://phabricator.wikimedia.org/T188581

The fading should definitely not be applied to the first line of the text

ar wikipedia changes line-height to 1.6em for their script.

@TBolliger apologies, I was OOO during this period. I will make sure this is posted before March 14