Page MenuHomePhabricator
Feed Advanced Search

Fri, Aug 7

RHo added a comment to T259913: Welcome survey: remove question about mentor program.

@RHo @nettrom_WMF -- do you have any objections to removing this question? I think this will improve the user experience by lightening the survey. We could also talk about removing the question about "have you edited Wikipedia", because we're not currently using that one either -- but would the survey then be too light? If not, we can remove it, too.

Fri, Aug 7, 7:00 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T253020: Add a link: Design brief.
Fri, Aug 7, 9:44 AM · Growth-Team (Current Sprint), Growth-Structured-Tasks, Epic
RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

Can we use the inline message style instead without the bordered background? And actually, instead of error message in red, the warning message seems more apt if it is coming up on the 10th language since the user can still proceed.

Not sure exactly what you mean here, but I'm guessing it's class="warning"? (See table below)

errorbox (current)
warningbox
error
warning (proposed)

I've updated my patch to use warning since that seems like a reasonable interpretation of what you described.

Fri, Aug 7, 9:07 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage
RHo updated the task description for T253020: Add a link: Design brief.
Fri, Aug 7, 9:03 AM · Growth-Team (Current Sprint), Growth-Structured-Tasks, Epic

Thu, Aug 6

RHo moved T259822: Add a link: Design V1 of the structured tasks add links workflow from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Thu, Aug 6, 5:55 PM · Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo moved T259822: Add a link: Design V1 of the structured tasks add links workflow from 📗Backlog (Current sprint) to 💪In Progress on the Growth Design board.
Thu, Aug 6, 5:55 PM · Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo moved T253020: Add a link: Design brief from Needs Design/Design Doing to Needs PM Review on the Growth-Team (Current Sprint) board.
Thu, Aug 6, 5:53 PM · Growth-Team (Current Sprint), Growth-Structured-Tasks, Epic
RHo updated the task description for T253020: Add a link: Design brief.
Thu, Aug 6, 5:52 PM · Growth-Team (Current Sprint), Growth-Structured-Tasks, Epic
RHo renamed T259822: Add a link: Design V1 of the structured tasks add links workflow from Add a link: Design structured add links workflow to Add a link: Design V1 of the structured tasks add links workflow .
Thu, Aug 6, 5:52 PM · Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo created T259822: Add a link: Design V1 of the structured tasks add links workflow .
Thu, Aug 6, 5:51 PM · Growth-Team (Current Sprint), Growth Design, Growth-Structured-Tasks
RHo added a comment to T258021: Variant C/D: mobile preview for suggested edits module with first suggested edit.

I've played around with two approaches and I'm on the fence about which one to use. The context is that the server will insert task data for a single task into the homepage HTML. On the mobile homepage that will be used as the task preview, and then the full task list on the module view will be manipulated to start with that task, for consistency. (If someone uses the non-JS detail view, that will be inconsistent, but that's a fringe case.) On the desktop, the full task list will also be manipulated to start with the preloaded task - there is nothing to be consistent with in that case, but it should improve the performance significantly.

The question is, how to get the extra data? On the server, we only load the page title for the task, plus task-specific data like difficulty. The description (which comes from a different source on mobile and desktop), image and pageviews are all loaded on the client side as separate API requests. One option is to keep doing that - that will mean adding a skeleton phase to the task preview, much like the one we already have for the desktop card. It also means more promise juggling (the data for the preview card might be loading in parallel with the data for the other 199 cards).

The other option is to do all the lookups on the server side. That's a fair amount of code duplication (for the other 199 tasks the data is loaded just in time so it would still have to happen on the client, unless we create a new API), and unclear performance impact - it would replace some client requests with intra-datacenter requests, OTOH PHP is not good at parallelizing things. UX-wise, it would mean there is no loading / skeleton animation and the task is visible immediately when the rest of the homepage is, but the homepage takes a bit longer to appear.

I'm leaning towards the client-side approach; @RHo @Catrope if you have a preference otherwise, I'd like to hear about it.

Thu, Aug 6, 11:03 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

@RHo and I talked about this. We decided that if the user has chosen 10 languages, the behavior we want is:

  • Disable the widget
  • Placeholder text disappears (per upstream behavior)
  • Error message below the selector: "You have added the maximum number of languages."

Implemented in the attached patch.
9 languages selected:

LGTM

10 languages selected:

Can we use the inline message style instead without the bordered background? And actually, instead of error message in red, the warning message seems more apt if it is coming up on the 10th language since the user can still proceed.

Thu, Aug 6, 10:19 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage

Wed, Aug 5

RHo moved T250235: Scale: pilot help panel with mentorship from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Fixed - checked on desktop and mobile:

Wed, Aug 5, 11:04 AM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Patch-For-Review, Growth-Scaling, Growth-Team (Current Sprint)
RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

We should change the text from "over 300 languages" to "nearly 300 languages", to bring it in line with what wikimediafoundation.org says.

Where exactly does it say it?

I'm pretty sure that by mid-2020, "over 300" is the correct thing, but I'm willing to be corrected.

(It's true that Wikipedias in dozens of these languages are not active, and I'm fine with omitting them from the count, but only if precise and consistent criteria for this are given.)

Wed, Aug 5, 10:03 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage

Tue, Aug 4

RHo moved T250235: Scale: pilot help panel with mentorship from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Thanks @Etonkovidova - agree that functionally this seems all good. However, I noticed one minor design issue with the change to the "Ask a mentor" button in the help panel:

  • The font-styles should be swapped for the Mentor name and additional info <#> edits · <Last active time>

(this applies to mobile and desktop)

DesktopActual
Expected
MobileActual
Expected
Tue, Aug 4, 10:11 AM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Patch-For-Review, Growth-Scaling, Growth-Team (Current Sprint)
RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

Question for @Pginer-WMF: when I start typing "Eng" to pick English, the first languages that come up are British English and Canadian English. Do you think users get confused by that and pick the wrong thing?

Side note: as you probably realize (because you directed the question to @Pginer-WMF) this behavior comes from ULS, and would have to be fixed there.

I think this is related to the variant question I raised earlier, since the ULS implemented allows users to choose a language as well as all its variants (e.g., one may not only add Chinese, but also Chinese (Hong Kong), Chinese (Simplified), etc). @Pginer-WMF can correct/confirm, but my suggestion is that we should only show the root language and hide the variants.
However, if this is not an easy thing to do quickly, perhaps in the short term (and since we are only collecting information at this stage and not asking users to translate anything yet), maybe we can let users enter multiple variants if they so choose and just de-dupe variants in the data analysis (e.g., if someone enters English, Canadian English, and British English, we count this as 1 language not 3).

Tue, Aug 4, 9:57 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage

Fri, Jul 31

RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

Thanks @Catrope - for clarity, I've added details for some of this into the description, and asked questions/comments on some other items inline below.

Fri, Jul 31, 3:32 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage
RHo added a comment to T258021: Variant C/D: mobile preview for suggested edits module with first suggested edit.

@RHo the task card version shown on the post-edit panel (which is what should be replicated here, design-wise) has no design for an error or zero results; it is simply not shown in those cases. Should we do the same here?

Fri, Jul 31, 3:30 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T232410: Newcomer tasks: add language question to welcome survey.
Fri, Jul 31, 12:04 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage

Thu, Jul 30

RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

Thanks for pinging, Rita. I think it looks and works well. The question seems clear. I only observed a couple of minor aspects to consider:

  • The need to clear the search field. When adding a language by searching (e.g., typing 'Cat' to find Catalan") the language selector is closed and the language is added. So far so good. However, clicking to add another one, the language selector is opened with the "Cat" search string filled. In this case, having it cleared would reduce friction.

Thanks @Pginer-WMF, good catch. @Catrope can we add this as another part that "Needs more work" on this task? I.e., to clear the search field inside the ULS after a language is selected.

Thu, Jul 30, 4:07 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage

Wed, Jul 29

RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

Hi @Pginer-WMF - @MMiller_WMF and I were wondering if might have any additional comments/suggestions now that this new language question is available to test in beta?
It is available in https://test.wikipedia.beta.wmflabs.org/wiki/Special:WelcomeSurvey (or cswiki beta) if you want to take it for a spin.
Otherwise screenshots and context are in above comment T232410#6346470.

Wed, Jul 29, 7:49 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage
RHo moved T232410: Newcomer tasks: add language question to welcome survey from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Thanks @Etonkovidova, moving back to Needs More Work for a few minor corrections based on your notes and review. Please see notes inline from reviewing https://cs.wikipedia.beta.wmflabs.org/wiki/Special:WelcomeSurvey

Wed, Jul 29, 7:14 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage

Tue, Jul 28

RHo moved T242618: Design review for help contents sample pages from Needs Design/Design Doing to Needs PM Review on the Growth-Team (Current Sprint) board.
Tue, Jul 28, 3:18 PM · Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo assigned T255389: Newcomer tasks: tips wrap in narrow panel to MMiller_WMF.

After the changes to width 360px on Desktop in T2558719, this issue is no longer happening.
However, pinging @MMiller_WMF in case we would like to proceed with one of the proposals in T255389#6224247 anyway to future-proof in case there are tasks in future which have >8 steps.

Tue, Jul 28, 3:17 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)

Fri, Jul 24

RHo moved T254527: Newcomer tasks: UI fixes to Suggested edit guidance screen - Quick start tips from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Note: The placement of text and icons looks a bit tight - please advise whether some adjustments are needed here:

Fri, Jul 24, 2:50 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo renamed T238598: Newcomer tasks: Display article cards with more information when the Suggested edits module is wide from Newcomer tasks: Article cards should be responsive to Newcomer tasks: Display article cards with more information when the Suggested edits module is wide.
Fri, Jul 24, 2:20 PM · NewcomerTasks Future Release , GrowthExperiments-Homepage, Growth-Team

Thu, Jul 23

RHo moved T258704: Variant C/D: homepage Suggested edits module changes from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Thu, Jul 23, 10:35 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T258704: Variant C/D: homepage Suggested edits module changes.
Thu, Jul 23, 10:35 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo created T258720: Newcomer tasks: Cannot navigate through Suggested edits on smaller mobile devices (prev and next arrows not visible on screen).
Thu, Jul 23, 3:15 PM · NewcomerTasks Future Release , GrowthExperiments-Homepage, Growth-Team
RHo updated the task description for T238598: Newcomer tasks: Display article cards with more information when the Suggested edits module is wide.
Thu, Jul 23, 3:14 PM · NewcomerTasks Future Release , GrowthExperiments-Homepage, Growth-Team
RHo updated the task description for T238598: Newcomer tasks: Display article cards with more information when the Suggested edits module is wide.
Thu, Jul 23, 1:26 PM · NewcomerTasks Future Release , GrowthExperiments-Homepage, Growth-Team
RHo updated the task description for T238598: Newcomer tasks: Display article cards with more information when the Suggested edits module is wide.
Thu, Jul 23, 1:25 PM · NewcomerTasks Future Release , GrowthExperiments-Homepage, Growth-Team
RHo added a comment to T258005: Variant C/D: homepage layout changes.
  1. For @media (max-width: 800px), changing the layout so that both the "main" content and the sidebar below it are at width:100%`.

Additionally, could we make the Impact module take up 50% of one column, and the mentor and help flex to the other side, as illustrated in the mock below:

We currently set the minimum width to 800px (done in 1ca13dff89812bd67f04c00cc1c6ffe190735d27), if we do this change, what would the new minimum width be? And would we fall back to single column mode at some point?

Hi @kostajh - I'd propose this be reduced to 600px. Please see the updated task description where I've tried to take a bit more time to illustrate the layout changes with details in this codepen: https://codepen.io/reets/pen/dyGaxQO.

Thu, Jul 23, 1:01 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T258005: Variant C/D: homepage layout changes.
Thu, Jul 23, 12:59 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Growth-Team (Current Sprint), GrowthExperiments
RHo created T258704: Variant C/D: homepage Suggested edits module changes.
Thu, Jul 23, 12:58 PM · Growth-Team (Current Sprint), GrowthExperiments

Wed, Jul 22

RHo added a comment to T258005: Variant C/D: homepage layout changes.

@RHo on my wide monitor, here is what the existing 75%/25% ratio between main and sidebar looks like with this layout change; it pushes the next module (mentorship) a bit farther down out of view.

If we change the ratio to 66% / 34% for main/sidebar it looks like this:

Do you have a preference between those?

Wed, Jul 22, 11:18 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T258010: Variant C/D: welcome peek drawer on mobile.
Wed, Jul 22, 9:24 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T258008: Variant C/D: smaller start module.
Wed, Jul 22, 9:10 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T258008: Variant C/D: smaller start module.

Should this only apply to variant C/D (but not variant A), or should we make this change globally?

@MMiller_WMF points out that this change is incongruent with variant A, because it would kill the call to action to initiate the suggested edits module (which is in the start module in variant A)

Yes, I would agree we should apply only to variant C/D.

Wed, Jul 22, 9:07 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
RHo closed T232896: Homepage: collapsible start module (mobile), a subtask of T213990: [EPIC] Growth: Newcomer homepage, as Invalid.
Wed, Jul 22, 9:01 PM · Growth-Team (Current Sprint), GrowthExperiments, Epic
RHo closed T232896: Homepage: collapsible start module (mobile) as Invalid.

@MMiller_WMF / @RHo is this obsoleted by the variant C / D work?

Wed, Jul 22, 9:01 PM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
RHo updated the task description for T258010: Variant C/D: welcome peek drawer on mobile.
Wed, Jul 22, 8:47 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T245790: Newcomer tasks: post-edit dialog.
Wed, Jul 22, 1:36 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Jul 10 2020

RHo moved T255074: Newcomer tasks: notice to switch to VE within guidance from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks @Etonkovidova, this LGTM including having no switching to VE on mobile per comment T254823#6296671.

Jul 10 2020, 8:45 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Jul 9 2020

RHo moved T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Too easy, thanks!

Jul 9 2020, 8:27 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T255825: Newcomer tasks: UI fixes to the text elements on the Post-edit dialog from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks, LGTM

Jul 9 2020, 8:13 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T255821: Newcomer tasks: UI fixes to the Mobile footer buttons in the Post-edit dialog from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Checked in betalabs - all specs seem to be in place:

Agreed, thanks!

Jul 9 2020, 8:03 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Jul 8 2020

RHo moved T256215: Newcomer task: Update mobile guidance panel copy reminding users about section editing from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Moving for PM to make final call, but with some additional notes below.

Jul 8 2020, 11:32 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo added a comment to T250451: Variant tests: D-mobile.

@RHo -- similar question as on T250331#6283867. On mobile, when users first visit their homepage from the welcome survey progressive button, they have a banner about how to return there (screenshot below). Would this conflict with the banner from this mockup?

Hmm so this conflicts more than Variant D desktop, since the dismissible notice on the homepage, whereas this is mobile banner pushes the page content down so two welcome messages appearing in succession will look wrong.
I think we should incorporate the the message about returning to the homepage into the new var D welcome style here. Something like:

Welcome to your homepage on Wikipedia. From here, you can learn more about different ways to edit, keep track of your contributions, and ask experienced users how to get started. 
You can always return here by selecting [icon + username] in the menu [menu icon].
Jul 8 2020, 11:14 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T250343: Variant tests: D-desktop.

@RHo -- I have the same question as in T250331#6283867. That popup potentially conflicts with the welcome banner in this variant (and will happen to the majority of users). What do you think we should do?

For variant D desktop where the SE onboarding is part of the homepage and this pop-up is a dialog on top, I don't think it physically conflicts, but the copy on Desktop could be revised and shortened.

Jul 8 2020, 11:10 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T250331: Variant tests: C-desktop.

@MMiller_WMF - this would be my revised welcome banner message for var C which incorporates the discovery pop-up message:

You can always click your username to return here.  Your homepage is where you can learn more about different ways you can edit, keep track of your contributions, and ask experienced users how to get started. 
Continue to learn about the Suggested edits shown below.
Jul 8 2020, 11:07 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T250440: Variant tests: C-mobile.

@RHo -- similar question as on T250331#6283867. On mobile, when users first visit their homepage from the welcome survey progressive button, they have a banner about how to return there (screenshot below). Would this conflict with the welcome drawer from this mockup?

Similar to my comment on Variant D (T250451#6285213), the existing here's 'how to get back to homepage' banner does conflict a lot more than the desktop version. I propose switching to our tried-and-trusted pulsing blue dot again over the menu icon. This is a pretty well used discovery indicator on mobile menus, with the idea that the first time the user taps on the menu to open the drawer, the same message about returning to the homepage by selecting the username will appear as a pop-up.

Jul 8 2020, 11:01 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

hi @kostajh - is it possible for it to be triggered over the input part of the TagMultiselectWidget only on Desktop like the below image?

Yeah, that sounds good! Do you want the languages to appear in a single column or in two columns?

Cool. I think one column works better when it is in this form menu context, and likely better for i18n and consistency with mobile too. (Plus being able to filter by searching should mean not much scrolling required.)

Jul 8 2020, 8:53 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage

Jul 7 2020

RHo updated the task description for T256754: Structured tasks: Positive reinforcements design research.
Jul 7 2020, 12:17 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo added a comment to T250440: Variant tests: C-mobile.

@RHo -- similar question as on T250331#6283867. On mobile, when users first visit their homepage from the welcome survey progressive button, they have a banner about how to return there (screenshot below). Would this conflict with the welcome drawer from this mockup?

Jul 7 2020, 12:01 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T250451: Variant tests: D-mobile.

@RHo -- similar question as on T250331#6283867. On mobile, when users first visit their homepage from the welcome survey progressive button, they have a banner about how to return there (screenshot below). Would this conflict with the banner from this mockup?

Jul 7 2020, 11:50 AM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T250343: Variant tests: D-desktop.

@RHo -- I have the same question as in T250331#6283867. That popup potentially conflicts with the welcome banner in this variant (and will happen to the majority of users). What do you think we should do?

Jul 7 2020, 11:36 AM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T250331: Variant tests: C-desktop.

@RHo -- in thinking back through these specifications, I realized that the the "welcoming" popup in this variant will conflict with one of the discovery popups, which welcomes the user to the homepage and tells them to click their username to return there. This happens if the user first arrives on their homepage after submitting the welcome survey and then clicking the button on the confirmation screen to go to their homepage. This is actually the majority way that users arrive at the homepage (see this slide).

What should we do about this?

Jul 7 2020, 11:29 AM · Growth-Team (Current Sprint), GrowthExperiments

Jul 6 2020

RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

@RHo, yes we can override that.

To implement this feature, there are kind of a few clunky things I wanted to document here and ask for feedback on one particular item.

  1. We need to add back the API module for handling welcome survey responses, shouldn't be a big deal, but will require a bit of time to rewire the form to use it
  2. For TagMultiselectWidgets, you typically connect these with an InputWidget that seamlessly handles input from the user and feeds it into the TagMultiSelectWidget for display. However there isn't an input widget for the universal language selector (ULS) and I don't think it's worth the additional work to create one given that with OOUI deprecation and Vue migration work, both TagMultiselectWidget and probably also ULS will be rewritten.
  3. Since there isn't an InputWidget we can use, I've done a hack which loads the ULS when the user clicks on the input area. The user then sees the language picker, and when a selection is made that's fed into the TagMultiselectWidget.

@RHo where would you like the ULS input to appear? Below or above the TagMultiselectWidget? Or covering it entirely?

hi @kostajh - is it possible for it to be triggered over the input part of the TagMultiselectWidget only on Desktop like the below image?

Jul 6 2020, 8:30 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage
RHo updated the task description for T256754: Structured tasks: Positive reinforcements design research.
Jul 6 2020, 8:12 AM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo added a comment to T256925: Minimized help panel displayed when a page loads.

This is definitely a bug. Not sure if this is related to the work occurring on T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel?

I don't think it's related, but won't it be obsoleted by that change? If the button is always visible, there is no harm in it being displayed a split second before the panel animates up - it might even be a good thing.

Jul 6 2020, 5:51 AM · Growth-Team (Current Sprint), GrowthExperiments

Jul 4 2020

RHo updated the task description for T256754: Structured tasks: Positive reinforcements design research.
Jul 4 2020, 8:34 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)

Jul 3 2020

RHo moved T255819: Newcomer tasks: UI fixes to the Image thumbnail in the Post-edit dialog from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks, image thumbs look much better now, esp. the placeholder image centering.

Jul 3 2020, 11:07 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T255825: Newcomer tasks: UI fixes to the text elements on the Post-edit dialog from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Moving back so @Tgr can adjust the two minor items (iii) and (iv) that @Etonkovidova found. Thanks both!

Jul 3 2020, 10:57 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.

The attached patch implements the animations mostly the way you asked for, but slightly differently. There's an asymmetry in the spec, saying the icons rotate from +/-90 to 0 when fading in, but from 0 to +/-45 when fading out. It was much easier to implement this with CSS transitions rather than animations, but transitions have to be symmetrical, so what I've implemented for now is a symmetrical version where the icons also rotate 90 degrees when fading out.

I used a transition duration of 400ms, because that's what the duration of the existing transition on opening the help panel was, and I thought the durations of these two transitions should match. We can easily change this though (I've pulled the 400ms number out into a variable, so we can update it in one place to change the duration of both transitions in lockstep).

Jul 3 2020, 10:48 AM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T255514: Newcomer tasks: switch to visual editor (desktop) from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Moving to PM review since the questions on T255514#6274151 are for @MMiller_WMF anyway.

Jul 3 2020, 10:42 AM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Jul 2 2020

RHo added a comment to T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing.

@RHo this task is fine. How important it is, though? I looked into it but the label is laid out by OOUI dynamically in a way that's not very intervention-friendly, and messing with it would add to maintenance debt (we'd have to maintain our own fork of this method, unless I'm missing a better option), so if it's just a minor thing, I'd rather not do it.
(FWIW, OOUI does left-align on mobile.)

Jul 2 2020, 7:32 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255514: Newcomer tasks: switch to visual editor (desktop).

To summarize for @RHo :and @MMiller_WMF review:

  • there are four options for Editing mode in Special:Preferences and one stand-alone option (the issues for some options are summarized below in the table)
  • wikis might be two-tabs or single-tab wikis - which does not affect switching to VE specifically.
Editing options SE guidance panel link effect
Remember my last editor (seems to be a default option)does not interfere with the editing workflow but shows the pulsing dot on "Edit source"

@MMiller_WMF - This seems OK to me since we will have the message about switching.

Jul 2 2020, 11:01 AM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo created T256955: [BUG] Newcomer tasks: Post-edit dialog unexpectedly appearing after users edit the talk page of newcomer task article.
Jul 2 2020, 10:50 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo moved T255719: Newcomer tasks: Make the help panel a fixed width on Desktop from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Looks good to me too


@MMiller_WMF - should we still keep T255389 open for future-proofing (if theres ever a task with 9 steps or more)?

Jul 2 2020, 10:35 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T254418: Newcomer tasks: align copy in headers and buttons in help panel from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

LGTM

Jul 2 2020, 10:34 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T256925: Minimized help panel displayed when a page loads.

@RHo -- is this desired? Or a bug?

Jul 2 2020, 10:31 AM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing.

hi @Tgr - I just noticed another minor thing missed in the update that was in the mocks but not specifically called out, which is that the panel header should be text left-aligned (for LTR languages) in this new design.
This is especially noticeable on the root screen as being a bit funky when using centre-aligned:

Expected
Current Betalabs
Jul 2 2020, 10:26 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)

Jul 1 2020

RHo moved T253009: Newcomer tasks: automatically advance tips from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

I also agree the behaviour right now is reasonable enough to move along.

Jul 1 2020, 10:42 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255819: Newcomer tasks: UI fixes to the Image thumbnail in the Post-edit dialog.

[ii] Image container size on Desktop should always be 88x88px, and on Mobile 72x72px. even when there is no image.

For the placeholder that's easy enough to fix (I forgot that flex can override the constant width). What should happen when there is an image, and it is not square? Should we make it fill the box (ie. smaller dimension of the image equals box size) and center it? Fit the box? Something else?

Jul 1 2020, 10:33 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255825: Newcomer tasks: UI fixes to the text elements on the Post-edit dialog.

@RHo do you have an example of the hatnote style somewhere else on the site? I want to check if it is something reusable.

Sorry this should actually be the thumbcaption style which is used on image captions on articles:

Desktop example
Mobile version
Jul 1 2020, 10:23 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255825: Newcomer tasks: UI fixes to the text elements on the Post-edit dialog.
Jul 1 2020, 10:19 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Jun 30 2020

RHo added a comment to T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.

hi @Catrope - I've just added the animation details in the task description. Happy to separate out into a different subtask if you prefer.

Jun 30 2020, 8:39 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.
Jun 30 2020, 8:38 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255522: Evaluate use of Figma for public components and patterns source files.

Jotting down my understanding of the situation:

  • Users of public shared components files are - WMF Designers, WMDE Designers, Unknown number of external public
  • WMF Designers primarily currently use Sketch, whilst WMDE are pretty exclusively Figma folks
  • Quality SVG exportability is important as final files to provide to FED, and presumed important for external folks (who may use free tools like Inkscape)
  • Storybook integration is expected with future integration with the WVUI work.
Jun 30 2020, 5:44 PM · Wikimedia Design Style Guide
RHo updated the task description for T256754: Structured tasks: Positive reinforcements design research.
Jun 30 2020, 5:40 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
schoenbaechler awarded T256754: Structured tasks: Positive reinforcements design research a Barnstar token.
Jun 30 2020, 2:35 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo moved T256754: Structured tasks: Positive reinforcements design research from 📗Backlog (Current sprint) to 💪In Progress on the Growth Design board.
Jun 30 2020, 12:36 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo added a project to T256754: Structured tasks: Positive reinforcements design research: Growth Design.
Jun 30 2020, 12:36 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo moved T256754: Structured tasks: Positive reinforcements design research from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Jun 30 2020, 12:36 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo created T256754: Structured tasks: Positive reinforcements design research.
Jun 30 2020, 12:36 PM · Growth Design, Growth-Structured-Tasks, Growth-Team (Current Sprint)
RHo added a comment to T255255: Newcomer tasks: Enable easier toggling to open and close Desktop help panel.

The attached patch implements 1-3, but not 4 (the animation part), because there's not enough information in the task about what the animation would be (and there are no links to mocks or specs or anything that would tell me).

[...]

There is currently no animation while closing the help panel.

Sorry @Catrope - let me add the animation for *both* opening and closing the panel shortly.

Jun 30 2020, 12:25 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T255719: Newcomer tasks: Make the help panel a fixed width on Desktop.

@RHo did you want to preserve the ability for the help panel to be wider on larger screens (500px) or should we remove that (now inactive) code?

Jun 30 2020, 12:23 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T232410: Newcomer tasks: add language question to welcome survey.

@MMiller_WMF @RHo I'm assuming we want to reuse the UniversalLanguageSelector widget in terms of what the user experience is like when inputting the language name (i.e. you can type any one of "el", "Ελληνικά", or "Greek" to switch to Greek language). Then we would place user selections inside a TagMultiselectWidget with a fixed item for current wiki language. Sounds about right?

Jun 30 2020, 12:18 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage
RHo moved T254526: Newcomer tasks: Header font-size on Suggested Edits screen should use OOUI fieldset header style from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks, LGTM

Jun 30 2020, 11:59 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated subscribers of T255327: [Epic] Evaluate which editing interface should be shown by default.
Jun 30 2020, 11:57 AM · Editing-team (Tracking), VisualEditor

Jun 29 2020

RHo moved T254529: Newcomer tasks: UI enhancement - add a drop-shadow under the header and footer when guidance contents scroll from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

LGTM, thanks!

Jun 29 2020, 12:03 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo moved T255850: [BUG] Double vertical scrollbar appearing on every guidance panel screen in certain browsers from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks @Etonkovidova, moving to PM. Note for @MMiller_WMF the narrow case looks better since this was tested because the 360px width (T255719) will resolve the overflowing tabs, and the breaking difficulty label ribbon bug has also been fixed on T254524:

Jun 29 2020, 12:00 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Regression, Growth-Team (Current Sprint)
RHo moved T254524: [BUG] Newcomer tasks: Overflowing text on guidance screen panel header when difficulty label is too long from Design Review to Needs PM Review on the Growth-Team (Current Sprint) board.

Thanks, double-checked on Desktop and Mobile and LGTM too.

Jun 29 2020, 11:53 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)

Jun 25 2020

RHo moved T255254: Newcomer tasks: Fix back-then-close issue when using guidance with editing from Design Review to Needs More Work on the Growth-Team (Current Sprint) board.

Whilst most of the design review items from my comment T255254#623223 are fixed, I've just notice the close "x" button is still inconsistently place on the LHS of the root screen:

Root screen

It is important that it is consistently in the same position in the header (always on the right hand side), esp. for mobile when it is covering the whole screen.

Jun 25 2020, 8:53 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Patch-For-Review, GrowthExperiments-Help panel, NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T256215: Newcomer task: Update mobile guidance panel copy reminding users about section editing.
Jun 25 2020, 8:37 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Growth-Team (Current Sprint), NewcomerTasks 1.2
RHo added a comment to T256215: Newcomer task: Update mobile guidance panel copy reminding users about section editing.

@RHo -- since the sections on an article are collapsed by default, I'm concerned that the users won't see the pencil icons. How about: "Ready? Open the section you want to edit and tap the pencil icon"

Jun 25 2020, 8:36 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Growth-Team (Current Sprint), NewcomerTasks 1.2

Jun 24 2020

RHo closed T251250: Newcomer tasks: guidance and help panel header overflow menu should use ButtonMenuSelectWidget as Invalid.

Yes, this is no longer valid since we got rid of this menu.

Jun 24 2020, 4:41 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo added a comment to T254526: Newcomer tasks: Header font-size on Suggested Edits screen should use OOUI fieldset header style.

The OOUI fieldset header style is for OOUI forms. I don't think there is a sane way to reuse it elsewhere. Ideally, WikimediaUI would provide a class for header styling, but it doesn't, and OOUI does not have a header component, and even if it did, it seems wasteful performance-wise to render every piece of text with an OOUI component. So we should probably just define our own header style which will hopefully be a close enough imitation of the OOUI style.

Jun 24 2020, 1:54 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)
RHo updated the task description for T254526: Newcomer tasks: Header font-size on Suggested Edits screen should use OOUI fieldset header style.
Jun 24 2020, 1:52 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), NewcomerTasks 1.2, Growth-Team (Current Sprint)