Page MenuHomePhabricator
Feed Advanced Search

Sat, Oct 23

RHo added a comment to T284088: Merge preference "Enable the editor help panel" with "Display the newcomer homepage" together.

I wonder if this will cause people to not realise/notice the second checkbox to "Default to newcomer homepage from username link in personal tools" that only appears when "Display newcomer homepage" is checked?

Do you think it would? I'd assume that anyone who notices it now would still notice it if there is an extra line of text between the two.

Sat, Oct 23, 10:21 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Growth-Team (Current Sprint), Patch-For-Review, Add-Link, Growth-Structured-Tasks

Fri, Oct 22

RHo closed T292320: [QA task] Sticky header impact on SE tasks as Resolved.
Fri, Oct 22, 2:35 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo created T294126: Newcomer tasks: Add blue pulsing dot on the new Vector's sticky header edit button for non-structured newcomer tasks.
Fri, Oct 22, 2:35 PM · Growth-Team, GrowthExperiments-NewcomerTasks
RHo added a comment to T292320: [QA task] Sticky header impact on SE tasks .

Re-checked

(1) The Suggestions mode bar gets replaced as soon as the scrolling (or auto-scrolling) happens on a page.

This is not the issue - the sticky header is not present in Suggestion mode.

(2) For the un-Structured task - the blue dot should accommodate the new edit button.

@RHo - below is the gif to show the blue dot gets replaced with the sticky header. The user impact seems minor to me. Moving for Design review to confirm that this behavior is fine.

sticky_header.gif (931×1 px, 2 MB)

Fri, Oct 22, 2:30 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T272146: Automatically ping newcomers when their question has been answered.

Drop-by comment with two questions...

  • Question: @RHo can you please give T290282 a quick read and let us know whether implementing it would provide newcomers the experience you are talking about creating in this ticket?
Fri, Oct 22, 2:15 PM · Growth-Team-Filtering, Growth-Team, DiscussionTools, Convenient-Discussions, GrowthExperiments-Help panel, GrowthExperiments-Mentorship
RHo added a comment to T236608: [AMC] Minerva talk tabs give confusing experience when they are red links.

for articles that exist this looks good:

Screen Shot 2021-10-21 at 1.28.09 PM.png (1×778 px, 107 KB)

when the article does not yet exist, I'm not sure if both tabs should be red. what do people think (cc @RHo)? the first tab (Article) is in its selected state, so maybe the black would make more sense? in Vector the Article tab is black even when the article does not exist.

Vector for reference:

Screen Shot 2021-10-21 at 1.27.53 PM.png (540×2 px, 153 KB)

current patchalternative
Screen Shot 2021-10-21 at 1.33.28 PM.png (1×780 px, 165 KB)
Screen Shot 2021-10-21 at 1.33.52 PM.png (1×772 px, 164 KB)
Fri, Oct 22, 2:02 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Readers-Web-Backlog (Kanbanana-FY-2021-22), User-Inductiveload, Advanced Mobile Contributions, MinervaNeue

Thu, Oct 21

RHo updated subscribers of T293854: Change "save" to "publish" in several Growth messages.

@MMiller_WMF and maybe @Tgr may have more context but IIRC this was set to "save" to accommodate wikis where there are flagged revisions?

Thu, Oct 21, 4:40 PM · Patch-For-Review, I18n, Growth Design
RHo added a comment to T293041: Improve log-out process in Minerva skin.

@ovasileva I agree that the log out action is not clear. I wonder if we should improve the button before adding a confirmation step?

AB
image.png (1×790 px, 178 KB)
image.png (1×796 px, 152 KB)

I think B creates a clearer organization/hierarchy of the links

Thu, Oct 21, 10:12 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MinervaNeue

Wed, Oct 20

RHo added a comment to T293699: Donors to newcomers: recurring donor landing page.

@RHo @MMiller_WMF One thing I didn't account for is the warning text in T290376: Better display warning text on Special:CreateAccount, which unfortunately interferes pretty drastically with the mobile display:

Screen Shot 2021-10-20 at 14.33.30.png (2×1 px, 207 KB)

Desktop is not as bad:

Screenshot 2021-10-20 at 14-33-59 Create account - Wikipedia.png (1×2 px, 345 KB)


For the email campaign, like with the previous one, it would be great to try a small batch of these to ensure that everything functions as intended and that is verified via analytics, before doing a mass send.

I don't think there is anything we can do about that this week; the solution is to complete T290376: Better display warning text on Special:CreateAccount / T282494: Create field for username assistance at the Special:CreateAccount page

Wed, Oct 20, 1:24 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Growth-Team (Current Sprint)

Tue, Oct 19

RHo added a comment to T293699: Donors to newcomers: recurring donor landing page.

@MMiller_WMF @kostajh - per offline discussion, would it be possible to create alternative copy when someone who is logged in already goes to this page? Something like the mock below (with better copy):

image.png (1×1 px, 406 KB)

Tue, Oct 19, 2:00 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Growth-Team (Current Sprint)
RHo added a comment to T290781: Add an image: captions.

Hi @mewoph - I was wanting the same behaviour to occur as on the add image prototype where the virtual keyboard does come up when the caption is shown, at least on Android (and I am pretty sure on iOS tests as well). Here's a screencast from my phone:

Here is a screen recording of the same flow in the prototype from an iPhone: https://drive.google.com/file/d/1mIiBcsHdZVn5oGjKK2tIlPfGWFDE2Crf/view?usp=sharing. Even in regular editing mode, when the article is first opened, the keyboard doesn't appear. This is by iOS's design/limitations and I'm not sure there's a good way around that.

Based on your assessment that this happens only in response to a button click, could we link the focus-and-invoke-keyboard action to when the user selects "Done" to close the caption onboarding dialog (if the onboarding is being shown), or else to the "Yes" selection for the image (when caption onboarding is not shown)?

It might be possible, but it could (likely) add to the timeline (cc: @kostajh @DMburugu). Based on the current setup, I don't think the effort will be trivial.

Tue, Oct 19, 1:44 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Mon, Oct 18

RHo added a comment to T290781: Add an image: captions.

Hi @MMiller_WMF @RHo I wanted to follow up on this requirement to bring up the keyboard programmatically.

After the user dismisses the onboarding (or if they don't get onboarding), the focus should be in the caption box with the device keyboard open.

On iOS, there is no way to do this since the OS doesn't allow the virtual keyboard to be invoked without a user action (https://bugs.webkit.org/show_bug.cgi?id=195884#c4). I'm not entirely sure about Android, but from my limited testing today, the behavior seems to be the same as in iOS (programmatically focusing on the text area doesn't do anything; focusing on the text area in response to a button click does bring up the virtual keyboard).

Mon, Oct 18, 10:43 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo moved T292730: Add an image: copy from Incoming to Needs Design/Design Doing on the Growth-Team (Current Sprint) board.
Mon, Oct 18, 5:54 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T292933: Help panel: lighter styling for help panel button.

@RHo there's a slight divergence between the Figma designs and standard OOUI states (active and focus). Very slight difference in the icon color (active and focus) and the border/outline (active). We can add extra styles to match the designs. For the focus border I think it's worth since makes the tab navigation coherent.

Progressive help cta.jpg (720×960 px, 51 KB)

Mon, Oct 18, 9:58 AM · Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Fri, Oct 15

RHo updated the task description for T292730: Add an image: copy.
Fri, Oct 15, 7:57 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T293447: Mentor dashboard: M1 mentee overview: Update more frequently than daily.

Hi @Urbanecm_WMF - 3 hours sounds like a prudent improvement to daily based on your assessment. However I wonder if in future, we may want to add a indication of how 'fresh' the data is, such as an Updated Xmin ago label. And furthermore, if it is technically possible (and desirable) for someone to manually refresh/re-run the query?

Both things should be possible (and fairly easy). Because of the performance improvements, updating data for a given mentor should be reasonably fast (a couple of minutes at most). It will still run in the background, but we can let mentors to run the background job on-demand, no problem.

Fri, Oct 15, 9:45 AM · User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-MentorDashboard, GrowthExperiments-Mentorship
RHo created T293454: Mentor dashboard: M1 mentee overview: Add "last updated" indicator and ability to manually refresh mentee data.
Fri, Oct 15, 9:44 AM · Growth-Team (Current Sprint), User-Urbanecm_WMF (Engineering), Patch-For-Review, GrowthExperiments-MentorDashboard, GrowthExperiments-Mentorship
RHo added a comment to T293447: Mentor dashboard: M1 mentee overview: Update more frequently than daily.

Hi @Urbanecm_WMF - 3 hours sounds like a prudent improvement to daily based on your assessment. However I wonder if in future, we may want to add a indication of how 'fresh' the data is, such as an Updated Xmin ago label. And furthermore, if it is technically possible (and desirable) for someone to manually refresh/re-run the query?

Fri, Oct 15, 9:04 AM · User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-MentorDashboard, GrowthExperiments-Mentorship

Thu, Oct 14

RHo added a comment to T284088: Merge preference "Enable the editor help panel" with "Display the newcomer homepage" together.

@RHo @MMiller_WMF could you let us know if the proposed wording is OK?

image.png (166×1 px, 91 KB)

Clicking "Editing" takes the user to the Editing tab in the preferences, without a page reload.

Thu, Oct 14, 3:02 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Growth-Team (Current Sprint), Patch-For-Review, Add-Link, Growth-Structured-Tasks
RHo added a comment to T293316: Add an image: minimal quality gate.

@RHo @Tgr @kostajh -- I created this task to define the minimal quality gate for Iteration 1. I have some questions:

  • For the post-edit dialog, I said that if the user does not have any non-image tasks in their feed, then we shouldn't offer a suggestion in their post-edit dialog. I did that because it's my understanding that for the dialog, we're pulling the next suggestion out of their cached feed. If their cache only has image tasks in it, there would be nothing to pull. @Tgr @kostajh -- do you see a simple way to go get some other task instead -- any other task? Without forcibly changing their filters for them?
  • @RHo -- in your mockups for this experience, you only have one button at the bottom: "View more suggested edits". But the standard experience also has the "Close and edit this article again" or "Close" button. Is that deliberate? Or should this also have both buttons (like I have in the task description now)?

I'd wanted to both simplify it because the new message is long, and as an extra nudge to move on to the next task. But for the sake of simplicity we can keep the second "Close" button. I'll add back in.

  • @RHo -- could you please make a design for the dialog that appears in the suggested edits feed when the user taps an image task?

Yes, this was created here: https://www.figma.com/file/ULhJr1isDstRbGE5vjYDsr/Add-images-structured-task?node-id=3274%3A14654

image.png (1×632 px, 105 KB)

Thu, Oct 14, 11:00 AM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Wed, Oct 13

RHo added a comment to T293161: Add an image: minimal caption validation (PLACEHOLDER).

@RHo @Tgr -- let me re-digest this to see if it sounds right:

  • Initially, let the user type and validate after 2s delay. The 2s starts over after each keystroke. In other words, if they take 1.5 seconds to type each character, and therefore take 7.5 seconds to type "Photo", they would not see the warning message at any point.
  • Once the form field has been in an error state, validate immediately on change.
  • The publish button should not be enabled until there are five characters in the box. If the user has typed in five characters, but starts deleting them, the button goes back to disabled.

Is this right?

Wed, Oct 13, 10:07 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T289599: Claim mentee: Send a notification to former mentor.

@Urbanecm_WMF -- here's my edit to the wording: "Your mentee, <mentee>, was claimed by <mentor>." Is the notification for being claimed also a low-priority one? Or is it a bell? I think they should match.

Wed, Oct 13, 9:58 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Patch-For-Review, User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-Mentorship, GrowthExperiments-MentorDashboard
RHo added a comment to T289599: Claim mentee: Send a notification to former mentor.

@RHo @MMiller_WMF This is basically ready for development, except that I'm not sure what the wording should be. Would something like "One of your mentees, <mentee>, was claimed by <mentor>" be okay? Also, is it okay if it is in the "low priority" notifications (not in the bell, but together with thanks, etc.)?

Wed, Oct 13, 7:46 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Patch-For-Review, User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-Mentorship, GrowthExperiments-MentorDashboard
RHo added a comment to T293161: Add an image: minimal caption validation (PLACEHOLDER).

More specifically, I think the most common behavior is:

  • initially, let the user type and only validate on blur / submit;
  • once the form field has been in an error state, validate immediately on change.

We could do that here and apply the same logic to the submit button; then, it would start out as active, and once the user clicks on it, it would go inactive and the caption UI would switch to error state. Not sure how natural that would feel.

Besides as you say the switching of enabled to disabled state being a bit unnatural, it's more important in my view to have the button start off as disabled as a signal that this is not an optional step.

Wed, Oct 13, 5:47 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T293161: Add an image: minimal caption validation (PLACEHOLDER).

Showing warnings on blur is very common for web forms, but in this case, there isn't really any place for focus to move to - there are no other form fields, and the submit button is disabled.

Wed, Oct 13, 4:03 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo closed T246533: Variant tests: "initiation part 2" test (C vs. D), a subtask of T238887: [EPIC] Growth: Homepage variant tests, as Resolved.
Wed, Oct 13, 1:39 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Growth-Team (Current Sprint), Epic, NewcomerTasks Future Release
RHo closed T246533: Variant tests: "initiation part 2" test (C vs. D) as Resolved.

Resolving as this has long been completed.

Wed, Oct 13, 1:39 PM · Growth-Team-Filtering, GrowthExperiments, Growth-Team
RHo added a comment to T290965: Prevent edits from anonymous users with add link plugin.

@RHo @MMiller_WMF @nettrom_WMF would you like instrumentation for any of the following:

  • The error dialog being shown to the user
  • Clicking Dismiss
  • Clicking Login
  • When the user arrives back on Special:Homepage, do you want the query parameter to show that the user arrived from this workflow (in the same way that we track the user arrived from WelcomeSurvey, Personal tools link, etc)

As this particular scenario seems pretty rare, it is maybe OK to skip instrumentation, but thought I'd ask.

Wed, Oct 13, 1:20 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T293161: Add an image: minimal caption validation (PLACEHOLDER).

@RHo -- what is your preferred experience with the red warning text that will appear under the caption box? Is it like this:

  1. User arrives on page with empty caption box. No red text.
  2. User types first character. Red text appears. Publish button stays gray.
  3. User types sixth character. Red text disappears. Publish button turns blue.

It might be annoying for the warning text to flash every time the user is at the beginning of typing their caption. How should this work? Should there be a delay before it appears? Or should it not appear until they try to press publish?

Wed, Oct 13, 10:30 AM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated subscribers of T292916: No notification for reply to mentor question without ping.

Moving to needs discussion / analysis. As far as I can tell, what we would want to do is switch the help panel / mentorship question ask feature to use ApiDiscussionToolsEdit, and then we'd get the subscribe functionality for free (and also remove our custom ApiHelpPanelPostQuestion.php code). Sounds like a win-win to me. We'd need to add on the change tag for the help / mentorship panel, but that shouldn't be hard.

@MMiller_WMF @RHo do you have any product concerns with using DiscussionTools API for creating the new section on a mentor's talk page when a question is asked via the help panel?

Wed, Oct 13, 9:56 AM · GrowthExperiments-Homepage, GrowthExperiments-Mentorship, Growth-Team
RHo updated subscribers of T272146: Automatically ping newcomers when their question has been answered.

Moving to needs discussion / analysis. As far as I can tell, what we would want to do is switch the help panel / mentorship question ask feature to use ApiDiscussionToolsEdit, and then we'd get the subscribe functionality for free (and also remove our custom ApiHelpPanelPostQuestion.php code). Sounds like a win-win to me. We'd need to add on the change tag for the help / mentorship panel, but that shouldn't be hard.

@MMiller_WMF @RHo do you have any product concerns with using DiscussionTools API for creating the new section on a mentor's talk page when a question is asked via the help panel?

Wed, Oct 13, 9:54 AM · Growth-Team-Filtering, Growth-Team, DiscussionTools, Convenient-Discussions, GrowthExperiments-Help panel, GrowthExperiments-Mentorship
RHo added a comment to T292090: Scale: consider enabling Growth features for autocreated accounts.

Thanks @Tgr and @Trizek-WMF. I'm a little worried about building in exceptions for these accounts, e.g. "homepage, but no help panel", or "homepage but not the username link". I think those will pile up and start becoming confusing to users and to us.

I could imagine (as you propose) something right on the homepage for autocreated accounts that is like, "Not all the features are on for you yet. Click this to enable the help panel".

Interested to hear what @RHo thinks!

Wed, Oct 13, 8:09 AM · Growth-Team, Growth-Scaling

Tue, Oct 12

RHo added a comment to T269659: Add a link: post-edit dialog.

Actually, I think this was an existing issue since the changes to the task name only concerns the metadata.

@RHo To confirm, in the current actual implementation, even when there is a description, the title and the description are not aligned to the top of the container. This should be fixed as well correct?

Tue, Oct 12, 6:50 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
RHo added a comment to T290910: Add an image: skip button functionality for image inspector.

Hi @RHo I was looking at the existing skipped all dialog for add link. It looks like we are using the default styling from OOUI MessageDialog which is different from the specs in Figma. Can you confirm whether we should be customizing the dialog styles or if we should stick to the default (for both add link & add image tasks)?

Screen Shot 2021-10-12 at 10.14.21 AM.png (1×708 px, 202 KB)

Tue, Oct 12, 6:49 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Mon, Oct 11

RHo added a comment to T292467: Add an image: suggestion reason.
  • The two displayed wikis should be whatever is returned first by the API.

hi @Tgr - per team discussion, is there a way to display a "smarter" order of the wikis? For example based on proximity of similar languages (like ULS), or size/age of the article in the other languages?

Mon, Oct 11, 12:41 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T290781: Add an image: captions.
Mon, Oct 11, 12:35 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated subscribers of T292888: Add an image: caption validation (PLACEHOLDER).

Minimum and maximum length.
Not allowing the filename to be included.

These are trivial to do.

Not allowing same caption as previous image done by the user.

Slightly more complicated because we'd have to store previous captions somewhere. Still fairly easy, but is it useful? Someone giving the exact same caption for multiple images seems unlikely.

I agree that not allowing previous captions seems not super useful validation.

Mon, Oct 11, 9:49 AM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T269659: Add a link: post-edit dialog.

@mewoph - the mobile looks perfectly aligned (just as in the screenshot in the above comment):

Screen Shot 2021-10-08 at 1.43.34 PM.png (960×872 px, 97 KB)

For Desktop - the improvement much less noticeable on FF 93:

FF 93 testwiki wmf.3Chrome 94 testwiki wmf.3
Screen Shot 2021-10-08 at 1.44.58 PM.png (1×1 px, 280 KB)
Screen Shot 2021-10-08 at 1.52.56 PM.png (1×1 px, 269 KB)
Mon, Oct 11, 9:43 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Fri, Oct 8

RHo updated the task description for T292627: Mentorship: Provide more information about the public nature of the mentors and talk pages in the Mentor module.
Fri, Oct 8, 1:46 PM · GrowthExperiments-Mentorship, Growth-Team (Current Sprint)
RHo updated the task description for T287915: Mentorship: allow newcomers to opt-in and opt-out of mentorship.
Fri, Oct 8, 1:30 PM · User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-Mentorship

Thu, Oct 7

RHo updated the task description for T292627: Mentorship: Provide more information about the public nature of the mentors and talk pages in the Mentor module.
Thu, Oct 7, 6:50 PM · GrowthExperiments-Mentorship, Growth-Team (Current Sprint)
RHo added a comment to T291367: Add an image: Investigate enabling caption text input on the editing surface (per Concept B prototype) .

Hi @RHo, one clarification: during this caption stage, should the rest of the editing surface be uneditable (so the user could only enter text into the caption input field)?

Thu, Oct 7, 6:29 PM · Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T292092: Add an image: overlay onboarding.

The images are machine-generated, which can be incorrect

@RHo @MMiller_WMF Depending on who reads this and how it is translated, it could be read literally as "the images are made by machines", but I think we want to say that the suggestions are machine-generated. Could we consider changing this to "The image suggestions are machine-generated, which can be incorrect"?

Thu, Oct 7, 1:12 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo created T292730: Add an image: copy.
Thu, Oct 7, 1:06 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T292633: Provide a way for mentors to define on which (section) of their talk pages they want to receive messages from mentees.

Moving to Needs Discussion for @RHo @MMiller_WMF @Urbanecm_WMF to discussion whether this should be done and if so, what the experience should be

Thu, Oct 7, 12:27 PM · Growth-Team, GrowthExperiments-Mentorship
RHo moved T292629: Mentorship: Provide a way for mentees to report issues with their mentor from Needs Discussion/Analysis to Triaged on the Growth-Team board.

Moving to triaged as we will look at this in future improvements to mentee experience, and also pending status of an overarching reporting system.

Thu, Oct 7, 12:23 PM · Growth-Team, GrowthExperiments-Mentorship
RHo moved T292633: Provide a way for mentors to define on which (section) of their talk pages they want to receive messages from mentees from Needs Discussion/Analysis to Triaged on the Growth-Team board.
Thu, Oct 7, 12:21 PM · Growth-Team, GrowthExperiments-Mentorship
RHo moved T272498: Consider to have mentors assigned to newcomers based on editing expertise, not only topic expertise from Needs Discussion/Analysis to Triaged on the Growth-Team board.

Moving to triaged as we will look at this in future improvements to mentee connection to mentors as part of T292068

Thu, Oct 7, 12:21 PM · Growth-Team, GrowthExperiments-Homepage
RHo moved T292068: Have a way for a mentee to select a new mentor from Needs Discussion/Analysis to Triaged on the Growth-Team board.
Thu, Oct 7, 12:19 PM · Growth-Team, GrowthExperiments-Mentorship, Growth-Scaling
RHo added a comment to T286842: Proposal: merge styles for user login and signup into a single ResourceLoader module.

This is how I see those pages:

en.m.wikipedia.org_w_index.php_title=Special_UserLogin.png (969×1 px, 100 KB)
en.m.wikipedia.org_w_index.php_title=Special_CreateAccount.png (1×1 px, 163 KB)
loginsignup

so pretty much identical, and non-full-width above ~1000px viewport width. If the patch changes that, that would be a bug.
(Adding Reading Web as they maintain the mobile skin of these pages.)

My screenshots:

  1. patch

image.png (1×1 px, 118 KB)

  1. no patch

image.png (1×1 px, 116 KB)

The patch version seems problematic.

Also, at a wider viewport, the line height seems wrong:

  1. patch

image.png (1×1 px, 180 KB)

  1. no patch

image.png (1×2 px, 202 KB)

The login screen seems off as well on wider viewport:

  1. patch

image.png (1×2 px, 139 KB)

  1. no patch

image.png (1×2 px, 136 KB)

On a phone sized viewport it seems less wrong, but notable that "Join {SITENAME}" is pushed down to the bottom of the viewport, presumably out of the viewport in smaller displays:

  1. patch

image.png (1×880 px, 93 KB)

  1. no patch

image.png (1×880 px, 98 KB)

cc @RHo @MMiller_WMF

Thu, Oct 7, 11:57 AM · Platform Engineering, Growth-Team, Patch-For-Review, Performance-Team (Radar), User-DannyS712, MediaWiki-User-login-and-signup

Wed, Oct 6

RHo added a comment to T290788: Add an image: quality gates.

Hiya, I've tried to group and respond to different comments below:

Wed, Oct 6, 2:36 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T290789: Add an image: post-edit dialog.
Wed, Oct 6, 1:50 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo closed T278712: Mentor module improvements: Design brief as Resolved.
Wed, Oct 6, 12:11 PM · GrowthExperiments-Mentorship, Growth-Team (Current Sprint)
RHo closed T278712: Mentor module improvements: Design brief, a subtask of T278711: [EPIC] Growth: Mentor module improvements , as Resolved.
Wed, Oct 6, 12:11 PM · Growth-Team (Current Sprint), GrowthExperiments-Mentorship, Epic
RHo updated the task description for T278712: Mentor module improvements: Design brief.
Wed, Oct 6, 12:11 PM · GrowthExperiments-Mentorship, Growth-Team (Current Sprint)
RHo updated the task description for T292629: Mentorship: Provide a way for mentees to report issues with their mentor.
Wed, Oct 6, 12:10 PM · Growth-Team, GrowthExperiments-Mentorship
RHo renamed T287915: Mentorship: allow newcomers to opt-in and opt-out of mentorship from Mentorship: allow users to opt-in and opt-out to Mentorship: allow newcomers to opt-in and opt-out of mentorship.
Wed, Oct 6, 12:10 PM · User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-Mentorship
RHo created T292629: Mentorship: Provide a way for mentees to report issues with their mentor.
Wed, Oct 6, 12:06 PM · Growth-Team, GrowthExperiments-Mentorship
RHo updated the task description for T292068: Have a way for a mentee to select a new mentor.
Wed, Oct 6, 11:52 AM · Growth-Team, GrowthExperiments-Mentorship, Growth-Scaling
RHo added parent tasks for T272498: Consider to have mentors assigned to newcomers based on editing expertise, not only topic expertise: T292068: Have a way for a mentee to select a new mentor, T264343: Have a special page for mentors to sign up.
Wed, Oct 6, 11:51 AM · Growth-Team, GrowthExperiments-Homepage
RHo added a subtask for T264343: Have a special page for mentors to sign up: T272498: Consider to have mentors assigned to newcomers based on editing expertise, not only topic expertise.
Wed, Oct 6, 11:51 AM · Growth-Team-Filtering, GrowthExperiments-MentorDashboard, GrowthExperiments-Mentorship, Growth-Team, Growth-Scaling
RHo added a subtask for T292068: Have a way for a mentee to select a new mentor: T272498: Consider to have mentors assigned to newcomers based on editing expertise, not only topic expertise.
Wed, Oct 6, 11:51 AM · Growth-Team, GrowthExperiments-Mentorship, Growth-Scaling
RHo added a subtask for T292068: Have a way for a mentee to select a new mentor: T272497: Consider to pair mentors and mentees based on Topics mentees selected.
Wed, Oct 6, 11:49 AM · Growth-Team, GrowthExperiments-Mentorship, Growth-Scaling
RHo added a parent task for T272497: Consider to pair mentors and mentees based on Topics mentees selected: T292068: Have a way for a mentee to select a new mentor.
Wed, Oct 6, 11:49 AM · Growth-Team-Filtering, GrowthExperiments-Mentorship, Growth-Team
RHo created T292627: Mentorship: Provide more information about the public nature of the mentors and talk pages in the Mentor module.
Wed, Oct 6, 11:38 AM · GrowthExperiments-Mentorship, Growth-Team (Current Sprint)

Tue, Oct 5

RHo added a comment to T290788: Add an image: quality gates.

Hi there - here are the proposals I have for the 'quantity gate' behaviour in the following scenarios (it's also on the Figma file here and here):

Tue, Oct 5, 8:15 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T290789: Add an image: post-edit dialog.
Tue, Oct 5, 7:26 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T290782: Add an image: image details.

note @MMiller_WMF – I made minor updates to the task description around not showing the metadata when the field is blank, and also showing suggestion reason on the dialogs.

Tue, Oct 5, 4:20 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T290782: Add an image: image details.
Tue, Oct 5, 4:19 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T290782: Add an image: image details.
Tue, Oct 5, 3:29 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T290046: Add an image: rejection dialog.
Tue, Oct 5, 3:03 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo closed T285704: Add an image: Design brief, a subtask of T285587: [EPIC] "Add an image" Iteration 1, as Resolved.
Tue, Oct 5, 12:10 PM · Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo closed T285704: Add an image: Design brief as Resolved.
Tue, Oct 5, 12:10 PM · Image-Suggestions, Growth-Team, Growth-Structured-Tasks

Mon, Oct 4

RHo updated the task description for T290046: Add an image: rejection dialog.
Mon, Oct 4, 7:10 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T290046: Add an image: rejection dialog.

@RHo -- could you please help with these clarifying questions?

  • For the "add an image" design, the rejection step is a fullscreen overlay, whereas for "add a link" it's a modal (see screenshot below). While I know we tested these options against each other with Concepts A and B, I want to check whether we want consistency here across the two task types.

Yes my bad, I've updated to use the same consistency with both tasks to not use a full-screen modal.

Mon, Oct 4, 7:09 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T291715: Add an image: captions onboarding tooltip (PLACEHOLDER).

@RHo -- since we've decided not to use tooltips in Iteration 1, what do you think we should do with this onboarding? Should it be a full screen overlay? Or a dialog?

Mon, Oct 4, 7:00 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T292320: [QA task] Sticky header impact on SE tasks .
Mon, Oct 4, 4:46 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T292320: [QA task] Sticky header impact on SE tasks .

@RHo ok great, thanks for the clarifications. Is there anything you need from us currently on this task?

Mon, Oct 4, 4:44 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T292320: [QA task] Sticky header impact on SE tasks .

@Etonkovidova @mewoph @RHo thanks for raising these questions.

  1. How can I see the Suggested mode toolbar?

Hi @alexhollender - the Suggested edits mode toolbar is shown when users open an "Add a link" structured task – see screencast:

Mon, Oct 4, 4:21 PM · Growth-Team (Current Sprint), GrowthExperiments
RHo updated the task description for T290910: Add an image: skip button functionality for image inspector.
Mon, Oct 4, 1:04 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated the task description for T290910: Add an image: skip button functionality for image inspector.
Mon, Oct 4, 1:03 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo renamed T290910: Add an image: skip button functionality for image inspector from Add an image: skip button functionality for image inspector (PLACEHOLDER) to Add an image: skip button functionality for image inspector.
Mon, Oct 4, 1:02 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T290910: Add an image: skip button functionality for image inspector.

@RHo -- I'd like to clarify our specifications here. You wrote that when the user taps "Not sure", they should be taken back to their suggested edits feed, with a dialog in between asking them to confirm. This is different than what we do for links: if the user skips all the links and confirms so in the dialog, they are taken to the post-edit dialog state that looks like this (see T269658 for the original specifications for "add a link"):

image.png (1×764 px, 448 KB)

I think we should do the same behavior for both tasks. Which do you prefer? I think we should align to the links behavior, so if a user skips the image, they get to the post-edit dialog to get another suggestion.

Mon, Oct 4, 12:07 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo updated subscribers of T292320: [QA task] Sticky header impact on SE tasks .

For (1), it looks like this is not unique to Suggestions mode. Regular VE toolbar gets covered by the sticky header as well.

sticky_header_conflict.gif (1×1 px, 3 MB)

Mon, Oct 4, 10:54 AM · Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T292393: Recommended link annotation is sometimes not visible in viewport.

@RHo / @MMiller_WMF could you decide how you'd like to prioritize dealing with this bug? (Upcoming work or current sprint?) I am not sure how often this occurs in practice, but is potentially very confusing to a newcomer who wouldn't see the text they are being asked to link.

Mon, Oct 4, 10:45 AM · MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), Growth-Team (Current Sprint), Add-Link
RHo added a comment to T292068: Have a way for a mentee to select a new mentor.

Perhaps we should first explore a way for mentees to opt out of mentorship as proposed within T278712 - since at present we have no mechanism that allows mentees to know which alternative mentors they should instead select. And this also solves the issue for mentees who don't want *any* mentor whatsoever.

Mon, Oct 4, 10:12 AM · Growth-Team, GrowthExperiments-Mentorship, Growth-Scaling

Fri, Oct 1

RHo updated the task description for T292092: Add an image: overlay onboarding.
Fri, Oct 1, 6:56 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T269659: Add a link: post-edit dialog.

Hi @RHo, updated

Mobile post-edit dialog

Screen Shot 2021-09-30 at 8.59.24 AM.png (748×808 px, 174 KB)

Mobile preview

Screen Shot 2021-09-30 at 8.58.46 AM.png (210×700 px, 83 KB)

Desktop post-edit dialog

Screen Shot 2021-09-30 at 9.01.10 AM.png (826×1 px, 240 KB)

Fri, Oct 1, 3:51 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
RHo added a comment to T285932: [BUG] Newcomer homepage mobile - user should not be able to scroll below the welcome "peek" drawer.

Hmm, yeah it seems to be something specific to the CSS on Special:Homepage. For reference you can make a drawer on a page like so:

var Drawer = mw.mobileFrontend.require( 'mobile.startup' ).Drawer;
 var drawer = new Drawer( {} );
document.body.appendChild( drawer.$el[ 0 ] );
 drawer.show();

and it looks like creating a drawer that way on Special:Homepage results in the scroll issue.

The drawer should be dismissed

@RHo As far as I know, swipe down is not defined by MobileFrontend's drawer as a way to close the drawer; instead you have to either tap outside or on the contents of the drawer to dismiss it. I'd propose that the fix for this task is to make drawers on Special:Homepage stay anchored to the bottom of the viewport for consistency with the way drawers behave elsewhere, and that swipe down to close is handled at another time or in a different task. Does that sound OK?

Fri, Oct 1, 3:49 PM · MobileFrontend, GrowthExperiments-Homepage, Growth-Team
RHo added a comment to T290965: Prevent edits from anonymous users with add link plugin.

Thanks @mewoph LGTM (but also hope it's an error that will be rarely seen)

Fri, Oct 1, 2:19 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T291366: Add an image: Investigate building mobile onboarding pop-ups on top of GuidedTour .

@MMiller_WMF @RHo should we continue researching this, or move this out of the current sprint as it looks like we are just using the overlay (T292092: Add an image: overlay onboarding) for onboarding?

Fri, Oct 1, 1:42 PM · Growth-Team (Current Sprint), Growth-Structured-Tasks

Thu, Sep 30

RHo added a comment to T290540: Add an image: image viewer.

That's right. Here's a video w/the two ways of navigating back.

Thu, Sep 30, 5:11 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T290540: Add an image: image viewer.

Hi @RHo the slide right is native iOS behavior (to go back to the previous page).

Thu, Sep 30, 4:45 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo moved T292173: Newcomer tasks: Placeholder image graphic for taskcard and task preview is distorted from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Thu, Sep 30, 11:21 AM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Growth-Team (Current Sprint), GrowthExperiments
RHo created T292173: Newcomer tasks: Placeholder image graphic for taskcard and task preview is distorted.
Thu, Sep 30, 11:21 AM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Growth-Team (Current Sprint), GrowthExperiments
RHo added a comment to T269659: Add a link: post-edit dialog.

I see, thanks for the specs @RHo. Here are the updated screens:

Desktop

Screen Shot 2021-09-29 at 2.14.03 PM.png (802×1 px, 184 KB)

Mobile

Screen Shot 2021-09-29 at 2.12.40 PM.png (812×814 px, 221 KB)

Thu, Sep 30, 10:58 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
RHo added a comment to T290045: Add an image: image inspector.

I don't know if this should be done in this task or a new one, but I encountered this issue today:

  • Select "Yes" to the image
  • It's inserted into the document
  • Change your mind and press the cancel X at the top of the publish dialog
  • Then press "No" for the suggestion
  • Then Publish changes

The image is embedded in the article, though it shouldn't be.

Thu, Sep 30, 10:52 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T290540: Add an image: image viewer.

Hi @RHo thanks for the clarifications, here's the updated (non)animation:

imageview_ios_noAnimation.gif (1×886 px, 2 MB)

Thu, Sep 30, 10:35 AM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
RHo added a comment to T289723: Sticky header: Add edit icons to sticky header.

@ppelberg @iamjessklein @ovasileva and myself met today to discuss this.

We discussed the three options for the situation where there are two edit buttons:

  1. Use icon buttons
  2. Use an icon-button with a dropdown menu
  3. Use text buttons

Text buttons have the most consistency with the article toolbar at the top of the page. We agreed to flesh out the text button option a bit further. Here is how text buttons would look in a few different languages:

image.png (1×2 px, 805 KB)
image.png (1×2 px, 867 KB)
image.png (1×2 px, 804 KB)
image.png (1×2 px, 818 KB)

We noted an open question: what percentage of people see two edit buttons, and have they opted-into that situation?

Thu, Sep 30, 8:00 AM · MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

Wed, Sep 29

RHo added a comment to T290540: Add an image: image viewer.

With updated back behavior (via swiping back & via back button):

imageview_ios_back.gif (1×886 px, 3 MB)

If there is time, I think it might be good to revisit the dialog animation. When swiping back, seeing the dialog animate out is rather odd so perhaps the animation can be skipped. Currently the dialog animation is the default one used for VE's dialogs. There is a related task to update the dialog animation: T288978: Add a link: Mobile dialogs should appear fading in and out from the centre of the screen.

Wed, Sep 29, 8:17 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks