I pulled this down for a more thorough code review today, and realized that I'm not clear what the actual acceptance criteria is here. From the description, I would expect garbled tally output for STV poll tallies, but the output from master seems fine?

sh
$ docker compose exec mediawiki bash -c "php extensions/SecurePoll/cli/tally.php --name 'stv 2'"

I wanted to note that the new toolbar ui (currently behind the pagetriage_tb url parameter) replaces draggable() already. You can access it by following review links from the feed with the parameter set: https://en.wikipedia.org/wiki/Special:NewPagesFeed?pagetriage_tb=new. It's a partial vue migration that should work as a drop in replacement for the current one.
see T340117 for more info

In T361699#9715760, @jsn.sherman wrote:

[...]

2. observability: we want moderators to be able to see/validate that it is working in cases where it is not reverting edits. There isn't a clear feature designed around this for the pilot. Perhaps just observability into the overall activity of the extension would be adequate for now.

noting that we can look at growth experiments extension page for json config notes

@Ladsgroup, thank you for looking at this.

In T361699#9712633, @Ladsgroup wrote:

Since you're aiming for May, I suggest doing this sooner than later since from what I'm seeing in the parent tickets it needs a bit of rework before it can go live.

In T352675#9709743, @Samwalton9-WMF wrote:

In T352675#9709696, @jsn.sherman wrote:

In T352675#9709691, @Samwalton9-WMF wrote:

[...]

Oh interesting - is DisableAnonTalk used on any production WMF wikis? I don't see it in CommonSettings or InitialiseSettings but not sure if I should be looking elsewhere.

[...]
I am not aware of it's use on any of our wikis.

I searched around Meta, MediaWiki.org, and Phabricator and also can't find any indication of it being used. Since Automoderator only needs to support production wikis can we ignore it?

In T352675#9709691, @Samwalton9-WMF wrote:

[...]

Oh interesting - is DisableAnonTalk used on any production WMF wikis? I don't see it in CommonSettings or InitialiseSettings but not sure if I should be looking elsewhere.

[...]
I am not aware of it's use on any of our wikis.

In T352675#9709202, @Samwalton9-WMF wrote:

[...]

Given this, the skip for revision-deleted edits, and seemingly no good reason to differentiate anon edits, I think we're back to a single edit summary?

In T352675#9708268, @jsn.sherman wrote:

In terms of imported edits there is again a potential special case, since we need to generate an interwiki link. But would Automoderator ever be reverting an imported edit? i.e. do edits generated via Special:Import trigger Automoderator review? If not we could remove these cases from consideration.

We currently implement the RevisionFromEditComplete hook, which imports also implement via the ImportReporter callback:
https://doc.wikimedia.org/mediawiki-core/master/php/classImportReporter.html

The RecentChangeSave hook (which we may switch to), is implemented by the rebuild recent changes script:
https://www.mediawiki.org/wiki/Manual:Rebuildrecentchanges.php

Meaning that if we wish to skip imported revisions, we need to add that to the precheck.

In T352675#9708308, @Scardenasmolinar wrote:

In T352675#9708288, @jsn.sherman wrote:

In T352675#9707823, @Samwalton9-WMF wrote:

[...]

Susana just mentioned to me that we're currently skipping edits where the username/edit has been revision deleted. It makes sense to me, actually, because if revision deletion is happening an admin has looked at the edit and is already taking moderation actions on it - if the edit should be reverted we can trust that they're also going to take that action.

[...]

Looking at the code, I think these are two slightly different checks. The precheck is seeing if there is a user identity associated with the revision, the edit summary check is seeing if there is an accessible username associated with the user identity. I don't know what the practical distinction is at the moment.

The user check is done in the hook even before the pre-check, so there may be a chance that the code will not get that far into creating an edit summary.

In T352675#9707823, @Samwalton9-WMF wrote:

[...]

Susana just mentioned to me that we're currently skipping edits where the username/edit has been revision deleted. It makes sense to me, actually, because if revision deletion is happening an admin has looked at the edit and is already taking moderation actions on it - if the edit should be reverted we can trust that they're also going to take that action.

[...]

In terms of imported edits there is again a potential special case, since we need to generate an interwiki link. But would Automoderator ever be reverting an imported edit? i.e. do edits generated via Special:Import trigger Automoderator review? If not we could remove these cases from consideration.

We'll need to check this next week, but I added really basic templating in my WIP patch

Okay, it sounds like the spike is still warranted. The way we do this now may end up getting thrown out later, but I don't think that's a big deal. For now I'll implement the config string as requested along with the edge case checks that I mentioned in earlier comments.

merged!