Page MenuHomePhabricator
Feed Advanced Search

Today

Catrope added a comment to T228746: mw.config empty on some pages (and fatal errors emitted) due to Unicode-unaware handling of UTF8 data by Lua.

In T245573 @Catrope suggested another potential way to fix this: cleaning up the string inside LuaSandbox after it comes from Lua, in luasandbox_timer_profiler_hook() and luasandbox_push_structured_trace().

Sat, Feb 22, 1:27 AM · Core Platform Team Workboards (Clinic Duty Team), LuaSandbox, MediaWiki-extensions-Scribunto, Wikimedia-production-error
Catrope added a comment to T164307: Add Reverted filter to RecentChanges Filters.

I have one doubt : Does the current edit model have a field to identify whether the edit is a revert ? Or does that need to be implemented ? From reading this, I understand that only a method needs to be implemented to know it, and that the model already has a field to know what is the edit type (revert or not) ?

Sat, Feb 22, 1:05 AM · Google-Summer-of-Code (2020), Growth-Team, Edit-Review-Improvements-RC-Page, Edit-Review-Improvements-Integrated-Filters

Yesterday

Catrope added a comment to T245782: Trying to Resolve a particular StructuredDiscussion doesn't work.

The DBQueryError was: Error: 1062 Duplicate entry '\x05\xC1Ue\x09\xC1\xD8\xD2\xC2\x10U' for key 'flow_revision_unique_parent' (10.64.32.11)

Fri, Feb 21, 7:48 PM · Growth-Team, StructuredDiscussions

Tue, Feb 18

Catrope created T245573: LuaSandbox should clean up short_src for multibyte-safe truncation.
Tue, Feb 18, 11:43 PM · LuaSandbox

Sat, Feb 15

Catrope created T245328: Disable the {{ (template) sequence when inside a <code> annotation.
Sat, Feb 15, 1:38 AM · VisualEditor

Fri, Feb 14

Catrope added a comment to T245073: [wmf.19] Uncaught TypeError: Cannot read property 'toggle' of undefined.

Need to backport?

Fri, Feb 14, 4:31 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Growth-Team

Wed, Feb 12

Catrope added a comment to T245072: Search by exonym (e.g. "Dutch" for nl) not working in language search dialog.

I broke this a year ago in rMW1c7c9bdf1fc5: Use packageFiles feature to replace special-purpose RL modules, apparently nobody noticed.

Wed, Feb 12, 10:48 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MW-1.33-notes, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, VisualEditor-LanguageTool
Catrope created T245072: Search by exonym (e.g. "Dutch" for nl) not working in language search dialog.
Wed, Feb 12, 10:48 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MW-1.33-notes, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, VisualEditor-LanguageTool

Tue, Feb 11

Catrope added a comment to T244937: [Regression 1.35.0-wmf.19] i/p/IndexPager.php:* PHP Warning: implode(): Invalid arguments passed.

This is a regression from rMW6786aa5d8e2e: Support pagination on multiple columns in the IndexPager, caused by the fact that ImageHistoryPseudoPager completely reimplements doQuery(), including code that lives in IndexPager::extractResultInfo(), which was modified in an incompatible way.

Tue, Feb 11, 10:56 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Patch-For-Review, Anti-Harassment, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3))

Wed, Feb 5

Catrope added a comment to T244192: Newcomer tasks: ORES ontology mapping and score thresholds.

But the topics themselves should be displayed alphabetically in the local language. Engineers, please let us know if that doesn't look like a good approach.

This shouldn't be an issue.,

Wed, Feb 5, 1:52 AM · Scoring-platform-team (Current), Discovery-Search (Current work), Growth-Team (Current Sprint)

Fri, Jan 24

Catrope added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

There will be some limitations to this approach:

  1. we'll rely on Vue's built-in template compiler for the time being, which means shipping a little bit of additional code in production;

This is irresponsible. For the amount of traffic we have, the amount of extra computation we are going to force on millions of clients because of our inability to get our process together.

Fri, Jan 24, 1:15 AM · Security-Team, TechCom-RFC

Jan 23 2020

Catrope added a comment to T236104: Cache of wmf-config/InitialiseSettings often 1 step behind.

I don't think that that would help. I was measuring mtime deltas not because I think there's a bug of the type you're alluding to, but as a proxy for finding out whether the bad servers generated their cache files very shortly after the scap happened. If the cache file is only a tenth of a second younger than the settings file, that might indicate some sort of race condition, but at 0.25 seconds that's less plausible, and at 3 seconds it's definitely not plausible.

Jan 23 2020, 1:07 AM · Deployments, Release-Engineering-Team, Performance-Team (Radar), serviceops
Catrope awarded T243472: +2 for Urbanecm on mediawiki/extensions/GrowthExperiments a Like token.
Jan 23 2020, 12:51 AM · Gerrit-Privilege-Requests, Growth-Team, GrowthExperiments
Catrope added a comment to T236104: Cache of wmf-config/InitialiseSettings often 1 step behind.

It happened again today, with this patch. This time I left it broken for a while so I could investigate.

Jan 23 2020, 12:01 AM · Deployments, Release-Engineering-Team, Performance-Team (Radar), serviceops

Jan 22 2020

Catrope updated the title for P10246 config mis-sync: servers sorted by mtime delta between InitialiseSettings.php and cache file from untitled to config mis-sync: servers sorted by mtime delta between InitialiseSettings.php and cache file.
Jan 22 2020, 11:53 PM
Catrope created P10246 config mis-sync: servers sorted by mtime delta between InitialiseSettings.php and cache file.
Jan 22 2020, 11:52 PM
Catrope edited P10245 2020-01-22 config mis-sync good and bad servers.
Jan 22 2020, 11:17 PM
Catrope created P10245 2020-01-22 config mis-sync good and bad servers.
Jan 22 2020, 11:11 PM
Catrope moved T243213: Allow extensions to register handlers with factories without the use of global variables from Inbox to In progress on the TechCom board.
Jan 22 2020, 9:35 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
Catrope moved T243036: Newcomer tasks: rules for duplicate results from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 22 2020, 8:34 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope added a comment to T236104: Cache of wmf-config/InitialiseSettings often 1 step behind.

Thanks to Giuseppe I got dsh+keyholder to work: SSH_AUTH_SOCK=/run/keyholder/proxy.sock dsh -r ssh -F 20 -M -g mediawiki-installation -o -i/etc/keyholder.d/mwdeploy -o -oUser=mwdeploy -o -oBatchMode=yes -- 'echo "echo \$wgGEHomepageSuggestedEditsTopicsRequiresOptIn ? \"BAD\" : \"good\";" | sudo -u www-data php /srv/mediawiki/multiversion/MWScript.php eval.php --wiki=cswiki | head -n 1'

Jan 22 2020, 7:00 AM · Deployments, Release-Engineering-Team, Performance-Team (Radar), serviceops
Catrope added a comment to T236104: Cache of wmf-config/InitialiseSettings often 1 step behind.

I encountered this bug again today, when deploying this config change. My teammates reported that the feature we'd just enabled was working about half the time, which likely means that about half (or at least a significant fraction, much more than 10%) of the app servers had an outdated config, I tried to use dsh to count how many app servers were affected, but I couldn't get keyholder to work. It gave me a "Too many authentication failures" error message for each host.

Jan 22 2020, 1:58 AM · Deployments, Release-Engineering-Team, Performance-Team (Radar), serviceops

Jan 21 2020

Catrope added a comment to T44085: Wikimedia needs a URL shortener (tracking).

It looks like @kaldari has updated the wiki page: https://www.mediawiki.org/w/index.php?title=Requests_for_comment%2FURL_shortener&type=revision&diff=3618236&oldid=2842533

Jan 21 2020, 10:40 PM · User-Ladsgroup, Proposal, TechCom-RFC (TechCom-RFC-Closed), Tracking-Neverending, WorkType-NewFunctionality, Wikimedia-General-or-Unknown
Catrope updated the task description for T243213: Allow extensions to register handlers with factories without the use of global variables.
Jan 21 2020, 9:18 PM · User-Daniel, TechCom, CPT Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
Catrope added a comment to T239084: Homepage wording suggestions.

Supplementing this with the reasoning that Amir provided in his commit messages, and highlighting what the changes are:

Jan 21 2020, 7:05 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T243211: CAS update failed on user_touched. The version of the user to be saved is older than the current version. from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 21 2020, 3:24 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Growth-Team (Current Sprint), GrowthExperiments-Homepage

Jan 17 2020

Catrope added a comment to T242052: Newcomer tasks: topic matching instrumentation.

@Tgr -- okay, I just talked to @Catrope about wanting to SWAT this on Tuesday. Because we don't want there to be a few days of the topic era that don't have this element as part of their events.

Jan 17 2020, 9:54 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope added a project to T243078: Variant test: Say hi to mentor notification: Growth-Team.
Jan 17 2020, 9:47 PM · Growth-Team, GrowthExperiments-HomepageDiscovery, GrowthExperiments-Homepage
Catrope assigned T238320: Deploy Newcomer Homepage to Ukrainian, Hungarian, Armenian Wikipedias to Trizek-WMF.

The config patches are done. The next step is for @Trizek-WMF to set a deployment date for each wiki.

Jan 17 2020, 3:36 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope updated the task description for T238320: Deploy Newcomer Homepage to Ukrainian, Hungarian, Armenian Wikipedias.
Jan 17 2020, 3:36 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope assigned T238319: Deploy Help Panel to Ukrainian, Hungarian, Armenian Wikipedias to Trizek-WMF.

The config patches are done. The next step is for @Trizek-WMF to set a deployment date for each wiki.

Jan 17 2020, 3:28 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope updated the task description for T238319: Deploy Help Panel to Ukrainian, Hungarian, Armenian Wikipedias.
Jan 17 2020, 3:28 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope added a comment to T230676: Deploy Growth experiments at Armenian Wikipedia.

Which namespace(s) and/or categories the Help panel search should handle = https://hy.wikipedia.org/wiki/%D4%BF%D5%A1%D5%BF%D5%A5%D5%A3%D5%B8%D6%80%D5%AB%D5%A1:%D5%8E%D5%AB%D6%84%D5%AB%D5%BA%D5%A5%D5%A4%D5%AB%D5%A1:%D5%95%D5%A3%D5%B6%D5%B8%D6%82%D5%A9%D5%B5%D5%B8%D6%82%D5%B6

@Trizek-WMF: We don't support category search here yet, you can only search in entire namespaces. Right now, all wikis that have the help panel search in namespaces 4 (Wikipedia) and 12 (Help).

Jan 17 2020, 3:11 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team
Catrope added a comment to T230478: Get the Growth experiment for the Hungarian Wikipedia.

Which namespace(s) and/or categories the Help panel search should handle (0 is mandatory) = 0, 4; Kategória:Segítség

I don't believe 0 is mandatory here at all. The normal setting is 4, 12 (Wikipedia and Help). We also don't have support for searching in categories right now.

Jan 17 2020, 3:03 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Tgr, Growth-Team
Catrope added a comment to T230478: Get the Growth experiment for the Hungarian Wikipedia.

On which namespaces it have to be deployed = 0, 2, 4

Shouldn't this be 2, 4, 12? That's how all our existing wikis are configured. Including 0 worries me in particular. See also T231720#5811842

Jan 17 2020, 3:02 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Tgr, Growth-Team
Catrope added a comment to T238319: Deploy Help Panel to Ukrainian, Hungarian, Armenian Wikipedias.

The ukwiki and huwiki patch don't enable the help panel in the main namespace in read mode, even though that was requested, because it's unusual and we've never done it before. If we decide that is desired, we can do it, but for now I'm erring on the side of caution. I brought this up on the Ukranian-specific task at T231720#5811842.

Jan 17 2020, 3:00 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope added a comment to T231720: Deploy Growth experiments at Ukrainian Wikipedia.

On which namespaces it have to be deployed = 0, 2, 4

Just checking, this means the help panel would appear in read mode on pages in the main, User and Wikipedia namespaces, but not in the Help namespace. Is that intended? On every other wiki that has the help panel, we don't enable it in the main namespace, and do enable it in the Help namespace (in other words, we do 2, 4, 12). Note that this is just about where the help panel appears in read mode; in edit mode it will appear in every namespace.

Jan 17 2020, 2:57 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team
Catrope assigned T238295: Deploy Welcome Survey to Ukrainian, Hungarian, Armenian Wikipedias to MMiller_WMF.

The patch above is incomplete, we'll need to add the URLs of the translated privacy policies once they're available. Assigning to @MMiller_WMF since he's the liaison with Legal for that.

Jan 17 2020, 2:28 AM · Patch-For-Review, Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope moved T238294: Deploy EditorJourney to Ukrainian, Hungarian, Armenian Wikipedias from Ready for Development to Needs PM Review on the Growth-Team (Current Sprint) board.

This is ready to go, waiting on a decision from @MMiller_WMF as to when to deploy this. We probably want @nettrom_WMF to be around?

Jan 17 2020, 2:24 AM · Growth-Team (Current Sprint), Product-Analytics, GrowthExperiments
Catrope added a comment to T242808: Newcomer tasks: mobile - Topic filters check marks overlaps labels.

I can't reproduce this on desktop Chrome (with or without mobile emulator), desktop Firefox (with or without mobile emulator), or mobile Chrome (on Android). Does this only happen on iPhones? Does it happen in desktop Safari too?

Jan 17 2020, 1:59 AM · Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope moved T224883: Homepage: discovery of homepage after account creation (mobile) from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 17 2020, 1:42 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Growth-Team (Current Sprint), Growth Design, GrowthExperiments-HomepageDiscovery, Mobile, GrowthExperiments-Homepage

Jan 16 2020

Catrope added a comment to T243026: Newcomer tasks: ambassadors test topic matching in production.

For completeness: if you want to turn topic matching back off and test the UI that normal users see, you can run step 3 but with the 1 changed to a 0:

new mw.Api().saveOption('growthexperiments-homepage-suggestededits-topics-enabled', 0).done( function() { window.location.reload() });
Jan 16 2020, 10:04 PM · User-Dyolf77, NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope moved T242418: Newcomer tasks: add article counter to footer of start editing dialog from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 16 2020, 7:28 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope added a comment to T205361: Make an HTML dump of the output of the CodeReview extension on MediaWiki.org.

Looks good to me

Jan 16 2020, 12:29 AM · Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-extensions-CodeReview
Catrope reassigned T242932: Remove censorship bar from Turkish Wikipedia logo from Catrope to Reedy.
Jan 16 2020, 12:24 AM · Turkish-Sites, Wikimedia-Site-requests
Catrope closed T242932: Remove censorship bar from Turkish Wikipedia logo as Resolved.
Jan 16 2020, 12:24 AM · Turkish-Sites, Wikimedia-Site-requests

Jan 15 2020

Catrope updated subscribers of T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I'm very excited about this proposal and eager to adopt a modern framework like Vue!
I think there's still a lot of infrastructure that needs to be put in place to take advantage of single-file components, and I'm wondering what the developer experience is like without them.

Supporting single-file components wouldn't actually be that hard at all. With small modifications to our existing infrastructure, we could have ResourceLoader automatically remap SFCs to JS component definitions (with the template as a string), because this transformation is very simple. We wouldn't be able to support ES6 or scoped styles though (because those depend on preprocessing steps that use nodejs libraries).

Jan 15 2020, 11:18 PM · Security-Team, TechCom-RFC
Catrope added a comment to T242400: Newcomer tasks: ambassadors test morelike.

I created the page and made the changes as suggested.

Jan 15 2020, 8:21 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Dyolf77, NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope added a comment to T223988: Wrong grammatical case of month names in Slavic languages in StructuredDiscussions extension.

@Catrope Would that PR also solve the same problem with dates in Special:Notifications?

Jan 15 2020, 3:38 AM · Upstream, I18n, Growth-Team, StructuredDiscussions

Jan 14 2020

Catrope closed T222851: Improve Echo seentime code for multi-DC access, a subtask of T212129: Use a multi-dc aware store for ObjectCache's MainStash if needed., as Resolved.
Jan 14 2020, 5:13 PM · MediaWiki-General, serviceops-radar, User-mobrovac, User-jijiki, Performance-Team (Radar), Operations
Catrope closed T222851: Improve Echo seentime code for multi-DC access, a subtask of T234294: Configurable timestamp storage, as Resolved.
Jan 14 2020, 5:13 PM · Growth-Team, Notifications, Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Multi-DC Echo Notification Storage)
Catrope closed T222851: Improve Echo seentime code for multi-DC access as Resolved.
Jan 14 2020, 5:13 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), CPT Initiatives (Multi-DC Echo Notification Storage), User-Eevans, Growth-Team, Notifications
Catrope updated the task description for T222851: Improve Echo seentime code for multi-DC access.
Jan 14 2020, 5:13 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), CPT Initiatives (Multi-DC Echo Notification Storage), User-Eevans, Growth-Team, Notifications
Catrope added a comment to T242698: Newcomer tasks: hidden preference.

I've scheduled the config patch for the 19:00 UTC SWAT on Thursday Jan 16. The train should already have run by then (it's scheduled for 14:00-15:00 UTC).

Jan 14 2020, 2:16 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope added a comment to T242698: Newcomer tasks: hidden preference.

Once this is deployed, the following console snippet will enable topic matching in production:

new mw.Api().saveOption('growthexperiments-homepage-suggestededits-topics-enabled', 1).done( function() { window.location.reload() });

To turn it back off, change the 1 to 0.

Jan 14 2020, 2:11 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope moved T242698: Newcomer tasks: hidden preference from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Jan 14 2020, 2:05 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), NewcomerTasks 1.1, Growth-Team (Current Sprint)

Jan 13 2020

Catrope moved T238612: Newcomer tasks: topic filters from Code Review to QA on the Growth-Team (Current Sprint) board.
Jan 13 2020, 11:38 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1

Jan 10 2020

Catrope added a comment to T242446: Decide timing of the automatic mediawiki branch cut.

I think having the branch be cut at a fixed time would be good in general, because it would make the process more predictable. It would be helpful if the branch cut happened late enough in the day that there's an opportunity for people to merge patches on Tuesday morning in time for the train, but I also recognize that you can't both cut it late enough that developers on the US west coast have a chance to merge patches (say 18:00 UTC) and also cut it early enough that a releng team member in Europe can run the train (which currently happens at 14:00 UTC, when it happens).

Jan 10 2020, 10:31 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Core Platform Team, Release-Engineering-Team (Deployment services), Goal
Catrope added a comment to T242414: Consider adding suggestion widget to OOUI.

There are some issues with the existing code in MachineVision that I ran into when I copied it to GrowthExperiments:

  • It depends on mediawiki.template.mustache+dom, which is in the WikibaseMediaInfo extension (MachineVision already depends on WBMI, but it doesn't make sense for GrowthExperiments to depend on WBMI)
  • The mustache+dom templating engine avoids destructively rerendering embedded OOUI widgets, which is good, but it does destructively rerender nodes created by the template. This is a problem, because it breaks CSS transitions for state changes.
  • Because CSS transitions don't work, the widget uses CSS animations instead. But that causes a bug where the widgets animate (the text moves from left to right) when they're being unhidden or added to the DOM.
  • There is no clean group widget for these, so I had to make one by picking the relevant pieces from ImageWithSuggestionsWidget (which contains a lot of other things as well). Without that, the SuggestionWidgets don't behave correctly, because they rely on a CSS class set on the parent element to hide the outline.
  • These widgets don't extend SelectWidget and OptionWidget, which means you have to reinvent some wheels around selection management and getting the selected values from the group widget for example
Jan 10 2020, 9:06 PM · MachineVision, Structured-Data-Backlog, OOUI, Growth-Team, GrowthExperiments
Catrope added a comment to T242400: Newcomer tasks: ambassadors test morelike.

Links to the config pages:

Jan 10 2020, 7:29 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Dyolf77, NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope placed T238612: Newcomer tasks: topic filters up for grabs.

Like Kosta I also ran out of time, so I'll put this back in the pool so that either Kosta can pick it up in his morning, or I can pick it up in my morning tomorrow.

Jan 10 2020, 12:53 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope moved T238611: Newcomer tasks: topic filter button from Code Review to QA on the Growth-Team (Current Sprint) board.

The button doesn't do anything yet when clicked, but I'm going to implement that as part of T238612

Jan 10 2020, 12:30 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Growth-Team (Current Sprint), NewcomerTasks 1.1

Jan 9 2020

Catrope moved T238612: Newcomer tasks: topic filters from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Jan 9 2020, 11:45 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope claimed T238612: Newcomer tasks: topic filters.
Jan 9 2020, 11:45 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope added a comment to T238610: Newcomer tasks: include topics in intro overlay.

hi there - I think the mock-ups were based on the v1.0 'final mocks' which have since had minor text changes. I've just updated to match what's in the copy doc and happy to go with option B as well.

Jan 9 2020, 11:26 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1

Jan 8 2020

Catrope closed T233465: Newcomer tasks: article configurations for topics, a subtask of T231506: Newcomer tasks: prototype topic matching, as Resolved.
Jan 8 2020, 11:30 PM · NewcomerTasks 1.1, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope closed T233465: Newcomer tasks: article configurations for topics as Resolved.

These are now done:

Jan 8 2020, 11:30 PM · CommRel-Specialists-Support (Jul-Sep-2019), NewcomerTasks 1.1, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope closed T241021: Newcomer tasks: article configurations for topics (viwiki), a subtask of T233465: Newcomer tasks: article configurations for topics, as Resolved.
Jan 8 2020, 11:30 PM · CommRel-Specialists-Support (Jul-Sep-2019), NewcomerTasks 1.1, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope closed T241021: Newcomer tasks: article configurations for topics (viwiki) as Resolved.

I have transferred the config to this page on viwiki, which is protected so that only admins can edit it: https://vi.wikipedia.org/wiki/MediaWiki:NewcomerTopics.json

Jan 8 2020, 11:30 PM · NewcomerTasks 1.1, Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T240512: Newcomer tasks: Morelike backend for topic matching.

@kostajh @Tgr @Catrope -- when I try this on Czech or Korean Beta, I am able to select a task type from the dropdown, but the topic field remains free text, with no choices. Does something need to be changed?
I'm here: https://cs.wikipedia.beta.wmflabs.org/wiki/Speci%C3%A1ln%C3%AD:API_p%C3%ADskovi%C5%A1t%C4%9B#action=query&format=json&list=growthtasks

Jan 8 2020, 6:29 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), NewcomerTasks 1.1, Growth-Team (Current Sprint)
Catrope moved T238610: Newcomer tasks: include topics in intro overlay from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Jan 8 2020, 2:24 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1

Jan 6 2020

Catrope placed T238888: Variant tests: "initiation" test up for grabs.
Jan 6 2020, 10:19 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Growth-Team (Current Sprint), NewcomerTasks Future Release

Dec 20 2019

Catrope added a comment to T238610: Newcomer tasks: include topics in intro overlay.

@MMiller_WMF @RHo The copy for the "base paragraph" is significantly different between the mockups for this task, and what's currently in production. What should the base paragraph be? And should this be different depending on whether topic matching is enabled or disabled?

Dec 20 2019, 11:39 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1

Dec 19 2019

MMiller_WMF awarded T238610: Newcomer tasks: include topics in intro overlay a Yellow Medal token.
Dec 19 2019, 10:56 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1
Catrope moved T240411: Newcomer tasks: graph icon is off the card in Arabic from QA to Code Review on the Growth-Team (Current Sprint) board.
Dec 19 2019, 8:27 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T240411: Newcomer tasks: graph icon is off the card in Arabic.

The difference is because Arabic Wikipedia's MediaWiki:Common.css has a rule .mw-body-content { font-size: .95em }, which makes all text ~1.12x the size it would normally be. We use ems (which are relative to the font size) for sizing the text, but px (which are absolute) for sizing the box, so the text grows while the box doesn't. If we would use ems for the box's height, the box would also grow 1.12x and everything would fit again.

Dec 19 2019, 8:19 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope claimed T238610: Newcomer tasks: include topics in intro overlay.
Dec 19 2019, 3:51 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Growth-Team (Current Sprint), NewcomerTasks 1.1

Dec 17 2019

Catrope moved T238179: Newcomer tasks: get rid of reload after suggested edits initiation from Code Review to QA on the Growth-Team (Current Sprint) board.
Dec 17 2019, 1:04 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Growth-Team (Current Sprint), NewcomerTasks Future Release , GrowthExperiments-Homepage
Catrope moved T238165: Newcomer tasks: task explanation widget should not have "x" from Code Review to QA on the Growth-Team (Current Sprint) board.
Dec 17 2019, 11:31 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Dec 16 2019

Thgoiter awarded T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) a Burninate token.
Dec 16 2019, 6:06 PM · Regression, Core Platform Team, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, MediaWiki-Watchlist, Growth-Team

Dec 14 2019

Catrope moved T235723: Newcomer tasks: intro and difficulty overlays from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Dec 14 2019, 12:07 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope added a comment to T235723: Newcomer tasks: intro and difficulty overlays.

hi @Catrope - there's a few minor style issues on the desktop version of the overlays which I've listed below (will keep all style issues for the mobile version of overlays tracked on the T234854).

Intro overlay

(1) Subheader text should be slightly smaller and have a greater line-height across all versions: .mw-ge-startediting-dialog-intro-general-subheader {font-size: 16px; line-height: 1.375;}

Dec 14 2019, 12:07 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage

Dec 13 2019

Catrope moved T236854: [mobile] Newcomer tasks - UI issues with Suggested edits module and Difficulty overlay from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Dec 13 2019, 10:52 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), NewcomerTasks 1.0 , Growth-Team (Current Sprint)
Catrope added a comment to T236854: [mobile] Newcomer tasks - UI issues with Suggested edits module and Difficulty overlay.

We hadn't yet updated the icon, but we had been using the old icon but enlarged and positioned in a better way. This regressed in rEGREa64079ba6964: Suggested Edits: Use Drawer component on mobile, which broke the mobile-specific styling for this icon by introducing a typo in the CSS class name for its wrapper. The first patch fixes the typo and restores the old styling. I'll submit a patch to use the new icon after lunch.

Dec 13 2019, 8:25 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), NewcomerTasks 1.0 , Growth-Team (Current Sprint)
Catrope moved T238888: Variant tests: "initiation" test from Ready for Development to QA on the Growth-Team (Current Sprint) board.
Dec 13 2019, 6:40 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Growth-Team (Current Sprint), NewcomerTasks Future Release

Dec 12 2019

Catrope added a comment to T203941: Allow watchlist notifications to be delivered as web notification (through Echo).

Since this also changes the email notifications for watchlist edits (from the old style to the Echo style), this will need to be rolled out carefully. We'd be moving a lot of people's cheese, and some pretty important cheese at that.

Dec 12 2019, 7:57 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), User-notice, Google-Code-in-2019, Growth-Team, WMSE-Bug-Reporting-and-Translation-2018, MediaWiki-Watchlist, Notifications
Catrope added a comment to T238888: Variant tests: "initiation" test.

I've merged the patch which adds a new preference for tracking this variant, but as I wrote in T238888#5696207 I'm curious if we plan to add individual preferences for every variant or if we should use a single preference that contains the various variant groups that a user might be in.

Dec 12 2019, 7:50 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Growth-Team (Current Sprint), NewcomerTasks Future Release

Dec 11 2019

Catrope added a comment to T232396: Variant tests: align treatment groups.

@Catrope -- how will your implementation handle users who change their preferences manually? Does it, like, automatically turn off help panel if a user turns off homepage? Or is more like it sets them both on for a user, but then whatever happens after that is up to the user?

It's the latter: at signup time, we will either enable both or neither, but after that the user can do whatever they want in their preferences. There are still separate preferences for the homepage and the help panel, and the user can choose to turn on/off one but not the other.

Dec 11 2019, 11:30 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Growth-Team (Current Sprint), NewcomerTasks Future Release , Product-Analytics (Kanban), GrowthExperiments-Homepage
Catrope moved T238282: Newcomer tasks: desktop module styling issues from Code Review to QA on the Growth-Team (Current Sprint) board.
Dec 11 2019, 11:00 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Catrope moved T238322: Newcomer tasks: pageview info doesn't fit article card from Code Review to QA on the Growth-Team (Current Sprint) board.
Dec 11 2019, 10:48 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), User-PPham, NewcomerTasks 1.0 , Growth-Team (Current Sprint)
Catrope moved T232419: Newcomer tasks: suggested edits initiation and overlays from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.

Once this patch is merged, remember to remind the ambassadors to get the changed messages retranslated (they are growthexperiments-homepage-startediting-subheader-edit-typo and growthexperiments-homepage-startediting-subheader-other).

Dec 11 2019, 2:28 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage

Dec 10 2019

Catrope added a comment to T219592: Frequent Echo DB_MASTER write queries on HTTP GET.

I did a bit of thinking about what a WatchedItemStore-like solution could look like. Here's my best idea so far:

  • When marking a notification as read:
    • Check if the notification is already marked as read in the DB; if it is, bail
    • Add its ID to the cached going-to-be-marked-as-read list in MainStash (using merge())
    • Enqueue a job to mark it as read in the DB
    • Purge the cached notification count in WANCache
  • When computing the notification count (i.e. the getWithSetCallback calback for the cached notification count in WANCache):
    • Get the going-to-be-marked-as-read list from cache
    • Query the number of unread notifications from the DB
    • Subtract the length of the going-to-be-marked-as-read list from the DB query result, and return that
  • In the job that marks things as read:
    • Update the DB to mark the notification as read
    • Remove the notification from the going-to-be-marked-as-read list (using merge())
    • Purge the cached notification count in WANCache (needed for convergence after race conditions, see below)
Dec 10 2019, 12:21 AM · CPT Initiatives (Multi-DC (TEC1)), Growth-Team, Notifications, Services (watching), Performance-Team (Radar), Availability (MediaWiki-MultiDC)

Dec 6 2019

Catrope added a comment to T240000: Config on the RequestContext may not be the same as the main config.

Going one step further: config being both a request property and a service seems weird. I think we should make up our mind about which one it is. I'd suggest that the config should be a service, not a request property, and so we should not just deprecate RequestContext::setConfig(), but also (soft-)deprecate RequestContext::getConfig() and move away from it in favor of the MainConfig service. There is a little bit of precedent for this, we deprecated ResourceLoaderContext::getConfig() this year.

Dec 6 2019, 8:34 PM · TechCom, Anti-Harassment, MediaWiki-General

Dec 5 2019

Catrope moved T238164: Newcomer tasks: Use Drawer component for mobile UI from Code Review to QA on the Growth-Team (Current Sprint) board.
Dec 5 2019, 1:04 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Dec 4 2019

Catrope changed Due Date from Dec 3 2019, 8:00 AM to Dec 18 2019, 8:00 AM on T208369: Welcome survey: anonymize data after one year.
Dec 4 2019, 10:23 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)

Nov 28 2019

Catrope added a comment to T239371: Support skinScripts and languageScripts in packageFiles.

I'm not sure yet which one I prefer. I think that A is messy and confusing, but that B and C would probably work. I like declarative things generally, so I like B for that reason, but I also like the flexibility of C. (They're also not mutually exclusive, we could support both.)

Nov 28 2019, 2:23 AM · Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team
Catrope added a comment to T239371: Support skinScripts and languageScripts in packageFiles.

I'll just start throwing around some ideas here:

Nov 28 2019, 2:19 AM · Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team
Catrope created T239371: Support skinScripts and languageScripts in packageFiles.
Nov 28 2019, 12:24 AM · Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team

Nov 27 2019

Catrope moved T239275: Deferred update EchoHooks::onPageContentSaveComplete failed: Argument passed to generateMentionEvents() must be array from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Nov 27 2019, 1:59 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Growth-Team (Current Sprint), Notifications, Wikimedia-production-error
Catrope claimed T239275: Deferred update EchoHooks::onPageContentSaveComplete failed: Argument passed to generateMentionEvents() must be array.
Nov 27 2019, 1:59 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Growth-Team (Current Sprint), Notifications, Wikimedia-production-error