Page MenuHomePhabricator
Feed Advanced Search

Jan 16 2017

Filip added a comment to T155405: Provide clear error message when SocialProfile extension is not installed..

Possible issue also in PictureGame, but not tested.

Jan 16 2017, 11:13 AM · Patch-For-Review, good first task, PollNY, PictureGame, QuizGame, Social-Tools
Filip updated subscribers of T155405: Provide clear error message when SocialProfile extension is not installed..
Jan 16 2017, 11:07 AM · Patch-For-Review, good first task, PollNY, PictureGame, QuizGame, Social-Tools
Filip created T155405: Provide clear error message when SocialProfile extension is not installed..
Jan 16 2017, 11:05 AM · Patch-For-Review, good first task, PollNY, PictureGame, QuizGame, Social-Tools
Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

@Qgil: @Phantom42: Tested, looks good!

Jan 16 2017, 9:09 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter

Jan 15 2017

Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

@Phantom42: We need to get merged this previous patch. Will checkout them, and try this out tomorrow!

Jan 15 2017, 10:02 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip claimed T155324: QuizGame admin panel: Pressing delete or reinstate should ask for confirmation before performing the action.
Jan 15 2017, 9:41 PM · Patch-For-Review, Design, Social-Tools, QuizGame
Filip claimed T154498: Remove remaining ContentHandler deprecated functions and hooks.
Jan 15 2017, 9:09 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), User-Daniel, Technical-Debt, MediaWiki-ContentHandler
Filip placed T154498: Remove remaining ContentHandler deprecated functions and hooks up for grabs.

@Reedy - I tought we removed all of these usages in these MW tasks. Can you join IRC?

Jan 15 2017, 9:08 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), User-Daniel, Technical-Debt, MediaWiki-ContentHandler
Filip placed T155366: right-create-userbox and action-create-userbox are essentially duplicate i18n messages up for grabs.

Yeah, thats unneeded to do it in separate patch. Thanks!

Jan 15 2017, 8:30 PM · good first task, I18n, Social-Tools, FanBoxes
Filip added a comment to T155366: right-create-userbox and action-create-userbox are essentially duplicate i18n messages.

@SamanthaNguyen: Looks like there's more unneeded messages. Will do small research on it

Jan 15 2017, 8:26 PM · good first task, I18n, Social-Tools, FanBoxes
Filip added a comment to T155366: right-create-userbox and action-create-userbox are essentially duplicate i18n messages.

Looks like someone added this as "permission", and then at action. I think its ok to remove it.

Jan 15 2017, 8:17 PM · good first task, I18n, Social-Tools, FanBoxes
Filip claimed T155366: right-create-userbox and action-create-userbox are essentially duplicate i18n messages.
Jan 15 2017, 8:10 PM · good first task, I18n, Social-Tools, FanBoxes
Filip updated subscribers of T154498: Remove remaining ContentHandler deprecated functions and hooks.

@MtDu: WIll clean up functions, I'll do hooks

Jan 15 2017, 1:22 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), User-Daniel, Technical-Debt, MediaWiki-ContentHandler
Filip claimed T154498: Remove remaining ContentHandler deprecated functions and hooks.
Jan 15 2017, 1:21 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), User-Daniel, Technical-Debt, MediaWiki-ContentHandler
Filip placed T155339: Convert WikiObjectModel to use extension registration up for grabs.
Jan 15 2017, 12:48 PM · MediaWiki-extensions-Other
Filip claimed T155339: Convert WikiObjectModel to use extension registration.
Jan 15 2017, 12:13 PM · MediaWiki-extensions-Other
Filip placed T155034: Extension WikiObjectModel failing tests due to missing apihelp messages up for grabs.
Jan 15 2017, 12:12 PM · Patch-For-Review, I18n, good first task, MediaWiki-extensions-Other, Continuous-Integration-Config
Filip created T155339: Convert WikiObjectModel to use extension registration.
Jan 15 2017, 12:01 PM · MediaWiki-extensions-Other
Filip claimed T155034: Extension WikiObjectModel failing tests due to missing apihelp messages.
Jan 15 2017, 11:49 AM · Patch-For-Review, I18n, good first task, MediaWiki-extensions-Other, Continuous-Integration-Config
Filip added a watcher for good first task: Filip.
Jan 15 2017, 11:48 AM
Filip added a comment to T145728: Clean up ContentHandler deprecated functions and hooks.

We only need to resolve T154498 , and everything will be done.

Jan 15 2017, 11:07 AM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), Patch-For-Review, MW-1.28-release-notes, Technical-Debt, MediaWiki-ContentHandler
Filip added a comment to T154763: Subscribe/Unsubscribe newsletter floating dialog disappears too soon.

@01tonythomas: @QuimGil: @MtDu: After T155228 we wanted to modify this setting, but I see, messages got edited. ^^ I'm not sure. Anyway, thanks @MtDu for help with this!

Jan 15 2017, 11:02 AM · Patch-For-Review, Google-Code-In-2016, Design, MediaWiki-extensions-Newsletter

Jan 14 2017

Filip closed T154384: "View Source" link appears as "Edit" for autoconfirmed users (who cannot edit newsletters) as Resolved.

Now all of Newsletter groups are only to sysop. Can't recreate this.

Jan 14 2017, 6:05 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
Filip removed a project from T148006: Wrong "Log in" link title on private wiki: Google-Code-In-2016.
Jan 14 2017, 5:21 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes, Patch-For-Review, MediaWiki-User-login-and-signup
Filip added a comment to T154384: "View Source" link appears as "Edit" for autoconfirmed users (who cannot edit newsletters).

GCI is over - we should do some cleanup.

Jan 14 2017, 3:16 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
Filip removed a project from T154384: "View Source" link appears as "Edit" for autoconfirmed users (who cannot edit newsletters): Google-Code-In-2016.
Jan 14 2017, 3:16 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
Filip claimed T154384: "View Source" link appears as "Edit" for autoconfirmed users (who cannot edit newsletters).
Jan 14 2017, 3:14 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
Filip placed T143230: ArticlePlaceholder element positioning has overlaps at 800x600 up for grabs.
Jan 14 2017, 3:11 PM · patch-welcome, Google-Code-In-2016, Wikidata, ArticlePlaceholder
Filip closed T149513: Validate PMID and PMCIDs that are extracted from Zotero's "extra" field in citoid as Resolved.

Marking as resolved!

Jan 14 2017, 12:03 PM · Patch-For-Review, good first task, Google-Code-In-2016, VisualEditor, User-Josve05a, Citoid

Jan 13 2017

Filip added a comment to T154763: Subscribe/Unsubscribe newsletter floating dialog disappears too soon.

@01tonythomas @QuimGil: @MtDu Its not a good solution. So:
In T155228 I'm fixing this bug with autoHideSeconds T155228 . When this will be merged, we should use this option here. The only problem is older MW releases.

Jan 13 2017, 5:21 PM · Patch-For-Review, Google-Code-In-2016, Design, MediaWiki-extensions-Newsletter
Filip renamed T155228: mw.notify() should have "autoHideSeconds" option settable. from mw.notify() should have "autoHideSecounds" option settable. to mw.notify() should have "autoHideSeconds" option settable..
Jan 13 2017, 4:46 PM · MediaWiki-Interface, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8))
Filip added a comment to T149513: Validate PMID and PMCIDs that are extracted from Zotero's "extra" field in citoid.

@Mvolz: Fixed code to keep 'PCM'

Jan 13 2017, 4:23 PM · Patch-For-Review, good first task, Google-Code-In-2016, VisualEditor, User-Josve05a, Citoid
Filip claimed T155228: mw.notify() should have "autoHideSeconds" option settable..
Jan 13 2017, 12:23 PM · MediaWiki-Interface, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8))
Filip updated the task description for T155228: mw.notify() should have "autoHideSeconds" option settable..
Jan 13 2017, 12:21 PM · MediaWiki-Interface, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8))
Filip added a comment to T155228: mw.notify() should have "autoHideSeconds" option settable..

More detailed comment: https://phabricator.wikimedia.org/T154763

Jan 13 2017, 10:42 AM · MediaWiki-Interface, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8))
Filip created T155228: mw.notify() should have "autoHideSeconds" option settable..
Jan 13 2017, 10:41 AM · MediaWiki-Interface, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8))

Jan 12 2017

Filip added a comment to T149513: Validate PMID and PMCIDs that are extracted from Zotero's "extra" field in citoid.

@Mvolz: Made patch implementing this. Looks like a much better solution! Thanks!

Jan 12 2017, 5:35 PM · Patch-For-Review, good first task, Google-Code-In-2016, VisualEditor, User-Josve05a, Citoid
Filip added a comment to T149513: Validate PMID and PMCIDs that are extracted from Zotero's "extra" field in citoid.
Jan 12 2017, 5:25 PM · Patch-For-Review, good first task, Google-Code-In-2016, VisualEditor, User-Josve05a, Citoid
Filip claimed T149513: Validate PMID and PMCIDs that are extracted from Zotero's "extra" field in citoid.
Jan 12 2017, 5:01 PM · Patch-For-Review, good first task, Google-Code-In-2016, VisualEditor, User-Josve05a, Citoid
Filip claimed T143230: ArticlePlaceholder element positioning has overlaps at 800x600.
Jan 12 2017, 3:05 PM · patch-welcome, Google-Code-In-2016, Wikidata, ArticlePlaceholder
Liuxinyu970226 awarded T34950: Use jQuery.suggestions to add reason suggestions to block/delete/protect forms a 100 token.
Jan 12 2017, 5:26 AM · User-notice, MediaWiki-Page-protection, MediaWiki-Page-deletion, JavaScript, MediaWiki-User-management

Jan 11 2017

Filip added a comment to T155086: JS-parser for reasons on block/delete/protect forms too simplistic.

Looks like "Xml::listDropdown" does exacly what we want. I'll just use modified version of this code to create new function which only parses this data.

Jan 11 2017, 4:07 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Patch-For-Review, JavaScript, MediaWiki-Page-protection, MediaWiki-Page-deletion, MediaWiki-User-management
Filip added a comment to T155086: JS-parser for reasons on block/delete/protect forms too simplistic.

Code will be parsed in php files, by addJsConfig function. Like in PS1. It will be simplier to parse this in php.

Jan 11 2017, 1:27 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Patch-For-Review, JavaScript, MediaWiki-Page-protection, MediaWiki-Page-deletion, MediaWiki-User-management
Filip claimed T155086: JS-parser for reasons on block/delete/protect forms too simplistic.

Hmm, you're right. Missed this!

Jan 11 2017, 1:19 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Patch-For-Review, JavaScript, MediaWiki-Page-protection, MediaWiki-Page-deletion, MediaWiki-User-management
Filip added a comment to T34950: Use jQuery.suggestions to add reason suggestions to block/delete/protect forms.

@Florian Thanks!

Jan 11 2017, 8:16 AM · User-notice, MediaWiki-Page-protection, MediaWiki-Page-deletion, JavaScript, MediaWiki-User-management

Jan 10 2017

Filip closed T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches as Resolved.

Ok, patch got merged. Checked everything, propably I can mark it as resolved.

Jan 10 2017, 7:13 PM · Patch-For-Review, Google-Code-In-2016, wikitech.wikimedia.org, Cloud-Services, Technical-Debt
Filip closed T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches, a subtask of T145728: Clean up ContentHandler deprecated functions and hooks, as Resolved.
Jan 10 2017, 7:13 PM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), Patch-For-Review, MW-1.28-release-notes, Technical-Debt, MediaWiki-ContentHandler
Filip closed T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches, a subtask of T154498: Remove remaining ContentHandler deprecated functions and hooks, as Resolved.
Jan 10 2017, 7:13 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), User-Daniel, Technical-Debt, MediaWiki-ContentHandler
Filip added a comment to T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches.

Ok! So:
"SemanticForms" - patch got merged, resolved!
"SemanticMediaWiki" - patch needs review.
"SemanticResultFormats" - Clean
"Validator" - Clean

Jan 10 2017, 6:50 PM · Patch-For-Review, Google-Code-In-2016, wikitech.wikimedia.org, Cloud-Services, Technical-Debt
Filip added a comment to T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches.

"SemanticForms": Is clean
"Validator": Is clean
Not sure about "SemanticMediawiki", but looks OK.
"SemanticResultsFormat" have call to deprecated Article:getContent

Jan 10 2017, 5:06 PM · Patch-For-Review, Google-Code-In-2016, wikitech.wikimedia.org, Cloud-Services, Technical-Debt
Filip claimed T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches.
Jan 10 2017, 3:43 PM · Patch-For-Review, Google-Code-In-2016, wikitech.wikimedia.org, Cloud-Services, Technical-Debt

Jan 9 2017

QuimGil awarded T154763: Subscribe/Unsubscribe newsletter floating dialog disappears too soon a Yellow Medal token.
Jan 9 2017, 8:24 PM · Patch-For-Review, Google-Code-In-2016, Design, MediaWiki-extensions-Newsletter
Filip added a comment to T154763: Subscribe/Unsubscribe newsletter floating dialog disappears too soon.

@QuimGil: (For disappear time solution) Ok, we can't just edit parameter of notification. Notifications should be fired form mw.notify, which does not have setting AutoHideSecounds. And we can't just make new notification, and edit this parameter, becouse this class is not meant to be used like that. So lets keep code correct, and use this 'on-click disappear' solution.

Jan 9 2017, 7:44 PM · Patch-For-Review, Google-Code-In-2016, Design, MediaWiki-extensions-Newsletter
Filip added a comment to T154763: Subscribe/Unsubscribe newsletter floating dialog disappears too soon.

@MtDu: We can also create new notification, change its autoHideSecounds, and notification.notify(), but its not a good solution. I think, hide on click is better solution, simplier, and code its clean.

Jan 9 2017, 5:37 PM · Patch-For-Review, Google-Code-In-2016, Design, MediaWiki-extensions-Newsletter
Filip added a comment to T154763: Subscribe/Unsubscribe newsletter floating dialog disappears too soon.

@MtDu: But this is for notification. We can't create notification from this class. Look at comments in this code, we should use mw.notify, with does not have this option.

Jan 9 2017, 4:36 PM · Patch-For-Review, Google-Code-In-2016, Design, MediaWiki-extensions-Newsletter
Filip added a comment to T154763: Subscribe/Unsubscribe newsletter floating dialog disappears too soon.

@MtDu: Thanks you!

Jan 9 2017, 2:30 PM · Patch-For-Review, Google-Code-In-2016, Design, MediaWiki-extensions-Newsletter
Filip closed T154874: Add log extract to Special:ContentModel as Resolved.

Marking as resolved!

Jan 9 2017, 7:31 AM · MediaWiki-General, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), MW-1.29-release-notes, Patch-For-Review
Filip claimed T154763: Subscribe/Unsubscribe newsletter floating dialog disappears too soon.

@QuimGil: @01tonythomas: Hmm, in test wiki, subscribed to newsletter, and I does not get any pop-up notification.

Jan 9 2017, 7:31 AM · Patch-For-Review, Google-Code-In-2016, Design, MediaWiki-extensions-Newsletter

Jan 8 2017

Filip created T154874: Add log extract to Special:ContentModel.
Jan 8 2017, 6:03 PM · MediaWiki-General, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), MW-1.29-release-notes, Patch-For-Review
Filip claimed T148006: Wrong "Log in" link title on private wiki.
Jan 8 2017, 5:21 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes, Patch-For-Review, MediaWiki-User-login-and-signup
Filip updated subscribers of T131492: Better UI for adding / removing Newsletter publishers.

@Phantom42: Hmm, I tought we can add new HtmlForm without modifying the code, but i'm not sure. @Reedy - what do you think about it?

Jan 8 2017, 1:11 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

@Phantom42: Yeah, I know. But its uneeded to add this to core. Just create new class in Newsletter extension.

Jan 8 2017, 11:10 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

@Phantom42: For me, its onneeded to add new class to core repo. UserMultiselectCapsule is that what you want, just add this class to Newsletter. @01tonythomas

Jan 8 2017, 11:05 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

@Phantom42: Hmm, why split it in 2 patches? Really want to test this!

Jan 8 2017, 9:13 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter

Jan 7 2017

Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

@Phantom42: Hmm, a lot of stuff uses javascript. Maybe just show warning? This would be another task. @01tonythomas: What do you think about it?

Jan 7 2017, 7:41 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

@Phantom42: Awesome! Would love to see this working!

Jan 7 2017, 6:38 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

Shouldn't it be also used in subscriber add/remove? Btw, capsuleMultiselectWidget is exactly what we want, look at https://doc.wikimedia.org/oojs-ui/master/demos/#widgets-mediawiki-ltr-desktop

Jan 7 2017, 6:30 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip claimed T34950: Use jQuery.suggestions to add reason suggestions to block/delete/protect forms.
Jan 7 2017, 3:56 PM · User-notice, MediaWiki-Page-protection, MediaWiki-Page-deletion, JavaScript, MediaWiki-User-management
Filip added a comment to T154383: Autoconfirmed users with `newsletter-create` right can move newsletters.

@Pppery: @01tonythomas: Now newsletter-create is only sysop group.

Jan 7 2017, 3:09 PM · MediaWiki-extensions-Newsletter
Qgil awarded T154342: Remove redundant and unnecessary logging from the Newsletter Extension a Yellow Medal token.
Jan 7 2017, 10:29 AM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter

Jan 6 2017

Filip added a comment to T131492: Better UI for adding / removing Newsletter publishers.

@01tonythomas @MtDu : Yeah, second option is more user-friendly.

Jan 6 2017, 5:36 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Qgil awarded T154534: Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default a Yellow Medal token.
Jan 6 2017, 4:55 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip reopened T154536: page service ignores wiki markup in title/description as "Open".
Jan 6 2017, 1:13 PM · Maps (Kartographer)
Filip closed T154536: page service ignores wiki markup in title/description as Resolved.

Commit message typo

Jan 6 2017, 1:13 PM · Maps (Kartographer)
Filip claimed T154534: Restrict 'newsletter-{create,manage,destroy}' only to 'sysop' by default.

Will do it as GCI task

Jan 6 2017, 12:22 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter

Jan 4 2017

Filip committed rEIDSf3527b28fc2e: Follow mediawiki guidelines (authored by Filip).
Follow mediawiki guidelines
Jan 4 2017, 3:29 PM

Jan 3 2017

Qgil awarded T154230: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed a Yellow Medal token.
Jan 3 2017, 10:19 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Qgil awarded T154136: NewsletterHooks: Return type for onUndeleteForm and wrong concatenation of strings for onTitleMove to be changed a Yellow Medal token.
Jan 3 2017, 8:29 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Qgil awarded T154120: Remove unused SpecialNewsletter:getNewsletterActionButtons() a Like token.
Jan 3 2017, 8:29 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Qgil awarded T154095: (NewsletterStore|NewsletterDb)::(addSubscription|removeSubscription) should allow for multiple users a Yellow Medal token.
Jan 3 2017, 8:26 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip closed T154453: Fix coding standards and add phpcs checks to CI as Resolved.

Marking as resolved, patch merged.

Jan 3 2017, 5:43 PM · Patch-For-Review, Google-Code-In-2016, Community-Tech, good first task, IDS-extension
Filip committed rEIDS0f28c3243212: Introduce CI tests (authored by Filip).
Introduce CI tests
Jan 3 2017, 5:33 PM
Filip committed rEIDS7d54e6d01acc: Introduce CI tests (authored by Filip).
Introduce CI tests
Jan 3 2017, 5:25 PM
Filip committed rEIDS131ca24eadc1: Introduce CI tests (authored by Filip).
Introduce CI tests
Jan 3 2017, 5:21 PM
Filip committed rEIDS167cef13bb38: Introduce CI tests (authored by Filip).
Introduce CI tests
Jan 3 2017, 5:16 PM
Filip closed T154043: Add ability to configure the web service endpoint in the IDS extension as Resolved.

@Reedy merged, marking as resolved!

Jan 3 2017, 5:13 PM · Google-Code-In-2016, Patch-For-Review, good first task, Community-Tech, IDS-extension
Filip closed T154043: Add ability to configure the web service endpoint in the IDS extension, a subtask of T154044: Epic: Support custom Han characters on Chinese Wikisource, as Resolved.
Jan 3 2017, 5:13 PM · Wikimedia Taiwan, I18n, Community-Wishlist-Survey-2016, Epic, Chinese-Sites, Wikisource, IDS-extension
Filip committed rEIDS79ec4784985e: Introduce CI tests (authored by Filip).
Introduce CI tests
Jan 3 2017, 4:44 PM
Filip claimed T154453: Fix coding standards and add phpcs checks to CI.
Jan 3 2017, 3:52 PM · Patch-For-Review, Google-Code-In-2016, Community-Tech, good first task, IDS-extension
Filip closed T17000: Special:Import error: "Import failed: Could not open import file" as Resolved.

Patch got merged, so closing as 'resolved'.

Jan 3 2017, 6:59 AM · MediaWiki-Export-or-Import, Operations, Wikimedia-General-or-Unknown
Filip closed T54027: Properly deprecate UnknownAction hook as Resolved.

And merged, marking as resolved.

Jan 3 2017, 6:51 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review, MediaWiki-General, Documentation, MediaWiki-Documentation

Jan 2 2017

Filip closed T13378: Transwiki Special:Import via redirected interwiki URL spews PHP error about HTTP error as Resolved.

@TTO: No longer occur in MediaWiki 1.21. Tried on 3 articles.

Jan 2 2017, 7:47 PM · Google-Code-In-2016, TestMe, MediaWiki-Export-or-Import
Filip claimed T17000: Special:Import error: "Import failed: Could not open import file".

@TTO: Added $wgHTTPImportTimeout setting.

Jan 2 2017, 7:03 PM · MediaWiki-Export-or-Import, Operations, Wikimedia-General-or-Unknown
Filip updated subscribers of T54027: Properly deprecate UnknownAction hook.

@Spage @TTO Completed this list, 2 patches need review, added note to wiki.

Jan 2 2017, 6:29 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review, MediaWiki-General, Documentation, MediaWiki-Documentation

Jan 1 2017

Filip added a comment to T154379: Bizzare behavior when newsletter moved outside Newsletter namespace.

@Pppery: @01tonythomas Cant reproduce error, when I move this to the another namespace, all description data/ after clicking edit button are lost. But no errors are thrown. Tried on fresh git clone. Maybe there's function to pass namespace to move form.

Jan 1 2017, 3:16 PM · MediaWiki-extensions-Newsletter
Filip claimed T154342: Remove redundant and unnecessary logging from the Newsletter Extension.
Jan 1 2017, 3:06 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter

Dec 30 2016

Filip updated the task description for T153906: Newsletter cleanup.
Dec 30 2016, 9:49 PM · Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip added a comment to T154230: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed.

@01tonythomas Oh. looked at wrong MW docs. Fixed!

Dec 30 2016, 5:12 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip added a comment to T154230: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed.

@01tonythomas Updated docs.

Dec 30 2016, 5:04 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter
Filip claimed T154230: EchoNewsletterUserLocator: Return type for locateNewsletterSubscribedUsers function to be changed.
Dec 30 2016, 4:16 PM · Patch-For-Review, Google-Code-In-2016, MediaWiki-extensions-Newsletter