The SQL must follow our Database policy.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 11 2019
Jun 10 2019
It's not just the phpunit test to get the benefit, also have Composer.
Jun 9 2019
Before we have a fundamental solution, you can split the page content via the API.
If the number of people affected is too much, the priority should be High.
I calculated the average duration for phpunit-test on 5 commit that before the patch. (Unit: second)
PHP Version | 1st | 2nd | 3rd | 4th | 5th | avg |
7.2 | 583 | 608 | 561 | 579 | 560 | 578.2 |
7.3 | 603 | 607 | 587 | 567 | 594 | 591.6 |
Jun 8 2019
This is because a patch was not backported to REL1_33.
Jun 7 2019
@Reedy All extensions hosted in WMF-gerrit already done, please check.
A full test should contain 20,000+ tests.
In T225244#5243541, @Reedy wrote:In T225244#5243487, @RazeSoldier wrote:The key is that the Travis CI builds includes a full test of phpunit, and the error also appeared in my test environment.
What is that supposed to mean? That we don't run all the phpunit tests in WMF CI?
The key is that the Travis CI builds includes a full test of phpunit, and the error also appeared in my test environment.
My fault, it is related to my patch.
repo admin can configure whether to test PR. Looks like it is disable in wikimedia/mediawiki.
Jun 6 2019
I have submitted patches of the extensions mentioned by Reedy, except that WikiLexicalData needs clarification.
Jun 5 2019
These tags are not suitable for subtask of train.
On my machine, the test with opcache.enable_cli=1 took about 5 and a half minutes and with opcache.enable_cli=0 took 6 minutes and 20 seconds.
Jun 3 2019
Jun 1 2019
May 30 2019
Merge the fix on master branch is not urgent. Drop priority.
May 29 2019
In T221933#5219611, @Aklapper wrote:@RazeSoldier: What's the sense in enabling something on beta which will not be enabled in production?
Can we enable the extension on beta zhwiki?
In T221933#5216973, @Hamishcn wrote:Is there any possibility for zhwiki to follow enwiki to set up an environment of a light weight form of Flagged Revisions a.k.a. Pending Changes?
May 28 2019
Fixed in f8fbb0f.
Is it necessary to reach certain conditions to enable the extension on zhwiki or to block the extension enabling at fundamentally? If it is the former, what conditions do we need to reach?
Also, is enabling FlaggedRevision extension within the scope of SWAT deploy? Enabling the extension seems complicated.
@Reedy Should I test my patch on beta-zhwiki? If so, this means that it cannot be deployed to zhwiki before June 1.
In T224374#5215627, @Reedy wrote:In T224374#5215626, @RazeSoldier wrote:Related 008428c. It swap the incoming variable of static::$minimumVersion and $serverVersion, made this bug fixed. But also caused an warming on config-*-old i18n messages. In config-*-old, the minimum version is in front, the system version is behind. In config-outdated-sqlite, quite the opposite.
That commit is not related...
But it seems that zh_classicalwiki uses the default configuration. Is there a reference value?
Related 008428c. It swap the incoming variable of static::$minimumVersion and $serverVersion, made this bug fixed. But also caused an warming on config-*-old i18n messages. In config-*-old, the minimum version is in front, the system version is behind. In config-outdated-sqlite, quite the opposite.
May 27 2019
@Reedy I don't know what happened. I ran php maintenance/install.php --env-checks again today and found that the output text was as expected. I am pretty sure that I am running on master branch.
It is very likely that I ignored something and I apologize.
May 26 2019
This bug has existed since 1.30 (introduced in b907358). The patch should be ported backwards into REL1_31, REL1_32 and REL1_33.
May 25 2019
Fixed in fddb7229.
May 24 2019
May 22 2019
In T221933#5206834, @Hamishcn wrote:Could you state exact time?
In T222628#5204429, @hashar wrote:There are various code path from extensions or mediawiki/core that ends up hitting the error. It has been added in mediawiki/core by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/504000/
The first occurrences were on April 30th.
I will schedule the patch on the 27th or 28th in next week.
May 21 2019
In T222024#5201713, @DannyS712 wrote:I just don't use IRC much, and it appears to be a requirement for SWAT deployments
May 20 2019
@Krinkle Still have a problem. See the beta site.
May 19 2019
It seems that this problem is essentially the same as the problem with T222628. A different error message will appear because of the difference(HHVM/PHP7) in PHP interpreter.
If I just leave /* */ comment, Bad value for parameter $dbkey : should not be empty will occur. Already reproduce in the test patch.
05:09 marostegui: varnish-backend-restart on cp1081 - SAL
May 17 2019
When should we deploy the patch?
May 15 2019
I pushed a new patch.
May 10 2019
I think this ticket is the same as T222857, because the revisions has an empty autocomment.
May 9 2019
Linker::formatAutocomments() did not handle empty autocomment.
For my debug, when a revision comment contains /**/ (patten: /\*\s*\*/), the exception will be throw. E.g. my test edit in sandbox
May 8 2019
May 5 2019
So setting $wgFlaggedRevsOverride=false is necessary and fits in the need and agreement in zhwiki.
We can set $wgFlaggedRevsOverride=false, default true.
What is "the English Wikipedia Model"? enwiki set $wgFlaggedRevsOverride=false, so unnecessary disable $wgKartographerEnableMapFrame.
May 3 2019
Checking list:
- Add zhwiki to flaggedrevs.dblist
- Grant movestable, autoreview and review to sysop
- Grant autoreview and review to rollbacker
- Disable $wgKartographerEnableMapFrame on zhwiki
Apr 30 2019
Which wiki has occur this exception?
Apr 26 2019
$wgFlaggedRevsOverride – Whether the stable version is the default content for pages.
Individual pages can be configured to have the stable or draft version as the default content by administrators. -- MediaWiki.org
@1233thehongkonger Due many FlaggedRevs wiki with $wgFlaggedRevsOverride=false ($wgFlaggedRevsOverride: Whether the stable version is the default content for pages). Just in case, do you want to disable this option (default true)?
Add groups:
+Revision Reviewers , - Revision Reviewers
@1233thehongkonger Hello, have a community discussion? Please provide a link to discussion.
Apr 23 2019
Looks like related to T203061.