Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Arlolra closed T235460: Parsoid/PHP does not emit ETags as Resolved.
Mon, Oct 21, 3:12 PM · CPT Initiatives (Parsoid REST API in PHP (CDP2)), Parsoid-PHP
Arlolra closed T235462: Parsoid/JS / RESTBase ETag harmonisation as Resolved.
Mon, Oct 21, 3:12 PM · Core Platform Team Workboards (Clinic Duty Team), Parsing-Team, RESTBase-API, RESTBase, Parsoid

Fri, Oct 18

Arlolra added a comment to T235709: Too many diffs on this page.

https://phabricator.wikimedia.org/P9393

Fri, Oct 18, 8:14 PM · Parsoid-PHP
Arlolra created P9393 (An Untitled Masterwork).
Fri, Oct 18, 7:41 PM

Wed, Oct 16

Arlolra added a comment to T235229: Extension:Indicator renders as a <link /> in Parsoid/PHP and a <span></span> in Parsoid/JS.

This is not because of the indicator extension but because of the maplink extension that surrounds it. This was traced to the ParserAfterParse parser hook not being invoked for the Kartographer extension.

Wed, Oct 16, 8:43 PM · Patch-For-Review, Parsoid-PHP

Fri, Oct 11

Arlolra added a comment to T233736: Testing the REST API in CI.

Probably depends on T227352

Fri, Oct 11, 11:32 PM · Parsoid-PHP
Arlolra triaged T231570: DomSourceRange serializes with null entries as Normal priority.
Fri, Oct 11, 11:30 PM · Parsoid-PHP
Arlolra closed T234057: Get rid of hybrid testing code as Resolved.
Fri, Oct 11, 11:28 PM · Parsoid-PHP
Arlolra added a comment to T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.

With the above patches merged, the mocha tests for this endpoint are passing. They can be run with the following,

Fri, Oct 11, 11:13 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API
Arlolra created T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers).
Fri, Oct 11, 11:00 PM · Parsoid-PHP
Arlolra claimed T234057: Get rid of hybrid testing code.
Fri, Oct 11, 9:59 PM · Parsoid-PHP
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

wonder if we should handle T234057: Get rid of hybrid testing code

Fri, Oct 11, 9:56 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

npm audit and snyk found some vulnerable Node dependencies for the dev dependency nsp (oddly enough, the old package which turned into audit) and service-runner's ms dependency. As I understand it, these packages are not relevant for Parsoid/PHP. Reporting here for the sake of completeness.

Fri, Oct 11, 9:52 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews

Wed, Oct 9

Arlolra created P9290 (An Untitled Masterwork).
Wed, Oct 9, 9:37 PM

Tue, Oct 1

Arlolra added a comment to T233818: Call to a member function getContent() on null.

Presumably selser will not call getContent() in fallback paths ... but if so, that is one place where this edge case will pop up.

Tue, Oct 1, 8:09 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T233818: Call to a member function getContent() on null.

Well, we have to be able to create a page from scratch (with no previous revision). So a zero-length string seems reasonable to me as a fallback, in both the Api config and the integrated config.

Tue, Oct 1, 7:50 PM · Patch-For-Review, Parsoid-PHP

Mon, Sep 30

Arlolra created T234266: Cannot read property 'stored' of undefined.
Mon, Sep 30, 8:31 PM · Parsoid

Thu, Sep 26

Arlolra added a comment to T233818: Call to a member function getContent() on null.

I think I just fixed this in I62868e8dc9eabea4da68a556e692f5f135924a8a

Thu, Sep 26, 10:23 PM · Patch-For-Review, Parsoid-PHP

Wed, Sep 25

Arlolra placed T233815: html2wt: TypeError in ConstrainedText.php up for grabs.
Wed, Sep 25, 6:00 PM · Parsoid-PHP
Arlolra claimed T233815: html2wt: TypeError in ConstrainedText.php.
Wed, Sep 25, 5:29 PM · Parsoid-PHP
Arlolra closed T233819: array_merge(): Argument #2 is not an array as Resolved.
Wed, Sep 25, 5:28 PM · Parsoid-PHP
Arlolra claimed T233819: array_merge(): Argument #2 is not an array.
Wed, Sep 25, 5:08 PM · Parsoid-PHP

Tue, Sep 24

Arlolra added a subtask for T228217: Ensure all the features of parse.js are covered by parse.php: T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess.
Tue, Sep 24, 4:38 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a parent task for T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess: T228217: Ensure all the features of parse.js are covered by parse.php.
Tue, Sep 24, 4:38 PM · Parsoid-PHP
Arlolra created T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess.
Tue, Sep 24, 4:37 PM · Parsoid-PHP
Arlolra created T233736: Testing the REST API in CI.
Tue, Sep 24, 4:34 PM · Parsoid-PHP

Mon, Sep 23

Arlolra claimed T233459: Undefined property: stdClass::$src in TokenUtils.php::tokensToString.
Mon, Sep 23, 10:10 PM · Parsoid-PHP
Arlolra renamed T233459: Undefined property: stdClass::$src in TokenUtils.php::tokensToString from Undefined $src in TokenUtils.php::tokensToString to Undefined property: stdClass::$src in TokenUtils.php::tokensToString.
Mon, Sep 23, 10:03 PM · Parsoid-PHP

Sep 17 2019

Arlolra added a comment to T233062: Tag new release of remex-html.

I think we're just waiting for https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/535291 to get in as well.

Sep 17 2019, 12:54 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, RemexHtml

Sep 12 2019

Arlolra added a comment to T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.

Env, for one, is specifically not intended for use outside of Parsoid.

Sep 12 2019, 7:54 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

Should I rebase the security branch with latest changes to master?

Sep 12 2019, 3:42 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews

Aug 29 2019

Arlolra closed T231592: Parsoid/PHP parser tests run takes 2.5x as long as Parsoid/JS parser tests run as Invalid.

On my laptop

Aug 29 2019, 9:48 PM · Parsoid-PHP, Performance Issue
Arlolra created T231570: DomSourceRange serializes with null entries.
Aug 29 2019, 3:40 PM · Parsoid-PHP

Aug 28 2019

Arlolra added a comment to T230666: git grep strtolower/strtoupper and see which one of them need to be mb_strtolower/mb_strtoupper.

Note function names are case insensitive for when you're grepping.

Aug 28 2019, 8:55 PM · Parsoid-PHP

Aug 19 2019

Arlolra updated the task description for T227209: Security Review For Parsoid-PHP.
Aug 19 2019, 8:45 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

For development and debugging purposes, Parsoid also supports accessing an external MediaWiki installation via its action API. Parsoid/JS doesn't require that external wiki to have installed the ParsoidBatchAPI extension, but Parsoid/PHP depends on that currently (* TODO: Verify *).

Aug 19 2019, 8:44 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews

Aug 17 2019

ToBeFree awarded T118517: [RFC] Use <figure> for media a Like token.
Aug 17 2019, 11:23 PM · Accessibility, Parsing-Team, Wikipedia-Android-App-Backlog, MediaWiki-Parser, TechCom-RFC

Aug 13 2019

Dalba awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Dislike token.
Aug 13 2019, 11:33 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016

Aug 8 2019

Arlolra created P8890 (An Untitled Masterwork).
Aug 8 2019, 10:20 PM
Arlolra created P8889 (An Untitled Masterwork).
Aug 8 2019, 10:09 PM

Aug 5 2019

Arlolra closed T229531: Ensure change from git a0a27f5 is applied to extension/src/Config/SiteConfig as well as Resolved.

The extension implementation is as follow,

Aug 5 2019, 11:16 PM · Parsoid-PHP
Arlolra added a comment to T200678: (OoW) wtp2011 memory correctable errors.

After the upgrade, I confirmed the host was still running the currently deployed version,

Aug 5 2019, 10:15 PM · Operations, ops-codfw
Arlolra added a comment to T200678: (OoW) wtp2011 memory correctable errors.

I ran, SSH_AUTH_SOCK=/run/keyholder/proxy.sock ssh -l deploy-service wtp2011 'depool service=parsoid' from deployment.eqiad.wmnet and it's now showing {"wtp2011.codfw.wmnet": {"weight": 10, "pooled": "no"}, "tags": "dc=codfw,cluster=parsoid,service=parsoid"}

Aug 5 2019, 9:34 PM · Operations, ops-codfw
Arlolra closed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint, a subtask of T229356: Run roundtrip tests with Parsoid/PHP on scandium, as Resolved.
Aug 5 2019, 8:11 PM · Parsoid-PHP
Arlolra closed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint as Resolved.
Aug 5 2019, 8:11 PM · Parsoid-PHP

Aug 3 2019

Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

With that ^ the rt test script at least runs

Aug 3 2019, 2:36 PM · Parsoid-PHP

Aug 2 2019

Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

A quick test with, node bin/roundtrip-test.js --domain ve --parsoidURL http://localhost/rest.php "Main Page", is returning,

Aug 2 2019, 9:43 PM · Parsoid-PHP

Jul 31 2019

Arlolra added a comment to T226523: Template in wikilink target position also returns pipe separated params.

I don't think the last fix deployment has fixed anything regarding that ticket. The Parsoid output is still broken so far I can see.

Jul 31 2019, 4:39 PM · Patch-For-Review, Mobile-Content-Service, Parsoid, Product-Infrastructure-Team-Backlog
Arlolra added a comment to T229375: TypeError in references endpoint.

In the meantime, here's an edit that fixes it,
https://en.wikipedia.org/w/index.php?title=Maine&type=revision&diff=908732865&oldid=908276611&diffmode=source

Jul 31 2019, 4:34 PM · Parsoid, Page Content Service, Product-Infrastructure-Team-Backlog
Arlolra added a comment to T229375: TypeError in references endpoint.

The content seems to contain {{#tag:ref|Maine does not ... <references group="nb" /> |group="nb"}}, which results in references in references.

Jul 31 2019, 4:25 PM · Parsoid, Page Content Service, Product-Infrastructure-Team-Backlog

Jul 30 2019

Arlolra claimed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.
Jul 30 2019, 4:48 PM · Parsoid-PHP
Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

How do we pass in the rt testing flag to Parsoid?

Jul 30 2019, 4:34 PM · Parsoid-PHP
Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

The parsoid config is only used to get prefixes, which isn't really needed.

Jul 30 2019, 4:07 PM · Parsoid-PHP

Jul 26 2019

Jdforrester-WMF awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Like token.
Jul 26 2019, 5:43 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016
Ladsgroup awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Love token.
Jul 26 2019, 11:18 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016

Jul 24 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 24 2019, 8:26 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 24 2019, 7:41 PM · Patch-For-Review, Parsoid-PHP

Jul 23 2019

Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

There should probably be better test coverage of this bin or at least fixing this,
https://github.com/wikimedia/parsoid/blob/master/bin/toolcheck.sh#L19-L21

Jul 23 2019, 10:34 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 10:32 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 9:28 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 9:27 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 6:16 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 5:45 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 4:19 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 4:18 PM · Patch-For-Review, Parsoid-PHP

Jul 22 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 22 2019, 10:08 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

Trying to address T178914: parse.js should have standard arguments as part of this port might be something worth considering.

Jul 22 2019, 9:41 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

@Arlolra has some WIP patches as well so maybe he has some insight into this question.

Jul 22 2019, 5:13 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016

Jul 19 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 19 2019, 4:01 AM · Patch-For-Review, Parsoid-PHP

Jul 18 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 18 2019, 5:49 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

genTest is not relevant in the post-javascript world, so I'm crossing those off

Jul 18 2019, 5:49 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 18 2019, 5:38 PM · Patch-For-Review, Parsoid-PHP

Jul 17 2019

Arlolra closed T228223: tokensToString being called on KV->V looks like a signature mismatch as Resolved.
Jul 17 2019, 10:25 PM · Patch-For-Review, Parsoid-PHP

Jul 16 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 16 2019, 10:50 PM · Patch-For-Review, Parsoid-PHP
Arlolra created T228223: tokensToString being called on KV->V looks like a signature mismatch.
Jul 16 2019, 10:44 PM · Patch-For-Review, Parsoid-PHP
Arlolra triaged T228217: Ensure all the features of parse.js are covered by parse.php as Normal priority.
Jul 16 2019, 8:54 PM · Patch-For-Review, Parsoid-PHP
Arlolra created T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 16 2019, 8:53 PM · Patch-For-Review, Parsoid-PHP
Arlolra placed T217540: Mobile-Sections returns missing images up for grabs.
Jul 16 2019, 7:19 PM · ChangeProp, Product-Infrastructure-Team-Backlog

Jun 28 2019

Arlolra updated the task description for T214994: PP passes that run `atTopLevel` omit HTML stashed in data-mw.
Jun 28 2019, 1:27 PM · Parsoid-Read-Views

Jun 27 2019

Arlolra closed T226583: Support selser in the bin/parse.php as Resolved.
Jun 27 2019, 7:58 PM · Parsoid-PHP

Jun 25 2019

Arlolra triaged T226583: Support selser in the bin/parse.php as Normal priority.
Jun 25 2019, 9:38 PM · Parsoid-PHP
Arlolra created T226583: Support selser in the bin/parse.php.
Jun 25 2019, 9:38 PM · Parsoid-PHP
Arlolra closed T226451: Possible bug in PHP Tokenizer: Unexpected OOM as Resolved.
Jun 25 2019, 8:02 PM · Parsoid-PHP
Arlolra renamed T226523: Template in wikilink target position also returns pipe separated params from Getting wikitext [[ from MCS on EU wiki to Template in wikilink target position also returns pipe separated params.
Jun 25 2019, 6:56 PM · Patch-For-Review, Mobile-Content-Service, Parsoid, Product-Infrastructure-Team-Backlog
Arlolra moved T226523: Template in wikilink target position also returns pipe separated params from Backlog to Link syntax (links & media) on the Parsoid board.
Jun 25 2019, 6:52 PM · Patch-For-Review, Mobile-Content-Service, Parsoid, Product-Infrastructure-Team-Backlog
Arlolra triaged T226523: Template in wikilink target position also returns pipe separated params as Normal priority.
Jun 25 2019, 6:52 PM · Patch-For-Review, Mobile-Content-Service, Parsoid, Product-Infrastructure-Team-Backlog
Arlolra added a comment to T226523: Template in wikilink target position also returns pipe separated params.

This simplifies as, [[{{1x|Main{{!}}Page}}]]

Jun 25 2019, 6:49 PM · Patch-For-Review, Mobile-Content-Service, Parsoid, Product-Infrastructure-Team-Backlog

Jun 24 2019

Arlolra claimed T226451: Possible bug in PHP Tokenizer: Unexpected OOM.
Jun 24 2019, 11:26 PM · Parsoid-PHP
Arlolra closed T225026: Implement Parsoid, the entry point interface, to the Parsoid/PHP composer library as Resolved.

Change 516451 merged by jenkins-bot:

Jun 24 2019, 10:41 PM · Patch-For-Review, Parsoid-PHP
Arlolra closed T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib as Resolved.

Change 509531 merged by jenkins-bot:

Jun 24 2019, 10:23 PM · Parsoid-PHP
Arlolra closed T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib, a subtask of T225026: Implement Parsoid, the entry point interface, to the Parsoid/PHP composer library, as Resolved.
Jun 24 2019, 10:22 PM · Patch-For-Review, Parsoid-PHP
Arlolra merged task T186298: Crash on tree depth of ~4k into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:05 PM · Parsoid
Arlolra merged T186298: Crash on tree depth of ~4k into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:05 PM · Parsoid
Arlolra merged T225974: RangeError: Maximum call stack size exceeded into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:04 PM · Parsoid
Arlolra merged task T225974: RangeError: Maximum call stack size exceeded into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:04 PM · Parsoid
Arlolra added a comment to T225974: RangeError: Maximum call stack size exceeded.

Probably from,
https://it.wikipedia.org/wiki/Nati_nel_1974
https://it.wikipedia.org/wiki/Nati_nel_1992
etc.

Jun 24 2019, 7:04 PM · Parsoid
Arlolra merged T208794: RangeError: Maximum call stack size exceeded into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:04 PM · Parsoid
Arlolra merged task T208794: RangeError: Maximum call stack size exceeded into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:04 PM · Parsoid
Arlolra merged task T211909: Cannot read property '0' of undefined into T208793: Crasher from missing DSR info -> failed encap -> failed wrapSections.
Jun 24 2019, 6:58 PM · Parsoid
Arlolra merged T211909: Cannot read property '0' of undefined into T208793: Crasher from missing DSR info -> failed encap -> failed wrapSections.
Jun 24 2019, 6:58 PM · Parsoid