Page MenuHomePhabricator
Feed Advanced Search

Thu, Nov 19

DLynch added a comment to T265100: [SPIKE] What events are being tracked within the "section=new" flow.

Does this help?

Thu, Nov 19, 6:05 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)
DLynch added a comment to T265100: [SPIKE] What events are being tracked within the "section=new" flow.

Can you confirm this diagram accurately describes how events are being logged at a high level? Sometimes, seeing something visually helps me better understand it.

I have to make my own diagram for this, so hold on.

Thu, Nov 19, 5:26 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)

Tue, Nov 17

DLynch added a comment to T262626: Remove http.client_ip from EventGate default schema (again).

@Nuria
Just like session id a browser re -start will clear error counters

I just wanted to raise that this approach has some issues, because sessionStorage isn't "browser session"-local, it's "current tab"-local. So anyone who browses wikipedia using multiple tabs or by opening new windows will read to this approach as multiple people.

Tue, Nov 17, 3:50 PM · Analytics-Kanban, Product-Analytics, Patch-For-Review, Product-Infrastructure-Data, observability, Privacy Engineering, Analytics, Event-Platform
DLynch moved T264146: Instrument the special characters toolbar from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.

B makes sense. It's asking for an insert from the "Greek" set, not "Greek extended", after all. (And inserting from "Greek extended" does indeed use insert-greekextended.) Sorry I didn't notice the mismatch when I was reviewing those.

Tue, Nov 17, 3:18 AM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools

Tue, Nov 10

DLynch added a comment to T265100: [SPIKE] What events are being tracked within the "section=new" flow.

So! The answer here is "it depends", because there's several variants we could be talking about.

Tue, Nov 10, 11:59 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)

Mon, Nov 9

DLynch added a comment to T259673: Change what event and dialog is shown when people are prevented from switching.

@MNeisler Sorry, I didn't realize when I was kicking it over to you -- the general tumult of last week meant we had a disruption to our normal deployment schedule. 1.36.0-wmf.16 only made it to Group 2 wikis in the noon PST deploy today, so your testing was unfortunately not including the fix. (I had foolishly assumed that it'd already be on its way out when I was making that last comment.)

Mon, Nov 9, 9:36 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, DiscussionTools

Thu, Nov 5

DLynch updated subscribers of T244114: "Publish" button remains greyed out: "TypeError: this.translationView.categoryUI is null".

It's not obviously problematic, at least. There could be some quirk I'm not considering, since I'm not super-familiar with the CX customizations.

Thu, Nov 5, 7:10 PM · JavaScript, Editing-team (FY2020-21 Kanban Board), Wikimedia-production-error, Language-Team (Language-2020-October-December), ContentTranslation

Wed, Nov 4

DLynch added a comment to T265099: Differentiate between events emitted from the Reply Tool and the New Discussion Tool.

If by "Discussion Tool Events" you mean "New discussion section events", then yes.

Wed, Nov 4, 6:26 PM · Product-Analytics, DiscussionTools, Editing-team (FY2020-21 Kanban Board)
DLynch reassigned T259673: Change what event and dialog is shown when people are prevented from switching from DLynch to MNeisler.

I guess you should take a look and verify that it looks correct to you now?

Wed, Nov 4, 6:24 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, DiscussionTools

Mon, Nov 2

DLynch added a comment to T264146: Instrument the special characters toolbar.

Are you able to share a link where we can see what wikis have MediaWiki:Visualeditor-quick-access-characters.json configured so we know where to test this?

Mon, Nov 2, 4:50 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T265101: Instrument event logging for VE's image search.

taking this on for creating the schema specifically. Will hand back off once this is merged

Mon, Nov 2, 4:47 PM · Editing-team (FY2020-21 Kanban Board), Better Use Of Data, SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Product-Infrastructure-Data, Structured-Data-Backlog (Current Work), Editing-Team-Request, VisualEditor

Fri, Oct 30

DLynch added a comment to T264885: Investigate table schema / DB abstraction layer for section/comment watching/unwatching.

The combined patch file:

Fri, Oct 30, 3:32 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools

Thu, Oct 29

DLynch updated the task description for T264146: Instrument the special characters toolbar.
Thu, Oct 29, 11:03 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T264146: Instrument the special characters toolbar.

You got some of the event names wrong, so I'm about to fix them.

Thu, Oct 29, 11:00 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch assigned T260467: Create a change tag for edits made using the New Discussion Tool to Esanders.
Thu, Oct 29, 8:33 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Skipped QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)
DLynch added a comment to T259673: Change what event and dialog is shown when people are prevented from switching.

I took a look. There was a sequencing issue with the events -- the editor-switch.visual-desktop event fired as soon as the switch was requested, so if it later failed because of a template the dialog-prevent-show would believe the switch had already happened and log itself as happening in visual mode.

Thu, Oct 29, 3:04 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, DiscussionTools

Wed, Oct 28

DLynch added a comment to T162291: Autolinking for URLs and magic links (ISBN etc.) not applied when copy-pasting a block of text.

Note "just treat ISBNs as plain text" is exactly *opposite* from the original request made in this bug, which is to somehow ensure that ISBNs are properly magic linked.

Please read the request again. It is not entirely clearly written, but the request is asking ISBNs to be pasted as plain text.

Wed, Oct 28, 10:06 PM · VisualEditor, VisualEditor-CopyPaste, VisualEditor-MediaWiki
DLynch added a comment to T264885: Investigate table schema / DB abstraction layer for section/comment watching/unwatching.

@matmarex So, my logic on both of those fields was to look at the echo_event table and just copy how they were doing it. However, I think you're right that our case differs. Instead we should be copying watchlist:

Wed, Oct 28, 8:16 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
DLynch added a comment to T264885: Investigate table schema / DB abstraction layer for section/comment watching/unwatching.

Having never had to really interact with table structure in mediawiki before, here's what I've worked out:

Wed, Oct 28, 6:30 AM · Editing-team (FY2020-21 Kanban Board), DiscussionTools

Oct 22 2020

DLynch added a comment to T244114: "Publish" button remains greyed out: "TypeError: this.translationView.categoryUI is null".

The specific error message from that stack trace is: Uncaught TypeError: Cannot read property 'lastOuterPost' of null

Oct 22 2020, 5:13 PM · JavaScript, Editing-team (FY2020-21 Kanban Board), Wikimedia-production-error, Language-Team (Language-2020-October-December), ContentTranslation

Oct 21 2020

DLynch added a comment to T265100: [SPIKE] What events are being tracked within the "section=new" flow.

Discussed in meeting: it's okay to summarize the table, since there's going to be a lot of VisualEditorFeatureUse events which are common to all integrations.

Oct 21 2020, 5:55 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)

Oct 19 2020

DLynch added a comment to T260467: Create a change tag for edits made using the New Discussion Tool.

There's a label, it's defined with:

"tag-discussiontools-newtopic": "Add topic",
"tag-discussiontools-newtopic-description": "User added a new topic to the page with DiscussionTools",
Oct 19 2020, 8:07 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Skipped QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)
DLynch added a comment to T265099: Differentiate between events emitted from the Reply Tool and the New Discussion Tool.

One option would be to use the existing init_type field, which is currently being sent as page but could be sent as section for this case. Advantage there is that it's just one event to change, and doesn't require any schema change. Disadvantage is that querying "event X in a session whose init was of type Y" is a more complicated query. It's consistent with how we currently log this sort of difference in VE/wikieditor though.

Oct 19 2020, 4:58 PM · Product-Analytics, DiscussionTools, Editing-team (FY2020-21 Kanban Board)
DLynch reassigned T264146: Instrument the special characters toolbar from MNeisler to Ryasmeen.
Oct 19 2020, 4:50 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T260467: Create a change tag for edits made using the New Discussion Tool.

It's different from the one in that patch, incidentally, because we immediately renamed it in this one.

Oct 19 2020, 3:41 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Skipped QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020 (New Discussion 1.0)

Oct 13 2020

DLynch added a comment to T265164: Evaluate usage of MediaWiki-Vagrant by technical contributors.

For reference, I believe that the only absolute blocker for me being able to use MediaWiki-Docker for development is T259685. There's some tracking on T261390 but the only other known issue was closed recently, so we're very near to it being viable...

Oct 13 2020, 5:24 AM · User-bd808, MediaWiki-Vagrant

Oct 8 2020

DLynch added a comment to T264146: Instrument the special characters toolbar.

Will close events for this feature be logged as dialog-abort?

Oct 8 2020, 5:21 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T264146: Instrument the special characters toolbar.

@ppelberg / @MNeisler - we've done the refactoring, so window-open-from-tool will be the event, consistent with all the others. We're waiting on your comments for a second patch that'll decide whether the actual insert should be logged as insert-Latin extended or insert-latinextended.

Oct 8 2020, 2:07 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools

Oct 7 2020

DLynch added a comment to T264146: Instrument the special characters toolbar.

The current state in code-review is that we're adjusting it so that it'll be the standard window-[open/close]-from-tool method, incidentally.

Oct 7 2020, 7:50 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch moved T264690: Double-logging of dialog close events from Blocked / Needs More Work to QA on the Editing-team (FY2020-21 Kanban Board) board.
Oct 7 2020, 5:25 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, VisualEditor
DLynch added a project to T264690: Double-logging of dialog close events: Editing QA.
Oct 7 2020, 5:25 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, VisualEditor
DLynch added a comment to T264690: Double-logging of dialog close events.

Sample wikitext:

[[File:Foo Fighters Live 21.jpg|thumb|Foo]]
[[foo]] {{Foo}} <ref>Foo.</ref><!-- Foo -->
Oct 7 2020, 5:25 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, VisualEditor

Oct 6 2020

DLynch reassigned T264690: Double-logging of dialog close events from DLynch to Esanders.
Oct 6 2020, 9:41 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, VisualEditor
DLynch added a comment to T264690: Double-logging of dialog close events.

We have a doubled inheritance via NodeDialog, it seems.

Oct 6 2020, 4:41 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, VisualEditor
DLynch added a project to T264690: Double-logging of dialog close events: Editing-team.
Oct 6 2020, 4:09 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, VisualEditor
DLynch added a comment to T259308: Measure usage of image search in Visual Editor.

I think we can live without location in the image grid for now, although this would be really nice to have. What's the impact of having a potentially infinite number of actions in the form search-result-chosen-34 for each offset?

Oct 6 2020, 3:01 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Product-Analytics (Kanban), Structured-Data-Backlog

Oct 5 2020

DLynch created T264690: Double-logging of dialog close events.
Oct 5 2020, 11:39 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Patch-For-Review, VisualEditor
DLynch added a comment to T259308: Measure usage of image search in Visual Editor.

To agree with @nettrom_WMF, there's currently no special instrumentation for media. Thus it just logs whatever is automatically logged due to generic hooks in the dialog/context-item systems. In practice, that means that we don't have any particular information about what someone did inside the dialog while it's open -- you could tell the difference between editing an existing image on the page and adding a new one, but I don't think you can see whether that new one is from search or upload.

Oct 5 2020, 11:36 PM · SDAW-MediaSearch (MediaSearch-ReleaseCandidate), Product-Analytics (Kanban), Structured-Data-Backlog

Oct 2 2020

DLynch claimed T264146: Instrument the special characters toolbar.
Oct 2 2020, 9:09 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch moved T264146: Instrument the special characters toolbar from Ready for Development to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Oct 2 2020, 9:09 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T264146: Instrument the special characters toolbar.

This patch will log:

Oct 2 2020, 8:14 PM · Editing-team (Tracking), Verified, Product-Analytics, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), OWC2020 (Reply Tool Opt Out), DiscussionTools

Sep 28 2020

DLynch added a comment to T249072: Replying v2.0: add support in toolbar for special characters.

@DLynch what – if any – instrumentation do we have in place in VE to measure how people are engaging with the special character toolbar [i]?

Sep 28 2020, 5:47 PM · OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools

Sep 22 2020

DLynch added a comment to T249944: WikiEditor records all edits as platform = desktop in EventLogging.

VisualEditor does ve.init.target.constructor.static.platformType || 'other' (approximately). In practice this means that anything using DesktopArticleTarget reports desktop and anything using MobileArticleTarget reports phone. Since the thing which picks which of those you're using is whether you're on MobileFrontend or not, in practice, yeah: platform: phone means "is on mobilefrontend".

Sep 22 2020, 1:42 AM · Editing-team (FY2020-21 Kanban Board), Analytics-Radar, Product-Analytics, Mobile, Analytics-Data-Quality, Analytics-EventLogging, WikiEditor

Sep 21 2020

DLynch moved T262877: Find and replace fails to highlight words when opened via F3 from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
Sep 21 2020, 6:06 PM · MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Editing-team (FY2020-21 Kanban Board), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Sep 18 2020

DLynch added a comment to T263261: Improve messaging when switching with multiple disallowed syntax types.

I guess it'd be easier if we made a new translation message for it, so we don't have an overlapping period where the old messages in non-english are looking particularly broken for expecting a parameter.

Sep 18 2020, 2:43 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools

Sep 17 2020

DLynch added a comment to T263215: Determine whether iOS 14 has introduced new regressions.

Translation could potentially break things, but is analogous to the existing translation feature in desktop Chrome which I don't think we're seeing bug reports over.

Sep 17 2020, 11:57 PM · Verified, VisualEditor, VisualEditor-MediaWiki-Mobile
DLynch moved T259673: Change what event and dialog is shown when people are prevented from switching from Ready for Development to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Sep 17 2020, 9:53 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, DiscussionTools

Sep 16 2020

DLynch added a comment to T262066: Make it possible to tell if Reply Tool is open from browser tab's name.

Should we bother? Tabs are short. I currently can't see the end of the title for any of the (only!) five tabs open in the window I'm writing this in. If you put something at the start, it'd mean I couldn't see the actual topic of the page...

Sep 16 2020, 5:58 PM · Editing-team (Tracking), DiscussionTools
DLynch added a comment to T262501: Reply Tool's comment summary not retained if closed .

@iamjessklein I was assuming it was the case where they'd manually deleted the content of the field.

Sep 16 2020, 4:28 PM · User-Ryasmeen, Verified, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Editing-team (FY2020-21 Kanban Board), DiscussionTools
DLynch updated subscribers of T251577: [Regression ?] "TypeError: Cannot read property '$element' of null" appears while adding a template.

@Jdlrobson that's a helpful pointer, thanks. Those are definitely the same error, though I guess we can't guarantee they're also from the template flow.

Sep 16 2020, 4:25 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor

Sep 15 2020

DLynch closed T261141: Toolbar doesn't stick to top of window on iPadOS as Resolved.

It works now, so either iOS betas fixed it or this was a new-Vector issue that also got fixed.

Sep 15 2020, 7:56 PM · User-Ryasmeen, VisualEditor
DLynch added a comment to T257593: iPadOS 14's Scribble text input issues.

GM build of iOS 14 was released today, with the final release scheduled for tomorrow (16th).

Sep 15 2020, 7:54 PM · Editing-team (Tracking), VisualEditor-ContentEditable, VisualEditor
DLynch added a comment to T261816: Add event for logging when people engage with the "Advanced" affordance.

Are you able to confirm this? I'd rather us spend the time now to be certain than try to untangle events when we're depending on the data meaning something specific.

Sep 15 2020, 12:32 AM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), OWC2020 (Reply Tool Opt Out), DiscussionTools

Sep 14 2020

DLynch added a comment to T261816: Add event for logging when people engage with the "Advanced" affordance.
  1. What – if any – editing interfaces, beyond the Reply Tool [and eventually, the New Discussion Tool] should Product Analytics and QA expect to see edit summary events emitted from?
Sep 14 2020, 11:46 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T261816: Add event for logging when people engage with the "Advanced" affordance.

It was merged before your comment, alas.

Sep 14 2020, 11:36 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T262501: Reply Tool's comment summary not retained if closed .

Oh, that matrix is very-specifically focused on the behavior when you actually submit the reply. There's additional what-happens to consider if reloading the page and restoring state is added to the mix.

Sep 14 2020, 10:54 PM · User-Ryasmeen, Verified, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Editing-team (FY2020-21 Kanban Board), DiscussionTools
DLynch added a comment to T262501: Reply Tool's comment summary not retained if closed .

This represents the current behavior of the tool:

Sep 14 2020, 10:49 PM · User-Ryasmeen, Verified, MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Editing-team (FY2020-21 Kanban Board), DiscussionTools
DLynch added a comment to T261816: Add event for logging when people engage with the "Advanced" affordance.

Eh, I've updated the patch to do it. It now does action advanced-show and advanced-hide.

Sep 14 2020, 7:05 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T261816: Add event for logging when people engage with the "Advanced" affordance.

The task description is ambiguous -- it just says to log when people engage with it. @ppelberg do we want to know that?

Sep 14 2020, 6:49 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), OWC2020 (Reply Tool Opt Out), DiscussionTools
DLynch added a comment to T261816: Add event for logging when people engage with the "Advanced" affordance.

I'm thinking feature: dtReply, action: toggle-advanced. It'll fire whenever you literally click on the toggle, but not when it's open when you initially view the page because the storage setting said it should be.

Sep 14 2020, 6:44 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), Verified, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), OWC2020 (Reply Tool Opt Out), DiscussionTools

Sep 9 2020

DLynch added a comment to T262223: VE won’t load on Chrome+iOS (also Firefox+iOS).

This may be fallout from f648197 removing the generic "iphone" and "ipad" browser-names? Which does mean that Ed caught this on the day it was committed, at least.

Sep 9 2020, 4:20 PM · User-Ryasmeen, Verified, Editing-team (FY2020-21 Kanban Board), MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Browser-Support-Apple-Safari, jQuery-Client, VisualEditor

Sep 8 2020

DLynch added a comment to T261390: Zeroconf Parsoid + VisualEditor doesn't work with MediaWiki-Docker.

@kostajh suggested I downgrade the docker image to 0.3.0 (from 0.5.0), which stopped this error from occurring.

Sep 8 2020, 4:46 PM · Editing-team (Tracking), VisualEditor, Parsoid, MediaWiki-Docker
DLynch added a comment to T261390: Zeroconf Parsoid + VisualEditor doesn't work with MediaWiki-Docker.

It's possible that this is being an issue independent of the docker/sqlite setup due to some less-used codepaths -- this is the non-restbase route, which is why the parse call is happening. None of our production sites have this setup, so...

Sep 8 2020, 3:16 PM · Editing-team (Tracking), VisualEditor, Parsoid, MediaWiki-Docker
DLynch added a comment to T261390: Zeroconf Parsoid + VisualEditor doesn't work with MediaWiki-Docker.

A possible indicator of whatever's going wrong: the visualeditor API parse call always returns Main_Page regardless of what was requested.

Sep 8 2020, 2:53 PM · Editing-team (Tracking), VisualEditor, Parsoid, MediaWiki-Docker

Sep 2 2020

DLynch moved T261662: undo/redo is slow on large documents from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
Sep 2 2020, 4:22 PM · Patch-For-Review, User-Ryasmeen, Skipped QA, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Editing-team (FY2020-21 Kanban Board), Performance Issue, VisualEditor-ContentEditable, VisualEditor
DLynch closed T250945: Double-click in text field can cause page reload and data loss as Resolved.

Looks like @Krinkle independently made the view-only change in d6f0cd0643d3a66e66c38d35e64c311c6ef1e6e0 without knowing about this ticket.

Sep 2 2020, 3:13 PM · Editing-team, MediaWiki-General

Sep 1 2020

DLynch added a comment to T258743: Change what symbol is prepended to pings on ar.wiki.

Is > going to cause any potential weird HTML issues? (Or complaints about weird diffs if it's escaped out to &lt;?)

Sep 1 2020, 3:03 PM · User-Ryasmeen, User-Dyolf77, OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools, VisualEditor

Aug 31 2020

DLynch added a comment to T231244: Make possible (or document how to) for a gadget to apply WikiEditor to a custom textarea.

ext.wikiEditor already requires everything this requests -- it just doesn't export it. It'd be trivial to do that so that you could just do mw.loader.require('ext.wikiEditor').toolbarConfig or similar.

Aug 31 2020, 5:01 PM · patch-welcome, Editing-team, WikiEditor
DLynch moved T261664: EditAttemptStep validation error '0' is not of type 'integer' from Code Review to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
Aug 31 2020, 4:45 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Skipped QA, Editing-team (FY2020-21 Kanban Board), Wikimedia-production-error, VisualEditor
DLynch added a comment to T258190: Production error: Cannot read property 'insertBefore' of null (VeCeDocumentNode.ve.ce.BranchNode.setupSlugs ).

So, this'd be happening here in ve.ce.BranchNode.js line 329:

// FIXME T126019: InternalListNode has an empty $element, so we assume that the slug goes
// at the end instead. This is a hack and the internal list needs to die in a fire.
if ( this.children[ i ] && this.children[ i ].$element[ 0 ] ) {
	child = this.children[ i ].$element[ 0 ];
	// child.parentNode might not be equal to this.$element[ 0 ]: e.g. annotated inline nodes
	child.parentNode.insertBefore( slugNode, child );
}

Which I'd say implies that we have some lightly-confused case where the child's $element has been removed from the DOM but the child hasn't been removed from the VE data model.

Aug 31 2020, 4:18 PM · Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

Looking at logstash, this seems to have slowed down greatly without us having made any deliberate changes -- I see 2,567 reports of it in the last 7 days. I also noticed that the abort_timing field is triggering it as well.

Aug 31 2020, 4:09 PM · VisualEditor, Growth-Team, Editing-team
DLynch created T261664: EditAttemptStep validation error '0' is not of type 'integer'.
Aug 31 2020, 4:03 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Skipped QA, Editing-team (FY2020-21 Kanban Board), Wikimedia-production-error, VisualEditor
DLynch added a comment to T260443: Mentioning an email address in DiscussionTools makes the system think I'm going to mention someone.

Making it configurable would be technically doable, as it's just a lightly modified reversion of the original removal.

Aug 31 2020, 3:30 PM · Editing-team, DiscussionTools

Aug 26 2020

DLynch assigned T257046: VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 mouse cursor to matmarex.

I just tested it again, and now it works for me. So, best guess would be some random beta hiccup on Monday? (There is sometimes a delay while the specialized template dialog opens, so maybe a spectacularly well timed network / caching issue bit me?)

Aug 26 2020, 2:40 PM · Skipped QA, User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), Accessibility, VisualEditor, VisualEditor-MediaWiki-References

Aug 25 2020

DLynch added a comment to T257046: VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 mouse cursor.

@matmarex in desktop mode?

Aug 25 2020, 11:35 PM · Skipped QA, User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), Accessibility, VisualEditor, VisualEditor-MediaWiki-References
DLynch renamed T257046: VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 mouse cursor from VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 cursor to VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 mouse cursor.
Aug 25 2020, 9:19 PM · Skipped QA, User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), Accessibility, VisualEditor, VisualEditor-MediaWiki-References
DLynch added a comment to T257046: VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 mouse cursor.

Hmm... @Esanders, I'm using a bluetooth trackpad, are you using a trackpad or mouse? (I have no idea whether this would make a difference, but...)

Aug 25 2020, 8:17 PM · Skipped QA, User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), Accessibility, VisualEditor, VisualEditor-MediaWiki-References
DLynch placed T257046: VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 mouse cursor up for grabs.
Aug 25 2020, 5:39 PM · Skipped QA, User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), Accessibility, VisualEditor, VisualEditor-MediaWiki-References

Aug 24 2020

DLynch added a comment to T258847: VisualEditor "jumps down" after editor loads in Safari.

I was looking at this -- it only happened to me while logged out. As soon as I logged in, the behavior went back to being consistent.

Aug 24 2020, 4:13 PM · Editing-team (FY2020-21 Kanban Board), Browser-Support-Apple-Safari, VisualEditor-MediaWiki, VisualEditor
DLynch created T261141: Toolbar doesn't stick to top of window on iPadOS.
Aug 24 2020, 3:58 PM · User-Ryasmeen, VisualEditor
DLynch added a comment to T257046: VisualEditor manual references box clicking doesn’t work with the new iPadOS 13.4 mouse cursor.

Tested it just now, albeit on iPadOS 14. The bug still occurs exactly as described -- using the mouse to select one of the items in the manual-cite dialog just closes the dialog while removing the selection from the document entirely.

Aug 24 2020, 3:52 PM · Skipped QA, User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), Accessibility, VisualEditor, VisualEditor-MediaWiki-References

Aug 17 2020

DLynch added a comment to T187102: Vagrant's /var/log/daemon.log filling up with kafka errors.

Makes sense to me. 👍🏻

Aug 17 2020, 3:45 PM · Event-Platform, Analytics, MediaWiki-Vagrant
DLynch added a comment to T236975: Vagrant eventbus role can't be installed because of node_version.

I mean, VisualEditor doesn't need Eventbus for anything -- it's pulled in because VE depends on Restbase, which depends on Eventbus.

Aug 17 2020, 3:10 AM · MediaWiki-Vagrant

Jul 30 2020

DLynch added a comment to T252597: Cookie “VEE” will be soon rejected because it has the “sameSite” attribute set to “none” or an invalid value, without the “secure” attribute..

Yeah, the patch is just a necessary-step towards removing the error. Depending on how T257936 is resolved, there may or may not be any more changes needed in VE code, I guess.

Jul 30 2020, 10:27 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Editing-team (FY2020-21 Kanban Board), VisualEditor
DLynch claimed T252597: Cookie “VEE” will be soon rejected because it has the “sameSite” attribute set to “none” or an invalid value, without the “secure” attribute..
Jul 30 2020, 4:52 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Editing-team (FY2020-21 Kanban Board), VisualEditor
DLynch added a comment to T257764: Catalogue the messages people encounter while using talk pages.

It's worth pointing to the translatewiki list here: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-discussiontools&language=es&filter=&optional=1&action=translate

Jul 30 2020, 4:27 PM · Editing Design, OWC2020, DiscussionTools
DLynch added a comment to T255622: Uncaught TypeError: Cannot read property 'getScrollTop' of null.

Also the error is coming from deep within Ace, so there may not be a lot we can do.

Jul 30 2020, 4:22 PM · User-Ryasmeen, CodeEditor, Editing-team (FY2020-21 Kanban Board), JavaScript, Wikimedia-production-error, VisualEditor

Jul 29 2020

DLynch claimed T257501: Add event for logging when people are prevented from switching from source to visual.
Jul 29 2020, 5:46 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), OWC2020 (Reply Tool Opt Out), Product-Analytics (Kanban), Editing-team (FY2020-21 Kanban Board), DiscussionTools

Jul 28 2020

DLynch added a comment to T258988: [Regression pre-wmf.2] Map dialog in VE hangs and VE does not open on page reload.

I can reproduce this. It only happens on pages that load the reply tool (so talk pages, or when using dtenable=1).

Jul 28 2020, 4:08 PM · Editing-team, VisualEditor

Jul 25 2020

DLynch added a comment to T252925: Apply VisualEditorFeatureUse schema changes to all editing interfaces.

Is it because I am using trackdebug=1 on Beta cluster? The reason I am using trackdebug=1 is because using editingStatsOversample=1 on Beta cluster does not fire any events.

Jul 25 2020, 5:10 AM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Product-Analytics, Editing-team (FY2020-21 Kanban Board), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), VisualEditor

Jul 24 2020

DLynch added a comment to T258811: VE's toolbar not wrapping correctly on desktop.

This is specifically rooted in OO.ui.Toolbar:

Jul 24 2020, 4:44 PM · Editing-team (Tracking), VisualEditor

Jul 23 2020

DLynch renamed T258743: Change what symbol is prepended to pings on ar.wiki from Change what synbol is prepended to pings on ar.wiki to Change what symbol is prepended to pings on ar.wiki.
Jul 23 2020, 7:17 PM · User-Ryasmeen, User-Dyolf77, OWC2020 (Reply Tool Opt Out), Editing-team (FY2020-21 Kanban Board), DiscussionTools, VisualEditor
DLynch added a comment to T252925: Apply VisualEditorFeatureUse schema changes to all editing interfaces.
  1. I am getting these events on Talk page namespace when I switch from Source mode to Desktop mode, Desktop to Source and while adding a link using visual mode. But I am not getting these on article namespace, meaning while using my sandbox on Dutch wiki and switching editors/adding links there, Is that expected?

That's not expected, and I cannot reproduce it. Could you give me more details of the page you're using?

Jul 23 2020, 4:54 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Product-Analytics, Editing-team (FY2020-21 Kanban Board), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), VisualEditor

Jul 22 2020

DLynch added a comment to T257501: Add event for logging when people are prevented from switching from source to visual.

Now T256150 has the relevant patch merged, we can do whatever logging we'd like.

Jul 22 2020, 5:38 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), OWC2020 (Reply Tool Opt Out), Product-Analytics (Kanban), Editing-team (FY2020-21 Kanban Board), DiscussionTools

Jul 21 2020

DLynch added a comment to T252925: Apply VisualEditorFeatureUse schema changes to all editing interfaces.

Oh, "VisualEditor" is also the new source mode on desktop from beta settings, in this case.

Jul 21 2020, 7:30 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Product-Analytics, Editing-team (FY2020-21 Kanban Board), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), VisualEditor

Jul 20 2020

DLynch moved T252925: Apply VisualEditorFeatureUse schema changes to all editing interfaces from Blocked / Needs More Work to QA on the Editing-team (FY2020-21 Kanban Board) board.
Jul 20 2020, 10:36 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Product-Analytics, Editing-team (FY2020-21 Kanban Board), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), VisualEditor
DLynch added a comment to T252925: Apply VisualEditorFeatureUse schema changes to all editing interfaces.

There's a consistency issue with the trackdebug logging for VisualEditorFeatureUse in DiscussionTools -- it's not also including the event-defaults... which is where four of the fields are located. The one that's in the regular payload is editor_interface, which you're indeed seeing there. (You won't see anything for bucket ever, because nothing is being bucketed.)

Jul 20 2020, 10:36 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Product-Analytics, Editing-team (FY2020-21 Kanban Board), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), VisualEditor

Jul 15 2020

DLynch moved T254518: TemplateStyles not applied when loading VE/NWE from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
Jul 15 2020, 5:53 PM · User-Ryasmeen, Skipped QA, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, TemplateStyles
DLynch reopened T187102: Vagrant's /var/log/daemon.log filling up with kafka errors as "Open".

This is still happening, and is causing issues with our team's prototype-testing server.

Jul 15 2020, 5:01 PM · Event-Platform, Analytics, MediaWiki-Vagrant

Jul 14 2020

DLynch added a comment to T257593: iPadOS 14's Scribble text input issues.

We will look at this once a production build is released for iOS 14.

Jul 14 2020, 3:50 PM · Editing-team (Tracking), VisualEditor-ContentEditable, VisualEditor