Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Lucas_Werkmeister_WMDE claimed T303317: Show word-level diff on textual fields in Wikibase diffs.
Thu, Jun 30, 3:23 PMPatch-For-Review, Special:NewLexeme revival (Special:NewLexeme revival - sprint 11), Wikidata-Campsite (Team A Hearth 馃彴馃敟), User-ItamarWMDE, Wikidata
Lucas_Werkmeister_WMDE moved T311224: Look into best way forward for word-level diff in Wikibase from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Thu, Jun 30, 3:23 PMPatch-For-Review, Special:NewLexeme revival (Special:NewLexeme revival - sprint 11), Wikidata
Lucas_Werkmeister_WMDE updated subscribers of T311224: Look into best way forward for word-level diff in Wikibase.

@Michael and I looked at WordLevelDiff and TableDiffFormatter and concluded that TableDiffFormatter isn鈥檛 very useful to us, but marking WordLevelDiff as @newable should be acceptable, under the same conditions as its parent class Diff (namely, that T257472 wants to eventually introduce a factory for it, at which point Diff should no longer be newable).

Thu, Jun 30, 2:47 PMPatch-For-Review, Special:NewLexeme revival (Special:NewLexeme revival - sprint 11), Wikidata
Lucas_Werkmeister_WMDE claimed T311224: Look into best way forward for word-level diff in Wikibase.
Thu, Jun 30, 2:22 PMPatch-For-Review, Special:NewLexeme revival (Special:NewLexeme revival - sprint 11), Wikidata
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

Although I still don鈥檛 see an exception corresponding to Jos茅 Barreto (from T309445#8023533), even when just looking through all the errors for that time regardless of item ID or other search terms.

Thu, Jun 30, 1:48 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T305064: Make linktarget table visible on cloud wiki replicas.

That is definitely in the medium-term work (=in a couple of months) to avoid bloating the table but it has complexities (race condition between being used and being deleted) that make it require a bit a time.

Thu, Jun 30, 1:40 PMDBA, Data-Engineering, Data-Services, User-Ladsgroup
Lucas_Werkmeister_WMDE moved T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown from Parents / Waiting to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Thu, Jun 30, 11:55 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

鈥nd while working on adding the logging, I suddenly find this:

ItemTermStoreWriterAdapter::saveTermsOfEntity()
		if ( $entity instanceof Item ) {
			try {
				$this->store->storeTerms( $entity->getId(), $entity->getFingerprint() );
				return true;
			} catch ( TermStoreException $ex ) {
				return false;
			}
		}

Small wonder there鈥檚 no trace of errors in Logstash鈥

Thu, Jun 30, 11:52 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE closed T311307: Add debug logging for item terms storage after merging as Resolved.

The logging is working fine, see the mediawiki dashboard with the channel set to WikibaseTerms.

Thu, Jun 30, 11:41 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE closed T311307: Add debug logging for item terms storage after merging, a subtask of T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown, as Resolved.
Thu, Jun 30, 11:41 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T308071: 1.39.0-wmf.18 deployment blockers.

Regarding my risky patch (T308071#8032891), the logging seems to be working and the volume on the WikibaseTerms channel seems to be ca. 40k messages per hour. Compared to a total MediaWiki volume in the vicinity of 1.2 million messages per hour, that seems acceptable 鈥 in the last 12 hours, it鈥檚 the 8th-most busy channel on the mediawiki board, the orangeish slice here (second from the top in most stacks):

image.png (300脳680 px, 38 KB)

TL;DR: seems fine :)

Thu, Jun 30, 11:40 AMPatch-For-Review, Release-Engineering-Team (Priority Backlog 馃摜), Release, Train Deployments

Wed, Jun 29

Lucas_Werkmeister_WMDE closed T308659: Validate lemma length in Special:NewLexeme(Alpha) and label/description/aliases length in Special:NewProperty (CVE-2022-34750) as Resolved.

I think we鈥檙e done here (but please reopen if the task should still be open for security release process purposes).

Wed, Jun 29, 4:31 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Vuln-DoS, Wikidata Lexicographical data, Wikidata, Security, Security-Team
Lucas_Werkmeister_WMDE added a comment to T308659: Validate lemma length in Special:NewLexeme(Alpha) and label/description/aliases length in Special:NewProperty (CVE-2022-34750).

Backported the patches to REL1_35 and REL1_37 (1.36 is out of support). Leaving the task open for review of the cleanup patch (which doesn鈥檛 need backporting).

Wed, Jun 29, 3:32 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Vuln-DoS, Wikidata Lexicographical data, Wikidata, Security, Security-Team
Lucas_Werkmeister_WMDE added a comment to T311640: Wikibase\MediaInfo\Tests\Integration\MultiLingualCaptionsTest::testEditCaptions test failure on REL1_35.

Mainly just creating this 鈥渇or the record鈥; assuming that not many more REL1_35 backports will be needed before that version falls out of support in September 2023, IMHO it鈥檚 acceptable to do nothing about this and close it when REL1_35 is gone.

Wed, Jun 29, 3:10 PMwdwb-tech, Structured-Data-Backlog, MW-1.35-release, ci-test-error, WikibaseMediaInfo, Wikidata
Lucas_Werkmeister_WMDE moved T311640: Wikibase\MediaInfo\Tests\Integration\MultiLingualCaptionsTest::testEditCaptions test failure on REL1_35 from Blocker to Not a blocker on the MW-1.35-release board.
Wed, Jun 29, 3:08 PMwdwb-tech, Structured-Data-Backlog, MW-1.35-release, ci-test-error, WikibaseMediaInfo, Wikidata
Lucas_Werkmeister_WMDE created T311640: Wikibase\MediaInfo\Tests\Integration\MultiLingualCaptionsTest::testEditCaptions test failure on REL1_35.
Wed, Jun 29, 3:08 PMwdwb-tech, Structured-Data-Backlog, MW-1.35-release, ci-test-error, WikibaseMediaInfo, Wikidata
Lucas_Werkmeister_WMDE created T311626: Language name of mul language (鈥渕ultiple languages鈥) inconsistently used in termboxes.
Wed, Jun 29, 1:22 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T306918: Prohibit duplication of mul labels in other languages.

Thing to consider: Should/could this be done with an abuse filter?

Wed, Jun 29, 1:10 PMWikidata, Wikidata-Campsite
Lucas_Werkmeister_WMDE added a comment to T306918: Prohibit duplication of mul labels in other languages.

I think we can implement this in much the same way as the blocking of identical labels and descriptions (T212869).

Wed, Jun 29, 1:09 PMWikidata, Wikidata-Campsite
Lucas_Werkmeister_WMDE created T311617: Wikibase classic termbox (entity terms view) sometimes reorders user babel languages.
Wed, Jun 29, 12:16 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE closed T307808: Wikibase classic termbox (entity terms view) drops last user babel language if interface language is not in babel as Resolved.
Wed, Jun 29, 12:04 PMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Wikidata-Campsite (Team A Hearth 馃彴馃敟), MediaWiki-extensions-WikibaseView, Wikidata
Lucas_Werkmeister_WMDE closed T307808: Wikibase classic termbox (entity terms view) drops last user babel language if interface language is not in babel, a subtask of T297393: Implement basic version of mul language code and deploy to Test Wikidata, as Resolved.
Wed, Jun 29, 12:04 PMMW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata, Language codes

Tue, Jun 28

Lucas_Werkmeister_WMDE moved T308659: Validate lemma length in Special:NewLexeme(Alpha) and label/description/aliases length in Special:NewProperty (CVE-2022-34750) from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Tue, Jun 28, 3:49 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Vuln-DoS, Wikidata Lexicographical data, Wikidata, Security, Security-Team
Lucas_Werkmeister_WMDE added a comment to T307957: Fix SVG export for maps in WDQI UI .

FWIW, I think the most realistic 鈥渇ix鈥 for this is that we disable the SVG download for maps. I don鈥檛 know if it鈥檚 even possible to save a Leaflet map as an SVG image without horrible hacks (e.g. leaflet-image says it鈥檚 incompatible with Leaflet.markercluster, which is what we use for markers IIRC), and it would likely be a major effort at least.

Tue, Jun 28, 3:44 PMWikidata-Campsite, User-ItamarWMDE, wmde-team-a-tech, Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE moved T308659: Validate lemma length in Special:NewLexeme(Alpha) and label/description/aliases length in Special:NewProperty (CVE-2022-34750) from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Tue, Jun 28, 2:47 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Vuln-DoS, Wikidata Lexicographical data, Wikidata, Security, Security-Team
Lucas_Werkmeister_WMDE moved T307869: Request for new search profile for Wikidata that boosts Items for languages from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Tue, Jun 28, 2:44 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE added a comment to T308071: 1.39.0-wmf.18 deployment blockers.
  1. Risky Patch! 馃殏馃敟
Tue, Jun 28, 12:54 PMPatch-For-Review, Release-Engineering-Team (Priority Backlog 馃摜), Release, Train Deployments

Mon, Jun 27

Lucas_Werkmeister_WMDE added a comment to T311409: Wikibase needs special handling for translatable pages.

The output of Special:UnconnectedPages is determined by the unexpectedUnconnectedPage page prop, which ClientParserOutputDataUpdater::setUnexpectedUnconnectedPage() sets for any content that is neither

  • connected to an item, nor
  • a redirect, nor
  • has the expectedUnconnectedPage page prop set.

I guess we could insert a hook here, so that Translate can tell Wikibase to not consider the page 鈥渦nexpected(ly) unconnected鈥. Or is there a relevant standard method directly on the Content or ParserOutput?

Mon, Jun 27, 3:44 PMWikidata
Lucas_Werkmeister_WMDE moved T311307: Add debug logging for item terms storage after merging from Peer Review to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.

Can be tech-verified (look for the new channel in logstash) once wmf.18 reaches Wikidata.

Mon, Jun 27, 3:36 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE moved T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown from Doing to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Mon, Jun 27, 3:36 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE moved T307869: Request for new search profile for Wikidata that boosts Items for languages from Peer Review to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.

It looks like the new profile isn鈥檛 fully working yet, at least when used via the maintenance script 鈥 I get the same results for 鈥淓ngl鈥 with or without the maintenance script:

Mon, Jun 27, 2:10 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE added a comment to T311410: Append `.index` to tracking namespace in wikibase.queryService.ui.App.
  • move all metrics data in Graphite related to App.js to the .index directory
    • there should be no longer any data under the old metric names in Graphite that could confuse people looking at it later
Mon, Jun 27, 12:57 PMPatch-For-Review, Special:NewLexeme revival (Special:NewLexeme revival - sprint 11), Wikidata-Campsite, User-ItamarWMDE, wdwb-tech, wmde-team-a-tech, Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE awarded T294424: Jenkins search results missing /ci/ URL component a Like token.
Mon, Jun 27, 11:06 AMUpstream, Continuous-Integration-Infrastructure, Jenkins
Lucas_Werkmeister_WMDE added a comment to T302274: INVESTIGATION [Timebox: 4hrs.]: Grafana board for Wikidata Query Service UI not receiving data.

I would slightly lean towards A, but both sound okay to me.

Mon, Jun 27, 10:23 AMUser-Michael, Special:NewLexeme revival (Special:NewLexeme revival - sprint 10), Wikidata Query UI, Wikidata, Wikidata-Campsite (Team A Hearth 馃彴馃敟)
Lucas_Werkmeister_WMDE moved T311307: Add debug logging for item terms storage after merging from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Mon, Jun 27, 9:45 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

鈥nd while working on adding the logging, I suddenly find this:

Mon, Jun 27, 9:21 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE claimed T311307: Add debug logging for item terms storage after merging.
Mon, Jun 27, 9:19 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T308659: Validate lemma length in Special:NewLexeme(Alpha) and label/description/aliases length in Special:NewProperty (CVE-2022-34750).

Feel free to upload and merge them now, the intention was to polish them afterwards (and it should be fine if the polishing patches don鈥檛 make it into the security release 鈥 they鈥檇 only make the code more maintainable, without changing anything at runtime, so they鈥檙e mostly important for the master branch).

Mon, Jun 27, 7:59 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Vuln-DoS, Wikidata Lexicographical data, Wikidata, Security, Security-Team

Fri, Jun 24

Lucas_Werkmeister_WMDE added a comment to T311297: activity.toolforge.org loads third-party content for d3.

Even better: https://tools-static.wmflabs.org/cdnjs/ajax/libs/d3/3.5.17/d3.min.js (I don鈥檛 think cloudflare.com is any better than d3js.org)

Fri, Jun 24, 3:30 PMToolforge-standards-committee, Privacy, Tools
Lucas_Werkmeister_WMDE created T311307: Add debug logging for item terms storage after merging.
Fri, Jun 24, 2:38 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

The simplest explanation for this whole business would be that the secondary data updates somehow just don鈥檛 happen. I don鈥檛 know why this would be 鈥 of course it鈥檚 possible that they crash for some reason, but I鈥檇 expect to see something in logstash in that case, and I鈥檓 not seeing anything 鈥 but at this point, I think this is a theory worth either confirming or ruling out, by adding some logging. I suggest that we add a temporary log channel that captures messages at any level (like, for example, the DuplicateParse channel), and make ItemHandler::getSecondaryDataUpdates() and ItemTermStoreWriterAdapter::saveTermsOfEntity() log debug messages indicating that the secondary data updates were created and executed, with some basic information about the terms being stored (number of labels, descriptions, and aliases across all languages; we don鈥檛 have access to the revision ID at this point, unfortunately).

Fri, Jun 24, 2:13 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

I tested it: a regular index.php?action=purge or action.php?action=purge doesn鈥檛 trigger secondary data updates, not even when you visit the page afterwards; api.php?action=purge&forcelinkupdate=1 does trigger secondary data updates. The merge gadget doesn鈥檛 set forcelinkupdate, so the secondary data updates shouldn鈥檛 get triggered by it (other than through the edit).

Fri, Jun 24, 2:03 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T301104: Wikimedia Commons structured data dump does not contain all fields, e..g, title.

And the dumps size has indeed increased somewhat:

Fri, Jun 24, 1:33 PMWikimedia-Hackathon-2022, Structured-Data-Backlog, Structured Data Engineering, Commons
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

Does any of the lists of potential merge candidates at https://www.wikidata.org/wiki/Help:Merge#Finding_items_to_merge help?

Fri, Jun 24, 11:52 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE claimed T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.
Fri, Jun 24, 9:48 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata

Thu, Jun 23

Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

Okay, but after 50 repeats of the code from earlier (i.e. 100 items, 50 merges), I still haven鈥檛 been able to reproduce the issue locally once. So now I鈥檓 back to thinking that the issue doesn鈥檛 happen with wbmergeitems alone, but is related to the combination of API requests the merge gadget makes.

Thu, Jun 23, 4:27 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

Recent merges:

Thu, Jun 23, 4:05 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

Found and merged another pair, again unable to reproduce the issue:

Thu, Jun 23, 3:50 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

Managed to find a pair of duplicates via the recent changes tagged as sitelink change from connected wiki (the dewiki and ptwiki articles were clearly translations of one another, with a left parenthesis missing in the same place in both) and merged them using the merge gadget. I was not able to reproduce the issue.

Thu, Jun 23, 3:38 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE changed the status of T307869: Request for new search profile for Wikidata that boosts Items for languages from Stalled to Open.
Thu, Jun 23, 3:22 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE changed the status of T307869: Request for new search profile for Wikidata that boosts Items for languages, a subtask of T298140: Lexeme Language Lookup - Prioritize Items for languages in the Item lookup, from Stalled to Open.
Thu, Jun 23, 3:21 PMWikidata, Wikidata Lexicographical data, Special:NewLexeme revival
Lucas_Werkmeister_WMDE added a comment to T307869: Request for new search profile for Wikidata that boosts Items for languages.

The above patch should fix the issue, I forgot that profile repositories must have have unique names, sorry about that!

Thu, Jun 23, 3:21 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE added a comment to T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown.

Tried reproducing this locally with the following snippet in the dev tools console 鈥 But didn鈥檛 succeed in reproducing the error, both labels are present in the terms store afterwards. It鈥檚 possible that this bug is related to some of the extra stuff that the merge gadget does.

Thu, Jun 23, 3:13 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MediaWiki-extensions-WikibaseRepository, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata
Lucas_Werkmeister_WMDE closed T306010: Add additional git, npm and composer workflow documentation to WikibaseLexeme.git readme, a subtask of T302324: [EPIC] Refresh WikibaseLexeme readme file, as Resolved.
Thu, Jun 23, 2:28 PMMW-1.39-notes (1.39.0-wmf.10; 2022-05-02), User-ItamarWMDE, Documentation, Wikidata Lexicographical data, Wikidata, Special:NewLexeme revival
Lucas_Werkmeister_WMDE closed T306010: Add additional git, npm and composer workflow documentation to WikibaseLexeme.git readme as Resolved.
Thu, Jun 23, 2:28 PMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Special:NewLexeme revival (Special:NewLexeme revival - sprint 10), User-Noarave, User-ItamarWMDE, Documentation, Wikidata Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE added a comment to T311195: Wikimedia Commons pages appear very, very small on mobile devices in desktop mode.

Same as T311119: All Wikimedia projects other than Wikipedia, Test Wikipedia, and Wikinews extremely zoomed out while using Vector Skin on iPad.?

Thu, Jun 23, 11:11 AMMediaWiki-Core-Skin-Architecture
Lucas_Werkmeister_WMDE added a comment to T311171: Query using wikibase:label returns the item id.

I don鈥檛 see what the issue here is鈥 if the item has no label in any of the listed languages, the label service falls back to the item ID. This is good and desirable. Whether an item has a label in a certain language or not is essentially arbitrary, so filtering out items that happen to have no label is not usually a good thing to do, in my opinion. (Unless you鈥檙e working with a maintenance query or are otherwise interested specifically in the existence of the label.)

Thu, Jun 23, 10:49 AMWikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE added a comment to T303317: Show word-level diff on textual fields in Wikibase diffs.

Make sure to consider whether the core class WordLevelDiff is marked as "newable", meaning that we are able to instantiate it outside of core

Thu, Jun 23, 10:39 AMPatch-For-Review, Special:NewLexeme revival (Special:NewLexeme revival - sprint 11), Wikidata-Campsite (Team A Hearth 馃彴馃敟), User-ItamarWMDE, Wikidata

Wed, Jun 22

Lucas_Werkmeister_WMDE closed T305707: INVESTIGATION: Add class prefix linting to new-lexeme repository as Declined.

Declining this; I think we agreed in an informal chat yesterday that this isn鈥檛 worth pursuing. (It would very likely have to be implemented as a new eslint plugin, which would need more time than the 4h we assigned to this investigation.)

Wed, Jun 22, 4:50 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 10), Wikidata Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE moved T311139: Map popups in Wikidata query service UI have tiny font size from Backlog to Done on the Wikidata Query UI board.
Wed, Jun 22, 4:42 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE closed T311139: Map popups in Wikidata query service UI have tiny font size as Resolved.

{F35265015}

Wed, Jun 22, 4:42 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE added a project to T311139: Map popups in Wikidata query service UI have tiny font size: Wikidata-Campsite (Team A Hearth 馃彴馃敟).

The fix should be live within 30 minutes.

Wed, Jun 22, 4:39 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE moved T311139: Map popups in Wikidata query service UI have tiny font size from Incoming to Product Verification on the Wikidata-Campsite (Team A Hearth 馃彴馃敟) board.
Wed, Jun 22, 4:38 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE committed rWDQGdb18c9ad6d8a: Set html font-size to 1rem (authored by Lucas_Werkmeister_WMDE).
Set html font-size to 1rem
Wed, Jun 22, 4:31 PM
Lucas_Werkmeister_WMDE claimed T311139: Map popups in Wikidata query service UI have tiny font size.
Wed, Jun 22, 3:55 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE moved T307869: Request for new search profile for Wikidata that boosts Items for languages from Peer Review to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.

(The revert was deployed, I just forgot to attach it to this task.)

Wed, Jun 22, 2:51 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE attached a referenced file: F35264338: image.png.
Wed, Jun 22, 2:43 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE attached a referenced file: F35264493: image.png.
Wed, Jun 22, 2:42 PMWikidata, Special:NewLexeme revival
Lucas_Werkmeister_WMDE attached a referenced file: F35264492: image.png.
Wed, Jun 22, 2:42 PMWikidata, Special:NewLexeme revival
Lucas_Werkmeister_WMDE created T311147: Distinguish 鈥渓oading鈥 and 鈥渘o results鈥 messages.
Wed, Jun 22, 2:42 PMWikidata, Special:NewLexeme revival
Lucas_Werkmeister_WMDE created T311139: Map popups in Wikidata query service UI have tiny font size.
Wed, Jun 22, 2:23 PMWikidata-Campsite (Team A Hearth 馃彴馃敟), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE closed T302172: Translation issue in German as Resolved.

This is fixed now:
{F35264327}

Wed, Jun 22, 2:18 PMwdwb-tech, I18n, Wikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE closed T307669: deploy new version of Query Builder to incorporate new translations, a subtask of T302172: Translation issue in German, as Resolved.
Wed, Jun 22, 2:18 PMwdwb-tech, I18n, Wikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE closed T301461: Investigate cache issues after WDQS UI deployments as Resolved.

Looks like it鈥檚 working, I didn鈥檛 notice any errors with today鈥檚 WDQS UI deployment and haven鈥檛 heard of any user problems either.

Wed, Jun 22, 2:18 PMwdwb-tech, wmde-team-a-tech, Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE closed T307669: deploy new version of Query Builder to incorporate new translations as Resolved.

Deployed.

Wed, Jun 22, 2:18 PMWikidata, Wikidata-Campsite (Team A Hearth 馃彴馃敟)
Lucas_Werkmeister_WMDE moved T289243: Edge Caches can lead to broken Query Builder for some time after deploy from Incoming to Done on the Wikidata Query Builder board.
Wed, Jun 22, 2:17 PMWikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE closed T289243: Edge Caches can lead to broken Query Builder for some time after deploy as Resolved.

Seems to be fixed now, I didn鈥檛 notice any query builder errors after today鈥檚 deployment.

Wed, Jun 22, 2:17 PMWikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE added a comment to T307869: Request for new search profile for Wikidata that boosts Items for languages.

Change 801793 merged by jenkins-bot:

[operations/mediawiki-config@master] [cirrus] Add a custom profile for the wikibase language selector

https://gerrit.wikimedia.org/r/801793

Wed, Jun 22, 1:38 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE added a comment to T301461: Investigate cache issues after WDQS UI deployments.

Thanks! Header looks good to me now:

Wed, Jun 22, 8:29 AMwdwb-tech, wmde-team-a-tech, Wikidata Query UI, Wikidata

Tue, Jun 21

Lucas_Werkmeister_WMDE added a comment to T294159: Enable Lexeme access on first set of projects.

This should now be enabled everywhere.
{F35260331}

Tue, Jun 21, 3:48 PMWikidata Lexicographical data, Wikidata, wdwb-tech, Patch-For-Review, Wikimedia-Site-requests
Lucas_Werkmeister_WMDE moved T309593: enable Lexeme Lua access on remaining Wikimedia projects from Incoming to Product Verification on the Wikidata-Campsite (Team A Hearth 馃彴馃敟) board.

This should now be enabled everywhere.
{F35260331}

Tue, Jun 21, 3:46 PMPatch-For-Review, wdwb-tech, Wikidata Lexicographical data, Wikidata, Wikidata-Campsite (Team A Hearth 馃彴馃敟), Wikimedia-Site-requests

Mon, Jun 20

Lucas_Werkmeister_WMDE added a comment to T307869: Request for new search profile for Wikidata that boosts Items for languages.

To roll out this new feature, we鈥檒l temporarily make the wbsearchentities API only expose the new API parameter if it鈥檚 been configured in the production config (i.e. when there鈥檚 another possible value besides default). This way, we can let the wbsearchentities change roll out with the train, and then control using only config changes when the new parameter is available on which wikis. So the current plan for deploying this feature is:

Mon, Jun 20, 3:37 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE committed rEPS1fa81341e71e: Remove no-longer-used Phan suppression (authored by Lucas_Werkmeister_WMDE).
Remove no-longer-used Phan suppression
Mon, Jun 20, 2:17 PM
Lucas_Werkmeister_WMDE committed rEWLCd2adfb77d31b: Add $profileContext to getRankedSearchResults() (authored by Lucas_Werkmeister_WMDE).
Add $profileContext to getRankedSearchResults()
Mon, Jun 20, 2:16 PM
Lucas_Werkmeister_WMDE added a comment to T301461: Investigate cache issues after WDQS UI deployments.

@RKemper thanks, that would be great!

Mon, Jun 20, 2:09 PMwdwb-tech, wmde-team-a-tech, Wikidata Query UI, Wikidata

Fri, Jun 17

Lucas_Werkmeister_WMDE committed rEPS891694dbfbe5: Pass $profileContext into EntitySearchHelper (authored by Lucas_Werkmeister_WMDE).
Pass $profileContext into EntitySearchHelper
Fri, Jun 17, 1:37 PM
Lucas_Werkmeister_WMDE added a comment to T306589: Add sharding to site_stats table.

Maybe it is easier to change the view to do the SUM instead to require to add the SUM. That would hide the technical detail, but that sounds not for something really needed there.

Fri, Jun 17, 10:30 AMUser-notice, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, Performance-Team (Radar), DBA
Lucas_Werkmeister_WMDE moved T307869: Request for new search profile for Wikidata that boosts Items for languages from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Fri, Jun 17, 9:49 AMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE attached a referenced file: F35248819: image.png.
Fri, Jun 17, 9:47 AMMW-1.39-notes (1.39.0-wmf.16; 2022-06-13), JsonConfig, Content-Transform-Team, MediaWiki-Parser, Wikimedia-production-error
Lucas_Werkmeister_WMDE closed T308749: MWException: Invalid language code "[[:int:lang]]'"`UNIQ--item-261--QINU`"'" as Resolved.

Seems to be fixed.

image.png (303脳678 px, 17 KB)

Fri, Jun 17, 9:46 AMMW-1.39-notes (1.39.0-wmf.16; 2022-06-13), JsonConfig, Content-Transform-Team, MediaWiki-Parser, Wikimedia-production-error

Thu, Jun 16

Lucas_Werkmeister_WMDE moved T310134: Update error message on blur of Lookup where no item has been selected from Peer Review to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Thu, Jun 16, 1:29 PMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Special:NewLexeme revival (Special:NewLexeme revival - sprint 10), Patch-For-Review, Wikidata Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE added a comment to T307869: Request for new search profile for Wikidata that boosts Items for languages.

For the API parameter, we鈥檒l have a config setting defining the possible API values and mapping them to the underling profile context value. This means it鈥檚 the administrator鈥檚 responsibility to make the API parameter useful (just like it鈥檚 already their responsibility to configure WikibaseCirrusSearch more generally), and to configure a value that the installed search extensions will understand. By default, the mapping would be:

Thu, Jun 16, 12:00 PMSpecial:NewLexeme revival (Special:NewLexeme revival - sprint 11), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), User-ItamarWMDE, Patch-For-Review, Discovery-Search (Current work), Elasticsearch, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE added a comment to T310134: Update error message on blur of Lookup where no item has been selected.

I think this still needs an update in WikibaseLexeme.git?

Thu, Jun 16, 11:00 AMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Special:NewLexeme revival (Special:NewLexeme revival - sprint 10), Patch-For-Review, Wikidata Lexicographical data, Wikidata

Wed, Jun 15

Lucas_Werkmeister_WMDE changed the subtype of T310134: Update error message on blur of Lookup where no item has been selected from "Bug Report" to "Task".
Wed, Jun 15, 10:54 AMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Special:NewLexeme revival (Special:NewLexeme revival - sprint 10), Patch-For-Review, Wikidata Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE moved T306010: Add additional git, npm and composer workflow documentation to WikibaseLexeme.git readme from Peer Review to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Wed, Jun 15, 10:50 AMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Special:NewLexeme revival (Special:NewLexeme revival - sprint 10), User-Noarave, User-ItamarWMDE, Documentation, Wikidata Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE closed T294637: Improvements to the WikibaseLexeme Lua interface (before full rollout) as Resolved.
Wed, Jun 15, 10:47 AMwdwb-tech, All-and-every-Wiktionary, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE closed T294637: Improvements to the WikibaseLexeme Lua interface (before full rollout), a subtask of T235901: Implement Lua access to Lexemes, Senses and Forms, as Resolved.
Wed, Jun 15, 10:47 AMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Platform Engineering Code Jam, wdwb-tech, Platform Engineering Roadmap Decision Making, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, All-and-every-Wiktionary, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE added a comment to T294637: Improvements to the WikibaseLexeme Lua interface (before full rollout).

Then let鈥檚 close this task, and I鈥檒l upload a Gerrit change to declare the Lua interface stable in its current form. Once the 鈥淟ua haswbstatements鈥 feature has been implemented, we鈥檒l announce it as a significant (but hopefully not breaking) change to the interface, but there鈥檚 no need to block the initial Lexeme Lua rollout on it.

Wed, Jun 15, 10:47 AMwdwb-tech, All-and-every-Wiktionary, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE awarded T310532: Investigate McRouter GET request spike from wmf.15 a Barnstar token.
Wed, Jun 15, 10:43 AMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Performance-Team, Release-Engineering-Team (Radar), Release, Train Deployments
Lucas_Werkmeister_WMDE added a comment to T235901: Implement Lua access to Lexemes, Senses and Forms.

The senses and forms of a returned lexeme entity aren鈥檛 entities themselves, they鈥檙e ordinary tables. Only the custom getForms() and getSenses() methods take care of properly creating entities.

I think we can leave this open for feedback after the initial Beta rollout. Should getForms() and getSenses() exist at all? Or should .forms and .senses contain entity objects already? And in either case, should they be indexed numerically (1, 2, 鈥) or by ID (L1-F1, L1-F2, 鈥 鈥 or just F1, F2, 鈥?)? Maybe the initial testers have some feedback on this.

Wed, Jun 15, 10:14 AMMW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Platform Engineering Code Jam, wdwb-tech, Platform Engineering Roadmap Decision Making, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, All-and-every-Wiktionary, Wikidata, Wikidata Lexicographical data