In T401575#11075781, @JWheeler-WMF wrote:

@TheresNoTime this looks good. Ideally in the target article/page we are also able to track any of the links on the row. That way, we can identify not only the CTR, but the CTR on certain elements of the page.

Is this doable? I think the spec as defined only tracks the diff or article links.

(will just grab this for now while I work on it :D)

Some quick poking at this found another "non-Vue" hacky way of dealing with this :3

T388567: "[Vue warn]: Attempting to mutate prop "inputValue". Props are readonly." when using NamespacesControl seems related

In T397861#10964875, @Andrew wrote:

In T397861#10962913, @TheresNoTime wrote:

• the concerns raised here suggest that it does increase NFS load, though perhaps not to a disruptive level, given how 'infrequently' new torrents would need to be generated?

Bursts are the main concern here, and it sounds like you're describing something bursty! Is this something with a throttle you can configure?

In T392827#10963790, @TheresNoTime wrote:

nb. from Slack: also query how many users have 5+ favourite templates

nb. from Slack: also query how many users have 5+ favourite templates

Thanks for the comments @Andrew

Will happen this Thursday once 1.45.0-wmf.8 is stable on all projects

In T396556#10907511, @Samwilson wrote:

I think it might be when a template is redirected but also is categorised, e.g. Template:CN:

#REDIRECT [[Template:Citation needed]]
[[Category:Template shortcuts]]

I think the fix might be in DataStore.getItemData(), where we look for the returned data with if ( responses[ 0 ].pages[ pageId ] !== undefined ) …

It should actually be looking instead for the *first* (well, and only) returned page (and also then returning the ID of that page, which will be different in the case of redirects).

Quick question (which very much could be from my own misunderstanding) — I tested the patch and found that language variants were being included:

Same here (in Chrome fwiw)

Is there a better way of setting an explicit title on tabs?

In T396556#10907511, @Samwilson wrote:

I think it might be when a template is redirected but also is categorised

hm, info doesn't have templatedata for some of these templates, but most (all?) of the required info is available in categories — I can't replicate this locally on the same commit/latest commit...

In T395730#10900377, @SomeRandomDeveloper wrote:

@Samwilson @TheresNoTime, please sanitize the system message in FeaturedTemplatesList.js:119 before merging the latest TemplateDiscovery patch. mw.msg() returns system messages unsanitized, and jQuery's .append() function takes raw HTML strings, causing stored XSS vulnerabilities through system messages.

I played around with this for a bit — couple of initial thoughts/questions:

• I strongly support the introduction of more personalisation for pronouns :-)
• Are you imagining a predefined list of pronouns, or would there be free text for neopronouns and the such?
• and if so
  • how do you imagine moderation to work on these custom inputs? Malicious users will abuse them.
  • would introducing a pronoun preference with a predefined list be a reasonable "first step", after which custom pronouns can be considered?

Number of users that open the dialog

Event tracking

Just noting that an initial run shows that 65 editors have favourited 1 or more templates as of today

I've raised T394287: Allow PageTitlesControl to be filtered by namespace 'upstream', but am working on writing a validator which can at least prevent saving of non-template namespace(s)/dupes

Just so you're aware, that level of analytics will need event tracking set up (instead of a simple database query) — not an issue, just will take a bit longer to set up and get going

Replaced

From discussion: If this runs every week/month, we can still graph something. We should start after deploying to the pilot wikis