Page MenuHomePhabricator
Feed Advanced Search

Today

Daimona added a comment to T221347: Fatal exception of type "ConfigException".

Given that they're close on the keyboard, I originally thought of a typo. But that would mean someone edited the file and introduced the typo on mw1274. Could be something more subtle of course.

Thu, Apr 18, 6:46 PM · PHP 7.2 support, Operations, Wikimedia-production-error
Daimona added a comment to T221357: Read timeout reached while viewing AbuseLog.

@mmodell Well, I guess we should always try to keep our code cross-DBMS-compat, and Postgres compatibility is mandatory for including AF in the tarball. That being said, there's no hurry to make it work now, given that it's been broken for 10 years or so... Basing on Logstash and tendril, it doesn't seem like AF is causing too many timeouts, aside from a couple of not-so-common queries on abuse_filter_log. Normalization is always great, although as for every schema change this one would take some time to be merged and deployed.

Thu, Apr 18, 6:04 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona added a comment to T221357: Read timeout reached while viewing AbuseLog.

Thanks @mmodell! Now we have plenty of time to understand how to get this working. However, I fear that our only possibility to keep the cast is to FORCE the index (and I still don't know if it would work). Other than that, I guess we're left with the option to keep the Postgres incompatibility for now and jump straight to T220791. That one would also normalize the schema a bit (so that Postgres won't be the only DBMS to benefit from it), but it won't be quick to do.

Thu, Apr 18, 5:26 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona added a comment to T221357: Read timeout reached while viewing AbuseLog.

@matej_suchanek Ah, so the index isn't used because of the cast? That's interesting, I'll do some experiments. However, what mostly confused me is that the DB engine performs the cast implicitly all the same, and I wouldn't expect a different performance. Probably there's some difference in how such cast is performed. I'll follow up with an update after having analyzed the EXPLAIN more thoroughly.

P.S. I didn't talk about times in the task description, but they vary from a nearly instantaneous query without the cast, to 60-80 seconds with the cast.

Thu, Apr 18, 4:47 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona added a comment to T221357: Read timeout reached while viewing AbuseLog.

@matej_suchanek Ah, so the index isn't used because of the cast? That's interesting, I'll do some experiments. However, what mostly confused me is that the DB engine performs the cast implicitly all the same, and I wouldn't expect a different performance. Probably there's some difference in how such cast is performed. I'll follow up with an update after having analyzed the EXPLAIN more thoroughly.

Thu, Apr 18, 4:35 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona triaged T221347: Fatal exception of type "ConfigException" as High priority.

Indeed, I echo Urbanecm. Giving high priority because a refresh fixes it and the code already looks correct. If you think it should be UBN, feel free to escalate it.

Thu, Apr 18, 12:28 PM · PHP 7.2 support, Operations, Wikimedia-production-error
Daimona merged T221358: Fatal exception of type ConfigException on enwiki into T221347: Fatal exception of type "ConfigException".
Thu, Apr 18, 12:01 PM · PHP 7.2 support, Operations, Wikimedia-production-error
Daimona merged task T221358: Fatal exception of type ConfigException on enwiki into T221347: Fatal exception of type "ConfigException".
Thu, Apr 18, 12:01 PM · User-revi, Wikimedia-production-error
Daimona claimed T221357: Read timeout reached while viewing AbuseLog.
Thu, Apr 18, 11:52 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona triaged T221357: Read timeout reached while viewing AbuseLog as Unbreak Now! priority.

Train blockers are UBN, and this is a TB because it's impossible to open Special:AbuseLog or even use the API (plus hotfix coming).

Thu, Apr 18, 11:50 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona added a parent task for T221357: Read timeout reached while viewing AbuseLog: T220726: 1.34.0-wmf.1 deployment blockers.
Thu, Apr 18, 11:49 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona added a subtask for T220726: 1.34.0-wmf.1 deployment blockers: T221357: Read timeout reached while viewing AbuseLog.
Thu, Apr 18, 11:49 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
Daimona created T221357: Read timeout reached while viewing AbuseLog.
Thu, Apr 18, 11:49 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona added a comment to T221347: Fatal exception of type "ConfigException".

Well, looking at the message and at this line of code, it seems like it used to read"Kogo" instead of "Logo", although there's no sign of this typo in wmf.25, nor in master.

Thu, Apr 18, 11:23 AM · PHP 7.2 support, Operations, Wikimedia-production-error
Daimona moved T221347: Fatal exception of type "ConfigException" from Untriaged to Found during 1.34-wmf.1 on the Wikimedia-production-error board.

Although I found it on itwiki where we're always at 1.33-wmf.25...

Thu, Apr 18, 11:18 AM · PHP 7.2 support, Operations, Wikimedia-production-error
Daimona added a comment to T221347: Fatal exception of type "ConfigException".
message
ConfigException from line 53 of /srv/mediawiki/php-1.33.0-wmf.25/includes/config/GlobalVarConfig.php: GlobalVarConfig::get: undefined option: 'Kogo'
Thu, Apr 18, 11:16 AM · PHP 7.2 support, Operations, Wikimedia-production-error
Daimona added a comment to T201193: Code coverage is low in AbuseFilter.

@DannyS712 Thanks for the help! There are some good explanations on the web, just searching "code coverage" on google yields something interesting. Basically, code coverage is the amount of code which gets executed during tests.

Thu, Apr 18, 9:26 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, User-Huji, AbuseFilter, Test-Coverage

Yesterday

Daimona added a comment to T34478: AbuseFilter not setting utf-8 flag.

@mobrovac Yes, it is, nothing has changed on this side since 2011. Since the plan is to fix the DB storage format and add new back-compat code, we can also start adding the utf-8 flag as part of T213006. The point is: is adding the flag enough?

Wed, Apr 17, 7:47 PM · Core Platform Team Kanban (Doing), User-Daimona, AbuseFilter, MediaWiki-Database
Daimona added a comment to T209877: Several edits appear twice in AbuseLog.

FTR this is still happening, see abuselog. I don't have possible explanations, though.

Wed, Apr 17, 5:55 PM · User-Daimona, Wikimedia-production-error, AbuseFilter
Daimona closed T221230: ContentTranslation\Test\AbuseFilterCheck\AbuseFilterCheckTest test failures as Resolved.

Yes, the CX patch was merged to soon, since as stated in commit message it was waiting for the parent. Thanks Krinkle for acting fast, I'm sorry but I'm a bit absent these days.

Wed, Apr 17, 2:01 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), AbuseFilter, Wikimedia-production-error (Shared Build Failure), ContentTranslation

Mon, Apr 15

Daimona added a comment to T220920: apc.enable_cli should be enabled in PHP jobs.

@hashar That's fair, but how can we test that caching works for that bit of code, if the code is using APC to run tests? At this point, shouldn't the service be changed to return a HashBagOStuff instead of APCUBagOStuff during unit tests?

Mon, Apr 15, 1:55 PM · Continuous-Integration-Config
Daimona closed T220915: Add botadmin group on itwiki as Resolved.
Mon, Apr 15, 12:37 PM · Wikimedia-Site-requests
Daimona added a comment to T209565: Dry run for normalizeThrottleParameters.php.

mrwiki done! @tstarling You acn dry-run one last time whenever you want, and thanks a lot for your help with this. One last question: is it fine to add the script to update.php so that it's automatically run upon updating, or do we want to run it manually?

Mon, Apr 15, 7:52 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter

Sun, Apr 14

Daimona added a comment to T220920: apc.enable_cli should be enabled in PHP jobs.

Maybe it has to do with the comment on top of the APCUBagOStuff file, mentioning bugs when serialization is set to default?

Sun, Apr 14, 8:01 PM · Continuous-Integration-Config
Daimona created T220920: apc.enable_cli should be enabled in PHP jobs.
Sun, Apr 14, 5:34 PM · Continuous-Integration-Config
Daimona created T220915: Add botadmin group on itwiki.
Sun, Apr 14, 2:43 PM · Wikimedia-Site-requests

Sat, Apr 13

Daimona added a comment to T209565: Dry run for normalizeThrottleParameters.php.

Well, so we're waiting for mr.wiki filter 9 to be fixed. I've been told to contact the only active local admin, although I don't know when they'll be able to fix the filter... Furthermore, the wiki has opted out from global sysop, and thus stewards cannot easily change the filter. I'm unsure if that would be OK to do for someone in the staff group.

Sat, Apr 13, 11:38 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-notice, Patch-For-Review, MW-1.32-release, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-maintenance-script-run, AbuseFilter
Daimona claimed T193068: Add support for SQLite and postgre when searching patterns.

Patch above + its dependencies and that's it.

Sat, Apr 13, 9:36 AM · Patch-For-Review, AbuseFilter, PostgreSQL, SQLite
Daimona added a comment to T220874: Special:AbuseLog throws when viewing details or examining (BadMethodCallException).

Alas, yes, it's the same.

Sat, Apr 13, 9:02 AM · AbuseFilter
Daimona merged T220874: Special:AbuseLog throws when viewing details or examining (BadMethodCallException) into T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).
Sat, Apr 13, 9:02 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), User-zeljkofilipin, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter
Daimona merged task T220874: Special:AbuseLog throws when viewing details or examining (BadMethodCallException) into T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).
Sat, Apr 13, 9:02 AM · AbuseFilter

Fri, Apr 12

Daimona edited P8017 Important and short patches in AbuseFilter currently under review.
Fri, Apr 12, 5:10 PM · AbuseFilter
Daimona closed T220812: Add missing action- messages to AbuseFilter as Resolved.
Fri, Apr 12, 1:05 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), AbuseFilter
Daimona closed T220812: Add missing action- messages to AbuseFilter, a subtask of T220779: Add test to check existence of action- messages, as Resolved.
Fri, Apr 12, 1:05 PM · I18n, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-Core-Testing
Daimona claimed T220812: Add missing action- messages to AbuseFilter.
Fri, Apr 12, 12:21 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), AbuseFilter
Daimona removed a project from T215787: PHP Warning: "count(): Parameter must be an array or an object that implements Countable" on AbuseFilter history with PHP7: Patch-For-Review.

(Waiting for the script to be executed)

Fri, Apr 12, 11:27 AM · PHP 7.2 support, User-Daimona, AbuseFilter
Daimona created T220791: afl_filter should be split in afl_filter_id and afl_global.
Fri, Apr 12, 7:45 AM · Patch-For-Review, AbuseFilter
Daimona closed T42757: Joins on INTEGER and TEXT fail with PostgreSQL as Resolved.

Calling this resolved because the compatibility problem with postgres is indeed resolved. I'm gonna open another task for the long-term goal of splitting afl_filter in afl_filter_id and afl_global.

Fri, Apr 12, 7:35 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), PostgreSQL, AbuseFilter
Daimona closed T42757: Joins on INTEGER and TEXT fail with PostgreSQL, a subtask of T2384: [REPLACED BY TAG] PostgreSQL/pgsql support (tracking), as Resolved.
Fri, Apr 12, 7:35 AM · PostgreSQL, Tracking-Neverending, MediaWiki-Database
Daimona closed T42757: Joins on INTEGER and TEXT fail with PostgreSQL, a subtask of T199544: Make AbuseFilter work on PostgreSQL and SQLite (tracking), as Resolved.
Fri, Apr 12, 7:34 AM · PostgreSQL, SQLite, AbuseFilter

Thu, Apr 11

Daimona claimed T220764: Expose more detailed diff information to the AbuseFilter.

This would indeed be useful, and I sent https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/431731/ for that a few months ago.
However, IIRC those variables would be pretty tricky: I think each added character would be alone in the resulting array. Now I cannot check if that's true, though (and I cannot add the task number on gerrit) because I'm from mobile. And that patch needs tests anyway.

Thu, Apr 11, 9:01 PM · Patch-For-Review, AbuseFilter
Daimona added a comment to T220758: Flaky wdio test "Special:Version has WikibaseMediaInfo listed".

Yes, seen in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/468706/.

Thu, Apr 11, 8:07 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Multimedia, SDC Engineering, WikibaseMediaInfo, Wikimedia-production-error (Shared Build Failure)
Daimona added a comment to T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).

Instead of displaying an error, I just made it so that _links variables aren't computed for faulty entries.
Nevertheless, I hope to get the root cause solved soon. Not only for this task, but also for related ones (listed in commit message).

Thu, Apr 11, 7:43 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), User-zeljkofilipin, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter

Wed, Apr 10

Daimona added a comment to T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).

@mmodell I guess we do, although I don't think it's worth doing anything beyond displaying an error instead of throwing. Also, this logspam is happening since at least one year, so it's a bit late to recognize it as train blocker.

Wed, Apr 10, 5:30 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), User-zeljkofilipin, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter
Daimona changed the status of T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null) from Open to Stalled.

@zeljkofilipin Thanks for the heads-up, per my comment above this is not a TB IMHO. Actually, this is blocked on T34478 and T213478.

Wed, Apr 10, 3:22 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), User-zeljkofilipin, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter
Daimona removed a parent task for T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null): T206679: 1.33.0-wmf.25 deployment blockers.
Wed, Apr 10, 3:21 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), User-zeljkofilipin, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter
Daimona removed a subtask for T206679: 1.33.0-wmf.25 deployment blockers: T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).
Wed, Apr 10, 3:21 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
Daimona added a comment to T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).

I don't think this should be a train blocker: it was discovered in 2018 and only affects some old entries. Nevertheless, it's really high priority. Last weeks, the spike on logstash was likely caused by a bot or something like that mass-requesting corrupted abuselog entries. I cannot check right now if that's still true, though.

Wed, Apr 10, 5:50 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), User-zeljkofilipin, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter

Tue, Apr 9

Daimona added a comment to T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).

It depends on the reason of the failure :-) Right now it fails because it has ast 0.1.2 installed, which is a very old version anyway, so it'd be better to just upgrade it. But yes, we'll have to use php7.[123] later on due to different phan requirements.

Tue, Apr 9, 9:25 PM · Patch-For-Review, phan-taint-check-plugin
Daimona added a comment to T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).

@sbassett Why skipping CI? Wouldn't it help to have regression tests in place to ensure that nothing was missed in the upgrade? We can still vote V+2 for spurious failures.

Tue, Apr 9, 8:02 PM · Patch-For-Review, phan-taint-check-plugin
Daimona added a comment to T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).

Great! Thanks @sbassett and @Bawolff! I guess we're currently blocked on T218719 which makes https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/SecurityCheckPlugin/+/497583/ fail, plus any further fix which I may have missed and will show up from CI.

Tue, Apr 9, 6:02 PM · Patch-For-Review, phan-taint-check-plugin

Mon, Apr 8

Daimona added a project to T220353: Unable to create redirect on dewiki - fatal DBQueryError: Wikimedia-production-error.
Mon, Apr 8, 9:30 AM · Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)), User-Marostegui, MediaWiki-Revision-backend, Wikimedia-production-error, MediaWiki-Redirects
Daimona added a comment to T220353: Unable to create redirect on dewiki - fatal DBQueryError.
message
A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: INSERT INTO `redirect` (rd_from,rd_namespace,rd_title,rd_fragment,rd_interwiki) VALUES ([REDACTED],'0',[REDACTED],[REDACTED],[REDACTED]) ON DUPLICATE KEY UPDATE rd_namespace = '0',rd_title = [REDACTED],rd_fragment = '',rd_interwiki = ''
Function: WikiPage::insertRedirectEntry
Error: 1205 Lock wait timeout exceeded; try restarting transaction
Mon, Apr 8, 9:29 AM · Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)), User-Marostegui, MediaWiki-Revision-backend, Wikimedia-production-error, MediaWiki-Redirects

Sat, Apr 6

Daimona added a comment to T219114: phan 1.2.6 is OOMing on MediaWiki core.

FYI, phan 1.2.8 was released just today and it includes Lego's fix for --progress-bar.

Sat, Apr 6, 6:45 PM · Patch-For-Review, Release-Engineering-Team, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan
Daimona edited P8017 Important and short patches in AbuseFilter currently under review.
Sat, Apr 6, 5:38 PM · AbuseFilter
Daimona closed T203353: Correctly validate action parameters server-side when saving a filter as Resolved.
Sat, Apr 6, 12:36 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), AbuseFilter
Daimona closed T219951: AbuseFilter shouldn't publish `udp` LogEntries with $newId=0 as Resolved.
Sat, Apr 6, 12:24 PM · Wikimedia-production-error, AbuseFilter

Wed, Apr 3

Daimona added a comment to T202320: Remove StopForumSpam/updateBlacklist.php in favour of core's maintenance/updateBlacklist.php.

@MarcoAurelio Yes, it's T189560. You have to vote V+2.

I see it mentions 1.31. It's REL1.32 also affected?

Wed, Apr 3, 10:18 AM · Technical-Debt, Patch-For-Review, MediaWiki-extensions-StopForumSpam
Daimona added a comment to T202320: Remove StopForumSpam/updateBlacklist.php in favour of core's maintenance/updateBlacklist.php.

@MarcoAurelio Yes, it's T189560. You have to vote V+2.

Wed, Apr 3, 10:10 AM · Technical-Debt, Patch-For-Review, MediaWiki-extensions-StopForumSpam

Tue, Apr 2

Daimona closed T207117: Translate/scripts/magic-export.php triggers warnings on PHP 7.3 as Resolved.
Tue, Apr 2, 6:17 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), PHP 7.3 support, MediaWiki-extensions-Translate

Mon, Apr 1

Daimona closed T218527: Enable wgAbuseFilterNotificationsPrivate on commons.wikimedia.org as Resolved.
Mon, Apr 1, 11:35 AM · AbuseFilter, Wikimedia-Site-requests
Daimona closed T191039: Re-enable filter profiling on every wiki as Resolved.
Mon, Apr 1, 11:34 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Performance-Team (Radar), User-Daimona, AbuseFilter
Daimona closed T191039: Re-enable filter profiling on every wiki, a subtask of T191430: Re-enable profiling for stashed edits, as Resolved.
Mon, Apr 1, 11:34 AM · AbuseFilter

Sun, Mar 31

Daimona closed T219593: Language constructs other than variables aren't highlighted anymore as Resolved.
Sun, Mar 31, 4:02 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), AbuseFilter
Daimona updated the task description for T219727: UnexpectedValueException: The title "Discussioni utente:Barstein" does not refer to an existing page.
Sun, Mar 31, 9:12 AM · TCB-Team, Wikimedia-production-error, Two-Column-Edit-Conflict-Merge
Daimona moved T219727: UnexpectedValueException: The title "Discussioni utente:Barstein" does not refer to an existing page from Untriaged to Found longer ago on the Wikimedia-production-error board.
Sun, Mar 31, 9:12 AM · TCB-Team, Wikimedia-production-error, Two-Column-Edit-Conflict-Merge
Daimona created T219727: UnexpectedValueException: The title "Discussioni utente:Barstein" does not refer to an existing page.
Sun, Mar 31, 9:11 AM · TCB-Team, Wikimedia-production-error, Two-Column-Edit-Conflict-Merge

Sat, Mar 30

Daimona claimed T207117: Translate/scripts/magic-export.php triggers warnings on PHP 7.3.
Sat, Mar 30, 12:29 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), PHP 7.3 support, MediaWiki-extensions-Translate
Daimona moved T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content from Waiting to Done on the User-Daimona board.
Sat, Mar 30, 12:06 PM · TestMe, User-Daimona, Wikimedia-production-error, AbuseFilter
Daimona closed T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content as Resolved.

Calling resolved, given that the EditFilterMergedContent hook is guaranteed to provide a valid Content object (that is then passed to contentToString).

Sat, Mar 30, 12:06 PM · TestMe, User-Daimona, Wikimedia-production-error, AbuseFilter
Daimona triaged T213478: purgeRedundantText: Potential data loss as High priority.

Blocking other high priority tasks.

Sat, Mar 30, 11:48 AM · User-Daimona, AbuseFilter, MediaWiki-Maintenance-scripts, Technical-Debt
Daimona raised the priority of T34478: AbuseFilter not setting utf-8 flag from Normal to High.

Blocking other high priority tasks.

Sat, Mar 30, 11:48 AM · Core Platform Team Kanban (Doing), User-Daimona, AbuseFilter, MediaWiki-Database
Daimona added a comment to T218527: Enable wgAbuseFilterNotificationsPrivate on commons.wikimedia.org.

@MusikAnimal Actually it wasn't. My patches were last, and took up more time than they should because the other 2 (for T191039) had to be rolled back. I rescheduled everything European Mid-day SWAT (on Monday). Will let you know!

Sat, Mar 30, 8:15 AM · AbuseFilter, Wikimedia-Site-requests

Fri, Mar 29

Daimona closed T157235: Don't escape some messages in AbuseFilterViewEdit so admins can add links to external tools as Resolved.
Fri, Mar 29, 6:01 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), AbuseFilter
Daimona claimed T219593: Language constructs other than variables aren't highlighted anymore.
Fri, Mar 29, 9:45 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), AbuseFilter
Daimona created T219593: Language constructs other than variables aren't highlighted anymore.
Fri, Mar 29, 8:57 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), AbuseFilter
Daimona added a comment to T157235: Don't escape some messages in AbuseFilterViewEdit so admins can add links to external tools.

@MusikAnimal Thanks for reporting. The culprit is this patch for T191039. The escaping itself wasn't altered, but I replaced the message "abusefilter-edit-status-profile" with "abusefilter-edit-status", and moved the content of the former for english. This was basically a revert of rEABF337cad30d9c66bbc09e3b5577e4d54fddbacc2c5. Messages in other languages have been moved to the new key per T191039#5051938, but on-wiki custom messages weren't (of course).
I'm unsure if there are other consequences, but for the moment I'm just changing the escaping to parse().

Fri, Mar 29, 8:53 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), AbuseFilter

Thu, Mar 28

Daimona added a comment to T219514: Variables old_wikitext and new_wikitext are blank in Page namespace.

For what concerns T219371: my patch fixed it, but the cause wasn't the AbuseFilter commit above. Instead, I think some other part of the code (related to action=raw) has been changed to use getText instead of getNativeData and broke the same way.

Thu, Mar 28, 8:52 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), ProofreadPage, Wikisource, AbuseFilter
Daimona added a comment to T219514: Variables old_wikitext and new_wikitext are blank in Page namespace.

@Jdforrester-WMF Yep. https://gerrit.wikimedia.org/r/499801

Thu, Mar 28, 6:21 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), ProofreadPage, Wikisource, AbuseFilter
Daimona added a comment to T219514: Variables old_wikitext and new_wikitext are blank in Page namespace.

No, this is just a regression coming from the AF patch linked above.

Thu, Mar 28, 4:42 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), ProofreadPage, Wikisource, AbuseFilter
Daimona added a parent task for T219514: Variables old_wikitext and new_wikitext are blank in Page namespace: T206677: 1.33.0-wmf.23 deployment blockers.
Thu, Mar 28, 3:52 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), ProofreadPage, Wikisource, AbuseFilter
Daimona added a subtask for T206677: 1.33.0-wmf.23 deployment blockers: T219514: Variables old_wikitext and new_wikitext are blank in Page namespace.
Thu, Mar 28, 3:52 PM · Release-Engineering-Team (Kanban), Release, Train Deployments
Daimona claimed T219514: Variables old_wikitext and new_wikitext are blank in Page namespace.

Dang, I wasn't correct! The problem here is rEABF324d0e6aa3ed9c3f6924960692111839f2e3c8d5. ProofreadPage still used getNativeData but didn't define getText, so AbuseFilter stopped receiving its text. Given that filters have unpredictable behaviour on the PP namespace, given that this behaviour could result in unfair actions on the user (e.g. a block), and given that the fix is very simple, I'm marking this as a train blocker + UBN.

Thu, Mar 28, 3:52 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), ProofreadPage, Wikisource, AbuseFilter
Daimona added a comment to T219514: Variables old_wikitext and new_wikitext are blank in Page namespace.

Alright, so ProofreadPage is currently incompatible with AbuseFilter, because it uses its own content model, and doesn't tell AbuseFilter how to turn it into plain text. Will fix it shortly, hopefully.

Thu, Mar 28, 3:41 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), ProofreadPage, Wikisource, AbuseFilter
Daimona added a project to T219514: Variables old_wikitext and new_wikitext are blank in Page namespace: ProofreadPage.
Thu, Mar 28, 3:23 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), ProofreadPage, Wikisource, AbuseFilter
Daimona triaged T219514: Variables old_wikitext and new_wikitext are blank in Page namespace as High priority.

If old_wikitext and new_wikitext are blank, any other text-related variable will be wrong. I'd like to investigate it, but I have to say that I don't know what the Page namespace is for, or where it comes from.

Thu, Mar 28, 3:20 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), ProofreadPage, Wikisource, AbuseFilter
Daimona claimed T214592: afl_log_id is never written to.
Thu, Mar 28, 1:56 PM · Patch-For-Review, User-Daimona, AbuseFilter
Daimona added a comment to T214592: afl_log_id is never written to.

Alright, so I think this afl_log_id field should be removed altogether. Not only because we don't use it, but it makes queries slower. For instance, I see the following logged as slow on tendril for commonswiki:

Thu, Mar 28, 1:41 PM · Patch-For-Review, User-Daimona, AbuseFilter
Daimona added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

OK so I was wrong, we don't have an ID, as we don't insert() the entry. I guess this happens because, as I said above, that part of the code is just used to mirror AbuseLog in RC, so we don't really want a duplicate in Special:Log. We're not interested in adding tags to the "mirror entry", either. Thus, I'm going to replicate what publish() does, removing the tags parts.

Thu, Mar 28, 1:06 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
Daimona added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

@pmiazga Thanks! Well, actually the if above will prevent false to be passed as second parameter, but the ID being 0 is of course a thing. Later today I'll effectively check whether we have an RCID, use it if we do, and call notifyFeeds if we don't. I also think this task isn't completely a wrong place to talk about it, given that AbuseFilter seems to be the only cause of this problem per logstash.

Thu, Mar 28, 8:13 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error

Wed, Mar 27

Daimona added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

@Krinkle Thanks! I missed the RCID part, and IIRC we do have an RCID there. Tomorrow I'll investigate further.
And yes, we want a RC entry for an event not in Special:Log.

Wed, Mar 27, 8:46 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error
Daimona added a comment to T218940: Exception "At least one of: RCID, revision ID, and log ID MUST be specified" from ManualLogEntry::publish.

Is there an alternative method to publish an entry without revId nor logId? With .23 on group1 I now see some logspam (link) from AbuseFilter, which does a ->publish(0, dest). However, AbuseLog is not on Special:Log and thus doesn't have a logId, while using publish() is useful as it allows to mirror filter hits to RC.

Wed, Mar 27, 7:27 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MediaWiki-Logging, Wikimedia-production-error

Tue, Mar 26

Daimona added a comment to T219056: VisualEditor should use its own message for the "Edit" tab.

For Wikimedia wikis, I think it was an intentional decision not to do it – to promote visual editor as the "normal" editor.

Tue, Mar 26, 9:00 PM · Uncyclomedia, MediaWiki-extensions-CollaborationKit, I18n, VisualEditor
Daimona added a comment to T219247: esytimeline image disappears in mobile view.

@alexhollender It definitely is, and thanks Aklapper for merging.

Tue, Mar 26, 8:51 PM · Readers-Web-Backlog, MobileFrontend, EasyTimeline
Daimona added a comment to T214035: DBError "Error: 1213 Deadlock found when trying to get lock" on WikiPage::doUpdateRestrictions.

@daniel Sure! FWIW, here is the one I mentioned in the task description. However, I can see that it's not the only script causing this problem, and I suspect that all the entries you see on logstash for the last 7 days are instead from this one.

Tue, Mar 26, 2:05 PM · Core Platform Team Backlog (Later), Core Platform Team (Security, stability, performance and scalability (TEC1)), MediaWiki-Revision-backend, Wikimedia-production-error

Mon, Mar 25

Daimona claimed T212082: Do not block page moves with AbuseFilter on LocalRenameJob page moves.
Mon, Mar 25, 7:28 PM · User-Daimona, Patch-For-Review, Stewards-and-global-tools, AbuseFilter, MediaWiki-extensions-CentralAuth, GlobalRename
Daimona claimed T200032: Some wikis have block enabled but don't assign the abusefilter-modify-restricted right to anyone.
Mon, Mar 25, 7:28 PM · Patch-For-Review, User-Daimona, Wikimedia-Site-requests, AbuseFilter
Daimona claimed T219092: Runtime profiling shouldn't include time taken to parse wikitext.
Mon, Mar 25, 7:21 PM · Patch-For-Review, User-Daimona, AbuseFilter
Daimona edited P8017 Important and short patches in AbuseFilter currently under review.
Mon, Mar 25, 6:58 PM · AbuseFilter
Daimona added a project to T219155: Fatal Error when trying to read notifications: Call to a member function getComment() on null: Wikimedia-production-error.
message
Call to a member function getComment() on null
Mon, Mar 25, 1:17 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Wikimedia-production-error, Notifications, Growth-Team