Created a followup task for the popup bug. T340547, Moving this task to done.

Clicking on the popup makes it disappear. I am not sure if that is enough or we still need to go ahead with implementing the closing button.

In T329968#8928844, @GMikesell-WMF wrote:

@S_Mukuti I just wanted to validate a couple of things with you if this is the results you wanted and I also came up with a side issue as seen below. Please let me know if you want me to create separate tasks for any or just however you want me to proceed, thanks!
Test links:
https://test.wikipedia.org/wiki/Cheesesteak
https://test.wikipedia.org/wiki/Philly_taco
https://test.wikidata.org/wiki/Q231553
I created a test wikidata and a test site called "Cheesesteak". I linked the article "Cheesesteak" with the Wikidata item. Is this what you want with the "Site link created", which I thought was fine but it followed with a "This article is already linked to an item". Shouldn't the 2nd part be removed since you are linking it for the first time and should only appear when you click Autosuggest again on that article?

Once "Cheesesteak" was linked, I create another article called "Philly taco" and tried to link it with the "cheesesteak" wikidata. Is that the warning you wanted? Also shouldn't the warning appear after the wikidata description besides in the middle of the wikidata item since it looks like it's part of the wikidata item? Also to distinguish it better, should we have the letters bold or anything to make it stick out more? Once you select the item and Submit, I was able to link it to "Philly taco" which now "Cheesesteak" is now unlinked to the wikidata.

Side error that I came across. When I was creating a new article of "Philly taco" which the "cheesesteak" wikidata did not have an alias of "Philly taco" yet. The Autosuggest link popped up as designed but if I do an edit since you can't close the popup unless you refresh the screen, each edit creates a new Autosuggest popup which doesn't go away so you end up with multiples on the side.

@GMikesell-WMF I think this patch https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/32/diffs?commit_id=4e99598e214e9a4ed743f5cb742be4973ecbcfd9 solved the issue by having a tag for each popup so that it is displayed independently whenever the AutoSuggestSitelink button is clicked.

I think this is all done.

@GMikesell-WMF The multiple popups issue has been resolved in the latest patch.

Fixed by T332076

https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/27

Fixed by T317036

Yes "Sarah Mukuti" is the correct username.

@KSiebert