PR is at https://github.com/wmde/FundraisingFrontend/pull/2035
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Fri, Jan 22
Thu, Jan 21
Mon, Jan 18
Fri, Jan 15
Thu, Jan 14
Wed, Jan 13
Tue, Jan 12
We have investigated this and found a design issue: When the user clicks the submit button, the browser blurs the bank data field (triggering an onBlur event) before triggering the onClick event. In the sub-second time scale between the blur and the click event, the browser renders the BIC field, moving the buttons further down. This leads to the situation that the browser somehow 'loses' the click event because it's in an area that's redrawn. If we use visibility instead of display for the BIC field (reserving whitespace, but hiding the element) the error does not occur. However, this looks kind of ugly:
Mon, Jan 11
Dec 22 2020
Another option to solve this would be to put the IBAN validation into its own 'micro-application'. That way, the extension would not "pollute" our whole application environment (with us needing custom PHP/extension builds) and would not be held back in case the extension is not ready for PHP 8.x yet
Authentication data for setting up the system is now obsolete beause we're using managed hosting.
Authentication data for deployment is stored in our shared and encrypted password store.
Dec 18 2020
Dec 17 2020
PR bounded context: https://github.com/wmde/fundraising-memberships/pull/58
Dec 16 2020
Dec 15 2020
Dec 14 2020
Dec 4 2020
The display errors have been fixed in the latest version. The syntax error in IE 11 persists. I have investigated and have found out that this is a problem with the way JavaScript bundlers choose the distribution bundle from packages - they prefer to use the ES6 module file (if available) over the ES5 file. So for now we can either wait if the author of Splide works on my ticket at https://github.com/Splidejs/splide/issues/201 and see if that ticket resolves anything (local testing surfaced new errors in IE 11), or switch libraries.
Dec 3 2020
Nov 27 2020
Nov 26 2020
To avoid mail flooding, we should finish T268845: Remove PiwikTracker before implementing a solution
@kai.nissen I was wondering if the session wouldn't be a better place than cookies to store this information. Withe the session we can rely on getting back exactly what we put in (a DateTimeImmutable instance) and are avoiding a potentially hostile user input. The only drawback I see is that you can get rid of the session more easily, by closing the browser, but since this is such a basic functionality, I don't see this as lowering the bar for circumvention much.
Made fixes and deployed them
Done by using our own codestyle, based on the MediaWiki one
Nov 25 2020
I've created a new document: https://github.com/wmde/fundraising-infrastructure/wiki/How-to-deal-with-permission-errors-on-deployment
Please read it and tell me if something is missing/unclear.
Deployed to https://testing02.wikimedia.customers.manitu.net
Please user-test it
Nov 19 2020
Nov 17 2020
I've created a patch for our localstorage access, to guard against corruption in Firefox: https://github.com/wmde/fundraising-banners/pull/466
Nov 16 2020
Nov 13 2020
Nov 12 2020
@kai.nissen There are three things missing: