Page MenuHomePhabricator
Feed Advanced Search

Wed, Nov 13

matthiasmullie added a comment to T226093: Capacity planning for Commons Structured Data.

Matthias will look into discrepancies between number of files with mediainfo slots vs. what's indexed in Cirrus.

Wed, Nov 13, 10:24 AM · Structured-Data-Backlog (Current Work), Dumps-Generation, Operations, Wikidata, SDC General

Tue, Nov 12

matthiasmullie closed T236558: "wikidata-federation" Cloud VPS project jessie deprecation as Resolved.

federated-commons.wikidata-federation.eqiad.wmflabs & federated-wikidata.wikidata-federation.eqiad.wmflabs have been deleted

Tue, Nov 12, 11:05 AM · Cloud-VPS (Debian Jessie Deprecation)

Fri, Nov 8

matthiasmullie moved T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 8, 10:11 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie moved T234756: Prevent users from entering short file caption on Commons from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 8, 10:10 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog, Structured Data Engineering, Structured-Data-Backlog (Current Work), Commons
matthiasmullie moved T236320: Internal error while undoing file captions: "Unsaved revision passed" from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 8, 10:10 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons
matthiasmullie moved T236948: PHP Warning: "array_keys() expects parameter 1 to be array" from WikibaseMediaInfo in ApiOpenSearch from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Fri, Nov 8, 10:10 AM · Structured-Data-Backlog (Current Work), Patch-For-Review, Structured Data Engineering, WikibaseMediaInfo, Wikimedia-production-error
matthiasmullie edited projects for T236948: PHP Warning: "array_keys() expects parameter 1 to be array" from WikibaseMediaInfo in ApiOpenSearch, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
Fri, Nov 8, 10:10 AM · Structured-Data-Backlog (Current Work), Patch-For-Review, Structured Data Engineering, WikibaseMediaInfo, Wikimedia-production-error

Thu, Nov 7

matthiasmullie claimed T236948: PHP Warning: "array_keys() expects parameter 1 to be array" from WikibaseMediaInfo in ApiOpenSearch.
Thu, Nov 7, 9:12 PM · Structured-Data-Backlog (Current Work), Patch-For-Review, Structured Data Engineering, WikibaseMediaInfo, Wikimedia-production-error

Mon, Nov 4

matthiasmullie added a comment to T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.

Patch has been updated:

Mon, Nov 4, 1:34 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T236558: "wikidata-federation" Cloud VPS project jessie deprecation.

@Cparle also no longer needs them.
I suspect no-one else needs these anymore, but speak up if you do! I'll wait another week before removing them.

Mon, Nov 4, 10:46 AM · Cloud-VPS (Debian Jessie Deprecation)
matthiasmullie moved T236320: Internal error while undoing file captions: "Unsaved revision passed" from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Mon, Nov 4, 10:20 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons

Thu, Oct 31

Abit awarded T231463: Newly registered user cant save contributions a Love token.
Thu, Oct 31, 3:24 PM · Structured-Data-Backlog (Current Work), ISA

Wed, Oct 30

matthiasmullie added a comment to T236558: "wikidata-federation" Cloud VPS project jessie deprecation.

federated-commons and federated-wikidata can be probably removed.
There's one more instance on there that is still being used (not on Jessie, though): sdc-test-runner - this one should stay.

Wed, Oct 30, 4:16 PM · Cloud-VPS (Debian Jessie Deprecation)
matthiasmullie merged T236911: InvalidArgumentException: Unsaved revision passed when undoing a 'depicts' statement into T236320: Internal error while undoing file captions: "Unsaved revision passed".
Wed, Oct 30, 2:43 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured-Data-Backlog (Current Work), Structured Data Engineering, MediaWiki-Revision-backend, Wikimedia-production-error, Commons
matthiasmullie merged task T236911: InvalidArgumentException: Unsaved revision passed when undoing a 'depicts' statement into T236320: Internal error while undoing file captions: "Unsaved revision passed".
Wed, Oct 30, 2:43 PM · Structured-Data-Backlog, WikibaseMediaInfo
matthiasmullie closed T231463: Newly registered user cant save contributions as Resolved.

Rate limits have been increased for registered & confirmed users.

Wed, Oct 30, 11:33 AM · Structured-Data-Backlog (Current Work), ISA

Tue, Oct 29

matthiasmullie added a comment to T236558: "wikidata-federation" Cloud VPS project jessie deprecation.

We have been using it in the past - unsure if we plan to use it anymore - let me ask around

Tue, Oct 29, 4:35 PM · Cloud-VPS (Debian Jessie Deprecation)

Mon, Oct 28

matthiasmullie closed T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items as Resolved.

Currently being used in production: https://commons.wikimedia.org/w/index.php?title=File%3AJodrell_Bank_Mark_II_5.jpg&type=revision&diff=371864746&oldid=149735587
Closing this one - let's open other more specific tickets for additional work (T236691, T236692) or issues once they arise.

Mon, Oct 28, 2:33 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, a subtask of T212144: Allow access to MediaInfo from wikitext on Commons, as Resolved.
Mon, Oct 28, 2:33 PM · Structured-Data-Backlog, Wikidata, Structured Data Engineering
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Mon, Oct 28, 2:31 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie created T236692: [Spike] Implement MediaInfo-specific Lua library.
Mon, Oct 28, 2:30 PM · Structured-Data-Backlog
matthiasmullie created T236691: Implement alternative `SiteLinkLookup` for MediaInfo entities.
Mon, Oct 28, 2:23 PM · Patch-For-Review, Structured-Data-Backlog (Current Work)

Thu, Oct 24

matthiasmullie added a comment to T236370: Call to undefined method Wikibase\Lib\EntityTypeDefinitions::getPrefetchingTermLookupCallbacks().

Same as with T236372, these happened at the exact time these changes were being scapped, and stopped immediately after: https://logstash.wikimedia.org/goto/cfd3017e60a6be127c9673fd9ff53536

Thu, Oct 24, 12:46 PM · Wikidata-Campsite, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
matthiasmullie added a comment to T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/WikibaseRepo.php on line 2470 and exactly 10 expected.

These all happened at 11:10 UTC, when the change was being deployed. This stopped immediately after: https://logstash.wikimedia.org/goto/39611d534c6b97d76c367f4e4878ab15

Thu, Oct 24, 12:44 PM · Wikidata-Campsite, Wikibase-DataModel, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
matthiasmullie added a comment to T236372: Too few arguments to function Wikibase\DataAccess\SingleEntitySourceServices::__construct(), 9 passed in /extensions/Wikibase/repo/includes/WikibaseRepo.php on line 2470 and exactly 10 expected.

I'll doublecheck, but I think these only happened the minute the patches were being scapped, and then stopped.

Thu, Oct 24, 12:36 PM · Wikidata-Campsite, Wikibase-DataModel, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
matthiasmullie added a comment to T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.

What other wikis have structured data enabled? 😃

Thu, Oct 24, 6:46 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)

Wed, Oct 23

matthiasmullie added a comment to T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.

That copy change in the confirmation dialog is a great idea, I'll go make that change.

Wed, Oct 23, 4:32 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

@matthiasmullie repeating myself from the IRC

Mmh - didn't see anything - what channel was that in? (or DM?)

Wed, Oct 23, 1:54 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie updated subscribers of T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.

So... @Ramsey-WMF/@PDrouin-WMF: here's a few screenshots of how I've implemented this thus far.
Let me know if we need to change things, or if this is ok as-is & we can move on with code review.

Wed, Oct 23, 12:06 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Wed, Oct 23, 11:02 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Tue, Oct 22

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Commons is group 1. Let me know if you'd like me to deploy these patches once merged, or help in any way!

Tue, Oct 22, 3:56 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

There is no magic involved.
Term lookups are performed differently for different entity types (because the data lives elsewhere), but in a non-hacky fashion (and it doesn't really matter where the data comes from or how it's retrieved anyway)

Tue, Oct 22, 6:18 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Mon, Oct 21

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

AFAICT, most operations seem to be working fine.
The one that don't are either:

  • irrelevant (e.g. resolvePropertyId - MediaInfo's aren't properties; or getDescription - it works, but MediaInfo's don't tend to have descriptions...)
  • use SiteLinkLookup (getEntityIdForTitle and getSitelink) - I'm not even sure we'll need these for MediaInfo's - if we do, we can implement that later on!

Other lookups seem to work just fine!

Mon, Oct 21, 7:16 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Apologies for being hard to reach recently @matthiasmullie.
I've submitted a change pair https://gerrit.wikimedia.org/r/544972 + https://gerrit.wikimedia.org/r/544973 with a simple proof-of-concept of what would be my idea how to solve this. I am not certain how to verify that all lookup operations are working as expected, so I would appreciate if you could have a look.

Mon, Oct 21, 5:37 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Oct 17 2019

matthiasmullie moved T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 17 2019, 1:03 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie created T235754: Implement haswbstatement:P<depicts>=Q<your term> autocomplete suggestions.
Oct 17 2019, 11:46 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Structured Data Engineering, Structured-Data-Backlog (Current Work)
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

I should be able to help with it @matthiasmullie . Looking into it...

Oct 17 2019, 11:17 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Oct 16 2019

matthiasmullie moved T235236: [Bug] File Page statement panels are not behaving properly in master branch and production from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 16 2019, 2:09 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering

Oct 11 2019

matthiasmullie moved T235236: [Bug] File Page statement panels are not behaving properly in master branch and production from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 11 2019, 7:30 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T235236: [Bug] File Page statement panels are not behaving properly in master branch and production.
Oct 11 2019, 7:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering

Oct 10 2019

matthiasmullie added a comment to T222867: Captions Panel alignment and overlapping issues in RTL languages .

Heads-up - we're going to start addressing some of these issues soon, but there's a refactoring patch that has to go out first (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseMediaInfo/+/528825/).

Oct 10 2019, 2:42 PM · Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Structured Data Engineering, RTL, I18n, Structured-Data-Team-Current-Work
matthiasmullie closed T233734: WikibaseMediaInfo should not export unprefixed config/globals in JavaScript as Resolved.
Oct 10 2019, 2:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured Data Engineering, Structured-Data-Backlog (Current Work), WikibaseMediaInfo
matthiasmullie moved T233734: WikibaseMediaInfo should not export unprefixed config/globals in JavaScript from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured Data Engineering, Structured-Data-Backlog (Current Work), WikibaseMediaInfo
matthiasmullie moved T231463: Newly registered user cant save contributions from To Do to Blocked on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:40 PM · Structured-Data-Backlog (Current Work), ISA
matthiasmullie moved T235167: When there are no hideable caption languages on the File page, we still get a link saying "show 0 more languages" from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:39 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Structured-Data-Backlog (Current Work), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie moved T234756: Prevent users from entering short file caption on Commons from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:38 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog, Structured Data Engineering, Structured-Data-Backlog (Current Work), Commons
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Update: while above patches got merged, Lua still won't work by next week's deployment (at least not until some more issues are straightened out, but they may require some more work)

Oct 10 2019, 2:05 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Code Review to Doing on the Structured-Data-Backlog (Current Work) board.
Oct 10 2019, 2:01 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Oct 8 2019

matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 8 2019, 10:53 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie moved T233267: Links to Wikidata Q-items don't open in a new tab from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.
Oct 8 2019, 10:53 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering

Oct 7 2019

matthiasmullie moved T229011: Templatize CaptionsPanel.js from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Oct 7 2019, 4:09 PM · Structured-Data-Backlog (Current Work), Patch-For-Review, Structured Data Engineering, WikibaseMediaInfo, Structured-Data-Team-Current-Work

Sep 27 2019

matthiasmullie moved T233267: Links to Wikidata Q-items don't open in a new tab from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Sep 27 2019, 7:14 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T233267: Links to Wikidata Q-items don't open in a new tab.
Sep 27 2019, 7:13 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 24 2019

matthiasmullie added a comment to T231463: Newly registered user cant save contributions.

@OlafJanssen It's not immediately clear to me exactly what's going on.
Did the new user start seeing this error message immediately, when the very first thing was being submitted? (in which case this is probably some yet unknown bug)
Or was it only after having already submitted a few things that it showed up? (in which case I suspect the user was rate limited - only a certain amount of edits are allowed in a short period of time for new users)

Sep 24 2019, 12:40 PM · Structured-Data-Backlog (Current Work), ISA
matthiasmullie moved T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.
Sep 24 2019, 12:10 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
Sep 24 2019, 12:10 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 23 2019

matthiasmullie moved T232499: Provide mechanism for users to opt in to statement the copy functionality from To Do to Doing on the Structured Data Engineering board.
Sep 23 2019, 4:28 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie claimed T232499: Provide mechanism for users to opt in to statement the copy functionality.
Sep 23 2019, 4:28 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 10 2019

matthiasmullie added a project to T232499: Provide mechanism for users to opt in to statement the copy functionality: UploadWizard.
Sep 10 2019, 4:40 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie created T232499: Provide mechanism for users to opt in to statement the copy functionality.
Sep 10 2019, 4:39 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), UploadWizard, Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 6 2019

matthiasmullie placed T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section up for grabs.

And unassigning myself - I don't want to claim this. Anyone can pick this up, work on any number of the acceptance criteria, and pass it on.

Sep 6 2019, 11:03 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie edited projects for T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section, added: Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.

I've spun this off into multiple tickets - one per "category" - and I'm pulling this first one into "current work".

Sep 6 2019, 11:01 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie created T232208: Write selenium tests for QA checklist "Check Language support beyond English" section.
Sep 6 2019, 10:57 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232207: Write selenium tests for QA checklist "Check UI design integrity" section.
Sep 6 2019, 10:57 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232206: Write selenium tests for QA checklist "Check that general Commons functionality is still intact" section.
Sep 6 2019, 10:56 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232205: Write selenium tests for QA checklist "Check that Search works properly" section.
Sep 6 2019, 10:55 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232204: Write selenium tests for QA checklist "Check that diffs between past revisions/edits works" section.
Sep 6 2019, 10:54 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie updated the task description for T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section.
Sep 6 2019, 10:52 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering
matthiasmullie updated the task description for T232200: Write selenium tests for QA checklist "Add Structured data during file upload with Upload Wizard" section.
Sep 6 2019, 10:52 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie updated the task description for T232201: Write selenium tests for QA checklist "Check page/file history AND recent changes" section.
Sep 6 2019, 10:52 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232203: Write selenium tests for QA checklist "Check that watchlists work properly" section.
Sep 6 2019, 10:52 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232201: Write selenium tests for QA checklist "Check page/file history AND recent changes" section.
Sep 6 2019, 10:51 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie created T232200: Write selenium tests for QA checklist "Add Structured data during file upload with Upload Wizard" section.
Sep 6 2019, 10:49 AM · Structured Data Engineering, Structured-Data-Backlog
matthiasmullie renamed T227278: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section from Write selenium tests for QA checklist to Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section.
Sep 6 2019, 10:48 AM · Structured-Data-Backlog (Current Work), Structured Data Engineering

Sep 3 2019

matthiasmullie created T231855: Allow using relative paths in array config vars.
Sep 3 2019, 8:13 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Security, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Structured-Data-Backlog, MediaWiki-Configuration, Wikidata

Sep 2 2019

matthiasmullie created T231789: Many "Unable to store text to external storage" exception on beta (read-only).
Sep 2 2019, 9:27 AM · MediaWiki-Revision-backend, Beta-Cluster-reproducible, Beta-Cluster-Infrastructure

Aug 30 2019

matthiasmullie moved T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Aug 30 2019, 2:09 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)

Aug 29 2019

matthiasmullie added a comment to T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard.

a) is nothing to worry about: already fixed in prod T231488

Aug 29 2019, 7:15 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)

Aug 28 2019

matthiasmullie added a comment to T225102: Refactor UW statements code.

I backported the patch that I believe should fix this - are you still able to get into this stuck state now?

Aug 28 2019, 3:21 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard.

I believe all of those things have now been fixed - can you do another run on labs to verify? :)

Aug 28 2019, 3:19 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)

Aug 27 2019

matthiasmullie claimed T231225: Explore simple, campaign-specific "sync" functionality for statements in UploadWizard.
Aug 27 2019, 12:35 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Structured-Data-Backlog (Current Work), Structured Data Engineering, SDC-Statements (Campaigns-jogging)
matthiasmullie added a comment to T225102: Refactor UW statements code.

Ok cool, thanks for the info!
I suspect the CORS (CSP) errors in console have nothing to do with it (see T135963), but the "abort is not a function" might.

Aug 27 2019, 7:41 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T225102: Refactor UW statements code.

That's on beta, I suspect?
What steps did you do to trigger this? Just added the new property, and that's how it then appeared? Or did you start typing an item? Or did it only appear once you added the other statements or edited anything else?

Aug 27 2019, 7:16 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 26 2019

matthiasmullie added a comment to T229679: Statements with unsupported properties are displayed weirdly on edit.

It's greyed out because that specific datatype has no proper support yet (e.g. can't edit the coordinate)
It's something we want to do soon, though: T224060

Aug 26 2019, 3:04 PM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, SDC-Statements (Other-statements-running), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie moved T228327: Add option to skip structured data parts in upload wizard campaigns from Doing to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Aug 26 2019, 2:58 PM · Structured-Data-Team-Current-Work, UploadWizard, Structured-Data-Backlog (Current Work), Wiki-Loves-Monuments, SDC-Statements (Campaigns-jogging), Structured Data Engineering
matthiasmullie moved T227220: Large numbers not handled properly in quantity qualifier field from Doing to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Aug 26 2019, 2:57 PM · Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie added a comment to T227220: Large numbers not handled properly in quantity qualifier field.

@Ramsey-WMF Is this still broken for you? AFAICT, it works fine now.

Aug 26 2019, 2:57 PM · Structured-Data-Backlog (Current Work), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie closed T229679: Statements with unsupported properties are displayed weirdly on edit as Resolved.

Some of last week's refactors probably solved this.
Closing since I can no longer reproduce this, but if anyone else still sees this, please reopen!

Aug 26 2019, 2:54 PM · Structured-Data-Backlog (Current Work), Structured-Data-Team-Current-Work, SDC-Statements (Other-statements-running), Structured Data Engineering, WikibaseMediaInfo
matthiasmullie claimed T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.
Aug 26 2019, 2:51 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Aug 23 2019

matthiasmullie moved T225102: Refactor UW statements code from To Do to Needs QA on the Structured-Data-Team-Current-Work board.
Aug 23 2019, 8:42 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work
matthiasmullie moved T225102: Refactor UW statements code from Doing to Verify on Production on the Structured Data Engineering board.
Aug 23 2019, 8:36 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Structured-Data-Backlog (Current Work), SDC-Statements (Other-statements-running), Structured Data Engineering, Structured-Data-Team-Current-Work

Aug 15 2019

matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

@LucasWerkmeister Yes - I'm in Stockholm. I'll take a look at your suggestion and then come find you!

Aug 15 2019, 7:29 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient

Aug 1 2019

matthiasmullie added a comment to T229473: Old "digital representation of" statement panels show as grayed out [due to cache].

Things >30d old will expire and get proper treatment, things < 8d should already have correct html in cache.
It's just the things in between, I believe. Basically the "active enough that it *is* in cache (most likely only when bot ran), but not really too active because it's not really recent".
I believe the bad caches size is small enough, the issue trivial enough, and the tempfix (?action=purge) easy enough, that we should not put more effort into it, and just let caches expire.

Aug 1 2019, 7:30 AM · Structured Data Engineering, SDC-Statements (Other-statements-running), Multimedia

Jul 26 2019

matthiasmullie added a project to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items: Structured-Data-Team-Current-Work.
Jul 26 2019, 12:08 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo, a subtask of T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, as Declined.
Jul 26 2019, 12:07 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo as Declined.

It looks like we may not need wb_terms (or the redesigned store) at this time. Declining ticket for now.

Jul 26 2019, 12:07 PM · Multimedia, Wikidata, SDC General, Structured Data Engineering
matthiasmullie closed T227847: Backfill terms index, a subtask of T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items, as Declined.
Jul 26 2019, 12:07 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie closed T227847: Backfill terms index as Declined.

I'll decline this task, since we probably won't end up wanting or needing wb_terms (not yet, at least).
This could be reopened if at some point later on we find that we do have a valid usecase for them.

Jul 26 2019, 12:07 PM · Multimedia, Structured Data Engineering, SDC General
matthiasmullie added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

I was thinking it'd make most sense to use the existing code & structure already used by Wikidata.
But I've since learned about the reasons for not using wb_terms (I figured it was just a case of not having implemented it because there had not been a need for it yet)

Jul 26 2019, 12:07 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
matthiasmullie added a comment to T228807: Existing qualifiers do not appear in read-mode on the file page.

Confirmed fixed on test-commons.

Jul 26 2019, 9:21 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), WikibaseMediaInfo, Structured-Data-Team-Current-Work, Multimedia