Page MenuHomePhabricator
Feed Advanced Search

Fri, Oct 30

SamanthaNguyen added a comment to T266878: Add a namespace to special page classes.

see also: T166010: The Great Namespaceization and Reorg

Fri, Oct 30, 5:31 PM · User-DannyS712, MediaWiki-Special-pages, Platform Engineering

Sun, Oct 25

SamanthaNguyen updated SamanthaNguyen.
Sun, Oct 25, 4:44 AM

Oct 24 2020

SamanthaNguyen added a comment to T265807: CI failures related to SocialProfile affecting other repositories for patches being submitted on the REL1_34 and REL1_35 branch, but not master.

@ashley Nice to see you too Jack Phoenix! :)

Oct 24 2020, 1:34 AM · SocialProfile, Social-Tools, ci-test-error

Oct 19 2020

SamanthaNguyen removed a project from T265108: Cosmos skin: Fix all remaining PHPCS issues: Patch-For-Review.
Oct 19 2020, 6:29 PM · Cosmos
SamanthaNguyen added a comment to T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).

Okay that's fine, thank you anyways!

Oct 19 2020, 5:24 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen added a comment to T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).

@sbassett Thanks for clearing that up. And yeah I'm not sure, it looks like I'm still not able to see the task unfortunately?

Oct 19 2020, 5:15 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen added a comment to T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).

@sbassett Hi! Yes please, I tried looking but I don't see any UI button on my screen to make this task public. Thank you! I don't have access to T263810, but I'm guessing that it would be related to this task then?

Oct 19 2020, 5:02 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen added a comment to T265853: Doxygen for MediaWiki PHP core: the PHP doc block for Linker::link() does not give a link to the FQCN of MediaWiki\Linker\LinkRenderer, only MediaWiki\Linker.

Some examples (to hopefully help anyone who is more familiar with Doxygen) that are affected by this issue:

Oct 19 2020, 3:27 AM · Continuous-Integration-Infrastructure, Upstream, Doxygen
SamanthaNguyen created T265853: Doxygen for MediaWiki PHP core: the PHP doc block for Linker::link() does not give a link to the FQCN of MediaWiki\Linker\LinkRenderer, only MediaWiki\Linker.
Oct 19 2020, 2:57 AM · Continuous-Integration-Infrastructure, Upstream, Doxygen

Oct 17 2020

SamanthaNguyen edited Description on MediaWiki-extensions-Newsletter.
Oct 17 2020, 10:44 PM
SamanthaNguyen claimed T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).

Not sure whether I should make this task as resolved and public, but it's done on our side now, so moving on the Cosmos workboard.

Oct 17 2020, 10:16 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen added a comment to T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).

Patches rolled-out to master, REL1_35, and REL1_34:

Oct 17 2020, 10:02 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen closed T265537: Document process on how to contribute to the Cosmos skin as Resolved.
Oct 17 2020, 9:52 PM · Documentation, Cosmos
SamanthaNguyen updated the task description for T265807: CI failures related to SocialProfile affecting other repositories for patches being submitted on the REL1_34 and REL1_35 branch, but not master.
Oct 17 2020, 9:50 PM · SocialProfile, Social-Tools, ci-test-error
SamanthaNguyen added a comment to T265807: CI failures related to SocialProfile affecting other repositories for patches being submitted on the REL1_34 and REL1_35 branch, but not master.

UploadAvatar extends UploadFromFile, which extends UploadBase, which defines the performUpload() function. Since 1.35, it introduces the $watchlistExpiry parameter, so the method signatures don't match now; this causes a PHP exception to throw.

Oct 17 2020, 9:45 PM · SocialProfile, Social-Tools, ci-test-error
SamanthaNguyen updated the task description for T265807: CI failures related to SocialProfile affecting other repositories for patches being submitted on the REL1_34 and REL1_35 branch, but not master.
Oct 17 2020, 9:41 PM · SocialProfile, Social-Tools, ci-test-error
SamanthaNguyen added a comment to T265807: CI failures related to SocialProfile affecting other repositories for patches being submitted on the REL1_34 and REL1_35 branch, but not master.

So this database column was dropped in master branch, but not in the REL1_34 branch, however last time I worked on SocialProfile, the master branch was the branch that users were expected to use and is expected to be stable with the latest stable version of MediaWiki.

Oct 17 2020, 9:40 PM · SocialProfile, Social-Tools, ci-test-error
SamanthaNguyen added a comment to T265807: CI failures related to SocialProfile affecting other repositories for patches being submitted on the REL1_34 and REL1_35 branch, but not master.

Looks like this column was dropped in the SQL patch at https://github.com/wikimedia/mediawiki-extensions-SocialProfile/blob/master/UserGifts/sql/patches/actor/drop-gift_creator_user_id.sql but there's still code trying to access this SQL column

Oct 17 2020, 9:36 PM · SocialProfile, Social-Tools, ci-test-error
SamanthaNguyen created T265807: CI failures related to SocialProfile affecting other repositories for patches being submitted on the REL1_34 and REL1_35 branch, but not master.
Oct 17 2020, 9:33 PM · SocialProfile, Social-Tools, ci-test-error
SamanthaNguyen lowered the priority of T265108: Cosmos skin: Fix all remaining PHPCS issues from Medium to Low.

Not as high of a priority now, since most are done. (not all are done yet, just two left)

Oct 17 2020, 6:56 PM · Cosmos
SamanthaNguyen moved T265637: Cosmos: Update screenshots from Backlog to Update or Improvement Needed to Existing Technical Documentation on the Documentation board.
Oct 17 2020, 6:53 PM · Documentation, Cosmos
SamanthaNguyen moved T265537: Document process on how to contribute to the Cosmos skin from Backlog to Update or Improvement Needed to Existing Technical Documentation on the Documentation board.
Oct 17 2020, 6:53 PM · Documentation, Cosmos
SamanthaNguyen moved T265537: Document process on how to contribute to the Cosmos skin from Incoming / Backlog to In Progress on the Cosmos board.
Oct 17 2020, 6:52 PM · Documentation, Cosmos
SamanthaNguyen triaged T264559: Add Discord webhook to wikimedia GitHub for tracking repository changes. as Lowest priority.
Oct 17 2020, 4:17 PM · Cosmos, Release-Engineering-Team, Wikimedia-GitHub
SamanthaNguyen triaged T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620) as High priority.
Oct 17 2020, 4:17 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen triaged T265229: Setup Phan for the Cosmos skin as Low priority.
Oct 17 2020, 4:16 PM · phan, Cosmos
SamanthaNguyen triaged T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings as Low priority.
Oct 17 2020, 4:16 PM · Cosmos
SamanthaNguyen triaged T265537: Document process on how to contribute to the Cosmos skin as Low priority.
Oct 17 2020, 4:16 PM · Documentation, Cosmos
SamanthaNguyen triaged T265233: Standardize color palette, extract out an interface containg constants for each color as Low priority.
Oct 17 2020, 4:16 PM · Cosmos
SamanthaNguyen triaged T265109: Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class as Medium priority.
Oct 17 2020, 4:15 PM · Cosmos
SamanthaNguyen raised the priority of T264908: Convert Cosmos to use HTML templating from Low to Medium.
Oct 17 2020, 4:12 PM · MediaWiki-HTML-Templating, Cosmos
SamanthaNguyen moved T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code from Incoming / Backlog to In Progress on the Cosmos board.
Oct 17 2020, 3:41 PM · Goal, Cosmos
SamanthaNguyen closed T265567: Cosmos skin: Replace deprecated User->getOption() call with UserOptionsLookup as Resolved.
Oct 17 2020, 3:40 PM · Cosmos
SamanthaNguyen moved T265539: Add soft dependencies of the Cosmos skin to CI jobs from In Progress to Done on the Cosmos board.
Oct 17 2020, 3:34 PM · Cosmos, Continuous-Integration-Config
SamanthaNguyen moved T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620) from In Progress to Blocked on the Cosmos board.
Oct 17 2020, 3:31 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen moved T264559: Add Discord webhook to wikimedia GitHub for tracking repository changes. from Incoming / Backlog to Blocked on the Cosmos board.
Oct 17 2020, 3:30 PM · Cosmos, Release-Engineering-Team, Wikimedia-GitHub
SamanthaNguyen moved T265567: Cosmos skin: Replace deprecated User->getOption() call with UserOptionsLookup from Incoming / Backlog to In Progress on the Cosmos board.
Oct 17 2020, 3:29 PM · Cosmos

Oct 15 2020

SamanthaNguyen updated subscribers of T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).

Adding @alistair3149 as a subscriber, as they recently joined the developer team for the Cosmos skin.

Oct 15 2020, 11:34 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen added a comment to T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).

Hi everyone, I hope this is fine. It's not to rush anyone, its just this is a matter of being a security issue (albeit, not a repository that's deployed on Wikimedia). Does the patch above look OK? I received an OK from Universal Omega on Discord, and I would like to receive at least one more OK so I can push this to master branch and backport it to the other branches as well. Also CC'ing @DannyS712, since Urbanecm added them as a subscriber.

Oct 15 2020, 11:31 PM · Cosmos, Vuln-XSS, Security
SamanthaNguyen changed the status of T265108: Cosmos skin: Fix all remaining PHPCS issues from Open to Stalled.

This is now stalled as this requires fixing MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures, which requires refactoring CosmosSocialProfile::getMostWantedPages()

Oct 15 2020, 11:15 PM · Cosmos
SamanthaNguyen changed the status of T265108: Cosmos skin: Fix all remaining PHPCS issues, a subtask of T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code, from Open to Stalled.
Oct 15 2020, 11:15 PM · Goal, Cosmos
SamanthaNguyen closed T265110: Cosmos skin: Replace calls to global function wfMessage(), a subtask of T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation, as Resolved.
Oct 15 2020, 11:01 PM · Cosmos
SamanthaNguyen closed T265110: Cosmos skin: Replace calls to global function wfMessage() as Resolved.
Oct 15 2020, 11:01 PM · Cosmos
SamanthaNguyen added a project to T265675: RGBA hexadecimal value is not supported in background-color (no support for transparency value): TemplateStyles.
Oct 15 2020, 9:04 PM · TemplateStyles
SamanthaNguyen added a parent task for T265110: Cosmos skin: Replace calls to global function wfMessage(): T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation.
Oct 15 2020, 8:42 PM · Cosmos
SamanthaNguyen added a subtask for T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation: T265110: Cosmos skin: Replace calls to global function wfMessage().
Oct 15 2020, 8:42 PM · Cosmos
SamanthaNguyen added a comment to T265539: Add soft dependencies of the Cosmos skin to CI jobs.

@Universal_Omega See https://github.com/wikimedia/integration-config/blob/master/zuul/parameter_functions.py#L141 for how it currently works

Oct 15 2020, 7:34 PM · Cosmos, Continuous-Integration-Config
SamanthaNguyen closed T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate, a subtask of T264908: Convert Cosmos to use HTML templating, as Resolved.
Oct 15 2020, 7:31 PM · MediaWiki-HTML-Templating, Cosmos
SamanthaNguyen closed T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate as Resolved.
Oct 15 2020, 7:31 PM · Cosmos
SamanthaNguyen moved T265110: Cosmos skin: Replace calls to global function wfMessage() from Incoming / Backlog to In Progress on the Cosmos board.
Oct 15 2020, 7:14 PM · Cosmos
SamanthaNguyen added a project to T265637: Cosmos: Update screenshots: Documentation.
Oct 15 2020, 6:20 PM · Documentation, Cosmos
SamanthaNguyen added a comment to T265109: Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class.

Switching to ResourceLoaderImageModule would slightly change behavior as they would have to be applied as a background image via the CSS background-image property.

Oct 15 2020, 6:05 AM · Cosmos
SamanthaNguyen triaged T265567: Cosmos skin: Replace deprecated User->getOption() call with UserOptionsLookup as Low priority.
Oct 15 2020, 6:03 AM · Cosmos
SamanthaNguyen updated the task description for T265567: Cosmos skin: Replace deprecated User->getOption() call with UserOptionsLookup.
Oct 15 2020, 6:02 AM · Cosmos
SamanthaNguyen created T265567: Cosmos skin: Replace deprecated User->getOption() call with UserOptionsLookup.
Oct 15 2020, 6:02 AM · Cosmos
SamanthaNguyen triaged T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate as Medium priority.
Oct 15 2020, 5:02 AM · Cosmos
SamanthaNguyen moved T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate from Incoming / Backlog to In Progress on the Cosmos board.
Oct 15 2020, 5:02 AM · Cosmos
SamanthaNguyen added a comment to T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings.

Before this is done, needs some reviewing of how we can make it work nicely with \ServiceOptions, eventually we'll want to convert some stuff into services

Oct 15 2020, 1:02 AM · Cosmos
SamanthaNguyen moved T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · Cosmos
SamanthaNguyen moved T265063: Factor SocialProfile features of Cosmos into an extension from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · Cosmos
SamanthaNguyen moved T265229: Setup Phan for the Cosmos skin from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · phan, Cosmos
SamanthaNguyen moved T265109: Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · Cosmos
SamanthaNguyen moved T265233: Standardize color palette, extract out an interface containg constants for each color from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · Cosmos
SamanthaNguyen moved T264908: Convert Cosmos to use HTML templating from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · MediaWiki-HTML-Templating, Cosmos
SamanthaNguyen moved T265110: Cosmos skin: Replace calls to global function wfMessage() from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · Cosmos
SamanthaNguyen moved T265179: Cosmos skin: Fix all remaining ESLint issues from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · Cosmos
SamanthaNguyen moved T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · Goal, Cosmos
SamanthaNguyen moved T265180: Cosmos skin: Fix all remaining Stylelint issues from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:11 AM · Cosmos
SamanthaNguyen moved T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings from Code hygiene to Incoming / Backlog on the Cosmos board.
Oct 15 2020, 12:10 AM · Cosmos
SamanthaNguyen moved T264907: Convert Cosmos to use ConfigRegistry from Code hygiene to In Progress on the Cosmos board.
Oct 15 2020, 12:09 AM · Patch-For-Review, Cosmos, MediaWiki-Configuration
SamanthaNguyen moved T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation from Code hygiene to In Progress on the Cosmos board.
Oct 15 2020, 12:09 AM · Cosmos
SamanthaNguyen moved T265108: Cosmos skin: Fix all remaining PHPCS issues from Code hygiene to In Progress on the Cosmos board.
Oct 15 2020, 12:09 AM · Cosmos
SamanthaNguyen moved T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620) from Code hygiene to In Progress on the Cosmos board.
Oct 15 2020, 12:09 AM · Cosmos, Vuln-XSS, Security
SamanthaNguyen added a comment to T265539: Add soft dependencies of the Cosmos skin to CI jobs.

Just discussed, adding ManageWiki as a soft dependency will probably need a separate task as it requires more setup (since it was created for the Miraheze wiki platform). The rest should be fine.

Oct 15 2020, 12:03 AM · Cosmos, Continuous-Integration-Config

Oct 14 2020

SamanthaNguyen added a comment to T265231: Sniff for detecting variables named in snake_case style? (lowercase, separation included using underscores).

@thiemowmde Thank you for your input! There's not really any issue besides being consistent with the coding conventions.

Oct 14 2020, 10:34 PM · MediaWiki-Codesniffer
SamanthaNguyen added a parent task for T264907: Convert Cosmos to use ConfigRegistry: T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings.
Oct 14 2020, 8:24 PM · Patch-For-Review, Cosmos, MediaWiki-Configuration
SamanthaNguyen added a subtask for T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings: T264907: Convert Cosmos to use ConfigRegistry.
Oct 14 2020, 8:24 PM · Cosmos
SamanthaNguyen moved T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings from Incoming / Backlog to Code hygiene on the Cosmos board.
Oct 14 2020, 8:20 PM · Cosmos
SamanthaNguyen updated the task description for T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings.
Oct 14 2020, 8:20 PM · Cosmos
SamanthaNguyen created T265540: Cosmos skin: Create high-level abstraction layer that can validate and retrieve configuration settings.
Oct 14 2020, 8:19 PM · Cosmos
SamanthaNguyen updated the task description for T265537: Document process on how to contribute to the Cosmos skin.
Oct 14 2020, 8:00 PM · Documentation, Cosmos
SamanthaNguyen updated subscribers of T265539: Add soft dependencies of the Cosmos skin to CI jobs.

@Universal_Omega Do you want to work on this? I can help show you how to make a patch to integration-config.

Oct 14 2020, 7:56 PM · Cosmos, Continuous-Integration-Config
SamanthaNguyen created T265539: Add soft dependencies of the Cosmos skin to CI jobs.
Oct 14 2020, 7:55 PM · Cosmos, Continuous-Integration-Config
SamanthaNguyen created T265537: Document process on how to contribute to the Cosmos skin.
Oct 14 2020, 7:49 PM · Documentation, Cosmos
SamanthaNguyen lowered the priority of T265180: Cosmos skin: Fix all remaining Stylelint issues from Medium to Low.
Oct 14 2020, 2:33 AM · Cosmos
SamanthaNguyen lowered the priority of T265179: Cosmos skin: Fix all remaining ESLint issues from Medium to Low.
Oct 14 2020, 2:33 AM · Cosmos
SamanthaNguyen added a comment to T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).

Oct 14 2020, 2:05 AM · Cosmos, Vuln-XSS, Security
SamanthaNguyen added a project to T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620): Vuln-XSS.
Oct 14 2020, 1:40 AM · Cosmos, Vuln-XSS, Security
SamanthaNguyen created T265440: Cosmos skin: Mix used of wfMessage() calls with no output mode and Html::rawElement (CVE-2020-27620).
Oct 14 2020, 1:33 AM · Cosmos, Vuln-XSS, Security

Oct 13 2020

SamanthaNguyen closed T265317: Switch to AutoloadNamespaces in Cosmos skin as Resolved.
Oct 13 2020, 9:26 PM · Cosmos
SamanthaNguyen added a comment to T265109: Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class.

(We also don't need to necessarily use OOUI icons and is actually more out of scope for this task, but could be something to consider in the future)

Oct 13 2020, 8:38 AM · Cosmos
SamanthaNguyen added a comment to T265109: Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class.

Ultimately the goal should be that we can just store plain SVG files under resources and load them through ResourceLoader. Currently the icon SVG data is stored in a nested associative array, but that's not very nice to have. See https://www.mediawiki.org/wiki/Manual:ResourceLoaderImageModule.php

Oct 13 2020, 8:36 AM · Cosmos
SamanthaNguyen updated SamanthaNguyen.
Oct 13 2020, 8:15 AM
SamanthaNguyen created T265317: Switch to AutoloadNamespaces in Cosmos skin.
Oct 13 2020, 12:34 AM · Cosmos

Oct 12 2020

SamanthaNguyen added a parent task for T264907: Convert Cosmos to use ConfigRegistry: T265063: Factor SocialProfile features of Cosmos into an extension.
Oct 12 2020, 10:31 PM · Patch-For-Review, Cosmos, MediaWiki-Configuration
SamanthaNguyen added a subtask for T265063: Factor SocialProfile features of Cosmos into an extension: T264907: Convert Cosmos to use ConfigRegistry.
Oct 12 2020, 10:31 PM · Cosmos
SamanthaNguyen added a subtask for T264908: Convert Cosmos to use HTML templating: T265109: Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class.
Oct 12 2020, 10:30 PM · MediaWiki-HTML-Templating, Cosmos
SamanthaNguyen added a parent task for T265109: Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class: T264908: Convert Cosmos to use HTML templating.
Oct 12 2020, 10:30 PM · Cosmos
SamanthaNguyen added a subtask for T264908: Convert Cosmos to use HTML templating: T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate.
Oct 12 2020, 10:28 PM · MediaWiki-HTML-Templating, Cosmos
SamanthaNguyen added a parent task for T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate: T264908: Convert Cosmos to use HTML templating.
Oct 12 2020, 10:28 PM · Cosmos