Page MenuHomePhabricator
Feed Advanced Search

Oct 12 2020

SamanthaNguyen added a parent task for T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate: T264908: Convert Cosmos to use HTML templating.
Oct 12 2020, 10:28 PM · Cosmos
SamanthaNguyen added a comment to T265233: Standardize color palette, extract out an interface containg constants for each color.

Preferrably, we should work on styling issues in CSS/LESS first (see T265180) before this task.

Oct 12 2020, 5:35 AM · Cosmos
SamanthaNguyen created T265233: Standardize color palette, extract out an interface containg constants for each color.
Oct 12 2020, 5:34 AM · Cosmos
SamanthaNguyen added a member for Trusted-Contributors: Universal_Omega.
Oct 12 2020, 5:28 AM
SamanthaNguyen created T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate.
Oct 12 2020, 4:33 AM · Cosmos
SamanthaNguyen updated subscribers of T265231: Sniff for detecting variables named in snake_case style? (lowercase, separation included using underscores).
Oct 12 2020, 4:23 AM · MediaWiki-Codesniffer
SamanthaNguyen added a comment to T265231: Sniff for detecting variables named in snake_case style? (lowercase, separation included using underscores).

I haven't written a sniff for PHPCS but would be interested in contributing anyways, but I'm fine if someone else would want to take over (since I am also a bit busy).

Oct 12 2020, 3:39 AM · MediaWiki-Codesniffer
SamanthaNguyen created T265231: Sniff for detecting variables named in snake_case style? (lowercase, separation included using underscores).
Oct 12 2020, 3:33 AM · MediaWiki-Codesniffer
SamanthaNguyen moved T265229: Setup Phan for the Cosmos skin from Incoming / Backlog to Code hygiene on the Cosmos board.
Oct 12 2020, 3:29 AM · phan, Cosmos
SamanthaNguyen moved T265229: Setup Phan for the Cosmos skin from Backlog to Extensions on the phan board.
Oct 12 2020, 3:29 AM · phan, Cosmos
SamanthaNguyen added a project to T265229: Setup Phan for the Cosmos skin: phan.
Oct 12 2020, 3:29 AM · phan, Cosmos
SamanthaNguyen created T265229: Setup Phan for the Cosmos skin.
Oct 12 2020, 3:28 AM · phan, Cosmos

Oct 11 2020

SamanthaNguyen added a comment to T265063: Factor SocialProfile features of Cosmos into an extension.

CosmosProfile repository was created by Chris on October 9th (2 days ago) in https://www.mediawiki.org/w/index.php?diff=4161443

Oct 11 2020, 7:39 PM · Cosmos
SamanthaNguyen updated the task description for T265107: Re-namespace code under MediaWiki\Skin\Cosmos.
Oct 11 2020, 7:14 PM · Cosmos
SamanthaNguyen added a comment to T265107: Re-namespace code under MediaWiki\Skin\Cosmos.

Halfway done, now needs migration to MediaWiki\Skin\Cosmos namespace

Oct 11 2020, 7:14 PM · Cosmos
SamanthaNguyen added a comment to T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation.

While we're at this, I'm currently wondering if CosmosNavigation::parseItem() and CosmosToolbar::parseItem() can be removed safely.
T hey don't seem to be used within the Cosmos source code according to Codesearch https://codesearch.wmcloud.org/skins/?q=parseItem&i=nope&files=&repos=Skin:Cosmos

Oct 11 2020, 7:11 PM · Cosmos
SamanthaNguyen triaged T265110: Cosmos skin: Replace calls to global function wfMessage() as Medium priority.
Oct 11 2020, 5:56 PM · Cosmos

Oct 10 2020

SamanthaNguyen added a comment to T265108: Cosmos skin: Fix all remaining PHPCS issues.

Except MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation, which can be auto-fixed

Oct 10 2020, 9:12 PM · Patch-For-Review, Cosmos
SamanthaNguyen added a comment to T265108: Cosmos skin: Fix all remaining PHPCS issues.
  • the Generic.Files.LineLength.TooLong will need to be manually fixed, same with the MediaWiki.Commenting.* sniffs
  • the SpaceyParenthesis sniffs can be auto-fixed but needs careful review since it will end up fixing at least ~2600+ detected errors
  • the rest of the Squiz sniffs are auto-fixable, and can maybe be all done in one patch (depends how many fixes there are, if it's like the SpaceyParenthesis sniffs, then it will need to be split up)
  • MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures needs manually fixing
  • MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName needs manually fixing
Oct 10 2020, 9:09 PM · Patch-For-Review, Cosmos
SamanthaNguyen moved T264907: Convert Cosmos to use ConfigRegistry from Feature requests to Code hygiene on the Cosmos board.
Oct 10 2020, 9:01 PM · Patch-For-Review, Cosmos, MediaWiki-Configuration
SamanthaNguyen moved T264908: Convert Cosmos to use HTML templating from Feature requests to Code hygiene on the Cosmos board.
Oct 10 2020, 9:01 PM · MediaWiki-HTML-Templating, Cosmos
SamanthaNguyen moved T265063: Factor SocialProfile features of Cosmos into an extension from Feature requests to Code hygiene on the Cosmos board.
Oct 10 2020, 9:01 PM · Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 7:44 PM · Patch-For-Review, Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 6:20 PM · Patch-For-Review, Cosmos
SamanthaNguyen added a comment to T265063: Factor SocialProfile features of Cosmos into an extension.

All methods under CosmosSocialProfile had an undeclared visibility, and is fixed in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Cosmos/+/633317.

Oct 10 2020, 6:17 PM · Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 6:07 PM · Patch-For-Review, Cosmos
SamanthaNguyen triaged T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation as Medium priority.

This should be looked at once PHPCS styling issues are done (T265108) and re-namespacing is done (T265107).

Oct 10 2020, 5:25 PM · Cosmos
SamanthaNguyen updated the task description for T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation.
Oct 10 2020, 5:23 PM · Cosmos
SamanthaNguyen updated the task description for T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation.
Oct 10 2020, 5:16 PM · Cosmos
SamanthaNguyen updated subscribers of T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation.
Oct 10 2020, 5:13 PM · Cosmos
SamanthaNguyen created T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation.
Oct 10 2020, 5:13 PM · Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 4:53 PM · Patch-For-Review, Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 4:47 PM · Patch-For-Review, Cosmos
SamanthaNguyen updated the task description for T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code.
Oct 10 2020, 4:08 PM · Goal, Cosmos
SamanthaNguyen added a parent task for T265108: Cosmos skin: Fix all remaining PHPCS issues: T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code.
Oct 10 2020, 4:06 PM · Patch-For-Review, Cosmos
SamanthaNguyen added a subtask for T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code: T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 4:06 PM · Goal, Cosmos
SamanthaNguyen added a subtask for T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code: T265179: Cosmos skin: Fix all remaining ESLint issues.
Oct 10 2020, 4:06 PM · Goal, Cosmos
SamanthaNguyen added a parent task for T265179: Cosmos skin: Fix all remaining ESLint issues: T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code.
Oct 10 2020, 4:06 PM · Cosmos
SamanthaNguyen added a subtask for T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code: T265180: Cosmos skin: Fix all remaining Stylelint issues.
Oct 10 2020, 4:06 PM · Goal, Cosmos
SamanthaNguyen added a parent task for T265180: Cosmos skin: Fix all remaining Stylelint issues: T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code.
Oct 10 2020, 4:05 PM · Cosmos
SamanthaNguyen triaged T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code as Medium priority.
Oct 10 2020, 4:04 PM · Goal, Cosmos
SamanthaNguyen created T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code.
Oct 10 2020, 4:04 PM · Goal, Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 3:38 PM · Patch-For-Review, Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 3:09 PM · Patch-For-Review, Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 12:49 PM · Patch-For-Review, Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 12:45 PM · Patch-For-Review, Cosmos
SamanthaNguyen renamed T265107: Re-namespace code under MediaWiki\Skin\Cosmos from Re-namespace code under MediaWiki\Skins\Cosmos to Re-namespace code under MediaWiki\Skin\Cosmos.
Oct 10 2020, 6:45 AM · Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 6:38 AM · Patch-For-Review, Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 6:24 AM · Patch-For-Review, Cosmos
SamanthaNguyen updated the task description for T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 10 2020, 6:21 AM · Patch-For-Review, Cosmos

Oct 9 2020

SamanthaNguyen updated the task description for T265179: Cosmos skin: Fix all remaining ESLint issues.
Oct 9 2020, 10:08 PM · Cosmos
SamanthaNguyen updated the task description for T265180: Cosmos skin: Fix all remaining Stylelint issues.
Oct 9 2020, 10:08 PM · Cosmos
SamanthaNguyen updated the task description for T265179: Cosmos skin: Fix all remaining ESLint issues.
Oct 9 2020, 10:05 PM · Cosmos
SamanthaNguyen updated the task description for T265180: Cosmos skin: Fix all remaining Stylelint issues.
Oct 9 2020, 10:04 PM · Cosmos
SamanthaNguyen triaged T265180: Cosmos skin: Fix all remaining Stylelint issues as Medium priority.
Oct 9 2020, 9:47 PM · Cosmos
SamanthaNguyen created T265180: Cosmos skin: Fix all remaining Stylelint issues.
Oct 9 2020, 9:47 PM · Cosmos
SamanthaNguyen triaged T265179: Cosmos skin: Fix all remaining ESLint issues as Medium priority.
Oct 9 2020, 9:47 PM · Cosmos
SamanthaNguyen created T265179: Cosmos skin: Fix all remaining ESLint issues.
Oct 9 2020, 9:47 PM · Cosmos
SamanthaNguyen triaged T265107: Re-namespace code under MediaWiki\Skin\Cosmos as Low priority.
Oct 9 2020, 9:38 PM · Cosmos
SamanthaNguyen assigned T265107: Re-namespace code under MediaWiki\Skin\Cosmos to Universal_Omega.
Oct 9 2020, 9:27 PM · Cosmos
SamanthaNguyen updated the task description for T265110: Cosmos skin: Replace calls to global function wfMessage().
Oct 9 2020, 8:42 PM · Cosmos
SamanthaNguyen added a comment to T265107: Re-namespace code under MediaWiki\Skin\Cosmos.

In a follow-up task, we should convert to AutoloadNamespaces as well.

Oct 9 2020, 8:35 PM · Cosmos
SamanthaNguyen updated the task description for T265107: Re-namespace code under MediaWiki\Skin\Cosmos.
Oct 9 2020, 8:19 PM · Cosmos
SamanthaNguyen updated the task description for T265107: Re-namespace code under MediaWiki\Skin\Cosmos.
Oct 9 2020, 8:19 PM · Cosmos
SamanthaNguyen removed a project from T265104: Cosmos skin: Setup ESLint and Stylelint: Patch-For-Review.
Oct 9 2020, 6:40 PM · Patch-For-Review, Cosmos
SamanthaNguyen closed T265104: Cosmos skin: Setup ESLint and Stylelint as Resolved.
Oct 9 2020, 6:39 PM · Patch-For-Review, Cosmos
SamanthaNguyen triaged T265104: Cosmos skin: Setup ESLint and Stylelint as Medium priority.
Oct 9 2020, 4:33 AM · Patch-For-Review, Cosmos
SamanthaNguyen created T265110: Cosmos skin: Replace calls to global function wfMessage().
Oct 9 2020, 4:32 AM · Cosmos
SamanthaNguyen moved T265104: Cosmos skin: Setup ESLint and Stylelint from Incoming / Backlog to Code hygiene on the Cosmos board.
Oct 9 2020, 4:30 AM · Patch-For-Review, Cosmos
SamanthaNguyen moved T265107: Re-namespace code under MediaWiki\Skin\Cosmos from Incoming / Backlog to Code hygiene on the Cosmos board.
Oct 9 2020, 4:30 AM · Cosmos
SamanthaNguyen moved T265108: Cosmos skin: Fix all remaining PHPCS issues from Incoming / Backlog to Code hygiene on the Cosmos board.
Oct 9 2020, 4:30 AM · Patch-For-Review, Cosmos
SamanthaNguyen moved T265109: Cosmos skin: Work on getting rid of the nasty MediaWiki\Skin\Cosmos\Icon class from Incoming / Backlog to Code hygiene on the Cosmos board.
Oct 9 2020, 4:30 AM · Cosmos
SamanthaNguyen created T265109: Cosmos skin: Work on getting rid of the nasty MediaWiki\Skin\Cosmos\Icon class.
Oct 9 2020, 4:30 AM · Cosmos
SamanthaNguyen triaged T265108: Cosmos skin: Fix all remaining PHPCS issues as Medium priority.
Oct 9 2020, 4:27 AM · Patch-For-Review, Cosmos
SamanthaNguyen renamed T265108: Cosmos skin: Fix all remaining PHPCS issues from Fix all remaining PHPCS issues to Cosmos skin: Fix all remaining PHPCS issues.
Oct 9 2020, 4:27 AM · Patch-For-Review, Cosmos
SamanthaNguyen created T265108: Cosmos skin: Fix all remaining PHPCS issues.
Oct 9 2020, 4:27 AM · Patch-For-Review, Cosmos
SamanthaNguyen created T265107: Re-namespace code under MediaWiki\Skin\Cosmos.
Oct 9 2020, 4:20 AM · Cosmos
SamanthaNguyen committed rSCOS5a5bf68f6891: Setup MediaWiki PHPCS and other standard dev packages (authored by Sam Nguyen <sam.t.nguyenn@gmail.com>).
Setup MediaWiki PHPCS and other standard dev packages
Oct 9 2020, 4:01 AM
SamanthaNguyen committed rSCOS1dbca1ef87ed: Setup MediaWiki PHPCS and other standard dev packages (authored by Sam Nguyen <sam.t.nguyenn@gmail.com>).
Setup MediaWiki PHPCS and other standard dev packages
Oct 9 2020, 4:01 AM
SamanthaNguyen committed rSCOS38dc20af3c97: PHPCS: Fix styling issues related to use statements (authored by Sam Nguyen <sam.t.nguyenn@gmail.com>).
PHPCS: Fix styling issues related to use statements
Oct 9 2020, 3:42 AM
SamanthaNguyen renamed T265104: Cosmos skin: Setup ESLint and Stylelint from Setup ESLint and Stylelint to Cosmos skin: Setup ESLint and Stylelint.
Oct 9 2020, 3:11 AM · Patch-For-Review, Cosmos
SamanthaNguyen created T265104: Cosmos skin: Setup ESLint and Stylelint.
Oct 9 2020, 3:11 AM · Patch-For-Review, Cosmos
SamanthaNguyen closed T265102: Cosmos: Fix media query rule conflicts between stylesheet files and ResourceLoader module declarations as Resolved.

CI issue is fixed. Follow-up patches will be made in the future for consolidating media queries and such.

Oct 9 2020, 2:56 AM · ci-test-error, Cosmos
SamanthaNguyen claimed T265102: Cosmos: Fix media query rule conflicts between stylesheet files and ResourceLoader module declarations.
Oct 9 2020, 1:40 AM · ci-test-error, Cosmos
SamanthaNguyen triaged T265102: Cosmos: Fix media query rule conflicts between stylesheet files and ResourceLoader module declarations as High priority.
Oct 9 2020, 1:30 AM · ci-test-error, Cosmos
SamanthaNguyen renamed T265102: Cosmos: Fix media query rule conflicts between stylesheet files and ResourceLoader module declarations from Fix Travis CI failures caused by media queries in mediawiki/skins/Cosmos to Cosmos: Fix media query rule conflicts between stylesheet files and ResourceLoader module declarations.
Oct 9 2020, 1:29 AM · ci-test-error, Cosmos

Oct 8 2020

SamanthaNguyen added a watcher for Cosmos: SamanthaNguyen.
Oct 8 2020, 9:57 PM
SamanthaNguyen added a member for Cosmos: SamanthaNguyen.
Oct 8 2020, 9:57 PM

Oct 6 2020

SamanthaNguyen updated subscribers of T264697: Sofa extension calls PageDeletionUpdates hook even though PageDeletionUpdates hook doesn't exist.
Oct 6 2020, 4:04 AM · MediaWiki-extensions-Other
SamanthaNguyen updated the task description for T264697: Sofa extension calls PageDeletionUpdates hook even though PageDeletionUpdates hook doesn't exist.
Oct 6 2020, 3:58 AM · MediaWiki-extensions-Other
SamanthaNguyen created T264697: Sofa extension calls PageDeletionUpdates hook even though PageDeletionUpdates hook doesn't exist.
Oct 6 2020, 3:55 AM · MediaWiki-extensions-Other

Sep 11 2020

SamanthaNguyen closed T262640: Attempting to run StructuredNavigation that requires PHP 7.4 fails CI tests, as tests setup only run PHP 7.2 as Resolved.
Sep 11 2020, 1:38 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release-Engineering-Team (CI & Testing services), PHP 7.4 support, Continuous-Integration-Config
SamanthaNguyen added a comment to T262640: Attempting to run StructuredNavigation that requires PHP 7.4 fails CI tests, as tests setup only run PHP 7.2.

Thank you Hashar for your explanation (it makes sense), and for the updated patch in integration/config! I don't believe anything else is action-able left in this task, so I'll mark this as resolved.

Sep 11 2020, 1:38 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release-Engineering-Team (CI & Testing services), PHP 7.4 support, Continuous-Integration-Config
SamanthaNguyen created T262640: Attempting to run StructuredNavigation that requires PHP 7.4 fails CI tests, as tests setup only run PHP 7.2.
Sep 11 2020, 7:48 AM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release-Engineering-Team (CI & Testing services), PHP 7.4 support, Continuous-Integration-Config

Aug 22 2020

SamanthaNguyen created T261034: CentralAuth calls "UserInvalidateEmailComplete" hook which doesn't exist, but "InvalidateEmailComplete" exists.
Aug 22 2020, 12:46 AM · MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), Platform Engineering, MediaWiki-extensions-CentralAuth

Mar 18 2020

SamanthaNguyen placed T155219: [GOAL] Make Nimbus responsive up for grabs.
Mar 18 2020, 8:38 PM · Goal, Mobile, Design, CSS, Nimbus
SamanthaNguyen placed T155458: Material skin footer needs styling up for grabs.
Mar 18 2020, 8:38 PM · CSS, Design, Material
SamanthaNguyen placed T155461: Material should use it's available mixins and variables up for grabs.
Mar 18 2020, 8:37 PM · Technical-Debt, CSS, Material
SamanthaNguyen placed T184204: The footer styles for the Material skin is non-existent up for grabs.
Mar 18 2020, 8:37 PM · Material

Jan 5 2020

SamanthaNguyen added a comment to T152860: Improve MediaWiki.org documentation for Refreshed skin.

@MtMNC: Thank you for your recent work on the Refreshed skin with v4 and getting that out of beta, it’s really great work. I don’t really do any MediaWiki-related work anymore, but I appreciate the efforts to update the docs too. Feel free to close this ticket; I’m sure I had more ideas about why I created this ticket, but that was a long time ago.

Jan 5 2020, 11:13 PM · Documentation, Brickimedia, Refreshed