Page MenuHomePhabricator
Feed Advanced Search

Thu, Feb 25

cscott committed rEPFU04bb8c3acb26: Replace use of Parser::$mStripState, deprecated in 1.35 (authored by cscott).
Replace use of Parser::$mStripState, deprecated in 1.35
Thu, Feb 25, 3:59 AM

Tue, Feb 23

cscott added a comment to T165098: unpackDOMFragments doesn't handle all mandatory content model constraints (those that are enforced by the HTML5 tree builder on a HTML5 parse).

Might be worth adding a "serialize-then-parse and check you get the same tree" assertion at some point to try to catch these cases more aggressively. @ssastry mentioned that we sort of do this already with our RT testing framework. In theory we could do this in parser tests as well, but I was a little disappointed to see that we didn't already have a parser test case for [[Foo|<div></div>]] so adding that assertion to the parser test framework might not buy us any extra coverage or protection.

Tue, Feb 23, 5:23 PM · Parsoid-DOM, Parsoid

Mon, Feb 22

cscott created T275444: Add baseconfig for banwiki (or rewrite test).
Mon, Feb 22, 9:58 PM · Parsoid
cscott added a comment to T275082: Develop a spec for representing a DOM range in serialized Parsoid output.

https://phabricator.wikimedia.org/T214241#6849806 contains some earlier discussion, framed at the time as an issue of collapsing wrapper elements.

Mon, Feb 22, 6:12 PM · Parsoid
cscott added a comment to T214241: data-mw info is clobbered by template annotations.

In T275082: Develop a spec for representing a DOM range in serialized Parsoid output the proposal is to have a way to represent a DOM *range*, both internally to Parsoid as well as externally as a serialization form. This is related to "issue #1" from the comment above, where we wanted to have a uniform way to represent "collapsed wrappers". However, the main difference is that T275082 ranges are *not* guaranteed to correspond to complete DOM subtrees (although maybe they should?), although they should still correspond to a contiguous set of nodes in an in-order traversal. So they can be represented as an about ID which is applied to a number of nodes, but adding a temporary <parsoid-wrapper> element to the internal DOM tree is probably not (quite) sufficient.

Mon, Feb 22, 6:05 PM · Parsoid-Rendering, Parsoid

Sat, Feb 20

cscott committed rERICa8eb917d3de4: Replace use of Parser::$mStripState, deprecated in 1.35 (authored by cscott).
Replace use of Parser::$mStripState, deprecated in 1.35
Sat, Feb 20, 2:20 AM
cscott committed rEPIC9ad4178319e6: Replace use of Parser::$mStripState, deprecated in 1.35 (authored by cscott).
Replace use of Parser::$mStripState, deprecated in 1.35
Sat, Feb 20, 12:57 AM

Fri, Feb 19

cscott committed rEMFUd3c29efa7f93: Replace use of Parser::$mOutput, deprecated in 1.35 (authored by cscott).
Replace use of Parser::$mOutput, deprecated in 1.35
Fri, Feb 19, 6:07 PM
cscott committed rETMC19aef1526d35: Replace use of Parser::$mOutput, deprecated in 1.35 (authored by cscott).
Replace use of Parser::$mOutput, deprecated in 1.35
Fri, Feb 19, 3:55 PM
cscott committed rEDPT7ebdcfe73e9e: Replace use of Parser::$mOutput, deprecated in 1.35 (authored by cscott).
Replace use of Parser::$mOutput, deprecated in 1.35
Fri, Feb 19, 3:18 PM

Thu, Feb 18

cscott created T275173: Extension:StringFunctionsEscaped should depend on ParserFunctions in CI.
Thu, Feb 18, 11:27 PM · Continuous-Integration-Config, Patch-For-Review, MediaWiki-extensions-StringFunctionsEscaped
cscott committed rEURE6d02a8036a3c: Replace use of Parser::$mTagHooks, deprecated in 1.35 (authored by cscott).
Replace use of Parser::$mTagHooks, deprecated in 1.35
Thu, Feb 18, 11:21 PM
cscott renamed T275160: Make public properties of Parser private from Make private instance properties of Parser to Make public properties of Parser private.
Thu, Feb 18, 8:50 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, MediaWiki-Parser
cscott added a subtask for T236812: Parser.php should be split into a base class and a parser implementation: T275160: Make public properties of Parser private.
Thu, Feb 18, 8:48 PM · Parsoid (Tracking), MediaWiki-Parser
cscott added a parent task for T275160: Make public properties of Parser private: T236812: Parser.php should be split into a base class and a parser implementation.
Thu, Feb 18, 8:48 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, MediaWiki-Parser
cscott created T275160: Make public properties of Parser private.
Thu, Feb 18, 8:48 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, MediaWiki-Parser

Tue, Feb 16

cscott committed rMLID2a47df7c9eaa: Fix phpunit.xml.dist `<coverage>` configuration (authored by cscott).
Fix phpunit.xml.dist `<coverage>` configuration
Tue, Feb 16, 6:41 PM
cscott committed rMLID44b3c6fdfcba: Rename Doxygen tag file to be consistent w/ the name used by Translate (authored by cscott).
Rename Doxygen tag file to be consistent w/ the name used by Translate
Tue, Feb 16, 6:41 PM

Sat, Feb 13

cscott committed rMLZE2ae58a1465c2: Strip strict type checks that assume use of PHP `xml` extension classes (authored by cscott).
Strip strict type checks that assume use of PHP `xml` extension classes
Sat, Feb 13, 5:31 AM
cscott committed rMLDO5cb9b3a67f2e: Use IDLeDOM prototypes for DOM APIs (authored by cscott).
Use IDLeDOM prototypes for DOM APIs
Sat, Feb 13, 5:25 AM
cscott committed rMLDOf0d7d3b92042: All Dodo classes now implement appropriate IDLeDOM prototypes (authored by cscott).
All Dodo classes now implement appropriate IDLeDOM prototypes
Sat, Feb 13, 5:25 AM

Wed, Feb 10

cscott committed rWLWI6500d44b79e6: Bump CHANGELOG after release (authored by cscott).
Bump CHANGELOG after release
Wed, Feb 10, 10:47 AM
cscott committed rWLWIa6c8d11b166d: Release 1.0.2 (authored by cscott).
Release 1.0.2
Wed, Feb 10, 10:47 AM

Mon, Feb 8

cscott added a comment to T274133: [[w:ru:Янская стоянка]] is not translatable via CX.

I think the proper resolution of this task was outlined by @Nikerabbit:

Mon, Feb 8, 5:53 PM · Maps (Kartographer), Product-Infrastructure-Team-Backlog, ContentTranslation
cscott committed rMLDO2d764fa42eb5: Start cleaning up Document.php (authored by DannyS712).
Start cleaning up Document.php
Mon, Feb 8, 4:10 PM

Wed, Feb 3

cscott added a comment to T259685: Zeroconf VisualEditor/Parsoid doesn't work on SQLite .

Ok, the pair of patches (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/622663 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/661213) actually fix the problem, according to @DLynch's testing. Sorry it took a while to get that right.

Wed, Feb 3, 9:04 PM · Editing-team (Third-party), User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Parsoid (Third-party), MW-1.35-notes, Platform Team Workboards (External Code Reviews), Patch-For-Review, VisualEditor, MW-1.35-release, SQLite

Mon, Feb 1

cscott added a comment to T269262: Integrate the DOM library with RemexHtml.

Basically there's one "builder" class in remex html; dodo could implement that to quickly get a tree builder. Alternatively, we could remove some explicit type casts (as I did for zest) to get a "universal" remex that would work with any some library as long as it was given an appropriate duck typed "DOMImplementation" class.

Mon, Feb 1, 8:18 PM · Parsoid (Dodo)

Fri, Jan 29

cscott committed rMLZE00c137247060: Bump CHANGELOG after release (authored by cscott).
Bump CHANGELOG after release
Fri, Jan 29, 4:12 PM
cscott committed rMLZEf4ea2901621b: Release zest-css 1.1.4 (authored by cscott).
Release zest-css 1.1.4
Fri, Jan 29, 4:12 PM
cscott committed rMLZE866a59f820ab: Add CHANGELOG (authored by cscott).
Add CHANGELOG
Fri, Jan 29, 4:12 PM
cscott created T273295: Set up CI for new PHP libraries: zest-css, dodo, webidl.
Fri, Jan 29, 3:31 PM · Continuous-Integration-Config, Parsoid

Jan 28 2021

cscott committed rWLWI888866e6e775: Fix up & trim down dependencies in composer.json (authored by cscott).
Fix up & trim down dependencies in composer.json
Jan 28 2021, 10:40 PM
cscott committed rWLWI9574f500fd96: Bump CHANGELOG after release (authored by cscott).
Bump CHANGELOG after release
Jan 28 2021, 10:30 PM
cscott added a comment to T69486: Links: Add support for self-links to Parsoid.

Self-links are (I expect) pretty rare, so they the fact that they could split a possible fragment cache based on 'current document title' isn't much of a concern right now.

I think most inclusions of navboxes contain a self-link. Not sure this is enough for for being a concern, but I wouldn’t classify it as “pretty rare”.

Jan 28 2021, 4:02 PM · Parsoid-Rendering, Growth-Team, Collaboration-Team-Triage, StructuredDiscussions, Parsoid

Jan 26 2021

cscott added a parent task for T269630: Parsoid should support section editing links: T272987: Parsoid read views for DiscussionTools.
Jan 26 2021, 4:01 PM · Parsoid
cscott added a subtask for T272987: Parsoid read views for DiscussionTools: T269630: Parsoid should support section editing links.
Jan 26 2021, 4:01 PM · DiscussionTools, Parsoid
cscott added a subtask for T272987: Parsoid read views for DiscussionTools: T270199: Table of contents in Parsoid output.
Jan 26 2021, 4:01 PM · DiscussionTools, Parsoid
cscott added a parent task for T270199: Table of contents in Parsoid output: T272987: Parsoid read views for DiscussionTools.
Jan 26 2021, 4:01 PM · Parsoid-Rendering, Parsoid
cscott added a comment to T92999: Better handle `__TOC__` in parser tests.

Given the intent to implement TOC in Parsoid (T270199), probably the correct thing to do is add a 'toc' flag to the !!options to opt-in to the toc post-processing step (when that gets implemented).

Jan 26 2021, 4:01 PM · Parsoid
cscott added a subtask for T270199: Table of contents in Parsoid output: T92999: Better handle `__TOC__` in parser tests.
Jan 26 2021, 4:00 PM · Parsoid-Rendering, Parsoid
cscott added a parent task for T92999: Better handle `__TOC__` in parser tests: T270199: Table of contents in Parsoid output.
Jan 26 2021, 4:00 PM · Parsoid
cscott created T272987: Parsoid read views for DiscussionTools.
Jan 26 2021, 3:59 PM · DiscussionTools, Parsoid

Jan 25 2021

cscott added a subtask for T247804: Move Sanitizer from core into Parsoid: T204279: Fine-grained Sanitizer control.
Jan 25 2021, 2:21 PM · MediaWiki-Parser, Parsoid
cscott added a parent task for T204279: Fine-grained Sanitizer control: T247804: Move Sanitizer from core into Parsoid.
Jan 25 2021, 2:21 PM · Security, Parsoid
cscott added a comment to T247804: Move Sanitizer from core into Parsoid.

Another option is to break out the Sanitizer as a library; if it was a parallel PHP/JS library (like wikipeg) then we could perhaps solve some of the Sanitizer-multiplication issues described in T248211: One Sanitizer to Rule Them All and reuse this library in more places.

Jan 25 2021, 2:19 PM · MediaWiki-Parser, Parsoid

Jan 23 2021

cscott updated the task description for T261161: Parsoid Config/* interfaces should perhaps be abstract classes.
Jan 23 2021, 9:57 PM · Parsoid

Jan 20 2021

cscott added a comment to T9356: User-specified HTML IDs can be the same as interface IDs.

@Krinkle I'm not sure why you think the solution is to prefix IDs in *user* content, rather than to reserve a prefix for *system* content. After all, (a) links to IDs in user content are already all over the web and in archives, it's somewhat rude to change them even if we provide compatibility anchors for a short time (and if we keep them forever, we haven't actually solved the problem), and (b) URLs to wiki content are intended to be "human readable", which suggests that "machine" content like "mw-" should be omitted if possible -- adding a prefix to user IDs also doesn't play nicely with our i18n (consider RTL anchors).

Jan 20 2021, 8:29 PM · MediaWiki-Parser
cscott added a comment to T268456: Value stored and value displayed are different for large numbers.

I'll look at the code, the idea seems reasonable. We could also file a bug upstream to see if PHP will add a bignum or string interface. Could also check libicu to see what types they are supporting (maybe the fault is just in the PHP wrapper).

Jan 20 2021, 1:26 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Jan 19 2021

cscott closed T10327: Language::formatNum() should prefix negative values with − (minus sign U+2212) as Resolved.
Jan 19 2021, 6:42 PM · MediaWiki-Internationalization, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), User-notice, MediaWiki-Interface
cscott closed T10327: Language::formatNum() should prefix negative values with − (minus sign U+2212), a subtask of T40579: Size of changes - minus-sign instead of hyphen, as Resolved.
Jan 19 2021, 6:42 PM · MediaWiki-Page-history
cscott added a comment to T270373: Wikisource Export: Underscores show instead of spaces in some titles.

What's the wikitext source? For [[Chapter 30]] Parsoid should definitely be outputting <a rel="mw:WikiLink" href="./Book_of_Jasher" title="Book of Jasher">Book of Jasher</a> and be totally compatible with the core parser output:

$ echo "[[Chapter 30]]" | php bin/parse.php  --normalize
Jan 19 2021, 5:54 PM · Community-Tech, Parsoid, WS Export
cscott added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

WRT captions appearing in the error case:
The {MediaWiki DOM Spec](https://www.mediawiki.org/wiki/Specs/HTML/2.2.0#Images) says:

<figcaption (absent when inline)>...</figcaption>

and

The outer <figure> element needs to become a <span> element when the figure is rendered inline, since otherwise the HTML5 parser will interrupt a surrounding block context. The inner <figcaption> element is rendered as a data-mw attribute in this case (since block content in an invisible caption would otherwise break parsing).

Jan 19 2021, 5:36 PM · Parsing-Active-Work, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Parsoid, MediaWiki-Parser
cscott merged T27476: Add and use parser function for signature timestamps (four/five tildes) to show them to the user in preferred locale and timezone into T230653: Use a parser function to encapsulate signatures.
Jan 19 2021, 4:27 PM · DiscussionTools, Patch-For-Review, OWC2020, MediaWiki-Parser
cscott merged task T27476: Add and use parser function for signature timestamps (four/five tildes) to show them to the user in preferred locale and timezone into T230653: Use a parser function to encapsulate signatures.
Jan 19 2021, 4:27 PM · I18n, MediaWiki-Internationalization
cscott added a comment to T27476: Add and use parser function for signature timestamps (four/five tildes) to show them to the user in preferred locale and timezone.

Great minds think alike: T230653: Use a parser function to encapsulate signatures

Jan 19 2021, 4:27 PM · I18n, MediaWiki-Internationalization
cscott added a comment to T272322: Check for line breaks in user signatures.

T230653: Use a parser function to encapsulate signatures would mitigate this long-term.

Jan 19 2021, 4:25 PM · Parsoid (Tracking), Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools, MediaWiki-User-preferences

Jan 14 2021

cscott added a comment to T9356: User-specified HTML IDs can be the same as interface IDs.

I think it's high time that the Parser/Linker maintain a list of interface-reserved prefixes (like n-, p-, and mw-), as well as a (short) list of legacy IDs (such as footer), that are automatically mapped to a different name to avoid clashes with interace styles.

For example, by prepending it with h- for heading, or something like that. For compatibility this would of course be limited only to where it is causing potential conflicts. Doing this for the other 99.9% of headings is out of scope for this task.

Jan 14 2021, 3:15 PM · MediaWiki-Parser

Jan 12 2021

cscott created T271863: Quibble runs core *integration* tests against Parsoid-as-an-extension, not *unit* tests.
Jan 12 2021, 9:16 PM · Patch-For-Review, Quibble, Parsoid
cscott committed rEDISf9e5a56bf8d4: Move Parsoid disambiguator parser tests to Extension:Disambiguator (authored by cscott).
Move Parsoid disambiguator parser tests to Extension:Disambiguator
Jan 12 2021, 8:31 PM

Jan 11 2021

cscott updated the task description for T271724: Document WebIDL binding for PHP.
Jan 11 2021, 5:58 PM · Parsoid (Dodo)
cscott renamed T271724: Document WebIDL binding for PHP from Write WebIDL binding for PHP to Document WebIDL binding for PHP.
Jan 11 2021, 5:56 PM · Parsoid (Dodo)
cscott updated the task description for T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).
Jan 11 2021, 5:06 PM · Parsing-Active-Work, Parsoid (Dodo)
cscott added a subtask for T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library): T271730: Fix enough bugs in Dodo that Parsoid's parser tests run cleanly.
Jan 11 2021, 5:04 PM · Parsing-Active-Work, Parsoid (Dodo)
cscott added a parent task for T271730: Fix enough bugs in Dodo that Parsoid's parser tests run cleanly: T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).
Jan 11 2021, 5:04 PM · Parsoid (Dodo)
cscott created T271730: Fix enough bugs in Dodo that Parsoid's parser tests run cleanly.
Jan 11 2021, 5:04 PM · Parsoid (Dodo)
cscott updated the task description for T269270: Code generation of HTML*Element DOM classes.
Jan 11 2021, 5:02 PM · Parsoid (Dodo)
cscott updated the task description for T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).
Jan 11 2021, 4:53 PM · Parsing-Active-Work, Parsoid (Dodo)
cscott updated the task description for T269707: Integrate the DOM library with Zest.
Jan 11 2021, 4:49 PM · Parsoid (Dodo)
cscott updated the task description for T269259: Set up test infrastructure for testing the library against standard spec test suites.
Jan 11 2021, 4:44 PM · Patch-For-Review, Parsoid (Dodo)
cscott updated the task description for T269262: Integrate the DOM library with RemexHtml.
Jan 11 2021, 4:41 PM · Parsoid (Dodo)
cscott updated the task description for T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).
Jan 11 2021, 4:38 PM · Parsing-Active-Work, Parsoid (Dodo)
cscott updated the task description for T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).
Jan 11 2021, 4:37 PM · Parsing-Active-Work, Parsoid (Dodo)
cscott added a subtask for T217867: Port domino (or another spec-compliant DOM library) to PHP: T271728: Migration strategy from DOMDocument to Dodo.
Jan 11 2021, 4:33 PM · Parsoid
cscott added a parent task for T271728: Migration strategy from DOMDocument to Dodo: T217867: Port domino (or another spec-compliant DOM library) to PHP.
Jan 11 2021, 4:33 PM · Parsoid (Dodo)
cscott created T271728: Migration strategy from DOMDocument to Dodo.
Jan 11 2021, 4:33 PM · Parsoid (Dodo)
cscott updated the task description for T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).
Jan 11 2021, 4:22 PM · Parsing-Active-Work, Parsoid (Dodo)
cscott added a subtask for T269259: Set up test infrastructure for testing the library against standard spec test suites: T271724: Document WebIDL binding for PHP.
Jan 11 2021, 4:19 PM · Patch-For-Review, Parsoid (Dodo)
cscott added a parent task for T271724: Document WebIDL binding for PHP: T269259: Set up test infrastructure for testing the library against standard spec test suites.
Jan 11 2021, 4:19 PM · Parsoid (Dodo)
cscott updated the task description for T269259: Set up test infrastructure for testing the library against standard spec test suites.
Jan 11 2021, 4:19 PM · Patch-For-Review, Parsoid (Dodo)
cscott added a subtask for T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library): T271724: Document WebIDL binding for PHP.
Jan 11 2021, 4:18 PM · Parsing-Active-Work, Parsoid (Dodo)
cscott added a parent task for T271724: Document WebIDL binding for PHP: T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).
Jan 11 2021, 4:18 PM · Parsoid (Dodo)
cscott created T271724: Document WebIDL binding for PHP.
Jan 11 2021, 4:17 PM · Parsoid (Dodo)
cscott added a comment to T269271: Settle on a suitable name for the DOM library.

\Wikimedia\DoDo maybe? Makes "DOm DOcument" clearer? OTOH, maybe reads as the repeated imperative "do do" instead of the bird.

Jan 11 2021, 4:16 PM · Parsoid
cscott updated the task description for T269259: Set up test infrastructure for testing the library against standard spec test suites.
Jan 11 2021, 3:55 PM · Patch-For-Review, Parsoid (Dodo)
cscott updated the task description for T269259: Set up test infrastructure for testing the library against standard spec test suites.
Jan 11 2021, 3:51 PM · Patch-For-Review, Parsoid (Dodo)
cscott updated the task description for T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).
Jan 11 2021, 3:28 PM · Parsing-Active-Work, Parsoid (Dodo)

Jan 10 2021

cscott added a comment to T263082: add <langconvert> parser tag.

Can we open a new phab task for this? I apologize for not noticing/flagging this earlier. There are a number of tasks already in phab to deprecate and remove the old mediawiki codes (including sr-ec, sr-el, etc) and it would be a significant step backwards to have the old names written into article wikitext, which would require manually updating all that wikitext in the future.

Jan 10 2021, 3:21 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-notice, Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review

Jan 8 2021

cscott created T271562: Remove special parsoidsvc-parsertests-docker job.
Jan 8 2021, 5:13 PM · Patch-For-Review, Continuous-Integration-Config, Parsoid
cscott claimed T69486: Links: Add support for self-links to Parsoid.

Not necessarily going to work on this immediately (I've got higher-priority parser tests tasks) but since I added the GetLinkColors hook to core/Parsoid I'll provisionally claim this task.

Jan 8 2021, 4:17 PM · Parsoid-Rendering, Growth-Team, Collaboration-Team-Triage, StructuredDiscussions, Parsoid
cscott added a comment to T69486: Links: Add support for self-links to Parsoid.

@GWicke's idea about putting the "document identity" in the CSS is interesting, so that a link could be styled as a self-link (or not) depending on the CSS that is applied to it.

Jan 8 2021, 3:43 PM · Parsoid-Rendering, Growth-Team, Collaboration-Team-Triage, StructuredDiscussions, Parsoid

Jan 6 2021

cscott added a comment to T265033: MediaWikiIntegrationTestCase does not clear tablesUsed before first test.

I think addDBDataOnce is more fundamentally broken, and shouldn't be used.

Jan 6 2021, 9:02 PM · MediaWiki-Core-Testing
cscott added a comment to T271287: Parsoid CI broken by Rest\Handler\LanguageLinksHandlerTest.

Related Q: how can we make code CI run your test suite so that it doesn't just break Parsoid CI? Core CI *does* run some tests in a mode where Parsoid is installed -- can we add your tests to that group?

Jan 6 2021, 6:33 PM · Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Patch-For-Review, Parsoid
cscott added a comment to T271287: Parsoid CI broken by Rest\Handler\LanguageLinksHandlerTest.

Yes, the Parser test runner setup creates its own interwiki table (using wgInterwikiCache) so that test results are not dependent on the host wiki configuration.

Jan 6 2021, 6:32 PM · Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Patch-For-Review, Parsoid

Dec 23 2020

cscott created T270777: Wikibase Client won't let ParserTests delete articles during cleanup.
Dec 23 2020, 4:44 PM · Parsoid (Tracking), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Patch-For-Review, Wikidata, MediaWiki-extensions-WikibaseClient

Dec 22 2020

cscott added a comment to T270444: Parsoid needs a bidirectional interwiki map (and hooks).

The local/global/site interwiki tables are implemented in the CDB caching, that's not expected to change.

Dec 22 2020, 9:34 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, MediaWiki-Interwiki, MediaWiki-Site-system, SiteMatrix, MediaWiki-extensions-InterwikiExtracts, Parsoid
cscott added a comment to T47096: Add a way to transclude template or other page in the correct language.

Some comments left on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/617294 -- see if you can determine if the $deps array is correct or not.

Dec 22 2020, 8:20 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Parsoid (Tracking), Language-Team (Language-2021-January-March), Platform Team Workboards (External Code Reviews), Patch-For-Review, MediaWiki-extensions-Translate

Dec 21 2020

cscott added a comment to T266140: HTML entity replaced by the Unicode character in an edit.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/649755 is my recommended fix here. It's been waiting for review for a while.

Dec 21 2020, 9:55 PM · Editing-team (FY2020-21 Kanban Board), MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Parsoid, DiscussionTools
cscott added a comment to T269750: PegTokenizer: UTF-8 errors.

Yeah, this is a bug in the lua code. I've attempted to contact the author: https://fr.wikipedia.org/w/index.php?title=Discussion_module%3ACoordinates&type=revision&diff=177884216&oldid=173976505

Dec 21 2020, 3:40 PM · Parsoid, Wikimedia-production-error
cscott added a comment to T269750: PegTokenizer: UTF-8 errors.

I strongly suspect that someone is converting "-71.3" degrees to "71.3 S" by chopping off the first *byte*, instead of the first *character*.

Dec 21 2020, 3:25 PM · Parsoid, Wikimedia-production-error
cscott added a comment to T269750: PegTokenizer: UTF-8 errors.

The unicode minus sign is from formatnum -- it shouldn't be getting chopped up into bad UTF-8, unless someone somewhere it doing a naive substr(1, ...) or something like that. I'll look.

Dec 21 2020, 2:57 PM · Parsoid, Wikimedia-production-error