Page MenuHomePhabricator
Feed Advanced Search

Yesterday

cscott added a comment to T287184: Introduce ParseContext class.

Global configuration information. The obvious thing here is the callbacks which control how page titles are mapped to revisions, which is certainly useful, but doesn't belong in parser options.

These callbacks are actually changed by some extensions. Perhaps we could split these out and provide non-default to the parser via ParserFactory. That approach will only work well if we actually parse right where we set these callbacks. I'll have a look at it, I have an idea.

Fri, Jul 23, 4:46 PM · Parsoid, Platform Team Workboards (MW Expedition)
cscott added a comment to T287184: Introduce ParseContext class.

However, one difference with ParserOptions is the dependencies. ParserOptions depend on user and optionally Language, so you can construct one pretty easily, and we have A LOT of code constructing ParserOptions directly. But this is something we need to address anyway - ParserOptions rely on global state heavily and need to have a factory anyway, so we will touch all this code.

Fri, Jul 23, 3:26 PM · Parsoid, Platform Team Workboards (MW Expedition)
cscott committed rMLDO5b029859f0cd: Ensure that Document::documentElement can match FilteredElementList (authored by cscott).
Ensure that Document::documentElement can match FilteredElementList
Fri, Jul 23, 2:57 PM
cscott committed rMLDO9deb8be837f7: Implement Node::getNodePath() for PHP compatibility (authored by cscott).
Implement Node::getNodePath() for PHP compatibility
Fri, Jul 23, 2:57 PM
cscott added a comment to T287184: Introduce ParseContext class.

FWIW, one reason why Parsoid doesn't use most of the stuff in ParserOptions currently is because we made a design decision *not to implement* any user-varying parser features. There's no per-user thumbnail size, stub size, etc, configuration in Parsoid. Our top-level design is that any such user customization will be done as a post-processing step.

Fri, Jul 23, 2:56 PM · Parsoid, Platform Team Workboards (MW Expedition)
cscott updated the task description for T151958: Annotations at Wikidev'17.
Fri, Jul 23, 2:27 PM · Wikimedia-Developer-Summit (2017)
cscott added a comment to T151952: Media, Visualizations, and Layout at Wikidev'17.

Uploaded the slides to commons at https://commons.wikimedia.org/wiki/File:Wikimedia_Developer_Summit_2017_-_Media,_Visualizations,_and_Layout.pdf

Fri, Jul 23, 2:18 PM · MediaWiki-File-management, Commons-Datasets, Wikimedia-Video, Multimedia, Commons, Wikimedia-Developer-Summit (2017)
Sj awarded T113004: Make it easy to fork, branch, and merge pages (or more) a Pterodactyl token.
Fri, Jul 23, 3:30 AM · MediaWiki-General, Community-Wishlist-Survey-2015, Contributors-Team, Wikimedia-Developer-Summit-2016

Thu, Jul 22

cscott added a comment to T287184: Introduce ParseContext class.

Three main issues from Parsoid's perspective:

  • In order to avoid circular dependencies, an interface (not necessarily TransformContext but something TransformContext implements or extends) needs to be defined in the parsoid library repository, not in core.
  • Again, due to circular dependencies, that parsoid interface can't directly reference Title/Revision/User objects. Instead Title is passed through as a string, eg. The core TransformContext can have a getTitle() method for mediawiki users, but Parsoid can't use that.
  • Extensions and parser functions currently use ParserOptions as a pass-through for information not actually needed by the parser, but which are needed to implement an extension tag or parser function. timestamp, speculative page id, etc etc. The TransformContext must provide a way to pipe that information through the parser and into the parser function/extension, without Parsoid necessarily knowing about it.
Thu, Jul 22, 11:07 PM · Parsoid, Platform Team Workboards (MW Expedition)
cscott created T287220: Pull out ParsoidOptions from ParserOptions.
Thu, Jul 22, 10:47 PM · Parsoid
ssastry awarded T287216: ParserOutput should implement ParsoidOutput a Yellow Medal token.
Thu, Jul 22, 10:21 PM · Parsoid
cscott added a comment to T287216: ParserOutput should implement ParsoidOutput.

I did add the bikeshed warning at the top. :) I can edit the task summary with the new name as soon as we have one.

Thu, Jul 22, 10:18 PM · Parsoid
cscott added a comment to T287216: ParserOutput should implement ParsoidOutput.

Some additional nodes:

  • ParserOutput::getText() is the most ugly thing here, it doesn't really belong. It probably won't be added to ParsoidOutput. Right now ParsoidOutput is an "out" parameter to the parsing process that gets updated and stands alongside the actual DOM output of the parse. It may be worth adding a setter to ParsoidOutput to record the final output *as a DOM*, something like ParsoidOutput::setParseDocument(DOMDocument $doc). The mediawiki integration code would be responsible for taking the DOM and converting it to a string in a way which is compatible with ParserOutput::getText() and friends; hopefully Parsoid will remain naively ignorant of those details.
  • Some of the setters are used by extensions or parser functions but not by the core parser. These shouldn't be added to ParsoidOutput. An extension or parser function which needs to record those details will have access to a "real" ParserOutput, they won't need those methods to be available in ParsoidOutput. Things like ParserOutput::addTrackingCategory() are an example of something which is on the bubble here. It would probably be added to ParsoidOutput because it happens to be useful to record delinting information during the parse, even though most uses of addTrackingCategory are probably in extension code.
Thu, Jul 22, 10:16 PM · Parsoid
cscott updated the task description for T287216: ParserOutput should implement ParsoidOutput.
Thu, Jul 22, 10:09 PM · Parsoid
cscott updated the task description for T287216: ParserOutput should implement ParsoidOutput.
Thu, Jul 22, 10:09 PM · Parsoid
cscott created T287216: ParserOutput should implement ParsoidOutput.
Thu, Jul 22, 10:08 PM · Parsoid
cscott added a comment to T236809: Refactor Parser.php to allow alternate parser (Parsoid).

Redirecting this task to the actual title (refactoring Parser.php): I realized over the past few days that some of the linked dependencies relating to deprecating the "clone" and "resetOutput" functions of Parser.php don't actually block the insertion of a new abstract base class in the hierarchy. The fundamental blocker was code which did "new Parser" because that would break if the Parser class became abstract. But that's been deprecated and removed for some years now. Code which clones an existing Parser will still work if you're holding on to a LegacyParser object, so is not blocking our next refactor step.

Thu, Jul 22, 9:48 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MediaWiki-extensions-Variables, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsing-Active-Work, Patch-For-Review, Parsoid, MediaWiki-Parser
cscott added a comment to T286569: Reserve ``` ``` syntax to indicate 'code' blocks in wikitext markup...

Copying some discussion from slack.

Thu, Jul 22, 8:36 PM · Parsoid, MediaWiki-Parser
cscott committed rMLZEe50f0e58d387: Implement basic namespace selector (authored by cscott).
Implement basic namespace selector
Thu, Jul 22, 4:15 PM
cscott committed rMLZE9dfb9505e25f: Expand "scoping root" to include DOMDocumentFragment (authored by cscott).
Expand "scoping root" to include DOMDocumentFragment
Thu, Jul 22, 4:15 PM
cscott committed rMLZEd628a6db8a3e: Bug fix: ~= operator now accepts non-space CSS whitespace as separators (authored by cscott).
Bug fix: ~= operator now accepts non-space CSS whitespace as separators
Thu, Jul 22, 4:15 PM
cscott committed rMLZEbfdd2d247f23: Add `getElementsById` option to support multiple elements with the same ID (authored by cscott).
Add `getElementsById` option to support multiple elements with the same ID
Thu, Jul 22, 4:15 PM
cscott committed rMLZE7a3a84cd9a8d: Implement 'standardsMode' as well as the `:scope` selector (authored by cscott).
Implement 'standardsMode' as well as the `:scope` selector
Thu, Jul 22, 4:15 PM
cscott committed rMLZEab497f73c936: Speed up uniqueness test for matched elements (authored by cscott).
Speed up uniqueness test for matched elements
Thu, Jul 22, 4:15 PM
cscott committed rMLZE07886304f076: Correct assertion argument order in test cases (authored by cscott).
Correct assertion argument order in test cases
Thu, Jul 22, 4:15 PM
cscott committed rMLZEc9e531245810: Remove some unnecessarly strict type hints (authored by cscott).
Remove some unnecessarly strict type hints
Thu, Jul 22, 4:15 PM
cscott committed rMLZE9a13174f4bdb: Sort results in document order when possible (authored by cscott).
Sort results in document order when possible
Thu, Jul 22, 4:15 PM
cscott committed rMLZE1a9981e4c294: Add CHANGELOG entry for dependency updates in previous commits (authored by cscott).
Add CHANGELOG entry for dependency updates in previous commits
Thu, Jul 22, 4:15 PM

Wed, Jul 21

cscott added a comment to T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access.

Brief to-do, to summarize:

  1. Revert the original parsoid-related patch in quibble ( https://gerrit.wikimedia.org/r/c/integration/quibble/+/705907 ) tag and release quibble 0.10.1 and rebuild images (alas)
  2. Add parsoid as a dependency of Flow ( https://gerrit.wikimedia.org/r/c/integration/config/+/705932 ). This may temporarily break Flow CI, but shouldn't break anyone else using extension-gate tests, since the gatedextension list ignores dependencies and so Parsoid will still be disabled for extension-gate builds. Flow devs can fix their tests if needed, and/or write the new API tests envisioned by T218534. They should probably take care that their tests will pass whether or not Parsoid is enabled, though, at least for an interim period. (ie, cleanly skip tests that require parsoid if the parsoid extension is not installed).
  3. Add the extension-gate tasks experimentally to Parsoid ( https://gerrit.wikimedia.org/r/c/integration/config/+/705966 ). This will allow Parsoid and Flow devs to look into these issues by running check experimental on empty commits in the parsoid repo.
  4. Someday: add Parsoid to the gated extension list ( https://gerrit.wikimedia.org/r/c/integration/config/+/655695 ) after Flow (and any other extensions) issues are fixed.
Wed, Jul 21, 5:21 PM · Patch-For-Review, Release-Engineering-Team, User-DannyS712, Growth-Team, ci-test-error (WMF-deployed Build Failure), StructuredDiscussions
cscott updated subscribers of T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access.

@Zabe @Urbanecm Thanks. Examination shows that's still the same set of Flow tests failing. So hopefully if the flow tests are fixed then those failures won't block https://gerrit.wikimedia.org/r/c/integration/config/+/655695.

Wed, Jul 21, 4:55 PM · Patch-For-Review, Release-Engineering-Team, User-DannyS712, Growth-Team, ci-test-error (WMF-deployed Build Failure), StructuredDiscussions
cscott added a comment to T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access.

I *believe* that the failure mode here is (a) the final integrated test on many repos runs core tests with a set of 'important for production' extensions that includes Flow, (b) Flow/includes/Conversion/Utils.php contains an isParsoidConfigured() method, and the tests in question used Utils::convert() which uses the legacy parser if isParsoidConfigured() returns false, and (c) the quibble patch set $wgVirtualRestConfig['modules']['parsoid'] = []; and isset( $vrs['modules']['parsoid'] ) is one of the tests used by Utils::makeVRSObject() to determine if Parsoid is configured. So isParsoidConfigured() started to return true which caused Utils::convert() to run down a different code path which triggered various failures.

Wed, Jul 21, 4:52 PM · Patch-For-Review, Release-Engineering-Team, User-DannyS712, Growth-Team, ci-test-error (WMF-deployed Build Failure), StructuredDiscussions
cscott added a comment to T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access.

Can we save the logs for one of the failed builds in GrowthExperiments as well? I assume that Flow's CI tests are the root cause here. The quibble patch effectively turned on Parsoid in all repositories at once, in addition to configuring Parsoid in a non-standard way. So if other extensions failed when Parsoid was turned on that would be interesting to the parsing team to look into, even though it shouldn't be a near term blocker.

Wed, Jul 21, 4:01 PM · Patch-For-Review, Release-Engineering-Team, User-DannyS712, Growth-Team, ci-test-error (WMF-deployed Build Failure), StructuredDiscussions
cscott added a comment to T151720: Update extension node renderings without building XML/wikitext in the client.

This is also how template editing ought to work: you provide the arguments in data-mw corresponding to https://www.mediawiki.org/wiki/Specs/HTML/1.2.1#Transclusion_content with "html" properties instead of "wt", and we'll html->wt->html it and provide you with an appropriate rendered representation of the template, as a DOM fragment (with potentially multiple nodes). I take it right now you are generating wikitext for the template instance and using the wt2html API to generate the preview rendering?

Wed, Jul 21, 2:20 PM · Parsoid-Web-API, Parsoid, VisualEditor-MediaWiki, VisualEditor
cscott added a comment to T151720: Update extension node renderings without building XML/wikitext in the client.

Some more discussion in T114412 (which was closed as a duplicate).

Wed, Jul 21, 2:16 PM · Parsoid-Web-API, Parsoid, VisualEditor-MediaWiki, VisualEditor
cscott added a comment to T218534: Run Parsoid service in quibble.

Running the Parsoid service in quibble was already done; we use it to run api tests in CI. You just need to make Flow depend on the Parsoid extension.

Wed, Jul 21, 2:03 PM · User-zeljkofilipin, Patch-For-Review, Quibble
cscott updated subscribers of T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access.

I marked the line in https://gerrit.wikimedia.org/r/c/integration/quibble/+/703182 which I suspect to be the culprit, but fundamentally I don't think that patch should have been necessary in the first place. Parsoid already runs "as a service" when we do API testing with the core API testing framework (poking @Arlolra who worked on this), so Flow ought to be able to do the same thing without messing with the quibble configuration.

Wed, Jul 21, 12:32 AM · Patch-For-Review, Release-Engineering-Team, User-DannyS712, Growth-Team, ci-test-error (WMF-deployed Build Failure), StructuredDiscussions

Mon, Jul 19

cscott committed rMLDO4189d5137649: Improve error handling when an empty string is given to DOMParser (authored by cscott).
Improve error handling when an empty string is given to DOMParser
Mon, Jul 19, 6:05 PM
cscott committed rMLDO97807bcaee1a: EXPERIMENTAL: add Node::getExtensionData() and Node::setExtensionData() (authored by cscott).
EXPERIMENTAL: add Node::getExtensionData() and Node::setExtensionData()
Mon, Jul 19, 6:05 PM
cscott committed rMLDOf31982edd424: Update to IDLeDOM 0.7.1 (authored by cscott).
Update to IDLeDOM 0.7.1
Mon, Jul 19, 6:05 PM
cscott committed rMLDOe35a6d4e2419: Minor code style cleanup (authored by cscott).
Minor code style cleanup
Mon, Jul 19, 6:05 PM
cscott committed rMLDO2916089b981a: Implement DocumentFragment::querySelector() and ::querySelectorAll() (authored by cscott).
Implement DocumentFragment::querySelector() and ::querySelectorAll()
Mon, Jul 19, 6:05 PM
cscott committed rMLDO251f2a02c10a: WPT tests: improve translation of JavaScript foreach constructs (authored by cscott).
WPT tests: improve translation of JavaScript foreach constructs
Mon, Jul 19, 6:05 PM
cscott committed rMLDO6c44d0251c2d: Speed up Element->getNodeName() for HTML elements (authored by cscott).
Speed up Element->getNodeName() for HTML elements
Mon, Jul 19, 6:05 PM
cscott committed rMLDOc72c2ef95f39: DOMParser: Further doctype creation fixes, this time in text/html mode (authored by cscott).
DOMParser: Further doctype creation fixes, this time in text/html mode
Mon, Jul 19, 6:04 PM
cscott committed rMLDOba0a0fce27e4: Fix signficant whitespace handling in DOMParser (authored by cscott).
Fix signficant whitespace handling in DOMParser
Mon, Jul 19, 5:58 PM
cscott committed rMLDO6534b0cd7198: Switch to precise dependency on IDLeDOM (authored by cscott).
Switch to precise dependency on IDLeDOM
Mon, Jul 19, 5:58 PM
cscott committed rMLDOd0825183823e: Ensure that Document::documentElement is always populated (authored by cscott).
Ensure that Document::documentElement is always populated
Mon, Jul 19, 5:58 PM
cscott committed rMLDO6d3b8620bcac: Fix doctype creation in DOMParser implementation (authored by cscott).
Fix doctype creation in DOMParser implementation
Mon, Jul 19, 5:58 PM

Fri, Jul 16

cscott committed rMLIDb389d4b73363: Bump CHANGELOG after release (authored by cscott).
Bump CHANGELOG after release
Fri, Jul 16, 9:22 PM
cscott committed rMLIDe154354c56eb: Add some basic scripts to help automate release process (authored by cscott).
Add some basic scripts to help automate release process
Fri, Jul 16, 9:19 PM
cscott committed rMLID88a564535d6e: Release 0.7.1 (authored by cscott).
Release 0.7.1
Fri, Jul 16, 9:18 PM
cscott committed rMLIDb5b43c26c4cc: Add `_getMissingProp`/`_setMissingProp` extension points (authored by cscott).
Add `_getMissingProp`/`_setMissingProp` extension points
Fri, Jul 16, 8:54 PM

Tue, Jul 13

cscott added a comment to T196088: Get cleanupTitles.php into a good enough state that we could run it in production.

Another ping...

Tue, Jul 13, 4:07 PM · MediaWiki-Maintenance-system, User-Nikerabbit

Mon, Jul 12

cscott added a comment to T284023: DiscussionTools doesn't handle unclosed nowiki in previous section..

Briefly, the proposed solution from the Parsing side is that we should add a lint for "unclosed nowiki" (if there isn't already one, there may well be) and then have DiscussionTools check the lints for the given page before saving (or starting?) an edit and warn the user if there are "problematic" lints for the page.

Mon, Jul 12, 3:51 PM · MediaWiki-extensions-Linter, Parsoid, Editing-team, DiscussionTools

Sun, Jul 4

cscott committed rMLDOb509e2231892: Release 0.1.0 (authored by cscott).
Release 0.1.0
Sun, Jul 4, 9:07 PM
cscott committed rMLDO9c59dfc077cc: Minor fixes to formatting (authored by ssastry).
Minor fixes to formatting
Sun, Jul 4, 9:07 PM
cscott committed rMLDO418dd1526db8: Bump version after release (authored by cscott).
Bump version after release
Sun, Jul 4, 9:07 PM
cscott committed rMLDOb954cc06c9f7: Update to IDLeDOM 0.7.0 (authored by cscott).
Update to IDLeDOM 0.7.0
Sun, Jul 4, 9:06 PM
cscott committed rMLDO47073f4d22bd: Allow (and ignore) writes to the Element `style` attribute (authored by cscott).
Allow (and ignore) writes to the Element `style` attribute
Sun, Jul 4, 9:06 PM
cscott committed rMLIDb479487598b5: Release 0.7.0 (authored by cscott).
Release 0.7.0
Sun, Jul 4, 6:03 PM
cscott committed rMLID756ed2451c49: Bump CHANGELOG after release (authored by cscott).
Bump CHANGELOG after release
Sun, Jul 4, 6:03 PM

Sat, Jul 3

cscott committed rMLID23cfe09083c4: Support [PutForwards]; add Location interface (authored by cscott).
Support [PutForwards]; add Location interface
Sat, Jul 3, 7:06 PM
cscott committed rMLIDa4436c53d74d: Add CSS Object Model interfaces (authored by cscott).
Add CSS Object Model interfaces
Sat, Jul 3, 6:59 PM
cscott committed rMLDOcd46daf8669d: Bug fixes to Node::compareDocumentPosition() (authored by cscott).
Bug fixes to Node::compareDocumentPosition()
Sat, Jul 3, 6:55 PM
cscott committed rMLDO613857579175: Bug fixes for Range implementation (authored by cscott).
Bug fixes for Range implementation
Sat, Jul 3, 6:55 PM
cscott committed rMLID430661fab312: WebIDL.md: Describe encoding issues with DOMString, USVString (authored by cscott).
WebIDL.md: Describe encoding issues with DOMString, USVString
Sat, Jul 3, 6:55 PM
cscott committed rMLDO4852c2a5f5c2: Implement XML parser; fixes to XMLSerializer and CDATASection support (authored by cscott).
Implement XML parser; fixes to XMLSerializer and CDATASection support
Sat, Jul 3, 7:42 AM
cscott committed rMLDO3ba8a61d8281: Address XML serialization prefix issues unresolved in spec (authored by cscott).
Address XML serialization prefix issues unresolved in spec
Sat, Jul 3, 7:42 AM
cscott committed rMLDO5272a639b8f5: Add 'domparsing' tests from WPT (authored by cscott).
Add 'domparsing' tests from WPT
Sat, Jul 3, 7:41 AM
cscott committed rMLDO5c92720c1495: Clean up W3CTestHarness (authored by cscott).
Clean up W3CTestHarness
Sat, Jul 3, 7:20 AM
cscott committed rMLDO9940fc394460: Implement ::innerHTML getter, ::outerHTML getter, XMLSerializer (authored by cscott).
Implement ::innerHTML getter, ::outerHTML getter, XMLSerializer
Sat, Jul 3, 7:20 AM
cscott committed rMLDOede41c02e8d3: Sort errors and failures (authored by cscott).
Sort errors and failures
Sat, Jul 3, 6:43 AM
cscott committed rMLDO02112882281e: Clean up WPT harness helper Common.php (authored by cscott).
Clean up WPT harness helper Common.php
Sat, Jul 3, 6:43 AM
cscott committed rMLDO39d677522543: Fix CharacterData to operate with proper UTF-16 offsets (authored by cscott).
Fix CharacterData to operate with proper UTF-16 offsets
Sat, Jul 3, 6:43 AM
cscott committed rMLDOf65e4dc376aa: Clean up WPTTestHarness (authored by cscott).
Clean up WPTTestHarness
Sat, Jul 3, 6:43 AM
cscott committed rMLDO6d4a4ec019a5: Clean up WPT harness helper Selectors.php (authored by cscott).
Clean up WPT harness helper Selectors.php
Sat, Jul 3, 6:43 AM
cscott committed rMLDOea69b6efa600: Remove unused dev dependencies (authored by cscott).
Remove unused dev dependencies
Sat, Jul 3, 6:43 AM

Thu, Jul 1

cscott committed rMLID265f9e895596: Improve documentation of WebIDL "simple exceptions" (authored by cscott).
Improve documentation of WebIDL "simple exceptions"
Thu, Jul 1, 5:23 AM

Wed, Jun 30

cscott committed rMLDO7cdd2ee75aaa: Implement ::add_cleanup in the WPT test harness (authored by cscott).
Implement ::add_cleanup in the WPT test harness
Wed, Jun 30, 8:18 PM
cscott committed rMLDOe5a9e28a7c7f: Fix test case that relied on implicit JS conversion of `null` to a string (authored by cscott).
Fix test case that relied on implicit JS conversion of `null` to a string
Wed, Jun 30, 8:18 PM
cscott committed rMLDO777e5df1f1b1: Improve WPT harness assertInArrayData/assertTrueData/assertFalseData (authored by cscott).
Improve WPT harness assertInArrayData/assertTrueData/assertFalseData
Wed, Jun 30, 8:16 PM
cscott committed rMLDO236c43e15587: Remove harness for parseFromString() since we've implemented DOMParser (authored by cscott).
Remove harness for parseFromString() since we've implemented DOMParser
Wed, Jun 30, 8:16 PM
cscott committed rMLDOa106104d2407: Implement Document::getTitle() / Document::setTitle() (authored by cscott).
Implement Document::getTitle() / Document::setTitle()
Wed, Jun 30, 8:15 PM
cscott committed rMLDOe1582e564449: Move harness code to tests/Harness and strip some unneeded subdirectories (authored by cscott).
Move harness code to tests/Harness and strip some unneeded subdirectories
Wed, Jun 30, 8:14 PM
cscott committed rMLDO3bae5ec8297b: Harness ::getDocBody() helper is no longer needed (authored by cscott).
Harness ::getDocBody() helper is no longer needed
Wed, Jun 30, 8:14 PM
cscott committed rMLDOe35d15fe0f49: Document::getElementById: The empty string is not a valid ID (authored by cscott).
Document::getElementById: The empty string is not a valid ID
Wed, Jun 30, 12:59 AM
cscott committed rMLDO966ec3638d84: Wpt -> WPT, and more case-sensitivity fixes (authored by cscott).
Wpt -> WPT, and more case-sensitivity fixes
Wed, Jun 30, 12:59 AM
cscott committed rMLDOf85a5fd19c7b: Copy test harness changes back to skeleton files (authored by cscott).
Copy test harness changes back to skeleton files
Wed, Jun 30, 12:59 AM
cscott committed rMLDOe5925390686e: W3c -> W3C, and fix other case-sensitive filenames (authored by cscott).
W3c -> W3C, and fix other case-sensitive filenames
Wed, Jun 30, 12:59 AM

Tue, Jun 29

cscott committed rMLDO2334726f87f5: Hack in some attributes fields to make W3C tests pass (authored by cscott).
Hack in some attributes fields to make W3C tests pass
Tue, Jun 29, 7:19 PM
cscott committed rMLDO00a08f41f382: Rename Node::__unsafe_appendChild and use it more broadly (authored by cscott).
Rename Node::__unsafe_appendChild and use it more broadly
Tue, Jun 29, 7:17 PM
cscott committed rMLDO067d7ecbfec1: Remove object addresses (which vary every run) from failure logs (authored by cscott).
Remove object addresses (which vary every run) from failure logs
Tue, Jun 29, 4:54 PM

Mon, Jun 28

cscott committed rMLDO0b1359ef05ed: Implement __get() helper methods for DOMException (from IDLeDOM helper) (authored by cscott).
Implement __get() helper methods for DOMException (from IDLeDOM helper)
Mon, Jun 28, 11:10 PM
cscott committed rMLDOdda48c7f0961: Bug fixes to assertion methods in test harnesses (authored by cscott).
Bug fixes to assertion methods in test harnesses
Mon, Jun 28, 11:10 PM
cscott committed rMLDOccdbf5d364fd: Don't check in the log.xml files; they contain timings and absolute filenames (authored by cscott).
Don't check in the log.xml files; they contain timings and absolute filenames
Mon, Jun 28, 11:10 PM
cscott committed rMLDO852b7086aaaf: Update phpdoc tags for IDLeDOM 0.6.0 (authored by cscott).
Update phpdoc tags for IDLeDOM 0.6.0
Mon, Jun 28, 11:10 PM

Jun 15 2021

cscott added a comment to T284921: Remove "auto-number headings" preference .
  1. Let people add numbers with CSS counter.

I was anticipating #2 actually, and I'm pretty sure that would be generally preferable on the MediaWiki side also.

Jun 15 2021, 3:27 PM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Cache, MediaWiki-Parser, Platform Engineering
cscott closed T277800: Argument 1 passed to Wikimedia\Parsoid\Html2Wt\WikitextSerializer::stripUnnecessaryHeadingNowikis() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.34/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php on line 1647 as Resolved.

We updated our deploy docs to better cover this case and ensure this doesn't happen again.

Jun 15 2021, 2:39 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Parsoid, Wikimedia-production-error
cscott committed rMLDOfeaca4db5141: Update to idle-dom 0.6.0 (events, string enums, dictionary classes) (authored by cscott).
Update to idle-dom 0.6.0 (events, string enums, dictionary classes)
Jun 15 2021, 5:57 AM
cscott committed rMLDOfe0be86592d1: Implement DOMParser::parseFromString() and use it (authored by cscott).
Implement DOMParser::parseFromString() and use it
Jun 15 2021, 5:57 AM