Page MenuHomePhabricator
Feed Advanced Search

Oct 11 2019

JeanFred committed R2566:9bd416002333: Extract method make_stats_for_no_group, with unit test.
Extract method make_stats_for_no_group, with unit test
Oct 11 2019, 6:31 PM
JeanFred committed R2566:f420e8dfa92b: Remove method run from PropertyStatistics.
Remove method run from PropertyStatistics
Oct 11 2019, 6:28 PM
JeanFred committed R2566:30fb5f7eeae7: Extract method format_higher_grouping_text.
Extract method format_higher_grouping_text
Oct 11 2019, 6:24 PM
JeanFred committed R2566:c03b50675867: Remove unnecessary intermediary variable in process_page.
Remove unnecessary intermediary variable in process_page
Oct 11 2019, 6:23 PM
JeanFred committed R2566:a619c01f7da5: Switch example data to red pandas.
Switch example data to red pandas
Oct 11 2019, 6:18 PM
JeanFred committed R2566:8e2b75ddee30: Enable test coverage using pytest-cov.
Enable test coverage using pytest-cov
Oct 11 2019, 6:15 PM
JeanFred committed R2566:1b8631fa7c92: Integrate coverage reporting with CodeCov.io in Travis-CI build.
Integrate coverage reporting with CodeCov.io in Travis-CI build
Oct 11 2019, 6:15 PM

Oct 8 2019

JeanFred committed R2566:70b47b5cd011: Reorganize files under a more standard package layout.
Reorganize files under a more standard package layout
Oct 8 2019, 8:01 PM

Oct 7 2019

JeanFred committed R2566:8365cc4508ef: Fix ordering of OrderedDict in TestParseConfigProperties.
Fix ordering of OrderedDict in TestParseConfigProperties
Oct 7 2019, 11:10 AM
JeanFred committed R2566:5713305a2ce5: Increase verbosity of py.test output in tox file.
Increase verbosity of py.test output in tox file
Oct 7 2019, 8:31 AM
JeanFred committed R2566:72b33ec5bf3d: Upgrade py.test to latest 5.2.1 (annd other dev dependencies).
Upgrade py.test to latest 5.2.1 (annd other dev dependencies)
Oct 7 2019, 8:25 AM
JeanFred committed R2566:3b4a376cb30f: Add Travis CI configuration and ReadMe badge.
Add Travis CI configuration and ReadMe badge
Oct 7 2019, 12:07 AM

Sep 30 2019

JeanFred updated the task description for T234230: InteGraality should not consider <no value> as a missing value.
Sep 30 2019, 3:38 PM · Tool-inteGraality
JeanFred closed T234230: InteGraality should not consider <no value> as a missing value as Invalid.

This is already the current behaviour.

Sep 30 2019, 3:37 PM · Tool-inteGraality
JeanFred created T234230: InteGraality should not consider <no value> as a missing value.
Sep 30 2019, 3:31 PM · Tool-inteGraality

Sep 19 2019

JeanFred committed R2566:9b8dfa5e948d: Catch all exceptions in pages_processor.process_all.
Catch all exceptions in pages_processor.process_all
Sep 19 2019, 7:06 PM
JeanFred committed R2566:d214f093cec7: Handle case where no groupings are retrieved from the Query Service.
Handle case where no groupings are retrieved from the Query Service
Sep 19 2019, 7:06 PM
JeanFred committed R2566:12ebc395f52a: Add direct link in footer to report a bug.
Add direct link in footer to report a bug
Sep 19 2019, 7:06 PM

Sep 18 2019

Effeietsanders awarded T195341: Post message to WLM participants who have not registered an email address a Yellow Medal token.
Sep 18 2019, 9:00 PM · Wiki-Loves-Monuments (2019)
JeanFred edited projects for T195341: Post message to WLM participants who have not registered an email address , added: Wiki-Loves-Monuments (2019); removed Wiki-Loves-Monuments (2018).
Sep 18 2019, 8:51 PM · Wiki-Loves-Monuments (2019)
JeanFred added a comment to T195341: Post message to WLM participants who have not registered an email address .

Ran check_emailable_users.py -category:"Images_from_Wiki_Loves_Monuments_2019" -delta:27360 -notify (to cover the last 18 days of competition. Took 4h.

There were 3454 uploaders in the last 27360 minutes...
...and 1139 non-emailable users
Sep 18 2019, 8:49 PM · Wiki-Loves-Monuments (2019)
JeanFred closed T232147: Number the country rankings as Resolved.

@MichaelMaggs This is now live − see https://tools.wmflabs.org/wikiloves/monuments/2019

Sep 18 2019, 2:42 PM · Tool-wikiloves
JeanFred committed R1969:093137ed5247: Enable high-frequency update for Wiki Loves Monuments 2019.
Enable high-frequency update for Wiki Loves Monuments 2019
Sep 18 2019, 2:38 PM
JeanFred committed R1969:7bd4fb9b96f8: Separate log files for update cron jobs.
Separate log files for update cron jobs
Sep 18 2019, 2:38 PM
JeanFred merged T233177: Wikiloves tool fails to display images uploaded by a given user into T231796: 502 Bad Gateway error in wikiloves images view when passing a user.
Sep 18 2019, 8:04 AM · Tool-wikiloves
JeanFred merged task T233177: Wikiloves tool fails to display images uploaded by a given user into T231796: 502 Bad Gateway error in wikiloves images view when passing a user.
Sep 18 2019, 8:04 AM · Tool-wikiloves
JeanFred renamed T231796: 502 Bad Gateway error in wikiloves images view when passing a user from 502 Bad Gateway error in WLM to 502 Bad Gateway error in wikiloves images view when passing a user.
Sep 18 2019, 8:04 AM · Tool-wikiloves

Sep 17 2019

JeanFred added a comment to T195341: Post message to WLM participants who have not registered an email address .

Pfew, took me two weeks to actually test that script ; found a bug, fixed it, now we’d be good to go.

Sep 17 2019, 9:10 PM · Wiki-Loves-Monuments (2019)

Sep 11 2019

JeanFred committed R1969:4fe1f629af7f: Number the country rankings on Edition page.
Number the country rankings on Edition page
Sep 11 2019, 1:30 PM
JeanFred triaged T232147: Number the country rankings as Medium priority.

Sure, good idea :)

Sep 11 2019, 1:04 PM · Tool-wikiloves

Sep 10 2019

JeanFred created T232536: Toolforge Kubernetes internal API down, causing `webservice` and other tooling to fail.
Sep 10 2019, 8:53 PM · Sustainability (Incident Followup), cloud-services-team (Kanban), Toolforge
JeanFred triaged T232394: Statistics fail on Wikidata harvested dataset as High priority.
Sep 10 2019, 8:00 PM · Wiki-Loves-Monuments-Database, Wiki-Loves-Monuments (2019)
JeanFred closed T232394: Statistics fail on Wikidata harvested dataset as Resolved.

Fixed https://commons.wikimedia.org/wiki/Special:Diff/365298329

Sep 10 2019, 8:00 PM · Wiki-Loves-Monuments-Database, Wiki-Loves-Monuments (2019)

Sep 9 2019

JeanFred added a comment to T232394: Statistics fail on Wikidata harvested dataset .

Can’t reproduce this locally. I did a harvest of ge:ka and another of au:en, ran fill_table_monuments_all and then database_statistics − the stats are generated just fine :-/

Sep 9 2019, 9:18 PM · Wiki-Loves-Monuments-Database, Wiki-Loves-Monuments (2019)
JeanFred created T232394: Statistics fail on Wikidata harvested dataset .
Sep 9 2019, 9:14 PM · Wiki-Loves-Monuments-Database, Wiki-Loves-Monuments (2019)

Sep 4 2019

JeanFred closed T232001: WLM 2019: Armenia missing from wikiloves as Resolved.
Sep 4 2019, 3:52 PM · Wiki-Loves-Monuments (2019), Tool-wikiloves
JeanFred added a comment to T232001: WLM 2019: Armenia missing from wikiloves .

Good catch, thanks for reporting!

Sep 4 2019, 3:51 PM · Wiki-Loves-Monuments (2019), Tool-wikiloves
JeanFred committed R1969:9b1d32b43cbf: Add special exception for WLM 2019 in Armenia.
Add special exception for WLM 2019 in Armenia
Sep 4 2019, 3:49 PM
JeanFred renamed T232001: WLM 2019: Armenia missing from wikiloves from Missing country to WLM 2019: Armenia missing from wikiloves .
Sep 4 2019, 3:46 PM · Wiki-Loves-Monuments (2019), Tool-wikiloves
JeanFred triaged T232001: WLM 2019: Armenia missing from wikiloves as Medium priority.
Sep 4 2019, 3:43 PM · Wiki-Loves-Monuments (2019), Tool-wikiloves

Sep 2 2019

JeanFred added a comment to T138517: mysqldump is timing out preventing all tables from being included in the dump.

Huh, looks like that just succeeded, in 6 minutes:

2019-09-02_16:31:06 Dump database...
2019-09-02_16:37:34 Replace the sql file atomically...
Sep 2 2019, 5:34 PM · DBA, Wiki-Loves-Monuments-Database
JeanFred added a comment to T231796: 502 Bad Gateway error in wikiloves images view when passing a user.

The images view 502s when providing a username parameter:
https://tools.wmflabs.org/wikiloves/images?event=monuments&year=2019&country=Russia&user=Olga-lisenkova

Sep 2 2019, 10:41 AM · Tool-wikiloves
JeanFred added a comment to T231796: 502 Bad Gateway error in wikiloves images view when passing a user.

Ah, my bad, I got confused with the steps. The images view does indeed 502.

Sep 2 2019, 10:39 AM · Tool-wikiloves
JeanFred added a comment to T231796: 502 Bad Gateway error in wikiloves images view when passing a user.

Thanks for reporting this and giving reproduction steps.

Sep 2 2019, 10:38 AM · Tool-wikiloves
JeanFred added a comment to T231760: Portugal appearing as "not participating in Wiki Loves Monuments 2019" at WLM map.

Cross-filed at https://github.com/hatnote/monumental/issues/33

Sep 2 2019, 8:23 AM · Wiki-Loves-Monuments (2020), Monumental
JeanFred added a comment to T231780: "Uploaders registered after competition starts" only take Commons into account.

My guess would be that the tool looks at when the Wikimedia Commons account was created rather than when the SUL account was created.

Sep 2 2019, 8:08 AM · Tool-wikiloves

Sep 1 2019

JeanFred edited projects for T231760: Portugal appearing as "not participating in Wiki Loves Monuments 2019" at WLM map, added: Monumental; removed Maps, Map-of-monuments.
Sep 1 2019, 7:43 PM · Wiki-Loves-Monuments (2020), Monumental
JeanFred moved T173783: Get Malaysia into the monuments database from Backlog to Done on the Wiki-Loves-Monuments (2018) board.
Sep 1 2019, 7:41 PM · Wiki-Loves-Monuments
JeanFred moved T173783: Get Malaysia into the monuments database from Needs mapping to Harvested on the Wiki-Loves-Monuments-Sources board.

Harvest done. 309 monuments.

Sep 1 2019, 7:41 PM · Wiki-Loves-Monuments
JeanFred added a comment to T173783: Get Malaysia into the monuments database.

Harvest is running. The Unknown fields report is already available: https://commons.wikimedia.org/wiki/Commons:Monuments_database/Unknown_fields/monuments_my_(en)

Sep 1 2019, 8:43 AM · Wiki-Loves-Monuments
JeanFred committed R1969:3295ae08842e: Fix spelling mistake in log message.
Fix spelling mistake in log message
Sep 1 2019, 8:37 AM
JeanFred committed R1969:36907a4e77f8: Add category exception for Austria 2019.
Add category exception for Austria 2019
Sep 1 2019, 8:30 AM

Aug 31 2019

JeanFred added a comment to T231621: Add Brazilian monuments in portuguese to Monuments database.
  1. by the nature of point 1 there will be no tracking category for images with ids for the dataset.

The MonumentID could figure it out based on the Wikidata invoke and add the relevant country-based category.

I'll ping @Mike_Peel here, as he is the creator of the MonumentID template on Commons. What do you think, Mike?

Sure, what country tracking category would you like it to add? I've done a demo at https://commons.wikimedia.org/wiki/File:At_Paraty,_Brazil_2017_107.jpg that currently puts it into "Category:Monuments by ID in Brazil", but any other format of "Category:prefix <country> postfix" is straightforward to implement. (But different prefixes/postfixes for different countries would be messy.)

Aug 31 2019, 9:37 AM · Wiki-Loves-Monuments (2020), Patch-For-Review, User-LokalProfil, Wiki-Loves-Monuments-Sources

Aug 30 2019

JeanFred added a comment to T231164: Add WLM 2019 to wikiloves stats tool.

I keep the module updated since today with this edit and have it on my list with changes in the coming hours and days.

Aug 30 2019, 9:09 PM · Tool-wikiloves, Wiki-Loves-Monuments (2019)
JeanFred added a comment to T231621: Add Brazilian monuments in portuguese to Monuments database.

We are also using a different template (MonumentID, which is not Brazilian specific) than the one used in other years (Cultural Heritage Brazil) so the images on Commons from previous Brazil WLM are not affected by this new process.

While I think the sparql bit of this will be straight forward there are a few other issues I think might complicate things (@JeanFred what do you think). They shouldn't be blockers though I believe.

Aug 30 2019, 7:47 PM · Wiki-Loves-Monuments (2020), Patch-For-Review, User-LokalProfil, Wiki-Loves-Monuments-Sources

Aug 29 2019

JeanFred awarded T97861: [toolforge.infra] Provide centralized logging (logstash) for Toolforge a Like token.
Aug 29 2019, 10:09 AM · cloud-services-team, observability, Toolforge

Aug 28 2019

JeanFred added a comment to T195341: Post message to WLM participants who have not registered an email address .

OK, done.

Aug 28 2019, 8:45 PM · Wiki-Loves-Monuments (2019)
JeanFred added a comment to T195341: Post message to WLM participants who have not registered an email address .

I think the text needs some minor tweaks (not sure where to find it on wiki within the template structure):

Aug 28 2019, 4:48 PM · Wiki-Loves-Monuments (2019)

Aug 27 2019

JeanFred added a comment to T195341: Post message to WLM participants who have not registered an email address .

Here is a draft message to be posted on the talk page:

Aug 27 2019, 8:08 PM · Wiki-Loves-Monuments (2019)
JeanFred added a comment to T70876: Make user_email_authenticated status visible on labs.

I found this out as I was researching T195341: Post message to WLM participants who have not registered an email address . I’ll probably go for (slow) API queries, but would be interested in checking this via the WikiReplicas.

Aug 27 2019, 6:32 PM · Data-Services
JeanFred added a comment to T195341: Post message to WLM participants who have not registered an email address .

I investigated this today. It’s doable via the API, and it’s implemented by Pywikibot as user.emailable()

Aug 27 2019, 6:30 PM · Wiki-Loves-Monuments (2019)
JeanFred added a parent task for T70876: Make user_email_authenticated status visible on labs: T195341: Post message to WLM participants who have not registered an email address .
Aug 27 2019, 6:29 PM · Data-Services
JeanFred added a subtask for T195341: Post message to WLM participants who have not registered an email address : T70876: Make user_email_authenticated status visible on labs.
Aug 27 2019, 6:29 PM · Wiki-Loves-Monuments (2019)
MartinK awarded T231344: Design a new, responsive on-wiki landing page template for WLM a Like token.
Aug 27 2019, 5:45 PM · Wiki-Loves-Monuments, Wikimania-Hackathon-2019
JeanFred closed T151783: Switch ErfgoedBot to use pywikibot master (and pin to specific commit) as Declined.

We have now a fine pinned pywikibot, and it’s been working well for a while now.

Aug 27 2019, 4:47 PM · Wiki-Loves-Monuments
JeanFred moved T230769: Revive Erfgoedbot for WLM 2019 from Backlog to In-progress on the Wiki-Loves-Monuments (2019) board.
Aug 27 2019, 4:27 PM · Wiki-Loves-Monuments (2019), User-LokalProfil, Wiki-Loves-Monuments-Database
JeanFred moved T231344: Design a new, responsive on-wiki landing page template for WLM from Backlog to In-progress on the Wiki-Loves-Monuments (2019) board.
Aug 27 2019, 4:27 PM · Wiki-Loves-Monuments, Wikimania-Hackathon-2019
JeanFred moved T134617: Implement CSV/TSV import/export for tabular data set from Backlog to Project Idea on the Wikimania-Hackathon-2019 board.
Aug 27 2019, 4:23 PM · Wikimania-Hackathon-2019, Commons-Datasets
JeanFred moved T231344: Design a new, responsive on-wiki landing page template for WLM from Backlog to Project Idea on the Wikimania-Hackathon-2019 board.
Aug 27 2019, 4:23 PM · Wiki-Loves-Monuments, Wikimania-Hackathon-2019
JeanFred added a project to T231344: Design a new, responsive on-wiki landing page template for WLM: Wikimania-Hackathon-2019.
Aug 27 2019, 4:22 PM · Wiki-Loves-Monuments, Wikimania-Hackathon-2019
JeanFred added a comment to T231344: Design a new, responsive on-wiki landing page template for WLM.

Per https://lists.wikimedia.org/pipermail/wlm-announce/2019-August/000085.html, @MartinK has made https://commons.wikimedia.org/wiki/Commons:Wiki_Loves_Monuments/Documentation/Landingpage_Template

Aug 27 2019, 4:22 PM · Wiki-Loves-Monuments, Wikimania-Hackathon-2019
JeanFred created T231344: Design a new, responsive on-wiki landing page template for WLM.
Aug 27 2019, 4:21 PM · Wiki-Loves-Monuments, Wikimania-Hackathon-2019
JeanFred closed T230768: Beta cluster: Campaign editor rights request, a subtask of T230767: Cleaner upload campaigns for WLM, as Resolved.
Aug 27 2019, 12:59 PM · User-LokalProfil, Wiki-Loves-Monuments (2019)
JeanFred closed T230768: Beta cluster: Campaign editor rights request as Resolved.

Done.

Aug 27 2019, 12:59 PM · User-LokalProfil, Beta-Cluster-Infrastructure
JeanFred closed T203708: clean up requirements-dev as Resolved.

This was actually done in ec66b4f.

Aug 27 2019, 9:27 AM · Wiki-Loves-Monuments-Database
JeanFred moved T231223: Upgrade Heritage to PHP 7 from Backlog to Infrastructure on the Wiki-Loves-Monuments-Database board.
Aug 27 2019, 9:26 AM · Wiki-Loves-Monuments-Database

Aug 26 2019

JeanFred added a comment to T203482: Investigate parallelisation of harvesting job.

This is still roughly 10.5 hours.

Aug 26 2019, 6:42 PM · Wiki-Loves-Monuments-Database
JeanFred closed T203500: Merging tables into mouments_all takes a crazy amout of time as Invalid.

Latest runs:
2019-08-26_13:45:03 Update monuments_all table...
2019-08-26_13:50:34 Make statistics...
→ 5 minutes

Aug 26 2019, 6:41 PM · Wiki-Loves-Monuments (2018), Wiki-Loves-Monuments-Database
JeanFred closed T216364: Upgrade heritage to Strech as Resolved.

Did this also make the statistics bit work?

Is there anything left to do in this task?

Aug 26 2019, 6:35 PM · Wiki-Loves-Monuments-Database
JeanFred added a comment to T231215: Heritage unit tests throw WARNING: TestResult has no addExpectedFailure method, reporting as passes.

Upstream issue with Nose. I should pick up that migration to py.test again :)

Aug 26 2019, 6:33 PM · Wiki-Loves-Monuments-Database
JeanFred closed T203417: update_database crashing due to KeyboardInterrupt as Resolved.

Tentatively closing this as resolved − grepped through the latest update logs, no mention of KeyboardInterrupt since September 2018

Aug 26 2019, 6:31 PM · Wiki-Loves-Monuments-Database
JeanFred added a project to T230769: Revive Erfgoedbot for WLM 2019: Wiki-Loves-Monuments (2019).
Aug 26 2019, 6:27 PM · Wiki-Loves-Monuments (2019), User-LokalProfil, Wiki-Loves-Monuments-Database
JeanFred added a parent task for T231157: mysql-connect issues during ErfgoedBot run: T231223: Upgrade Heritage to PHP 7.
Aug 26 2019, 6:14 PM · Patch-For-Review, User-LokalProfil, Wiki-Loves-Monuments-Database
JeanFred added a subtask for T231223: Upgrade Heritage to PHP 7: T231157: mysql-connect issues during ErfgoedBot run.
Aug 26 2019, 6:14 PM · Wiki-Loves-Monuments-Database
JeanFred removed a subtask for T231157: mysql-connect issues during ErfgoedBot run: T231223: Upgrade Heritage to PHP 7.
Aug 26 2019, 6:14 PM · Patch-For-Review, User-LokalProfil, Wiki-Loves-Monuments-Database
JeanFred removed a parent task for T231223: Upgrade Heritage to PHP 7: T231157: mysql-connect issues during ErfgoedBot run.
Aug 26 2019, 6:14 PM · Wiki-Loves-Monuments-Database
JeanFred added a subtask for T231157: mysql-connect issues during ErfgoedBot run: T231223: Upgrade Heritage to PHP 7.
Aug 26 2019, 6:13 PM · Patch-For-Review, User-LokalProfil, Wiki-Loves-Monuments-Database
JeanFred added a parent task for T231223: Upgrade Heritage to PHP 7: T231157: mysql-connect issues during ErfgoedBot run.
Aug 26 2019, 6:13 PM · Wiki-Loves-Monuments-Database
JeanFred triaged T231223: Upgrade Heritage to PHP 7 as Low priority.
Aug 26 2019, 6:13 PM · Wiki-Loves-Monuments-Database
JeanFred created T231223: Upgrade Heritage to PHP 7.
Aug 26 2019, 6:13 PM · Wiki-Loves-Monuments-Database
JeanFred reopened T172690: Investigate time-out issues with Wikidata harvests as "Open".

I am not sure the timeout catch actually works: testing the nl_nl, I got the timeout on the Query service UI, but on pywikibot side I just had an empty result.

Aug 26 2019, 5:48 PM · Patch-For-Review, Wiki-Loves-Monuments-Database
JeanFred reopened T172690: Investigate time-out issues with Wikidata harvests, a subtask of T138668: Harvest Wikidata into the Monuments database , as Open.
Aug 26 2019, 5:48 PM · Wikimedia-Hackathon-2017, Wiki-Loves-Monuments-Database
JeanFred reopened T172690: Investigate time-out issues with Wikidata harvests, a subtask of T172772: Wlm/heritage/erfgoedbot sprint at Wikimania Hackathon 2017, as Open.
Aug 26 2019, 5:48 PM · Wikimania-Hackathon-2017, Wiki-Loves-Monuments
JeanFred triaged T231215: Heritage unit tests throw WARNING: TestResult has no addExpectedFailure method, reporting as passes as Low priority.
Aug 26 2019, 4:43 PM · Wiki-Loves-Monuments-Database
JeanFred created T231215: Heritage unit tests throw WARNING: TestResult has no addExpectedFailure method, reporting as passes.
Aug 26 2019, 4:42 PM · Wiki-Loves-Monuments-Database
JeanFred moved T231164: Add WLM 2019 to wikiloves stats tool from Backlog to In-progress on the Wiki-Loves-Monuments (2019) board.
Aug 26 2019, 3:33 PM · Tool-wikiloves, Wiki-Loves-Monuments (2019)

Aug 25 2019

JeanFred committed R1969:ea5f9431ba57: Link to Wikimedia Commons category from instance view.
Link to Wikimedia Commons category from instance view
Aug 25 2019, 7:12 PM
JeanFred committed R1969:e020db38d519: Link to Daily Uploads tool from the Instance view.
Link to Daily Uploads tool from the Instance view
Aug 25 2019, 7:12 PM
JeanFred closed T231152: Flake8 fails on labs-tools-heritage, complaining about py3 stuff as Resolved.
Aug 25 2019, 5:24 PM · Wiki-Loves-Monuments-Database
JeanFred added a comment to T231152: Flake8 fails on labs-tools-heritage, complaining about py3 stuff.

Ah, setting basepython is good enough as it seems :)

Aug 25 2019, 3:20 PM · Wiki-Loves-Monuments-Database