Thanks again for the responses @Pablo-WMDE I hereby declare the editing master ticket officially resolved :)
Thu, Apr 18
Wed, Apr 17
Declined because it only appears on en beta wikipedia
Tue, Apr 16
Thanks for the responses, @Pablo-WMDE !
Am I right in assuming that you used the m.wikidata.beta.wmflabs.org domain? I filed T220995 so we address the blocked cross-origin response. Please use the non-mobile domain with the useformat parameter to work around this.
I can successfully make edits now :)
What does not happen, yet, is an automatic update if other people changed other parts of the item in the mean time. So if I change the de-label and somebody else changes the fr-label, I don't see the fr-label change, not even if I enter the editing mode for a second time. Only a hard refresh shows me the actual data. This is contrary to the second to last acceptance criterion, but I would be ok with leaving it like this for now (especially since I believe to remember that we put the criterion in such a way because it was easiest for you to implement).
Mon, Apr 15
things that I found:
- I could not save the page, neither logged in nor logged out, neither firefox nor google. Clicking on the save button resulted in no visible response (and the data was not updated either)
- The acceptance criteria state that line breaks are allowed, but they are not. I do remember some discussion among devs + UX that might have resulted in a ticket that states the opposite, but just in case that was not the case, I'm mentioning it here
- The save button does not have any shadow, but it does have it in the mocks
Fri, Apr 12
Thu, Apr 11
This was taken into the scope of T216987: Allow editing of fields
Wed, Apr 10
updated again, removing the mentioning of placeholders, so there is no doubling with T217000: Show placeholders for label, description and alias
per resolution of T217767
Updated the task description to have all acceptance criteria in there and not also mixed into the comments
Hi @Yann, thanks for the report! The definition of licences that allow a transfer and licences that block a transfer can be found here for English Wikipedia (and a list of all config files for wikis can be found here. If you want to add a licence that is allowed on Commons, please add the licence name in a newline in the "Templates / Good" - list. I hope that helps!
Mon, Apr 8
Mon, Apr 1
Sat, Mar 30
It looks generally fine to me, but I am wondering if we shouldn't also adapt the info box: The description there says "Displays popups when users hover over article links" and I wonder whether it feels right already to also call yourselves authors (or is there a better way to define more precisely where people worked on)?
Fri, Mar 29
Sorry I overlooked your comment last week :/ So the icons now look awesome, I just noticed one thing and I wonder if this is related to the ticket: On Chrome the min width is bigger than on firefox, and the delta could roughly be the icon size. But if this is not related, then please mark the ticket as resolved :)