Page MenuHomePhabricator
Feed Advanced Search

Nov 5 2018

JeroenDeDauw committed rEWLEe6d0806f4147: Move interactor construction into normal function.
Move interactor construction into normal function
Nov 5 2018, 2:21 PM
JeroenDeDauw committed rEWLEea875df2244b: Split interactor construction code.
Split interactor construction code
Nov 5 2018, 2:21 PM

Nov 1 2018

JeroenDeDauw closed T208534: Outdated version of CS cause failures on Gerrit as Resolved.

Already fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/471046

Nov 1 2018, 7:11 PM · Wikibase-Quality-Constraints, Wikidata
JeroenDeDauw renamed T208534: Outdated version of CS cause failures on Gerrit from Outdated version of CS used on Gerrit to Outdated version of CS cause failures on Gerrit.
Nov 1 2018, 7:06 PM · Wikibase-Quality-Constraints, Wikidata
JeroenDeDauw created T208534: Outdated version of CS cause failures on Gerrit.
Nov 1 2018, 7:06 PM · Wikibase-Quality-Constraints, Wikidata
JeroenDeDauw added a comment to T206325: Use wikibase/data-model 9.0 everywhere.

Release PR: https://github.com/wmde/WikibaseDataModel/pull/801

Nov 1 2018, 2:58 PM · User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), MediaWiki-Vendor, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, [DEPRECATED] wdwb-tech, Wikibase-DataModel, Wikidata
JeroenDeDauw added a comment to T208500: Wikidata role on vagrant not working locally (unclear why).

As @Addshore said, that composer info does not look right. You'll get the error you are getting when the code is not loaded. So my guess is that you do not have it loaded.

Nov 1 2018, 2:53 PM · MediaWiki-Vagrant, DataValues, Wikibase-Quality-Constraints, Wikidata
JeroenDeDauw added a comment to T208500: Wikidata role on vagrant not working locally (unclear why).

AFAIK Wikibase does not use Geo 4.x, since Geo 4.x requires PHP 7.1. So it is not clear to me how the 4.1 release could affect Wikibase.

Nov 1 2018, 2:51 PM · MediaWiki-Vagrant, DataValues, Wikibase-Quality-Constraints, Wikidata

Oct 30 2018

JeroenDeDauw added a comment to T204714: Define job to run constraint checks for an entity.

Ready for review : https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/463740

Oct 30 2018, 12:54 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), User-Addshore, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
JeroenDeDauw added a comment to T204714: Define job to run constraint checks for an entity.

I'll amend the change

Oct 30 2018, 12:47 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), User-Addshore, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
JeroenDeDauw added a comment to T204714: Define job to run constraint checks for an entity.

Someone will need to follow up on Jonas his PR

Oct 30 2018, 12:34 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), User-Addshore, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

Oct 29 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEWLEfeab042093aa: Merge "Fix type in comment" (authored by JeroenDeDauw).
Merge "Fix type in comment"
Oct 29 2018, 12:02 PM
JeroenDeDauw added a comment to T206325: Use wikibase/data-model 9.0 everywhere.

One thing we could do is revert the change causing all the pain. EntityDocument extending ClearableEntity might be nice, though likely not worth all this effort.

Oct 29 2018, 10:26 AM · User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), MediaWiki-Vendor, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, [DEPRECATED] wdwb-tech, Wikibase-DataModel, Wikidata
JeroenDeDauw committed rEWLE056a8c251815: Move ChangeOp Deserialization stuff into Presentation/.
Move ChangeOp Deserialization stuff into Presentation/
Oct 29 2018, 9:44 AM
JeroenDeDauw committed rEWLE7f65b92e1c0b: Prevent modification of stored Lexeme in FakeLexemeRepository.
Prevent modification of stored Lexeme in FakeLexemeRepository
Oct 29 2018, 8:45 AM

Oct 27 2018

JeroenDeDauw committed rEWLE4dcc4b8f29fe: Fix type in comment.
Fix type in comment
Oct 27 2018, 8:57 AM
JeroenDeDauw committed rEWLEfa02ee6e0024: Prevent modification of stored Lexeme in FakeLexemeRepository.
Prevent modification of stored Lexeme in FakeLexemeRepository
Oct 27 2018, 8:57 AM
JeroenDeDauw committed rEWLE6d40e5ecfb05: Use return type hints in Lexeme.
Use return type hints in Lexeme
Oct 27 2018, 8:53 AM
JeroenDeDauw committed rEWLEcc3e1f85ebdb: Prevent modification of stored Lexeme in FakeLexemeRepository.
Prevent modification of stored Lexeme in FakeLexemeRepository
Oct 27 2018, 8:50 AM
JeroenDeDauw committed rEWLEf90e767568b5: Break EntityRevisionLookup out of merge interactor.
Break EntityRevisionLookup out of merge interactor
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLE5b9987f041e9: Store isBot state in global factory.
Store isBot state in global factory
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLE6a4cef879c89: Split interactor construction code.
Split interactor construction code
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLEd152969c0d33: Move LexemeRepository construction out of the merge interactor.
Move LexemeRepository construction out of the merge interactor
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLEe216e94966af: Move interactor construction into normal function.
Move interactor construction into normal function
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLE82f161afbbe1: Break auth details (inc MW bind) out of LexemeMerge interactor.
Break auth details (inc MW bind) out of LexemeMerge interactor
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLEfac2caf53f1a: Split method in MediaWikiLexemeRepository.
Split method in MediaWikiLexemeRepository
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLEde276968bc37: Break persistance details out of MergeLexemesInteractor (initial step).
Break persistance details out of MergeLexemesInteractor (initial step)
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLEc08583e8ae6f: Rename Domain/Lookups to Domain/Storage.
Rename Domain/Lookups to Domain/Storage
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLE7af41066fdea: Remove not needed vars.
Remove not needed vars
Oct 27 2018, 8:31 AM
JeroenDeDauw committed rEWLEb3eb5615f50e: Add TODO.
Add TODO
Oct 27 2018, 8:31 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWLEaac1466f0189: Merge "Inline not needed vars" (authored by JeroenDeDauw).
Merge "Inline not needed vars"
Oct 27 2018, 7:40 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWLEd623f234b547: Merge "Remove dead code from MergeLexemesInteractor" (authored by JeroenDeDauw).
Merge "Remove dead code from MergeLexemesInteractor"
Oct 27 2018, 7:40 AM

Oct 26 2018

JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.

I've started cleaning up the existing interactor to correspond to what an interactor normally is and to respect architectural boundaries. This is mostly done. Chain of commits starting with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/469373

Oct 26 2018, 7:55 AM · Wikidata-Trailblazing-Exploration, Wikidata-Campsite, Technical-Debt, User-Addshore, Wikidata Lexicographical data, Wikidata
JeroenDeDauw committed rEWLE60c42ce3ff7d: Break EntityRevisionLookup out of merge interactor.
Break EntityRevisionLookup out of merge interactor
Oct 26 2018, 7:46 AM
JeroenDeDauw committed rEWLEbb5247e5c178: Break EntityRevisionLookup out of merge interactor.
Break EntityRevisionLookup out of merge interactor
Oct 26 2018, 7:32 AM
JeroenDeDauw committed rEWLE7b9b56d1ce38: Break EntityRevisionLookup out of merge interactor.
Break EntityRevisionLookup out of merge interactor
Oct 26 2018, 7:21 AM
JeroenDeDauw committed rEWLEb5223273f6ed: Add to DIRECTORIES.md.
Add to DIRECTORIES.md
Oct 26 2018, 7:18 AM
JeroenDeDauw committed rEWLE9a8e7387e062: Remove not needed comments.
Remove not needed comments
Oct 26 2018, 7:15 AM
JeroenDeDauw committed rEWLE690b6afadfc2: Break EntityRevisionLookup out of merge interactor.
Break EntityRevisionLookup out of merge interactor
Oct 26 2018, 7:00 AM
JeroenDeDauw committed rEWLE46b4990f594a: Remove docs in LexemeValidatorFactory.
Remove docs in LexemeValidatorFactory
Oct 26 2018, 4:29 AM

Oct 25 2018

JeroenDeDauw committed rEWLEbb838bfda8f8: Store isBot state in global factory.
Store isBot state in global factory
Oct 25 2018, 10:22 AM
JeroenDeDauw committed rEWLE69ec8b9cd068: Remove no longer needed parameter.
Remove no longer needed parameter
Oct 25 2018, 10:17 AM
JeroenDeDauw committed rEWLE9aa61769eceb: Store isBot state in global factory.
Store isBot state in global factory
Oct 25 2018, 10:12 AM
JeroenDeDauw committed rEWLE025fe59e0250: Move LexemeRepository construction out of the merge interactor.
Move LexemeRepository construction out of the merge interactor
Oct 25 2018, 9:49 AM
JeroenDeDauw committed rEWLEca4949228638: Split interactor construction code.
Split interactor construction code
Oct 25 2018, 9:49 AM
JeroenDeDauw committed rEWLE289f2256aa04: Move interactor construction into normal function.
Move interactor construction into normal function
Oct 25 2018, 9:06 AM
JeroenDeDauw committed rEWLE07d24929d16a: Break auth details (inc MW bind) out of LexemeMerge interactor.
Break auth details (inc MW bind) out of LexemeMerge interactor
Oct 25 2018, 8:53 AM
JeroenDeDauw committed rEWLE108c8deffcd1: Break auth details (inc MW bind) out of LexemeMerge interactor.
Break auth details (inc MW bind) out of LexemeMerge interactor
Oct 25 2018, 8:43 AM

Oct 24 2018

JeroenDeDauw committed rEWLE3cdb95fa692d: Split method in MediaWikiLexemeRepository.
Split method in MediaWikiLexemeRepository
Oct 24 2018, 7:52 AM
JeroenDeDauw committed rEWLE6f29b5651373: Break persistance details out of MergeLexemesInteractor (initial step).
Break persistance details out of MergeLexemesInteractor (initial step)
Oct 24 2018, 7:49 AM
JeroenDeDauw committed rEWLE7e4cf497fb0b: Break persistance details out of MergeLexemesInteractor (initial step).
Break persistance details out of MergeLexemesInteractor (initial step)
Oct 24 2018, 6:21 AM
JeroenDeDauw committed rEWLEba60495e8a92: Rename Domain/Lookups to Domain/Storage.
Rename Domain/Lookups to Domain/Storage
Oct 24 2018, 5:49 AM
JeroenDeDauw committed rEWLE73d9219deb56: Remove not needed vars.
Remove not needed vars
Oct 24 2018, 5:49 AM
JeroenDeDauw committed rEWLE657ffd442f7f: Add TODO.
Add TODO
Oct 24 2018, 5:49 AM
JeroenDeDauw committed rEWLE57bd77cda551: Inline not needed vars.
Inline not needed vars
Oct 24 2018, 5:49 AM
JeroenDeDauw committed rEWLE2c3491f04c33: Remove dead code from MergeLexemesInteractor.
Remove dead code from MergeLexemesInteractor
Oct 24 2018, 5:13 AM
JeroenDeDauw committed rEWLEbc21c3c2d100: Fix FQN in MergeLexemes.
Fix FQN in MergeLexemes
Oct 24 2018, 4:56 AM
JeroenDeDauw committed rEWLEc49ca1417086: Do not require factory in ChangeOpLexicalCategory.
Do not require factory in ChangeOpLexicalCategory
Oct 24 2018, 4:53 AM
JeroenDeDauw committed rEWLE81153591c019: Do not require factory in ChangeOpLexicalCategory.
Do not require factory in ChangeOpLexicalCategory
Oct 24 2018, 3:53 AM
JeroenDeDauw committed rEWLE15b2a7b3abf4: Do not require factory in ChangeOpLanguage.
Do not require factory in ChangeOpLanguage
Oct 24 2018, 3:47 AM
JeroenDeDauw committed rEWLE6103ec287a36: Add preliminary DIRECTORIES.md.
Add preliminary DIRECTORIES.md
Oct 24 2018, 3:31 AM
JeroenDeDauw committed rEWLE5b38dbecfeab: Add preliminary DIRECTORIES.md.
Add preliminary DIRECTORIES.md
Oct 24 2018, 3:31 AM
JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/469367

Oct 24 2018, 3:28 AM · Wikidata-Trailblazing-Exploration, Wikidata-Campsite, Technical-Debt, User-Addshore, Wikidata Lexicographical data, Wikidata
JeroenDeDauw committed rEWLE135286c8f9ff: Add preliminary DIRECTORIES.md.
Add preliminary DIRECTORIES.md
Oct 24 2018, 3:23 AM
JeroenDeDauw committed rEWLEe2e4147baf59: Remove docs in LexemeValidatorFactory.
Remove docs in LexemeValidatorFactory
Oct 24 2018, 2:34 AM

Oct 23 2018

JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.

Chain partially merged. First commit that still needs merging: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/466682/

Oct 23 2018, 8:48 AM · Wikidata-Trailblazing-Exploration, Wikidata-Campsite, Technical-Debt, User-Addshore, Wikidata Lexicographical data, Wikidata
JeroenDeDauw committed rEWLE7491390a362e: Move ChangeOps/ into DataAccess/.
Move ChangeOps/ into DataAccess/
Oct 23 2018, 2:14 AM
JeroenDeDauw committed rEWLEde0c396c58ce: Move LemmaTermValidator to where other ChangeOp validation code is.
Move LemmaTermValidator to where other ChangeOp validation code is
Oct 23 2018, 2:14 AM
JeroenDeDauw committed rEWLEbb5f1f31f676: Move DummyObjects/ into Domain/.
Move DummyObjects/ into Domain/
Oct 23 2018, 2:14 AM
JeroenDeDauw committed rEWLE225278b29ce3: Move Diff/ into Presentation/.
Move Diff/ into Presentation/
Oct 23 2018, 2:14 AM
JeroenDeDauw committed rEWLEaa48596853b2: Move Store/ and Search/ into DataAccess/.
Move Store/ and Search/ into DataAccess/
Oct 23 2018, 2:11 AM

Oct 17 2018

JeroenDeDauw committed rEWLE00316c4aafed: Move contents of Validators/ elsewhere.
Move contents of Validators/ elsewhere
Oct 17 2018, 6:17 PM
JeroenDeDauw committed rEWLEaca205f6a327: Move View/ into Presentation/.
Move View/ into Presentation/
Oct 17 2018, 6:17 PM
JeroenDeDauw committed rEWLE747d11cc0f75: Move Formatters/ and Rdf/ into Presentation/.
Move Formatters/ and Rdf/ into Presentation/
Oct 17 2018, 6:17 PM
JeroenDeDauw committed rEWLEb37d25c3ca42: Move EntityReferenceExtractors/ and Merge/ into Domain/.
Move EntityReferenceExtractors/ and Merge/ into Domain/
Oct 17 2018, 6:17 PM
JeroenDeDauw committed rEWLEb0d6f52149d1: Reorganize contents of DataModel and rename to Model.
Reorganize contents of DataModel and rename to Model
Oct 17 2018, 6:14 PM
JeroenDeDauw committed rEWLEd965da3855a0: Move DataModel to Domain/DataModel.
Move DataModel to Domain/DataModel
Oct 17 2018, 6:14 PM

Oct 13 2018

JeroenDeDauw committed rEWLE80e7cc72e04e: Break line to reduce line lenght.
Break line to reduce line lenght
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE0a1ea3894167: Move LemmaTermValidator to where other ChangeOp validation code is.
Move LemmaTermValidator to where other ChangeOp validation code is
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE4f92c51db76d: Move ChangeOps/ into DataAccess/.
Move ChangeOps/ into DataAccess/
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE8223f62eb11d: Move Diff/ into Presentation/.
Move Diff/ into Presentation/
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE4ed4a6418ab6: Move DummyObjects/ into Domain/.
Move DummyObjects/ into Domain/
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE694f0c2796a8: Move Store/ and Search/ into DataAccess/.
Move Store/ and Search/ into DataAccess/
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE2e64b30fa41d: Move contents of Validators/ elsewhere.
Move contents of Validators/ elsewhere
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE0c268b3da4dd: Move View/ into Presentation/.
Move View/ into Presentation/
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE3a2f51e429c2: Move Formatters/ and Rdf/ into Presentation/.
Move Formatters/ and Rdf/ into Presentation/
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE8d4a9acf6e50: Move EntityReferenceExtractors/ and Merge/ into Domain/.
Move EntityReferenceExtractors/ and Merge/ into Domain/
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE12e241d44911: Reorganize contents of DataModel and rename to Model.
Reorganize contents of DataModel and rename to Model
Oct 13 2018, 11:23 PM
JeroenDeDauw committed rEWLE98f2f40c7c47: Move DataModel to Domain/DataModel.
Move DataModel to Domain/DataModel
Oct 13 2018, 11:17 PM
JeroenDeDauw committed rEWLE891258f7aef0: Move EntityLinkFormatters to MW NS.
Move EntityLinkFormatters to MW NS
Oct 13 2018, 11:17 PM

Oct 12 2018

JeroenDeDauw committed rEWLEf71127b7287e: Move LexemeLanguageCodePropertyIdConfig to MW NS.
Move LexemeLanguageCodePropertyIdConfig to MW NS
Oct 12 2018, 4:22 PM
JeroenDeDauw committed rEWLE242dd703dca0: Break line to reduce line lenght.
Break line to reduce line lenght
Oct 12 2018, 2:19 PM

Oct 11 2018

JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.

Initial moving is done, ending with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/466691

Oct 11 2018, 4:40 PM · Wikidata-Trailblazing-Exploration, Wikidata-Campsite, Technical-Debt, User-Addshore, Wikidata Lexicographical data, Wikidata
JeroenDeDauw committed rEWLE02128f0fee0e: Move ChangeOps/ into DataAccess/.
Move ChangeOps/ into DataAccess/
Oct 11 2018, 4:35 PM
JeroenDeDauw committed rEWLEb85dae5f18be: Break line to reduce line lenght.
Break line to reduce line lenght
Oct 11 2018, 4:35 PM
JeroenDeDauw committed rEWLE99784362d7cf: Move LemmaTermValidator to where other ChangeOp validation code is.
Move LemmaTermValidator to where other ChangeOp validation code is
Oct 11 2018, 4:35 PM
JeroenDeDauw committed rEWLEd147d9f20435: Move DummyObjects/ into Domain/.
Move DummyObjects/ into Domain/
Oct 11 2018, 4:06 PM
JeroenDeDauw committed rEWLE5faa1361dca8: Move Diff/ into Presentation/.
Move Diff/ into Presentation/
Oct 11 2018, 4:06 PM
JeroenDeDauw committed rEWLE06ded4beb779: Move contents of Validators/ elsewhere.
Move contents of Validators/ elsewhere
Oct 11 2018, 4:06 PM
JeroenDeDauw committed rEWLE26e6948a7b01: Move Store/ and Search/ into DataAccess/.
Move Store/ and Search/ into DataAccess/
Oct 11 2018, 4:06 PM