Started at https://github.com/wmde/mediawiki-doctrine-connection

The updating optimization ticket is relevant for this cleanup. We now have two main approaches:

I came to a similar conclusion after trying to write some code without looking at this ticket first :) It might still be worth it to do the diff because it helps https://phabricator.wikimedia.org/T220150. I'll comment more there.

@alaa_wmde seems to have a different idea of how the maintenance script would work then I do.

After a bunch of consideration I moderately prefer "2. Create dedicated library". That approach does not clutter anything and it gives us a building block we can use in other projects, which I think is worth the small initial investment.

So this is semi-blocked on figuring out what we do for labs, since that impacts the reasons for immediate cleanup.

I was wondering about how much extra complexity the post request approach (4) would bring. In particular, which info do we need to give to the job. Giving the property id is not sufficient. You could give the ids of the text records and then in the job check if they are still unused and do the same for the higher level records that point to those text records. Thing is, if you already need to find the unused records in the request, then you can just as well delete them right away. Either way you have a performance penalty. So I think the simpler approach (immediate cleanup (3)) makes more sense as a starting point. Does that make sense to you?

I renamed this back to an implementation agnostic task, since else we don't have anything to track the completion of the service implementation, and a parent task for more detailed things such as the cleanup logic.

huh. Why is the DBAL connection part of this checkpoint and not checkpoint 2? I was expecting it to be part of checkpoint 2

Wikibase Client also uses the TermIndex stuff, so I'm afraid we can't just put this into Wikibase Repository. Some options:

Prefix support is done by https://github.com/wmde/wikibase-term-store/commit/cea464a0b4f09acde1eb70d6bda4af423133b460 and https://github.com/wmde/wikibase-term-store/commit/e0139554776b68fedbc62b48c60cb9f0df79b1bf

Experiment at https://github.com/wmde/wikibase-term-store

While this might need work in the UI, avoiding the PHP warning also seemed like a good idea, so Corinna and I paired on this as a little exercise. https://github.com/wmde/fundraising-memberships/pull/27

Blocked on https://phabricator.wikimedia.org/T219142

I'm just seeing this now as addshore mailed me.

https://github.com/wmde/Euro/pull/9

I think it is valuable to have the separation between MW and non-MW bound code on a high level, rather than repeating it in src/ and tests/. Might also be good to separate JS and PHP more.

This is done, awaiting review:

I take it this commit and the follow ups can be abandoned? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/450399/

The initial pass over the structure is done. Having a single mostly-sane UC is almost done. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/472159 and dependent commits. After that the tests will also need to be reorganized. I do not need this ticket to keep track of that, so it can be closed if you want.

I made two commits simplifying the involved code in preparation of implementing the behavior change: