Page MenuHomePhabricator
Feed Advanced Search

Apr 7 2019

JeroenDeDauw moved T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Apr 7 2019, 3:22 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.

Started at https://github.com/wmde/mediawiki-doctrine-connection

Apr 7 2019, 1:31 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw claimed T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.
Apr 7 2019, 1:25 AM · Patch-For-Review, Wikidata wb_terms Trailblazing

Apr 6 2019

JeroenDeDauw updated the task description for T219805: Investigate Doctrine DBAL usage possibility.
Apr 6 2019, 8:59 AM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

The updating optimization ticket is relevant for this cleanup. We now have two main approaches:

Apr 6 2019, 8:28 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220169: Optimize term updating.

I came to a similar conclusion after trying to write some code without looking at this ticket first :) It might still be worth it to do the diff because it helps https://phabricator.wikimedia.org/T220150. I'll comment more there.

Apr 6 2019, 8:16 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

@alaa_wmde seems to have a different idea of how the maintenance script would work then I do.

Apr 6 2019, 8:05 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw placed T219805: Investigate Doctrine DBAL usage possibility up for grabs.
Apr 6 2019, 7:57 AM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review

Apr 5 2019

JeroenDeDauw added a comment to T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.

After a bunch of consideration I moderately prefer "2. Create dedicated library". That approach does not clutter anything and it gives us a building block we can use in other projects, which I think is worth the small initial investment.

Apr 5 2019, 6:49 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

So this is semi-blocked on figuring out what we do for labs, since that impacts the reasons for immediate cleanup.

Apr 5 2019, 5:53 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220169: Optimize term updating from Backlog to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.
Apr 5 2019, 5:50 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Apr 5 2019, 5:49 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Apr 5 2019, 5:49 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Apr 5 2019, 5:48 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Apr 5 2019, 5:48 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220150: [Story] Clean up unused records.

I was wondering about how much extra complexity the post request approach (4) would bring. In particular, which info do we need to give to the job. Giving the property id is not sufficient. You could give the ids of the text records and then in the job check if they are still unused and do the same for the higher level records that point to those text records. Thing is, if you already need to find the unused records in the request, then you can just as well delete them right away. Either way you have a performance penalty. So I think the simpler approach (immediate cleanup (3)) makes more sense as a starting point. Does that make sense to you?

Apr 5 2019, 5:48 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw placed T219295: Create service for writing property terms up for grabs.
Apr 5 2019, 5:23 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw placed T220169: Optimize term updating up for grabs.
Apr 5 2019, 5:22 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw created T220169: Optimize term updating.
Apr 5 2019, 5:22 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219295: Create service for writing property terms.

I renamed this back to an implementation agnostic task, since else we don't have anything to track the completion of the service implementation, and a parent task for more detailed things such as the cleanup logic.

Apr 5 2019, 5:19 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T219120: [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection .

huh. Why is the DBAL connection part of this checkpoint and not checkpoint 2? I was expecting it to be part of checkpoint 2

Apr 5 2019, 5:17 AM · User-Addshore, Wikidata, Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw renamed T219297: Adjust current write logic to write property terms to new schema from Adjust current write logic to write proerty terms to new schema to Adjust current write logic to write property terms to new schema.
Apr 5 2019, 5:15 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a subtask for T219295: Create service for writing property terms: T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.
Apr 5 2019, 5:13 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a parent task for T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection: T219295: Create service for writing property terms.
Apr 5 2019, 5:13 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T219295: Create service for writing property terms from Stalled to In Progress on the Wikidata wb_terms Trailblazing board.
Apr 5 2019, 5:12 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw renamed T219295: Create service for writing property terms from [MW DBAL] Implement the new interface for writing property terms to Create service for writing property terms.
Apr 5 2019, 5:12 AM · Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T219294: Create interface for writing and deleting entity terms as Resolved.
Apr 5 2019, 5:10 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, User-Ladsgroup, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw closed T219294: Create interface for writing and deleting entity terms, a subtask of T219121: [Checkpoint 2] Refactor Write & Migration code for Properties, as Resolved.
Apr 5 2019, 5:09 AM · User-Addshore, Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw added a comment to T220155: Implement Doctrine DBAL Driver Connection wrapper for MW db connection.

Wikibase Client also uses the TermIndex stuff, so I'm afraid we can't just put this into Wikibase Repository. Some options:

Apr 5 2019, 5:07 AM · Patch-For-Review, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220150: [Story] Clean up unused records from Backlog to In Progress on the Wikidata wb_terms Trailblazing board.
Apr 5 2019, 4:50 AM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw moved T220157: Update schema in wikibase-term-store to match original schema from In Review to Done on the Wikidata wb_terms Trailblazing board.
Apr 5 2019, 4:49 AM · Wikidata wb_terms Trailblazing

Apr 4 2019

JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Apr 4 2019, 9:07 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw placed T220150: [Story] Clean up unused records up for grabs.
Apr 4 2019, 8:52 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw updated the task description for T220150: [Story] Clean up unused records.
Apr 4 2019, 8:50 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw created T220150: [Story] Clean up unused records.
Apr 4 2019, 8:49 PM · Wikidata, Wikidata wb_terms Trailblazing
JeroenDeDauw renamed T219144: wbterms: Register new terms store schema changes with MW update mechanism from Update update.php with the new SQL files to Register schema schanges with MW update mechanism.
Apr 4 2019, 8:36 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
JeroenDeDauw updated the task description for T219805: Investigate Doctrine DBAL usage possibility.
Apr 4 2019, 2:14 AM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review
JeroenDeDauw updated the task description for T219805: Investigate Doctrine DBAL usage possibility.
Apr 4 2019, 1:58 AM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review
JeroenDeDauw added a comment to T219805: Investigate Doctrine DBAL usage possibility.

Prefix support is done by https://github.com/wmde/wikibase-term-store/commit/cea464a0b4f09acde1eb70d6bda4af423133b460 and https://github.com/wmde/wikibase-term-store/commit/e0139554776b68fedbc62b48c60cb9f0df79b1bf

Apr 4 2019, 1:58 AM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review

Apr 1 2019

JeroenDeDauw added a comment to T219805: Investigate Doctrine DBAL usage possibility.

Experiment at https://github.com/wmde/wikibase-term-store

Apr 1 2019, 8:45 PM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review
JeroenDeDauw renamed T219805: Investigate Doctrine DBAL usage possibility from Investigate Doctrine usage possibility to Investigate Doctrine DBAL usage possibility.
Apr 1 2019, 4:21 PM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review

Mar 26 2019

JeroenDeDauw added a comment to T215163: Division by zero error when membership fee is validated.

While this might need work in the UI, avoiding the PHP warning also seemed like a good idea, so Corinna and I paired on this as a little exercise. https://github.com/wmde/fundraising-memberships/pull/27

Mar 26 2019, 3:20 PM · WMDE-FUN-Sprint-2019-03-18, WMDE-Fundraising-Tech, WMDE-FUN-Team

Mar 25 2019

JeroenDeDauw added a comment to T219144: wbterms: Register new terms store schema changes with MW update mechanism.

Blocked on https://phabricator.wikimedia.org/T219142

Mar 25 2019, 3:43 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Mar 21 2019

Mill <mill@mail.com> committed rEWLE3580c3d4f651: r6aaaaaaaaaaaa (authored by JeroenDeDauw).
r6aaaaaaaaaaaa
Mar 21 2019, 12:41 AM

Jan 18 2019

JeroenDeDauw added a comment to T204683: cloudvps: queryrapi project trusty deprecation.

I'm just seeing this now as addshore mailed me.

Jan 18 2019, 12:01 PM · Cloud-VPS (Ubuntu Trusty Deprecation)

Jan 17 2019

JeroenDeDauw added a comment to T208950: User Input can cause fatal error in ValidateFeeController.

https://github.com/wmde/Euro/pull/9

Jan 17 2019, 5:45 PM · WMDE-FUN-Team, WMDE-Fundraising-Tech

Jan 15 2019

JeroenDeDauw committed rEWLE2e9a0da0a6a5: Cleanup commented out tests in LexemeSensesMergerTest (authored by Addshore).
Cleanup commented out tests in LexemeSensesMergerTest
Jan 15 2019, 8:17 AM

Jan 14 2019

JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.

I think it is valuable to have the separation between MW and non-MW bound code on a high level, rather than repeating it in src/ and tests/. Might also be good to separate JS and PHP more.

Jan 14 2019, 12:12 PM · Wikidata-Trailblazing-Exploration, Wikidata-Campsite, Technical-Debt, User-Addshore, Wikidata, Wikidata Lexicographical data

Dec 12 2018

JeroenDeDauw committed rEWLEf4c1d56a9178: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).
Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector
Dec 12 2018, 10:22 PM
JeroenDeDauw committed rEWLE622d84ca3bab: Remove comment (authored by JeroenDeDauw).
Remove comment
Dec 12 2018, 10:14 PM

Dec 5 2018

JeroenDeDauw committed rEWLEa780b1831c84: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).
Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector
Dec 5 2018, 10:22 AM

Dec 4 2018

JeroenDeDauw committed rEWLEf224bb0dc4c5: Remove earlier added fixes (authored by JeroenDeDauw).
Remove earlier added fixes
Dec 4 2018, 7:36 PM
JeroenDeDauw committed rEWLE651bf3db5840: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).
Move last trace of $isBot out of MergeLexeme interactor
Dec 4 2018, 4:01 PM

Dec 3 2018

JeroenDeDauw committed rEWLE033a7ed3d33b: Get rid of WikibaseLexeme.mediawiki-services.php (authored by JeroenDeDauw).
Get rid of WikibaseLexeme.mediawiki-services.php
Dec 3 2018, 1:17 PM
JeroenDeDauw committed rEWLE87b2ccbff4bc: Simplify term list merging (authored by JeroenDeDauw).
Simplify term list merging
Dec 3 2018, 12:30 PM
JeroenDeDauw committed rEWLEe477cf1ff82f: Get rid of WikibaseLexeme.mediawiki-services.php (authored by JeroenDeDauw).
Get rid of WikibaseLexeme.mediawiki-services.php
Dec 3 2018, 12:27 PM
JeroenDeDauw moved T204066: Make Lexemes appear in global usage of Commons files from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 3 2018, 12:26 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Multimedia, Wikidata, CommonsMetadata, Wikidata Lexicographical data
JeroenDeDauw committed rEWLE944e09af3386: Remove earlier added fixes (authored by JeroenDeDauw).
Remove earlier added fixes
Dec 3 2018, 10:16 AM
JeroenDeDauw committed rEWLEd90911d79f24: Use ::class refs in Registrar (authored by JeroenDeDauw).
Use ::class refs in Registrar
Dec 3 2018, 10:10 AM
JeroenDeDauw committed rEWLEb92d2c957aee: Get rid of WikibaseLexeme.mediawiki-services.php (authored by JeroenDeDauw).
Get rid of WikibaseLexeme.mediawiki-services.php
Dec 3 2018, 9:58 AM
JeroenDeDauw committed rEWLEddf7351e8201: Get rid of WikibaseLexeme.mediawiki-services.php (authored by JeroenDeDauw).
Get rid of WikibaseLexeme.mediawiki-services.php
Dec 3 2018, 9:18 AM
JeroenDeDauw committed rEWLE2cb30f2a0bd6: Update parser output for Form and Sense statements (authored by JeroenDeDauw).
Update parser output for Form and Sense statements
Dec 3 2018, 9:08 AM

Dec 2 2018

JeroenDeDauw committed rEWLE2fe9cd0ebe1e: Update parser output for Form and Sense statements (authored by JeroenDeDauw).
Update parser output for Form and Sense statements
Dec 2 2018, 10:44 AM
JeroenDeDauw added a comment to T204066: Make Lexemes appear in global usage of Commons files.

This is done, awaiting review:

Dec 2 2018, 10:44 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Multimedia, Wikidata, CommonsMetadata, Wikidata Lexicographical data

Dec 1 2018

JeroenDeDauw committed rEWLE6b4d009ae1bb: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).
Move last trace of $isBot out of MergeLexeme interactor
Dec 1 2018, 9:55 AM
JeroenDeDauw committed rEWLE7cdc9e6d5b73: Simplify term list merging (authored by JeroenDeDauw).
Simplify term list merging
Dec 1 2018, 9:25 AM
JeroenDeDauw committed rEWLE3a3558bda354: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).
Move last trace of $isBot out of MergeLexeme interactor
Dec 1 2018, 9:25 AM
JeroenDeDauw added a comment to T184933: Display map for geocoordinate statements.

I take it this commit and the follow ups can be abandoned? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/450399/

Dec 1 2018, 9:23 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Maps, Wikidata, Wikidata-Gadgets

Nov 22 2018

JeroenDeDauw added a comment to T206619: Reorganizing Lexeme code.

The initial pass over the structure is done. Having a single mostly-sane UC is almost done. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/472159 and dependent commits. After that the tests will also need to be reorganized. I do not need this ticket to keep track of that, so it can be closed if you want.

Nov 22 2018, 1:20 AM · Wikidata-Trailblazing-Exploration, Wikidata-Campsite, Technical-Debt, User-Addshore, Wikidata, Wikidata Lexicographical data

Nov 19 2018

JeroenDeDauw committed rEWLEec08a9ce89cd: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).
Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector
Nov 19 2018, 11:31 PM
JeroenDeDauw committed rEWLEf1b1cba08668: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).
Move last trace of $isBot out of MergeLexeme interactor
Nov 19 2018, 11:31 PM

Nov 9 2018

JeroenDeDauw added a comment to T204066: Make Lexemes appear in global usage of Commons files.

I made two commits simplifying the involved code in preparation of implementing the behavior change:

Nov 9 2018, 9:23 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Multimedia, Wikidata, CommonsMetadata, Wikidata Lexicographical data

Nov 7 2018

JeroenDeDauw committed rEWLEfbaabb0b60bf: Create request model for MergeLexemesInteractor (authored by JeroenDeDauw).
Create request model for MergeLexemesInteractor
Nov 7 2018, 4:18 PM
JeroenDeDauw committed rEWLE18261379bf84: Disable UnusedUse rule (authored by JeroenDeDauw).
Disable UnusedUse rule
Nov 7 2018, 4:14 PM
JeroenDeDauw committed rEWLEb120889a47df: Disable UnusedUse rule (authored by JeroenDeDauw).
Disable UnusedUse rule
Nov 7 2018, 4:14 PM
JeroenDeDauw committed rEWLE940e3072536e: Create request model for MergeLexemesInteractor (authored by JeroenDeDauw).
Create request model for MergeLexemesInteractor
Nov 7 2018, 3:57 PM
JeroenDeDauw committed rEWLE38ecffd404d1: Create request model for MergeLexemesInteractor (authored by JeroenDeDauw).
Create request model for MergeLexemesInteractor
Nov 7 2018, 3:49 PM
JeroenDeDauw committed rEWLE7dc97fa8f85e: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).
Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector
Nov 7 2018, 3:49 PM
JeroenDeDauw committed rEWLE332d59082de8: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).
Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector
Nov 7 2018, 3:29 PM
JeroenDeDauw committed rEWLE93c6346161fa: Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector (authored by JeroenDeDauw).
Fold LexemeRedirectCreationInteractor into MediaWikiLexemeRedirector
Nov 7 2018, 3:29 PM
JeroenDeDauw committed rEWLEe20976b63230: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).
Move last trace of $isBot out of MergeLexeme interactor
Nov 7 2018, 3:29 PM
JeroenDeDauw committed rEWLEccfed96fb94f: Move last trace of $isBot out of MergeLexeme interactor (authored by JeroenDeDauw).
Move last trace of $isBot out of MergeLexeme interactor
Nov 7 2018, 3:07 PM
JeroenDeDauw committed rEWLE23eac5f79ef9: Specify compat with DM 9.x (authored by JeroenDeDauw).
Specify compat with DM 9.x
Nov 7 2018, 2:29 PM

Nov 6 2018

JeroenDeDauw committed rEWLEfdc418af0a93: Remove accidental complexity (authored by JeroenDeDauw).
Remove accidental complexity
Nov 6 2018, 9:10 PM
JeroenDeDauw committed rEWLE7be46466f453: Remove accidental complexity (authored by JeroenDeDauw).
Remove accidental complexity
Nov 6 2018, 8:45 PM
JeroenDeDauw committed rEWLEe68454f2e120: Reduce complexity of service construction in ChangeOpLexicalCategoryTest (authored by JeroenDeDauw).
Reduce complexity of service construction in ChangeOpLexicalCategoryTest
Nov 6 2018, 8:24 PM
JeroenDeDauw committed rEWLEc0a653d263b5: Reduce complexity of service construction in ChangeOpLexicalCategoryTest (authored by JeroenDeDauw).
Reduce complexity of service construction in ChangeOpLexicalCategoryTest
Nov 6 2018, 8:24 PM

Nov 5 2018

JeroenDeDauw committed rEWLE504341d223cb: Reduce complexity of service construction in ChangeOpLexicalCategoryTest (authored by JeroenDeDauw).
Reduce complexity of service construction in ChangeOpLexicalCategoryTest
Nov 5 2018, 11:42 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEWLE569903f8b43c: Merge "Remove dead method" (authored by JeroenDeDauw).
Merge "Remove dead method"
Nov 5 2018, 11:42 PM
JeroenDeDauw committed rEWLE8866aad5c71d: Rename WikibaseLexemeServices.php::newInstance -> newTestInstance (authored by JeroenDeDauw).
Rename WikibaseLexemeServices.php::newInstance -> newTestInstance
Nov 5 2018, 7:28 PM
JeroenDeDauw committed rEWLE74da61458daf: Remove dead method (authored by JeroenDeDauw).
Remove dead method
Nov 5 2018, 7:28 PM
JeroenDeDauw committed rEWLE97c84013b71f: Remove dead method (authored by JeroenDeDauw).
Remove dead method
Nov 5 2018, 3:45 PM
JeroenDeDauw committed rEWLEcf4b2f1429dc: Rename method (authored by JeroenDeDauw).
Rename method
Nov 5 2018, 3:45 PM
JeroenDeDauw committed rEWLE3be4ac6414f0: Explicitly require isBot info when constructing global WikibaseLexemeServices (authored by JeroenDeDauw).
Explicitly require isBot info when constructing global WikibaseLexemeServices
Nov 5 2018, 3:45 PM
JeroenDeDauw committed rEWLE01c4472c6e83: Reduce complexity of service construction in ChangeOpLexicalCategoryTest (authored by JeroenDeDauw).
Reduce complexity of service construction in ChangeOpLexicalCategoryTest
Nov 5 2018, 3:31 PM
JeroenDeDauw committed rEWLEa38195f2fdd7: Move ChangeOp Deserialization stuff into Presentation/ (authored by JeroenDeDauw).
Move ChangeOp Deserialization stuff into Presentation/
Nov 5 2018, 3:11 PM
JeroenDeDauw committed rEWLEeb5bb69b4c91: Prevent modification of stored Lexeme in FakeLexemeRepository (authored by JeroenDeDauw).
Prevent modification of stored Lexeme in FakeLexemeRepository
Nov 5 2018, 2:21 PM
JeroenDeDauw committed rEWLE15015057dee7: Break EntityRevisionLookup out of merge interactor (authored by JeroenDeDauw).
Break EntityRevisionLookup out of merge interactor
Nov 5 2018, 2:21 PM
JeroenDeDauw committed rEWLE80fe0ca04299: Move LexemeRepository construction out of the merge interactor (authored by JeroenDeDauw).
Move LexemeRepository construction out of the merge interactor
Nov 5 2018, 2:21 PM
JeroenDeDauw committed rEWLE972b8f459446: Store isBot state in global factory (authored by JeroenDeDauw).
Store isBot state in global factory
Nov 5 2018, 2:21 PM