In T324759#8875363, @Samwilson wrote:

Yes, I think this is right.

I do wonder if we should reorganise the patches a bit, e.g.:

1. add the new DifferenceEngineBeforeDiffTable hook, but with nothing in it (so it'd not change anything);
2. update VE to use the new hook, to move the existing mode switch;
3. add the type toggle to core, passing it in the hook's $parts paramater;
4. add the legend, also in $parts.

That way, we don't have the awkward situation of things being implemented before they can be used (the legend) or of needing to merge extension and core patches at the same time in order for them to work properly and not break the display.

New implementation will cover the issue described in this task. Please see https://phabricator.wikimedia.org/T324759#8874993

New implementation will cover this issue. Please see https://phabricator.wikimedia.org/T324759#8874993

In T324759#8874993, @HMonroy wrote:

The following tickets will be closed since this new approach will solve the problems described in this tasks:

• T336482: Legend appears on Special:MobileDiff when viewed on desktop
• T336582: Disable visual diffs in Special:AbuseFilter diffs

T336909: Logic for VE diff switch should have an inclusive check is no longer valid since a different solution in patch is being implemented.

No longer valid since a different solution is being implemented as specified in
https://phabricator.wikimedia.org/T324759#8874993

The following tickets will be closed since this new approach will solve the problems described in this tasks:

Dab Tool was started to try to initiate conversation with community about technical requirements for this wish. We determine that this was now feasible during a Wishathon.

@Samwilson The legend is showing up when you toggle to the Visual option.

@TheresNoTime Thank you!

This wish has been submitted multiple times over the years: https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2016/Categories/Editing#Auto-saving_edits, https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2022/Editing/Autosave_edited_or_new_unpublished_article.

In T330972#8744002, @Samwilson wrote:

https://en.wikisource.org/wiki/Author:Adalbold_II_of_Utrecht does not trigger the popup at all, not expected.

This one is already connected to Wikidata, so it shouldn't trigger the popup.

Duh!! Sorry about the noise, I didn't think about that.

@Samwilson, @GMikesell-WMF and I got together to test this issue and we found that there are some inconsistencies.

• https://en.wikisource.org/wiki/Author:May_Hollis_Barton triggers the pop up with the "We couldn't find a Wikidata item.. " message, expected.
• https://en.wikisource.org/wiki/Author:W._Gray triggers the popup with the appropriate suggestions, expected.
• https://en.wikisource.org/wiki/Author:Adalbold_II_of_Utrecht does not trigger the popup at all, not expected.

In T324759#8709170, @TheresNoTime wrote:

In T324759#8708477, @Samwilson wrote:

At the moment there's no way to switch to inline mode anyway, so it won't be seen by very many people. Or is it better to get the dropdown in place first?

I think this is safe to +2, given it won't be seen?