Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Mainframe98 committed rERLSbe5984abadf2: Inject ObjectFactory into ApiModuleManager (authored by Mainframe98).
Inject ObjectFactory into ApiModuleManager
Mon, Sep 16, 9:39 PM

Sun, Sep 15

Mainframe98 merged T190417: CheckboxMultiSelectInputWidget doesn't disable when infusing a disabled HTMLMultiSelectField into T230066: TagMultiselectWidget: the input field is editable even if the widget is disabled.
Sun, Sep 15, 12:00 PM · OOUI, AbuseFilter, User-DannyS712
Mainframe98 merged task T190417: CheckboxMultiSelectInputWidget doesn't disable when infusing a disabled HTMLMultiSelectField into T230066: TagMultiselectWidget: the input field is editable even if the widget is disabled.
Sun, Sep 15, 12:00 PM · OOUI

Tue, Sep 10

Mainframe98 added a comment to T232506: Inject services into special pages.

For the listed patch, this code search shows which extensions will break due to the patch above.

Tue, Sep 10, 5:54 PM · Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 updated the task description for T232506: Inject services into special pages.
Tue, Sep 10, 5:27 PM · Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 created T232506: Inject services into special pages.
Tue, Sep 10, 5:11 PM · Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 committed rEOTP918685b0b428: Remove unnecessary PHPCS exclusions (authored by Mainframe98).
Remove unnecessary PHPCS exclusions
Tue, Sep 10, 10:35 AM

Fri, Sep 6

Mainframe98 updated the task description for T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them.
Fri, Sep 6, 6:42 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-ServiceContainer, MediaWiki-API, MediaWiki-Special-pages, TechCom, Technical-Debt
Mainframe98 added a parent task for T232169: Deprecate `wgSysopEmailBans`: T20807: Phase out right-related globals.
Fri, Sep 6, 6:39 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation), MediaWiki-User-management, User-DannyS712
Mainframe98 added a subtask for T20807: Phase out right-related globals: T232169: Deprecate `wgSysopEmailBans`.
Fri, Sep 6, 6:39 AM · User-DannyS712, MediaWiki-Configuration

Wed, Sep 4

Mainframe98 added a project to T231982: NOINDEX userpages within the Chinese Wikipedia: Wikimedia-Site-requests.
Wed, Sep 4, 12:05 PM · User-Zoranzoki21, Wikimedia-Site-requests, Chinese-Sites

Mon, Sep 2

Mainframe98 closed T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors as Resolved.
Mon, Sep 2, 11:13 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Sun, Sep 1

Mainframe98 added a comment to T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.

To give an example:

Using PHP 7.2.13-1+0~20181207100540.13+stretch~1.gbpf57305
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.
Sun, Sep 1, 9:10 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing
Mainframe98 added a comment to T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.

I tried mocking the Language class, and all the tests that used creatNoOpMock() to mock Language failed until I added the exception for the destructor.

Sun, Sep 1, 8:55 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Fri, Aug 30

Mainframe98 created T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.
Fri, Aug 30, 3:24 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Thu, Aug 29

Mainframe98 added a subtask for T220746: 1.34.0-wmf.21 deployment blockers: T231540: Unable to view contributions: Call to undefined method ContribsPager::getContribs().
Thu, Aug 29, 11:19 AM · Release-Engineering-Team-TODO (201909), Patch-For-Review, Release-Engineering-Team (Deployment services), Release, Train Deployments
Mainframe98 added a parent task for T231540: Unable to view contributions: Call to undefined method ContribsPager::getContribs(): T220746: 1.34.0-wmf.21 deployment blockers.
Thu, Aug 29, 11:19 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Special-pages, User-DannyS712

Thu, Aug 22

Mainframe98 edited projects for T231029: DefaultPreferencesFactory.php: Global default '' is invalid for field incubatortestwiki-code, added: MediaWiki-extensions-GlobalPreferences, MediaWiki-User-preferences; removed MediaWiki-General.
Thu, Aug 22, 4:44 PM · MediaWiki-extensions-WikimediaIncubator, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-User-preferences, Wikimedia-production-error

Tue, Aug 20

Mainframe98 added a comment to T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions.

Is there anything left to do for D1151? I couldn't find any instructions on what to do once the revision has been accepted. I also don't see a way to rerun the tests; previously they failed because harbormaster couldn't connect to Jenkins (B3231).

Tue, Aug 20, 9:38 AM · Phabricator

Aug 18 2019

Mainframe98 added a project to T230672: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?: SocialProfile.
Aug 18 2019, 7:26 AM · SocialProfile, Social-Tools

Aug 16 2019

Mainframe98 added a project to T230628: WinCacheBagOStuff.php: wincache_ucache_add(): function called with a key which already exists: MediaWiki-Cache.
Aug 16 2019, 8:18 PM · MediaWiki-Cache

Aug 15 2019

Mainframe98 edited projects for T230573: Special:RecordImpression renders as a blank page, added: MediaWiki-extensions-CentralNotice; removed MediaWiki-General.

codesearch shows that this special page is part of MediaWiki-extensions-CentralNotice.

Aug 15 2019, 8:27 PM · MediaWiki-extensions-CentralNotice, User-DannyS712

Aug 11 2019

Mainframe98 added projects to T230292: SpecialPage tests failing for Loops extension: MediaWiki-extensions-Loops, ci-test-error.
Aug 11 2019, 10:17 AM · ci-test-error, MediaWiki-extensions-Loops

Aug 4 2019

Mainframe98 added projects to T229750: PhabricatorPackagesPackageEditEngine.php : typo ? => Package Package : Phabricator (Upstream), I18n.

I can't see the message you're referring to: I see "This message group is empty". when I click on the links. Do you have a direct link to the message?

Aug 4 2019, 9:39 AM · I18n, Upstream, Phabricator (Upstream)

Jul 31 2019

Mainframe98 added a comment to T228280: Disable grouped results on RecentChanges page on mobile.

This change also affects non-mobile views: I can no longer group recent changes on mediawiki.org (or the beta cluster), regardless of the value of the preference. I use Vector (on desktop - no mobile whatsoever).

Jul 31 2019, 6:20 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Advanced Mobile Contributions

Jul 29 2019

Mainframe98 updated subscribers of T229185: ArmchairGM links to the most recent commit don't work in Diffusion.

Then it's probably a duplicate of T196855: Diffusion commits stuck in 'Importing...... @mmodell should know how to fix it.

Jul 29 2019, 10:38 AM · Diffusion, VPS-project-codesearch

Jul 28 2019

Mainframe98 added a project to T229176: API allusers: Is it intended that all users are returned when an invalid value for augroup is specified?: MediaWiki-API.
Jul 28 2019, 11:27 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API

Jul 27 2019

Mainframe98 closed T205951: update.php doesn't create table securepoll_elections on SQLite database as Resolved.
Jul 27 2019, 8:08 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, MediaWiki-extensions-SecurePoll

Jul 25 2019

Mainframe98 committed rEOTP9fd5ce902ab9: Use IDatabase::selectSQLText for the sub query (authored by Mainframe98).
Use IDatabase::selectSQLText for the sub query
Jul 25 2019, 2:03 PM

Jul 19 2019

Mainframe98 added a comment to T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions.

I've also updated https://www.mediawiki.org/wiki/Phabricator/Differential with instructions on how to create changes without using arcanist.

Jul 19 2019, 5:20 PM · Phabricator
Mainframe98 requested review of D1151: Remove unused file CustomLoginHandler.
Jul 19 2019, 5:16 PM · Wikimedia-Phabricator-Extensions
Mainframe98 claimed T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions.

There's also https://phabricator.wikimedia.org/differential/diff/create/, in which you can paste a diff, which is how I created D1151.

Jul 19 2019, 5:02 PM · Phabricator
Mainframe98 added a revision to T223926: Phabricator login page does not show Welcome text / "Click button below" text anymore: D1151: Remove unused file CustomLoginHandler.
Jul 19 2019, 5:00 PM · Developer-Advocacy (Jul-Sep 2019), Regression, Phabricator
Mainframe98 added a revision to T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions: D1151: Remove unused file CustomLoginHandler.
Jul 19 2019, 5:00 PM · Phabricator

Jul 18 2019

Mainframe98 updated the task description for T228367: Archive the ViewFiles extension.
Jul 18 2019, 8:54 AM · translatewiki.net, Patch-For-Review, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup

Jul 17 2019

Mainframe98 created T228264: Viewing php extensions on libup's package overview results in an 500 Internal Server Error.
Jul 17 2019, 9:46 AM · LibUp

Jul 16 2019

Mainframe98 added a comment to T228148: Convert Convert2Wiki to use extension registration.

I've created T228198: Archive the Convert2Wiki extension.

Jul 16 2019, 6:19 PM · Patch-For-Review, MediaWiki-extensions-Other
Mainframe98 created T228198: Archive the Convert2Wiki extension.
Jul 16 2019, 6:18 PM · User-MarcoAurelio, Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 added a comment to T228148: Convert Convert2Wiki to use extension registration.

I did an install and found the following issues, that make me advise archival:

  • I18n, while present, is not loaded, resulting in ⧼convert2wiki⧽ shown.
  • The special page itself is not translatable, the text is hardcoded in Convert2WikiSpecial.php.
  • Rather than adding all necessary classes to the MediaWiki autoloader, this extension manually registers a new autoloader to load its classes, in a weird way that isn't obvious to me why you'd do that. There is no comment indicating why.
  • Usage of deprecated global $wgAjaxExportList.
  • No maintenance or updates have been done after the initial import.
  • Only reported usage is a 1.26 wiki.
  • Dropdowns on Special:Convert2Wiki do not work.
  • Console reports TypeError: Cannot read property 'wikiScript' of undefined at convert2wiki.js:48
  • The special page does not work at all, no submit button or anything. It seems to rely on the JavaScript component to do anything, making it unfriendly to users without JavaScript.
  • Unit tests aren't auto-discovered, nor manually registered. It does have tests, but those aren't run by the CI. The tests themselves fail, there is a broken method call in Convert2Wiki\Formats\Text.
Jul 16 2019, 6:09 PM · Patch-For-Review, MediaWiki-extensions-Other

Jul 12 2019

Mainframe98 added a comment to T227843: Deprecate AbuseFilter's support for Zero.

Mediawiki.org had one filter, which I've marked as deleted: https://www.mediawiki.org/wiki/Special:AbuseFilter/50.

Jul 12 2019, 7:07 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-notice, WikimediaMessages, Technical-Debt, AbuseFilter

Jul 11 2019

Mainframe98 updated the task description for T227731: Archive ZeroPortal and ZeroBanner.
Jul 11 2019, 7:47 AM · translatewiki.net, ZeroPortal, ZeroBanner, MediaWiki-extensions-General, Repository-Admins, Technical-Debt
Mainframe98 added a project to T227731: Archive ZeroPortal and ZeroBanner: translatewiki.net.
Jul 11 2019, 7:47 AM · translatewiki.net, ZeroPortal, ZeroBanner, MediaWiki-extensions-General, Repository-Admins, Technical-Debt

Jul 2 2019

Mainframe98 awarded T191035: MediaWiki core @Database tests failure with sqlite a Party Time token.
Jul 2 2019, 11:00 AM · SQLite, MediaWiki-Core-Testing

Jun 27 2019

Mainframe98 added a project to T226690: Monobook – the three symbols User-page / your alerts / your notices: MonoBook.
Jun 27 2019, 7:02 AM · Growth-Team, Notifications, MonoBook

Jun 24 2019

Mainframe98 added a project to T226433: Install Extension:Newsletter on Meta: Wikimedia-Extension-setup.
Jun 24 2019, 5:39 PM · Community-consensus-needed, Wikimedia-Site-requests, Wikimedia-Extension-setup, Wiktionary

Jun 21 2019

Mainframe98 updated the task description for T226149: Archive the FirstSteps extension.
Jun 21 2019, 10:12 PM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Restricted Application added a project to T226249: Cannot close "Custom Policy" dialog window when viewing policy of an OAuth application; no "Close" button displayed: Upstream.
Jun 21 2019, 11:06 AM · Phabricator (2019-08-22), Upstream

Jun 20 2019

Mainframe98 moved T226149: Archive the FirstSteps extension from Backlog to delete on the GitHub-Mirrors board.
Jun 20 2019, 9:16 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 moved T226149: Archive the FirstSteps extension from Backlog to Cleanup / Archival on the Repository-Admins board.
Jun 20 2019, 9:16 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 moved T226149: Archive the FirstSteps extension from Untriaged to Archive extensions on the Cleanup board.
Jun 20 2019, 9:15 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 updated the task description for T226149: Archive the FirstSteps extension.
Jun 20 2019, 8:22 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 added a project to T226149: Archive the FirstSteps extension: translatewiki.net.
Jun 20 2019, 7:57 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 claimed T226149: Archive the FirstSteps extension.

I couldn't find any uses on WikiApiary: https://wikiapiary.com/wiki/Extension:FirstSteps. Googling the extension description didn't turn up anything either.

Jun 20 2019, 7:52 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup

Jun 18 2019

Mainframe98 closed T225991: Archive the PureWikiDeletion extension as Resolved.

Thanks for the help @MarcoAurelio!

Jun 18 2019, 1:34 PM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 updated the task description for T225991: Archive the PureWikiDeletion extension.
Jun 18 2019, 1:33 PM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 updated the task description for T225991: Archive the PureWikiDeletion extension.
Jun 18 2019, 12:39 PM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 updated the task description for T225991: Archive the PureWikiDeletion extension.
Jun 18 2019, 11:07 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 updated the task description for T225991: Archive the PureWikiDeletion extension.
Jun 18 2019, 10:47 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 edited projects for T225984: Allow defining account creation limits for specific groups (e.g. extended-confirmed accounts), added: MediaWiki-Configuration; removed Wikimedia-Site-requests.

Then I'm most likely mistaken - I probably confused wgAccountCreationThrottle with wgRateLimits - I'll restore MediaWiki-Configuration as project, as it's becoming pretty clear that this is a request for a new feature, not a change to existing configuration. Apologies for the confusion!

Jun 18 2019, 10:08 AM · MediaWiki-Configuration, MediaWiki-User-login-and-signup
Mainframe98 added a comment to T225982: Add option so that "checkmatrix" only allows a user to check one response.

Isn't this exactly what a radio button does?

Jun 18 2019, 9:45 AM · MediaWiki-HTMLForm
Mainframe98 moved T225991: Archive the PureWikiDeletion extension from Backlog to Cleanup / Archival on the Repository-Admins board.
Jun 18 2019, 8:28 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 moved T225991: Archive the PureWikiDeletion extension from Backlog to delete on the GitHub-Mirrors board.
Jun 18 2019, 8:28 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 moved T225991: Archive the PureWikiDeletion extension from Untriaged to Archive extensions on the Cleanup board.
Jun 18 2019, 8:28 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 updated the task description for T225991: Archive the PureWikiDeletion extension.
Jun 18 2019, 8:27 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 closed T25843: Add another argument in SpecialRandompage.php to allow exclusion of blank pages as Declined.

There have been no additional requests for this feature, and the extension this was requested for is archived: T225991: Archive the PureWikiDeletion extension.

Jun 18 2019, 8:08 AM · MediaWiki-Special-pages
Mainframe98 closed T146165: PureWikiDeletion should not use deprecated WikiPage::getAutosummary() as Declined.

This extension no longer works. Should we fix bugs related to this?

Jun 18 2019, 8:07 AM · Technical-Debt, MediaWiki-ContentHandler
Mainframe98 updated the task description for T225991: Archive the PureWikiDeletion extension.
Jun 18 2019, 8:05 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 created T225991: Archive the PureWikiDeletion extension.
Jun 18 2019, 7:53 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 edited projects for T225984: Allow defining account creation limits for specific groups (e.g. extended-confirmed accounts), added: Wikimedia-Site-requests; removed MediaWiki-Configuration.
Jun 18 2019, 7:11 AM · MediaWiki-Configuration, MediaWiki-User-login-and-signup

Jun 15 2019

Mainframe98 added a project to T225865: tools.wmflabs.org/pageviews data corrupted: Tool-Pageviews.
Jun 15 2019, 1:43 PM · Tool-Pageviews
Mainframe98 added a comment to T225571: Add MessageWidget for block user messages (error, warning, success or notice).

Will there also be a PHP variant of this widget?

Jun 15 2019, 10:22 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.0)

Jun 13 2019

Mainframe98 updated subscribers of T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.
  • Look at the PHPUnit "Test Report" for a commit and sort the root by duration. Find the slowest ones and look at its test suite to look for ways to improve it.
Jun 13 2019, 5:49 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Testing, Continuous-Integration-Config

Jun 12 2019

Mainframe98 edited projects for T225593: Allow defining a specific frame for video file thumbnail, on demand, added: Wikimedia-Video; removed Social-Tools, Video (non-WMF).
Jun 12 2019, 8:28 AM · Wikimedia-Video
Mainframe98 added a project to T225585: Unable to open user sub pages with trailing space (Blank page fatal: "invalid DB key"): Wikimedia-production-error.
Jun 12 2019, 5:25 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Core Platform Team Workboards (Team 3), WikiLove, Growth-Team, Wikimedia-production-error

Jun 11 2019

Mainframe98 renamed T225495: Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet from Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet. to Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet.
Jun 11 2019, 10:51 AM · Zuul, Continuous-Integration-Infrastructure
Mainframe98 created T225495: Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet.
Jun 11 2019, 10:40 AM · Zuul, Continuous-Integration-Infrastructure

Jun 8 2019

Mainframe98 committed rEOTPad98876dc178: Build: commit package-lock.json (authored by Mainframe98).
Build: commit package-lock.json
Jun 8 2019, 4:58 PM
Mainframe98 added a comment to T225359: MobileFrontend throws ConfigException when loading JS.

Probably the same as T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'" - Likely already fixed in master, just needs a backport.

Jun 8 2019, 4:50 PM · Anti-Harassment, Readers-Web-Backlog (Tracking), Patch-For-Review, MobileFrontend

May 30 2019

Mainframe98 renamed T224690: Archive the DarkMode extension from Archive the <name of extension/skin> to Archive the DarkMode extension.
May 30 2019, 6:57 PM · MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 created T224690: Archive the DarkMode extension.
May 30 2019, 6:56 PM · MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup

May 29 2019

Mainframe98 added a comment to T224524: Various pages (Special:Contributions, Special:WhatLinksHere) shows autocomplete / search suggestions dropdown on page load.

Regression caused by rMW72f61f7a5930: jquery.suggestions: Trigger keypress on initializing.

May 29 2019, 7:35 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Search, Discovery-Search, MediaWiki-Special-pages, Regression

May 23 2019

Mainframe98 added a comment to T224184: Diffusion: rMW does not update anymore.

See T151070: Move Phabricator from PHP 7.0 to PHP 7.2 for tasks related to the move.

May 23 2019, 9:43 AM · Repository-Admins, Diffusion
Mainframe98 closed T224184: Diffusion: rMW does not update anymore as Invalid.

Seems to work now. I assume the move to phab1003 functioned as the restart it needed.

May 23 2019, 6:17 AM · Repository-Admins, Diffusion

May 22 2019

Mainframe98 created T224184: Diffusion: rMW does not update anymore.
May 22 2019, 7:45 PM · Repository-Admins, Diffusion
Mainframe98 removed a project from T160783: The page language for user js/css sub pages can be modified without the edituserjs/css right: Patch-For-Review.
May 22 2019, 9:35 AM · MediaWiki-General
Mainframe98 removed a project from T215129: Assignment to a class variable in an anonymous class incorrectly triggers MediaWiki.Usage.AssignmentInReturn.AssignmentInReturn: Patch-For-Review.
May 22 2019, 9:34 AM · MediaWiki-Codesniffer

May 21 2019

Mainframe98 closed T223979: Minus-X documentation does not state directories ignored by default as Resolved.
May 21 2019, 6:17 PM · Documentation, MinusX
Mainframe98 committed R2151:89b8bc9855af: Mention always ignored directories in the readme (authored by Mainframe98).
Mention always ignored directories in the readme
May 21 2019, 1:13 PM
Mainframe98 claimed T223979: Minus-X documentation does not state directories ignored by default.
May 21 2019, 11:35 AM · Documentation, MinusX
Mainframe98 created T223979: Minus-X documentation does not state directories ignored by default.
May 21 2019, 11:01 AM · Documentation, MinusX
Mainframe98 added a project to T223960: Add email address to specific user account on en.wikipedia: Wikimedia-Site-requests.
May 21 2019, 9:01 AM · User-Urbanecm, Trust-and-Safety, Wikimedia-Site-requests

May 16 2019

Mainframe98 merged T223451: PHP Fatal Error: Call to undefined method MediaWiki\MediaWikiServices::getAssociated() into T223440: Special:Contributions on meta.wikimedia.org: associated=1: "PHP fatal error: Call to undefined method MediaWiki\MediaWikiServices::getAssociated()".
May 16 2019, 6:26 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Regression, MediaWiki-Special-pages
Mainframe98 merged task T223451: PHP Fatal Error: Call to undefined method MediaWiki\MediaWikiServices::getAssociated() into T223440: Special:Contributions on meta.wikimedia.org: associated=1: "PHP fatal error: Call to undefined method MediaWiki\MediaWikiServices::getAssociated()".
May 16 2019, 6:26 PM · MediaWiki-General, Wikimedia-production-error

May 13 2019

Mainframe98 merged T223020: Deleted Flow discussions should be visible for admins on Special:DeletedContributions in fr-wiki into T118024: When deleting StructuredDiscussion content, deleted content is misattributed to the sysop that deleted it.
May 13 2019, 10:41 AM · Growth-Team, Collaboration-Team-Triage, StructuredDiscussions
Mainframe98 merged task T223020: Deleted Flow discussions should be visible for admins on Special:DeletedContributions in fr-wiki into T118024: When deleting StructuredDiscussion content, deleted content is misattributed to the sysop that deleted it.
May 13 2019, 10:41 AM · Growth-Team, StructuredDiscussions
Mainframe98 added a comment to T223082: Phan should object to @return that doesn't have a return.

Can't we implement this in MediaWiki-Codesniffer instead? That's faster to run, and the check is fairly simplistic - verify that the method contains T_RETURN or T_YIELD when the accompanying docblock contains @return.

May 13 2019, 10:24 AM · Patch-For-Review, MediaWiki-Core-Testing, phan

May 12 2019

Mainframe98 merged T223035: File information missing into T222935: HttpRequestFactory get method always return null (was: All local file description pages pointing to Commons do not display description locally from 1.34.0-wmf.4).
May 12 2019, 1:14 PM · User-notice, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, WMF-Legal, WikibaseMediaInfo, Regression, Multimedia, Commons, Chinese-Sites, MediaWiki-File-management
Mainframe98 merged task T223035: File information missing into T222935: HttpRequestFactory get method always return null (was: All local file description pages pointing to Commons do not display description locally from 1.34.0-wmf.4).
May 12 2019, 1:14 PM

May 8 2019

Mainframe98 added a comment to T222786: proc_open() - Memory allocation problem.

Not related to a specific extension, the same is happening for XAnalytics: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/XAnalytics/+/508684.
This has to do with some out of memory issues with Phan: T219114: phan 1.2.6 is OOMing on MediaWiki core.

May 8 2019, 12:03 PM · phan
Mainframe98 committed rEOTPe10be0673afd: Drop jsonlint (authored by Mainframe98).
Drop jsonlint
May 8 2019, 10:18 AM