Page MenuHomePhabricator
Feed Advanced Search

Today

hashar triaged T225025: Request new Flavor for integration Cloud VPS project as Normal priority.
Wed, Jun 19, 1:14 PM · Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure, Cloud-VPS (Quota-requests)
hashar updated subscribers of T225025: Request new Flavor for integration Cloud VPS project.

@Andrew @aborrero can you possibly bring that up at the next quota meeting please? It is merely to save a bit of RAM we do not need :]

Wed, Jun 19, 1:14 PM · Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure, Cloud-VPS (Quota-requests)
hashar closed T197875: LoadError when running selenium-WikibaseLexeme-chrome Jenkins job as Resolved.

The ruby/mediawiki selenium job has been removed in favor of a NodeJS one: https://integration.wikimedia.org/ci/job/selenium-daily-beta-WikibaseLexeme/

Wed, Jun 19, 9:21 AM · wikidata-tech-focus, Wikidata, Lexicographical data
hashar closed T197875: LoadError when running selenium-WikibaseLexeme-chrome Jenkins job, a subtask of T194252: Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata, as Resolved.
Wed, Jun 19, 9:21 AM · MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), MediaWiki-Core-Testing, Patch-For-Review, Wikidata-Turtles-Sprint #5, Lexicographical data, Wikidata
hashar added a comment to T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.

I merged all integration/config patches that were still pending.

Wed, Jun 19, 9:20 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Core-Testing, Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar updated the task description for T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.
Wed, Jun 19, 9:18 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Core-Testing, Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar updated the task description for T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.
Wed, Jun 19, 9:14 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Core-Testing, Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar added a comment to T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.

https://integration.wikimedia.org/ci/job/selenium-daily-beta-AdvancedSearch/1/console deployed

Wed, Jun 19, 9:08 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-Core-Testing, Patch-For-Review, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar updated subscribers of T226078: releng/quibble-fresnel container requires Firefox to be installed in order to launch Chromium.

The reason is that it uses puppeteer which download chromium but obviously fail to install the dependencies :-\ There are a few ways to solve that:

Wed, Jun 19, 8:28 AM · Patch-For-Review, Continuous-Integration-Infrastructure, Performance-Team, Fresnel
hashar updated the task description for T226078: releng/quibble-fresnel container requires Firefox to be installed in order to launch Chromium.
Wed, Jun 19, 8:18 AM · Patch-For-Review, Continuous-Integration-Infrastructure, Performance-Team, Fresnel
Restricted Application added a project to T226078: releng/quibble-fresnel container requires Firefox to be installed in order to launch Chromium: Performance-Team.
Wed, Jun 19, 8:13 AM · Patch-For-Review, Continuous-Integration-Infrastructure, Performance-Team, Fresnel
hashar removed a project from T208988: Fix Flow random test failures: Continuous-Integration-Config.
Wed, Jun 19, 7:56 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team, Patch-For-Review, User-kostajh, StructuredDiscussions
hashar added a comment to T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones.

Argh that is due to me not adding a file in git bah :-\

Wed, Jun 19, 7:22 AM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
hashar closed T225940: [Discussion] Disable whitelisted-user automated testing, unless requested. as Declined.

I am being bold here and declining based on the proposal being a not so nice user experience. That adds way more manual steps when people have been used to get feedback automatically, and the tests will be run anyway, just that they will be run delayed. So that does not change much.

Wed, Jun 19, 7:20 AM · Continuous-Integration-Infrastructure
hashar added a comment to T225628: On CI, stop testing MediaWiki with php7.0.

The discussion here amounts to dropping support retroactively in existing releases which were released with that support.

Wed, Jun 19, 7:17 AM · TechCom, Continuous-Integration-Config
hashar added a comment to T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel.

There are a few gotchas though. Some testsuite define tests which would not be found by globbing files. Typically the parser tests. There are also alternative ways to register test files via the UnitTest hook.

Wed, Jun 19, 7:05 AM · Continuous-Integration-Config, MediaWiki-Core-Testing

Yesterday

hashar closed T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones as Resolved.
Tue, Jun 18, 8:51 PM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
hashar added a comment to T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones.

Should be good hopefully.

Tue, Jun 18, 8:51 PM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
hashar added a comment to T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones.

Will build the following images:

  • docker-registry.discovery.wmnet/releng/php72:0.2.0
  • docker-registry.discovery.wmnet/releng/composer-php72:0.2.0
  • docker-registry.discovery.wmnet/releng/php72-compile:0.2.0
  • docker-registry.discovery.wmnet/releng/mediawiki-phan:0.3.0
  • docker-registry.discovery.wmnet/releng/quibble-stretch-php72:0.0.31-5
  • docker-registry.discovery.wmnet/releng/quibble-coverage:0.0.31-5
  • docker-registry.discovery.wmnet/releng/composer-test-php72:0.2.0
  • docker-registry.discovery.wmnet/releng/quibble-fresnel:0.0.31-7
  • docker-registry.discovery.wmnet/releng/composer-package-php72:0.2.0
Tue, Jun 18, 7:52 PM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
hashar added a comment to T226005: mwext-php70-phan-docker fails for WikibaseCirrusSearch.

Thank you for the debugging/fix up! :-]

Tue, Jun 18, 7:16 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), Wikidata, CirrusSearch, Discovery-Search
hashar added a comment to T226040: quibble-coverage docker image fails at mysql_install_db step.

Reproducible using:

docker run --rm -it --entrypoint=bash docker-registry.wikimedia.org/releng/quibble-coverage:0.0.31-1
Tue, Jun 18, 6:58 PM · Patch-For-Review, Continuous-Integration-Infrastructure
hashar updated the task description for T226040: quibble-coverage docker image fails at mysql_install_db step.
Tue, Jun 18, 6:55 PM · Patch-For-Review, Continuous-Integration-Infrastructure
hashar updated the task description for T226040: quibble-coverage docker image fails at mysql_install_db step.
Tue, Jun 18, 6:39 PM · Patch-For-Review, Continuous-Integration-Infrastructure
hashar added a comment to T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones.

That is merely to have the MediaWiki tests to use the same package that Wikimedia is using. So I have scoped it to just php7.2 for now :-]

Tue, Jun 18, 3:39 PM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
hashar created T226028: CI uses PHP7.2 packages from sury.org instead of SRE ones.
Tue, Jun 18, 3:23 PM · Release-Engineering-Team (Kanban), PHP 7.2 support, Continuous-Integration-Infrastructure
hashar added a comment to T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball.

I will mess a bit more with the jobs triggered for mediawiki/vendor.git. It is a bit messy right now.

Tue, Jun 18, 2:27 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), Continuous-Integration-Config, CX-deployments, AbuseFilter
hashar edited projects for T204125: Run less tests when a patch is in WIP mode in Gerrit, added: Continuous-Integration-Infrastructure, Zuul, Upstream; removed Continuous-Integration-Config.

I have checked the code, Zuul does not have support for Gerrit wip status. For a wip change, gerrit query yields:

{
   "wip" : true,
   "open" : true,
   "status" : "NEW",
}
Tue, Jun 18, 2:10 PM · Upstream, Zuul, Continuous-Integration-Infrastructure, User-Addshore
hashar added a comment to T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball.

I have send dummy changes against REL1_33 and also triggered the php jobs by commenting check php:

Tue, Jun 18, 1:56 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), Continuous-Integration-Config, CX-deployments, AbuseFilter
hashar updated subscribers of T160990: deployment-ms-be03.deployment-prep and deployment-ms-be04.deployment-prep have high load / system CPU.

I have abandoned the years old patch which was doing too much at the same time. Instead I have split it up in small atomic chunks which should be easier to review/deploy for production.

Tue, Jun 18, 1:16 PM · Release-Engineering-Team (Kanban), RelEng-Archive-FY201718-Q1, Patch-For-Review, media-storage, Beta-Cluster-Infrastructure
hashar triaged T225979: Code-Review and Verified votes can be removed from changes after they are merged as Low priority.

At least the reviews notes are still correct:

$ fetch origin refs/notes/review:refs/notes/review
$ git log -n1 --format=%N --notes=review a13c86033723dddbec6f615d7a137dab28133591Code-Review+2: Bartosz Dziewoński <matma.rex@gmail.com>
Verified+2: jenkins-bot
Submitted-by: jenkins-bot
Submitted-at: Tue, 18 Jun 2019 00:03:39 +0000
Reviewed-on: https://gerrit.wikimedia.org/r/517459
Project: VisualEditor/VisualEditor
Branch: refs/heads/master
Tue, Jun 18, 12:55 PM · Gerrit
hashar updated the task description for T226005: mwext-php70-phan-docker fails for WikibaseCirrusSearch.
Tue, Jun 18, 11:21 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), Wikidata, CirrusSearch, Discovery-Search
hashar added a comment to T217018: Upgrade Wikibase extension to use newer phan.

The ElasticSearch stubs added to Wikibase cause phan to fail for WikibaseCirrusSearch. Got filled as T226005

Tue, Jun 18, 11:19 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Campsite (Wikidata-TechDebt-Exploration), Wikidata, phan
hashar added a comment to T225796: Wikibase and Lexeme browser tests are failing with `failed-save: The save has failed.`.

Thank you, very well done :]

Tue, Jun 18, 8:39 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), User-zeljkofilipin, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Mon, Jun 17

Krinkle awarded T225955: Document Zuul problems caused by force merge a Orange Medal token.
Mon, Jun 17, 5:26 PM · Documentation, Release-Engineering-Team (Kanban), Zuul, Continuous-Integration-Infrastructure
hashar added a comment to T225955: Document Zuul problems caused by force merge.

In short Zuul is supposed to handle all the merges and thus it misbehave whenever a change is force merged. A few things on top of my mind:

Mon, Jun 17, 4:43 PM · Documentation, Release-Engineering-Team (Kanban), Zuul, Continuous-Integration-Infrastructure
hashar created T225955: Document Zuul problems caused by force merge.
Mon, Jun 17, 4:36 PM · Documentation, Release-Engineering-Team (Kanban), Zuul, Continuous-Integration-Infrastructure
hashar added a comment to T126611: You've exceeded your rate limit. Please wait some time and try again (ratelimited).

Related is Wikibase tests suddenly failing. T225796#5261867 comes with disabling $wgRateLimits in includes/DevelopmentSettings.php. So if MediaWiki vagrant include that file, that will resolve the issue as well.

Mon, Jun 17, 9:24 AM · MediaWiki-Vagrant
hashar added a comment to T225901: Don't deduplicate archive table on new installs.

Very nice catch to speed up update.php. Not sure why that script takes so long even when the archive table is empty, but that is a side concern.

Mon, Jun 17, 8:55 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MW-1.33-notes, Patch-For-Review, MediaWiki-Core-Testing, Continuous-Integration-Infrastructure, Core Platform Team
hashar removed a watcher for Keyholder: hashar.
Mon, Jun 17, 8:46 AM

Sat, Jun 15

Ejegg awarded T210287: Migrate wikimedia-fundraising-civicrm to a Docker container a Party Time token.
Sat, Jun 15, 5:13 AM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway)

Fri, Jun 14

hashar closed T210285: Migrate selenium-Wikibase-chrome selenium-WikibaseLexeme-chrome to Docker containers as Resolved.

Eventually the job got deleted via T224301

Fri, Jun 14, 1:04 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikidata, Lexicographical data, User-zeljkofilipin, Browser-Tests, Continuous-Integration-Infrastructure (Slipway)
hashar committed rEWATdb89de79aec6: Jenkins job validation (DO NOT SUBMIT) (authored by hashar).
Jenkins job validation (DO NOT SUBMIT)
Fri, Jun 14, 12:35 PM
hashar committed rEBSES09925438a83f: Jenkins job validation (DO NOT SUBMIT) (authored by hashar).
Jenkins job validation (DO NOT SUBMIT)
Fri, Jun 14, 9:20 AM
hashar added a comment to T225710: Error while checking binary files for python shebang.

The code should test whether the first line read from the file is valid_encoding?, else its binary I guess?

Fri, Jun 14, 8:04 AM · Patch-For-Review, Operations, Operations-Software-Development

Thu, Jun 13

hashar added a comment to T225184: CirrusSearch\SearcherTest::testSearchText PHPUnit tests take a while and runs for everyone.

Thank you @dcausse :] Discovery covered its part. The second part is to only run this test when CI is triggered by CirrusSearch, the latest idea is to flag it with @group standalone and we instrument that in CI to skip the test ( T225068#5247536 ).

Thu, Jun 13, 10:06 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Discovery-Search (Current work), CirrusSearch
hashar triaged T225719: HashRingTest::testHashRingKetamaMode takes 3+ seconds as Normal priority.

@aaron indeed the $ketama_test( 1e5 ) is the culprit and lowering it down to 10000 get it down to half a second. Is there any need to verify it against a larger number? Given the test already ran it for 100 entry, I would guess it could result that output, do the md5sum and compare against the expected md5sum from .c code?

Thu, Jun 13, 10:01 PM · MW-1.32-notes, MW-1.33-notes, Performance-Team, MediaWiki-JobQueue, MediaWiki-Core-Testing
hashar added a project to T225735: Cleanup CI puppet manifests: Technical-Debt.

I guess I will do it since I am responsible for almost of the mess that happened there.

Thu, Jun 13, 5:02 PM · Patch-For-Review, Technical-Debt, Release-Engineering-Team, Continuous-Integration-Infrastructure
hashar created T225735: Cleanup CI puppet manifests.
Thu, Jun 13, 5:02 PM · Patch-For-Review, Technical-Debt, Release-Engineering-Team, Continuous-Integration-Infrastructure
hashar added a comment to T224069: Add/reserve a Jenkins node for the pipeline's trigger jobs.

Just so I'm clear, in this instance is it sufficient to change workspace to /mnt/home/jenkins-deploy in the Jenkins config? I see that path exists.

Thu, Jun 13, 4:57 PM · Release-Engineering-Team (Kanban), Release Pipeline
hashar added a comment to T224907: Drop php55 testing support.

Thank you very much!

Thu, Jun 13, 4:55 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure (phase-out-jessie)
hashar reopened T224069: Add/reserve a Jenkins node for the pipeline's trigger jobs as "Open".

The instance is a small one and all most of the disk is used by the / partition. When the extended disk is created, there is only 415MBytes left for `/srv:

$ df -h /srv
Filesystem                          Size  Used Avail Use% Mounted on
/dev/mapper/vd-second--local--disk  484M   41M  415M   9% /srv
Thu, Jun 13, 4:45 PM · Release-Engineering-Team (Kanban), Release Pipeline
hashar closed T170995: Setup a mirror for R language dependencies (CRAN), a subtask of T153856: Add lint/CI to all wikimedia/discovery analytics repositories, as Declined.
Thu, Jun 13, 1:49 PM · Release-Engineering-Team-TODO, Product-Analytics, Patch-For-Review, Discovery-Analysis (Current work), Discovery, Continuous-Integration-Config
hashar closed T170995: Setup a mirror for R language dependencies (CRAN) as Declined.

maybe one day if we look again at R

Thu, Jun 13, 1:49 PM · Release-Engineering-Team-TODO, Product-Analytics, User-Addshore, WMDE-Analytics-Engineering, Discovery-Analysis, Operations, Discovery
hashar closed T223348: Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x as Resolved.

Switched to a Docker container which comes with php 7.0 !

Thu, Jun 13, 1:22 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Continuous-Integration-Config, Fundraising-Backlog
hashar closed T223348: Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x, a subtask of T224906: Drop php56 testing support, as Resolved.
Thu, Jun 13, 1:22 PM · Release-Engineering-Team, Patch-For-Review, Continuous-Integration-Infrastructure
hashar closed T205950: Database busted for CiviCRM tests? as Resolved.

I have no idea what happened nor did I ever plan to investigate. The job is now using a Docker container that initialize and spawn MySQL on start ( T210287 ). So we have a guarantee the state is clean each time the job run!

Thu, Jun 13, 1:21 PM · Release-Engineering-Team-TODO
hashar closed T210287: Migrate wikimedia-fundraising-civicrm to a Docker container as Resolved.

<snip>

One error log caught my eye, but seems to be harmless. I can't imagine the privileges on the /tmp db data directory matters a whit.

2019-06-12 23:35:02 140664573070720 [Warning] Ignoring user change to 'nobody' because the user was set to 'mysql' earlier on the command line
....
/usr/sbin/mysqld: One can only use the --user switch if running as root

Thu, Jun 13, 1:20 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway)
hashar closed T210287: Migrate wikimedia-fundraising-civicrm to a Docker container, a subtask of T205950: Database busted for CiviCRM tests?, as Resolved.
Thu, Jun 13, 1:20 PM · Release-Engineering-Team-TODO
hashar created T225719: HashRingTest::testHashRingKetamaMode takes 3+ seconds.
Thu, Jun 13, 12:08 PM · MW-1.32-notes, MW-1.33-notes, Performance-Team, MediaWiki-JobQueue, MediaWiki-Core-Testing
hashar added a comment to T224899: Fatal error Cannot redeclare wmfLabsSettings() on Beta cluster wikis.

Tldr: someone would need to find a stacktrace or add some debug logging to track InitialiseSettings.php being loaded twice. I would guess the SiteConfiguration callback should not ever be called since the config is supposedly already loaded, but apparently something triggers it

Thu, Jun 13, 9:54 AM · Release-Engineering-Team, Patch-For-Review, Beta-Cluster-Infrastructure, MediaWiki-Configuration
hashar added a comment to T224899: Fatal error Cannot redeclare wmfLabsSettings() on Beta cluster wikis.

From https://logstash-beta.wmflabs.org/app/kibana , that notably happens on the jobrunner but also on a wide range of pages.

Thu, Jun 13, 9:47 AM · Release-Engineering-Team, Patch-For-Review, Beta-Cluster-Infrastructure, MediaWiki-Configuration

Wed, Jun 12

hashar added a comment to T223602: Define variant Wikimedia production config in compiled, static files.

@Ladsgroup what sort of issues have you had with yaml in python? How complicated are the structures you needed to represent?

1- There's no built-in support for yaml in python, you need to install pyyaml and sometimes security issues would have been exposed, like T214560: [CVE-2017-18342] pyyaml vulnerability in netbox deploy repository 2- indentation is tricky and problematic sometimes. You know, like this.

Wed, Jun 12, 9:25 PM · Release-Engineering-Team (Kanban), Epic, serviceops, Continuous-Integration-Config
hashar added a comment to T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.

For jsduck, if a repository is still using it, just break it. It has been obsolete for a few years now and the last commit is from 2013 or 6 years ago. It is time to break! If we want to play it nice, we can have E_YET_ANOTHER_TASK another task that announce Jsduck being dropped and just get rid of it from all repos: https://codesearch.wmflabs.org/search/?q=jsduck&i=nope&files=&repos=

Wed, Jun 12, 9:04 PM · Release-Engineering-Team-TODO, JavaScript, Continuous-Integration-Config
hashar added a comment to T225628: On CI, stop testing MediaWiki with php7.0.

The purpose is two folds:

  • save us from having to maintain some old/obsolete versions of php. Though the Debian maintainer made PHP versions co installable and easier to forward port, it still comes at a price.
  • run less jobs on CI. Having tests for all of hhvm, php 7.0, php 7.1 and php.7.2 use a bit of resources.
Wed, Jun 12, 9:01 PM · TechCom, Continuous-Integration-Config
hashar added a comment to T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.

Most probably all of those repositories can just be upgraded from Node 6 to 10. The conservative way I have been doing for such upgrades is to add a job in the experimental pipeline, trigger the job for all repositories, assert they pass, then switch.

Wed, Jun 12, 8:22 PM · Release-Engineering-Team-TODO, JavaScript, Continuous-Integration-Config
hashar added a comment to T225218: Consider httpd for quibble instead of php built-in server.

I started experimenting with this; I started with Apache then abandoned it because of the difficulties of running as non-root, then tried nginx but that has its own issues with kick off php-fpm and nginx from within Quibble.

Wed, Jun 12, 3:59 PM · Patch-For-Review, Continuous-Integration-Infrastructure, Quibble
hashar added a project to T225451: Remove PHP_BIN from WMF CI job configuration: Technical-Debt.
Wed, Jun 12, 1:33 PM · Technical-Debt, Continuous-Integration-Config, Release-Engineering-Team
hashar added a comment to T225451: Remove PHP_BIN from WMF CI job configuration.

We might still have some old legacy jobs that could still be relying on the php wrapper (the migration was/is tracked by Continuous-Integration-Infrastructure (Slipway)). It is in integration/jenkins.git in bin/php.

Wed, Jun 12, 1:33 PM · Technical-Debt, Continuous-Integration-Config, Release-Engineering-Team
hashar created T225628: On CI, stop testing MediaWiki with php7.0.
Wed, Jun 12, 1:30 PM · TechCom, Continuous-Integration-Config
hashar changed the status of T225495: Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet from Open to Stalled.

That is for Zuul. It does log debug message for the action it takes, but those are not reported back to Gerrit. It is a good idea but our zuul version is frozen and we do not add new features to it. When we come to a newer CI system (which might be the next version of zuul), we will revisit this task.

Wed, Jun 12, 1:21 PM · Zuul, Continuous-Integration-Infrastructure
hashar updated the task description for T225495: Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet.
Wed, Jun 12, 1:11 PM · Zuul, Continuous-Integration-Infrastructure
hashar added a comment to T225112: New phan dependencies significantly slowed down CI tests.

We really need to phase out the list of dependencies being maintained in integration/config.git. Adding phan dependencies on top (via d371e28862ab9cd4d41c847cfdf643b4ad368895) adds more tech debt which we will have to repay soon.

Wed, Jun 12, 1:09 PM · Continuous-Integration-Config, Continuous-Integration-Infrastructure
hashar triaged T225467: Label the DB group PHPunit run differently from the non-DB group PHPunit run, for clarity as Low priority.
Wed, Jun 12, 1:01 PM · Quibble
hashar added a comment to T225467: Label the DB group PHPunit run differently from the non-DB group PHPunit run, for clarity.

Can you clarify? :]

Wed, Jun 12, 1:01 PM · Quibble
hashar merged T225330: Commit package-lock.json files everywhere into T225315: libraryupgrader should commit package-lock.json files.
Wed, Jun 12, 12:50 PM · VPS-project-libraryupgrader
hashar merged task T225330: Commit package-lock.json files everywhere into T225315: libraryupgrader should commit package-lock.json files.
Wed, Jun 12, 12:50 PM · MediaWiki-Core-Testing, Quibble
hashar added a comment to T225330: Commit package-lock.json files everywhere.

Grr there are too many tasks :D

Wed, Jun 12, 12:50 PM · MediaWiki-Core-Testing, Quibble
hashar reopened T225330: Commit package-lock.json files everywhere, a subtask of T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests, as Open.
Wed, Jun 12, 12:49 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin
hashar reopened T225330: Commit package-lock.json files everywhere as "Open".
Wed, Jun 12, 12:49 PM · MediaWiki-Core-Testing, Quibble
hashar added a comment to T225218: Consider httpd for quibble instead of php built-in server.

Would you be able to run the same benchmark for hhvm as well?
hhvm -m server -p 8888 -d "hhvm.static_file.extensions[svg]=image/svg+xml"

Wed, Jun 12, 8:19 AM · Patch-For-Review, Continuous-Integration-Infrastructure, Quibble
hashar moved T225496: Improve caching in CI tests from Backlog to Repo setup on the Continuous-Integration-Config board.

I am not quite sure how MediaWiki selects the caches its is going to use. A few notes:

Wed, Jun 12, 8:00 AM · MW-1.32-notes, MW-1.31-release-notes, MW-1.33-notes, Patch-For-Review, Continuous-Integration-Config, MediaWiki-Core-Testing, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup
hashar edited projects for T225496: Improve caching in CI tests, added: MediaWiki-Core-Testing, Continuous-Integration-Config; removed Continuous-Integration-Infrastructure.
Wed, Jun 12, 7:41 AM · MW-1.32-notes, MW-1.31-release-notes, MW-1.33-notes, Patch-For-Review, Continuous-Integration-Config, MediaWiki-Core-Testing, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), User-Ladsgroup

Tue, Jun 11

hashar removed a project from T223697: Request access to analytics cluster for Alaa Sarhan: Release-Engineering-Team.

Removing Release-Engineering-Team since there is already deployment/logstash access :]

Tue, Jun 11, 1:58 PM · Operations, SRE-Access-Requests
hashar claimed T210287: Migrate wikimedia-fundraising-civicrm to a Docker container.

The new Docker based job can be tested by comment check experimental in Gerrit. To do the actual switch, I would need a couple patches for the civicrm CI entry point:

Tue, Jun 11, 1:53 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway)
hashar added a comment to T210287: Migrate wikimedia-fundraising-civicrm to a Docker container.

More self notes.

Tue, Jun 11, 12:53 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway)
hashar added a comment to T210287: Migrate wikimedia-fundraising-civicrm to a Docker container.

Good news, I have managed to get the PHPUnit tests to pass in a local Docker container!

Tue, Jun 11, 12:50 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway)
hashar added a comment to T225347: When downloading from git using HTTPS: HTTP 500 / GnuTLS recv error (-110).

Since I am not familiar with that specific configuration and there are private data involved (IP address of the machine), I have filled a private task to get more informations form people that knows better than me: T225480

Tue, Jun 11, 8:35 AM · Traffic, Operations, Gerrit
hashar added a comment to T225347: When downloading from git using HTTPS: HTTP 500 / GnuTLS recv error (-110).

The TLS stack is just fine and the query does reach the Apache in front of Gerrit,. The reason is the OVH one is being rejected by our configuration. Or in short it is not a configuration / software stack issue on @Ciencia_Al_Poder machine.

Tue, Jun 11, 8:20 AM · Traffic, Operations, Gerrit
hashar added a project to T225254: Extract zuul-cloner into standalone library: Quibble.

I have embedded it intentionally. Upstream no more ship with a zuul cloner command and all its logic has been stripped out of Zuul itself. Instead they have converted it to an Ansible task. I have thus embedded the command inside Quibble, which also save us from having to rely on an external dependency.

Tue, Jun 11, 7:57 AM · Quibble, Zuul

Sun, Jun 9

hashar added a project to T60189: Tests for LinksUpdate should respect PostgreSQL database constraints: PostgreSQL.
Sun, Jun 9, 6:08 PM · PostgreSQL, MediaWiki-Page-derived-data

Fri, Jun 7

hashar added a comment to P8600 all(imap_unordered()) bad trick.

When sleeper returns None, all() returns on the first sleeper that completes. Thus the output is:

Fri, Jun 7, 9:30 PM · Quibble
hashar created P8600 all(imap_unordered()) bad trick.
Fri, Jun 7, 9:29 PM · Quibble
hashar added a comment to T224673: Automate identifying flaky tests.

I have edited the task description to show comments matching \nrecheck in the database, though the comments are no more in the db since June 2018.

Fri, Jun 7, 11:06 AM · Browser-Tests, Continuous-Integration-Infrastructure, Code-Health
hashar updated the task description for T224673: Automate identifying flaky tests.
Fri, Jun 7, 10:46 AM · Browser-Tests, Continuous-Integration-Infrastructure, Code-Health
hashar added a comment to T225193: CI monitoring to detect flapping tests, especially in unrelated gated extensions.

Another thought: Zuul pipelines can have several reporters. The only one we use for now is the gerrit reporter which send a review back to Gerrit (and eventually with labels vote and submitting the change). There is another one to report over smtp.

Fri, Jun 7, 8:18 AM · Continuous-Integration-Infrastructure
hashar added a comment to T225193: CI monitoring to detect flapping tests, especially in unrelated gated extensions.

OpenStack had a similar need and they wrote a reporter which collect and analyze tests and create a nice report.

Fri, Jun 7, 8:01 AM · Continuous-Integration-Infrastructure
hashar committed rQUIBBLEa663ad60cdff: MediaWiki installation... as command (authored by awight).
MediaWiki installation... as command
Fri, Jun 7, 7:49 AM
hashar committed rQUIBBLEf0ff523faede: MediaWiki installation... as command (authored by awight).
MediaWiki installation... as command
Fri, Jun 7, 7:37 AM
hashar committed rQUIBBLE3c3d43108f33: Npm install as command (authored by awight).
Npm install as command
Fri, Jun 7, 7:31 AM
hashar committed rQUIBBLE27439695b871: Composer and npm test as command (authored by awight).
Composer and npm test as command
Fri, Jun 7, 7:29 AM