Page MenuHomePhabricator
Feed Advanced Search

Fri, May 24

hashar added a comment to T222472: Investigate gerrit session expiration.

As for the size of the disk cache: Gerrit keeps track of logged out sessions apparently. I have explored the H2 database using strings for my user using:

Fri, May 24, 11:45 AM · Release-Engineering-Team, Gerrit
hashar added a comment to T224262: Patch author and owner swapped in gerritbot comments.

I am not sure who maintains Gerrit bot, it seems it always use the commit author as the owner and the committer field for the by action. That does not match the reality though :]

Fri, May 24, 11:09 AM · GerritBot
hashar updated the task description for T224262: Patch author and owner swapped in gerritbot comments.
Fri, May 24, 11:07 AM · GerritBot
hashar added a comment to T223447: AbuseFilter log error on fiwiki: /srv/mediawiki/php-1.34.0-wmf.5/includes/Revision.php:639 Call to a member function getId() on a non-object (null).

As expected, this was fixed by the patch for T187153, which landed in production yesterday with wmf.6 at 13:22UTC. The error rate dropped from ~475/30 mins to a flat 0 at that time.

Fri, May 24, 11:01 AM · User-Daimona, AbuseFilter, Wikimedia-production-error
hashar added a comment to T224033: Fix operations/puppet.git "rebase hell".

(I edited my previous comment since I submitted it before I was done with it)

Fri, May 24, 9:42 AM · Continuous-Integration-Config, Operations
hashar added a comment to T224033: Fix operations/puppet.git "rebase hell".

A few thoughts:

  • None of our CI on ops/puppet provides very strong guarantees of correctness regardless of what we do here. It's possible for the automatic CI to succeed and for puppet-compiler to succeed on every possible host, and yet after merging the actual agent runs on the hosts fail due to an issue not caught by either one.
Fri, May 24, 9:21 AM · Continuous-Integration-Config, Operations
hashar added a comment to T224033: Fix operations/puppet.git "rebase hell".

If I have 2 CRs, chained one on top of another and I +2 both of them because I want to deploy them together, and the first one fails but the second one passes, would the second one be rebased on top of production branch and merged despite the fact that its parent was not merged?
If this is the case this would be a blocker IMHO.

Fri, May 24, 9:05 AM · Continuous-Integration-Config, Operations
hashar committed rODHI3bb9957dba43: Polish up Debian packaging (authored by hashar).
Polish up Debian packaging
Fri, May 24, 8:07 AM

Thu, May 23

hashar added a comment to T221026: Gerrit thread use GC thrashing.

@thcipriani now deserves some well deserved time off after all the madness that task has caused :-]

Thu, May 23, 9:10 PM · VPS-project-codesearch, Patch-For-Review, Release-Engineering-Team, Gerrit
hashar added a comment to T224239: Swagger-router 0.7.3 causes all outgoing HTTP requests to throw 504s.

Some time

Thu, May 23, 8:54 PM · Core Platform Team Kanban (Done with CPT), Services (done), Patch-For-Review, Core Platform Team (Security, stability, performance and scalability (TEC1)), Page Content Service, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog
hashar awarded T224224: [GrowthExperiments] Sessions are disabled for this entry point a Love token.
Thu, May 23, 8:52 PM · Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-Help panel, Wikimedia-production-error
hashar added a comment to T224239: Swagger-router 0.7.3 causes all outgoing HTTP requests to throw 504s.

The way we debug those is usually by looking at the Jenkins build console between the latest good build and the first bad build. Luckily there is a periodic job https://integration.wikimedia.org/ci/job/mobileapps-periodic-test/ which makes it easy to find the good/bad builds.

Thu, May 23, 8:44 PM · Core Platform Team Kanban (Done with CPT), Services (done), Patch-For-Review, Core Platform Team (Security, stability, performance and scalability (TEC1)), Page Content Service, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog
hashar added a comment to T223971: Old cloudvirt (with Intel Xeon) are twice slower than new ones (Intel Sky Lake).

Eventually I found a MediaWiki application server with a CPU older than the one on cloudvirt1006: mw2139.codfw.wmnet has a Xeon CPU E5-2450 0 based on Sandy Bridge.

Thu, May 23, 8:34 PM · cloud-services-team (Kanban), Continuous-Integration-Infrastructure
hashar lowered the priority of T224224: [GrowthExperiments] Sessions are disabled for this entry point from Unbreak Now! to High.

Changing priority, that has been worked for now. Still have to figure out the root cause though :-(

Thu, May 23, 3:35 PM · Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-Help panel, Wikimedia-production-error
hashar added a comment to T223971: Old cloudvirt (with Intel Xeon) are twice slower than new ones (Intel Sky Lake).

Ran it on a couple production host and two of my machines at home:

Thu, May 23, 3:13 PM · cloud-services-team (Kanban), Continuous-Integration-Infrastructure
hashar updated the task description for T223971: Old cloudvirt (with Intel Xeon) are twice slower than new ones (Intel Sky Lake).
Thu, May 23, 3:07 PM · cloud-services-team (Kanban), Continuous-Integration-Infrastructure
hashar added a comment to T223971: Old cloudvirt (with Intel Xeon) are twice slower than new ones (Intel Sky Lake).

Thanks! So the benchmarks on the real hardware looks similar to what I get on the instance. I guess that rules out kvm/qemu/labvirt etc.

Thu, May 23, 2:53 PM · cloud-services-team (Kanban), Continuous-Integration-Infrastructure
hashar updated the task description for T223971: Old cloudvirt (with Intel Xeon) are twice slower than new ones (Intel Sky Lake).
Thu, May 23, 2:53 PM · cloud-services-team (Kanban), Continuous-Integration-Infrastructure
hashar closed T220731: 1.34.0-wmf.6 deployment blockers as Resolved.

Looks like 1.34.0-wmf.6 is mostly fine.

Thu, May 23, 2:29 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar removed a parent task for T224227: php-1.34.0-wmf.6/includes/TemplateParser.php(149) : eval()'d code: syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ')': T220731: 1.34.0-wmf.6 deployment blockers.
Thu, May 23, 2:29 PM · MediaWiki-HTML-Templating, Readers-Web-Backlog, Vector, Parsing-Team, Core Platform Team, PHP 7.2 support, Wikimedia-production-error
hashar removed a subtask for T220731: 1.34.0-wmf.6 deployment blockers: T224227: php-1.34.0-wmf.6/includes/TemplateParser.php(149) : eval()'d code: syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ')'.
Thu, May 23, 2:29 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar added a comment to T224227: php-1.34.0-wmf.6/includes/TemplateParser.php(149) : eval()'d code: syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ')'.

From https://www.php.net/eval eval beahves differently on PHP7:

Thu, May 23, 2:28 PM · MediaWiki-HTML-Templating, Readers-Web-Backlog, Vector, Parsing-Team, Core Platform Team, PHP 7.2 support, Wikimedia-production-error
hashar created T224227: php-1.34.0-wmf.6/includes/TemplateParser.php(149) : eval()'d code: syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ')'.
Thu, May 23, 2:23 PM · MediaWiki-HTML-Templating, Readers-Web-Backlog, Vector, Parsing-Team, Core Platform Team, PHP 7.2 support, Wikimedia-production-error
hashar updated subscribers of T224224: [GrowthExperiments] Sessions are disabled for this entry point.

That seems to be the feature https://www.mediawiki.org/wiki/Growth/Focus_on_help_desk/Help_panel Apparently that only happens on the kowiki. There is no specific referrer URL to blame :/

Thu, May 23, 2:15 PM · Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-Help panel, Wikimedia-production-error
hashar added a comment to T224224: [GrowthExperiments] Sessions are disabled for this entry point.

Apparently the exception bubbles up and cause a message of: Calculating version for "ext.growthExperiments.Help" failed: BadMethodCallException: Sessions are disabled for this entry point

Thu, May 23, 2:02 PM · Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-Help panel, Wikimedia-production-error
hashar updated the task description for T224224: [GrowthExperiments] Sessions are disabled for this entry point.
Thu, May 23, 1:59 PM · Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-Help panel, Wikimedia-production-error
hashar created T224224: [GrowthExperiments] Sessions are disabled for this entry point.
Thu, May 23, 1:47 PM · Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments-Help panel, Wikimedia-production-error
hashar added a comment to T220731: 1.34.0-wmf.6 deployment blockers.

[13:25:28] <logmsgbot> !log hashar@deploy1001 rebuilt and synchronized wikiversions files: all wikis to 1.34.0-wmf.6

Thu, May 23, 1:34 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar added a comment to T220731: 1.34.0-wmf.6 deployment blockers.

@SBisson sorry I have missed T223741 hotfix ( https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/512070/ ). I think I had it has a blocker, you found it to be a duplicate and eventually I have not let it be a blocker since that occurred previously.

Thu, May 23, 1:22 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar updated subscribers of T222200: Run browser tests as part of "npm test" of wikidata/query/gui.

Here is an explanation of the issue @Smalyshev encountered on T219749 as I posted it on https://gerrit.wikimedia.org/r/#/c/integration/config/+/511308/

Thu, May 23, 1:02 PM · Patch-For-Review, Wikimedia-Hackathon-2019, User-zeljkofilipin, Wikidata-Campsite, Wikidata, Continuous-Integration-Infrastructure
hashar added a comment to T223971: Old cloudvirt (with Intel Xeon) are twice slower than new ones (Intel Sky Lake).
  • cloudvirt1006.eqiad.wmnet has 2x 12 cores/24 threads, 384G of ram, and 15000rpm spinning disks on an Ivy Bridge (3rd gen) architecture.
  • cloudvirt1025.eqiad.wmnet has 2x 18 cores/36 threads, 512G of ram, and SSD disks on a Skylake (6th gen) architecture.

    @hashar what is your hoped for outcome here? I'm not sure I understand why you are confused that 5 year old servers (cloudvirt1006) are slower than servers purchased in the last year (cloudvirt1025).
Thu, May 23, 11:37 AM · cloud-services-team (Kanban), Continuous-Integration-Infrastructure
hashar added a comment to T223971: Old cloudvirt (with Intel Xeon) are twice slower than new ones (Intel Sky Lake).

I wonder if there should be two separate sets of flavours, one for each type of host. Probably wouldn't want an instance set up on one type migrated to the other. It sounds like right now if you see docs/examples that say a particular flavour should be used (perhaps on the basis of VCPUs), it's useless due to it actually coming down to the luck of what host you get scheduled on?

Thu, May 23, 11:37 AM · cloud-services-team (Kanban), Continuous-Integration-Infrastructure
hashar closed T224093: [Collections] Fatal error: Call to undefined function wfAjaxCollectionGetItemList() as Resolved.

Thank you @Lucas_Werkmeister_WMDE

Thu, May 23, 9:52 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Collection, Wikimedia-production-error
hashar closed T224093: [Collections] Fatal error: Call to undefined function wfAjaxCollectionGetItemList(), a subtask of T220731: 1.34.0-wmf.6 deployment blockers, as Resolved.
Thu, May 23, 9:52 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar added a comment to T224093: [Collections] Fatal error: Call to undefined function wfAjaxCollectionGetItemList().

Yes that is an internal function that uses to be in /Collections.php has a global function. https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Collection/+/332929/ moved it to a class static method.

Thu, May 23, 9:35 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Collection, Wikimedia-production-error
hashar added a comment to T220731: 1.34.0-wmf.6 deployment blockers.

And I forgot T224093: [Collections] Fatal error: Call to undefined function wfAjaxCollectionGetItemList()

Thu, May 23, 9:23 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar added a subtask for T220731: 1.34.0-wmf.6 deployment blockers: T224093: [Collections] Fatal error: Call to undefined function wfAjaxCollectionGetItemList().
Thu, May 23, 9:23 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar added a parent task for T224093: [Collections] Fatal error: Call to undefined function wfAjaxCollectionGetItemList(): T220731: 1.34.0-wmf.6 deployment blockers.
Thu, May 23, 9:22 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Collection, Wikimedia-production-error
hashar moved T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses) from Untriaged to Found during 1.34-wmf.5 on the Wikimedia-production-error board.
Thu, May 23, 9:18 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
hashar added a comment to T224211: Not Implemented: WikibaseLexeme/src/DataAccess/Store/MediaWikiPageSubEntityMetaDataAccessor.php:42.

(and since that happened last week already, it is imho not a blocker for this week ;))

Thu, May 23, 9:18 AM · Lexicographical data, Wikimedia-production-error, Wikidata
hashar merged T224211: Not Implemented: WikibaseLexeme/src/DataAccess/Store/MediaWikiPageSubEntityMetaDataAccessor.php:42 into T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).
Thu, May 23, 9:17 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
hashar merged task T224211: Not Implemented: WikibaseLexeme/src/DataAccess/Store/MediaWikiPageSubEntityMetaDataAccessor.php:42 into T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses).
Thu, May 23, 9:17 AM · Lexicographical data, Wikimedia-production-error, Wikidata
hashar added a comment to T224211: Not Implemented: WikibaseLexeme/src/DataAccess/Store/MediaWikiPageSubEntityMetaDataAccessor.php:42.

Ah indeed that is a duplicate! I blame myself for not properly searching in Phabricator. I filled it as a child task of the deployment blocker since I just clicked a link that automatically set the blocker task as a parent.

Thu, May 23, 9:17 AM · Lexicographical data, Wikimedia-production-error, Wikidata
Restricted Application added a project to T224211: Not Implemented: WikibaseLexeme/src/DataAccess/Store/MediaWikiPageSubEntityMetaDataAccessor.php:42: Wikidata.
Thu, May 23, 9:12 AM · Lexicographical data, Wikimedia-production-error, Wikidata
hashar updated the task description for T224210: CentralAuthCreateLocalAccountJob throws exception "No atomic section is open (got User::addToDatabase).".
Thu, May 23, 9:01 AM · MediaWiki-Database, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
hashar created T224210: CentralAuthCreateLocalAccountJob throws exception "No atomic section is open (got User::addToDatabase).".
Thu, May 23, 9:00 AM · MediaWiki-Database, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
hashar updated subscribers of T220731: 1.34.0-wmf.6 deployment blockers.

Thanks to @SBisson / @Reedy and @Jdforrester-WMF , FlaggedRevs faulty changes have been reverted and I have upgraded group 1 to 1.34.0-wmf.6.

Thu, May 23, 8:55 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar closed T224124: Special:ProblemChanges on several Wiktionary sites show raw message IDs instead of translated strings as Resolved.

Fixed by @SBisson that reverted FlaggedRevs extension.json for T224116
@Jdforrester-WMF also took care of rebuilding i18n messages.

Thu, May 23, 8:52 AM · Regression, Wiktionary, MediaWiki-extensions-FlaggedRevs
hashar closed T224124: Special:ProblemChanges on several Wiktionary sites show raw message IDs instead of translated strings, a subtask of T220731: 1.34.0-wmf.6 deployment blockers, as Resolved.
Thu, May 23, 8:52 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar closed T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182 as Resolved.

Fixed by @SBisson / reverting extension.json

Thu, May 23, 8:50 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar closed T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182, a subtask of T220731: 1.34.0-wmf.6 deployment blockers, as Resolved.
Thu, May 23, 8:50 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar added a comment to T224033: Fix operations/puppet.git "rebase hell".

@Volans wrote:
I'm assuming that in cases in which the rebase fails because of conflicts or the CI fails after the rebase Jenkins would vote -1 and the patch would be out of the merging queue. Correct me if I'm wrong.

Thu, May 23, 7:17 AM · Continuous-Integration-Config, Operations

Wed, May 22

hashar awarded T192830: Requesting access to production for SWAT deploy for Urbanecm a Like token.
Wed, May 22, 9:41 PM · Patch-For-Review, User-zeljkofilipin, Release-Engineering-Team (Kanban), User-greg, User-Urbanecm, Operations, SRE-Access-Requests
hashar added a comment to T223741: Invalid message parameter CommentStoreComment from EventPresentationModel.php.

I should have searched in Phabricator before filling another task. Thank you @SBisson to have spotted it!

Wed, May 22, 9:38 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Growth-Team (Current Sprint), Patch-For-Review, Notifications, Wikimedia-production-error
hashar added a comment to T144169: Flake8 for python files without extension in puppet repo.

@jbond those OpenStack .original files, I am assuming they are copied verbatim from the upstream project. So one would assume that we would never modify them and that they already have been validated. So I guess it is fine to miss them or eventually explicitly exclude them. We can surely afford a few holes here and there!

Wed, May 22, 9:36 PM · cloud-services-team (Kanban), Patch-For-Review, Operations, Operations-Software-Development
hashar added a comment to T221026: Gerrit thread use GC thrashing.

Regarding the SendEmail thread, it took a while to remember about it but T131189 was about SendEmail having stuck tcp connections eventually blocking the task and thus the thread pool. Alexandros used gdb to close the sockets "manually" :D The task is worth reading.

Wed, May 22, 9:21 PM · VPS-project-codesearch, Patch-For-Review, Release-Engineering-Team, Gerrit
hashar added a comment to T220731: 1.34.0-wmf.6 deployment blockers.

Status update:

Wed, May 22, 4:29 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar added a comment to T224124: Special:ProblemChanges on several Wiktionary sites show raw message IDs instead of translated strings.

https://en.wikinews.org/wiki/Special:ProblemChanges and https://pl.wiktionary.org/wiki/Specjalna:W%C4%85tpliwe_zmiany no more shows the issue after moving back to MediaWiki 1.34.0-wmf.5

Wed, May 22, 4:19 PM · Regression, Wiktionary, MediaWiki-extensions-FlaggedRevs
hashar added a comment to T224124: Special:ProblemChanges on several Wiktionary sites show raw message IDs instead of translated strings.

That might be related to T224116. There is also bab8ea77c7020795cd813cc390e3cbb03ccbb9fd

Wed, May 22, 4:08 PM · Regression, Wiktionary, MediaWiki-extensions-FlaggedRevs
hashar added a comment to T224123: [Echo] PHP Warning: htmlspecialchars() expects parameter 1 to be string, object given.

A spike of those, apparently only on meta.wikimedia.org so far.

Wed, May 22, 2:13 PM · Notifications, Growth-Team, Wikimedia-production-error
hashar created T224123: [Echo] PHP Warning: htmlspecialchars() expects parameter 1 to be string, object given.
Wed, May 22, 2:12 PM · Notifications, Growth-Team, Wikimedia-production-error
hashar renamed T221763: Unable to move page (Special:MovePage&action=submit) Title does not belong to page ID X but actually belong to Y from Unable to move page (Special:MovePage&action=submit) to Unable to move page (Special:MovePage&action=submit) Title does not belong to page ID X but actually belong to Y.
Wed, May 22, 2:06 PM · Core Platform Team Backlog (Next), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), Operations, Wikimedia-production-error, Regression
hashar added a comment to T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.

The error is gone from https://logstash.wikimedia.org/goto/85e59a7e13a40e11c9595c444ea90375 and https://ca.wikinews.org/ is back up.

Wed, May 22, 2:03 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar added a comment to T222628: Some history views and diffs unavailable on Wikipedias (Fatal ParameterAssertionException: Bad value for parameter $dbkey).

There are various code path from extensions or mediawiki/core that ends up hitting the error. It has been added in mediawiki/core by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/504000/

Wed, May 22, 1:58 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), User-notice, MediaWiki-Comment-backend, MediaWiki-History-and-Diffs, Wikimedia-production-error
hashar added a comment to T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty.

Not a blocker since that predate 1.34.0-wmf.6.

Wed, May 22, 1:56 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar removed a subtask for T220731: 1.34.0-wmf.6 deployment blockers: T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty.
Wed, May 22, 1:56 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar removed a parent task for T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty: T220731: 1.34.0-wmf.6 deployment blockers.
Wed, May 22, 1:56 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar added a comment to T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty.

Thank you @Aklapper , I have transfered the informations to the task.

Wed, May 22, 1:56 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar updated the task description for T222628: Some history views and diffs unavailable on Wikipedias (Fatal ParameterAssertionException: Bad value for parameter $dbkey).
Wed, May 22, 1:56 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), User-notice, MediaWiki-Comment-backend, MediaWiki-History-and-Diffs, Wikimedia-production-error
hashar merged task T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty into T222628: Some history views and diffs unavailable on Wikipedias (Fatal ParameterAssertionException: Bad value for parameter $dbkey).
Wed, May 22, 1:55 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar merged T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty into T222628: Some history views and diffs unavailable on Wikipedias (Fatal ParameterAssertionException: Bad value for parameter $dbkey).
Wed, May 22, 1:55 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team Kanban (Doing), Core Platform Team (Decoupling (CDP2)), User-notice, MediaWiki-Comment-backend, MediaWiki-History-and-Diffs, Wikimedia-production-error
hashar added a comment to T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.

I have rolled back cawikinews:

Wed, May 22, 1:46 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar added a comment to T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.

And https://ca.wikinews.org/ get us a Wikimedia error page. Time for a rollback!

Wed, May 22, 1:41 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar triaged T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182 as Unbreak Now! priority.
Wed, May 22, 1:36 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar updated the task description for T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.
Wed, May 22, 1:35 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar merged T224118: 33 Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-1.34.0-wmf.6/includes/GlobalFunctions.php on line 3177 into T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.
Wed, May 22, 1:33 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar merged task T224118: 33 Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-1.34.0-wmf.6/includes/GlobalFunctions.php on line 3177 into T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.
Wed, May 22, 1:33 PM · Wikimedia-production-error
hashar updated the task description for T224118: 33 Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-1.34.0-wmf.6/includes/GlobalFunctions.php on line 3177.
Wed, May 22, 1:30 PM · Wikimedia-production-error
hashar updated the task description for T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.
Wed, May 22, 1:27 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar added a comment to T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.

Only got it on cawikinews so far.

Wed, May 22, 1:24 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar created T224118: 33 Invalid operand type was used: cannot perform this operation with arrays in /srv/mediawiki/php-1.34.0-wmf.6/includes/GlobalFunctions.php on line 3177.
Wed, May 22, 1:23 PM · Wikimedia-production-error
hashar updated the task description for T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.
Wed, May 22, 1:22 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar added a project to T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182: Wikimedia-Site-requests.
Wed, May 22, 1:18 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar created T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.
Wed, May 22, 1:15 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
hashar moved T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
Wed, May 22, 12:14 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), Continuous-Integration-Config, CX-deployments, AbuseFilter
hashar moved T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball from Backlog to In progress on the Continuous-Integration-Config board.
Wed, May 22, 12:14 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), Continuous-Integration-Config, CX-deployments, AbuseFilter
hashar claimed T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball.

https://gerrit.wikimedia.org/r/#/c/integration/config/+/511866 switches CI to only use composer install / composer merge plugin instead of relying on mediawiki/vendor.git

Wed, May 22, 12:13 PM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), Continuous-Integration-Config, CX-deployments, AbuseFilter
hashar added a comment to T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty.

I am not sure whether that one should be a blocker given it already got shipped with the previous version last week (1.34.0-wmf.5).

Wed, May 22, 11:33 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar renamed T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty from [Flow] Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty to Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty.
Wed, May 22, 11:26 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar updated the task description for T224095: Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty.
Wed, May 22, 11:21 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar added a comment to T224094: [ArticlePlaceHolder] on test.wikidata.org, searches cause PHP Notice: Undefined index: QXXXXX.

Not a train blocker, that happened previously and the notice is only found for queries toward test.wikidata.org / test.wikipedia.org

Wed, May 22, 11:17 AM · ArticlePlaceholder, Wikidata, Wikimedia-production-error
hashar removed a subtask for T220731: 1.34.0-wmf.6 deployment blockers: T224094: [ArticlePlaceHolder] on test.wikidata.org, searches cause PHP Notice: Undefined index: QXXXXX.
Wed, May 22, 11:16 AM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
hashar removed a parent task for T224094: [ArticlePlaceHolder] on test.wikidata.org, searches cause PHP Notice: Undefined index: QXXXXX: T220731: 1.34.0-wmf.6 deployment blockers.
Wed, May 22, 11:16 AM · ArticlePlaceholder, Wikidata, Wikimedia-production-error
hashar renamed T224094: [ArticlePlaceHolder] on test.wikidata.org, searches cause PHP Notice: Undefined index: QXXXXX from [ArticlePlaceHolder] search causes PHP Notice: Undefined index: QXXXXX to [ArticlePlaceHolder] on test.wikidata.org, searches cause PHP Notice: Undefined index: QXXXXX.
Wed, May 22, 11:16 AM · ArticlePlaceholder, Wikidata, Wikimedia-production-error
hashar updated the task description for T224099: Request for conduit token of Phabricator_maintenance user.
Wed, May 22, 9:46 AM · Phabricator-Bot-Requests, Phabricator
hashar updated the task description for T224098: [Flow] Flow workflow is for different page.
Wed, May 22, 9:29 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar added a project to T224098: [Flow] Flow workflow is for different page: StructuredDiscussions.
Wed, May 22, 9:29 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar created T224098: [Flow] Flow workflow is for different page.
Wed, May 22, 9:28 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
hashar added a comment to T224096: [JsonConfig] PHP Notice: Cannot access property on non-object.

That is emitted for lines 32 33 34 and 35 of JCApi.php:

30         if ( isset( $conf->store ) ) {
31             $res['store'] = [
32                 'cacheNewValue' => $conf->store->cacheNewValue,
33                 'notifyUrl' => $conf->store->notifyUrl,
34                 'notifyUsername' => $conf->store->notifyUsername !== '', // true or false
35                 'notifyPassword' => $conf->store->notifyPassword !== '', // true or false
36             ];
37         }
Wed, May 22, 9:24 AM · MediaWiki-extensions-JsonConfig, Wikimedia-production-error
hashar created T224096: [JsonConfig] PHP Notice: Cannot access property on non-object.
Wed, May 22, 9:21 AM · MediaWiki-extensions-JsonConfig, Wikimedia-production-error