Page MenuHomePhabricator
Feed Advanced Search

Yesterday

hashar removed a project from T230287: Extension:LinkedWiki is licensed under a non-free CC-NC-BY-SA: Gerrit.
Sat, Aug 17, 9:00 AM · Software-Licensing, MediaWiki-extensions-LinkedWiki

Wed, Jul 31

alaa_wmde awarded T105474: 'recheck' on a CR+2 patch should trigger gate-and-submit, not test a Mountain of Wealth token.
Wed, Jul 31, 2:01 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Upstream, Zuul, Patch-For-Review, Continuous-Integration-Config
hashar closed T203566: ParserOutput cache incompatibility errors in 1.32.0-wmf.20, a subtask of T191066: 1.32.0-wmf.20 deployment blockers, as Resolved.
Wed, Jul 31, 5:21 AM · Release-Engineering-Team (Kanban), Release, Train Deployments
hashar closed T203566: ParserOutput cache incompatibility errors in 1.32.0-wmf.20 as Resolved.

That has hit us again via T229366: serialize(): "" returned as member variable from __sleep() but does not exist but this time we have a test to ensure ParserOutput class signature does not change: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/526575/2/tests/phpunit/includes/parser/ParserOutputTest.php

Wed, Jul 31, 5:21 AM · Core Platform Team (Needs Cleaning - Security, stability, performance and scalability (TEC1)), MediaWiki-Parser, MediaWiki-Cache, Wikimedia-production-error
hashar added a comment to T229366: serialize(): "" returned as member variable from __sleep() but does not exist.

For the record, we frequently hit the issue of corrupted objects when unserializing from a different class signature. Even so that the exact same issue with ParserOutput and has hit us in September 2018 - T203566

Wed, Jul 31, 5:19 AM · Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Cache, Wikimedia-production-error

Mon, Jul 29

hashar added a comment to T229220: Unit tests are not being run for extensions under PHPUnit 4.x (HHVM).

Seems related to the PHPUnit version.

Mon, Jul 29, 7:18 PM · Release-Engineering-Team-TODO, Code-Health, User-kostajh, Code-Health-Metrics, Epic, MediaWiki-Core-Testing
hashar added a comment to T208566: puppet.git rake fails with ruby 2.5.

The Gemfile had Puppet 4.8.2 to match the version provided by Debian Jessie:

Stretch, not jessie. jessie shipped with 3.7.2.

Mon, Jul 29, 9:16 AM · Patch-For-Review, Continuous-Integration-Config, Operations, Puppet

Sun, Jul 28

hashar reopened T208566: puppet.git rake fails with ruby 2.5 as "Open".

The Gemfile had Puppet 4.8.2 to match the version provided by Debian Jessie:

Gemfile
gem 'puppet', ENV['PUPPET_GEM_VERSION'] || '~> 4.8.2'
Sun, Jul 28, 8:17 PM · Patch-For-Review, Continuous-Integration-Config, Operations, Puppet

Sat, Jul 27

hashar committed rESRD17ac5a4bac97: build: bump grunt and drop grunt-cli (authored by hashar).
build: bump grunt and drop grunt-cli
Sat, Jul 27, 11:17 PM

Fri, Jul 26

hashar added a project to T228838: Unreferenced log channels are not logged at all causing "logged" errors to be missed: Release-Engineering-Team.
Fri, Jul 26, 7:29 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Debug-Logger, Release-Engineering-Team, Wikimedia-production-error

Thu, Jul 25

hashar closed T179190: Run Selenium Cucumber tests in CI, a subtask of T190710: Minerva Ruby and Node.js browser tests running side by side, as Resolved.
Thu, Jul 25, 11:24 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Core-Testing, User-zeljkofilipin, User-Jdlrobson, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), MinervaNeue
hashar closed T179190: Run Selenium Cucumber tests in CI, a subtask of T198389: Q1 Selenium framework improvements, as Resolved.
Thu, Jul 25, 11:24 PM · MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar closed T179190: Run Selenium Cucumber tests in CI as Resolved.

Quibble now detects whether a repository has a selenium-test npm script. If so, it runs npm install && npm run-script selenium-test with ChromeDriver enabled.

Thu, Jul 25, 11:24 PM · Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.29-release-notes, MW-1.30-release-notes, MediaWiki-Core-Testing, JavaScript, User-zeljkofilipin
hashar closed T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests, a subtask of T179190: Run Selenium Cucumber tests in CI, as Resolved.
Thu, Jul 25, 11:20 PM · Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.29-release-notes, MW-1.30-release-notes, MediaWiki-Core-Testing, JavaScript, User-zeljkofilipin
hashar closed T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests, a subtask of T190829: Test WikiTextEditor class with browser tests., as Resolved.
Thu, Jul 25, 11:20 PM · WMDE-QWERTY-Spike-2019-07-09, WMDE-QWERTY-Sprint-2019-06-26, WMDE-QWERTY-Sprint-2019-06-12, WMDE-QWERTY-Sprint-2019-05-29, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
hashar closed T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests, a subtask of T198389: Q1 Selenium framework improvements, as Resolved.
Thu, Jul 25, 11:20 PM · MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), User-zeljkofilipin
hashar closed T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests as Resolved.
Thu, Jul 25, 11:20 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar added a comment to T190829: Test WikiTextEditor class with browser tests..

@awight aced the implementation in Quibble . Provided the repository has defined a npm script selenium-test, Quibble will detect it and run the command with Chromedriver running.

Thu, Jul 25, 11:18 PM · WMDE-QWERTY-Spike-2019-07-09, WMDE-QWERTY-Sprint-2019-06-26, WMDE-QWERTY-Sprint-2019-06-12, WMDE-QWERTY-Sprint-2019-05-29, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
hashar added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

Implemented by @awight and released with 0.0.34. I have missed a few things after review and had to add a few hotfixes but overall it seems to be running fine now.

Thu, Jul 25, 11:08 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar closed T229065: Quibble extension selenium test fails with: gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable., a subtask of T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests, as Resolved.
Thu, Jul 25, 11:05 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar closed T229065: Quibble extension selenium test fails with: gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable. as Resolved.

The CI Docker containers missed build-essential and python. Confirmed to be fixed.

Thu, Jul 25, 11:05 PM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar added a comment to T229065: Quibble extension selenium test fails with: gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable..

Tested with:

Thu, Jul 25, 10:48 PM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar claimed T229065: Quibble extension selenium test fails with: gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable..
Thu, Jul 25, 10:25 PM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar created T229065: Quibble extension selenium test fails with: gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable..
Thu, Jul 25, 10:18 PM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar added a parent task for T217113: MediaWiki-Vagrant should use the same Node.js version as Wikimedia production: T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.
Thu, Jul 25, 10:04 PM · User-zeljkofilipin, MediaWiki-Vagrant
hashar added a subtask for T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10: T217113: MediaWiki-Vagrant should use the same Node.js version as Wikimedia production.
Thu, Jul 25, 10:04 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar reopened T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10, a subtask of T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests, as Open.
Thu, Jul 25, 10:03 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar reopened T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10 as "Open".

We still need to restore 'selenium-test' for CirrusSearch (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/525612/)

Thu, Jul 25, 10:03 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar committed rECIR2b3f8bad38bb: build: temporarily rename 'selenium-test' (authored by hashar).
build: temporarily rename 'selenium-test'
Thu, Jul 25, 9:24 PM
hashar committed rECIR997742146db8: build: temporarily rename 'selenium-test' (authored by hashar).
build: temporarily rename 'selenium-test'
Thu, Jul 25, 9:19 PM
hashar removed a project from T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10: MobileFrontend.

Fixed for #MobileFronted

Thu, Jul 25, 9:12 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar added a comment to T217113: MediaWiki-Vagrant should use the same Node.js version as Wikimedia production.

We are now using NodeJS 10. That can be aligned with Wikimedia production by using:

/etc/apt/sources.list.d/wikimedia-node10.list
deb http://apt.wikimedia.org/wikimedia stretch-wikimedia component/node10
#deb-src http://apt.wikimedia.org/wikimedia stretch-wikimedia component/node10
Thu, Jul 25, 6:16 PM · User-zeljkofilipin, MediaWiki-Vagrant
hashar added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

The feature has been implemented by @awight and I have released it today with Quibble 0.0.33 (which is broken so really use 0.0.34).

Thu, Jul 25, 6:13 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar added a parent task for T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10: T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.
Thu, Jul 25, 6:12 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar added a subtask for T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests: T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.
Thu, Jul 25, 6:12 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar renamed T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10 from Quibble 0.0.34: node-gyp fails for extension due to lack of python to wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.
Thu, Jul 25, 6:11 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar added a comment to T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.

We need to use fibers@3.x with NodeJS 10 and thus wdio-cucumber-framework requires an update. That is done by:

Thu, Jul 25, 6:10 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar added a comment to T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.
$ grep wdio-cucumber-framework {extensions,skins}/*/package.json
extensions/CirrusSearch/package.json:		"wdio-cucumber-framework": "1.0.1",
extensions/MobileFrontend/package.json:    "wdio-cucumber-framework": "1.1.1",
skins/MinervaNeue/package.json:		"wdio-cucumber-framework": "2.2.8",
Thu, Jul 25, 6:04 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar added a comment to T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.

I don't know how fibers@3.1.1 works without python but maybe it does not need it or ship a binary.

Thu, Jul 25, 5:59 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar added a comment to T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.

Somehow releng/quibble-stretch-hhvm lacks python :-(

$ docker run --rm -it --entrypoint=python docker-registry.discovery.wmnet/releng/quibble-stretch-hhvm:0.0.34
docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: \"python\": executable file not found in $PATH": unknown.

Same for 0.0.32-1-s2

Thu, Jul 25, 5:47 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar added a comment to T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.

Example https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/20207/console

Thu, Jul 25, 5:38 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar created T229033: wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10.
Thu, Jul 25, 5:37 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), CirrusSearch, Discovery-Search, Patch-For-Review, Quibble
hashar closed T229020: Quibble 0.0.33 fails with No such file or directory: '/workspace/src/vendor/package.json' as Resolved.
Thu, Jul 25, 5:35 PM · Release-Engineering-Team-TODO (201907), Patch-For-Review, Quibble
hashar committed rQUIBBLEff8d86ffca97: package.json/composer.json might not exist! (authored by hashar).
package.json/composer.json might not exist!
Thu, Jul 25, 4:54 PM
hashar created T229020: Quibble 0.0.33 fails with No such file or directory: '/workspace/src/vendor/package.json'.
Thu, Jul 25, 4:25 PM · Release-Engineering-Team-TODO (201907), Patch-For-Review, Quibble
hashar committed rQUIBBLEb2f9e3630466: Run node browser tests in each repo (authored by awight).
Run node browser tests in each repo
Thu, Jul 25, 2:36 PM
hashar moved T213806: Migrate wikimedia-portals-build to Docker container from Backlog to Migration on the Release Pipeline board.
Thu, Jul 25, 7:45 AM · Release-Engineering-Team-TODO, Release Pipeline, Continuous-Integration-Infrastructure (Slipway), Wikimedia-Portals
hashar added projects to T213806: Migrate wikimedia-portals-build to Docker container: Release Pipeline, Release-Engineering-Team-TODO.
Thu, Jul 25, 7:44 AM · Release-Engineering-Team-TODO, Release Pipeline, Continuous-Integration-Infrastructure (Slipway), Wikimedia-Portals
hashar updated the task description for T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.
Thu, Jul 25, 7:32 AM · Release-Engineering-Team-TODO (201908), Release-Engineering-Team (CI & Testing services), JavaScript, Continuous-Integration-Config
hashar added a parent task for T213806: Migrate wikimedia-portals-build to Docker container: T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.
Thu, Jul 25, 7:31 AM · Release-Engineering-Team-TODO, Release Pipeline, Continuous-Integration-Infrastructure (Slipway), Wikimedia-Portals
hashar added a subtask for T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects: T213806: Migrate wikimedia-portals-build to Docker container.
Thu, Jul 25, 7:31 AM · Release-Engineering-Team-TODO (201908), Release-Engineering-Team (CI & Testing services), JavaScript, Continuous-Integration-Config
hashar merged task T228907: Migrate the wikimedia-portals-build timed CI job to node10 into T213806: Migrate wikimedia-portals-build to Docker container.
Thu, Jul 25, 7:31 AM · Release-Engineering-Team-TODO (201907), Continuous-Integration-Config, Wikimedia-Portals
hashar merged T228907: Migrate the wikimedia-portals-build timed CI job to node10 into T213806: Migrate wikimedia-portals-build to Docker container.
Thu, Jul 25, 7:31 AM · Release-Engineering-Team-TODO, Release Pipeline, Continuous-Integration-Infrastructure (Slipway), Wikimedia-Portals

Wed, Jul 24

hashar added a comment to T226945: Decide on future of running Phan tests on release branches.

A real life example https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UserMerge/+/525286/ for REL1_33

Wed, Jul 24, 5:14 PM · Patch-For-Review, Continuous-Integration-Config, phan, MW-1.32-release, MW-1.31-release, MediaWiki-Core-Testing
hashar added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

It took me a few tries to reach out to @awight patch but I have finally managed to do a proper review of https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/510709/ today :] It is almost ready to be merged!

Wed, Jul 24, 3:32 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, MediaWiki-Core-Testing, Quibble, User-zeljkofilipin
hashar committed rQUIBBLE48729695a93d: Split Qunit out of BrowserTest command (authored by hashar).
Split Qunit out of BrowserTest command
Wed, Jul 24, 3:03 PM
hashar committed rQUIBBLEdc5af99b4608: run_selenium depends on a npm script, not a composer one (authored by hashar).
run_selenium depends on a npm script, not a composer one
Wed, Jul 24, 3:03 PM
hashar added a comment to T228848: Remove trailing newline from log messages.

Note that wfDebugLog(); does a trim() on the message anyway :]

Wed, Jul 24, 12:01 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Debug-Logger
hashar closed T228171: InvalidArgumentException: Invalid sort: last_edit_asc=1 as Resolved.

Solved by @EBernhardson . No need to backport to wmf branches since that is a rare occurrence and happened previously. Thank you Erik!

Wed, Jul 24, 10:17 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch, MediaWiki-Search, Wikimedia-production-error
hashar added a comment to T228731: https://dumps.wikimedia.org/other/pageviews/ lacks hourly pageviews since 20190722-17:00.

@JHedden it seems the DNS change has been harmless and the issue came from some of the magic in a oozie job.

Wed, Jul 24, 9:46 AM · Analytics-Kanban, Analytics, cloud-services-team, Wikimedia-Portals
hashar closed T222472: Investigate gerrit session expiration as Resolved.

Output of gerrit show-cache:

Gerrit Code Review        2.15.14-16-g855b179b5f      now    08:37:43   UTC
                                                 uptime    1 days 14 hrs
Wed, Jul 24, 9:00 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit
hashar closed T228381: zuul systemd service: [/lib/systemd/system/zuul.service:15] Failed to parse usec_t value, ignoring: infinity as Resolved.
contint1001:~$ systemctl show zuul|grep TimeoutStopUSec
TimeoutStopUSec=0
Wed, Jul 24, 8:32 AM · Zuul, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201907), Continuous-Integration-Infrastructure
hashar created T228838: Unreferenced log channels are not logged at all causing "logged" errors to be missed.
Wed, Jul 24, 8:26 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Debug-Logger, Release-Engineering-Team, Wikimedia-production-error

Tue, Jul 23

hashar added a comment to T228490: Give access to l10n-bot to wikimedia/iegreview repository.

Thank you @abi_ and @MarcoAurelio :]

Tue, Jul 23, 6:58 PM · User-MarcoAurelio, Wikimedia-IEG-grant-review, Gerrit-Privilege-Requests, Gerrit
hashar added a comment to T227193: Request access to deployment cluster for Jakob_WMDE.

bitte schon \o/

Tue, Jul 23, 4:03 PM · Release-Engineering-Team (Deployment services), Operations, SRE-Access-Requests
hashar added a comment to T227193: Request access to deployment cluster for Jakob_WMDE.

Confirmed to me by @Jakob_WMDE !

Tue, Jul 23, 4:02 PM · Release-Engineering-Team (Deployment services), Operations, SRE-Access-Requests
hashar added a comment to T227193: Request access to deployment cluster for Jakob_WMDE.

https://gerrit.wikimedia.org/r/#/admin/projects/operations/mediawiki-config,access mediawiki-config access are granted via the wmf-deployment Gerrit group.

Tue, Jul 23, 4:01 PM · Release-Engineering-Team (Deployment services), Operations, SRE-Access-Requests
hashar updated subscribers of T228749: AssembleUploadChunksJob triggers: SqlBagOStuff: tries to serialize closure.

The last change to includes/upload/UploadBase.php has been 4a83841fa742eb0b1ebf5ca068a6ba402c63c0f7 by @aaron . The UploadBase::setSessionStatus call from the stack trace shows up in the diff:

       /**
         * The value will be set in cache for 1 day
         *
+        * Avoid triggering this method on HTTP GET/HEAD requests
+        *
         * @param User $user
         * @param string $statusKey
         * @param array|bool $value
         * @return void
         */
        public static function setSessionStatus( User $user, $statusKey, $value ) {
-               $cache = MediaWikiServices::getInstance()->getMainObjectStash();
-               $key = $cache->makeKey( 'uploadstatus', $user->getId() ?: md5( $user->getName() ), $statusKey );
+               $store = self::getUploadSessionStore();
+               $key = self::getUploadSessionKey( $store, $user, $statusKey );
Tue, Jul 23, 1:09 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Core Platform Team (Needs Cleaning - Code Health (TEC13)), Core Platform Team Workboards (Clinic Duty Team), Multimedia, MediaWiki-Uploading, Wikimedia-production-error
hashar renamed T228749: AssembleUploadChunksJob triggers: SqlBagOStuff: tries to serialize closure from SqlBagOStuff: tries to serialize closure to AassembleUploadChunks triggers: SqlBagOStuff: tries to serialize closure.
Tue, Jul 23, 1:04 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Core Platform Team (Needs Cleaning - Code Health (TEC13)), Core Platform Team Workboards (Clinic Duty Team), Multimedia, MediaWiki-Uploading, Wikimedia-production-error
hashar updated the task description for T228746: mw.config empty on some pages due to non-UTF8 data from LuaSandbox.
Tue, Jul 23, 1:01 PM · Core Platform Team Workboards (Clinic Duty Team), LuaSandbox, MediaWiki-extensions-Scribunto, Wikimedia-production-error
hashar removed a subtask for T220740: 1.34.0-wmf.15 deployment blockers: Unknown Object (Task).
Tue, Jul 23, 10:25 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Deployment services), Release, Train Deployments
hashar updated subscribers of T220740: 1.34.0-wmf.15 deployment blockers.
In T228462#5355073, @Anomie wrote:
In T228462#5355028, @Krinkle wrote:

The train has gone out again a few hours ago. Has the issue come back? Should we rollback again?

It does not appear to have returned, revisions in revision missing from cu_changes are within the historical ranges of <1% per hour over the past few hours.

Tue, Jul 23, 10:24 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Deployment services), Release, Train Deployments
hashar added a comment to T228733: Add more SREs to gerritadmin LDAP group.

The change has been done after T218761 (private).

Tue, Jul 23, 9:09 AM · Release-Engineering-Team-TODO, Release-Engineering-Team (Development services), Gerrit, LDAP-Access-Requests, Operations
hashar renamed T228731: https://dumps.wikimedia.org/other/pageviews/ lacks hourly pageviews since 20190722-17:00 from https://dumps.wikimedia.org/other/pageviews/ lacks hourly pageviews since 20190722-16:00 to https://dumps.wikimedia.org/other/pageviews/ lacks hourly pageviews since 20190722-17:00.
Tue, Jul 23, 9:02 AM · Analytics-Kanban, Analytics, cloud-services-team, Wikimedia-Portals
hashar added a comment to T228731: https://dumps.wikimedia.org/other/pageviews/ lacks hourly pageviews since 20190722-17:00.

The DNS change is f4c51db24a4953eb4b24b3480b555ad5cf61b219 Mon Jul 22 16:31:01 2019 +0000

templates/wikimedia.org
@@ -80,7 +80,7 @@ ns2.corp    1H  IN A    198.73.209.16
 ; interactions with selective CN censorhsip at the DNS level)
 dyna            600 IN DYNA geoip!text-addrs
Tue, Jul 23, 9:01 AM · Analytics-Kanban, Analytics, cloud-services-team, Wikimedia-Portals
hashar added a project to T228731: https://dumps.wikimedia.org/other/pageviews/ lacks hourly pageviews since 20190722-17:00: Analytics.
Tue, Jul 23, 8:49 AM · Analytics-Kanban, Analytics, cloud-services-team, Wikimedia-Portals
hashar created T228731: https://dumps.wikimedia.org/other/pageviews/ lacks hourly pageviews since 20190722-17:00.
Tue, Jul 23, 8:48 AM · Analytics-Kanban, Analytics, cloud-services-team, Wikimedia-Portals
hashar updated the task description for T223134: Reorganize CI phabricator projects.
Tue, Jul 23, 8:41 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Continuous-Integration-Infrastructure
hashar assigned T228171: InvalidArgumentException: Invalid sort: last_edit_asc=1 to EBernhardson.

Thank you Erik for the follow up patch :-]

Tue, Jul 23, 8:30 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Discovery-Search (Current work), CirrusSearch, MediaWiki-Search, Wikimedia-production-error
hashar added a comment to T225735: Cleanup CI puppet manifests.

The chain of doom:

Tue, Jul 23, 8:24 AM · Release-Engineering-Team-TODO (201908), Release-Engineering-Team (CI & Testing services), Technical-Debt, Continuous-Integration-Infrastructure
hashar closed T228639: wikimedia-portals-build job failing with "node: command not found" as Resolved.
Notice: /Stage[main]/Contint::Packages::Javascript/Package[nodejs-legacy]/ensure: created
Notice: /Stage[main]/Contint::Packages::Javascript/Package[npm]/ensure: created
Info: /Stage[main]/Contint::Packages::Javascript/Package[npm]: Scheduling refresh of Exec[pin npm]
Notice: /Stage[main]/Contint::Packages::Javascript/Exec[pin npm]/returns: executed successfully
Notice: /Stage[main]/Contint::Packages::Javascript/Exec[pin npm]: Triggered 'refresh' from 1 events
Notice: Applied catalog in 35.76 seconds
$ node --version
v6.11.0
$ npm --version
3.8.3
Tue, Jul 23, 8:07 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (CI & Testing services), Wikimedia-Portals, Jenkins
hashar added a comment to T228639: wikimedia-portals-build job failing with "node: command not found".

I broke the job when I have removed NodeJS / npm from the permanent slaves :-(

Tue, Jul 23, 7:46 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (CI & Testing services), Wikimedia-Portals, Jenkins
hashar added a comment to T125050: [Task] Add Scribunto to extension-gate in CI.

This somehow happened in the last weekend for wikibase: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/60806/consoleFull (on Wikibase patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/524688)
Does anyone know why? the test job run time has jumped drastically, almost doubled.

Tue, Jul 23, 7:44 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Continuous-Integration-Config, MediaWiki-extensions-Scribunto, Wikidata

Mon, Jul 22

hashar added a comment to T224448: Gerrit http threads stuck behind sendemail thread.
- parking to wait for <0x00000006d75ed7e0> (a java.util.concurrent.locks.ReentrantLock$NonfairSync)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)
at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)
at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2089)
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2046)
at com.google.common.cache.LocalCache.get(LocalCache.java:3943)
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3967)
at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4952)
at com.google.gerrit.server.account.AccountCacheImpl.get(AccountCacheImpl.java:85)
at com.google.gerrit.server.account.InternalAccountDirectory.fillAccountInfo(InternalAccountDirectory.java:69)
at com.google.gerrit.server.account.AccountLoader.fill(AccountLoader.java:91)
at com.google.gerrit.server.change.ChangeJson.formatQueryResults(ChangeJson.java:
Mon, Jul 22, 9:40 PM · Release-Engineering-Team-TODO (201908), Release-Engineering-Team (Development services), serviceops-radar, Gerrit
hashar moved T225955: Document Zuul problems caused by force merge from Doing to Ready on the Release-Engineering-Team-TODO (201907) board.
Mon, Jul 22, 4:27 PM · Release-Engineering-Team-TODO (201908), Documentation, Zuul, Continuous-Integration-Infrastructure
hashar moved T225735: Cleanup CI puppet manifests from Ready to Doing on the Release-Engineering-Team-TODO (201907) board.
Mon, Jul 22, 4:26 PM · Release-Engineering-Team-TODO (201908), Release-Engineering-Team (CI & Testing services), Technical-Debt, Continuous-Integration-Infrastructure

Fri, Jul 19

hashar added a comment to T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges().

Thank you @Krinkle :]

Fri, Jul 19, 2:40 PM · Performance-Team, Mediawiki-Rdbms, Wikimedia-production-error
hashar closed T228505: Error 500 when visiting the 'dashboards' tab for some repos as Resolved.

wikimedia/iegreview.git (in refs/meta/config) inherits from the wikimedia.git repo:

project.config
[access]
	inheritFrom = wikimedia
...
Fri, Jul 19, 1:00 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
hashar committed rQUIBBLE3f47961cf55e: Use repo_has_composer_script() in PhpUnitUnit (authored by hashar).
Use repo_has_composer_script() in PhpUnitUnit
Fri, Jul 19, 11:01 AM
hashar committed rQUIBBLEf07777233071: Detect selenium tests by parsing composer.json (authored by awight).
Detect selenium tests by parsing composer.json
Fri, Jul 19, 11:01 AM
hashar added a comment to T184086: Add prometheus exporter to Gerrit.

Sort of orthogonal, please consider also adding the jmx exporter (even if it doesn't have gerrit-specific metrics yet) to get jvm general metrics (context is T177197: Export Prometheus-compatible JVM metrics from JVMs in production)

Fri, Jul 19, 9:13 AM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, Patch-For-Review, Gerrit, Operations

Jul 19 2019

hashar added a comment to T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges().

The resolution is unclear to me. We have filled this task due to the requests timeout that occurred immediately after promoting all wikis to 1.34.0-wmf.14 but:

Jul 19 2019, 8:48 AM · Performance-Team, Mediawiki-Rdbms, Wikimedia-production-error

Jul 18 2019

hashar added a comment to T220739: 1.34.0-wmf.14 deployment blockers.

I have rollbacked due to T228436

Jul 18 2019, 3:54 PM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Deployment services), Release, Train Deployments
hashar added a comment to T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges().

Indeed the rollback got rid of the spam of errors. To be investigated now is what kind of db transactions are taking a while in Wikimedia\Rdbms\LBFactory->commitMasterChanges() :-\ There might be informations in logstash log if MediaWiki logs anything for databases.

Jul 18 2019, 3:53 PM · Performance-Team, Mediawiki-Rdbms, Wikimedia-production-error
hashar added a comment to T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges().

That happens mostly on enwiki. Over one hour 4k occurrences out of 4400 total matches.

Jul 18 2019, 3:29 PM · Performance-Team, Mediawiki-Rdbms, Wikimedia-production-error
hashar updated subscribers of T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges().
Jul 18 2019, 3:24 PM · Performance-Team, Mediawiki-Rdbms, Wikimedia-production-error
hashar added a parent task for T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges(): T220739: 1.34.0-wmf.14 deployment blockers.
Jul 18 2019, 3:24 PM · Performance-Team, Mediawiki-Rdbms, Wikimedia-production-error
hashar added a subtask for T220739: 1.34.0-wmf.14 deployment blockers: T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges().
Jul 18 2019, 3:24 PM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Deployment services), Release, Train Deployments
hashar triaged T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges() as Unbreak Now! priority.
Jul 18 2019, 3:24 PM · Performance-Team, Mediawiki-Rdbms, Wikimedia-production-error
hashar created T228436: web request timeout after 200 seconds due to Wikimedia\Rdbms\LBFactory->__destruct() > Wikimedia\Rdbms\LBFactory->commitMasterChanges().
Jul 18 2019, 3:23 PM · Performance-Team, Mediawiki-Rdbms, Wikimedia-production-error