The project was already using js-yaml as a dependency, so I gave this a shot by putting in a js-yaml config.yaml as the npm test script.

If that's what you're looking for, js-yaml is a very easy-to-use node module. Running js-yaml file.yaml prints out the JSON for the YAML in the file and the return status code of js-yaml tells us whether there was an error or not. Errors get logged to console too, of course.

You're looking for some configuration of npm modules such that when you run npm test, the YAML files get linted?

I tested this by updating CodeSniffer, and the issue was gone. Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed's code has changed and no longer checks for T_CONSTANT_ENCAPSED_STRING, so the issue no longer occurs. The CodeSniffer dependency was updated in rMCSN9a1a1acc5e8c: Update squizlabs/php_codesniffer to 2.3.4, but we still have to cut a new version ( T113516: Release version 0.4.0 of mediawiki/tools/codesniffer ). Once that is done, we can update core's version of mediawiki-codesniffer and we should be good to go.

@Legoktm and I spoke about this on IRC a while back - we do need to update to v0.4.0 also because of 62bddfe5ed8b2 and 0735677425.

Closing as invalid since we're unable to reproduce it. Feel free to re-open if it occurs again!

IIRC, it uses our phpcs.xml only if we don't specify any files to check. Try doing the same thing without specifying the . at the end.

Should the MediaWiki-extension-requests project be removed?

Regarding users: I sent out a mail to mediawiki-l announcing the extension. Hopefully wiki admins who have this problem on their wikis will make use of the extension. At the moment, WikiApiary shows 2 wikis using the extension.

Still happening. Bump?

Unfortunately, codesniffer only uses the phpcs.xml file if you don't specify any files to check.

This isn't really a bug on our end, but probably with upstream composer or phpcs. Marking as invalid because of that.

This error is reported by the PEAR.ControlStructures.MultiLineCondition sniff, which AFAIK, is not included in the MediaWiki standard. Are you sure you're using the MediaWiki standard and not the default standard that phpcs uses, which is probably PEAR?

Just adding some people who might have some idea about this. Also, are there any projects that I missed?

So for the amount I've reviewed, the primary issues with autofixing this are the following:

This is wrt master's state at d5a7559f99.

@Legoktm wrote a patch to automatically fix these issues using PHPCBF (https://gerrit.wikimedia.org/r/#/c/228993/) and I'm currently testing out that patch on core.

I'm not sure whether this was already discussed and declined. If so, please close the task.

@Addshore, still some way to go. A few tasks were resolved a while back, but then I got occupied with my GSoC project. After my midterms end (a few days from now), I'll investigate this is more depth.

And finally, version 0.1.0 was released in 902eb3142. :D

@Bawolff, thanks a lot for the final review!

@Raymond, thanks a lot for that review!

To clarify, by review the messages, I don't mean check the English used, but rather, usage of features such as parameters, plural support, etc. The reason the T109510: Finalize i18n messages for Extension:SmiteSpam was required was because of bad usage of such features. (I was connecting two messages using a comma inside PHP instead of using parameters) There's a very good chance that some updates need to be made.

@NiharikaKohli, I'd like to wait a little longer to resolve this, probably a week or so. There are a few tasks remaining on MediaWiki-extensions-SmiteSpam that need to be completed, after which I'll announce this extension on mediawiki-l (as per a discussion with Yaron and Jan) and mark this task as resolved too. Does that seem alright?

Works now.

The page is password protected, though. We get redirected to the login page which has the message: "Wikipedia Internal store. This online store only open to Wikimedia Foundation internal."

@NiharikaKohli, sorry, I should have clarified: the Labs instance does not have the extension installed. The original purpose of the instance was something else. In order to install the extension (and update it later), I'll need to ssh into the machine, which, as of now, I don't know a way to do.

Fair enough, and I understand the intention behind asking for a public demo. However, the other issue still remains, which is that I cannot SSH into my Labs instance through my college network's proxy.

Thanks @Abhinand!

About "Project is completed and hosted on Labs/elsewhere - in a demo-able condition", I'm now back in college and within a network proxy. IIRC, based on a discussion with Labs admins and my college student sysadmins, it basically is not possible for me to SSH into my Labs instance.

mw:Extension:SmiteSpam page updated with relevant information.

Seeing broken unicode characters in the preview could possibly confuse admins, leading to unexpected consequences. @Abhinand, are you working on this?