Page MenuHomePhabricator
Feed Advanced Search

Today

awight committed rEFLI953a1e943cac: Give all import exceptions a code (authored by awight).
Give all import exceptions a code
Mon, Jun 17, 8:07 AM
awight added a comment to T225602: Correct logging of failure types on FileImporter Grafana board.

Epic catalog of error codes is evolving here: https://www.mediawiki.org/wiki/Extension:FileImporter/Errors

Mon, Jun 17, 8:03 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons

Yesterday

awight added a comment to T225871: Selenium and PHPUnit: Stop execution on failure.

I would actually object to this: imagine your change has caused multiple test failures that you weren't able to predict in your dev environment (because you didn't have all extensions installed or your environment is otherwise different from our CI). You'll have to amend your PR with one fix at a time and push it just to see what explodes next.

Sun, Jun 16, 11:31 AM · Patch-For-Review, Continuous-Integration-Config

Sat, Jun 15

awight added a comment to T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.
  • using --stop-on-failure for PHPUnit (and whatever the equivalent is for QUnit and Selenium) for gate-and-submit might be interesting as a means to speed up the entire cycle when a flaky build happens
Sat, Jun 15, 12:51 PM · Patch-For-Review, User-zeljkofilipin, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity

Fri, Jun 14

awight committed rEFLI1f9cef1aabda: Standardize error buckets (authored by awight).
Standardize error buckets
Fri, Jun 14, 3:08 PM
awight committed rEFLId3cc89eb5544: Give all import exceptions a code (authored by awight).
Give all import exceptions a code
Fri, Jun 14, 3:01 PM
awight committed rEFLIfda51e365bce: Fix config-sensitive test (authored by awight).
Fix config-sensitive test
Fri, Jun 14, 3:01 PM
awight committed rEFLI6cae44d61abd: [WIP] Give all import exceptions a code (authored by awight).
[WIP] Give all import exceptions a code
Fri, Jun 14, 2:43 PM
awight added a comment to T225721: PHP statsd client doesn't support tagging metrics.

FWIW, WMF is slowly moving away from statsd in favor of Prometheus. I'm not sure what the Mediawiki plan is. @fgiunchedi

Fri, Jun 14, 2:37 PM · Operations, Graphite
awight committed rEFLIadb05c222633: [WIP] Give all import exceptions a code (authored by awight).
[WIP] Give all import exceptions a code
Fri, Jun 14, 2:09 PM
awight committed rEFLI609ae46ff9df: [WIP] Give all import exceptions a code (authored by awight).
[WIP] Give all import exceptions a code
Fri, Jun 14, 12:14 PM
awight added a comment to T225602: Correct logging of failure types on FileImporter Grafana board.

Notes on next implementation steps:

  • Our exceptions should all respond to getCode, with a string constant naming the error type.
  • Take recoverable errors out of the planning phase error count, report it separately.
  • FileImporter.import.result.exception' is missing two errors, "bad edit token" and "bad import hash". Move import submit stats logging up to the exception handler to catch these.
  • Drop the "plan" vs. "submit" distinction, this doesn't seem to matter.
  • Report time taken to fail?
Fri, Jun 14, 10:55 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight added a comment to T225602: Correct logging of failure types on FileImporter Grafana board.

Notes from discussion:

  • Definitely go ahead with creating a MediaWiki page to document what the buckets are and what specific errors are in each one.
  • Link to our documentation from the "i" information popup on the failure graph, and summarize to help users with interpretation.
  • Minimum granularity for this task is to split out unrecoverable from recoverable errors, and to expose exact counts for AbuseFilter matches.
Fri, Jun 14, 9:28 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight added a comment to T225062: Requesting access to deployment cluster for awight.

It will be live in around half an hour everywhere; sometime after that, please check that you can get to the hosts you expect.

Fri, Jun 14, 8:23 AM · Operations, SRE-Access-Requests
awight added a comment to T225721: PHP statsd client doesn't support tagging metrics.

To say it out loud, it looks like the liuggio/statsd-php-client is no longer maintained. A question about releases, https://github.com/liuggio/statsd-php-client/issues/55 has been sitting for 8 months. The last commit was in 2016. We could fork it and take over maintenance, or start with a new library. I suggest that we wrap whatever we use with our own interface, so that swapping out libraries is easier in the future. We're currently basing our interface hierarchy directly on the liuggio code.

Fri, Jun 14, 8:12 AM · Operations, Graphite
awight added a project to T225721: PHP statsd client doesn't support tagging metrics: Operations.
Fri, Jun 14, 7:54 AM · Operations, Graphite

Thu, Jun 13

awight added a comment to T225602: Correct logging of failure types on FileImporter Grafana board.

The grafana dashboard shows all these errors now, and sums correctly over the past 24hr. Next steps are to distinguish between recoverable and unrecoverable errors during the planning stage. Then we can provide more granularity where desired--probab best if @Lea_WMDE looks over the dashboard to help scope where we need this granularity.

Thu, Jun 13, 3:53 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight added a comment to T225602: Correct logging of failure types on FileImporter Grafana board.

I'm getting a little confused, so will leave some breadcrumbs about where various error stats come from in the current code:

  • Permission and user block errors when first opening the special page are tallied as MediaWiki.FileImporter.specialPage.execute.fail.*, which should be used with care because it almost overlaps with the ...fail.plan.* below.
  • Errors when building the ImportPlan report one MediaWiki.FileImporter.specialPage.execute.fail.plan.total and one MediaWiki.FileImporter.specialPage.execute.fail.plan.byType.*
  • Importer::import called when action=submit will record a Mediawiki.FileImporter.import.result.exception
Thu, Jun 13, 3:28 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight updated the task description for T225602: Correct logging of failure types on FileImporter Grafana board.
Thu, Jun 13, 3:07 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight created T225721: PHP statsd client doesn't support tagging metrics.
Thu, Jun 13, 1:13 PM · Operations, Graphite
awight created P8609 statsd to console.
Thu, Jun 13, 10:01 AM
awight updated the task description for T225602: Correct logging of failure types on FileImporter Grafana board.
Thu, Jun 13, 9:34 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight moved T225602: Correct logging of failure types on FileImporter Grafana board from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-06-12 board.
Thu, Jun 13, 8:10 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight moved T224007: Show Now Commons info for files that were moved from Doing to Review on the WMDE-QWERTY-Sprint-2019-06-12 board.
Thu, Jun 13, 8:09 AM · WMDE-QWERTY-Sprint-2019-06-12, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMDE-QWERTY-Sprint-2019-05-29, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, TCB-Team, Move-Files-To-Commons
awight closed T225609: Supplement the FileImporter environment on beta to allow full testing as Resolved.

This should be ready to go, just waiting for config deployment which won't happen until at least next week (June 17th). We should sign up for a SWAT deployment once the new calendar is posted.

Thu, Jun 13, 8:09 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight closed T225609: Supplement the FileImporter environment on beta to allow full testing, a subtask of T224007: Show Now Commons info for files that were moved, as Resolved.
Thu, Jun 13, 8:09 AM · WMDE-QWERTY-Sprint-2019-06-12, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMDE-QWERTY-Sprint-2019-05-29, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, TCB-Team, Move-Files-To-Commons
awight updated the task description for T225609: Supplement the FileImporter environment on beta to allow full testing.
Thu, Jun 13, 8:06 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight moved T225696: Typo in workboard column name: "Confirmation" from Untriaged to Manager/NDA Approval/Confirmation on the SRE-Access-Requests board.
Thu, Jun 13, 7:48 AM · SRE-Access-Requests, Operations
Restricted Application added a project to T225696: Typo in workboard column name: "Confirmation": Operations.
Thu, Jun 13, 7:48 AM · SRE-Access-Requests, Operations
awight closed T223262: Request: add awight to contint-docker as Declined.

I'm having second thoughts about this request, because I'm no longer see that I'll be useful in this role. Building and publishing images is a straightforward process, and the burdensome work is to write and test patches in integration-config/dockerfiles (something I can do without privileges), and bumping image versions which is just part of deployment.

Thu, Jun 13, 7:45 AM · Release-Engineering-Team-TODO, Operations, SRE-Access-Requests, Continuous-Integration-Infrastructure
awight claimed T225609: Supplement the FileImporter environment on beta to allow full testing.
Thu, Jun 13, 7:34 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight added a comment to T210287: Migrate wikimedia-fundraising-civicrm to a Docker container.

Woohoo, nice work!

Thu, Jun 13, 12:01 AM · Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway)

Wed, Jun 12

awight added a comment to T225193: CI monitoring to detect flapping tests, especially in unrelated gated extensions.

The "recheck bot" is an interesting twist--I like the idea of automatically rechecking if there was an external error e.g. network glitch, but it makes me uncomfortable to think about rechecking due to flapping tests. What would be nicer is a fine-grained mask for interpreting test results, basically a way to quickly flag certain tests as broken at the CI level, without having to edit and merge code. This would let us provisionally V+2 patches only affected by flappers.

Wed, Jun 12, 3:30 PM · Continuous-Integration-Infrastructure
awight moved T225611: Track interaction with title and file info from Tickets in sprint to Tickets ready for pickup on the Move-Files-To-Commons board.
Wed, Jun 12, 3:13 PM · TCB-Team, Move-Files-To-Commons
awight moved T225588: Investigate: Import the file, but suppress old revisions when they are blocked by the AbuseFilter from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.
Wed, Jun 12, 3:12 PM · WMDE-QWERTY-Sprint-2019-06-12, AbuseFilter, Move-Files-To-Commons, TCB-Team
awight moved T225521: Investigate whether the AbuseFilter can specify which revisions to execute a rule on from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.
Wed, Jun 12, 3:12 PM · WMDE-QWERTY-Sprint-2019-06-12, AbuseFilter, Move-Files-To-Commons, TCB-Team
awight added a comment to T224518: Investigation how to automatically add the now-commons-equivalent template to the file on the source wiki.

The patch works as intended, now. Only two minor changes: I had to change the action=edit request to a POST, and we needed an intermediate call to obtain a csrftoken. This approach will be fine!

Wed, Jun 12, 3:12 PM · WMDE-QWERTY-Sprint-2019-06-12, WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight committed rEFLIa68b447277b9: [WIP] Set notice in file on the source wiki (authored by WMDE-Fisch).
[WIP] Set notice in file on the source wiki
Wed, Jun 12, 3:10 PM
awight moved T224518: Investigation how to automatically add the now-commons-equivalent template to the file on the source wiki from Doing to Done on the WMDE-QWERTY-Sprint-2019-06-12 board.
Wed, Jun 12, 3:10 PM · WMDE-QWERTY-Sprint-2019-06-12, WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight added a comment to T225521: Investigate whether the AbuseFilter can specify which revisions to execute a rule on.

@Daimona Hi, thanks for the offer! The docs for FileImporter start here, but long story short we're importing File pages including their entire revision history, moving to commonswiki for the Wikimedia use case. We call AbuseFilter on each revision by manually invoking the EditFilterMergedContent hook.

Wed, Jun 12, 2:01 PM · WMDE-QWERTY-Sprint-2019-06-12, AbuseFilter, Move-Files-To-Commons, TCB-Team
awight moved T225610: Display info about import time,MBs moved, no of file revisions and no of text revisions from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.
Wed, Jun 12, 1:36 PM · WMDE-QWERTY-Sprint-2019-06-12, Move-Files-To-Commons, TCB-Team
awight removed a project from T223017: Isolate FileImporter integration test from external web services: WMDE-QWERTY-Sprint-2019-06-12.
Wed, Jun 12, 1:35 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight moved T225611: Track interaction with title and file info from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.
Wed, Jun 12, 1:34 PM · TCB-Team, Move-Files-To-Commons
awight moved T225602: Correct logging of failure types on FileImporter Grafana board from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.
Wed, Jun 12, 1:34 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight moved T225609: Supplement the FileImporter environment on beta to allow full testing from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.
Wed, Jun 12, 1:34 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-06-12, TCB-Team, Move-Files-To-Commons
awight added a comment to T224007: Show Now Commons info for files that were moved.

I used the test beta wiki, moving this file from de.wikipedia.org there: https://test.wikimedia.beta.wmflabs.org/wiki/File:Rajamangala_University_of_Technology_Rattanakosin_Salaya_Campus_Stadium.jpg

What I received was the message if we do not know what the template is, but I was expecting to be suggested using Vorlage:NowCommons, because this is what the Wikidata item has in store for de.wikipedia.org

Wed, Jun 12, 10:29 AM · WMDE-QWERTY-Sprint-2019-06-12, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMDE-QWERTY-Sprint-2019-05-29, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, TCB-Team, Move-Files-To-Commons
awight moved T224007: Show Now Commons info for files that were moved from Demo to Review on the WMDE-QWERTY-Sprint-2019-05-29 board.
Wed, Jun 12, 10:06 AM · WMDE-QWERTY-Sprint-2019-06-12, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMDE-QWERTY-Sprint-2019-05-29, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, TCB-Team, Move-Files-To-Commons

Tue, Jun 11

awight moved T223017: Isolate FileImporter integration test from external web services from Doing to Review on the WMDE-QWERTY-Sprint-2019-05-29 board.
Tue, Jun 11, 8:52 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight moved T224518: Investigation how to automatically add the now-commons-equivalent template to the file on the source wiki from Demo to Doing on the WMDE-QWERTY-Sprint-2019-05-29 board.
Tue, Jun 11, 3:35 PM · WMDE-QWERTY-Sprint-2019-06-12, WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight added a comment to T224518: Investigation how to automatically add the now-commons-equivalent template to the file on the source wiki.

Local vagrant environment with the centralauth role enabled is behaving well, I'll use that to debug our proof-of-concept patch tomorrow.

Tue, Jun 11, 3:35 PM · WMDE-QWERTY-Sprint-2019-06-12, WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight committed rEFLI8ed96036b1b3: [WIP] Set notice in file on the source wiki (authored by WMDE-Fisch).
[WIP] Set notice in file on the source wiki
Tue, Jun 11, 3:35 PM
awight added a comment to T223218: Clean up ConfigFiles.

I've partially reverted my edits and only removed Information -> Template this time.

Tue, Jun 11, 1:31 PM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight added a comment to T223218: Clean up ConfigFiles.

@Pikne Thanks for the quick bug report! I'll revert my bad edits right away.

Tue, Jun 11, 12:39 PM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight moved T223218: Clean up ConfigFiles from Doing to Review on the WMDE-QWERTY-Sprint-2019-05-29 board.
Tue, Jun 11, 11:51 AM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight added a comment to T223218: Clean up ConfigFiles.

This was more like 2 story points.

Tue, Jun 11, 11:51 AM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight updated the task description for T223218: Clean up ConfigFiles.
Tue, Jun 11, 11:51 AM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight updated the task description for T223218: Clean up ConfigFiles.
Tue, Jun 11, 11:29 AM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight updated the task description for T223218: Clean up ConfigFiles.
Tue, Jun 11, 11:16 AM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight updated the task description for T223218: Clean up ConfigFiles.
Tue, Jun 11, 11:09 AM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight moved T223218: Clean up ConfigFiles from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-05-29 board.
Tue, Jun 11, 9:13 AM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight claimed T223218: Clean up ConfigFiles.
Tue, Jun 11, 9:13 AM · WMDE-QWERTY-Sprint-2019-05-29, TCB-Team, Move-Files-To-Commons
awight committed rQUIBBLEdb1b1c1fb09b: Experiment with frozen classes (authored by awight).
Experiment with frozen classes
Tue, Jun 11, 12:58 AM

Mon, Jun 10

awight updated subscribers of T221913: Translate coverage publish step fails with: Incorrect whitelist config, no code coverage will be generated..

I can confirm the work that's already been done on this ticket. As Thiemo pointed out, the phpunit-suite-edit script is responsible for constructing the coverage whitelist, and for the Translate extension none of these directories exist.

Mon, Jun 10, 8:35 PM · Continuous-Integration-Config, MediaWiki-extensions-Translate
awight added a comment to T223262: Request: add awight to contint-docker.

If you really want :) Approved.

Mon, Jun 10, 7:42 PM · Release-Engineering-Team-TODO, Operations, SRE-Access-Requests, Continuous-Integration-Infrastructure
awight added a comment to T211704: CI Quibble jobs should be feed with git repos and dependencies.

T211702, T211703, and this task all seem slightly at odds with each other. If we clone everything before running quibble, then we lose the opportunity to optimize for the fast-fail on linting. If CI runs npm and composer test, then quibble shouldn't be doing the cloning, etc. We need to refine this plan before implementing, IMHO.

Mon, Jun 10, 2:15 PM · Release-Engineering-Team-TODO, Quibble (marble)

Sun, Jun 9

awight added a comment to T211702: Quibble initialize step should only clone the target repository.

I'm imagining we might specify the process dependency graph in terms of abstract job milestones, so rather than couple tasks directly e.g. (repo_npm_test && repo_composer test -> clone dependencies), we would say (repo_npm_test && repo_composer_test -> REPO_TESTS_DONE) and (REPO_TESTS_DONE -> clone dependencies -> ALL_TESTS_READY) then (ALL_TESTS_READY -> ext_skin_composer_test), etc.

Sun, Jun 9, 8:49 AM · Release-Engineering-Team-TODO, Quibble (marble)
awight added a comment to T211702: Quibble initialize step should only clone the target repository.

I wanted to give this a try, as a way to work through some questions that I've been stewing on regarding my Command object refactor. How to represent the higher-level stages? My suspicion is that stages are just a special case of dependency relationships between the fine-grained steps, and there should actually be several stages. One especially quirky point is that I don't want to plan the entire job until after cloning repos, because we can't analyze whether certain steps (e.g. npm run selenium-test) make any sense until the code is present. Here are some thoughts about the stages generally (bigger scope than this task):

  • Clone ZUUL_PROJECT
  • Analyze what steps can be taken to test this repo (look for composer.json, package.json...) and plan first stage.
  • First test stage (T221702), all steps in parallel
    • composer test
    • npm install && npm test
  • Clone all dependencies
  • Analyze what can be tested (e.g. look for tests/selenium in each repo) and plan second stage.
  • Second test stage, some steps can be in parallel
Sun, Jun 9, 8:41 AM · Release-Engineering-Team-TODO, Quibble (marble)
awight committed rQUIBBLEcbf4d6b42a04: Experiment with frozen classes (authored by awight).
Experiment with frozen classes
Sun, Jun 9, 12:15 AM

Sat, Jun 8

awight committed rQUIBBLEe5c5db32a7bf: Run node browser tests in each repo (authored by awight).
Run node browser tests in each repo
Sat, Jun 8, 10:08 PM
awight committed rQUIBBLEfe174d58320e: Inline remaining cmd.py steps (authored by awight).
Inline remaining cmd.py steps
Sat, Jun 8, 10:08 PM
awight committed rQUIBBLE4f50be97e140: Rename native composer command (authored by awight).
Rename native composer command
Sat, Jun 8, 10:08 PM
awight committed rQUIBBLEf5bb5138b421: Move parallel_run to util.py (authored by awight).
Move parallel_run to util.py
Sat, Jun 8, 10:08 PM
awight committed rQUIBBLE6d281cd87c07: Separate planning and execution phases (authored by awight).
Separate planning and execution phases
Sat, Jun 8, 10:08 PM
awight committed rQUIBBLE406fd2f1ad00: browser tests as command (authored by awight).
browser tests as command
Sat, Jun 8, 10:08 PM
awight committed rQUIBBLE3a60fb7775e4: Core npm composer test as command (authored by awight).
Core npm composer test as command
Sat, Jun 8, 10:05 PM

Fri, Jun 7

awight merged T225330: Commit package-lock.json files everywhere into T225315: libraryupgrader should commit package-lock.json files.
Fri, Jun 7, 10:27 PM · VPS-project-libraryupgrader
awight merged task T225330: Commit package-lock.json files everywhere into T225315: libraryupgrader should commit package-lock.json files.
Fri, Jun 7, 10:27 PM · MediaWiki-Core-Testing, Quibble
awight committed rQUIBBLE805ff996f803: Run node browser tests in each repo (authored by awight).
Run node browser tests in each repo
Fri, Jun 7, 10:25 PM
awight committed rQUIBBLE311454c7b82c: Run node browser tests in each repo (authored by awight).
Run node browser tests in each repo
Fri, Jun 7, 10:22 PM
awight committed rQUIBBLEd4ea53724d55: Inline remaining cmd.py steps (authored by awight).
Inline remaining cmd.py steps
Fri, Jun 7, 9:46 PM
awight added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

There are at least two easy speedups for npm install, the first is documented in subtask T225330: Commit package-lock.json files everywhere, which just became possible thanks to the npm 10 upgrade. The second is --prefer-offline, which only fetches packages when they are missing from the local cache. We should experiment with both.

Fri, Jun 7, 9:09 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin
awight created T225330: Commit package-lock.json files everywhere.
Fri, Jun 7, 9:02 PM · MediaWiki-Core-Testing, Quibble
awight committed rQUIBBLEc564d872e5d5: Rename native composer command (authored by awight).
Rename native composer command
Fri, Jun 7, 2:57 PM
awight committed rQUIBBLEbe406810d4a0: Move parallel_run to util.py (authored by awight).
Move parallel_run to util.py
Fri, Jun 7, 2:57 PM
awight committed rQUIBBLEb98853ccf33e: Separate planning and execution phases (authored by awight).
Separate planning and execution phases
Fri, Jun 7, 2:57 PM
awight committed rQUIBBLE7e1442de3b0a: browser tests as command (authored by awight).
browser tests as command
Fri, Jun 7, 2:57 PM
awight committed rQUIBBLEee97c332f827: Rename native composer command (authored by awight).
Rename native composer command
Fri, Jun 7, 2:51 PM
awight committed rQUIBBLEb82584ffed8c: Move parallel_run to util.py (authored by awight).
Move parallel_run to util.py
Fri, Jun 7, 2:51 PM
awight committed rQUIBBLE9d82f17dfab1: Separate planning and execution phases (authored by awight).
Separate planning and execution phases
Fri, Jun 7, 2:51 PM
awight committed rQUIBBLEc28f33bf9b04: browser tests as command (authored by awight).
browser tests as command
Fri, Jun 7, 2:51 PM
awight committed rQUIBBLE14a064f17daf: Rename native composer command (authored by awight).
Rename native composer command
Fri, Jun 7, 2:13 PM
awight committed rQUIBBLE63225b806f16: Separate planning and execution phases (authored by awight).
Separate planning and execution phases
Fri, Jun 7, 2:13 PM
awight committed rQUIBBLE45219e3c418c: browser tests as command (authored by awight).
browser tests as command
Fri, Jun 7, 2:13 PM
awight committed rQUIBBLEb2fb7a1d703b: Separate planning and execution phases (authored by awight).
Separate planning and execution phases
Fri, Jun 7, 2:09 PM
awight committed rQUIBBLEf7c51a8b0bab: browser tests as command (authored by awight).
browser tests as command
Fri, Jun 7, 2:09 PM
awight committed rQUIBBLE7413e3e0aa14: Core npm composer test as command (authored by awight).
Core npm composer test as command
Fri, Jun 7, 1:57 PM
awight committed rQUIBBLEbcc695fe1e1e: phpunit tests as command (authored by awight).
phpunit tests as command
Fri, Jun 7, 12:51 PM
awight committed rQUIBBLEb5d689ec027e: Composer and npm test as command (authored by awight).
Composer and npm test as command
Fri, Jun 7, 12:03 PM
awight committed rQUIBBLE707483b285fe: Rename native composer command (authored by awight).
Rename native composer command
Fri, Jun 7, 7:34 AM

Thu, Jun 6

awight added a comment to T225248: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline.

I like this proposal, but I'm concerned that non-voting tests will become meaningless, wasting CI resources for little value, and discouraging developers from writing browser tests in the future. Here are a few alternative approaches we might consider,

  • Make it easier to run browser tests locally, especially the full gate-and-submit suite which helps find unwanted interactions between extensions. Just as we shouldn't be pushing patches without linting and running unit tests locally, we should also be able to do these more complex tests. Quibble is a big step towards this goal, we might just be a small amount of extra glue away from a simple, local "test everything".
  • Run CI browser tests in parallel. (Task already filed?)
  • Better social conventions around flapping tests. I'm pretty sure most of us were being inconvenienced by the same flaky tests. Rather than recheck, maybe the first response should be to mark the test as broken. This would be aided by a hit list of the top offending tests, or other monitoring. (T224673, T225193, T225162)
  • Hourly or daily regression suite which is capable of bisecting or something, to identify which specific patches broke the build even after merge. This is less than ideal since it lets us deploy broken code.
Thu, Jun 6, 10:00 PM · Patch-For-Review, User-zeljkofilipin, Browser-Tests, Continuous-Integration-Infrastructure, Developer Productivity