Page MenuHomePhabricator
Feed Advanced Search

Yesterday

awight moved T189573: Display current category state on Import Preview Page from Review to Demo on the WMDE-QWERTY-Sprint-2019-05-15 board.
Thu, May 23, 2:44 PM · WMDE-QWERTY-Sprint-2019-05-15, Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-30, TCB-Team, Move-Files-To-Commons
awight added a comment to T189573: Display current category state on Import Preview Page.

Discussed, and the patch reflects the text we want.

Thu, May 23, 2:08 PM · WMDE-QWERTY-Sprint-2019-05-15, Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-30, TCB-Team, Move-Files-To-Commons
awight committed rEFLIb92f28bb9889: Add notice about categorization (authored by awight).
Add notice about categorization
Thu, May 23, 2:04 PM
awight moved T189573: Display current category state on Import Preview Page from Doing to Review on the WMDE-QWERTY-Sprint-2019-05-15 board.
Thu, May 23, 1:56 PM · WMDE-QWERTY-Sprint-2019-05-15, Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-30, TCB-Team, Move-Files-To-Commons
awight committed rEFLIf4fe97875188: Add notice about categorization (authored by awight).
Add notice about categorization
Thu, May 23, 1:55 PM
awight added a comment to T213821: On the file page change localized namespace to target wiki namespace names .

It looks like all patches are merged now?

Thu, May 23, 1:34 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), WMDE-QWERTY-Sprint-2019-04-30, TCB-Team, Move-Files-To-Commons
awight added a comment to T222200: Run browser tests as part of "npm test" of wikidata/query/gui.

This might also be useful:
T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests
I have a patch for review which will run browser tests for each extension separately, which makes it possible to run custom setup scripts and install local npm dependencies. This seems like a simpler solution than spinning up the headless browser in another phase of testing. Or maybe I'm misunderstanding why you want the workaround here--would you mind explaining why it's desirable to run browser tests along with npm test?

Thu, May 23, 1:06 PM · Patch-For-Review, Wikimedia-Hackathon-2019, User-zeljkofilipin, Wikidata-Campsite, Wikidata, Continuous-Integration-Infrastructure
awight committed rEFLIf9ec0f6fd353: Browser tests for external dependencies (authored by awight).
Browser tests for external dependencies
Thu, May 23, 12:49 PM
awight added a watcher for Passwordless-Login: awight.
Thu, May 23, 12:13 PM
awight added a comment to T189573: Display current category state on Import Preview Page.

Below the category box there is an info text: Files on Wikimedia Commons should be categorized. This makes it easier to find them. You can add categories to this file by editing the file info on this page.

I guess we still need to add this.

Thu, May 23, 9:06 AM · WMDE-QWERTY-Sprint-2019-05-15, Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-30, TCB-Team, Move-Files-To-Commons

Wed, May 22

awight updated the task description for T224122: 20% maintenance tasks in QWERTY sprint 2019-05-15.
Wed, May 22, 2:17 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15
awight created T224121: Disable manual V+2 for TechWishes extensions.
Wed, May 22, 2:09 PM · WMDE-QWERTY-Team
awight added a comment to T194272: Clean up config variable handling.

Minor observation: we should schedule a hard end-of-life for supporting older wikidiff2 versions, to allow us to remove special-case code.

Wed, May 22, 1:28 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-10, WMDE-QWERTY-X-Mas-Sprint-2018-12-18, WMDE-QWERTY-Sprint-2018-08-29, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), WMDE-QWERTY-Sprint-2018-08-14, WMDE-MediaWiki-maintenance, wikidiff2, WMDE-QWERTY-Team, TCB-Team, MediaWiki-History-and-Diffs
awight claimed T210172: wikidiff2 mediawiki-vagrant role broken.
Wed, May 22, 12:53 PM · Patch-For-Review, MediaWiki-Vagrant, wikidiff2
awight updated the task description for T210172: wikidiff2 mediawiki-vagrant role broken.
Wed, May 22, 12:53 PM · Patch-For-Review, MediaWiki-Vagrant, wikidiff2
awight renamed T210172: wikidiff2 mediawiki-vagrant role broken from No role for wikidiff3 to wikidiff2 mediawiki-vagrant role broken.
Wed, May 22, 12:53 PM · Patch-For-Review, MediaWiki-Vagrant, wikidiff2
awight closed T217546: Line matching algorithm can produce dead left-to-right side links as Resolved.
Wed, May 22, 11:25 AM · Patch-For-Review, wikidiff2, TCB-Team, WMDE-QWERTY-Sprint-2019-02-20
awight closed T222869: "Moved paragraph" arrows in diffs show broken page previews as Resolved.

Verified working for the original links.

Wed, May 22, 11:24 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-30, Regression, good first bug, wikidiff2, TCB-Team, WMDE-QWERTY-Team, Reference Previews
awight claimed T200018: File exporter beta feature does not have an RTL image.
Wed, May 22, 11:22 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, Beta-Feature, good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight added a comment to T1149: "Patch-For-Review" should be updated if the status in Gerrit changes.

Fantastic, thanks x10^6!

Wed, May 22, 10:55 AM · User-Ladsgroup, Phabricator
awight created T224102: Discuss: maintainers email for WMDE projects.
Wed, May 22, 9:54 AM · WMDE-QWERTY-Team, WMDE-FUN-Team
awight moved T200018: File exporter beta feature does not have an RTL image from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-05-15 board.
Wed, May 22, 9:27 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, Beta-Feature, good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight added a project to T200018: File exporter beta feature does not have an RTL image: WMDE-QWERTY-Sprint-2019-05-15.
Wed, May 22, 9:27 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, Beta-Feature, good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight updated the task description for T223967: Tangential CI work to support Tech Wishes.
Wed, May 22, 8:50 AM · WMDE-QWERTY-Sprint-2019-05-15

Tue, May 21

awight added a comment to T200018: File exporter beta feature does not have an RTL image.

It wasn't a layer. It was just.... something weird. This should be the fix, thanks for catching!

Tue, May 21, 11:57 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, Beta-Feature, good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight updated the task description for T194272: Clean up config variable handling.
Tue, May 21, 11:52 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-10, WMDE-QWERTY-X-Mas-Sprint-2018-12-18, WMDE-QWERTY-Sprint-2018-08-29, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), WMDE-QWERTY-Sprint-2018-08-14, WMDE-MediaWiki-maintenance, wikidiff2, WMDE-QWERTY-Team, TCB-Team, MediaWiki-History-and-Diffs
awight added a comment to T200018: File exporter beta feature does not have an RTL image.

Oh, the colors in this image are not entirely correct. Bonus points for flipping the mountain!

Tue, May 21, 11:51 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, Beta-Feature, good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight updated the task description for T223379: Set up config pages that can be used for testing purposes.
Tue, May 21, 11:41 PM · Patch-For-Review, TCB-Team, Move-Files-To-Commons, WMDE-QWERTY-Sprint-2019-05-15
awight moved T223379: Set up config pages that can be used for testing purposes from Review to Demo on the WMDE-QWERTY-Sprint-2019-05-15 board.
Tue, May 21, 11:41 PM · Patch-For-Review, TCB-Team, Move-Files-To-Commons, WMDE-QWERTY-Sprint-2019-05-15
awight updated the task description for T223379: Set up config pages that can be used for testing purposes.
Tue, May 21, 11:41 PM · Patch-For-Review, TCB-Team, Move-Files-To-Commons, WMDE-QWERTY-Sprint-2019-05-15
awight added a comment to T194272: Clean up config variable handling.

The mediawiki-core usages make it look like we're going to invalidate a lot of cached diffs with this... https://codesearch.wmflabs.org/search/?q=WikiDiff2MovedParagraphDetectionCutoff&i=nope&files=&repos=

Tue, May 21, 11:28 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-10, WMDE-QWERTY-X-Mas-Sprint-2018-12-18, WMDE-QWERTY-Sprint-2018-08-29, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), WMDE-QWERTY-Sprint-2018-08-14, WMDE-MediaWiki-maintenance, wikidiff2, WMDE-QWERTY-Team, TCB-Team, MediaWiki-History-and-Diffs
awight committed rQUIBBLE8e04b546bd50: Separate planning and execution phases (authored by awight).
Separate planning and execution phases
Tue, May 21, 10:56 PM
awight committed rQUIBBLEbeeb62a3bd58: Separate planning and execution phases (authored by awight).
Separate planning and execution phases
Tue, May 21, 10:23 PM
awight committed rQUIBBLEc18e6e8cb42f: [WIP] Rough out plan-execution decoupling (authored by awight).
[WIP] Rough out plan-execution decoupling
Tue, May 21, 8:12 PM
awight committed rQUIBBLEe6a8d8dc426e: [WIP] Rough out plan-execution decoupling (authored by awight).
[WIP] Rough out plan-execution decoupling
Tue, May 21, 7:18 PM
awight moved T223752: Decouple Quibble planning and execution phases from In-progress to Untriaged on the Continuous-Integration-Infrastructure board.
Tue, May 21, 7:02 PM · Patch-For-Review, Quibble
awight moved T223752: Decouple Quibble planning and execution phases from Backlog to In progress on the Quibble board.
Tue, May 21, 7:02 PM · Patch-For-Review, Quibble
awight moved T223752: Decouple Quibble planning and execution phases from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.
Tue, May 21, 7:01 PM · Patch-For-Review, Quibble
awight added a comment to T223752: Decouple Quibble planning and execution phases.

Some successes in the WIP patch so far. It actually runs through the whole process through browser testing, at least when smoke-testing a trivial code path. It prints a medium-granularity execution plan, and flag --plan-only stops before execution. I'm happy about how all command parameters must be explicitly passed into the constructor, so there are no self.* surprises which might cause implicit coupling issues later, and the command implementations can be extracted into separate modules as desired. Personally, I think that's a good direction to go in, so that each module has one general responsibility. The ZuulCloneCommand build_params hack isn't completely disgusting, which is unexpected.

Tue, May 21, 6:44 PM · Patch-For-Review, Quibble
awight committed rQUIBBLEa64887754e33: [WIP] Rough out plan-execution decoupling (authored by awight).
[WIP] Rough out plan-execution decoupling
Tue, May 21, 5:16 PM
awight committed rQUIBBLEf565174b7099: [WIP] Rough out plan-execution decoupling (authored by awight).
[WIP] Rough out plan-execution decoupling
Tue, May 21, 5:04 PM
awight committed rQUIBBLE882c23e250ce: [WIP] Rough out plan-execution decoupling (authored by awight).
[WIP] Rough out plan-execution decoupling
Tue, May 21, 4:28 PM
awight added a comment to T223752: Decouple Quibble planning and execution phases.

I ran into another complication: the zuul cloner takes a huge number of parameters, plus reading from the environment. The command abstraction shouldn't explicitly wire the parameters together because that would be fragile and high-maintenance. The only trick I've come up with so far is to separate the parameters into a list of projects, then an opaque **kwargs which is built by the calling code and by the quibble.zuul module. I don't like it, but there is one small benefit, that it facilitates dumping the entire list of parameters to zuul for debugging.

Tue, May 21, 3:00 PM · Patch-For-Review, Quibble
awight added a comment to T200018: File exporter beta feature does not have an RTL image.

For entertainment:

Tue, May 21, 1:33 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, Beta-Feature, good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight renamed T224007: Show Now Commons info for files that were moved from en.wikipedia from Show Now Commons info for files that where moved from en.wikipedia to Show Now Commons info for files that were moved from en.wikipedia.
Tue, May 21, 1:19 PM · TCB-Team, Move-Files-To-Commons
awight renamed T223373: Advise users which template to add to the source wiki. from Advice users which template to add to the source wiki. to Advise users which template to add to the source wiki..
Tue, May 21, 1:11 PM · TCB-Team, Move-Files-To-Commons
awight claimed T223967: Tangential CI work to support Tech Wishes.
Tue, May 21, 12:04 PM · WMDE-QWERTY-Sprint-2019-05-15
awight moved T223379: Set up config pages that can be used for testing purposes from Doing to Review on the WMDE-QWERTY-Sprint-2019-05-15 board.
Tue, May 21, 10:59 AM · Patch-For-Review, TCB-Team, Move-Files-To-Commons, WMDE-QWERTY-Sprint-2019-05-15
awight added a comment to T223379: Set up config pages that can be used for testing purposes.

I've copied some configuration into here, https://commons.wikimedia.beta.wmflabs.org/wiki/Extension:FileImport/Data

Tue, May 21, 10:59 AM · Patch-For-Review, TCB-Team, Move-Files-To-Commons, WMDE-QWERTY-Sprint-2019-05-15
awight moved T223967: Tangential CI work to support Tech Wishes from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-05-15 board.
Tue, May 21, 9:47 AM · WMDE-QWERTY-Sprint-2019-05-15
awight created T223967: Tangential CI work to support Tech Wishes.
Tue, May 21, 9:28 AM · WMDE-QWERTY-Sprint-2019-05-15
awight added a comment to T211703: CI should run composer test/npm test BEFORE running Quibble.

How does this relate to T211702: Quibble initialize step should only clone the target repository? It seems that they are redundant, if we do this task then the lint steps should be skipped in Quibble, and if we do the other task then this one is irrelevant.

Tue, May 21, 7:32 AM · Release-Engineering-Team (Backlog), Quibble (marble)

Mon, May 20

awight committed rESCCaed80c7fee9a: Hide VisualEditor welcome dialog during tests (authored by thiemowmde).
Hide VisualEditor welcome dialog during tests
Mon, May 20, 10:33 PM
awight added a comment to T223379: Set up config pages that can be used for testing purposes.

Reading about the differences between beta commons and beta testwiki, I think that beta commons is the right target for this change. Specifically, betacommons currently

does not respect CommonsHelper2 config files

Mon, May 20, 12:39 PM · Patch-For-Review, TCB-Team, Move-Files-To-Commons, WMDE-QWERTY-Sprint-2019-05-15
awight claimed T223379: Set up config pages that can be used for testing purposes.
Mon, May 20, 12:14 PM · Patch-For-Review, TCB-Team, Move-Files-To-Commons, WMDE-QWERTY-Sprint-2019-05-15
awight updated the task description for T222873: Design behavior when importing an uncategorized file.
Mon, May 20, 9:28 AM · Move-Files-To-Commons, TCB-Team
awight added a comment to T222873: Design behavior when importing an uncategorized file.

One possibility I see is having a rather humble pointer to it:

Mon, May 20, 9:28 AM · Move-Files-To-Commons, TCB-Team
awight claimed T189573: Display current category state on Import Preview Page.
Mon, May 20, 8:53 AM · WMDE-QWERTY-Sprint-2019-05-15, Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-30, TCB-Team, Move-Files-To-Commons
awight committed rEFLI371cbb5d7049: Display current categories on preview page (authored by Andrew-WMDE).
Display current categories on preview page
Mon, May 20, 8:44 AM

Sat, May 18

awight created T223752: Decouple Quibble planning and execution phases.
Sat, May 18, 9:30 PM · Patch-For-Review, Quibble

Fri, May 17

awight added a comment to T219114: phan 1.2.6 is OOMing on MediaWiki core.

Oh :-) That's even simpler than I was imagining, since we own the wrapper script. I think your migration will work: we leave jjb/* configuration alone and deploy your run.sh patch, then remove the redundant subpaths from jjb. I was able to verify that the trailing path parameter is harmless.

Fri, May 17, 10:32 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan
awight added a comment to T223431: Need a mechanism for injecting a LocalSettings.php fragment before nodejs browser tests.

It would be nice to package the PHP fragments in a conf.d-style directory, which gets cleaned and repopulated between browser tests on each repo, to reduce the chance of interference between tests.

Fri, May 17, 1:59 PM · Continuous-Integration-Infrastructure

Thu, May 16

awight added a comment to T219114: phan 1.2.6 is OOMing on MediaWiki core.

How about we disable the progress bar while leaving the phan version the same?

Thu, May 16, 10:10 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan
awight added a comment to T223021: Clean up FileImporter test class namespaces.

From my experience, the best naming scheme is FileImporter\Tests\…, followed by a copy of the namespace of the file under test. The most relevant advantage of this scheme is that it allows very convenient PSR-4 class loading.

Thu, May 16, 3:29 PM · good first bug, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight moved T190829: Test WikiTextEditor class with browser tests. from Doing to Review on the WMDE-QWERTY-Sprint-2019-05-15 board.

This patch plus https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/510709/ should do the job.

Thu, May 16, 1:26 PM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
awight committed rEFLIe5bb6aac6ba6: Browser tests for external dependencies (authored by awight).
Browser tests for external dependencies
Thu, May 16, 1:19 PM
awight moved T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests from Enhancement to In progress on the Quibble board.

@hashar This is ready for review, and I've smoke-tested locally. The big question IMO is whether I've implemented the desired functionality, this will run npm install && npm run selenium-test in each of self.dependencies which includes a tests/selenium.

Thu, May 16, 12:58 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin
awight committed rQUIBBLE9dea5826ab75: Run node browser tests in each repo (authored by awight).
Run node browser tests in each repo
Thu, May 16, 12:15 PM
awight committed rQUIBBLE89e8473cad97: Run node browser tests in each repo (authored by awight).
Run node browser tests in each repo
Thu, May 16, 12:01 PM
awight committed rQUIBBLE275fc65c1b57: [WIP] Run node browser tests in each repo (authored by awight).
[WIP] Run node browser tests in each repo
Thu, May 16, 11:31 AM
awight added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

Reading the task description again, I see that my understanding was slightly different than the original suggestion. The request is to run *all* extension and skin tests.

Thu, May 16, 10:52 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin
awight added a comment to T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests.

I'm going to take a brief look at this. The changes will need to be made in several steps, AIUI:

  • Patch quibble to run npm install && npm run selenium-test in the extension-or-skin root directory.
  • Build a new quibble image
  • Patch integration-config to use the new quibble image.
  • Tests will be duplicated at this point. We should verify this--each repo with tests/selenium/specs/*.js should also have a selenium-test script listed in package.json.
  • Remove extensions and skins from search patch in mw-core wdio.conf.js
Thu, May 16, 10:47 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-Core-Testing, Release-Engineering-Team (Kanban), Quibble, User-zeljkofilipin
awight added a comment to T223431: Need a mechanism for injecting a LocalSettings.php fragment before nodejs browser tests.

Looks like the biggest blocker is T199116: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests, because:

mwselenium.sh wouldn't quite work in our case, since the test is being run from mw-core

Thu, May 16, 10:27 AM · Continuous-Integration-Infrastructure
awight added a comment to T190829: Test WikiTextEditor class with browser tests..

Because of T223431, we might have to introduce some nasty code changes and a test-only parameter to allow us to navigate to Special:ImportFile pages even when $wgEnableUploads is false. Of course, the final check must be respected to prevent actually uploading on submit.

Thu, May 16, 10:15 AM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
awight updated the task description for T223431: Need a mechanism for injecting a LocalSettings.php fragment before nodejs browser tests.
Thu, May 16, 10:14 AM · Continuous-Integration-Infrastructure
awight created T223431: Need a mechanism for injecting a LocalSettings.php fragment before nodejs browser tests.
Thu, May 16, 10:06 AM · Continuous-Integration-Infrastructure
awight committed rEFLId562a9021605: Browser tests for external dependencies (authored by awight).
Browser tests for external dependencies
Thu, May 16, 9:34 AM
awight committed rEFLIc8cec0d7df4b: Browser tests for external dependencies (authored by awight).
Browser tests for external dependencies
Thu, May 16, 8:12 AM

Wed, May 15

awight updated subscribers of T190829: Test WikiTextEditor class with browser tests..

I'm able to connect to commonswiki from an integration worker, so this theory might be wrong.

Wed, May 15, 4:23 PM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
awight added a comment to T190829: Test WikiTextEditor class with browser tests..

Thoughts: we can upload a file to the local test wiki, implement a test-only parameter "ignoreDuplicateHash", and import from self.

Wed, May 15, 4:13 PM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
awight added a comment to T190829: Test WikiTextEditor class with browser tests..

Oooh--my current guess is now simply that we can't connect to commonswiki from the test.

Wed, May 15, 4:02 PM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
awight committed rEFLI1bfee6744bd3: Browser tests for external dependencies (authored by awight).
Browser tests for external dependencies
Wed, May 15, 3:57 PM
awight moved T190829: Test WikiTextEditor class with browser tests. from Review to Doing on the WMDE-QWERTY-Sprint-2019-05-15 board.

These tests are still failing in CI, and I'm short on clues to debug. All I know is that the expected element (edit file info button) isn't present on Special:ImportFile?clientUrl=..., which shouldn't require any special LocalSettings.php configuration, it should Just Work as long as the extension is installed.

Wed, May 15, 3:44 PM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
Gerrit Code Review <gerrit@wikimedia.org> committed rEFLIe3ad0d3472d4: Merge "Fix deprecation warning on EditPage without context title" (authored by awight).
Merge "Fix deprecation warning on EditPage without context title"
Wed, May 15, 3:22 PM
awight added a comment to T190829: Test WikiTextEditor class with browser tests..

Correction--it looks like mw-core browser tests will run for every patch, regardless. So we might as well keep what I've done, and consider additional daily tests via a patch like https://gerrit.wikimedia.org/r/#/c/integration/config/+/502356/7/jjb/mediawiki-extensions.yaml

Wed, May 15, 3:16 PM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
awight added a comment to T190829: Test WikiTextEditor class with browser tests..

Currently I have the browser test running with every patch submitted to Gerrit, but we might want to only run these tests daily instead, since we're mostly checking for external breaking changes and almost nothing we do in the extension should change these integrations. For example, if WikiEditor will break our ChangeInfoEditForm a few months after we stop working on FileImporter, we want to get an alert.

Wed, May 15, 3:06 PM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
awight committed rEFLI1b7b806450df: Browser tests for external dependencies (authored by awight).
Browser tests for external dependencies
Wed, May 15, 2:58 PM
awight committed rEFLIa8549bcf212e: Browser tests for external dependencies (authored by awight).
Browser tests for external dependencies
Wed, May 15, 2:19 PM
awight committed rEFLI647205bb0755: Fix deprecation warning on EditPage without context title (authored by thiemowmde).
Fix deprecation warning on EditPage without context title
Wed, May 15, 2:19 PM
awight moved T190829: Test WikiTextEditor class with browser tests. from Doing to Review on the WMDE-QWERTY-Sprint-2019-05-15 board.
Wed, May 15, 2:14 PM · User-zeljkofilipin, Patch-For-Review, WMDE-QWERTY-Sprint-2019-05-15, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons
awight committed rEFLIeb0f75362fc9: [WIP] Browser tests for external dependencies (authored by awight).
[WIP] Browser tests for external dependencies
Wed, May 15, 1:51 PM
awight committed rEFLIf7fdf668ff1e: [WIP] Browser tests for external dependencies (authored by awight).
[WIP] Browser tests for external dependencies
Wed, May 15, 12:23 PM
awight committed rEFLI5ff626d3be65: [WIP] Browser tests for external dependencies (authored by awight).
[WIP] Browser tests for external dependencies
Wed, May 15, 10:57 AM
awight updated subscribers of T223262: Request: add awight to contint-docker.

My manager is @Tobi_WMDE_SW, and the CI work would usually full under the maintenance / 20% category for that job. For example, right now I'm trying to help correct some flapping tests that are annoying for us, T219114: phan 1.2.6 is OOMing on MediaWiki core

Wed, May 15, 9:06 AM · Operations, Release-Engineering-Team (Backlog), SRE-Access-Requests, Continuous-Integration-Infrastructure

Tue, May 14

awight committed rQUIBBLE4150a8a61744: Minor copyediting (authored by awight).
Minor copyediting
Tue, May 14, 8:49 PM
awight added a comment to T223017: Isolate FileImporter integration test from external web services.
  • All the test might need to do is to replace the FileImporterHttpRequestExecutor service with a mock.
Tue, May 14, 1:45 PM · Patch-For-Review, WMDE-QWERTY-Team, Move-Files-To-Commons, TCB-Team
awight created T223262: Request: add awight to contint-docker.
Tue, May 14, 11:54 AM · Operations, Release-Engineering-Team (Backlog), SRE-Access-Requests, Continuous-Integration-Infrastructure

Mon, May 13

awight committed rEFLIedcf48ca953e: [WIP] Browser tests for external dependencies (authored by awight).
[WIP] Browser tests for external dependencies
Mon, May 13, 1:59 PM
awight committed rEFLIc08103e07f1d: [WIP] Browser tests for external dependencies (authored by awight).
[WIP] Browser tests for external dependencies
Mon, May 13, 8:54 AM
awight added a comment to T219114: phan 1.2.6 is OOMing on MediaWiki core.

I just experienced this crash 4 times in a row, when running CI on mw-ext-FileImporter. Looking at the integration-config repo,

./jjb/mediawiki-extensions.yaml:        image: 'docker-registry.wikimedia.org/releng/mediawiki-phan:0.1.11'
Mon, May 13, 7:27 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan