Yup @Ejegg I got it. I'll put up a patch tomorrow morning.
Thu, Aug 15
@Ejegg Oh! I think this is caused by the type being "number" as I've learned it happens when any value with a decimal place is entered.
@CCogdill_WMF Can you confirm whether you see the error message when you directly click on the "Donate Monthly" button versus just tabbing away? That's what I found in my testing but want to confirm it. Thanks!
I'm currently thinking this might be something from Firefox, because I noticed the red highlighting doesn't happen in Chrome and the errorHighlight class doesn't seem to have actually been applied. I'm trying to test one more idea.
There are two places I thought the initial error highlighting might be coming from: validation_input and ext.donationinterface.validation.js, but when I enter console.log statements in them, they are not logged.
Okay, so I've found more interesting behavior. Basically the error highlighting appears if I tab away from the box, but when I click "Donate Monthly" the error text appears. I've been trying to find where in the code the highlight is applied but haven't found it yet.
Wed, Aug 14
@XenoRyet Want to take a look at this or ask someone else to review?
So I had a weird experience testing this locally. I saw the error on my first test. Then I added some logging and tested again, and strangely the error text showed up! Then I tried to test without the logging (though it seemed weird if that fixed it) and there was an unrelated bug on ingenico's side that prevented me from testing further.
Also, do we know what we wanted to do on this during the sprint?
Or anyone else who remembers what our plan was? @Ejegg remembers something about mustache templates.
@jgleeson what did we plan to do here? Please write it up if you have time before leaving for Wikimania.
Tue, Aug 13
@Eileenmcnaughton It looks like you started this?
Fri, Aug 2
Hmm, so one question. Are we just looking for the fields in the custom set "Communication"? Also, I agree that so far there is no obvious place in our documentation to put this, but that means we need to create one.
@DStrine Do you just want the list on the task or somewhere else?
Fri, Jul 26
This also happened in 2017 with cid 1092521. The pending recurring contributions report (where I found this) only has 5 rows though so it's possible this is a limited issue.
Jul 10 2019
@Ejegg Has this been deployed?
@XenoRyet I see patches merged. Should this be moved to "Pending Deployment"?
@AndyRussG How you would you like this reviewed? I wasn't sure if this is what you and @jgleeson talked about yesterday, but it's a long train of patches and I'm wondering if we should start by +2ing the original patch, or work from the top down.
Jul 5 2019
@Ejegg What is the best way to test this change?
Notes from tech-talk review:
Jul 3 2019
We talked about this in fortnightly today. @NNichols If you search for Communication:Employer Name Regex [a-zA-Z] that will return only those with values. (Not Empty works too but is slow.)
Jun 28 2019
This was emotionally difficult but I went ahead and removed all his roles and blocked his user. @Eileenmcnaughton any thoughts on whether we should delete his user or keep it for historical records (as in any changes he might have made in Civi)?
Jun 27 2019
May 30 2019
May 13 2019
I didn't know this existed! I need to add a link on the documentation homepage.
May 8 2019
@chasemp Sorry this dropped of my radar! Finally done today. Thanks for the pings :).
May 7 2019
Apr 24 2019
Weird @Cstone looks like you correctly linked the task but it didn't show up here. Thanks!
@XenoRyet did I remember you talking about this yesterday in standup or was it another part of contribution_tracking?
@Cstone where is your patch for this that we were looking at?
Apr 19 2019
@Ejegg some of the errors were from Monday though.
@MBeat is #577898 a uk or swedish donor?
Apr 18 2019
Apr 9 2019
I'm moving this to done, but more feedback is still welcome.
@CaitVirtue will we be checking if their employer matches the gift? If I saw that text on a donation form, I'd expect an automatic lookup.
Apr 4 2019
Apr 3 2019
Weird @Ejegg I can see it on my iPhone 7.
Apr 1 2019
Our next step is to update the CSP settings, and test both ourselves, and see if we can get any in-country donors to test. Then we can switch back over during higher traffic European times, and do a live test for a few hours. @cwdent @Ejegg does that sound right to you?
Mar 28 2019
@Ejegg would we both write to the db and use a queue?
@Ejegg Thanks! It looks good. I'm closing this.
Mar 27 2019
@Ejegg I don't see any edits from you in the page history. Where did you put them?
Mar 22 2019
Next todo: break Dashboard out into it's own page
Mar 21 2019
I've started on this. Currently trying to decide which headings belong on the main page versus sub pages. I want to break up the big block called "Documents" and move the software installation to a separate page.
Mar 19 2019
Mar 18 2019
Oops, this was just a mistaken click!
Mar 15 2019
Mar 14 2019
Mar 13 2019
Page created at https://collab.wikimedia.org/wiki/Fundraising/Engineering/Onboarding. Now I need to re-add links and formatting.
@Ejegg would this be a good tech talk topic or pairing exercise?
Mar 11 2019
I also updated my column!
@Cstone I added you but did not fill in any boxes.
Mar 7 2019
Mar 6 2019
Thanks @cwdent for taking the time to answer to each question. It sounds like you're very concerned about deploying this change, and I appreciate that given the importance of the effected systems.