Page MenuHomePhabricator
Feed Advanced Search

Fri, Dec 6

Od1n added a comment to T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML.

We had a related on issue on frwiki (see talk, involving template Liste éléments):

Fri, Dec 6, 6:46 PM · Performance-Team (Radar), Parsing-Team, MediaWiki-Parser, TemplateStyles

Nov 10 2019

Od1n awarded T137584: Allow Scribunto code to add a category without changing output a Like token.
Nov 10 2019, 4:36 PM · MediaWiki-extensions-Scribunto

Nov 6 2019

Od1n updated subscribers of T197902: Be more selective in applying French Space armoring.

@thiemowmde Your benchmarks are above :)

Nov 6 2019, 5:01 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), MediaWiki-Parser
Od1n added a comment to T237490: Collect feedback from module and gadget authors for Developer Productivity & onwiki tooling techconf session.
  1. Volunteer developer at frwiki.
  2. For me the main issue is that some scripts are just maintenance nightmares.
    • Examples:
    • The issues are, more precisely:
      • Very few people are able to work on these codes (or are willing to spend dozens of hours to understand the whole script and to investigate the interactions with the other scripts).
      • We are close to a bus factor 1. When the creator of a script leaves the project, there's no one else crazy enough to carry on such script.
      • It's nearly impossible to make any change without breaking something (in the script, or in interacting scripts), also without making the code even more complicated. Making a "clean" change requires a lot of skills and time.
    • Thoughts about improving this:
      • Anything that would improve modularity and decoupling would be good to take. Slicing these monolithic monstruosities into smaller codes that could be worked on separately, sanely.
      • Same with things like unit testing, automated reports, and such. Anything that would help spotting any regressions immediately, or at least before they become difficult to fix.
Nov 6 2019, 4:53 PM · Wikimedia-Technical-Conference-2019

Oct 30 2019

Od1n added a comment to T197902: Be more selective in applying French Space armoring.

$text = str_repeat( 'lorem ipsum dolor sit amet', 1000 );
$space = '&#160;';

Oct 30 2019, 7:58 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), MediaWiki-Parser

Oct 26 2019

Od1n added a comment to T197902: Be more selective in applying French Space armoring.

@cscott I see you have improved it even further :)

Oct 26 2019, 8:49 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), MediaWiki-Parser

Oct 25 2019

Od1n added a comment to T197902: Be more selective in applying French Space armoring.

The code could be optimized as so:

Oct 25 2019, 12:51 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), MediaWiki-Parser

Oct 18 2019

Od1n added a comment to T213426: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle.

frwiki has been updated:

Oct 18 2019, 12:36 AM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.35-release, Growth-Team, Metrolook, WikiEditor, Wikidata, MediaWiki-extensions-Translate, MediaViewer, MassMessage, Maps (Kartographer), MediaWiki-extensions-InputBox, MediaWiki-extensions-Graph, StructuredDiscussions, MediaWiki-extensions-CentralNotice, Technical-Debt (Deprecation process), JavaScript, MediaWiki-General

Oct 12 2019

Od1n added a comment to T235300: Replace 'editToken' from mw.user.tokens by 'csrfToken' in on-wiki gadgets.

Ok, I got the point of, basically, not duplicating the API documentation into the page ResourceLoader/Core modules, and just making the latter link to the former. Entirely agree with this.

Oct 12 2019, 2:23 AM · Wikimedia-General-or-Unknown, Performance-Team
Od1n added a comment to T235300: Replace 'editToken' from mw.user.tokens by 'csrfToken' in on-wiki gadgets.

@Krinkle:

  • If I documented something private/internal that should be by mistake, as it's something I would like to avoid too. Maybe you found an example of this?
  • Indeed I have noticed your maintenance work on this page (amongst all the rest of course). That's very appreciated.
Oct 12 2019, 2:17 AM · Wikimedia-General-or-Unknown, Performance-Team

Oct 11 2019

Od1n added a comment to T235300: Replace 'editToken' from mw.user.tokens by 'csrfToken' in on-wiki gadgets.

Great explanation by Krinkle above, in particular the following:

Oct 11 2019, 11:42 PM · Wikimedia-General-or-Unknown, Performance-Team
Od1n added a comment to T235300: Replace 'editToken' from mw.user.tokens by 'csrfToken' in on-wiki gadgets.

Just to mention the "de facto" documentation hadn't been updated.

Oct 11 2019, 11:32 PM · Wikimedia-General-or-Unknown, Performance-Team
Od1n awarded T235300: Replace 'editToken' from mw.user.tokens by 'csrfToken' in on-wiki gadgets a Barnstar token.
Oct 11 2019, 11:21 PM · Wikimedia-General-or-Unknown, Performance-Team

Oct 8 2019

Od1n added a comment to T218339: Deprecate and remove mediawiki.RegExp.

Just as a kind reminder, ResourceLoader/Core modules documentation would need updating.

Oct 8 2019, 12:35 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.35-release, MediaWiki-General, Performance-Team, Technical-Debt (Deprecation process)

Sep 5 2019

Od1n added a comment to T210508: Highlighting does not work if span with mw-cite-backlink class is removed.

For the record, on frwiki I have changed the classname back to the regular name (refs Cite references link one, Cite references link many), as I think it's the only proper way to handle this. The classname just shouldn't had been allowed to be renamed in the first place. Triggered by the custom name, these subsequent JavaScript workarounds were in turn causing some bug in gadget ReferenceTooltips...

Sep 5 2019, 12:42 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), WMDE-QWERTY-Sprint-2018-11-20, Patch-For-Review, Cite, TCB-Team
Od1n added a comment to T210520: Customized messages mess order of DOM elements up.

For the record, on frwiki I have changed the classname back to the regular name (refs Cite references link one, Cite references link many), as I think it's the only proper way to handle this. The classname just shouldn't had been allowed to be renamed in the first place. Triggered by the custom name, these subsequent JavaScript workarounds were in turn causing some bug in gadget ReferenceTooltips...

Sep 5 2019, 12:41 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), WMDE-QWERTY-Sprint-2018-11-20, TCB-Team, Cite
Od1n added a comment to T205270: Highlight the important jump mark letter by making it bold.

For the record, on frwiki I have changed the classname back to the regular name (refs Cite references link one, Cite references link many), as I think it's the only proper way to handle this. The classname just shouldn't had been allowed to be renamed in the first place. Triggered by the custom name, these subsequent JavaScript workarounds were in turn causing some bug in gadget ReferenceTooltips...

Sep 5 2019, 12:41 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Cite, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, WMDE-QWERTY-Sprint-2018-11-06, TCB-Team, German-Community-Wishlist, patch-welcome

Aug 14 2019

Od1n added a comment to T228604: Clean up party of Mediawiki:Common.css at Wikimania 2019.

Do not forget that to use TemplateStyles in Editnotices (messages that display while editing) you need to add <div class="mw-parser-output"> wrapper :)

Aug 14 2019, 2:46 PM · Bengali-Sites, Performance Issue, TemplateStyles, Wikimania-Hackathon-2019

Dec 3 2018

Od1n added a comment to T142882: `usergroups` field label entity-encoded twice in Special:Preferences.

Note that previously the preferences had been fixed, by using in the message a nbsp character (instead of a html entity), and it was working fine.

Dec 3 2018, 3:52 AM · MediaWiki-Special-pages

Sep 30 2018

Od1n added a comment to T29693: File links containing double pipes ([[File:Foo.jpg|16px||Bar]] etc) are mangled inside wikitables.

On the other hand, there is for sure a bug in the parser...
So even if this one resulting issue may be ignored, we have here an open gate for other issues.

Sep 30 2018, 2:59 PM · MediaWiki-Parser

Sep 23 2018

Od1n created T205212: Echo-pref-email-frequency-never shows HTML entity &#039; instead of apostrophe ' in notification preferences.
Sep 23 2018, 6:41 AM · Growth-Team, Notifications, MediaWiki-User-preferences

Sep 18 2018

Od1n awarded T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec" a Like token.
Sep 18 2018, 4:30 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Tidy, Community-Relations-Support, Parsoid, MediaWiki-Parser

Aug 28 2018

Od1n added a comment to T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1.

Same for docblock of Window::open, which should be updated according to WindowManager::openWindow.

Aug 28 2018, 2:41 PM · OOUI (OOjs-UI-0.22.0)

Aug 27 2018

Od1n added a comment to T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1.

Return value in docblock of Window::close should be updated accordingly, copying the return value from docblock of WindowManager::closeWindow.

Aug 27 2018, 6:44 AM · OOUI (OOjs-UI-0.22.0)

Aug 23 2018

Od1n added a comment to T194945: Infobox overlaps with text, prevents editing the latter..

How about using a bot to move {{Infobox/Titre en italique}} bricks into the infoboxes, i.e. above the closing brick {{Modèle:Infobox/Fin}}? Then documenting this so that editors don't reintroduce back the issue.

Aug 23 2018, 10:50 PM · Parsoid, VisualEditor

Jul 27 2018

Od1n closed T199595: Undo use of some custom interface messages on frwiki ("nstab-projet" etc) as Invalid.

Closing, per the explanation above :)

Jul 27 2018, 6:58 PM · Wikimedia-Site-requests

Jul 22 2018

Od1n added a comment to T168333: CSS is duplicated on each template usage.

For the deduplicated styles, do we really need the <link> tags? Couldn't we completely remove the tag?

Jul 22 2018, 9:32 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Performance-Team (Radar), Patch-For-Review, Technical-Debt, TemplateStyles

Jul 21 2018

Od1n added a comment to T191452: Deploy TemplateStyles on French Wikipedia on 2018-07-19.

Just to clarify, I was precisely concerned about TemplateStyles in small templates invoked many times. More precisely:

  • Server-side: all processing time for parsing, deduplicating, etc. (CPU/RAM usage)
  • Client-side (which I'm more worried about): cost of markup bloat with the numerous added <link> tags (page size, also CPU/RAM usage)
Jul 21 2018, 5:59 PM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests, TemplateStyles

Jul 19 2018

Od1n awarded T200021: MediaWiki:Oathauth-step1-test misses a final dot a Orange Medal token.
Jul 19 2018, 7:22 PM · Patch-For-Review, MediaWiki-extensions-OATHAuth

Jul 14 2018

Od1n created T199595: Undo use of some custom interface messages on frwiki ("nstab-projet" etc).
Jul 14 2018, 5:27 AM · Wikimedia-Site-requests

Jul 13 2018

Od1n updated the task description for T199496: Remove frwiki outdated entries in robots.txt.
Jul 13 2018, 3:28 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests
Od1n added a parent task for T199496: Remove frwiki outdated entries in robots.txt: T16720: robots.txt (tracking).
Jul 13 2018, 3:28 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests
Od1n added a subtask for T16720: robots.txt (tracking): T199496: Remove frwiki outdated entries in robots.txt.
Jul 13 2018, 3:28 AM · Tracking-Neverending, Wikimedia-Site-requests
Od1n created T199496: Remove frwiki outdated entries in robots.txt.
Jul 13 2018, 3:27 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests

Jul 3 2018

Od1n added a comment to T194945: Infobox overlaps with text, prevents editing the latter..

This makes sense. I am just uncomfortable with removing the "nowiki" from the sub (and main) template {{Titre en italique}}. That one "nowiki" fixes many cases of empty <p>.

Jul 3 2018, 2:21 PM · Parsoid, VisualEditor
Od1n added a comment to T194945: Infobox overlaps with text, prevents editing the latter..

The output HTML are two properly distinct elements, a div followed by a p, and the p is clearly outside of the template transclusion. Thus I maintain the issue is at the visual editor level.

Jul 3 2018, 1:11 PM · Parsoid, VisualEditor

Jul 2 2018

Od1n added a comment to T194945: Infobox overlaps with text, prevents editing the latter..

Though it's quite clear these <nowiki /> are tricky, I'd say the issue discussed here is rather in the visual editor, which should properly handle the case.

Jul 2 2018, 10:58 PM · Parsoid, VisualEditor

Jun 24 2018

Od1n awarded T193314: Remove document.write support (deprecated since 1.26) a Barnstar token.
Jun 24 2018, 12:31 AM · Technical-Debt (Deprecation process), Performance-Team, MediaWiki-ResourceLoader

Jun 23 2018

Od1n added a comment to T192623: ResourceLoader 2018 Review.

Wow, that's quite an impressive reply! Thank you. Pinned.

Jun 23 2018, 4:49 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team
Od1n added a comment to T192623: ResourceLoader 2018 Review.

I'll just also mention toolbar customization, which has been modified several times, and has become a real pain for users.

Jun 23 2018, 3:43 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team
Od1n added a comment to T192623: ResourceLoader 2018 Review.

Not strictly deprecation/removal, but off the very top of my head:

Jun 23 2018, 12:45 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team

Jun 22 2018

Od1n added a comment to T192623: ResourceLoader 2018 Review.

I just found it was cumbersome to manage different versions of scripts, depending on MediaWiki version, swimming on short intervals like 6 months.
Moving to forward-compatbility implying to break backward-compatibility even for recent and supported MediaWiki versions.

Jun 22 2018, 1:41 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team
Od1n added a comment to T192623: ResourceLoader 2018 Review.

I think the legacy "mediawiki.api.*" modules should be removed later than in MediaWiki 1.33.

Jun 22 2018, 1:32 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team

Jun 3 2018

Od1n added a comment to T192033: Older skins no longer bold Self links.

So, there is still Modern to fix.

Jun 3 2018, 12:53 AM · MediaWiki-extensions-General, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14))

May 20 2018

Od1n created T195192: Missing search results when using contentmodel filter.
May 20 2018, 11:28 AM · Discovery-Search, Discovery, CirrusSearch

May 19 2018

Od1n awarded T195049: Remove animations from jquery.makeCollapsible a Party Time token.
May 19 2018, 12:43 PM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Wikimedia-Hackathon-2018, MediaWiki-General, CSS, JavaScript

May 17 2018

Od1n removed a project from T183783: Missing some "noflip" directives for thumbs in Timeless skin: Patch-For-Review.
May 17 2018, 10:24 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Timeless, CSS
Od1n closed T183783: Missing some "noflip" directives for thumbs in Timeless skin as Resolved.

Looks like it's solved, the patch having been merged.

May 17 2018, 10:21 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Timeless, CSS

May 14 2018

Od1n placed T194655: Special:PrefixIndex no longer put current prefix in the prefix input up for grabs.
May 14 2018, 2:00 PM · MediaWiki-Special-pages
Od1n closed T194655: Special:PrefixIndex no longer put current prefix in the prefix input as Resolved.

Indeed, duplicate.
Apparently the whole thing was just broken, and the fix is to be deployed soon.

May 14 2018, 1:58 PM · MediaWiki-Special-pages
Od1n created T194655: Special:PrefixIndex no longer put current prefix in the prefix input.
May 14 2018, 1:03 PM · MediaWiki-Special-pages

May 12 2018

Od1n added a comment to T193826: Organise module files in directories based on their module name.

I have just updated a few links, there are probably more remaining.

May 12 2018, 6:35 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Performance-Team (Radar), Front-end-Standards-Group, MediaWiki-ResourceLoader

Apr 30 2018

Od1n added a comment to T187460: Provide a gadget migration script.

Thank you for these explanations :)

Apr 30 2018, 1:13 AM · Patch-For-Review, User-DannyS712, Core Platform Team, MediaWiki-extensions-Gadgets

Apr 29 2018

Od1n added a comment to T186702: Request to manually rename a gadget in fr.wiki database.

Bump :) Is there someone able to do it? Is the task easy or not?

Apr 29 2018, 10:06 PM · Wikimedia-Site-requests

Apr 13 2018

Od1n updated subscribers of T192033: Older skins no longer bold Self links.

At least, the self links shouldn't be blue, using some a:not([href]) CSS as it has been done for Minerva.

Apr 13 2018, 4:25 AM · MediaWiki-extensions-General, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14))

Apr 12 2018

Od1n added a comment to T192033: Older skins no longer bold Self links.

By the way, I checked on Timeless, and the self links are blue, as regular links. That is wrong for sure.

Apr 12 2018, 3:12 AM · MediaWiki-extensions-General, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14))
Od1n added a comment to T192033: Older skins no longer bold Self links.

I mean that the bold removal and the underline on hover are by design ;) But I may be mistaken.

Apr 12 2018, 3:08 AM · MediaWiki-extensions-General, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14))
Od1n added a comment to T192033: Older skins no longer bold Self links.

I think it is by design.

Apr 12 2018, 2:51 AM · MediaWiki-extensions-General, MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14))
Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.

@MusikAnimal I figured it out exactly at the same time ;)

Apr 12 2018, 1:39 AM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments
Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.

@MusikAnimal I've noticed your revert. Actually, there might be something missing in the extension implementation in MediaWiki. Compare the two following sets of Lua debug outputs:

Apr 12 2018, 1:26 AM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments

Apr 11 2018

Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.
Apr 11 2018, 5:17 PM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments
Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.

Yes, please uncomment it, so you can at the very same moment check if it is running fine.

Apr 11 2018, 5:15 PM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments
Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.

@MusikAnimal I have implemented this extension in the module.

Apr 11 2018, 9:59 AM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments

Apr 10 2018

whym awarded T181472: "a.mw-selflink" links miss styling a Love token.
Apr 10 2018, 2:10 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MediaWiki-extensions-MobileApp, Mobile, Wikipedia-Android-App-Backlog

Apr 2 2018

Od1n added a comment to T183718: Image border missing in Timeless skin.

I made the patch, but the Gerrit Patch Uploader currently fails to submit it (and there is no error message).

Apr 2 2018, 9:52 AM · MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless

Mar 30 2018

Od1n closed T190538: Request to manually add "bot flag" to past edits by bot account as Resolved.

One week already, I got no more reports about this. If there is no one willing to nonetheless fix it, I think this ticket can just be closed.

Mar 30 2018, 3:25 AM · Wikimedia-Site-requests

Mar 23 2018

Od1n created T190538: Request to manually add "bot flag" to past edits by bot account.
Mar 23 2018, 4:55 PM · Wikimedia-Site-requests

Mar 8 2018

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Just to clarify, the patch that has just been merged is not for the issue of this ticket, but for a related issue.

Mar 8 2018, 3:28 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MediaWiki-extensions-MobileApp, Mobile, Wikipedia-Android-App-Backlog

Mar 5 2018

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

This needs more than the single rule above. I had to add the following to fr.wiki: https://fr.wikipedia.org/w/index.php?title=MediaWiki:Mobile.css&diff=prev&oldid=143649876

Mar 5 2018, 8:24 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MediaWiki-extensions-MobileApp, Mobile, Wikipedia-Android-App-Backlog

Mar 2 2018

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Thank you for this addition. But as I stated a bit above, these missing styles are simply an overlook from T160480. There is just no reason not to add them.

Mar 2 2018, 1:16 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MediaWiki-extensions-MobileApp, Mobile, Wikipedia-Android-App-Backlog

Feb 27 2018

Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

If template returns #ccc and is used as style="color:{{template}}", {{#balance:inline}} would break the template, as it wraps the output with <span>...</span>.

Feb 27 2018, 9:47 PM · Epic, MediaWiki-Parser

Feb 12 2018

Od1n added a comment to T38742: Elements with blacklisted class get removed only if it's their only class.

For convenience, refs https://phabricator.wikimedia.org/T31157 (relocation of bugzilla 29157).

Feb 12 2018, 3:17 AM · MobileFrontend-stable

Feb 7 2018

Od1n added a comment to T186710: When creating a new task, tags should be middle-clickable to go to their description page.

Phabricator's Contributing Code:

Feb 7 2018, 5:06 PM · Phabricator (Upstream), Upstream
Od1n added a comment to T186710: When creating a new task, tags should be middle-clickable to go to their description page.

Even in this "Browse Projects" modal, there is no link to go to the tag page!

Feb 7 2018, 2:47 PM · Phabricator (Upstream), Upstream
Od1n edited projects for T186702: Request to manually rename a gadget in fr.wiki database, added: Wikimedia-Site-requests; removed Wikimedia-General-or-Unknown.
Feb 7 2018, 2:17 PM · Wikimedia-Site-requests
Od1n created T186710: When creating a new task, tags should be middle-clickable to go to their description page.
Feb 7 2018, 2:11 PM · Phabricator (Upstream), Upstream
Od1n created T186702: Request to manually rename a gadget in fr.wiki database.
Feb 7 2018, 12:14 PM · Wikimedia-Site-requests

Feb 1 2018

Od1n closed T117646: Fix recentchangesbox Gadget on French Wikipedia as Resolved.
Feb 1 2018, 1:25 PM · Community-Tech, Community-Tech-fixes, good first task
Od1n closed T117646: Fix recentchangesbox Gadget on French Wikipedia, a subtask of T110185: Gadgets not working on the French Wikipedia, as Resolved.
Feb 1 2018, 1:25 PM · JavaScript, Wikimedia-General-or-Unknown
Od1n closed T117755: Fix GlobalWatchlist gadget on French Wikipedia as Resolved.
Feb 1 2018, 1:25 PM · Community-Tech, Community-Tech-fixes, Google-Code-In-2015, good first task
Od1n closed T117755: Fix GlobalWatchlist gadget on French Wikipedia, a subtask of T110185: Gadgets not working on the French Wikipedia, as Resolved.
Feb 1 2018, 1:25 PM · JavaScript, Wikimedia-General-or-Unknown
Od1n closed T117756: Fix AdvancedResearch gadget on French Wikipedia as Resolved.
Feb 1 2018, 1:25 PM · Community-Tech, Community-Tech-fixes, Google-Code-In-2015, good first task
Od1n closed T117756: Fix AdvancedResearch gadget on French Wikipedia, a subtask of T110185: Gadgets not working on the French Wikipedia, as Resolved.
Feb 1 2018, 1:25 PM · JavaScript, Wikimedia-General-or-Unknown
Od1n added a comment to T117756: Fix AdvancedResearch gadget on French Wikipedia.

Fixed by this edit, yet I have removed this code just after as it's no longer needed.

Feb 1 2018, 1:04 PM · Community-Tech, Community-Tech-fixes, Google-Code-In-2015, good first task
Od1n added a comment to T117646: Fix recentchangesbox Gadget on French Wikipedia.

Has been fixed in this edit (search setTimeout).

Feb 1 2018, 9:16 AM · Community-Tech, Community-Tech-fixes, good first task
Od1n added a comment to T117755: Fix GlobalWatchlist gadget on French Wikipedia.

Should be working again, see notably this edit.

Feb 1 2018, 9:08 AM · Community-Tech, Community-Tech-fixes, Google-Code-In-2015, good first task

Jan 31 2018

Od1n added a comment to T183718: Image border missing in Timeless skin.

Any news on this?

Jan 31 2018, 11:47 AM · MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless
Od1n added a comment to T183827: Timeless: images (eg smileys) are not middle aligned with text.

For the demo above, note the CSS has been fixed locally.

Jan 31 2018, 11:46 AM · Patch-For-Review, Timeless

Jan 28 2018

Od1n created T185859: On [[Special:ExpandTemplates]], the "Input wikitext:" textarea should be resizable.
Jan 28 2018, 11:05 PM · OOUI (OOUI-0.26.2), Patch-For-Review, CSS, UI-Standardization, MediaWiki-Interface

Jan 21 2018

Od1n added a comment to T168763: Lua's mw.text.nowiki() should escape exclamation point "!" on new line.

How about just escaping all ! characters? It would escape more than necessary, but the code would be much simpler (in particular the PHP one).

Jan 21 2018, 10:05 PM · Patch-For-Review, MediaWiki-extensions-Scribunto

Jan 13 2018

Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

So, you don't think there is the same issue with the 2nd do/while of the for loop? I haven't checked it thoroughly, but it just looks very similar, with these n+2 steps. That's why I added the "overflow fix" after the for loop in my demonstration patch, to cover the two do/while's.

Jan 13 2018, 8:42 AM · affects-translatewiki.net, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team, Wikimedia-production-error, MediaWiki-ResourceLoader

Jan 10 2018

Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

Thank you for your work on this.

Jan 10 2018, 3:05 AM · affects-translatewiki.net, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team, Wikimedia-production-error, MediaWiki-ResourceLoader

Dec 30 2017

Od1n awarded T183823: Add 'fromsection' and 'tosection' to action=compare a Party Time token.
Dec 30 2017, 6:47 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, MediaWiki-API
Od1n added a comment to T160480: Selflinks should still be <a> tags with CSS styling via a class, not <strong> tags.

I was about to completely agree with Jdlrobson, but actually such links are HTML5's "placeholder links" and seem to be the recommended way…

Dec 30 2017, 10:06 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), User-Ryasmeen, Technical-Debt, MediaWiki-Parser, MediaWiki-General, Contributors-Team, VisualEditor

Dec 29 2017

Od1n updated the task description for T183783: Missing some "noflip" directives for thumbs in Timeless skin.
Dec 29 2017, 3:36 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Timeless, CSS
Od1n created T183783: Missing some "noflip" directives for thumbs in Timeless skin.
Dec 29 2017, 3:32 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Timeless, CSS
Od1n added a comment to T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes.

Code references:

Dec 29 2017, 7:11 AM · MediaWiki-Page-Diffs, JavaScript
Od1n added a comment to T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes.

There are two different points:

  • Texts "Latest revision" and "Your text" are always missing. They should be added, for consistency with the "non-live preview" mode.
  • When there is no difference (i.e. empty ajax diff content) the text "(No difference)" should be added.
Dec 29 2017, 7:05 AM · MediaWiki-Page-Diffs, JavaScript
Od1n added a comment to T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase.

Also, documentation needs to be updated: https://www.mediawiki.org/wiki/API:Revisions

Dec 29 2017, 6:54 AM · MW-1.30-release-notes, Technical-Debt, Patch-For-Review, MediaWiki-API
Od1n added a comment to T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase.

The JavaScript of "live preview"[1] gets deprecation warnings and has to be updated.

Dec 29 2017, 6:53 AM · MW-1.30-release-notes, Technical-Debt, Patch-For-Review, MediaWiki-API