Page MenuHomePhabricator
Feed Advanced Search

Sep 16 2015

TasneemLo added a comment to T101311: Add sniff for checking that "else" is on same line as previous closing brace.

Could you assign this to me please ?

Sep 16 2015, 6:50 AM · Patch-For-Review, good first task, MediaWiki-Codesniffer
TasneemLo renamed T112717: MediaWiki QUnit test suite has test failures on Firefox from issues with QUnit tests on MobileFrontend, Firefox to issues with QUnit tests on Firefox.
Sep 16 2015, 1:52 AM · MediaWiki-Core-Tests
TasneemLo created T112717: MediaWiki QUnit test suite has test failures on Firefox.
Sep 16 2015, 1:32 AM · MediaWiki-Core-Tests

Sep 15 2015

TasneemLo committed rECTX86f5a000efbb: Use standard blue to highlight buttons.
Use standard blue to highlight buttons
Sep 15 2015, 5:35 AM
TasneemLo added a comment to T112280: phpcs doesnt exit when timed out in composer.

I don't seem to be able to reproduce this anymore, so I am not sure if this is really an issue.

Sep 15 2015, 1:46 AM · Upstream, MediaWiki-Codesniffer

Sep 13 2015

TasneemLo added a comment to T17616: Inconsistent positioning of cached data message..

This is due to a small design fault in the code, there are two provisions to give a "Header". One is got by checking for "<pagename>-summary" message, while the other is manually set.

Sep 13 2015, 9:52 AM · Patch-Needs-Improvement, Design, MediaWiki-Special-pages
TasneemLo added a comment to T106005: Adjust the blue highlight of new contribution actions.

Could you give a link to the Contributions Page ? How to get there ?

Sep 13 2015, 8:19 AM · WMF-deploy-2015-09-15_(1.26wmf23), Patch-For-Review, Design, good first task, ContentTranslation
TasneemLo added a comment to T100467: Rename JavaScript modules to reflect their location.

The above patch is a demo for the modules/search/SearchApi. Is this fine ? Or did I miss something ?

Sep 13 2015, 6:09 AM · WMF-deploy-2015-09-22_(1.26wmf24), Patch-For-Review, MobileFrontend, Mobile, good first task, Web-Team-Backlog
TasneemLo added a comment to T110843: Banners do not show up in mobile editor preview or new beta feature "wikitext editor".

Hey, I'm new to Mediawiki and was hoping to try solving this task as it is marked "Easy"

Sep 13 2015, 3:13 AM · VisualEditor, Contributors-Team, Wikidata-Page-Banner
TasneemLo added a comment to T100467: Rename JavaScript modules to reflect their location.

Could someone assign this to me please (I cannot assign myself)

Sep 13 2015, 3:09 AM · WMF-deploy-2015-09-22_(1.26wmf24), Patch-For-Review, MobileFrontend, Mobile, good first task, Web-Team-Backlog

Sep 12 2015

TasneemLo added a comment to T108458: Adapt MW-CS test framework to support testing sniffs that support auto-fixing (phpcbf).

I have addressed this issue in https://gerrit.wikimedia.org/r/#/c/237899/ - but have not tested it out yet. Would like a review before I work more on it, so that I know that the approach is fine.

Sep 12 2015, 12:43 PM · MediaWiki-Codesniffer

Sep 11 2015

TasneemLo added a comment to T92751: Improve test suite for mediawiki phpcs standard.

It may be better to go towards class based unittesting (example : https://phpunit.de/getting-started.html) and use assertEquals and so on to test whether functions perform correctly.

Sep 11 2015, 9:54 PM · Patch-For-Review, MediaWiki-Codesniffer
TasneemLo added a comment to T92744: Add sniff for "if/while ( $a = foo() )" constructs in phpcs.

Sumit, may I attempt this ? or will you be fixing the patch ?

Sep 11 2015, 9:13 PM · Patch-For-Review, MediaWiki-Codesniffer
TasneemLo closed T112292: IF paranthesis condition not the same as MW convention as Resolved.
Sep 11 2015, 6:42 PM · MediaWiki-Codesniffer
TasneemLo added a comment to T112292: IF paranthesis condition not the same as MW convention.

Aha - you're right.

Sep 11 2015, 6:05 PM · MediaWiki-Codesniffer
TasneemLo added a comment to T101311: Add sniff for checking that "else" is on same line as previous closing brace.

This seems to already be there in phpcs

Sep 11 2015, 5:39 PM · Patch-For-Review, good first task, MediaWiki-Codesniffer
TasneemLo added a comment to T112292: IF paranthesis condition not the same as MW convention.

I am using the phpcs.xml given in the media-wiki core's git repo. And am using composer phpcs test.php on a test file I created in the core's local repo.

Sep 11 2015, 5:32 PM · MediaWiki-Codesniffer
TasneemLo created T112292: IF paranthesis condition not the same as MW convention.
Sep 11 2015, 4:54 PM · MediaWiki-Codesniffer
TasneemLo created T112280: phpcs doesnt exit when timed out in composer.
Sep 11 2015, 3:59 PM · Upstream, MediaWiki-Codesniffer
TasneemLo added a comment to T89682: Improving static analysis tools for MediaWiki.

I was wondering if this project is open for Outreachy Dev-Mar (Round 11) submissions.
I notice a few GSoC 15 project submissions, but am unable to find it in the accepted projects in the melange website, so I am guessing it is as of yet incomplete ?

Sep 11 2015, 8:27 AM · MediaWiki-Codesniffer (MediaWiki-Codesniffer-GSoC-2016), Outreachy-Round-12, Google-Summer-of-Code (2016)