@Aklapper it looks like that file hasn't been significantly touched in 8 years and most of it is 12(!) years old. I think replacing it with a link to wikitech is indeed the right thing to do.

SpiderPig is hilarious and awesome. Great job everyone!

If you want to fix it right, maybe we should take this upstream?

In T389738#10665939, @taavi wrote:

This is because https://phabricator.wikimedia.org/config/edit/maniphest.subtypes/ has "mutations": [] explicitely set for the Security subtype.

The biggest weakness in Phabricator's search implementation, as far as I understand it, is when searching for very common terms which match a massive number of documents. In the case of very common terms it is really costly to sort and rank the results, and simultaneously, the results are unlikely to be very useful. It would be useful for search queries specifically to put a cap on resource consumption and just simply abort the query if it has been running for a long time.

There is an optimization for the search index ngrams tables, which could reduce the size of the dataset:

I can't remember making the change, or why I did. Feel free to revert it.

What was the intention behind this commit, where to find related discussions?

In T352782#9414884, @Aklapper wrote:

This custom code change did not "Removed a bunch of brand-specific icons" as its description says.
This code changed getIconQuips() and that very function only provides tooltips and does not change any selection of icons. Thus it made a bunch of icons not have a descriptive tooltip but display the internal filename as the tooltip instead:

I think the intention is to share the "single document url" from logstash instead of the request id. The instructions are unclear, however, and could be improved.

I'd be happy to answer any questions you might have about this. I think I still remember a few things

The bulk of that behavior is implemented in webroot/rsrc/js/application/transactions/behavior-show-older-transactions.js

Congrats on the migration, very happy to see this completed.

If it helps: It's unlikely that phabricator will ever need elasticsearch in the future.