Sorry It took that long, but a lot of things happened because of pandemic and i totally forgot about this task. I'm not sure if this is what you want, but I can transfer repository to @srishakatux or Toolforge organisation.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jul 22 2020
Jan 6 2020
It's working on wikipedia beta because it use #some_input_id:checked ~ #mw-mf-page-left (i don't remember id), but from what I've seen mediawiki is using anchor in this id so it can't be checked. Now I'm on mobile phone so I can't check dev tools, but I'm pretty sure there was anchor, not input on mediawiki
Ok, but I don't think it will work without this change which was reverted. Should I add it again (if it won't be a problem now)?
In T231205#5779359, @Jdlrobson wrote:https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page runs the latest code and I see the box-shadow there but not the primary-navigation-enabled class. It's most likely this is a regression which will resolve itself in the next deploy.
I removed border-radius from .toggle-list__list. I haven't found any other border-radius styles that could override this so removing it from ToggleList.less should be fine, but I'm not sure why previous box-shadow change was reverted, like I said before.
In T231205#5779128, @N3rsti wrote:@Jdlrobson Why was this change reverted? I know you said that "this CSS block is dead", but now it doesn't show shadow in websites like this . There were no other shadow styles for this drawer.
@Jdlrobson Why was this change reverted? I know you said that "this CSS block is dead", but now it doesn't show shadow in websites like this . There were no other shadow styles for this drawer.
Jan 2 2020
@alexhollender I haven't changed border-radius, because from the task I had to change color only. I did everything from this list:
Dec 28 2019
Dec 25 2019
Dec 24 2019
It should be fixed now. I'm not sure if I created variable in the right place, but it's easy to fix in necessary.
Dec 23 2019
It should be working now, it it's not, please let me know and I will try to fix it.
I tried to reconstruct this bug on devtools and I see this shadow on the left side (which I will try to fix), but I don't see the shadow on the burger menu. On which website have you seen this bug?
@Jdlrobson My GCI task was already approved, but I see that there is a problem with it. Can I fix it?
Notes
These are my notes, I will edit them when I find something.
Dec 21 2019
Created web app showing toolfoge apps using wikimedia API including new apps from task description. The tiles design is from previous toolforge gallery, but I did it from scratch without using bootstrap (so it's probably slightly faster) and changed color to blue (#36c) from wikimedia style guide. On navigation bar you can search for apps using app name / module.