@gengh Good, I took into account your remark :)

@SDunlap Is this the kind of scenario you had in mind?

I made the refactoration (with the hope @JKieserman will approve that move :) )

Also 2 questions:

• I changed an instance of <z-object-selector> to a <z-reference> in ZImplementation.vue. What are the differences between the two of them?
• If this change is right, I wonder if therefore we could not even replace this code in ZImplementation.vue:

@Ddwaal-WMF Thanks for your answer. If you would like, I propose you therefore to you take a look at the patches I made in T323381.

I made 2 patches:

• the first is the implementation;
• the second are the tests;

Thank you for your answer :)

@Jdforrester-WMF OK, so from your message, I think I understood something: WikiBase and WikiLambda are the name of extensions, whereas WIkiData and WikiFunctions are the name of the Wiki sites run by the Wikimedia foundation. Am I right?

The scenario I described felt like a bit odd to me, but I cannot speak for everyone.
And as moreover I am not a UX expert, I am fine with closing the ticket :)

@gengh Is this bug different from T323381?

@Ddwaal-WMF I propose more detailed steps to reproduce:

1. Go to this function: https://wikifunctions.beta.wmflabs.org/wiki/Z10018
2. Edit the function
3. Change the content of the name field (DO NOT PUBLISH)
4. Click on the Cancel button

@Ddwaal-WMF Looks good. I wonder, on WikiData, when changing content and refreshing, the content is restored.

@AdesojiThisDot Sure! :)

Seems like it is a side effect of this commit:

@gengh @JKieserman May I start working on it or should I wait first? I see that the task needs to be triaged first.

I am the one to apologize, I'd rather know how probable the might in this sentence meant: This should be solved, but I believe that this might get solved when we implement the new default component.
At first, when I sought for an answer, I felt like a fix was not taking that much time, but that wasn't considering the review.

I proposed a fix which changes the behavior. Not sure about the UX though.

I see these possibilities :

• Either we can use Array.prototype.find because it is supported by all modern browsers and we do not support IE11
• Otherwise:
  • we can probably use Array.prototype.some just like we currently use Array.prototype.forEach and return true when we want to stop iterating and return`false` otherwise
  • a good old for (...;...;...) loop with a break statement
  • Use some Array.prototype.find polyfill (core-js or even babel which uses it)

I proposed a patch, with much uncertainty.

I proposed a change. I simply use the tooltip component which appears on the chip only.

Removing myself in favor of T320388. I may take it back later, but until then, I don't mind if anyone claim it!

@Teleosteen Thanks for your contribution!! Do you wanna continue working on this task?

Thanks Julia for the details!

To ease their writing, I propose the use of:

• Test scenarios written in Gherkin syntax thanks to Cucumber;
• Playwright in order to manipulate the headless browsers (Firefox, Chrome, ... but not IE);

@JKieserman I have to apologize, because it is a regression of T320614

Thanks @JKieserman for the heads up!

If I am right, the issue in WikiLambda should be fixed thanks to the patch for T320614 (which is merely a circumvent of the issue, I agree to say)

Thanks! :)

@Jdforrester-WMF As T320723 is merged, I think this issue can be set as resolved. Do you need me to do this (now and in the future)? Or should I let someone like you do this?

Please see the patch at this ticket Gerrit ticket: https://gerrit.wikimedia.org/r/842910

Normally it will eventually be fixed along with T320723

Using Vim, I edited the i18n/en.json file to check if there were other keys for which the translations were in the case described by the issue. I failed to find others, here is my methodology:

• open the file using neovim (or vim, it will work as well): nvim i18n/en.json
• search translation having caracters others than alphanumerics, spaces (of any form), punctuation mark, colon, dollar and single quote: /\wikilambda[^"]*": \".*\zs[^[:alnum:][:space:]\.\,\$\']\ze.*"
• for each match, read the whole line (because some match may occur due to the greedy .*

(Sorry, I had difficulties to reproduce the issue locally even if I could on the beta platform)

Stalling this, because it might be affected by the new Publish component designs.

This proposal provides a fix (by circumventing the issue): T320614.

The patch above implements the proposal.

I proposed a patch with the "UX/UI" solution in mind.

I have two contradictory ideas in mind:

• Technical considerations: I wonder if using CSS grid could not be a good fit for keeping the "Add new input" to the top right (but maybe having to support IE 11 spoils the idea);
• UI / UX considerations: As the "Add new input" is meant to push a new input, it should remain below the last input (see screenshot below)

Devices and Design (URLs or screenshots, if applicable):

https://www.figma.com/file/z4PDWdNVvwEtRMMozW8Fvi/Function-editor?node-id=2832%3A11786

Once again, I am really grateful for the way this bug has been described in this ticket. Thanks a lot @gengh!

 Per this slack thread - buttons should always be enabled

I tried to understand how the store works to bind the languages of the FunctionDefinition and the FnEditorVisualDisplay, and have to admit to have failed on this.

Also when you select another language, the previously selected language still appears at the right corner (work summary), and you cannot select again this language in the function definition.

The CI failed. I understand why!
That's because Babel is a peerDependency of vue3-jest. That requires to install Babel along with the latter.

@ori Sure! You'll find the patch above :)

Is this a task I could take? More details would be appreciated (I don't understand what is AW)

Also I can squash the commits, I don't think it is worth to keep 3 commits for this ticket.

I guess we could do more, but it would probably take time for me (maybe more functional and technical background on WikiLambda can help doing more).

LGTM

I somehow fixed the bug. However, you may take a look on my own comment:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/827464/1/resources/ext.wikilambda.edit/components/types/ZMultilingualString.vue#79

(I pushed my work in progress as promised)

I take this issue.