Currently working on it (I'll try to push my work in progress ASAP)
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Aug 26 2022
Aug 24 2022
Aug 22 2022
OK, I removed the interface and did as you suggested.
Aug 16 2022
Can the static analysis run asynchronously, maybe in a different micro-service, just like a linter? (if that's not already the case)
Aug 12 2022
phpcs report these errors:
FILE: /var/www/html/w/extensions/WikiLambda/includes/ZObjects/ZMultiLingualString.php
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------
199 | ERROR | Only one object structure is allowed in a file
| | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
219 | ERROR | Only one object structure is allowed in a file
| | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
----------------------------------------------------------------------------------------------------------------------Jul 27 2022
Thanks for your feedback @Jdforrester-WMF, I edited the title and the description of the task for more clarity and assigned it to myself. I'll work on it during the week.
Jul 25 2022
Thanks for your response @Jdforrester-WMF! I don't see the overhead that would be implied when returning a ZMonoLingualString, but it's wise that I trust your analysis :-).
Also, I would tend to return a structure which would look like the Message class, so with it we may:
- define a placeholder text to use (instead of the use of $isTItle + $returnPlaceholder) using a setPlaceholder($placeholder: string) function;
- set a flag so we may fallback to English or not (LanguageFallback::MESSAGES VS LanguageFallback::STRICT) ;
- get the return type we want using a method (like value() to get the string value only and zMonolingualString() to get the whole ZMonolingual instance)
Jul 22 2022
I started with a simple class, just factorizing dieWithZError.
Jul 18 2022
I take this issue if you don't mind, thanks for pointing out this idea!
Jul 16 2022
Here is my patch. Review welcome, also don't hestitate to nitpick.
I take the issue.
Jul 14 2022
This is my patch. I hope this is what was expected :).
Jul 7 2022
If that's OK, I can take this bug.
I made several changes:
- First commit: I added the tests as requested
- Second commit: I propose to split getters / setters tests so we can easily understand that a tests like "Returns current zObject by its ID" applies to the "getZObjectById" getter in the tests output
- Third commit: I propose a typo fix and another implementation for "findLatestKey"
Jun 30 2022
Apologies for the ambiguity of the task description!
If it's OK, I'd like to take this issue.
Jun 29 2022
Also don't hesitate to nitpick, I take any remark so I can continue contributing in the future with all your codestyle and processes :)
@gengh Thanks, I think it's good now :)
That's way better now, I can authenticate through ssh (I had to generate a new SSH key, the one I used to use was a classic rsa key, I follow the suggestion to generate a ed25519 one).
I don't know how to push a new branch on gerrit (despite having set my ssh public key in my preferences, I still have no permission to use the ssh protocol, as documented in this wikipage).
I'd be glad to take this issue and attempt a fix if no one is against that.