Page MenuHomePhabricator
Feed Search

Aug 26 2022

Teleosteen added a comment to T312171: Avoid duplicate PHP logic between ZObjectEditAction, ZObjectContentHandler, and SpecialCreateZObject.

Currently working on it (I'll try to push my work in progress ASAP)

Aug 26 2022, 8:47 AM · Abstract Wikipedia team, MW-1.40-notes (1.40.0-wmf.1; 2022-09-12), MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), WikiLambda, Abstract Wikipedia Fix-It tasks

Aug 24 2022

Teleosteen claimed T312171: Avoid duplicate PHP logic between ZObjectEditAction, ZObjectContentHandler, and SpecialCreateZObject.
Aug 24 2022, 1:30 PM · Abstract Wikipedia team, MW-1.40-notes (1.40.0-wmf.1; 2022-09-12), MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), WikiLambda, Abstract Wikipedia Fix-It tasks

Aug 22 2022

Teleosteen added a comment to T313712: ZMultiLingualString->internalGetStringForLanguage may return a structure to build the expected value (with or without fallback / placeholder).

OK, I removed the interface and did as you suggested.

Aug 22 2022, 12:07 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda

Aug 16 2022

Teleosteen added a comment to T315026: Discuss Not Running Static Validation.

Can the static analysis run asynchronously, maybe in a different micro-service, just like a linter? (if that's not already the case)

Aug 16 2022, 8:49 AM · Abstract Wikipedia team, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), WikiLambda, function-orchestrator

Aug 12 2022

Teleosteen added a comment to T313712: ZMultiLingualString->internalGetStringForLanguage may return a structure to build the expected value (with or without fallback / placeholder).

phpcs report these errors:

FILE: /var/www/html/w/extensions/WikiLambda/includes/ZObjects/ZMultiLingualString.php
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------
 199 | ERROR | Only one object structure is allowed in a file
     |       | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
 219 | ERROR | Only one object structure is allowed in a file
     |       | (Generic.Files.OneObjectStructurePerFile.MultipleFound)
----------------------------------------------------------------------------------------------------------------------
Aug 12 2022, 6:19 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda

Jul 27 2022

Teleosteen added a comment to T313712: ZMultiLingualString->internalGetStringForLanguage may return a structure to build the expected value (with or without fallback / placeholder).

Thanks for your feedback @Jdforrester-WMF, I edited the title and the description of the task for more clarity and assigned it to myself. I'll work on it during the week.

Jul 27 2022, 7:18 AM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda
Teleosteen renamed T313712: ZMultiLingualString->internalGetStringForLanguage may return a structure to build the expected value (with or without fallback / placeholder) from ZMultiLingualString->internalGetStringForLanguage may return a ZMonoLingualString to ZMultiLingualString->internalGetStringForLanguage may return a structure to build the expected value (with or without fallback / placeholder).
Jul 27 2022, 7:16 AM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda

Jul 25 2022

Teleosteen added a comment to T313712: ZMultiLingualString->internalGetStringForLanguage may return a structure to build the expected value (with or without fallback / placeholder).

Thanks for your response @Jdforrester-WMF! I don't see the overhead that would be implied when returning a ZMonoLingualString, but it's wise that I trust your analysis :-).

Jul 25 2022, 2:10 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda
Teleosteen added a comment to T313712: ZMultiLingualString->internalGetStringForLanguage may return a structure to build the expected value (with or without fallback / placeholder).

Also, I would tend to return a structure which would look like the Message class, so with it we may:

  • define a placeholder text to use (instead of the use of $isTItle + $returnPlaceholder) using a setPlaceholder($placeholder: string) function;
  • set a flag so we may fallback to English or not (LanguageFallback::MESSAGES VS LanguageFallback::STRICT) ;
  • get the return type we want using a method (like value() to get the string value only and zMonolingualString() to get the whole ZMonolingual instance)
Jul 25 2022, 12:02 PM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda
Teleosteen created T313712: ZMultiLingualString->internalGetStringForLanguage may return a structure to build the expected value (with or without fallback / placeholder).
Jul 25 2022, 10:15 AM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda

Jul 22 2022

Teleosteen added a comment to T313237: Factor out common code between WikiLambda API modules into our own extension of the ApiBase class, WikiLambdaApiBase or similar.

I started with a simple class, just factorizing dieWithZError.

Jul 22 2022, 12:33 PM · MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda, Abstract Wikipedia Fix-It tasks, Technical-Debt

Jul 18 2022

Teleosteen claimed T313237: Factor out common code between WikiLambda API modules into our own extension of the ApiBase class, WikiLambdaApiBase or similar.

I take this issue if you don't mind, thanks for pointing out this idea!

Jul 18 2022, 2:53 PM · MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda, Abstract Wikipedia Fix-It tasks, Technical-Debt

Jul 16 2022

Teleosteen added a comment to T305380: WikiLambda: API wikilambda_fetch, return Z5 errors instead of error message strings.

Here is my patch. Review welcome, also don't hestitate to nitpick.

Jul 16 2022, 8:07 PM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks, WikiLambda
Teleosteen claimed T305380: WikiLambda: API wikilambda_fetch, return Z5 errors instead of error message strings.
Jul 16 2022, 2:53 PM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks, WikiLambda
Teleosteen added a comment to T305380: WikiLambda: API wikilambda_fetch, return Z5 errors instead of error message strings.

I take the issue.

Jul 16 2022, 9:50 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks, WikiLambda

Jul 14 2022

Teleosteen added a comment to T310324: Create and use "Invalid Programming Language" Errors.

This is my patch. I hope this is what was expected :).

Jul 14 2022, 8:54 AM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks

Jul 7 2022

Teleosteen claimed T310324: Create and use "Invalid Programming Language" Errors.

If that's OK, I can take this bug.

Jul 7 2022, 2:51 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
Teleosteen added a comment to T306507: front-end: Add specific unit tests for zobjectTreeUtils.

I made several changes:

  • First commit: I added the tests as requested
  • Second commit: I propose to split getters / setters tests so we can easily understand that a tests like "Returns current zObject by its ID" applies to the "getZObjectById" getter in the tests output
  • Third commit: I propose a typo fix and another implementation for "findLatestKey"
Jul 7 2022, 9:56 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Abstract Wikipedia team, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, WikiLambda, Abstract Wikipedia Fix-It tasks

Jun 30 2022

Teleosteen added a comment to T305611: wikilambda_edit API: Make summary parameter required or handle empty value in the ZObjectStore creation methods.

Apologies for the ambiguity of the task description!

Jun 30 2022, 2:38 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda, Abstract Wikipedia Fix-It tasks
Teleosteen added a comment to T306507: front-end: Add specific unit tests for zobjectTreeUtils.
Jun 30 2022, 8:51 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Abstract Wikipedia team, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, WikiLambda, Abstract Wikipedia Fix-It tasks
Teleosteen claimed T306507: front-end: Add specific unit tests for zobjectTreeUtils.

If it's OK, I'd like to take this issue.

Jun 30 2022, 8:34 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Abstract Wikipedia team, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, WikiLambda, Abstract Wikipedia Fix-It tasks

Jun 29 2022

Teleosteen added a comment to T305611: wikilambda_edit API: Make summary parameter required or handle empty value in the ZObjectStore creation methods.

Also don't hesitate to nitpick, I take any remark so I can continue contributing in the future with all your codestyle and processes :)

Jun 29 2022, 5:13 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda, Abstract Wikipedia Fix-It tasks
Teleosteen added a comment to T305611: wikilambda_edit API: Make summary parameter required or handle empty value in the ZObjectStore creation methods.

@gengh Thanks, I think it's good now :)

Jun 29 2022, 5:11 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda, Abstract Wikipedia Fix-It tasks
Teleosteen added a comment to T305611: wikilambda_edit API: Make summary parameter required or handle empty value in the ZObjectStore creation methods.

That's way better now, I can authenticate through ssh (I had to generate a new SSH key, the one I used to use was a classic rsa key, I follow the suggestion to generate a ed25519 one).

Jun 29 2022, 3:56 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda, Abstract Wikipedia Fix-It tasks
Teleosteen added a comment to T305611: wikilambda_edit API: Make summary parameter required or handle empty value in the ZObjectStore creation methods.

I don't know how to push a new branch on gerrit (despite having set my ssh public key in my preferences, I still have no permission to use the ssh protocol, as documented in this wikipage).

Jun 29 2022, 3:09 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda, Abstract Wikipedia Fix-It tasks
Teleosteen claimed T305611: wikilambda_edit API: Make summary parameter required or handle empty value in the ZObjectStore creation methods.

I'd be glad to take this issue and attempt a fix if no one is against that.

Jun 29 2022, 12:35 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Wikimedia-Hackathon-2022, good first task, Abstract Wikipedia team (Phase κ – Clean-up), WikiLambda, Abstract Wikipedia Fix-It tasks