Page MenuHomePhabricator
Feed Advanced Search

May 12 2015

Edokter closed T98768: FormWizard throws typeerror when loading on 'edit' pages as Resolved.

Adding the dependencies (mediawiki.cookie and mediawiki.user) seems to have cleared the JavaScript exceptions and no longer conflicts with CharInsert. (The depencies still need to be set on Meta.)

May 12 2015, 8:31 AM · Co-op
Edokter added a comment to T98768: FormWizard throws typeerror when loading on 'edit' pages.

The gadget (on enwiki) was missing the dependency on mediawiki.cookie in gadgets-definition. I've added it. Can you see if that clears the problem? I will try to recreate the error that I encountered.

May 12 2015, 8:14 AM · Co-op

May 9 2015

Edokter merged task T98693: Graph extension throws JavaScript error in IE8 into T98689: Graph does not support IE8 and throws JS errors.
May 9 2015, 10:58 PM · MediaWiki-extensions-Graph
Edokter merged T98693: Graph extension throws JavaScript error in IE8 into T98689: Graph does not support IE8 and throws JS errors.
May 9 2015, 10:58 PM · Browser-Support-Internet-Explorer, MediaWiki-extensions-Graph
Edokter created T98693: Graph extension throws JavaScript error in IE8.
May 9 2015, 10:53 PM · MediaWiki-extensions-Graph

May 2 2015

Edokter added a comment to T44241: Vector: Middle click on <a href="#"> in tabs should not open "{current url}#" in a new window.

Because most patches are abandoned, and any solution will involve too much payload just to solve an edge case.

May 2 2015, 4:45 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Readers-Web-Backlog, Accessibility, Vector
Edokter placed T44241: Vector: Middle click on <a href="#"> in tabs should not open "{current url}#" in a new window up for grabs.
May 2 2015, 4:40 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Readers-Web-Backlog, Accessibility, Vector
Edokter added a comment to T63099: Vector: Remove use of raster graphics in the layout styles.

Same problem: backward compatibility.

May 2 2015, 11:08 AM · CSS, Readers-Web-Backlog (Tracking), Vector
Edokter added a comment to T20465: Tabs in Monobook and Vector should indicate selected state.

Define 'selected'. Active tabs already have a selected style. I think OP means 'highlighted' to indicate a control has focus? There is a clear distincion between those two in UIX land.

May 2 2015, 10:47 AM · Desktop Improvements, WCAG-Level-AAA, Readers-Web-Backlog (Tracking), CSS, Vector, Accessibility, MonoBook
Edokter changed the status of T56307: Watchlist icon does not match on desktop and mobile skin, a subtask of T55733: Use the same icons to represent the same things (tracking), from Resolved to Declined.
May 2 2015, 10:41 AM · UI-Standardization, OOUI, Tracking-Neverending, Design, MediaWiki-General
Edokter changed the status of T56307: Watchlist icon does not match on desktop and mobile skin from Resolved to Declined.

The consensus seems to be that they should not be the same. So yes, 'declined' is the better choice.

May 2 2015, 10:41 AM · Vector, Google-Code-in-2014, Design
Edokter closed T44241: Vector: Middle click on <a href="#"> in tabs should not open "{current url}#" in a new window as Declined.
May 2 2015, 9:47 AM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Readers-Web-Backlog, Accessibility, Vector
Edokter closed T44241: Vector: Middle click on <a href="#"> in tabs should not open "{current url}#" in a new window, a subtask of T46881: [DO NOT USE] Vector skin issues (tracking) [superseded by #Vector], as Declined.
May 2 2015, 9:47 AM · Tracking-Neverending, Vector
Edokter closed T68388: Vector's dropdown menus (Variants, More/Actions) feature weird outlines when focused/clicked in Chrome as Invalid.
May 2 2015, 9:34 AM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Vector, Browser-Support-Google-Chrome
Edokter closed T87573: Page status indicator overlaps with the action menu in skin Vector as Resolved.
May 2 2015, 9:15 AM · Patch-For-Review, Vector
Edokter added a comment to T67286: #p-logo should be at the top of <body>.

Suggest declining. Loading the content before the rest of the UI was a concious design decision.

May 2 2015, 9:09 AM · Performance Issue, Vector
Edokter placed T56307: Watchlist icon does not match on desktop and mobile skin up for grabs.
May 2 2015, 9:04 AM · Vector, Google-Code-in-2014, Design
Edokter closed T56307: Watchlist icon does not match on desktop and mobile skin, a subtask of T55733: Use the same icons to represent the same things (tracking), as Resolved.
May 2 2015, 9:04 AM · UI-Standardization, OOUI, Tracking-Neverending, Design, MediaWiki-General
Edokter closed T56307: Watchlist icon does not match on desktop and mobile skin as Resolved.
May 2 2015, 9:04 AM · Vector, Google-Code-in-2014, Design
Edokter closed T78635: Special:Search bar no longer fits screen in Vector as Invalid.

The min-widht has since been removed. That should resolve the issue. Otherwise, it must be cause by an external factor.

May 2 2015, 8:44 AM · Vector
Edokter closed T87077: Change 0.875em font size to 1em as Declined.

There is little positive feedback for this proposal, so closing.

May 2 2015, 8:38 AM · Vector, UI-Standardization

Apr 30 2015

Edokter closed T88220: Remove overflow:hidden for headings as Declined.

Please abandon any associated patches.

Apr 30 2015, 8:51 AM · MediaWiki-Interface

Apr 29 2015

Edokter added a comment to T67160: Refresh thumbnail style in Vector.

Claiming task, since nothing is happening. I'll be creating some testcases which we can choose from.

Apr 29 2015, 3:52 PM · Readers-Web-Backlog (Tracking), Design, Vector
Edokter claimed T67160: Refresh thumbnail style in Vector.
Apr 29 2015, 3:50 PM · Readers-Web-Backlog (Tracking), Design, Vector
Edokter renamed T66653: Typography refresh fixup: list line-height, h1 margin, h3 font-size from Typography refresh fixup: list line-height, h1 margin, h3 font-size, diff display to Typography refresh fixup: list line-height, h1 margin, h3 font-size.
Apr 29 2015, 3:40 PM · MediaWiki-Interface, Vector
Edokter claimed T66653: Typography refresh fixup: list line-height, h1 margin, h3 font-size.
Apr 29 2015, 12:49 PM · MediaWiki-Interface, Vector
Edokter added a comment to T95964: Deprecation status of importScript, importStylesheet, importScriptURI, importStylesheetURI.

It hasn't been deployed yet. We could ping a dev to ask for a lightning deploy.

Apr 29 2015, 7:44 AM · MW-1.25-release, User-notice, Technical-Debt, JavaScript

Apr 28 2015

Edokter accepted rMW33cfd0bc4a5f: Slightly increase wikitable padding.

Closing, as padding has been adjusted.

Apr 28 2015, 2:16 PM
Edokter updated the task description for T97299: WikiEditor styles are not loaded when editing any JS or CSS page.
Apr 28 2015, 11:00 AM · WikiEditor
Edokter added a comment to T97299: WikiEditor styles are not loaded when editing any JS or CSS page.

It will work in Opera >12 (which is Webkit). The overflow condition only applies to non-textareas. The Mozilla page is slightly outdated. Not really an issue.

Apr 28 2015, 8:32 AM · WikiEditor
Edokter updated the task description for T97299: WikiEditor styles are not loaded when editing any JS or CSS page.
Apr 28 2015, 8:32 AM · WikiEditor

Apr 27 2015

Edokter created T97299: WikiEditor styles are not loaded when editing any JS or CSS page.
Apr 27 2015, 4:00 PM · WikiEditor

Apr 26 2015

Edokter added a comment to T59824: Display tabs in .mw-code as 4 spaces using CSS tab-size property.

Any reason why this should not be applied to every pre-formatted text? Or all text for that matter?

Apr 26 2015, 1:29 PM · CSS, MediaWiki-General

Apr 20 2015

Edokter added a comment to T95964: Deprecation status of importScript, importStylesheet, importScriptURI, importStylesheetURI.

I'm with TheDJ. We still don't have a drop-in replacement... Wasn't this supposed to be superceded with GlobalGadgets/ResourceLoader 3.0 (or whatever version)? Until that is here, we should maintain these as (legacy) wrappers for mw.loader.load.

Apr 20 2015, 5:13 PM · MW-1.25-release, User-notice, Technical-Debt, JavaScript

Apr 13 2015

Edokter added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

I agree... I choose 25em initially, but failed to test it 'live'. 24em seems like a good value.

Apr 13 2015, 1:17 PM · Patch-For-Review, MediaWiki-Categories

Apr 10 2015

Edokter added a comment to T78418: Introduce MediaWiki:Mainpage.css.

Should I create an RFC for this?

Apr 10 2015, 7:53 PM · Performance-Team, Technical-Debt, MediaWiki-ResourceLoader

Apr 6 2015

Edokter claimed T94307: Page status indicator should not be automatically sorted outside main namespace.

The more I think about it, the more I am puzzled. The argument for sorting is "consistency", but this has not been thought through. When two specific indicators are used on multiple pages, their order would be consistent, but that is also easily achieved within the templates utilizing the indicators.

Apr 6 2015, 8:56 AM · Patch-Needs-Improvement, MediaWiki-General

Apr 2 2015

Edokter added a comment to T18691: RFC: Section header "share" link.

Pretty much what we had here, but they have a big gutter to work with...

Apr 2 2015, 4:59 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface

Mar 29 2015

Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

Users should not have to hack around with the name parameter just to get them in the right order (with the unpredictive results mentioned above). How about only excluding user pages from auto-sorting.?

Mar 29 2015, 7:52 PM · Patch-Needs-Improvement, MediaWiki-General

Mar 28 2015

Edokter added a comment to T94307: Page status indicator should not be automatically sorted outside main namespace.

I recommend that users who want reliable custom ordering just place a single <indicator/> tag on their pages, with whatever content they want inside, in whatever order they want it.

Mar 28 2015, 10:12 PM · Patch-Needs-Improvement, MediaWiki-General
Edokter updated the task description for T94307: Page status indicator should not be automatically sorted outside main namespace.
Mar 28 2015, 5:33 PM · Patch-Needs-Improvement, MediaWiki-General
Edokter updated subscribers of T94307: Page status indicator should not be automatically sorted outside main namespace.
Mar 28 2015, 5:29 PM · Patch-Needs-Improvement, MediaWiki-General
Edokter created T94307: Page status indicator should not be automatically sorted outside main namespace.
Mar 28 2015, 5:24 PM · Patch-Needs-Improvement, MediaWiki-General

Mar 25 2015

Edokter added a comment to T18691: RFC: Section header "share" link.

U+1F517 is only workable using a webfont, as no standard font (that I know of) supports this character. I suggested putting the link symbol in WikiFont earlier.

Mar 25 2015, 8:29 AM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface

Mar 22 2015

Edokter added a comment to T91890: Wikitable padding.

Noted and considered. 0.3em vertical is still too high. I'll submit a patch shortly.

Mar 22 2015, 3:34 PM · Patch-For-Review, Design, MediaWiki-Interface
Edokter added a comment to T91890: Wikitable padding.

That is not much of an argument... I could say no one has made an issue of 0.2em either. 0.3em is just too high and unbalances the horizontal/vertical padding. I conceded to the horizontal padding being too tight, but there was nothing wrong with the vertical padding. So unless there is an actual case for the vertical padding... don't change what's not broken.

Mar 22 2015, 7:56 AM · Patch-For-Review, Design, MediaWiki-Interface

Mar 17 2015

Edokter added a comment to T18691: RFC: Section header "share" link.

Good... it was over-engineered anyway. A simple link within the header toolbar, or right-float inside the header is far simpler and less intrusive.

Mar 17 2015, 11:20 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface

Mar 16 2015

Edokter added a comment to T91890: Wikitable padding.

I have incorporated 0.2em 0.4em for testing on enwiki. Any progress here?

Mar 16 2015, 8:43 AM · Patch-For-Review, Design, MediaWiki-Interface

Mar 11 2015

Edokter added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

It concerns both desktop and mobile, so i would say rename.

Mar 11 2015, 8:41 AM · Patch-For-Review, MediaWiki-Categories

Mar 10 2015

Edokter added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

That is somewhat expected; columns actually behave as one long page, which have basically been cut into three pieces. So when content is added, anything 'below' is pushed 'down' to the next column.

Mar 10 2015, 3:54 PM · Patch-For-Review, MediaWiki-Categories

Mar 7 2015

Edokter added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

It works in so far that the paragraphs are not broken up. In the context of pagebreaks, columns are treated as pages. Anyway, we should just avoid breaks in the list items for the time being.

Mar 7 2015, 9:11 PM · Patch-For-Review, MediaWiki-Categories
Edokter added a comment to T91890: Wikitable padding.

I know the horizontal padding is tight, but I believe that is because real estate in tables is premium in most uses. So any increase will cause a number of tables to be wider that the display window, necessitating horizontal scrolling.

Mar 7 2015, 8:44 PM · Patch-For-Review, Design, MediaWiki-Interface
Edokter added a comment to T91891: Review of increased wikitable padding.

@Isarra, please copy your comment to T91890.

Mar 7 2015, 8:29 PM · MediaWiki-Interface, Design
Edokter added a comment to T91890: Wikitable padding.

Created a duplicate task (T91891) shortly after this one. So copying key point here:

Mar 7 2015, 8:27 PM · Patch-For-Review, Design, MediaWiki-Interface
Edokter added a comment to rMW33cfd0bc4a5f: Slightly increase wikitable padding.

Continued at T91891 T91890.

Mar 7 2015, 6:13 PM
Edokter updated subscribers of T91891: Review of increased wikitable padding.
Mar 7 2015, 6:12 PM · MediaWiki-Interface, Design
Edokter created T91891: Review of increased wikitable padding.
Mar 7 2015, 6:11 PM · MediaWiki-Interface, Design

Mar 5 2015

Edokter added a comment to T18691: RFC: Section header "share" link.

In response to the main page, or other pages where the links are not wanted: How about a __NOSECTIONLINKS__ magic word?

Mar 5 2015, 8:53 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface
Edokter added a comment to T18691: RFC: Section header "share" link.

@Elitre, right-click, 'Copy link'.

Mar 5 2015, 8:51 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface
Edokter added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

That hurts... :)

Mar 5 2015, 3:50 PM · Patch-For-Review, MediaWiki-Categories
Edokter added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

@matmarex, the break-before/inside/after properties enjoy a wider support then columns, so I foresee no problems there.

Mar 5 2015, 3:40 PM · Patch-For-Review, MediaWiki-Categories
Edokter added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

In that case, the avoid-break code should be aplied to the individual list items, and not the entire block.

Mar 5 2015, 3:38 PM · Patch-For-Review, MediaWiki-Categories
Edokter added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

@Sumit, What determined the break between columns when tables were used? That same algorith can be used to allow/force a column break as well by inserting an element that has page-break-before: always; property set.

Mar 5 2015, 3:12 PM · Patch-For-Review, MediaWiki-Categories
Edokter added a comment to T18691: RFC: Section header "share" link.

@Fomafix: doesn't work (attempt)

Mar 5 2015, 3:02 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface
Edokter reopened T55130: Categories should be displayed in a responsive table and be mobile friendly. as "Open".

Reopening, because I am not quite happy with its implementation.

Mar 5 2015, 9:22 AM · Patch-For-Review, MediaWiki-Categories

Mar 2 2015

Edokter added a comment to T62595: Tooltip text for watchlist button assumes knowledge of the concept of watchlist.

I've suggested better wording on the patch, because it was quite clunky.

Mar 2 2015, 9:36 AM · MediaWiki-Interface, Voice & Tone, Patch-For-Review, I18n, Design

Feb 27 2015

Edokter added a comment to T18691: RFC: Section header "share" link.

Doesn't look too hot when headers appear inside a box, like documentation pages:

Feb 27 2015, 9:48 AM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface

Feb 26 2015

Edokter added a comment to rMW33cfd0bc4a5f: Slightly increase wikitable padding.

Can't find any off-hand, but there are template relying on it. Also tables are known to fight for space, and this doesn't help. Regardless, such a visual change should have been initiated as a bug/task.

Feb 26 2015, 4:08 PM
Edokter raised a concern with rMW33cfd0bc4a5f: Slightly increase wikitable padding.

Where is the task discussing this? This is not a "slight" increase, it's doubled, and it is very noticable. It also messes up table based templates like infobox that rely of default wikitable styling.

Feb 26 2015, 2:40 PM
Edokter added a comment to T55991: Floating image on left covers bullet points of a list.

I was referring to content in general. The main text usually 'flows' around floating obejcts like images and infoboxes. These floating elements have margins to prevent them from colliding with the main content. Since the floating object reside inside the main content, giving a margin to the main content makes no sense.

Feb 26 2015, 9:41 AM · MediaWiki-Parser

Feb 25 2015

Edokter added a comment to T55991: Floating image on left covers bullet points of a list.

Non-floating content never has side margins.

Feb 25 2015, 4:45 PM · MediaWiki-Parser

Feb 24 2015

Edokter added a comment to T55991: Floating image on left covers bullet points of a list.

Because the frame comes with a (wider) margin.

Feb 24 2015, 2:26 PM · MediaWiki-Parser

Feb 23 2015

Edokter added a comment to T37338: Vector: List bullet icon should not be low-res (pixelated on HiDPI screens).

Even so, without MobileFrontend, he would revert to the Desktop view.

Feb 23 2015, 9:29 PM · Patch-For-Review, Vector
Edokter added a comment to T55991: Floating image on left covers bullet points of a list.

No. See @TheDJ's answer in T13782.

Feb 23 2015, 9:26 PM · MediaWiki-Parser
Edokter added a comment to T55991: Floating image on left covers bullet points of a list.

The reported issues may seem different, but the root cause is the same, and known.

Feb 23 2015, 3:30 PM · MediaWiki-Parser
Edokter added a comment to T13782: List indicators overlap with left floating images/blocks.

It is a duplicate issue; the root cause is the same, namely because lists are styled with list-style-position: outside; to make list indentations uniform. This has always conflicted with left floating content.

Feb 23 2015, 3:21 PM · MediaWiki-Parser

Feb 20 2015

Edokter removed a project from T18691: RFC: Section header "share" link: Patch-For-Review.
Feb 20 2015, 9:13 AM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface

Feb 18 2015

Edokter added a comment to T75902: MediaViewer should have special handling for images which link to other images.

You wouldn't have to expand anything (except perhaps as alias for |link=); it would only be there for MediaViewer to pick up so it can display the right image.

Feb 18 2015, 11:05 PM · Multimedia, MediaViewer
Edokter added a comment to T75902: MediaViewer should have special handling for images which link to other images.

Another possible solution is auto-logic is too complicated: add some directive for MediaViewer to image syntax pointing to non-cropped image (|imagelink=).

Feb 18 2015, 11:46 AM · Multimedia, MediaViewer

Feb 17 2015

Edokter added a comment to T18691: RFC: Section header "share" link.

From what I can see in Resources.php, loading only the (default) skinning/elements.css and not content.css or interface.css.

Feb 17 2015, 2:17 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface

Feb 16 2015

Edokter added a comment to T18691: RFC: Section header "share" link.

It works. It does show that the gutter in Monobook is very tight.

Feb 16 2015, 9:26 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface
Edokter added a comment to T18691: RFC: Section header "share" link.

For anyone interested in testing out this feature, there's now a public demo at http://m4m.wmflabs.org/wiki/Slate.

Feb 16 2015, 8:36 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface
Edokter added a comment to T37338: Vector: List bullet icon should not be low-res (pixelated on HiDPI screens).
In T37338#1040792, @Mattflaschen wrote:

This could be because you don't have MobileFrontend installed.

Feb 16 2015, 9:04 AM · Patch-For-Review, Vector

Feb 15 2015

Edokter closed T89542: FOUC of horizontal rule in Vector sidebar as Resolved.

@polybuildr, That would result in more redundant code.

Feb 15 2015, 1:41 PM · Patch-For-Review, MediaWiki-Interface, Design, Performance Issue, Vector
Edokter reopened T89542: FOUC of horizontal rule in Vector sidebar as "Open".

You know what... I am annoyed enough to reopen this.

Feb 15 2015, 9:17 AM · Patch-For-Review, MediaWiki-Interface, Design, Performance Issue, Vector
Edokter added a comment to T89542: FOUC of horizontal rule in Vector sidebar.

I know we don't support IE6 anymore, but does that mean we should actively break IE6?

Feb 15 2015, 9:16 AM · Patch-For-Review, MediaWiki-Interface, Design, Performance Issue, Vector

Feb 14 2015

Edokter added a comment to T89542: FOUC of horizontal rule in Vector sidebar.

I think what Bartosz's main concern is, why does that class have to be added with JavaScript, which may incur a rendering delay?

Feb 14 2015, 7:55 PM · Patch-For-Review, MediaWiki-Interface, Design, Performance Issue, Vector
Edokter added a comment to T18691: RFC: Section header "share" link.

As for text-decoration:none, the patch does applied it on :hover and :focus while the existing styling already removes it from normal a tags, AFAIK.

Feb 14 2015, 3:49 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface
Edokter added a comment to T18691: RFC: Section header "share" link.

The padding only extends the 'clickable' area, but in case of H1 and H2, extends too far into the actual header.

Feb 14 2015, 12:30 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface
Edokter added a comment to T89542: FOUC of horizontal rule in Vector sidebar.

In the off-chance some user script or style actually depends on .first, I'd feel safer if the skin (vector.php) just adds the class statically.

Feb 14 2015, 12:28 PM · Patch-For-Review, MediaWiki-Interface, Design, Performance Issue, Vector
Edokter added a comment to T18691: RFC: Section header "share" link.

Brilliantly simple, could not be done with a (header) background image. I do have some suggestions:

Feb 14 2015, 10:02 AM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface

Feb 11 2015

Edokter added a comment to T539: Adapting Gadget-BugStatusUpdate.js to Phabricator.

...and enwiki should load it dynamically.

Feb 11 2015, 9:32 AM · JavaScript, Phabricator

Feb 9 2015

Edokter added a comment to T37338: Vector: List bullet icon should not be low-res (pixelated on HiDPI screens).

We shouldn't hack around bugs. Besides, @media is not webkit-only.

Feb 9 2015, 2:46 PM · Patch-For-Review, Vector
Edokter added a comment to T88220: Remove overflow:hidden for headings.

That is an edge case where a header is caught between two floating images. Again, not worth the host of other regressions that will emerge, should overflow:hidden be removed.

Feb 9 2015, 9:28 AM · MediaWiki-Interface

Feb 8 2015

Edokter added a comment to T37338: Vector: List bullet icon should not be low-res (pixelated on HiDPI screens).

Please don't do anything.

Feb 8 2015, 4:51 PM · Patch-For-Review, Vector
Edokter added a comment to T37338: Vector: List bullet icon should not be low-res (pixelated on HiDPI screens).

Using a viewBox hack in the SVG to 'trick' Webkit into using the correct dimensions appears to fix the problem. However, it requires setting the width and height to non-intrinsic values, which makes the SVG image useless for other purposes. So let's not go there.

Feb 8 2015, 11:21 AM · Patch-For-Review, Vector
Edokter added a comment to T37338: Vector: List bullet icon should not be low-res (pixelated on HiDPI screens).

@Paladox, please do not use the updated icon; it shows too big on the rest. The iOS issue will have to be resolved in another way.

Feb 8 2015, 9:48 AM · Patch-For-Review, Vector

Feb 5 2015

Edokter added a comment to T87077: Change 0.875em font size to 1em.

Historically, 16px was the initial fontsize when browsers first came out. The default font was Times/serif, which has a lower x-height, and 16px was good.

Feb 5 2015, 8:19 AM · Vector, UI-Standardization

Feb 4 2015

Edokter added a comment to T18691: RFC: Section header "share" link.
  1. The [edit] link used to be all the way on the right edge of the page. It now sits right next to the header text; it is no longer floating. (There is a gadget on enwiki to move them to the right again.)
  2. I missed that. I was thinking about a link (chain) symbol as used by the Headanchor gadget.
  3. Multiple floating inline elements in the header will sit next to eachother wihtout getting in eachothers way
Feb 4 2015, 4:14 PM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface
Edokter added a comment to T18691: RFC: Section header "share" link.

@polybuildr, making the header a link was not a good idea, so forget that.

Feb 4 2015, 11:50 AM · Readers-Web-Backlog (Tracking), Tech-Ambassadors, User-Jdlrobson, Platform Team Workboards (Clinic Duty Team), TechCom-RFC, Design, MediaWiki-Interface