Page MenuHomePhabricator
Feed Advanced Search

Jun 2 2021

Shubh1815 added a comment to T237517: Update 'Sent' status to 'Finalized'.

Thanks @Scardenasmolinar and @Samwalton9 for helping, its working now.

Jun 2 2021, 7:31 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform

May 30 2021

Shubh1815 added a comment to T237517: Update 'Sent' status to 'Finalized'.

I am getting this error, when i try to run migrations.

May 30 2021, 12:31 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform

May 28 2021

Shubh1815 added a comment to T237517: Update 'Sent' status to 'Finalized'.

Hey @Samwalton9, I am getting this error after setting up the project, can you help me?

May 28 2021, 9:23 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform

May 27 2021

Shubh1815 claimed T237517: Update 'Sent' status to 'Finalized'.

Will raise a PR on this soon.

May 27 2021, 4:45 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Mar 18 2021

Shubh1815 added a comment to T237517: Update 'Sent' status to 'Finalized'.

Okay

Mar 18 2021, 1:34 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
Shubh1815 claimed T237517: Update 'Sent' status to 'Finalized'.

I want to work on this issue. So, I was thinking of overriding the "get_status_display" method, and checking the authorization method of the partner and return the status accordingly. Will that be okay??

Mar 18 2021, 11:03 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Feb 26 2021

Shubh1815 added a comment to T245270: Stop using external Javascript hosting.

Thanks @Scardenasmolinar, its working now. Also, can you explain how rebasing the branch fixed it?

Feb 26 2021, 8:42 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Feb 24 2021

Shubh1815 added a comment to T245270: Stop using external Javascript hosting.

Hey @Samwalton9, I am getting this error when I run tests, and I am not able to figure out why, as I haven't changed any code after I made the PR and before creating the PR I had ran the tests and it didn't gave any error at that time.

Feb 24 2021, 3:17 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Feb 21 2021

Shubh1815 added a comment to T275042: Reword application renewal string.

PR: https://github.com/WikipediaLibrary/TWLight/pull/625

Feb 21 2021, 1:32 PM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform

Feb 19 2021

Amire80 awarded T275045: Update blocktrans to blocktrans trimmed for homepage strings a Love token.
Feb 19 2021, 8:20 AM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform
Shubh1815 added a comment to T245270: Stop using external Javascript hosting.

Do I still need to do anything in this PR?

Feb 19 2021, 6:07 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Feb 18 2021

Shubh1815 claimed T275042: Reword application renewal string.
Feb 18 2021, 7:33 AM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform
Shubh1815 added a comment to T275045: Update blocktrans to blocktrans trimmed for homepage strings.

PR: https://github.com/WikipediaLibrary/TWLight/pull/617

Feb 18 2021, 5:41 AM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform

Feb 17 2021

Shubh1815 claimed T275045: Update blocktrans to blocktrans trimmed for homepage strings.

I will raise a PR on this soon.

Feb 17 2021, 6:37 PM · The-Wikipedia-Library (Kanban), good first task, Library-Card-Platform

Feb 1 2021

Shubh1815 added a comment to T255995: Squash Django migration files.

Tag and TextFieldTag aren't imported in the squashed resources migration file. Did the build failed just due to that or there are some other issues as well?

Feb 1 2021, 3:31 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
Shubh1815 added a comment to T255995: Squash Django migration files.

Why did the build failed??

Feb 1 2021, 2:50 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
Shubh1815 added a comment to T255995: Squash Django migration files.

PR: https://github.com/WikipediaLibrary/TWLight/pull/602

Feb 1 2021, 2:27 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform
Shubh1815 added a comment to T255995: Squash Django migration files.

I was getting Circular Dependency Error if I squash the resources migrations into one file. So, instead I squashed resources migrations 0001 to 0062 into one file and 0063 to 0084 into another file, to avoid Circular Dependancy Error. Is that okay?

Feb 1 2021, 1:05 PM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Jan 31 2021

Shubh1815 added a comment to T245270: Stop using external Javascript hosting.

Pull Request: https://github.com/WikipediaLibrary/TWLight/pull/600

Jan 31 2021, 8:10 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform
Shubh1815 claimed T245270: Stop using external Javascript hosting.

I will raise a PR on this soon.

Jan 31 2021, 7:35 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform
Shubh1815 added a comment to T255995: Squash Django migration files.

Can I create a PR on this, if nobody is currently working on this?

Jan 31 2021, 7:05 AM · The-Wikipedia-Library (Kanban), Library-Card-Platform

Sep 15 2020

Shubh1815 added a watcher for Library-Card-Platform: Shubh1815.
Sep 15 2020, 12:58 PM