Page MenuHomePhabricator
Feed Advanced Search

Today

jhathaway claimed T310822: Create a Prometheus exporter for Znuny metrics of interest to the VRT.
Tue, Jul 5, 4:42 PM · Znuny
jhathaway added a comment to T310822: Create a Prometheus exporter for Znuny metrics of interest to the VRT.

@akosiaris thanks for the link to the sql exporter, I'll try playing around with one and see what type of metrics I can expose.

Tue, Jul 5, 4:42 PM · Znuny
jhathaway updated the task description for T310822: Create a Prometheus exporter for Znuny metrics of interest to the VRT.
Tue, Jul 5, 4:30 PM · Znuny

Thu, Jun 16

jhathaway changed the status of T310836: Upgrade Exim to 4.96 from Open to Stalled.

This is stalled until 4.96 is available in Debian.

Thu, Jun 16, 8:46 PM · Infrastructure-Foundations, SRE, Mail
jhathaway changed the status of T310836: Upgrade Exim to 4.96, a subtask of T309238: 2022-05-09 Exim BDAT Errors incident, from Open to Stalled.
Thu, Jun 16, 8:46 PM · Infrastructure-Foundations, SRE, Mail, Wikimedia-Incident
jhathaway created T310836: Upgrade Exim to 4.96.
Thu, Jun 16, 8:45 PM · Infrastructure-Foundations, SRE, Mail
jhathaway closed T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001 as Resolved.

This has now been fixed upstream, https://git.exim.org/exim.git/commit/462e2cd30. We will keep chunking disabled until we upgrade to 4.96 which will include the fix.

Thu, Jun 16, 8:44 PM · SRE, Mail, Infrastructure-Foundations
jhathaway closed T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001, a subtask of T309238: 2022-05-09 Exim BDAT Errors incident, as Resolved.
Thu, Jun 16, 8:43 PM · Infrastructure-Foundations, SRE, Mail, Wikimedia-Incident
jhathaway renamed T310822: Create a Prometheus exporter for Znuny metrics of interest to the VRT from Create a Prometheus exporter for Znuny to Create a Prometheus exporter for Znuny metrics of interest to the VRT.
Thu, Jun 16, 5:06 PM · Znuny
jhathaway created T310822: Create a Prometheus exporter for Znuny metrics of interest to the VRT.
Thu, Jun 16, 5:05 PM · Znuny

Tue, Jun 7

jhathaway updated the title for P29437 VRT 60 day domain stats from untitled to VRT 60 day domain stats.
Tue, Jun 7, 9:42 PM

Mon, Jun 6

jhathaway edited P29437 VRT 60 day domain stats.
Mon, Jun 6, 1:54 PM
jhathaway created P29437 VRT 60 day domain stats.
Mon, Jun 6, 1:53 PM

Jun 2 2022

jhathaway added a project to T309813: SPF record for wmflabs.org defaults to ?all: Cloud-Services.
Jun 2 2022, 8:49 PM · Cloud-Services
jhathaway created T309813: SPF record for wmflabs.org defaults to ?all.
Jun 2 2022, 8:48 PM · Cloud-Services

May 26 2022

jhathaway closed T309237: Determine why Exim BDAT error messages are not counted as bounces by mtail as Resolved.

@herron I did a little log analysis and from what I can tell the errors from this incident were drowned out by the continual errors we get that match the mtail regex. I am not sure we can improve our detection of this type of event by tweaking these rules, so I am going to close this ticket for now, as we at least understand the cause.

May 26 2022, 8:16 PM · Sustainability (Incident Followup), Infrastructure-Foundations, Mail
jhathaway closed T309237: Determine why Exim BDAT error messages are not counted as bounces by mtail, a subtask of T309238: 2022-05-09 Exim BDAT Errors incident, as Resolved.
May 26 2022, 8:16 PM · Infrastructure-Foundations, SRE, Mail, Wikimedia-Incident
jhathaway claimed T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001.
May 26 2022, 7:06 PM · SRE, Mail, Infrastructure-Foundations
jhathaway added a comment to T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001.

I sent a message to the Exim mailing list, https://www.mail-archive.com/exim-users@exim.org/msg57216.html.

May 26 2022, 7:06 PM · SRE, Mail, Infrastructure-Foundations

May 25 2022

jhathaway added a comment to T309237: Determine why Exim BDAT error messages are not counted as bounces by mtail.

Bounces relating to these 503s should/would originate from the sending mail system as opposed to the wikimedia mx since these errored out midway through the incoming SMTP session, and the connection was closed before the message was accepted into queue of the mx.

May 25 2022, 8:51 PM · Sustainability (Incident Followup), Infrastructure-Foundations, Mail
jhathaway updated the task description for T309238: 2022-05-09 Exim BDAT Errors incident.
May 25 2022, 7:25 PM · Infrastructure-Foundations, SRE, Mail, Wikimedia-Incident
jhathaway added a parent task for T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001: T309238: 2022-05-09 Exim BDAT Errors incident.
May 25 2022, 7:22 PM · SRE, Mail, Infrastructure-Foundations
jhathaway added a subtask for T309238: 2022-05-09 Exim BDAT Errors incident: T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001.
May 25 2022, 7:22 PM · Infrastructure-Foundations, SRE, Mail, Wikimedia-Incident
jhathaway added a subtask for T309238: 2022-05-09 Exim BDAT Errors incident: T309237: Determine why Exim BDAT error messages are not counted as bounces by mtail.
May 25 2022, 7:21 PM · Infrastructure-Foundations, SRE, Mail, Wikimedia-Incident
jhathaway added a parent task for T309237: Determine why Exim BDAT error messages are not counted as bounces by mtail: T309238: 2022-05-09 Exim BDAT Errors incident.
May 25 2022, 7:21 PM · Sustainability (Incident Followup), Infrastructure-Foundations, Mail
jhathaway created T309238: 2022-05-09 Exim BDAT Errors incident.
May 25 2022, 7:21 PM · Infrastructure-Foundations, SRE, Mail, Wikimedia-Incident
jhathaway claimed T309237: Determine why Exim BDAT error messages are not counted as bounces by mtail.
May 25 2022, 7:03 PM · Sustainability (Incident Followup), Infrastructure-Foundations, Mail
jhathaway updated the task description for T309237: Determine why Exim BDAT error messages are not counted as bounces by mtail.
May 25 2022, 7:02 PM · Sustainability (Incident Followup), Infrastructure-Foundations, Mail
jhathaway created T309237: Determine why Exim BDAT error messages are not counted as bounces by mtail.
May 25 2022, 7:01 PM · Sustainability (Incident Followup), Infrastructure-Foundations, Mail

May 9 2022

jhathaway added a comment to T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001.
  • Please first remove the google servers from the callout cache, and you may also consider examining what caused callout failure on that host. It defintely shouldn't be there. An unexpected rejection may mess up google's SMTP side and may invalidate already seen chunking status, which would in turn invalidate BDATs. (In fact it might be our own server involved in the callout, if it was a wikimedia.org source!)
May 9 2022, 8:54 PM · SRE, Mail, Infrastructure-Foundations
jhathaway added a comment to T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001.

First messages in the logs appeared on May 4th:

May 9 2022, 3:17 PM · SRE, Mail, Infrastructure-Foundations
jhathaway added a comment to T307873: [mitigated] Google returning 503 error when delivering to mx1001 and mx2001.

@jbond I can't think of any recent changes that would have introduced this behavior. The boxes were rebooted on Friday to catch the latest kernel update. I'll start investigating.

May 9 2022, 1:46 PM · SRE, Mail, Infrastructure-Foundations

May 6 2022

jhathaway closed T307573: Request to add user fkaelin to analytics-platform-eng-admins group as Resolved.

Commit has been merged in, please reopen if there are any problems, thanks!

May 6 2022, 3:24 PM · SRE, Generated Data Platform, SRE-Access-Requests

May 5 2022

jhathaway updated the task description for T307573: Request to add user fkaelin to analytics-platform-eng-admins group.
May 5 2022, 10:14 PM · SRE, Generated Data Platform, SRE-Access-Requests
jhathaway added a comment to T307737: Grant Access to PII in Superset for HMonroy and Dmaza.

Thanks @HMonroy from my read of T296161 it is ultimately the same as T283190, both add the user to the analytics-privatedata-users group. If you could use the template, twice, that would be appreciated, as I can then ensure the boxes are checked for both accounts.

May 5 2022, 10:05 PM · SRE-Access-Requests, SRE, Community-Tech
jhathaway moved T307737: Grant Access to PII in Superset for HMonroy and Dmaza from Untriaged to Awaiting User Input on the SRE-Access-Requests board.
May 5 2022, 8:07 PM · SRE-Access-Requests, SRE, Community-Tech
jhathaway claimed T307573: Request to add user fkaelin to analytics-platform-eng-admins group.
May 5 2022, 8:05 PM · SRE, Generated Data Platform, SRE-Access-Requests
jhathaway claimed T307737: Grant Access to PII in Superset for HMonroy and Dmaza.
May 5 2022, 8:04 PM · SRE-Access-Requests, SRE, Community-Tech
jhathaway added a comment to T307737: Grant Access to PII in Superset for HMonroy and Dmaza.

@HMonroy happy to help grant superset access, but I am not sure exactly how to do that? This ticket, T283190, appears similar, is that what group you all need? Also, would you kindly use the access template so as to keep these requests consistent, https://phabricator.wikimedia.org/maniphest/task/edit/form/8/

May 5 2022, 8:04 PM · SRE-Access-Requests, SRE, Community-Tech
jhathaway moved T307573: Request to add user fkaelin to analytics-platform-eng-admins group from Untriaged to Awaiting User Input on the SRE-Access-Requests board.
May 5 2022, 7:49 PM · SRE, Generated Data Platform, SRE-Access-Requests
jhathaway added a comment to T307573: Request to add user fkaelin to analytics-platform-eng-admins group.

@WDoranWMF patch cut, if you could explicitly approve as a comment that would be appreciated, though I take your authoring of the ticket as tacit approval.

May 5 2022, 7:48 PM · SRE, Generated Data Platform, SRE-Access-Requests
jhathaway updated the task description for T307573: Request to add user fkaelin to analytics-platform-eng-admins group.
May 5 2022, 7:44 PM · SRE, Generated Data Platform, SRE-Access-Requests
jhathaway closed T307582: Grant Access to ldap/wmf for Ariel Gutman as Resolved.

@AGutman-WMF you have been added to the wmf group, please reopen if there are any issues!

May 5 2022, 7:17 PM · SRE, LDAP-Access-Requests
jhathaway added a member for WMF-NDA: AGutman-WMF.
May 5 2022, 7:16 PM

May 4 2022

jhathaway added a comment to T307573: Request to add user fkaelin to analytics-platform-eng-admins group.

@WDoranWMF happy to help on this access request. Would you be so kind as to update this ticket with the access request form details, https://phabricator.wikimedia.org/maniphest/task/edit/form/8/

May 4 2022, 10:29 PM · SRE, Generated Data Platform, SRE-Access-Requests
jhathaway added a comment to T307582: Grant Access to ldap/wmf for Ariel Gutman.

@AGutman-WMF I assume you don't need shell access?

May 4 2022, 9:34 PM · SRE, LDAP-Access-Requests

May 3 2022

jhathaway added a comment to T303464: Disable GeoIP Legacy Download / Identify all users of legacy (v1) GeoIP datasets and inform them of the need to switch to GeoIP2 dataset.

@Dzahn that makes sense, so I assume it is okay that we also received a notice saying the invoice has lapsed, since these downloads are no longer needed?

May 3 2022, 3:45 PM · Trust-and-Safety, serviceops, Traffic, SRE, Data-Engineering
jhathaway added a comment to T303464: Disable GeoIP Legacy Download / Identify all users of legacy (v1) GeoIP datasets and inform them of the need to switch to GeoIP2 dataset.

@Dzahn I mentioned over email, but I thought I would add a note here as well, we are still receiving alerts, last one was on May 2, stating that we are downloading the legacy database, is that expected?

May 3 2022, 3:04 PM · Trust-and-Safety, serviceops, Traffic, SRE, Data-Engineering

Apr 26 2022

jhathaway added a comment to T306860: Videoscalers fail health checks while CPU is maxed.

Another option would be to use cpu pinning via taskset(1), where ffmpeg is assigned to cpus 1-N and cpu 0 is left free to service health checks.

Apr 26 2022, 8:12 PM · Sustainability (Incident Followup), WMF-JobQueue, serviceops, SRE

Apr 21 2022

jhathaway claimed T305567: MX: increasing disk space.
Apr 21 2022, 2:16 PM · Mail, SRE, Infrastructure-Foundations
jhathaway triaged T305567: MX: increasing disk space as Medium priority.
Apr 21 2022, 2:16 PM · Mail, SRE, Infrastructure-Foundations

Apr 18 2022

jhathaway added a comment to T211750: Introduce Python code formatters usage.

thanks @Volans for the additional detail and I am happy to see that folks have been persistently chipping away at some of these blockers.

Apr 18 2022, 6:46 PM · Infrastructure-Foundations, User-Kormat, tox-wikimedia, Patch-For-Review, SRE, SRE-tools

Apr 14 2022

jhathaway added a comment to T211750: Introduce Python code formatters usage.

Although there are no doubt that an automatic formatter is of great help, there are also a bunch of issues to take into account, for example:

Apr 14 2022, 9:02 PM · Infrastructure-Foundations, User-Kormat, tox-wikimedia, Patch-For-Review, SRE, SRE-tools
jhathaway added a comment to T305676: Validate all yaml files in puppet.git.

I think having a syntax validity check would be a great first start. I think using yamllint, a ruby script or a short python script would work well:

Apr 14 2022, 8:47 PM · Puppet, SRE, Infrastructure-Foundations
jhathaway added a comment to T294564: Migrate Foundations Prometheus alerts to AlertManager.

+1 to exclude list, thank you for digging out the root cause. Just as an historical/contextual note I can't remember at the minute why we went with our implementation of smartmon.py (it is possible it wasn't available at the time though). Having said that, nowadays it might make sense to move to upstream' smartmon (100% out of scope for this task, but putting it out there)

Apr 14 2022, 7:24 PM · Observability-Alerting

Apr 13 2022

jhathaway closed T305962: Exim emitting warnings about tainted filenames as Resolved.

merged!

Apr 13 2022, 7:00 PM · SRE, Mail, Infrastructure-Foundations
jhathaway added a comment to T211750: Introduce Python code formatters usage.

Are we ready to consider running black on our puppet repo?

Apr 13 2022, 6:58 PM · Infrastructure-Foundations, User-Kormat, tox-wikimedia, Patch-For-Review, SRE, SRE-tools

Apr 12 2022

jhathaway added a comment to T305962: Exim emitting warnings about tainted filenames.

Mailing list discussion, https://www.mail-archive.com/exim-users@exim.org/msg57122.html

Apr 12 2022, 7:28 PM · SRE, Mail, Infrastructure-Foundations
jhathaway created T305962: Exim emitting warnings about tainted filenames.
Apr 12 2022, 4:16 PM · SRE, Mail, Infrastructure-Foundations
jhathaway closed T280472: Figure out if we can remove legacy domain support for mailing lists as Resolved.

Emails are now being rejected, gmail presents rejections like this:

2022-04-11-162926_1181x740_scrot.png (740×1 px, 74 KB)

Apr 12 2022, 2:32 PM · SRE, Wikimedia-Mailing-lists

Apr 8 2022

jhathaway added a comment to T294564: Migrate Foundations Prometheus alerts to AlertManager.

@jhathaway I saw the alert firing today, looks like it is working as expected so that's great! I believe the old icinga alert can be removed now (i.e. both are firing e.g. for aqs1007 ATM)

Apr 8 2022, 7:49 PM · Observability-Alerting
jhathaway added a comment to T305567: MX: increasing disk space.

ok, thanks, I'll rotate it manually and plan on embiggening the existing
hosts.

Apr 8 2022, 1:41 PM · Mail, SRE, Infrastructure-Foundations

Apr 6 2022

jhathaway added a comment to T305567: MX: increasing disk space.

I rotated the log file and then compressed it on another host for this specific incident, but it was cumbersome. I think we should definitely embiggen the disks for the new Postfix based hosts. I am less sure if it is worth the effort for these hosts.

Apr 6 2022, 9:33 PM · Mail, SRE, Infrastructure-Foundations

Mar 31 2022

jhathaway claimed T280472: Figure out if we can remove legacy domain support for mailing lists.
Mar 31 2022, 7:10 PM · SRE, Wikimedia-Mailing-lists
jhathaway added a comment to T280472: Figure out if we can remove legacy domain support for mailing lists.

I did some quick analysis and it appears like the vast majority of traffic to the old addresses is spam. As an example, for the messages sent on March 29th, it appears all of them were spam:

Mar 31 2022, 7:10 PM · SRE, Wikimedia-Mailing-lists

Mar 29 2022

jhathaway added a comment to T304965: Security Issue Access Request for jhathaway.

@Dsharpe thanks!

Mar 29 2022, 7:07 PM · SecTeam-Processed, Security-Team, Security
jhathaway created T304965: Security Issue Access Request for jhathaway.
Mar 29 2022, 3:36 PM · SecTeam-Processed, Security-Team, Security

Mar 25 2022

jhathaway claimed T236954: Hieradata yaml style checking.
Mar 25 2022, 2:28 PM · Infrastructure-Foundations, Patch-For-Review, Puppet, SRE, User-jbond

Mar 16 2022

jhathaway closed T302423: Where to Put Community Modules? as Resolved.

Community modules have now been moved to vendor_modules, thanks everyone for the discussion & feedback.

Mar 16 2022, 4:53 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway closed T302423: Where to Put Community Modules?, a subtask of T265138: Work required to prepare for puppet 6, as Resolved.
Mar 16 2022, 4:52 PM · Infrastructure-Foundations, Patch-For-Review, User-jbond, SRE, Puppet

Mar 14 2022

jhathaway added a comment to T302423: Where to Put Community Modules?.

There seems to be some coalescing around moving vendored modules into their own directory, here is a patch that does just that, feedback very much appreciated, https://gerrit.wikimedia.org/r/770099

Mar 14 2022, 3:27 AM · Patch-For-Review, Puppet, Infrastructure-Foundations

Mar 10 2022

jhathaway closed T286898: Setup new mirror server (mirror1001.wikimedia.org) as Resolved.
Mar 10 2022, 5:42 PM · Infrastructure-Foundations, SRE
jhathaway added a comment to T297906: Change physical label from copernicum.wikimedia.org to mirror1001.wikimedia.org.

thanks!

Mar 10 2022, 5:41 PM · ops-eqiad, Infrastructure-Foundations, DC-Ops
jhathaway claimed T302423: Where to Put Community Modules?.
Mar 10 2022, 5:18 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway claimed T302639: How should we monitor for faulty memory modules?.
Mar 10 2022, 5:18 PM · SRE Observability, Infrastructure-Foundations
jhathaway closed T299107: mx1001.wikimedia.org mail delivery timeouts as Resolved.

We are no longer seeing the timeouts after setting the sysctl net.ipv4.tcp_fastopen_blackhole_timeout_sec sysctl to 3600 which restores the setting to the same value prior to kernel
version v5.10.54.

Mar 10 2022, 5:09 PM · Infrastructure-Foundations, Mail, SRE
jhathaway closed T299107: mx1001.wikimedia.org mail delivery timeouts, a subtask of T297127: Incident: 2021-12-03 mx2001->Gmail delivery issues, as Resolved.
Mar 10 2022, 5:09 PM · SRE-OnFire (FY2021/2022-Q2), Sustainability (Incident Followup), SRE
jhathaway closed T298110: Provide an easier way to drop spam mail as Resolved.
Mar 10 2022, 5:07 PM · Infrastructure-Foundations, Mail
jhathaway closed T298727: decom sodium, a subtask of T286898: Setup new mirror server (mirror1001.wikimedia.org), as Resolved.
Mar 10 2022, 5:06 PM · Infrastructure-Foundations, SRE
jhathaway closed T298727: decom sodium as Resolved.
Mar 10 2022, 5:06 PM · Infrastructure-Foundations, SRE
jhathaway added a project to T297906: Change physical label from copernicum.wikimedia.org to mirror1001.wikimedia.org: ops-eqiad.
Mar 10 2022, 5:04 PM · ops-eqiad, Infrastructure-Foundations, DC-Ops
Legoktm awarded T300985: mirrors.wikimedia.org debian repository fails to serve packages from time to time a Orange Medal token.
Mar 10 2022, 4:09 PM · SRE
aborrero awarded T300985: mirrors.wikimedia.org debian repository fails to serve packages from time to time a Like token.
Mar 10 2022, 10:33 AM · SRE

Mar 9 2022

jhathaway closed T300985: mirrors.wikimedia.org debian repository fails to serve packages from time to time as Resolved.

@aborrero the mirrors server has now been switched to apache2 and I am unable to reproduce the error with my tests. Please reopen if you experience the issue again, thanks!

Mar 9 2022, 9:37 PM · SRE

Mar 1 2022

jhathaway added a comment to T302423: Where to Put Community Modules?.

Based on the discussion so far my inclination is that we stick with our current method of vendoring Community modules in ./modules. Though not a perfect solution, it seems to have worked well for us and the downsides are small. My personal experience with a similar setup mirrors the foundation's experience. As @akosiaris mentioned git submodules for just Community modules could be an interesting route as well, but given the scars of the last submodules experience I don't think the upsides are worth exploring at this time.

Mar 1 2022, 4:22 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway added a comment to T302423: Where to Put Community Modules?.

On a side note, I see there is a proposal of using /vendor/modules. It seems interesting and I 've never tried it, I am wondering what technical hurdles we 'd meet. Any ideas?

Mar 1 2022, 3:57 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway closed T302687: Don't move filesystem_avail_bigger_than_size icinga check to alert manager? as Resolved.
Mar 1 2022, 3:11 PM · Patch-For-Review, Observability-Alerting
jhathaway closed T302687: Don't move filesystem_avail_bigger_than_size icinga check to alert manager?, a subtask of T294564: Migrate Foundations Prometheus alerts to AlertManager, as Resolved.
Mar 1 2022, 3:10 PM · Observability-Alerting

Feb 28 2022

jhathaway added a comment to T302423: Where to Put Community Modules?.

@CDanis I had not, here is my attempt at a comparison between git submodules and subtrees

Feb 28 2022, 5:57 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway added a comment to T302687: Don't move filesystem_avail_bigger_than_size icinga check to alert manager?.

Thank you for digging up the details/history for this! I'm +1 on leaving the check in icinga, and possibly behind a conditional based on the distribution

Feb 28 2022, 2:21 PM · Patch-For-Review, Observability-Alerting

Feb 27 2022

jhathaway created T302687: Don't move filesystem_avail_bigger_than_size icinga check to alert manager?.
Feb 27 2022, 11:49 PM · Patch-For-Review, Observability-Alerting
jhathaway added a subtask for T294564: Migrate Foundations Prometheus alerts to AlertManager: T302639: How should we monitor for faulty memory modules?.
Feb 27 2022, 11:25 PM · Observability-Alerting
jhathaway added a parent task for T302639: How should we monitor for faulty memory modules?: T294564: Migrate Foundations Prometheus alerts to AlertManager.
Feb 27 2022, 11:25 PM · SRE Observability, Infrastructure-Foundations

Feb 25 2022

jhathaway created T302639: How should we monitor for faulty memory modules?.
Feb 25 2022, 10:25 PM · SRE Observability, Infrastructure-Foundations

Feb 24 2022

jhathaway added a comment to T302481: Where to put puppetlabs Core Modules.

As all the packages we need have already been packaged by debian, my view is we just go with the debian packages and close this ticket down.

Feb 24 2022, 3:31 PM · Infrastructure-Foundations, SRE, Puppet

Feb 23 2022

jhathaway added a comment to T302423: Where to Put Community Modules?.

Before commenting i would say that in my mind we have four types types of modules

  • in house modules
  • third-party modules
  • built in types which are all the types included in the puppet source tree.
  • core types which are types that puppet labs packages with the puppet-agent and labeled puppetlabs-core-$foo on puppet forge

We can ignore the built in types as they will be shipped with the puppet agent code

The puppet core types are modules that use to be part of the puppet source tree but got split out when puppet 6 was released. puppetlabs upstream package theses modules are part of the puppet-agent package, however it seems that Debian will split theses out as separate packages. Even though they are separate repos in puppet labs the fact that puppet labs have decided to bundle them with the puppet agent makes me think we should follow suite and package theses possibly even try to keep parity with the versions that puppetlabs ship in there puppet-agent packages. Further i have never needed to submit a patch to theses core types and would even argue that any such changes should be scrutinised by both us and upstream and we shouldn't allow users to so easily change something that is stable. To keep context currently this set would only include i think cron and mailaises

Feb 23 2022, 8:24 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway added a comment to T302423: Where to Put Community Modules?.

To start with I would just like to add a bit of info that we have a history of using git submodules inside the puppet repo and not liking them and then moving away from them again, which was kind of a bigger deal. So maybe not that one.

Feb 23 2022, 6:45 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway added a comment to T302423: Where to Put Community Modules?.

Feel free to edit the description and add advantages and disadvantages.

Feb 23 2022, 5:45 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway created T302423: Where to Put Community Modules?.
Feb 23 2022, 5:43 PM · Patch-For-Review, Puppet, Infrastructure-Foundations
jhathaway added a comment to T302372: prometheus-statsd-exporter failure to start due to invalid yaml config.

@fgiunchedi very sorry about the breakage, I wish I would have caught that in the review.

Feb 23 2022, 2:53 PM · SRE Observability, Infrastructure-Foundations, Puppet