Page MenuHomePhabricator
Feed Advanced Search

Thu, May 6

IKhitron added a comment to T229735: Add gadgets-edit and gadgets-definition-edit access to stewards and interface administrators.

Even so, it doesn't mean they should appear in the rest for years.

Thu, May 6, 1:27 PM · Wikimedia-Site-requests, Gadgets-2.0, MediaWiki-extensions-Gadgets
IKhitron added a comment to T229735: Add gadgets-edit and gadgets-definition-edit access to stewards and interface administrators.
In T229735#7065727, Iniquity wrote:

The question is, is it impossible to make the setting and hide these namespaces in all the wiki of the foundation for now? And then turn them back on, if necessary. No one will even notice, but this will at least reduce the load on the search filters.

Thu, May 6, 1:17 PM · Wikimedia-Site-requests, Gadgets-2.0, MediaWiki-extensions-Gadgets

Fri, Apr 30

IKhitron updated subscribers of T281346: Cannot start or resume a translation for articles with spaces or non-ascii characters in the title.
Fri, Apr 30, 10:10 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), User-notice, Patch-For-Review, Language-Team (Language-2021-April-June), ContentTranslation

Mon, Apr 12

IKhitron awarded T277363: New search widget API doesn't work in "Special:" and "File:" namespace a Like token.
Mon, Apr 12, 7:29 PM · Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Tracking), Vector, Vue.js (Vue.js Search Experience (Vector modern)), Desktop Improvements

Apr 8 2021

IKhitron renamed T279674: New Vector search interface is broken in LTR wikis with RTL interface language and vice versa from New Vector search interface is broken in LTR wikis with RTL interface language to New Vector search interface is broken in LTR wikis with RTL interface language and vice versa.
Apr 8 2021, 3:12 PM · Desktop Improvements, I18n, RTL
IKhitron updated the task description for T279674: New Vector search interface is broken in LTR wikis with RTL interface language and vice versa.
Apr 8 2021, 3:00 PM · Desktop Improvements, I18n, RTL

Mar 25 2021

IKhitron closed T277175: Local time compatibility as Invalid.

I took a time to think about this, and decided to take the @Aklapper's suggestion. While the extensions' settings number as I asked will be better to me, I'm sure that most of the users will prefer the time zone in wiki settings. So, I've created T278440 and I'm closing this one.

Mar 25 2021, 2:51 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T278440: Local time compatibility.
Mar 25 2021, 2:49 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Mar 16 2021

IKhitron changed the subtype of T277545: Avoid updating cached timestamp from "Task" to "Bug Report".
Mar 16 2021, 3:41 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T277545: Avoid updating cached timestamp.
Mar 16 2021, 3:41 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274720: Remove redundant message "sites with changes".

Absolutely.

Mar 16 2021, 12:07 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron added a comment to T274720: Remove redundant message "sites with changes".

@DannyS712, something's wrong. Looks like this merge brokes the structure when there are site sites without changes, they appear in a list without any collapsing or collapsable.

Mar 16 2021, 2:45 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MediaWiki-extensions-GlobalWatchlist, User-DannyS712

Mar 11 2021

IKhitron added a comment to T277175: Local time compatibility.

BTW, Danny, if you do think it's better to use the Meta local timezone, please decline this task, I'll create another one with accordand description.

Mar 11 2021, 9:55 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T277175: Local time compatibility.

I just do not expect from international site to work like it's local. And the global list for me is a part of my local wiki, as before, with irrelevant address, not a part of Meta. But again, it's just me.

Mar 11 2021, 9:42 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T277175: Local time compatibility.

Because Meta is not supposed to be a local wiki for my local timezone, but it's just me. If Danny prefers, using the Meta value could be the second best for most of users that do have their local time there. In this case I will definitely use my local zone on Meta for this purpose.

Mar 11 2021, 9:35 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T277175: Local time compatibility.

Is this a request to add custom timezone support for the Global Watchlist only?

This will be the result.

Special:Preferences#mw-prefsection-rendering already offers to set the "Time zone" in the "Time offset" area, why not respect that setting instead?

Because the list is on Meta, it can't respect or even recognize this value for the user's home wiki.

Mar 11 2021, 7:20 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T277175: Local time compatibility.

It is not a bug, so there are no "actual problems". Only a feature to help 99% of users that do not live in Greenwich timezone to use the product without the same calculations of what does this timestump actually mean at each line.

Mar 11 2021, 7:02 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron updated the task description for T277175: Local time compatibility.
Mar 11 2021, 2:25 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron changed the subtype of T277175: Local time compatibility from "Task" to "Feature Request".
Mar 11 2021, 2:25 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T277175: Local time compatibility.
Mar 11 2021, 2:24 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron changed the subtype of T277172: Add an hr line to split the new edits. from "Task" to "Feature Request".
Mar 11 2021, 1:51 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a project to T277172: Add an hr line to split the new edits.: MediaWiki-extensions-GlobalWatchlist.
Mar 11 2021, 1:50 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T277172: Add an hr line to split the new edits..
Mar 11 2021, 1:50 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Mar 8 2021

IKhitron added a comment to T275636: Use page id for edits grouping.

Mar 8 2021, 1:38 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T275636: Use page id for edits grouping.

I already described the steps. The settings are to see everything. Grouped. No live updates. What preferences?

Mar 8 2021, 12:33 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Mar 2 2021

IKhitron added a comment to T276195: Allow more than five wikis as projects in Global Watchlist.

Well, in 14 from 20 wikis I have maximum 3 pages in each.

Mar 2 2021, 7:02 PM · Performance-Team (Radar), User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T276195: Allow more than five wikis as projects in Global Watchlist.

Just a thought. If you have two refresh buttons it may help. One to show first five wikis in the list. Another to show all. It can save a lot of performance if one presses the second button much less often.

I have no real idea how to do that, and it'll be confusing with how those work, how they interact with each other, and the live updates mode. My grant to develop the extension is currently over, and while I'm planning to request more funding for continued development and support for now this isn't a priority.

Tell if you change your mind one day, I'll give full answers. Looks like it should took to implement all this for 30 minutes top.

On my device, the global watchlist takes just above 3 seconds to reload. 50 might be a bit high, but why not.

I think concerns about the time it'll take to reload might be a bit exaggerated, since if I recall all of the sites are loaded in parallel, so its based on whichever site takes the longest to load and process (for me thats enwiki) and any other sites added that don't take as long shouldn't result in a longer overall load time.

Mar 2 2021, 6:55 PM · Performance-Team (Radar), User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T276195: Allow more than five wikis as projects in Global Watchlist.

Just a thought. If you have two refresh buttons it may help. One to show first five wikis in the list. Another to show all. It can save a lot of performance if one presses the second button much less often.

Mar 2 2021, 5:54 PM · Performance-Team (Radar), User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T276195: Allow more than five wikis as projects in Global Watchlist.

I used the script with 20 wikis. Now I use it for 5 and the script for the rest.

Mar 2 2021, 12:27 PM · Performance-Team (Radar), User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron awarded T276195: Allow more than five wikis as projects in Global Watchlist a Love token.
Mar 2 2021, 12:26 PM · Performance-Team (Radar), User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Mar 1 2021

IKhitron added a comment to T276057: Bullet points visible next to top bar.

"Freezed view" is a way to freeze the top line of the screen when scrolling, you use it in the watchlist.

  1. Open the global watchlist.
  2. Wait until there will be at least 1.5 screens of edits.
  3. Scroll down a screen.
  4. You can see the top line with the buttons remains at the top of the screen, see lines X - X+... below, and also see the bullets of the lines X-2 and X-1 at side.
Mar 1 2021, 1:54 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T276057: Bullet points visible next to top bar.
Mar 1 2021, 10:38 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Feb 24 2021

IKhitron added a comment to T275636: Use page id for edits grouping.

At least for me, it is. Between the first unseen edit on this page until the last one, both with the same name.

Feb 24 2021, 5:07 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T275636: Use page id for edits grouping.

I expect not to see Y again, and all the edits of both pages see in X group, as in Special:Watchlist, this is why.
You can check over there how is it implemented.

Feb 24 2021, 4:51 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron updated the task description for T275636: Use page id for edits grouping.
Feb 24 2021, 3:40 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T275636: Use page id for edits grouping.
Feb 24 2021, 3:38 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Feb 22 2021

IKhitron added a comment to T275437: Jobs are not getting executed or executed really slowly.

This ticket is not a UBN. We've had issues with mass message before, and there's no indication of widespread jobs failures.

Feel free to deprioritize it. The graphs I linked earlier (and that are outdated, as you noted) scared me, so I preliminarily set the priority to UBN. If you think this is not UBN, no objections for decreasing the priority (or reseting to Needs Triage).

FYI: T218511 is on 3 hours (sic!) delay on Meta now.

Feb 22 2021, 11:37 PM · SRE, WMF-JobQueue
IKhitron added a comment to T275437: Jobs are not getting executed or executed really slowly.

This ticket is not a UBN. We've had issues with mass message before, and there's no indication of widespread jobs failures.

Feel free to deprioritize it. The graphs I linked earlier (and that are outdated, as you noted) scared me, so I preliminarily set the priority to UBN. If you think this is not UBN, no objections for decreasing the priority (or reseting to Needs Triage).

Feb 22 2021, 11:32 PM · SRE, WMF-JobQueue

Feb 21 2021

IKhitron added a comment to T275303: Setting the ordering of the watchlist.

@Iniquity so this should really be documented somewhere, but the order is based on the order edits are made in, and then if there are multiple edits to the same page their are displayed using the timestamp of the latest, but (I'm pretty sure) still sorted using the timestamp of the oldest. Maybe we can add an explicit sort function watchlistUtils...

Feb 21 2021, 7:37 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MediaWiki-extensions-GlobalWatchlist, User-DannyS712

Feb 20 2021

IKhitron updated the task description for T275278: Site autocomplete.
Feb 20 2021, 1:45 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron changed the subtype of T275278: Site autocomplete from "Task" to "Feature Request".
Feb 20 2021, 1:43 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron created T275278: Site autocomplete.
Feb 20 2021, 1:43 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Feb 18 2021

IKhitron added a comment to T274602: Expand/collapse button is in the wrong place when the wiki's use of RTL or LTR is different from the display language.

As you wish. For me, it will look wierd if it "jumps" from side to side on the same page.

Feb 18 2021, 9:22 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), MediaWiki-extensions-GlobalWatchlist, User-DannyS712, RTL, I18n
IKhitron added a comment to T274602: Expand/collapse button is in the wrong place when the wiki's use of RTL or LTR is different from the display language.

Just a thought. Can you put the collapse button on the line center, nevermind what is the uselang and what is the wiki? It should be much easier.

Feb 18 2021, 9:17 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), MediaWiki-extensions-GlobalWatchlist, User-DannyS712, RTL, I18n
IKhitron changed the subtype of T275159: Fire a hook after every list rebuild from "Task" to "Feature Request".
Feb 18 2021, 8:34 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron created T275159: Fire a hook after every list rebuild.
Feb 18 2021, 8:33 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712

Feb 16 2021

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Well, @DannyS712, it's on 30.

Feb 16 2021, 3:12 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Feb 14 2021

IKhitron changed the subtype of T274720: Remove redundant message "sites with changes" from "Task" to "Design".
Feb 14 2021, 12:10 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron created T274720: Remove redundant message "sites with changes".
Feb 14 2021, 12:09 AM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MediaWiki-extensions-GlobalWatchlist, User-DannyS712

Feb 12 2021

IKhitron added a comment to T274600: Api calls should specify language.

It will work better if you allow to make uselang language permanent in preferences, as I already suggested.

Feb 12 2021, 2:23 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

But, on the other hand, how can you be sure that the user does not prefer the foreign language preferences. He set them to use these wikis, including reading the diffs and the history pages.

Feb 12 2021, 1:08 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

I see. You're right.

Feb 12 2021, 12:57 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

OK. So how is this different from the current state? It does show the wikidata labels on the Meta preferences language, or overrided by uselang, doesn't it?

Feb 12 2021, 12:51 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

On which wiki? If somebody turns on a computer, opens a browser, opens the GW page on Meta, you do not know what wiki does this user prefer to work on.

Feb 12 2021, 12:40 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

I mean, how do you know which language you should use to override? How do you now that I prefer Hebrew without me saying this explicitly, for example by using uselang?

Feb 12 2021, 12:04 AM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Feb 11 2021

IKhitron added a comment to T274600: Api calls should specify language.

How can you use the language of local wiki? You do not know what is this language and can't recognize this.

Feb 11 2021, 11:57 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

Yes, I have all rtl wikis on Hebrew, ruwiki on Russion, and the rest on English. So?

Feb 11 2021, 11:46 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274600: Api calls should specify language.

As I already said, for my sake uselang is quite enough. Don't know what do you want achidve with this.

Feb 11 2021, 11:36 PM · User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron awarded T274599: Allow uncollapsing grouped results a Love token.
Feb 11 2021, 10:58 PM · MediaWiki-extensions-GlobalWatchlist, User-DannyS712
IKhitron added a comment to T274313: Need to restore RTL handling.

Confirm that it works on testwiki.

Feb 11 2021, 10:19 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

If I understand properly, I should see the results on testwiki now?

Feb 11 2021, 10:13 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

So, unfortunately, there are some errors with the train (T271344: 1.36.0-wmf.30 deployment blockers), specifically T274589: No atomic section is open (got LocalFile::lockingTransaction)
As a result, there is a chance that the train will be rolled back, switching metawiki from wmf.30 back to wmf.27. There are a number of changes to the GlobalWatchlist extension between .27 and .30 that, in my opinion, are necessary before deployment. Accordingly, per discussion in #wikimedia-operations, we won't be deploying the extension today.

However, we are still backporting the fixes for the issues identified to wmf.30, so that once the train blocker is resolved this can proceed as planned

Feb 11 2021, 10:10 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T274313: Need to restore RTL handling.

Maybe I needed a deep refresh once more. It works fine now in all cases.
On LTR interface:


On RTL interface:

Feb 11 2021, 8:38 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Are you sure? The jenkins-bot did not leave a comment this time to say it's already there, and nothing changed visually.

Feb 11 2021, 8:27 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

@DannyS712, I'm here, but where is the jenkins-bot?

Feb 11 2021, 8:11 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

I didn't think about the interaction with CSSJanus flipping stuff, since that wasn't the case for the user script.

Feb 11 2021, 5:48 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Well, can you try to change the code to

.ext-globalwatchlist-feed-site {
	/* @noflip */ text-align: left;
	/* @noflip */ direction: ltr;
}
/* Handling of rtl wikis */
div[ id^='ext-globalwatchlist-feed-site-he_' ],
div[ id^='ext-globalwatchlist-feed-site-ar_' ],
div[ id^='ext-globalwatchlist-feed-site-azb_' ],
div[ id^='ext-globalwatchlist-feed-site-ckb_' ],
div[ id^='ext-globalwatchlist-feed-site-dv_' ],
div[ id^='ext-globalwatchlist-feed-site-fa_' ],
div[ id^='ext-globalwatchlist-feed-site-glk_' ],
div[ id^='ext-globalwatchlist-feed-site-ks_' ],
div[ id^='ext-globalwatchlist-feed-site-lrc_' ],
div[ id^='ext-globalwatchlist-feed-site-mzn_' ],
div[ id^='ext-globalwatchlist-feed-site-nqo_' ],
div[ id^='ext-globalwatchlist-feed-site-pnb_' ],
div[ id^='ext-globalwatchlist-feed-site-ps_' ],
div[ id^='ext-globalwatchlist-feed-site-sd_' ],
div[ id^='ext-globalwatchlist-feed-site-ug_' ],
div[ id^='ext-globalwatchlist-feed-site-ur_' ],
div[ id^='ext-globalwatchlist-feed-site-yi_' ] {
	/* @noflip */ text-align: right;
	/* @noflip */ direction: rtl;
}

?

Feb 11 2021, 2:11 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Found the problem, trying to solve.

Feb 11 2021, 2:02 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.
Feb 11 2021, 12:55 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Ack. So I think the CSS solution just isn't going to work, instead I think we should identify whether the remote wiki is LTR or RTL, and then wrap the contents in <div dir="ltr"> or <div dir="rtl"> accordingly.

Now that I typed it, I'm not sure looking at the directionality of the wiki is right, shouldn't we look at the directionality of the user's chosen interface language on that wiki? My interface language is "English", so I would expect my watchlist to be LTR, even on RTL wikis.

Feb 11 2021, 9:00 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron updated subscribers of T274313: Need to restore RTL handling.

Thanks @DannyS712 and @Legoktm. It was definitely merged, and it's much better now, but not enough.
See how it looks on LTR wikis:


Looks fine, English on the left, Arabic on the right.
See how it looks on RTL wikis:

Looks wrong, English on the right, Arabic on the left - an opposite from needed.

Feb 11 2021, 8:05 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Feb 10 2021

IKhitron added a comment to T274313: Need to restore RTL handling.

See https://meta.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix - there are hebrew and arabic testwiki, so it should be possible to test there

Feb 10 2021, 3:45 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.
Feb 10 2021, 3:44 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

I can't merge it, since its my patch, but once its merged it can be tested on the beta cluster to confirm whether it works, and if it is we backport to testwiki.

Feb 10 2021, 1:38 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Too late. They are already here.

Feb 10 2021, 11:19 AM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T274313: Need to restore RTL handling.

Well, @DannyS712, I still have no normal F12 tools, but try to replace the line 62 selector with

.ext-globalwatchlist-feed-site

Done in patchset 3

Feb 10 2021, 11:17 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Well, @DannyS712, I still have no normal F12 tools, but try to replace the line 62 selector with

.ext-globalwatchlist-feed-site
Feb 10 2021, 1:25 AM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Feb 9 2021

IKhitron added a comment to T274313: Need to restore RTL handling.

I do not know how to do this, never tryed.
The script works fine for both cases, up to now.
Unfortunately I can't check the selectors using F12 tools by myself, probably until Thursday evening.

Feb 9 2021, 11:49 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

Well, @DannyS712, I think the patch will fix the problem of rtl wikis on ltr language page.
But I do not believe it will fix the problem of ltr wikis on rtl language page.
Please open the watchlist with uselang=he. As you can see, all the wikis are aligned to right. It should not happen without the patch. Maybe there is a problem with css selectors on the line 62, thay must align all the text to the left without the patch.

Feb 9 2021, 11:37 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

I see. Well, I haven't +2, of course, so I'll just take a look to the code and wait.

Feb 9 2021, 11:30 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

You can lie. Wait 5 seconds with the message, it will drop the number or users with irrelevant message from 100% to 1%.

Feb 9 2021, 11:28 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T274313: Need to restore RTL handling.

I don't. I know it works, it's my code. I just was affraid you can't proceed to the deployment without enough reviews.

Feb 9 2021, 11:24 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

What exactly would you have it do? That message is shown if the javascript is not loaded. If the message was removed, and users who don't have Javascript enabled tried to visit the page, it would just be blank for them...

Show this message with delay, for example.

Feb 9 2021, 11:22 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T274313: Need to restore RTL handling.

So, you don't need me for +1? If so, there is no need to call him.

Feb 9 2021, 11:21 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T274313: Need to restore RTL handling.

@DannyS712, you've asked me to review the code, but I'm not a developer on that level. May I call to a real developer that understands a lot in RTL?

Feb 9 2021, 11:18 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), I18n, RTL, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Congratulations again, @DannyS712! Three little issues that should not disturb to the deployment tomorrow, but should be fixed soon.

  1. There is a second delay between opening the link Special:GlobalWatchlist and the watchlist work start. In this time, we can see an error message that we have no Javascript on this browser. It should be removed or replaced.

The error message is only shown until the javascript is loaded, and there is no delay coded into the extension for that - as soon as your browser downloads and executes the start of the code, the message is replaced.

Still, it's a wrong behavior.

  1. You can add more than five wiki fields on Special:GlobalWatchlistSettings. The settings list should be aware of the wiki variable for maximum number of wikis.

You can add more fields, but you can't save them if there is more than 5 - its allowed to add extra fields because there is no easy way to reorder them

Yes, I know you can't save, but it will be better if you can't add. About an easy way - I suggest to remove the "Add" buttons at all, and always show maximum number of fields, empty or not. On save you read all the fields and filter out the empty ones, in any order.

  1. You've commented out the code I wrote for rtl wikis, because "CSSJanus should handle it", or something like this, but it doesn't. The GW appears wrong for rtl wikis on ltr language page and for ltr wikis on rtl language page.

Okay, I forgot to test that out - handling at T274313

Thanks.

N3: The bug for empty lists fixed, thanks a lot for this.

Feb 9 2021, 11:14 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Congratulations again, @DannyS712! Three little issues that should not disturb to the deployment tomorrow, but should be fixed soon.

  1. There is a second delay between opening the link Special:GlobalWatchlist and the watchlist work start. In this time, we can see an error message that we have no Javascript on this browser. It should be removed or replaced.
  2. You can add more than five wiki fields on Special:GlobalWatchlistSettings. The settings list should be aware of the wiki variable for maximum number of wikis.
  3. You've commented out the code I wrote for rtl wikis, because "CSSJanus should handle it", or something like this, but it doesn't. The GW appears wrong for rtl wikis on ltr language page and for ltr wikis on rtl language page.

N3: The bug for empty lists fixed, thanks a lot for this.

Feb 9 2021, 10:46 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Feb 6 2021

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

since my comment above I actioned the TODO and merged it into ext-globalwatchlist

Feb 6 2021, 11:22 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Ah, thanks for the explanation. So the group doesn't exist on twn, instead of "it's broken".
Indeed, https://translatewiki.net/wiki/Special:Translate/ext-globalwatchlist-script shows Message group: All > Recent additions.
Maybe https://translatewiki.net/wiki/Special:Translate/ext-globalwatchlist was meant which shows Message group: All > Global Watchlist instead.

Feb 6 2021, 10:04 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

The link is not broken and works here. If you think that something is broken then please always include why you think that something is broken - thanks.

Feb 6 2021, 9:40 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Yes, ext-globalwatchlist-script should also be translated (TODO they should be merged, its no longer useful to keep them separate) - I'm not sure what you mean by unlock it, you should be able to translate at https://translatewiki.net/wiki/Special:Translate/ext-globalwatchlist-script

Feb 6 2021, 8:07 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Feb 4 2021

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

@Johan, I suggest to remove the message entirely from 2021/06, because it's already Thursday evening, the issue is closed very soon, and add it, for now, in "Recent changes" of 2021/07. We can move it again, if there will no be deployment next week.

Feb 4 2021, 7:31 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Also, the message included "You can watch up to five wikis. You can watch more wikis in the future." - as far as I know there are no plans to increase the default limit or override it for WMF config, and any such change would probably need approval from the performance team first.

Feb 4 2021, 6:37 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

Yes, ext-globalwatchlist-script should also be translated (TODO they should be merged, its no longer useful to keep them separate) - I'm not sure what you mean by unlock it, you should be able to translate at https://translatewiki.net/wiki/Special:Translate/ext-globalwatchlist-script

Thanks, done.

In T260862#6798570, Legoktm wrote:

While I understand the grant said Meta only, the extension should be deployed to testwiki first for testing purposes.

Hmm, okay. Once its enabled on meta, is it okay to then disable it on testwiki?

Feb 4 2021, 2:16 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Feb 3 2021

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).
Feb 3 2021, 1:20 AM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Feb 1 2021

IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

@DannyS712, do you need us to translate MediaWiki messages on translatewiki toward the deployment?

There is nothing blocking deployment in terms of translations, but any contributions would be welcome, as always.

Feb 1 2021, 7:16 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup
IKhitron added a comment to T260862: Deploy GlobalWatchlist extension to production (Meta only).

@DannyS712, do you need us to translate MediaWiki messages on translatewiki toward the deployment?

Feb 1 2021, 7:02 PM · User-DannyS712, User-notice, MediaWiki-extensions-GlobalWatchlist, Wikimedia-extension-review-queue, Wikimedia-Extension-setup

Jan 21 2021

IKhitron added a comment to T268950: Include section name in the revision history visual diff.

Another possible solution: The line above was added for better orientation. Now, when we have section names, the line above the header is not needed any more.

Jan 21 2021, 11:34 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs
IKhitron added a comment to T268950: Include section name in the revision history visual diff.

No. What I'm saying that if you display a part of section from any reason, you should not give her a wrong name. Nkw one can understand the line is the part of the wrong section. You can show both names, it will solve the problem. Or you can find another visualization.

Jan 21 2021, 11:22 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs
IKhitron added a comment to T268950: Include section name in the revision history visual diff.

I do not say if the first name should or should not be here. I do say the second name should be here for sure, the last header before the quoted line, and it's not here at all.

Jan 21 2021, 10:40 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Patch-For-Review, Verified, Editing-team (FY2020-21 Kanban Board), VisualEditor-VisualDiffs, VisualEditor, MediaWiki-Page-history, MediaWiki-Page-diffs