@JoeWalsh Ok, thanks!
@JoeWalsh Thank you for updating the description. One part is not clear to me yer. Maybe I have missed it.
Where are the readMore items coming from? Is the app providing this list or is the JS layer expected to query that?
Yes, the saved state could be handled as part of the interaction handling, in a follow up to T219998.
Just talked with @JoeWalsh about this. For now we're planning on injecting the translated strings from the client. That should be easier to do than setting up I18N server-side and mapping accept-language header values to the right message catalog.
Probably not needed for now. The apps can request the summary and usually have it first anyways.
I don't think we would support different strings for Android vs. iOS inside the WebView content. Long-term it's probably best to ask the PMs. If this became a requirement then it would be best to have the clients pass those strings in since that would be bad for caching and storage to serve two different platform variants for each page, as you mentioned. It wouldn't be ideal to have this done by clients, though, because that would add more DOM transformation burden on clients.
Mon, Jun 17
The mobile-sections endpoint and most of the other MCS/PCS endpoints were built to support the Wikipedia apps. So, most endpoints have only been tested with *.wikipedia.org domains. (The exception is the definitions endpoint but you probably don't care about that one.)
May I ask what features of mobile-sections you are most interested in and are the reason for not using Parsoid directly?
I hasn't been deployed yet. Should be today, though.
Fri, Jun 14
Thu, Jun 13
Wed, Jun 12
Not sure what level this should be best resolved. My guess is probably Parsoid or upstream from that.
Parsoid also 404s: https://en.wikipedia.org/api/rest_v1/page/html/User:JoeWalsh_(WMF)
The reason why I mentioned mobile-html and the other PCS endpoints is that those will replace mobile-sections in the future.
Tue, Jun 11
Mon, Jun 10
@Sharvaniharan @NHarateh_WMF Is this used by the apps by itself (just collapseTables)? If so how or where is it used? This functionality is exposed by the setMulti() function which should be called when a page loads.
Having a separate call for this, when we cannot reasonably assume what the state of the table collapsing is would require some refactoring work. That's why I wanted to check first if this is even needed as a stand-alone function.
Yes. The reason is that ChangeProp doesn't know to update /page/media when these kinds of changes happen. I agree that we should consider separating out this information into separate endpoints if this is info that is only needed by the editing aspect.
Fri, Jun 7
I think we'd like this is for all PCS endpoints (mobile-sections, mobile-html, and related PCS JSON endpoints)
Services team, could we add MCS for WikiSpecies?
Thu, Jun 6
Wed, Jun 5
+1 what @Mholloway said about beta cluster already being covered by our deploy procedure. I do find the appservice useful and would like to keep it. Most of the feed endpoints are not useful/testable in beta cluster unfortunately. We need access to production pages, which appservice allows.
Thu, May 30
Wed, May 29
Possibly related to T174986.
Fri, May 24
Are the values always going to be text or can they contain HTML as well? Maybe we should consider having fields like text or html, like we have in other places?
Thu, May 23
FWIW, display: block is used in several places of the CSS inheritance tree in this case, even in the inline style. The other places are mostly originating from MinervaNeue.
Now it's up to services to fix service-runner. I'm think other service-runner based projects will run into this as well if not fixed soon.
Wed, May 22
Tue, May 21
Should crashes on appservice.wmflabs.org even be reported in Logstash?
May 17 2019
I think it would help if there was at least some Varnish caching for a certain amount of time but I guess that editing might have more issues with that than PCS.
May 16 2019
No objection, as long as we can have the same port in all environments (local dev, beta, production, mwvagrant, ...) if there is such a thing as an exposed port in Kubernetes.
(I think it adds more burden if the ports of the same service are different per environment. Example: In MCS we use 6927 for local development, but 8888 on the production machines.)
May 14 2019
Thank you @NHarateh_WMF. That sounds useful enough to expose it. The issue is that we already have a callback for the setup functionality. I guess I'll make a parameter object which can hold multiple callback functions.
In CollapseTable.setupEventHandling() is the footerDivClickCallback used by iOS or Android? Just wondering if that should be exposed.
May 9 2019
@phuedx Yes, that is correct. I've mainly brought it up since you are doing various refactoring, and it might fit into the theme. :)
May 8 2019
Keeping mobile-sections with the rest of PCS makes sense to me. Thank you for preserving the git history. The rest is nice to have and not necessarily blocking.
The lexeme work sounds promising. (That would be a big enough change to warrant at least a major version bump if not a new endpoint.)
Even if we removed the functionality in the app we would have to keep the endpoint running for a bit for older versions of the Android app.
This task might also be a reminder to look into definition alternatives, i.e. if the Android OS provides one.
May 7 2019
Moving out the feed stuff sounds like a reasonable approach to me. I'm just not sure if we really should be starting with a brand new repo. Have you considered using a clone so we can keep the Git history?
Some of the libraries are shared between mobile-sections and the PCS endpoints. We may consider creating an npm library for sharing those if it make sense to do so.
Before we move code to other repos I think it might be beneficial to make sure the OpenAPI spec is merged and some other code cleanup is done. That could be updating of dependencies, esp. eslint configs, a convention for unit test file names.
We could start out with moving easily identifiable files and subfolders into different buckets, at least for the lib and test. Probably the routes could be done as well.
May 6 2019
May 4 2019
Reproduced with https://en.wikipedia.org/api/rest_v1/page/mobile-html/Windows_10_version_history on desktop browser and running pagelib.ThemeTransform.setTheme(document, pagelib.ThemeTransform.THEME.BLACK) in the console.
May 3 2019
I see now. I forgot to close the table earlier.