Our list of planned components has separate entries for a "Tooltip" and "Popup/Popover" component. As I mentioned in T340456#9482792, I worry this task conflates the two. The immediate need for a Tooltip component is to unblock T338282: Label: Add tooltip, which would be used by Wikidata's Query Builder and for Community Configuration 2.0. As I understand it, these are pretty simple use cases where all that's needed is providing brief supplementary information. Whether it appears only on hover or can also be activated through some other event is something I leave to the designers based on the need for touchscreen support / accessibility reasons.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Yesterday
Thu, Apr 18
@Jdlrobson just a note, since I saw you comment on it in the patch, some of the tokens were indeed intentionally left the same between light and dark mode. Worth having @egardner and @DTorsani-WMF review though.
In T360845#9728068, @Jdlrobson wrote:Minerva+Vector get these styles directly from Codex and they don't seem to be applying on https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&oldid=612901&minervanightmode=1 ?
Is this still a relevant request if the steps outlined in T354889#9720761 (folding the experimental build into the main build) are complete?
Wed, Apr 17
The latest Codex release went out and includes the dark mode decision tokens. I think once the experimental build is folded into the main build as described in T354889#9720761 and Minerva + Vector use the tokens from Codex, this will be fixed.
I don't think we have tickets set up for this yet but once we do I can share them here.
There's agreement amongst the Design-System-Team designers that these should be tokens that come from Codex. Assigning back to @DTorsani-WMF to finalize on the token names.
@mwilliams @bmartinezcalvo this is a duplicate of T360154. Can we pick one and consolidate them? Whichever one sticks around should be a subtask of T303320. Thank you!
Tue, Apr 16
@Jdlrobson the new colors Derek is referencing were added as part of T360341, which is set to be included in the Codex release going out today, so they are technically not there yet. The patch is https://gerrit.wikimedia.org/r/c/design/codex/+/1015983. Note that in order to increase the contrast, the colors that are changing are not the link colors but rather the background colors of the messages in dark mode.
The next step here is for Design-System-Team to confirm we are adding new decision tokens to Codex for diff-related colors. Assuming we are, they also need to be added and made available for use in night mode.
Mon, Apr 15
Fri, Apr 12
Thu, Apr 11
To be discussed at next sprint planning.
In T356949#9705332, @stjn wrote:Another argument in favour of putting everything above the input (with an example that is valid for Wikipedia, ‘Stjn’ is not required to be here, it can also just be ‘Manage passwords’ on its own):
As seen here, browsers can put various autocomplete elements below the input field, which can obscure any hints or error messages.
Okay I will check with the team to see if there are any concerns about doing this. It's just not something we've discussed before, but I can see how it's useful. The question of "stability" of icons also hasn't really come up yet.
In T361508#9694631, @Lofhi wrote:It could improves accessibility by removing arbitrary color uses to be sure to have only WCAG 2.1 AA compliant colors, verified by the WMF, for example.
Tue, Apr 9
Fri, Apr 5
Hadn't thought about this -- what's an example of how you would want to be re-using the icons in wikitext using Commons?
In T355242#9687103, @Lofhi wrote: