Page MenuHomePhabricator
Feed Search

Sep 11 2025

Surjection updated the task description for T404315: Multiblock page must not depend on possibly failing API request.
Sep 11 2025, 12:52 PM · SecTeam-Processed, Community-Tech, Multiblocks, Security
Surjection added a comment to T404315: Multiblock page must not depend on possibly failing API request.

I think the underlying DB error that caused the HTTP 502 has gone away, so yes, there probably isn't too much of a reason to keep this private anymore. I don't think it is very likely that an attacker could intentionally cause DB issues, but if they would, I doubt they would use it just to ensure that they can't get blocked.

Sep 11 2025, 12:48 PM · SecTeam-Processed, Community-Tech, Multiblocks, Security
Surjection updated the task description for T404315: Multiblock page must not depend on possibly failing API request.
Sep 11 2025, 10:16 AM · SecTeam-Processed, Community-Tech, Multiblocks, Security
Surjection updated the task description for T404315: Multiblock page must not depend on possibly failing API request.
Sep 11 2025, 10:12 AM · SecTeam-Processed, Community-Tech, Multiblocks, Security
Surjection created T404315: Multiblock page must not depend on possibly failing API request.
Sep 11 2025, 10:11 AM · SecTeam-Processed, Community-Tech, Multiblocks, Security

Aug 27 2025

Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

In principle, I agree with the decoupling. I have always found it somewhat strange that mw.ustring.upper and mw.ustring.lower are overwritten when the language module is loaded (which authors of module code have practically no control over). However, it might take some thought to figure out how to do this in a non-breaking way, or at least with appropriate warning for downstream users to update their code.

Aug 27 2025, 10:28 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto
Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

Pages using the Italian pronunciation module are also broken, e.g. https://en.wiktionary.org/wiki/Facci#Italian. Fixing all the individual modules is not the solution here, reverting the breaking change is.

Aug 27 2025, 9:51 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto
Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

Again, please list the pages with incorrect output so we can fix them. You're making pretty sweeping claims about broken pages.

Aug 27 2025, 9:46 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto
Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

No, it definitely has not been fixed. There are bound to be more modules that relied on the old behavior. This change in behavior is also entirely undocumented, and even if it were to be documented, it is still counter-intuitive to anyone who has worked on text processing in other languages.

Aug 27 2025, 9:39 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto
Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

As I already proposed, the fix should be to revert the original commit and then discuss how to proceed forward. I'm frankly puzzled that it is considered acceptable to make a breaking change of this sort and not an immediate priority to revert it when it is apparent that it causes significant breakage. I have made such breaking changes during my career and had to rather quickly come to terms with the fact that I had to revert them.

Aug 27 2025, 9:38 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto
Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

I'm sorry, but I do not agree that these are "specialist cases". Text processing is a rather common goal, and Scribunto has a variety of functions specifically to support this goal.

Aug 27 2025, 9:33 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto
Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

Language::uc() and friends are primarily meant for manipulating wikitext and titles, and NFC output in those cases seems appropriate.

Aug 27 2025, 9:20 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto
Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

Scribunto is not necessarily specifically designed for manipulating wikitext, but for generating it. There are many reasons why internal string processing would want to rely on non-normalized Unicode text.

Aug 27 2025, 9:18 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto
Surjection added a comment to T403113: Scribunto - mw.ustring.lower and mw.ustring.upper now automatically convert text to NFC, causing Module:grc-translit to fail on English Wiktionary.

Wikitext content is supposed to always be in NFC form.

Aug 27 2025, 8:54 PM · Essential-Work, Content-Transform-Team (Work In Progress), Scribunto

Aug 1 2025

Surjection added a comment to T400291: Searching with long s (ſ) character causes everything else to be interpreted as if capitalized.

In my opinion, adding a special case for long s to lowercase s is worth it even in spite of the 'technical debt' it would incur, because claſs (which is all in lowercase) redirecting to CLASS instead of class is unacceptably counter-intuitive.

Aug 1 2025, 10:56 AM · MW-1.45-notes (1.45.0-wmf.14; 2025-08-12), MediaWiki-Search, Discovery-Search (2025.07.25 - 2025.08.15)

Nov 13 2024

Surjection added a comment to T364685: CSS sanitizer refuses TemplateStyles variable assignment to border-color but does permit background-color.

For now this is intended behavior, see T361934#9692764

Nov 13 2024, 5:21 AM · Patch-For-Review, TemplateStyles, css-sanitizer

Oct 10 2024

Surjection added a comment to T376446: Enable $wgMFCollapseSectionsByDefault on English Wiktionary.

I assure you "not been developed after ten years of waiting" is far from the truth.

Oct 10 2024, 11:06 AM · Web-Team, Web-Team-Housekeeping, Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4), Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views), MobileFrontend, Wikimedia-Site-requests

Oct 8 2024

Surjection added a comment to T376446: Enable $wgMFCollapseSectionsByDefault on English Wiktionary.

is it okay to deploy the above config change, i.e. collapse all sections by default, without a MobileFrontend feature to expand sections if there’s only one section?

Oct 8 2024, 1:42 PM · Web-Team, Web-Team-Housekeeping, Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4), Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views), MobileFrontend, Wikimedia-Site-requests

Oct 4 2024

Surjection added a comment to T376446: Enable $wgMFCollapseSectionsByDefault on English Wiktionary.

Well, it is going to have to be in Mobile.js (https://en.wiktionary.org/wiki/MediaWiki:Mobile.js) to run automatically on the mobile frontend in order to get the desired behavior.

Oct 4 2024, 10:43 PM · Web-Team, Web-Team-Housekeeping, Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4), Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views), MobileFrontend, Wikimedia-Site-requests
Surjection added a comment to T376446: Enable $wgMFCollapseSectionsByDefault on English Wiktionary.

Please note I would highly recommend you don't attempt to override this behaviour with CSS or JS as the code here is pretty complex and it will be difficult to do that without impacting performance or risking future bugs when this code changes. Please do reach out for input/support if you do consider such a gadget.

Oct 4 2024, 9:11 PM · Web-Team, Web-Team-Housekeeping, Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4), Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views), MobileFrontend, Wikimedia-Site-requests
Surjection updated the task description for T376446: Enable $wgMFCollapseSectionsByDefault on English Wiktionary.
Oct 4 2024, 6:37 AM · Web-Team, Web-Team-Housekeeping, Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4), Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views), MobileFrontend, Wikimedia-Site-requests
Surjection updated the task description for T376446: Enable $wgMFCollapseSectionsByDefault on English Wiktionary.
Oct 4 2024, 6:32 AM · Web-Team, Web-Team-Housekeeping, Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4), Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views), MobileFrontend, Wikimedia-Site-requests
Surjection created T376446: Enable $wgMFCollapseSectionsByDefault on English Wiktionary.
Oct 4 2024, 6:32 AM · Web-Team, Web-Team-Housekeeping, Web-Team-Backlog-Archived (FY2024-25 Q2 Sprint 4), Readers Essential Work 2025 (WE6.3.4 Fix bugs within the reading experience across platforms for Parsoid Read Views), MobileFrontend, Wikimedia-Site-requests

Aug 9 2021

Surjection added a comment to T165935: "Lua error: not enough memory" on certain en.wiktionary pages.

If Lua on MediaWiki can't be upgraded to 5.2 or later (T178146 is stalled, with "re-evaluation in 2024"), maybe just the GC changes could be backported to 5.1, to have at least some predictable GC behaviour?

Aug 9 2021, 11:23 AM · Performance Issue, Scribunto, All-and-every-Wiktionary

Aug 8 2021

Surjection added a comment to T165935: "Lua error: not enough memory" on certain en.wiktionary pages.

There are plenty of signs that the GC is unpredictable and that this is making this issue practically impossible to solve on en.wikt's side without dropping Lua modules altogether.

Aug 8 2021, 6:40 PM · Performance Issue, Scribunto, All-and-every-Wiktionary

Jan 19 2021

Surjection added a comment to T210695: Hieroglyphs are no longer inline.

Just to note, the inline-block or inline-table 'hacks' do not work anymore, so the only way to actually solve this is to solve the core issue of <table>s causing paragraphs to be split up unless there is an outer <div> present (the resulting HTML looks as in T210695#4846093).

Jan 19 2021, 9:55 PM · Regression, WikiHiero